]> git.lizzy.rs Git - rust.git/log
rust.git
8 years agoMerge pull request #132 from birkenfeld/let_and_return
Manish Goregaokar [Tue, 11 Aug 2015 20:57:48 +0000 (02:27 +0530)]
Merge pull request #132 from birkenfeld/let_and_return

New lint: let and immediately return

8 years agonew lint for "let x = EXPR; x" at the end of functions (fixes #104)
Georg Brandl [Tue, 11 Aug 2015 20:06:30 +0000 (22:06 +0200)]
new lint for "let x = EXPR; x" at the end of functions (fixes #104)

8 years agomove NeedlessReturn pass out to its own module and rename to ReturnPass
Georg Brandl [Tue, 11 Aug 2015 19:47:34 +0000 (21:47 +0200)]
move NeedlessReturn pass out to its own module and rename to ReturnPass

8 years agoMerge pull request #130 from birkenfeld/use_help
Manish Goregaokar [Tue, 11 Aug 2015 20:05:15 +0000 (01:35 +0530)]
Merge pull request #130 from birkenfeld/use_help

types: remove almost duplicate helper function

8 years agoMerge pull request #131 from birkenfeld/readme_update
Manish Goregaokar [Tue, 11 Aug 2015 20:04:53 +0000 (01:34 +0530)]
Merge pull request #131 from birkenfeld/readme_update

README: update with recently added lints

8 years agoREADME: update with recently added lints
Georg Brandl [Tue, 11 Aug 2015 19:30:55 +0000 (21:30 +0200)]
README: update with recently added lints

8 years agotypes: remove almost duplicate helper function
Georg Brandl [Tue, 11 Aug 2015 19:25:24 +0000 (21:25 +0200)]
types: remove almost duplicate helper function

I guess "help" instead of "note" is fine as well, so we can
get rid of the extra function.

8 years agoMerge pull request #129 from birkenfeld/unwrap_lint
Manish Goregaokar [Tue, 11 Aug 2015 19:22:03 +0000 (00:52 +0530)]
Merge pull request #129 from birkenfeld/unwrap_lint

Lint for Result/Option.unwrap()

8 years agonew lint for Option.unwrap() and Result.unwrap()
Georg Brandl [Tue, 11 Aug 2015 18:53:50 +0000 (20:53 +0200)]
new lint for Option.unwrap() and Result.unwrap()

The latter is set to Allow by default (fixes #24)

8 years agomove walk_ty() to utils module and rename to walk_ptrs_ty
Georg Brandl [Tue, 11 Aug 2015 18:57:21 +0000 (20:57 +0200)]
move walk_ty() to utils module and rename to walk_ptrs_ty

8 years agoMerge pull request #127 from birkenfeld/better-helptext-if-let
Manish Goregaokar [Tue, 11 Aug 2015 19:14:51 +0000 (00:44 +0530)]
Merge pull request #127 from birkenfeld/better-helptext-if-let

better help text for "match -> if let" lint

8 years agoMerge pull request #128 from birkenfeld/whitespace-cleanup
Manish Goregaokar [Tue, 11 Aug 2015 19:06:21 +0000 (00:36 +0530)]
Merge pull request #128 from birkenfeld/whitespace-cleanup

all: whitespace cleanup

8 years agoBump to 0.0.10
Manish Goregaokar [Tue, 11 Aug 2015 18:58:46 +0000 (00:28 +0530)]
Bump to 0.0.10

8 years agoall: whitespace cleanup
Georg Brandl [Tue, 11 Aug 2015 18:22:20 +0000 (20:22 +0200)]
all: whitespace cleanup

* 4-space indentation
* no trailing whitespace
* no tabs

8 years agoMerge branch 'pr-78'
Manish Goregaokar [Tue, 11 Aug 2015 17:58:06 +0000 (23:28 +0530)]
Merge branch 'pr-78'

Conflicts:
src/lib.rs

8 years agonit
Manish Goregaokar [Tue, 11 Aug 2015 17:41:20 +0000 (23:11 +0530)]
nit

8 years agobetter help text for "match -> if let" lint
Georg Brandl [Tue, 11 Aug 2015 17:26:33 +0000 (19:26 +0200)]
better help text for "match -> if let" lint

Implements the suggestion from #87.

Changes span_help_and_lint(), which is only used for this lint,
to use fileline_help() instead of span_help() to avoid printing
the span twice.

Also adds complete suggested new code. I had to distinguish
between blocks, which need no additionals braces, and other exprs.

8 years agonew lint for unneeded return stmts
Georg Brandl [Tue, 11 Aug 2015 16:55:07 +0000 (18:55 +0200)]
new lint for unneeded return stmts

8 years agoRemove tabs and trailing whitespace from lib and misc.
Georg Brandl [Tue, 11 Aug 2015 15:02:04 +0000 (17:02 +0200)]
Remove tabs and trailing whitespace from lib and misc.

8 years agoMerge pull request #125 from Manishearth/parent
llogiq [Tue, 11 Aug 2015 13:27:19 +0000 (15:27 +0200)]
Merge pull request #125 from Manishearth/parent

added parent method, also changed match-if-let note to help

8 years agoadded parent method, also changed match-if-let note to help
llogiq [Tue, 11 Aug 2015 13:07:21 +0000 (15:07 +0200)]
added parent method, also changed match-if-let note to help

8 years agoUpdate CONTRIBUTING.md
Manish Goregaokar [Tue, 11 Aug 2015 13:05:05 +0000 (18:35 +0530)]
Update CONTRIBUTING.md

8 years agoCONTRIBUTING
Manish Goregaokar [Tue, 11 Aug 2015 13:03:56 +0000 (18:33 +0530)]
CONTRIBUTING

8 years agoUpgrade Rust to rustc 1.4.0-nightly (a5d33d891 2015-08-08) (fixes #123)
Manish Goregaokar [Sun, 9 Aug 2015 16:43:56 +0000 (22:13 +0530)]
Upgrade Rust to rustc 1.4.0-nightly (a5d33d891 2015-08-08) (fixes #123)

8 years agoMerge pull request #122 from Manishearth/strings
llogiq [Fri, 7 Aug 2015 08:02:34 +0000 (10:02 +0200)]
Merge pull request #122 from Manishearth/strings

New string_add_assign lint

8 years agowhitespace
llogiq [Fri, 7 Aug 2015 07:33:54 +0000 (09:33 +0200)]
whitespace

8 years agoNew string_add_assign lint (first part of #121), also formatting & refactoring
llogiq [Wed, 5 Aug 2015 13:10:45 +0000 (15:10 +0200)]
New string_add_assign lint (first part of #121), also formatting & refactoring

8 years agoFix crash with idents from different contexts
Manish Goregaokar [Sun, 2 Aug 2015 15:29:12 +0000 (20:59 +0530)]
Fix crash with idents from different contexts

8 years agoUpgrade to rustc 1.3.0-nightly (4d52d7c85 2015-07-30)
Manish Goregaokar [Fri, 31 Jul 2015 06:30:06 +0000 (12:00 +0530)]
Upgrade to rustc 1.3.0-nightly (4d52d7c85 2015-07-30)

8 years agoBasic framework for structured logging
Manish Goregaokar [Sun, 26 Jul 2015 14:53:11 +0000 (20:23 +0530)]
Basic framework for structured logging

9 years agoMerge pull request #117 from Manishearth/rustup
Manish Goregaokar [Thu, 16 Jul 2015 18:40:15 +0000 (00:10 +0530)]
Merge pull request #117 from Manishearth/rustup

rustup, also first time clippy was used on itself, which led to a sma…

9 years agorustup, also first time clippy was used on itself, which led to a small refactoring
llogiq [Thu, 16 Jul 2015 06:53:02 +0000 (08:53 +0200)]
rustup, also first time clippy was used on itself, which led to a small refactoring

9 years agobump to 0.0.6
Manish Goregaokar [Fri, 10 Jul 2015 14:52:15 +0000 (20:22 +0530)]
bump to 0.0.6

9 years agoMerge pull request #108 from Manishearth/refactoring
llogiq [Thu, 9 Jul 2015 15:23:59 +0000 (17:23 +0200)]
Merge pull request #108 from Manishearth/refactoring

new 'snippet' utils method, used where applicable

9 years agonew 'snippet' utils method, used where applicable
llogiq [Thu, 9 Jul 2015 15:02:21 +0000 (17:02 +0200)]
new 'snippet' utils method, used where applicable

9 years agoMerge pull request #106 from zmbush/nightly
Manish Goregaokar [Wed, 1 Jul 2015 16:32:01 +0000 (22:02 +0530)]
Merge pull request #106 from zmbush/nightly

Fix build for rustc 1.3.0-nightly (bf3c979ec 2015-06-30)

9 years agoFix build for rustc 1.3.0-nightly (bf3c979ec 2015-06-30)
Zachary Bush [Wed, 1 Jul 2015 16:21:46 +0000 (09:21 -0700)]
Fix build for rustc 1.3.0-nightly (bf3c979ec 2015-06-30)

9 years agoMerge pull request #102 from zmbush/master
llogiq [Fri, 19 Jun 2015 03:56:43 +0000 (05:56 +0200)]
Merge pull request #102 from zmbush/master

Fix build with rustc 1.2.0-nightly (20d23d8e5 2015-06-18)

9 years agoFix build with rustc 1.2.0-nightly (20d23d8e5 2015-06-18)
Zachary Bush [Thu, 18 Jun 2015 22:29:13 +0000 (15:29 -0700)]
Fix build with rustc 1.2.0-nightly (20d23d8e5 2015-06-18)

In https://github.com/rust-lang/rust/pull/26347, MacroFormat was
renamed to ExpnFormat. MacroFormat wasn't being used in
src/mut_mut.rs, so I removed it.

9 years agoMerge pull request #101 from ogham/patch-1
llogiq [Wed, 17 Jun 2015 20:09:48 +0000 (22:09 +0200)]
Merge pull request #101 from ogham/patch-1

Remove redundant 'redundant_closure' description

9 years agoRemove redundant 'redundant_closure' description
Ben S [Wed, 17 Jun 2015 17:24:31 +0000 (18:24 +0100)]
Remove redundant 'redundant_closure' description

There were two of them in the README, now there are one.

9 years agoMerge pull request #99 from Manishearth/rustup
llogiq [Mon, 15 Jun 2015 11:30:29 +0000 (13:30 +0200)]
Merge pull request #99 from Manishearth/rustup

fixed renaming of rustc::middle::ty enums

9 years agofixed renaming of rustc::middle::ty enums
llogiq [Mon, 15 Jun 2015 11:27:24 +0000 (13:27 +0200)]
fixed renaming of rustc::middle::ty enums

9 years agobump crates
Manish Goregaokar [Sat, 13 Jun 2015 17:06:06 +0000 (22:36 +0530)]
bump crates

9 years agoMerge pull request #94 from Manishearth/unicode
llogiq [Thu, 11 Jun 2015 15:10:20 +0000 (17:10 +0200)]
Merge pull request #94 from Manishearth/unicode

first unicode lint: zero_width_space

9 years agoalso included String::from in cmp_owned and fixed deprecation in test
llogiq [Thu, 11 Jun 2015 14:53:23 +0000 (16:53 +0200)]
also included String::from in cmp_owned and fixed deprecation in test

9 years agofirst unicode lint: zero_width_space
llogiq [Thu, 11 Jun 2015 09:35:00 +0000 (11:35 +0200)]
first unicode lint: zero_width_space

9 years agoMerge pull request #92 from Manishearth/inline_always
llogiq [Sun, 7 Jun 2015 10:11:14 +0000 (12:11 +0200)]
Merge pull request #92 from Manishearth/inline_always

Remove false positives on inline_always. this closes issue #84 and adds a few utils

9 years agoforgot to update utils, there are a few new s
llogiq [Sun, 7 Jun 2015 10:05:14 +0000 (12:05 +0200)]
forgot to update utils, there are a few new s

9 years agoremoved false positives from inline_always (issue #84)
llogiq [Sun, 7 Jun 2015 10:03:56 +0000 (12:03 +0200)]
removed false positives from inline_always (issue #84)

9 years agoMerge pull request #91 from michaelrutherford/master
llogiq [Sat, 6 Jun 2015 18:42:11 +0000 (20:42 +0200)]
Merge pull request #91 from michaelrutherford/master

Fixed spelling error

9 years agoFixed spelling error
Michael Rutherford [Sat, 6 Jun 2015 18:28:58 +0000 (13:28 -0500)]
Fixed spelling error

Fixed a spelling error and added a comma in the README.md file.

9 years agoMerge pull request #90 from Manishearth/bit_mask
llogiq [Sat, 6 Jun 2015 00:32:37 +0000 (02:32 +0200)]
Merge pull request #90 from Manishearth/bit_mask

fixed issue #88 in bit_mask

9 years agofixed issue #88 in bit_mask
llogiq [Sat, 6 Jun 2015 00:27:48 +0000 (02:27 +0200)]
fixed issue #88 in bit_mask

9 years agoMerge pull request #89 from Manishearth/test_extension
llogiq [Sat, 6 Jun 2015 00:22:26 +0000 (02:22 +0200)]
Merge pull request #89 from Manishearth/test_extension

extended compile-test.rs to actually observe TESTNAME ...

9 years agoextended compile-test.rs to actually observe TESTNAME environment variable and filter...
llogiq [Sat, 6 Jun 2015 00:07:48 +0000 (02:07 +0200)]
extended compile-test.rs to actually observe TESTNAME environment variable and filter tests if available

9 years agoUpdate README.md
Manish Goregaokar [Thu, 4 Jun 2015 03:45:56 +0000 (09:15 +0530)]
Update README.md

9 years agoexplained recently added lints
llogiq [Tue, 2 Jun 2015 07:23:22 +0000 (09:23 +0200)]
explained recently added lints

9 years agoMerge pull request #82 from Manishearth/collapsible_if
llogiq [Mon, 1 Jun 2015 20:52:16 +0000 (22:52 +0200)]
Merge pull request #82 from Manishearth/collapsible_if

Fixed block check, also added macro test to collapsible_if and …

9 years agofixed modules/visibility
llogiq [Mon, 1 Jun 2015 20:36:56 +0000 (22:36 +0200)]
fixed modules/visibility

9 years agomoved in_macro to (new) utils.rs
llogiq [Mon, 1 Jun 2015 20:30:34 +0000 (22:30 +0200)]
moved in_macro to (new) utils.rs

9 years agoFixed block check, also added macro test to collapsible_if and inline_always
llogiq [Mon, 1 Jun 2015 13:09:17 +0000 (15:09 +0200)]
Fixed block check, also added macro test to collapsible_if and inline_always

9 years agoMerge pull request #81 from Manishearth/len_zero
llogiq [Mon, 1 Jun 2015 12:09:20 +0000 (14:09 +0200)]
Merge pull request #81 from Manishearth/len_zero

Len zero extended with check for is_empty() (so we should no longer get false positives).

9 years agomerged upstream master
llogiq [Mon, 1 Jun 2015 11:55:55 +0000 (13:55 +0200)]
merged upstream master

9 years agonow the method lookup actually works (and I understand why! :smile:), reduces unneces...
llogiq [Mon, 1 Jun 2015 10:49:36 +0000 (12:49 +0200)]
now the method lookup actually works (and I understand why! :smile:), reduces unnecessary loops, and has a few comments

9 years agoMerge branch 'master' into len_zero
llogiq [Mon, 1 Jun 2015 05:52:22 +0000 (07:52 +0200)]
Merge branch 'master' into len_zero

9 years agoMerge pull request #68 from Manishearth/macro_expn
llogiq [Mon, 1 Jun 2015 05:44:27 +0000 (07:44 +0200)]
Merge pull request #68 from Manishearth/macro_expn

macro expn detection in mut_mut.rs

9 years agocheck for is_empty() method to get rid of false positives
llogiq [Mon, 1 Jun 2015 05:40:33 +0000 (07:40 +0200)]
check for is_empty() method to get rid of false positives

9 years agoImplements #45 - any number mod 1 will be 0
Matthew Hall [Sun, 31 May 2015 12:17:31 +0000 (13:17 +0100)]
Implements #45 - any number mod 1 will be 0

9 years agoNew lint for issue
llogiq [Sat, 30 May 2015 13:10:19 +0000 (15:10 +0200)]
New lint for issue
#72

9 years agoMerge pull request #76 from mattyhall/master
Manish Goregaokar [Fri, 29 May 2015 14:59:08 +0000 (20:29 +0530)]
Merge pull request #76 from mattyhall/master

Add lint for ifs that could be collapsed

9 years agoAdd lint for ifs that could be collapsed
Matthew Hall [Fri, 29 May 2015 14:07:34 +0000 (15:07 +0100)]
Add lint for ifs that could be collapsed

"Collapsible" ifs are ones which contain only a then block, and the then
block consists of an if that only has a then block.

9 years agomade in_macro distinguish intra-crate and extra-crate macros, as the latter have...
llogiq [Tue, 26 May 2015 11:52:40 +0000 (13:52 +0200)]
made in_macro distinguish intra-crate and extra-crate macros, as the latter have no working source (note: may fail in the face of compiler plugins doing whatever they like with spans), also one more run-pass test

9 years agoMerge pull request #71 from sourcejedi/patch-1
Manish Goregaokar [Tue, 26 May 2015 10:32:04 +0000 (16:02 +0530)]
Merge pull request #71 from sourcejedi/patch-1

Fix copy+paste in description of LEN_ZERO

9 years agoMerge pull request #70 from Manishearth/issue_69
llogiq [Mon, 25 May 2015 23:46:30 +0000 (01:46 +0200)]
Merge pull request #70 from Manishearth/issue_69

Issue #69 fixed

9 years agomade macro test even simpler, added a few tests
llogiq [Mon, 25 May 2015 23:45:15 +0000 (01:45 +0200)]
made macro test even simpler, added a few tests

9 years agofixed issue #69
llogiq [Mon, 25 May 2015 20:50:41 +0000 (22:50 +0200)]
fixed issue #69

9 years agofirst prototype of macro expn detection in mut_mut.rs
llogiq [Mon, 25 May 2015 05:22:41 +0000 (07:22 +0200)]
first prototype of macro expn detection in mut_mut.rs

9 years agoFix copy+paste in description of LEN_ZERO
Alan Jenkins [Sun, 24 May 2015 18:06:54 +0000 (19:06 +0100)]
Fix copy+paste in description of LEN_ZERO

9 years agoMerge pull request #66 from Manishearth/refactoring
llogiq [Sat, 23 May 2015 10:43:24 +0000 (12:43 +0200)]
Merge pull request #66 from Manishearth/refactoring

another refactoring…

9 years agoFormatting fixed
llogiq [Sat, 23 May 2015 10:32:29 +0000 (12:32 +0200)]
Formatting fixed

9 years agoanother refactoring, using more fitting Option methods, improving formatting, etc.
llogiq [Fri, 22 May 2015 22:49:13 +0000 (00:49 +0200)]
another refactoring, using more fitting Option methods, improving formatting, etc.

9 years agoMerge pull request #65 from Manishearth/cmp_owned
llogiq [Thu, 21 May 2015 14:41:57 +0000 (16:41 +0200)]
Merge pull request #65 from Manishearth/cmp_owned

check for str type of .to_owned() callee

9 years agoMerge pull request #64 from Manishearth/refactoring
llogiq [Thu, 21 May 2015 14:39:30 +0000 (16:39 +0200)]
Merge pull request #64 from Manishearth/refactoring

refactored Option usage and fn argument types, improved formatting

9 years agocheck for str type of .to_owned() callee
llogiq [Thu, 21 May 2015 14:37:38 +0000 (16:37 +0200)]
check for str type of .to_owned() callee

9 years agoMerge pull request #63 from Manishearth/cmp_owned
llogiq [Thu, 21 May 2015 14:00:45 +0000 (16:00 +0200)]
Merge pull request #63 from Manishearth/cmp_owned

new lint: cmp_owned

9 years agorefactored Option usage and fn argument types, improved formatting
llogiq [Thu, 21 May 2015 13:59:38 +0000 (15:59 +0200)]
refactored Option usage and fn argument types, improved formatting

9 years agoadded description to README
llogiq [Thu, 21 May 2015 12:57:20 +0000 (14:57 +0200)]
added description to README

9 years agonew lint: cmp_owned
llogiq [Thu, 21 May 2015 12:51:43 +0000 (14:51 +0200)]
new lint: cmp_owned

9 years agoMerge pull request #62 from Manishearth/len_zero_is_empty
llogiq [Wed, 20 May 2015 08:38:08 +0000 (10:38 +0200)]
Merge pull request #62 from Manishearth/len_zero_is_empty

Here goes nothing... :smile:

9 years agoadded messages to test error comments
llogiq [Wed, 20 May 2015 07:34:02 +0000 (09:34 +0200)]
added messages to test error comments

9 years agoUpdate .travis.yml
Manish Goregaokar [Wed, 20 May 2015 07:04:45 +0000 (12:34 +0530)]
Update .travis.yml

9 years agonew lints len_zero and len_without_is_empty
llogiq [Wed, 20 May 2015 06:52:19 +0000 (08:52 +0200)]
new lints len_zero and len_without_is_empty

9 years agoUpdate README.md
Manish Goregaokar [Mon, 18 May 2015 10:32:25 +0000 (16:02 +0530)]
Update README.md

9 years agoMerge pull request #33 from ctjhoa/master
Manish Goregaokar [Mon, 18 May 2015 10:30:55 +0000 (16:00 +0530)]
Merge pull request #33 from ctjhoa/master

Fix and improve README

9 years agoSpecify languages for examples
Camille TJHOA [Wed, 29 Apr 2015 14:17:30 +0000 (16:17 +0200)]
Specify languages for examples

9 years agoFix typo
Camille TJHOA [Wed, 29 Apr 2015 12:18:02 +0000 (14:18 +0200)]
Fix typo

9 years agoFix and improve README
Camille TJHOA [Tue, 28 Apr 2015 19:50:04 +0000 (21:50 +0200)]
Fix and improve README

9 years agoMerge pull request #59 from Manishearth/mut_mut
Manish Goregaokar [Mon, 18 May 2015 10:20:04 +0000 (15:50 +0530)]
Merge pull request #59 from Manishearth/mut_mut

Mut mut no longer matches ty_ptr, better error messages

9 years agoremoved ty_ptr match
llogiq [Mon, 18 May 2015 09:36:56 +0000 (11:36 +0200)]
removed ty_ptr match