]>
git.lizzy.rs Git - rust.git/log
wartman4404 [Wed, 4 Nov 2015 03:11:40 +0000 (21:11 -0600)]
check for Deref conversions
wartman4404 [Sat, 31 Oct 2015 04:58:37 +0000 (23:58 -0500)]
New lint for using `.cloned()`
llogiq [Tue, 3 Nov 2015 21:45:52 +0000 (22:45 +0100)]
Merge pull request #432 from nweston/zip-with-range
New lint for zip with array length instead of enumerate()
Nathan Weston [Tue, 3 Nov 2015 14:42:52 +0000 (09:42 -0500)]
New lint for zip with array length instead of enumerate()
Fixes #11.
llogiq [Sat, 31 Oct 2015 01:07:20 +0000 (02:07 +0100)]
Merge pull request #426 from Manishearth/fix-ptr-arg
Fix ptr-arg false positive for trait impls
Manish Goregaokar [Fri, 30 Oct 2015 23:48:05 +0000 (05:18 +0530)]
Fix ptr-arg false positive for trait impls
Fixes #425
llogiq [Thu, 29 Oct 2015 11:05:28 +0000 (12:05 +0100)]
Merge pull request #422 from sanxiyn/no-effect
New lint for statement with no effect
Seo Sanghyeon [Wed, 28 Oct 2015 16:50:00 +0000 (01:50 +0900)]
New lint for statement with no effect
Manish Goregaokar [Thu, 29 Oct 2015 03:32:56 +0000 (09:02 +0530)]
Merge pull request #423 from wartman4404/master
Duplicate warnings for match_bool / single_match #403
wartman4404 [Thu, 29 Oct 2015 03:26:48 +0000 (22:26 -0500)]
Don't show single_match if match_bool also applies
llogiq [Tue, 27 Oct 2015 17:33:58 +0000 (18:33 +0100)]
Merge pull request #396 from fhartwig/while-let-for
Suggest for loop instead of while-let when looping over iterators
Florian Hartwig [Tue, 27 Oct 2015 17:28:36 +0000 (18:28 +0100)]
Allow needless_lifetime to pass dogfood.sh
Florian Hartwig [Mon, 26 Oct 2015 22:49:37 +0000 (23:49 +0100)]
Fix false positives when iterator variable is used after the loop
Florian Hartwig [Fri, 23 Oct 2015 08:50:18 +0000 (10:50 +0200)]
Fix error in README
Florian Hartwig [Thu, 22 Oct 2015 21:16:58 +0000 (23:16 +0200)]
Fixes for code review comments
* remove weird infinite loops from compile-tests
* remove call to Option::unwrap
* in the lint message, show while-let loop rewritten as for loop
Florian Hartwig [Mon, 19 Oct 2015 23:04:21 +0000 (01:04 +0200)]
Don't suggest using a for loop if the iterator is used in the loop body
Due to https://github.com/rust-lang/rust/issues/8372, we have to use while-let
in these cases.
Florian Hartwig [Fri, 16 Oct 2015 18:27:13 +0000 (20:27 +0200)]
Suggest for loop instead of while-let when looping over iterators
Georg Brandl [Mon, 26 Oct 2015 07:07:24 +0000 (08:07 +0100)]
Merge pull request #415 from birkenfeld/fix_409
Fix reverse_range_loop not taking sign into account (fixes #409)
Georg Brandl [Mon, 26 Oct 2015 06:43:38 +0000 (07:43 +0100)]
Fix reverse_range_loop not taking sign into account (fixes #409)
Adds a Display impl for Constant, because that might come in handy
elsewhere as well.
Manish Goregaokar [Sun, 25 Oct 2015 18:19:53 +0000 (23:49 +0530)]
fix
Manish Goregaokar [Sun, 25 Oct 2015 18:13:27 +0000 (23:43 +0530)]
bump version, add optional dep info
llogiq [Sun, 25 Oct 2015 09:35:29 +0000 (10:35 +0100)]
Merge pull request #413 from iKevinY/approx-const
Compare float literals to stringified constants
Kevin Yap [Sat, 24 Oct 2015 04:30:57 +0000 (21:30 -0700)]
Compare float literals to stringified constants
- Convert constants to strings and compare directly with float literal.
- Return immediately after positive match for constant.
- Fix value of `my_log10_e` in `approx_const` tests.
Manish Goregaokar [Fri, 23 Oct 2015 12:08:10 +0000 (17:38 +0530)]
Merge pull request #408 from iKevinY/approx-const
Change implementation of approx_const lint
Kevin Yap [Thu, 22 Oct 2015 22:19:03 +0000 (15:19 -0700)]
Change implementation of approx_const lint
- Replace epsilon with lower and upper bounds for each constant.
- Warn on use of "3.14", and update tests accordingly.
Manish Goregaokar [Thu, 22 Oct 2015 09:23:54 +0000 (14:53 +0530)]
Merge pull request #405 from sanxiyn/needless-update
New lint for struct update that has no effect
Seo Sanghyeon [Wed, 21 Oct 2015 15:25:16 +0000 (00:25 +0900)]
New lint for struct update that has no effect
Manish Goregaokar [Wed, 21 Oct 2015 06:34:00 +0000 (12:04 +0530)]
Merge pull request #402 from Manishearth/match_bool_hints
added code snippet help to match_bool
Andre Bogus [Wed, 21 Oct 2015 06:24:56 +0000 (08:24 +0200)]
added code snippet help to match_bool
Manish Goregaokar [Tue, 20 Oct 2015 19:30:39 +0000 (01:00 +0530)]
Merge pull request #401 from kvikas/match_bool
Match on bool should be replaced with if..else block
Vikas Kumar [Tue, 20 Oct 2015 18:26:54 +0000 (11:26 -0700)]
Fixups from review comments
1. Moved common check `in_external_macro` to the top of function from inside each
conditionals.
2. Inlined `is_bool_expr` call
Vikas Kumar [Tue, 20 Oct 2015 17:25:37 +0000 (10:25 -0700)]
Ran util/update_lints.py to auto gen doc and lib.rs
Vikas Kumar [Tue, 20 Oct 2015 17:18:48 +0000 (10:18 -0700)]
Match on bool should be replaced with if..else block
1. Added another conditional in `check_expr` impl to lint if match expr
is a bool.
2. Test cases.
Manish Goregaokar [Sat, 17 Oct 2015 19:24:03 +0000 (00:54 +0530)]
Merge branch 'pr-394'
Florian Gilcher [Sat, 17 Oct 2015 18:16:54 +0000 (20:16 +0200)]
Cleanup as discussed in PR
Manish Goregaokar [Fri, 16 Oct 2015 23:03:05 +0000 (04:33 +0530)]
Make is_from_for_desugar sound (rust/28973 got fixed)
Florian Gilcher [Thu, 15 Oct 2015 10:53:21 +0000 (12:53 +0200)]
Regnerate README.md
Florian Gilcher [Thu, 15 Oct 2015 09:13:01 +0000 (11:13 +0200)]
New lint for needless use of nightly features
Manish Goregaokar [Thu, 15 Oct 2015 14:26:27 +0000 (19:56 +0530)]
bump again
Manish Goregaokar [Thu, 15 Oct 2015 14:25:14 +0000 (19:55 +0530)]
Fix type complexity lint
llogiq [Thu, 15 Oct 2015 14:24:04 +0000 (16:24 +0200)]
Merge pull request #395 from Manishearth/rustup
rustup
Andre Bogus [Thu, 15 Oct 2015 14:19:08 +0000 (16:19 +0200)]
Merge branch 'master' of https://github.com/Manishearth/rust-clippy into rustup
Andre Bogus [Thu, 15 Oct 2015 14:18:40 +0000 (16:18 +0200)]
workaround for failing test
Andre Bogus [Thu, 15 Oct 2015 14:04:19 +0000 (16:04 +0200)]
bump crate version
Andre Bogus [Thu, 15 Oct 2015 14:02:19 +0000 (16:02 +0200)]
rustup
Manish Goregaokar [Thu, 15 Oct 2015 13:52:36 +0000 (19:22 +0530)]
bump crates
llogiq [Wed, 14 Oct 2015 20:40:18 +0000 (22:40 +0200)]
Merge pull request #392 from fhartwig/warn-ptr-args
Make ptr_arg lint warn by default
Florian Hartwig [Wed, 14 Oct 2015 17:51:54 +0000 (19:51 +0200)]
Make ptr_arg lint warn by default
Andre Bogus [Wed, 14 Oct 2015 10:22:57 +0000 (12:22 +0200)]
Merged #365
Andre Bogus [Wed, 14 Oct 2015 10:06:28 +0000 (12:06 +0200)]
Merged #366
Andre Bogus [Wed, 14 Oct 2015 09:44:09 +0000 (11:44 +0200)]
Merge PR #374
Manish Goregaokar [Tue, 13 Oct 2015 13:09:11 +0000 (18:39 +0530)]
Merge pull request #382 from Manishearth/empty_loop
new lint to detect `loop {}`
Andre Bogus [Tue, 13 Oct 2015 12:45:35 +0000 (14:45 +0200)]
update lints
Andre Bogus [Mon, 12 Oct 2015 11:38:18 +0000 (13:38 +0200)]
new lint to detect
Manish Goregaokar [Tue, 13 Oct 2015 12:03:23 +0000 (17:33 +0530)]
Merge pull request #390 from Manishearth/precedence
improved precedence messages (fixes #389)
Andre Bogus [Tue, 13 Oct 2015 11:48:48 +0000 (13:48 +0200)]
improved precedence messages (fixes #389)
Manish Goregaokar [Mon, 12 Oct 2015 22:46:05 +0000 (04:16 +0530)]
Improve cmp_owned suggestions (fixes #386)
Ravi Shankar [Sun, 11 Oct 2015 16:49:01 +0000 (22:19 +0530)]
whup the while_let_loop for ignoring expressions!
Manish Goregaokar [Mon, 12 Oct 2015 06:03:35 +0000 (11:33 +0530)]
Merge pull request #379 from swgillespie/zero_div_zero_nan
implement 0.0/0.0 -> NaN lint as described in #370
llogiq [Mon, 12 Oct 2015 06:01:35 +0000 (08:01 +0200)]
Merge pull request #381 from durka/patch-2
fix doc comment for if_let_chain!
Georg Brandl [Mon, 12 Oct 2015 05:59:08 +0000 (07:59 +0200)]
Remove "are you sure?" from lint msg.
No added value, and leads to punctuation clash.
Alex Burka [Mon, 12 Oct 2015 05:54:44 +0000 (01:54 -0400)]
fix doc comment for if_let_chain!
swgillespie [Mon, 12 Oct 2015 02:22:13 +0000 (19:22 -0700)]
implement 0.0/0.0 -> NaN lint as described in #370
casing of NaN
Manish Goregaokar [Sun, 11 Oct 2015 21:16:23 +0000 (02:46 +0530)]
Merge pull request #377 from Manishearth/rustup
Rust upgrade to rustc 1.5.0-nightly (
9d3e79ad3 2015-10-10)
Manish Goregaokar [Sun, 11 Oct 2015 21:12:21 +0000 (02:42 +0530)]
Rust upgrade to rustc 1.5.0-nightly (
9d3e79ad3 2015-10-10)
Florian Hartwig [Sun, 11 Oct 2015 14:07:00 +0000 (16:07 +0200)]
Recommend using Mutex<()> for locking
Manish Goregaokar [Thu, 8 Oct 2015 09:21:53 +0000 (14:51 +0530)]
Merge pull request #369 from fhartwig/allow-warn
Fix documentation that disagrees with code
Florian Hartwig [Wed, 7 Oct 2015 22:35:32 +0000 (00:35 +0200)]
Fix documentation that disagrees with code
Florian Hartwig [Wed, 7 Oct 2015 20:58:34 +0000 (22:58 +0200)]
Add a lint for sized integer types in a mutex
Pyriphlegethon [Wed, 7 Oct 2015 15:15:44 +0000 (17:15 +0200)]
Change lint description
Pyriphlegethon [Wed, 7 Oct 2015 11:15:14 +0000 (13:15 +0200)]
Add "nonsensical OpenOptions" lint
Florian Hartwig [Tue, 6 Oct 2015 23:17:57 +0000 (01:17 +0200)]
Suggest using an atomic value instead of a Mutex where possible
Manish Goregaokar [Tue, 6 Oct 2015 22:48:02 +0000 (04:18 +0530)]
Merge pull request #354 from Pyriphlegethon/master
Add "unnecessary mut passed" lint
Georg Brandl [Mon, 5 Oct 2015 20:02:05 +0000 (22:02 +0200)]
RingBuf was renamed to VecDeque (fixes #363)
Manish Goregaokar [Mon, 5 Oct 2015 19:20:06 +0000 (00:50 +0530)]
Bump version
Manish Goregaokar [Fri, 2 Oct 2015 18:19:25 +0000 (23:49 +0530)]
Merge pull request #361 from cuviper/deflocal
Update the DefLocal pattern
Josh Stone [Fri, 2 Oct 2015 18:07:56 +0000 (11:07 -0700)]
Update the DefLocal pattern
DefLocal now contains a DefId too, since rust-lang/rust@
a0dc2d9a29218 .
Manish Goregaokar [Fri, 2 Oct 2015 08:09:07 +0000 (13:39 +0530)]
Merge pull request #360 from Manishearth/fix-ice
Fix a panic caused by while let
Manish Goregaokar [Fri, 2 Oct 2015 07:56:04 +0000 (13:26 +0530)]
bump
Manish Goregaokar [Fri, 2 Oct 2015 07:55:34 +0000 (13:25 +0530)]
Fix a panic caused by while let
Manish Goregaokar [Wed, 30 Sep 2015 19:44:45 +0000 (01:14 +0530)]
Merge pull request #351 from Wafflespeanut/while_let
Training the `while_let` detector...
Pyriphlegethon [Wed, 30 Sep 2015 16:17:55 +0000 (18:17 +0200)]
Well, fix them again
Pyriphlegethon [Wed, 30 Sep 2015 16:00:14 +0000 (18:00 +0200)]
Fix tests
Manish Goregaokar [Wed, 30 Sep 2015 14:40:54 +0000 (20:10 +0530)]
Fix rustup fallout: lifetimes false positives
Manish Goregaokar [Wed, 30 Sep 2015 14:24:41 +0000 (19:54 +0530)]
rustup to rustc 1.5.0-nightly (
65d5c0833 2015-09-29)
Pyriphlegethon [Wed, 30 Sep 2015 11:27:09 +0000 (13:27 +0200)]
Add test for unnecessary mut passed lint
Pyriphlegethon [Wed, 30 Sep 2015 11:08:29 +0000 (13:08 +0200)]
Remove unnecessary clones and add helper function
Pyriphlegethon [Tue, 29 Sep 2015 16:52:19 +0000 (18:52 +0200)]
Change description of unnecessary mut passed lint
Pyriphlegethon [Tue, 29 Sep 2015 16:43:38 +0000 (18:43 +0200)]
Add unnecessary mut passed lint for methods
Ravi Shankar [Sun, 27 Sep 2015 07:39:42 +0000 (13:09 +0530)]
extending while_let to warn for more statements
Pyriphlegethon [Tue, 29 Sep 2015 11:16:53 +0000 (13:16 +0200)]
Replace tabs by spaces
Pyriphlegethon [Tue, 29 Sep 2015 11:11:19 +0000 (13:11 +0200)]
Add unnecessary mut passed lint
Georg Brandl [Mon, 28 Sep 2015 05:11:03 +0000 (07:11 +0200)]
all: remove trailing spaces
Manish Goregaokar [Mon, 28 Sep 2015 05:04:06 +0000 (10:34 +0530)]
rustup to 1.5.0-nightly (
7bf4c885f 2015-09-26)
fixes #348
llogiq [Fri, 25 Sep 2015 13:29:32 +0000 (15:29 +0200)]
Merge pull request #349 from Manishearth/rustup
rustup 2015-09-24
Manish Goregaokar [Fri, 25 Sep 2015 13:22:36 +0000 (18:52 +0530)]
rustup 2015-09-24
Manish Goregaokar [Thu, 24 Sep 2015 06:31:18 +0000 (12:01 +0530)]
Merge branch 'pr-347'
Pietro Monteiro [Thu, 24 Sep 2015 00:30:39 +0000 (17:30 -0700)]
Upgrade Rust to rustc 1.5.0-nightly (
b2f379cdc 2015-09-23)
Ident was removed in many HIR structures in favor of Name.
llogiq [Tue, 22 Sep 2015 07:18:45 +0000 (09:18 +0200)]
Merge pull request #344 from Manishearth/reflet
Handle let ref in toplevel_ref_arg as well
Manish Goregaokar [Tue, 22 Sep 2015 07:08:42 +0000 (12:38 +0530)]
Handle let ref in toplevel_ref_arg as well