]>
git.lizzy.rs Git - rust.git/log
bors[bot] [Tue, 16 Nov 2021 11:27:11 +0000 (11:27 +0000)]
Merge #10734
10734: fix: add generic parameters in convert to manual impl assist r=Veykril a=TheDoctor314
Fixes #10041.
Co-authored-by: TheDoctor314 <64731940+TheDoctor314@users.noreply.github.com>
bors[bot] [Tue, 16 Nov 2021 11:16:50 +0000 (11:16 +0000)]
Merge #10774
10774: minor: Lift out FxIndex{Map/Set} types into ide_db r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Tue, 16 Nov 2021 11:15:47 +0000 (12:15 +0100)]
minor: Lift out FxIndex{Map/Set} types into ide_db
bors[bot] [Tue, 16 Nov 2021 10:52:31 +0000 (10:52 +0000)]
Merge #10773
10773: fix: Remove faulty logic for ascending test attributes for runnables r=Veykril a=Veykril
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/10768
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Tue, 16 Nov 2021 10:36:41 +0000 (11:36 +0100)]
fix: Reimplement mapping out of test/bench attributes for runnables
TheDoctor314 [Mon, 15 Nov 2021 15:21:48 +0000 (20:51 +0530)]
Fix `impl_def_from_trait`
Revert "Fix `impl_trait` function to emit correct ast"
This reverts commit
55a4813151a8f36dcdb520c45a461fe5dfbed499 .
Fix `impl_def_from_trait`
It now generates the correct `ast::Impl` using
`generate_trait_impl_text` and parses it to form the right node (copied
from the private fn 'make::ast_from_text').
bors[bot] [Sun, 14 Nov 2021 15:26:58 +0000 (15:26 +0000)]
Merge #10767
10767: minor: Rename intern_macro -> intern_macro_call r=Veykril a=Veykril
We potentially want to intern macro definitions so the names would probably collide
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Sun, 14 Nov 2021 15:25:40 +0000 (16:25 +0100)]
Rename intern_macro -> intern_macro_call
bors[bot] [Sun, 14 Nov 2021 12:05:17 +0000 (12:05 +0000)]
Merge #10759
10759: make `add_missing_match_arms` applicable at the end of the match r=Veykril a=rainy-me
close #10740
Co-authored-by: rainy-me <github@yue.coffee>
rainy-me [Sun, 14 Nov 2021 11:56:28 +0000 (20:56 +0900)]
adjust test case and stop deleting newline
bors[bot] [Sun, 14 Nov 2021 09:20:59 +0000 (09:20 +0000)]
Merge #10762
10762: Fix: trigger flyimport on enum variants r=lnicola a=XFFXFF
fixes #10749
Co-authored-by: zhoufan <1247714429@qq.com>
zhoufan [Sun, 14 Nov 2021 04:16:21 +0000 (12:16 +0800)]
fix: flyimport triggers on enum variant declarations
bors[bot] [Sat, 13 Nov 2021 23:42:16 +0000 (23:42 +0000)]
Merge #10761
10761: inlay hints: add the option to always show constructor inlay hints r=Veykril a=jhgg
This PR adds a config to *disable* the functionality in #10441 - _and makes that functionality disabled by default._
I actually *really* like inlay hints always showing up, and it helps a lot as a teaching tool too, and also it's quite reassuring to know that r-a indeed understands the code I've written. This PR adds the option `rust-analyzer.inlayHints.hideNamedConstructorHints` (i can also invert this to be `rust-analyzer.inlayHints.showNamedConstructorHints`, just let me know.)
Co-authored-by: Jake Heinz <jh@discordapp.com>
Jake Heinz [Sat, 13 Nov 2021 23:39:34 +0000 (23:39 +0000)]
flip the default
Jake Heinz [Sat, 13 Nov 2021 23:12:29 +0000 (23:12 +0000)]
inlay hints: add the option to always show constructor inlay hints
rainy-me [Sat, 13 Nov 2021 17:32:10 +0000 (02:32 +0900)]
add missing match arms end of last arm
bors[bot] [Sat, 13 Nov 2021 15:56:25 +0000 (15:56 +0000)]
Merge #10758
10758: Update docs: include Gentoo source build r=lnicola a=mjkalyan
Mention the dev-util/rust-analyzer package for building from source.
Co-authored-by: mjkalyan <34904034+mjkalyan@users.noreply.github.com>
mjkalyan [Sat, 13 Nov 2021 01:26:21 +0000 (18:26 -0700)]
Update docs: include Gentoo source build
Mention the dev-util/rust-analyzer package for building from source.
bors[bot] [Fri, 12 Nov 2021 21:05:54 +0000 (21:05 +0000)]
Merge #10756
10756: Allow the check command to terminate without output r=Veykril a=Wilfred
Cargo will always output something on success:
```
$ cargo check --message-format=json
{"reason":"compiler-artifact", ... snipped ... }
{"reason":"build-finished","success":true}
```
However, rustc does not output anything on success:
```
$ rustc --error-format=json main.rs
$ echo $?
0
```
Restore the behaviour prior to #10517, where an exit code of 0 is
considered good even if nothing is written to stdout.
This enables custom overrideCommand values that use rustc rather than
cargo.
Co-authored-by: Wilfred Hughes <me@wilfred.me.uk>
Wilfred Hughes [Fri, 12 Nov 2021 19:43:20 +0000 (11:43 -0800)]
Allow the check command to terminate without output
Cargo will always output something on success:
```
$ cargo check --message-format=json
{"reason":"compiler-artifact", ... snipped ... }
{"reason":"build-finished","success":true}
```
However, rustc does not output anything on success:
```
$ rustc --error-format=json main.rs
$ echo $?
0
```
Restore the behaviour prior to #10517, where an exit code of 0 is
considered good even if nothing is written to stdout.
This enables custom overrideCommand values that use rustc rather than
cargo.
bors[bot] [Fri, 12 Nov 2021 19:32:04 +0000 (19:32 +0000)]
Merge #10755
10755: Fix type names in typescript sample code r=lnicola a=Wilfred
`bool` is Rust, whereas `boolean` is the type name in TypeScript.
Co-authored-by: Wilfred Hughes <me@wilfred.me.uk>
Wilfred Hughes [Fri, 12 Nov 2021 19:15:08 +0000 (11:15 -0800)]
Fix type names in typescript sample code
bors[bot] [Thu, 11 Nov 2021 17:48:45 +0000 (17:48 +0000)]
Merge #10747
10747: fix: Remove faulty logic for ascending test attributes for runnables r=Veykril a=Veykril
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/10744
- This logic is currently not required as we do not expand test/bench anymore for the time being
- The implementation of this was flawed to begin with as it just skipped out of macro expansions instead of ascending the trees inside expansions
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Thu, 11 Nov 2021 17:47:24 +0000 (18:47 +0100)]
Remove faulty logic for ascending test attributes for runnables
bors[bot] [Thu, 11 Nov 2021 17:21:37 +0000 (17:21 +0000)]
Merge #10745
10745: internal: Replace some more ide usages of ModuleDef with Definition r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Thu, 11 Nov 2021 17:20:54 +0000 (18:20 +0100)]
Replace some more ide usages of ModuleDef with Definition
bors[bot] [Thu, 11 Nov 2021 13:45:20 +0000 (13:45 +0000)]
Merge #10743
10743: feat: index fewer crates on startup/reload r=jonas-schievink a=jonas-schievink
Before this PR, we used to index every crate in the `CrateGraph`, which includes every test, benchmark and example of all packages everywhere. The point of indexing is to speed up future queries, so indexing lots of tiny crates users are unlikely to open isn't really helpful.
This PR instead makes us index only the transitive dependencies of all workspace crates.
This reduces the number of crates we index in the rust-analyzer repo from 617 to 177 (!). Time is not impacted by that much, because most of the skipped crates are tiny.
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Jonas Schievink [Thu, 11 Nov 2021 13:39:20 +0000 (14:39 +0100)]
Prime a more reasonable set of crates
TheDoctor314 [Thu, 11 Nov 2021 08:46:59 +0000 (14:16 +0530)]
Fix `impl_trait` function to emit correct ast
`impl_trait` code copied from `generate_impl_text_inner` to properly
handle the bounds for the generic parameters.
TheDoctor314 [Thu, 11 Nov 2021 08:46:29 +0000 (14:16 +0530)]
Add generic bounds in test
bors[bot] [Wed, 10 Nov 2021 23:19:44 +0000 (23:19 +0000)]
Merge #10741
10741: internal: Flatten Definition::ModuleDef variant r=Veykril a=Veykril
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Wed, 10 Nov 2021 21:02:50 +0000 (22:02 +0100)]
internal: Flatten `Definition::ModuleDef` variant
bors[bot] [Wed, 10 Nov 2021 21:08:51 +0000 (21:08 +0000)]
Merge #10689
10689: Handle pub tuple fields in tuple structs r=Veykril a=adamrk
The current implementation will throw a parser error for tuple structs
that contain a pub tuple field. For example,
```rust
struct Foo(pub (u32, u32));
```
is valid Rust, but rust-analyzer will throw a parser error. This is
because the parens after `pub` is treated as a visibility context.
Allowing a tuple type to follow `pub` in the special case when we are
defining fields in a tuple struct can fix the issue.
I guess this is a really minor case because there's not much reason
for having a tuple type within a struct tuple, but it is valid rust syntax...
Co-authored-by: Adam Bratschi-Kaye <ark.email@gmail.com>
Adam Bratschi-Kaye [Wed, 3 Nov 2021 22:57:46 +0000 (23:57 +0100)]
Handle pub tuple fields in tuple structs
The current implementation will throw a parser error for tuple structs
that contain a pub tuple field. For example,
```rust
struct Foo(pub (u32, u32));
```
is valid Rust, but rust-analyzer will throw a parser error. This is
because the parens after `pub` is treated as a visibility context.
Allowing a tuple type to follow `pub` in the special case when we are
defining fields in a tuple struct can fix the issue.
bors[bot] [Wed, 10 Nov 2021 17:27:24 +0000 (17:27 +0000)]
Merge #10739
10739: internal: Simplify r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Wed, 10 Nov 2021 16:33:35 +0000 (17:33 +0100)]
Simplify
bors[bot] [Wed, 10 Nov 2021 16:47:35 +0000 (16:47 +0000)]
Merge #10729
10729: Fix: Lookup impls in local def maps r=jonas-schievink a=XFFXFF
fixes #10676
Co-authored-by: zhoufan <1247714429@qq.com>
bors[bot] [Wed, 10 Nov 2021 15:12:05 +0000 (15:12 +0000)]
Merge #10738
10738: internal: Do not search through all three namespaces in `ItemScope::name_of` r=Veykril a=Veykril
Brings down `5ms - find_path_prefixed (46 calls)` to `1ms - find_path_prefixed (46 calls)` for me on the `integrated_completion_benchmark`.
Still `O(n)` but this should considerably cut down lookups nevertheless(as shown by the timings already).
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Wed, 10 Nov 2021 15:06:16 +0000 (16:06 +0100)]
Do not search through all three namespaces in `ItemScope::name_of`
TheDoctor314 [Mon, 8 Nov 2021 15:49:22 +0000 (21:19 +0530)]
Add generic parameters for manual impl assist
The `impl_trait` function takes an optional `GenericParamList` to create
the trait impl.
TheDoctor314 [Mon, 1 Nov 2021 16:47:27 +0000 (22:17 +0530)]
Add failing tests for generic struct
bors[bot] [Tue, 9 Nov 2021 22:11:32 +0000 (22:11 +0000)]
Merge #10731
10731: fix: show the right check-command r=Veykril a=Florian-Schoenherr
Currenty r.a. only shows this:
![image](https://user-images.githubusercontent.com/
65456722 /
140977478 -
e6bc8a45 -7c25-4578-9406-
fb34f1eb0792 .png)
even if another command was specified
There might be a better way to do this, I tried.
Co-authored-by: Florian-Schoenherr <florian.schoenherr99@gmail.com>
Florian-Schoenherr [Tue, 9 Nov 2021 20:52:55 +0000 (21:52 +0100)]
fix: show the right check-command
Signed-off-by: Florian-Schoenherr <florian.schoenherr99@gmail.com>
bors[bot] [Tue, 9 Nov 2021 18:06:23 +0000 (18:06 +0000)]
Merge #10732
10732: minor: Bump deps r=lnicola a=lnicola
bors r+
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Tue, 9 Nov 2021 18:05:04 +0000 (20:05 +0200)]
Bump chalk
Laurențiu Nicola [Tue, 9 Nov 2021 18:03:48 +0000 (20:03 +0200)]
Bump libc and paste
zhoufan [Tue, 9 Nov 2021 10:13:42 +0000 (18:13 +0800)]
lookup impls in local del maps
bors[bot] [Mon, 8 Nov 2021 18:42:10 +0000 (18:42 +0000)]
Merge #10726
10726: minor: Add some completion profile spans r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Mon, 8 Nov 2021 18:41:16 +0000 (19:41 +0100)]
Add some completion profile spans
bors[bot] [Mon, 8 Nov 2021 14:08:49 +0000 (14:08 +0000)]
Merge #10722
10722: fix: Fix proc-macro attributes being shadowed by their functions in IDE layer r=Veykril a=Veykril
We sometimes still didn't resolve proc-macro attrs in attribute paths in the ide crates due to their function definitions resolving first.
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Mon, 8 Nov 2021 13:31:46 +0000 (14:31 +0100)]
Fix proc-macro attributes being shadowed by their functions in IDE layer
bors[bot] [Mon, 8 Nov 2021 13:37:34 +0000 (13:37 +0000)]
Merge #10688
10688: internal: Type-check TS on CI and also turn off the strict setting `useUnknownInCatchVariables` r=lnicola a=ChayimFriedman2
We don't follow it and I found that turning it on will have little benefit.
I'm not sure if we should also type-check when building in launch.json.
Co-authored-by: Chayim Refael Friedman <chayimfr@gmail.com>
bors[bot] [Mon, 8 Nov 2021 13:12:03 +0000 (13:12 +0000)]
Merge #10720
10720: fix: Don't ascribe types in pattern completion for param patterns twice r=Veykril a=Veykril
Fixes #10323
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Mon, 8 Nov 2021 13:10:26 +0000 (14:10 +0100)]
Add test for current incorrect behaviour
bors[bot] [Sun, 7 Nov 2021 11:13:15 +0000 (11:13 +0000)]
Merge #10699
10699: internal: Make CompletionItem `label` and `lookup` fields `SmolStr`s r=Veykril a=Veykril
This replaces a bunch of String clones with SmolStr clones, though also makes a few parts a bit more expensive(mainly things involving `format!`ted strings as labels).
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
bors[bot] [Sun, 7 Nov 2021 11:02:39 +0000 (11:02 +0000)]
Merge #10698
10698: implement multi-token mapping for ssr r=Veykril a=spookyvision
Co-authored-by: Anatol Ulrich <anatol.ulrich@ferrous-systems.com>
bors[bot] [Sun, 7 Nov 2021 08:03:03 +0000 (08:03 +0000)]
Merge #10712
10712: minor: Avoid deprecated methods in client-side tests r=lnicola a=lnicola
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Sun, 7 Nov 2021 08:00:58 +0000 (10:00 +0200)]
Avoid deprecated methods in client-side tests
bors[bot] [Sat, 6 Nov 2021 15:41:32 +0000 (15:41 +0000)]
Merge #10709
10709: minor: Bump deps r=lnicola a=lnicola
bors r+
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Sat, 6 Nov 2021 15:12:34 +0000 (17:12 +0200)]
Bump deps
Lukas Wirth [Fri, 5 Nov 2021 17:39:36 +0000 (18:39 +0100)]
Don't ascribe types in pattern completion for patterns twice
bors[bot] [Fri, 5 Nov 2021 17:34:16 +0000 (17:34 +0000)]
Merge #10706
10706: minor: Show how to create `~/.local/bin` r=lnicola a=lnicola
Closes #10687
bors r+
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Fri, 5 Nov 2021 17:32:55 +0000 (19:32 +0200)]
Show how to create `~/.local/bin`
bors[bot] [Fri, 5 Nov 2021 15:06:37 +0000 (15:06 +0000)]
Merge #10704
10704: internal: Short-circuit `descend_into_macros_single` r=Veykril a=Veykril
There is no need to descend everything if all we are interested in is the first mapping.
This bring `descend_into_macros` timing in highlighting in `rust-analyzer/src/config.rs` from `154ms - descend_into_macros (2190 calls)` to `24ms - descend_into_macros (2190 calls)` since we use the single variant there(will regress once we want to highlight multiple namespaces again though).
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Fri, 5 Nov 2021 15:02:56 +0000 (16:02 +0100)]
Short-circuit descend_into_macros_single
Lukas Wirth [Fri, 5 Nov 2021 14:52:10 +0000 (15:52 +0100)]
Don't search for root nodes unnecessarily
bors[bot] [Fri, 5 Nov 2021 13:53:59 +0000 (13:53 +0000)]
Merge #10703
10703: internal: Don't check items for macro calls if they have no attributes r=Veykril a=Veykril
Turns out when highlighting we currently populate the Dynmaps of pretty much every item in a file, who would've known that would be so costly...
Shaves off 250 ms for the integrated benchmark on `rust-analyzer/src/config.rs`.
We are still looking at a heft `154ms - descend_into_macros (2190 calls)` but I feel like this is slowly nearing towards just call overhead.
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Fri, 5 Nov 2021 13:50:10 +0000 (14:50 +0100)]
Don't check items for macro calls if they have no attributes
bors[bot] [Fri, 5 Nov 2021 13:26:56 +0000 (13:26 +0000)]
Merge #10701
10701: internal: Cache ast::MacroCalls to their expansions in Semantics::descend_into_macros_impl r=Veykril a=Veykril
Saves ~45ms when highlighting `rust-analyzer/src/config.rs` for me
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Fri, 5 Nov 2021 13:25:47 +0000 (14:25 +0100)]
Cache ast::MacroCalls to their expansions in Semantics::descend_into_macros_impl
Lukas Wirth [Fri, 5 Nov 2021 11:30:39 +0000 (12:30 +0100)]
Replace some String usages with SmolStr in completions
bors[bot] [Fri, 5 Nov 2021 11:25:17 +0000 (11:25 +0000)]
Merge #10685
10685: fix: Enable markdown tables r=Veykril a=Veykril
Should fix https://github.com/rust-analyzer/rust-analyzer/issues/10655
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Anatol Ulrich [Thu, 4 Nov 2021 21:01:59 +0000 (22:01 +0100)]
maybe?
bors[bot] [Thu, 4 Nov 2021 17:13:33 +0000 (17:13 +0000)]
Merge #10696
10696: internal: Replace more Name::to_string usages with Name::to_smol_str r=Veykril a=Veykril
Gets rid of some more unnecessary string allocs
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Thu, 4 Nov 2021 17:12:05 +0000 (18:12 +0100)]
Replace more Name::to_string usages with Name::to_smol_str
Lukas Wirth [Wed, 3 Nov 2021 14:40:41 +0000 (15:40 +0100)]
Enable markdown tables
bors[bot] [Thu, 4 Nov 2021 16:31:16 +0000 (16:31 +0000)]
Merge #10645
10645: fix: make `rename` multi-token mapping aware r=Veykril a=spookyvision
Co-authored-by: Anatol Ulrich <anatol.ulrich@ferrous-systems.com>
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Co-authored-by: Anatol Ulrich <45840+spookyvision@users.noreply.github.com>
bors[bot] [Thu, 4 Nov 2021 05:52:05 +0000 (05:52 +0000)]
Merge #10691
10691: minor: Use array `into_iter` in more places r=lnicola a=lnicola
bors r+
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Wed, 3 Nov 2021 12:21:46 +0000 (14:21 +0200)]
Use array into_iter in more places
Chayim Refael Friedman [Wed, 3 Nov 2021 23:23:45 +0000 (01:23 +0200)]
Type-check TS on CI and also turn off the strict setting `useUnknownInCatchVariables`
We don't follow it and I found that turning it on will have little benefit.
bors[bot] [Wed, 3 Nov 2021 20:23:14 +0000 (20:23 +0000)]
Merge #10686
10686: internal: Add `Semantics::original_ast_node` for upmapping nodes out of macro files r=Veykril a=Veykril
Fixes trying to insert imports into macro expanded files which then do text edits on very wrong text ranges.
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Wed, 3 Nov 2021 20:12:36 +0000 (21:12 +0100)]
Add Semantics::original_ast_node for upmapping nodes out of macro files
bors[bot] [Wed, 3 Nov 2021 16:19:42 +0000 (16:19 +0000)]
Merge #10680
10680: implement Literal::from_str r=jonas-schievink a=spookyvision
this apparently fixes RTIC 0.6's
```rust
#[rtic::app]
mod app {}
```
Co-authored-by: Anatol Ulrich <anatol.ulrich@ferrous-systems.com>
Anatol Ulrich [Tue, 2 Nov 2021 20:42:17 +0000 (21:42 +0100)]
implement Literal::from_str
bors[bot] [Wed, 3 Nov 2021 14:50:39 +0000 (14:50 +0000)]
Merge #10667
10667: internal: Expose version string of crates from HIR r=Veykril a=Veykril
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/10664
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Anatol Ulrich [Wed, 3 Nov 2021 14:44:46 +0000 (15:44 +0100)]
Update crates/text_edit/src/lib.rs
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Anatol Ulrich [Wed, 3 Nov 2021 14:44:32 +0000 (15:44 +0100)]
Update crates/ide/src/rename.rs
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Sat, 30 Oct 2021 14:17:04 +0000 (16:17 +0200)]
Expose version string of crates fom HIR
bors[bot] [Wed, 3 Nov 2021 14:02:10 +0000 (14:02 +0000)]
Merge #10596
10596: internal: Set server status to warning when proc-macro sources change r=Veykril a=Veykril
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/10027
![image](https://user-images.githubusercontent.com/
3757771 /
138102552 -
208d3edf -a843-49e6-9f48-
1e911f54a4ba .png)
It feels wrong using the database in this part of the code, but this was the only way to figure out whether a file belongs to a proc-macro that I could think of.
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Wed, 3 Nov 2021 13:42:15 +0000 (14:42 +0100)]
Add disjoint check back in TextEdit::union
Anatol Ulrich [Wed, 3 Nov 2021 13:21:29 +0000 (14:21 +0100)]
forgot a dbg
bors[bot] [Wed, 3 Nov 2021 07:40:23 +0000 (07:40 +0000)]
Merge #10683
10683: minor: Use `.into_iter()` method on array to avoid dereference r=lnicola a=arzg
Arguably it’s nicer to just use `.into_iter()` instead of iterating over references which are immediately dereferenced.
I also changed the use of `String::from` to `.to_string()` because the latter has around twenty times more usages in rust-analyzer.
Co-authored-by: Aramis Razzaghipour <aramisnoah@gmail.com>
Aramis Razzaghipour [Wed, 3 Nov 2021 05:13:47 +0000 (16:13 +1100)]
Use `.into_iter()` method on array to avoid dereference
Anatol Ulrich [Tue, 2 Nov 2021 20:38:38 +0000 (21:38 +0100)]
accept identical Indels when merging; add rename test case
bors[bot] [Sun, 31 Oct 2021 10:16:59 +0000 (10:16 +0000)]
Merge #10672
10672: feat: upgrade ubuntu builders r=matklad a=matklad
For `-gnu` triples, use 20.04, the current LTS. This upgrades the
required version of glibc. For musl, just use `latest` as, presumably,
we don't care about glibc version in that case.
Hopefully, this unbreaks nightly publishing!
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sun, 31 Oct 2021 10:07:30 +0000 (13:07 +0300)]
minor: group -gnu builders together
Aleksey Kladov [Sun, 31 Oct 2021 10:05:40 +0000 (13:05 +0300)]
feat: upgrade ubuntu builders
For `-gnu` triples, use 20.04, the current LTS. This upgrades the
required version of glibc. For musl, just use `latest` as, presumably,
we don't care about glibc version in that case.
bors[bot] [Sun, 31 Oct 2021 08:50:24 +0000 (08:50 +0000)]
Merge #10671
10671: minor: Run apt-get update for AArch64 builds r=lnicola a=lnicola
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Sun, 31 Oct 2021 08:49:43 +0000 (10:49 +0200)]
Run apt-get update for AArch64 builds
bors[bot] [Sat, 30 Oct 2021 14:42:53 +0000 (14:42 +0000)]
Merge #10668
10668: fix: Fix for-loop expressions breaking with BlockExpr iterable r=Veykril a=Veykril
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/10665
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>