]>
git.lizzy.rs Git - rust.git/log
Manish Goregaokar [Tue, 26 Sep 2017 02:52:20 +0000 (19:52 -0700)]
Fix dogfood needless-borrow
Manish Goregaokar [Tue, 26 Sep 2017 02:52:13 +0000 (19:52 -0700)]
Fix dogfood filter-map
Manish Goregaokar [Tue, 26 Sep 2017 02:44:50 +0000 (19:44 -0700)]
Reduce cyclomatic complexity of types::check_ty
Manish Goregaokar [Tue, 26 Sep 2017 02:04:55 +0000 (19:04 -0700)]
Rustup to rustc 1.22.0-nightly (
6c476ce46 2017-09-25)
Manish Goregaokar [Mon, 25 Sep 2017 20:52:23 +0000 (13:52 -0700)]
Update lockfile
Manish Goregaokar [Mon, 25 Sep 2017 20:52:17 +0000 (13:52 -0700)]
Update line numbers
Michal Budzynski [Thu, 14 Sep 2017 14:04:04 +0000 (16:04 +0200)]
stabilizing feature iterator_for_each for rust 1.21.0
Manish Goregaokar [Mon, 25 Sep 2017 17:22:57 +0000 (10:22 -0700)]
Merge pull request #2079 from rust-lang-nursery/ptr_arg-vs-capacity
avoid linting `ptr_arg` if `.capacity()` is called.
Oliver Schneider [Sun, 24 Sep 2017 11:57:56 +0000 (13:57 +0200)]
Merge pull request #2060 from mrecachinas/feature/int-plus-one
Addresses #1955 - Suggests >= y + 1 become > y
Michael Recachinas [Sun, 24 Sep 2017 11:31:12 +0000 (12:31 +0100)]
Change rtype of int_plus_one detection to Option<String>
Michael Recachinas [Sun, 24 Sep 2017 09:30:29 +0000 (10:30 +0100)]
Change to returning Option<(bool, Option<String>)>
Michael Recachinas [Sun, 24 Sep 2017 08:58:58 +0000 (09:58 +0100)]
Remove old return-value
Manish Goregaokar [Sat, 23 Sep 2017 20:47:07 +0000 (13:47 -0700)]
Merge pull request #2082 from rust-lang-nursery/rustup
Rust upgrade to rustc 1.22.0-nightly (
14039a42a 2017-09-22)
Manish Goregaokar [Sat, 23 Sep 2017 20:36:40 +0000 (13:36 -0700)]
fix docs
Manish Goregaokar [Sat, 23 Sep 2017 20:36:18 +0000 (13:36 -0700)]
Bump to 0.0.163
Manish Goregaokar [Sat, 23 Sep 2017 20:35:06 +0000 (13:35 -0700)]
Update test expectations
Manish Goregaokar [Sat, 23 Sep 2017 20:30:29 +0000 (13:30 -0700)]
Rust upgrade to rustc 1.22.0-nightly (
14039a42a 2017-09-22)
Michael Recachinas [Sat, 23 Sep 2017 18:32:11 +0000 (19:32 +0100)]
Use span_lint_and_then as per feedback
Andre Bogus [Wed, 20 Sep 2017 21:59:23 +0000 (23:59 +0200)]
avoid linting `ptr_arg` if `.capacity()` is called. Also suggest removing `.as_str()` where applicable.
THis fixes #2070.
Also fixes a few formatting mishaps
Manish Goregaokar [Tue, 19 Sep 2017 03:36:34 +0000 (20:36 -0700)]
Merge pull request #2069 from rust-lang-nursery/rustup
Rust upgrade to rustc 1.22.0-nightly (
0701b37d9 2017-09-18)
Manish Goregaokar [Tue, 19 Sep 2017 03:26:36 +0000 (20:26 -0700)]
Bump to 0.0.162
Manish Goregaokar [Tue, 19 Sep 2017 03:23:08 +0000 (20:23 -0700)]
Rust upgrade to rustc 1.22.0-nightly (
0701b37d9 2017-09-18)
Martin Carton [Mon, 18 Sep 2017 20:40:00 +0000 (22:40 +0200)]
Fix case in doc_valid_idents
BibTeX and BibLaTeX use the usual capitalization of TeX tools:
- https://www.ctan.org/pkg/bibtex
- https://www.ctan.org/pkg/biblatex
Martin Carton [Mon, 18 Sep 2017 20:34:43 +0000 (22:34 +0200)]
Merge pull request #2066 from lucab/ups/doc-markdown
lints/doc_markdown: add two more entries
Luca Bruno [Mon, 18 Sep 2017 14:44:28 +0000 (14:44 +0000)]
lints/doc_markdown: add two more entries
Michael Recachinas [Sun, 17 Sep 2017 16:27:40 +0000 (17:27 +0100)]
Add tests for 'int_plus_one'
Michael Recachinas [Sun, 17 Sep 2017 16:27:16 +0000 (17:27 +0100)]
Register 'int_plus_one' lint case in clippy_lints
Michael Recachinas [Sun, 17 Sep 2017 16:18:12 +0000 (17:18 +0100)]
(#1955): Suggests `x > y` over `x >= y + 1` for ints
This module handles the following cases:
- `... >= ... + 1` and `... >= 1 + ...`
- `... - 1 >= ...` and `-1 + ... >= ...`
- `... + 1 <= ...` and `... + 1 <= ...`
- `... <= ... - 1` and `... <= -1 + ...`
Note: this only goes 1 level deep (i.e., does not constant-fold) and
does not currently simplify expressions. Examples of these
cases include:
```rust
let x = 1;
y >= y + x; // won't catch this case or any permutation
x + 1 >= y + 2; // won't catch this case
x + 1 - 1 >= y - 1 + 1; // WILL catch this case when it likely shouldn't
```
Oliver Schneider [Sun, 17 Sep 2017 13:37:21 +0000 (15:37 +0200)]
Merge pull request #2058 from rust-lang-nursery/ptr_arg-vs-clone
add suggestions for .clone() in ptr_arg fns
llogiq [Sun, 17 Sep 2017 08:21:43 +0000 (10:21 +0200)]
Merge pull request #2059 from marcusklaas/manual-slice-clone4
Also detect manual slice cloning
Marcus Klaas [Sat, 16 Sep 2017 23:17:22 +0000 (19:17 -0400)]
Extend MANUAL_MEMCPY lint so that it also detects manual clones between slices
Marcus Klaas [Sat, 16 Sep 2017 22:53:55 +0000 (18:53 -0400)]
Add test for manual slice clones
Marcus Klaas [Sat, 16 Sep 2017 22:45:28 +0000 (18:45 -0400)]
Format loops.rs with latest stable rustfmt
llogiq [Sat, 16 Sep 2017 07:16:55 +0000 (09:16 +0200)]
Merge pull request #2057 from topecongiro/issue-1818
Enhance CHARS_*_CMP lint
llogiq [Sat, 16 Sep 2017 07:13:13 +0000 (09:13 +0200)]
Merge pull request #2056 from topecongiro/issue-1851
Add suggestion to needless_borrow
Andre Bogus [Sat, 16 Sep 2017 07:10:26 +0000 (09:10 +0200)]
add suggestions for .clone() in ptr_arg fns
topecongiro [Sat, 16 Sep 2017 05:50:30 +0000 (14:50 +0900)]
Update tests
topecongiro [Sat, 16 Sep 2017 05:50:07 +0000 (14:50 +0900)]
Enhance CHARS_*_CMP lint
topecongiro [Sat, 16 Sep 2017 02:27:46 +0000 (11:27 +0900)]
Update tests
topecongiro [Sat, 16 Sep 2017 02:27:24 +0000 (11:27 +0900)]
Add suggestion to needless_borrow
Oliver Schneider [Fri, 15 Sep 2017 07:21:46 +0000 (09:21 +0200)]
Merge pull request #2052 from topecongiro/issue-1990
Add ExprLoop to contains_continue_expr()
Seiichi Uchida [Thu, 14 Sep 2017 13:27:29 +0000 (22:27 +0900)]
Update a test
Seiichi Uchida [Thu, 14 Sep 2017 13:26:59 +0000 (22:26 +0900)]
Add ExprLoop to contains_continue_expr()
Seiichi Uchida [Thu, 14 Sep 2017 13:24:00 +0000 (22:24 +0900)]
Bump version
Oliver Schneider [Thu, 14 Sep 2017 07:13:54 +0000 (09:13 +0200)]
Version bump
Oliver Schneider [Thu, 14 Sep 2017 07:11:10 +0000 (09:11 +0200)]
Merge pull request #2049 from topecongiro/rustc-fix
rustc fix
topecongiro [Thu, 14 Sep 2017 04:18:34 +0000 (13:18 +0900)]
Remove '\t' from .stderr
to make cargo test pass
topecongiro [Thu, 14 Sep 2017 04:18:08 +0000 (13:18 +0900)]
Add a missing argument
Oliver Schneider [Wed, 13 Sep 2017 13:41:09 +0000 (15:41 +0200)]
Merge remote-tracking branch 'origin/master' into rustup
Oliver Schneider [Wed, 13 Sep 2017 13:34:04 +0000 (15:34 +0200)]
Rustup
llogiq [Tue, 12 Sep 2017 18:12:48 +0000 (20:12 +0200)]
Merge pull request #2046 from siiptuo/small-doc-fixes
Small documentation fixes
Tuomas Siipola [Tue, 12 Sep 2017 16:04:57 +0000 (19:04 +0300)]
Fix link in trivial_regex
Tuomas Siipola [Tue, 12 Sep 2017 16:04:05 +0000 (19:04 +0300)]
Fix empty documentation in unit_expr
Tuomas Siipola [Tue, 12 Sep 2017 16:03:34 +0000 (19:03 +0300)]
Fix links in approx_const
Oliver Schneider [Tue, 12 Sep 2017 12:40:24 +0000 (14:40 +0200)]
Version bump
Oliver Schneider [Tue, 12 Sep 2017 12:26:40 +0000 (14:26 +0200)]
Rustup
Oliver Schneider [Tue, 12 Sep 2017 12:25:58 +0000 (14:25 +0200)]
Regressions (#2041)
Oliver Schneider [Mon, 11 Sep 2017 06:30:52 +0000 (08:30 +0200)]
Merge pull request #2039 from rust-lang-nursery/ptr-arg-suggestion
suggestion for ptr_arg
Andre Bogus [Sun, 10 Sep 2017 17:32:24 +0000 (19:32 +0200)]
suggestion for ptr_arg
Oliver Schneider [Sun, 10 Sep 2017 09:27:02 +0000 (11:27 +0200)]
Merge pull request #2037 from Aaron1011/clone-rc
Add CLONE_ON_REF_PTR lint
Aaron Hill [Sun, 10 Sep 2017 01:51:54 +0000 (21:51 -0400)]
Add CLONE_ON_REF_PTR lint
Closes issue #1645
Oliver Schneider [Sat, 9 Sep 2017 12:47:40 +0000 (14:47 +0200)]
Merge pull request #2034 from Aaron1011/update-rust
Update for latest Rust
Oliver Schneider [Sat, 9 Sep 2017 12:37:16 +0000 (14:37 +0200)]
Bump version
Oliver Schneider [Sat, 9 Sep 2017 12:06:41 +0000 (14:06 +0200)]
Use hir_id instead of fetching hir_id via the NodeId
Aaron Hill [Sat, 9 Sep 2017 05:23:08 +0000 (01:23 -0400)]
Update for latest Rust
This is mainly due to https://github.com/rust-lang/rust/commit/
dead08cb33134
Oliver Schneider [Fri, 8 Sep 2017 12:26:42 +0000 (14:26 +0200)]
Merge pull request #2029 from rust-lang-nursery/rustup
Soft rustup (only fixed some tests)
Oliver Schneider [Fri, 8 Sep 2017 10:28:31 +0000 (12:28 +0200)]
Soft rustup (only fixed some tests)
Oliver Schneider [Wed, 6 Sep 2017 05:57:57 +0000 (07:57 +0200)]
Merge pull request #1963 from rust-lang-nursery/upstream
Rust needs clippy to have a Cargo.lock
Manish Goregaokar [Tue, 5 Sep 2017 22:10:41 +0000 (15:10 -0700)]
Update changelog
Manish Goregaokar [Tue, 5 Sep 2017 22:09:39 +0000 (15:09 -0700)]
Merge pull request #2004 from sunfishcode/master
When suggesting `from(x)` for lossless casts, strip parens from `x`.
Manish Goregaokar [Tue, 5 Sep 2017 21:19:51 +0000 (14:19 -0700)]
format comment
Manish Goregaokar [Tue, 5 Sep 2017 21:19:00 +0000 (14:19 -0700)]
Merge pull request #2023 from montrivo/while_let_loop
`while_let_loop` doesn't take into account break-with-value #1948
Manish Goregaokar [Tue, 5 Sep 2017 20:30:40 +0000 (13:30 -0700)]
Merge pull request #2022 from rust-lang-nursery/oli-obk-patch-1
Also ignore `continue` statements in `is_unit_expr`
Tim Nielens [Tue, 5 Sep 2017 20:28:30 +0000 (22:28 +0200)]
`while_let_loop` doesn't take into account break-with-value #1948
Oliver Schneider [Tue, 5 Sep 2017 09:25:20 +0000 (11:25 +0200)]
Also ignore `continue` statements in `is_unit_expr`
Manish Goregaokar [Tue, 5 Sep 2017 19:10:53 +0000 (12:10 -0700)]
for loops -> for-loops
Dan Gohman [Tue, 5 Sep 2017 11:05:26 +0000 (04:05 -0700)]
Only strip parens for binary expressions.
Dan Gohman [Wed, 30 Aug 2017 23:45:36 +0000 (16:45 -0700)]
Add a testcase demonstrating how precedence interacts with the lossless-cast lint.
Dan Gohman [Wed, 30 Aug 2017 23:06:21 +0000 (16:06 -0700)]
When suggesting `from(x)` for lossless casts, strip parens from `x`.
Manish Goregaokar [Tue, 5 Sep 2017 16:45:14 +0000 (09:45 -0700)]
Update changelog
Manish Goregaokar [Tue, 5 Sep 2017 16:45:14 +0000 (09:45 -0700)]
Update changelog
Oliver Schneider [Tue, 5 Sep 2017 16:41:27 +0000 (18:41 +0200)]
Merge pull request #2021 from marcusklaas/needless-loop-2
Add lint to detect manual slice copies
Marcus Klaas [Tue, 5 Sep 2017 00:16:34 +0000 (20:16 -0400)]
Add lint to detect manual slice copies
Oliver Schneider [Tue, 5 Sep 2017 10:53:52 +0000 (12:53 +0200)]
Rustfmt for_loop.rs and add false positive tests
Oliver Schneider [Tue, 5 Sep 2017 09:33:04 +0000 (11:33 +0200)]
Run nightly rustfmt
Martin Carton [Mon, 4 Sep 2017 19:29:50 +0000 (21:29 +0200)]
Merge pull request #2020 from 0xbsec/patch-1
Fix "further information" link
M. Hasbini [Mon, 4 Sep 2017 17:03:51 +0000 (20:03 +0300)]
Fix "further information" link
"further information" link was missing the `v` part from the url.
e.g.
wrong (404 notfound): https://rust-lang-nursery.github.io/rust-clippy/0.0.157/index.html#map_entry
correct: https://rust-lang-nursery.github.io/rust-clippy/v0.0.157/index.html#map_entry
Oliver Schneider [Mon, 4 Sep 2017 15:07:19 +0000 (17:07 +0200)]
Version Bump
Oliver Schneider [Mon, 4 Sep 2017 15:05:47 +0000 (17:05 +0200)]
Fix `len_zero` ICE
Oliver Schneider [Mon, 4 Sep 2017 14:10:36 +0000 (16:10 +0200)]
Update to latest nightly
Manish Goregaokar [Sun, 3 Sep 2017 21:58:27 +0000 (14:58 -0700)]
Fix dogfood
Manish Goregaokar [Sun, 3 Sep 2017 21:15:15 +0000 (14:15 -0700)]
Run rustfmt
Manish Goregaokar [Sun, 3 Sep 2017 21:14:07 +0000 (14:14 -0700)]
Fix unit_expr expectations and changelog entry
Manish Goregaokar [Sun, 3 Sep 2017 21:02:16 +0000 (14:02 -0700)]
Merge branch 'pr-2016' into HEAD
Zaki Manian [Sun, 3 Sep 2017 21:01:29 +0000 (14:01 -0700)]
Mention the false positive
Manish Goregaokar [Sun, 3 Sep 2017 20:57:40 +0000 (13:57 -0700)]
Bump to 0.0.156
Manish Goregaokar [Sun, 3 Sep 2017 20:55:45 +0000 (13:55 -0700)]
Rustup to rustc 1.22.0-nightly (
744dd6c1d 2017-09-02) (fixes #2013)
Zaki Manian [Sun, 3 Sep 2017 20:46:49 +0000 (13:46 -0700)]
Rustfmt tests
Zaki Manian [Sun, 3 Sep 2017 20:39:49 +0000 (13:39 -0700)]
Fix all the clippy lints
Add false positive tests
Zaki Manian [Sun, 3 Sep 2017 19:50:02 +0000 (12:50 -0700)]
Remove direct call for Deref
Remove "assigns" from the lint