]> git.lizzy.rs Git - rust.git/log
rust.git
2 years agoRollup merge of #93080 - SkiFire13:itermut-as_mut_slice, r=m-ou-se
Dylan DPC [Mon, 20 Jun 2022 12:56:33 +0000 (14:56 +0200)]
Rollup merge of #93080 - SkiFire13:itermut-as_mut_slice, r=m-ou-se

Implement `core::slice::IterMut::as_mut_slice` and `impl<T> AsMut<[T]> for IterMut<'_, T>`

As per [the zulip discussion](https://rust-lang.zulipchat.com/#narrow/stream/219381-t-libs/topic/.60std.3A.3Aslice.3A.3AIterMut.3A.3Aas_mut_slice.60), the `AsMut` impl has been commented out, with a comment near the `#[unstable(...)]` to uncomment it when `as_mut_slice` gets stabilized.

2 years agoWindows: `CommandExt::async_pipes`
Chris Denton [Wed, 18 May 2022 18:52:10 +0000 (19:52 +0100)]
Windows: `CommandExt::async_pipes`

2 years agoAuto merge of #97674 - nnethercote:oblig-forest-tweaks, r=nikomatsakis
bors [Mon, 20 Jun 2022 10:58:56 +0000 (10:58 +0000)]
Auto merge of #97674 - nnethercote:oblig-forest-tweaks, r=nikomatsakis

Obligation forest tweaks

A few minor improvements to the code.

r? `@nikomatsakis`

2 years ago`Stdio::make_pipe`
Chris Denton [Wed, 18 May 2022 19:14:29 +0000 (20:14 +0100)]
`Stdio::make_pipe`

2 years agoDrop magic value 3 from code
Wei Liu [Sat, 18 Jun 2022 17:19:24 +0000 (17:19 +0000)]
Drop magic value 3 from code

Magic value 3 is used to create state for a yield point. It is in fact
the number of reserved variants.

Lift RESERVED_VARIANTS out to module scope and use it instead.

2 years agoOptimize heapsort
zhangyunhao [Mon, 20 Jun 2022 08:30:27 +0000 (08:30 +0000)]
Optimize heapsort

2 years agoAuto merge of #98284 - JohnTitor:rollup-7lbs143, r=JohnTitor
bors [Mon, 20 Jun 2022 08:18:07 +0000 (08:18 +0000)]
Auto merge of #98284 - JohnTitor:rollup-7lbs143, r=JohnTitor

Rollup of 5 pull requests

Successful merges:

 - #98183 (Fix pretty printing of empty bound lists in where-clause)
 - #98268 (Improve `lifetime arguments are not allowed on` error message)
 - #98273 (Fix minor documentation typo)
 - #98274 (Minor improvements on error for `Self` type in items that don't allow it)
 - #98281 (Fix typo in `HashMap::drain` docs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

2 years agoShow #![feature] in example.
Mara Bos [Mon, 20 Jun 2022 08:00:55 +0000 (10:00 +0200)]
Show #![feature] in example.

2 years agoRollup merge of #98281 - Nilstrieb:map-drain-typo, r=JohnTitor
Yuki Okushi [Mon, 20 Jun 2022 07:41:50 +0000 (16:41 +0900)]
Rollup merge of #98281 - Nilstrieb:map-drain-typo, r=JohnTitor

Fix typo in `HashMap::drain` docs

It's a map, not a vector.

Fixes #98275.

2 years agoRollup merge of #98274 - compiler-errors:self-type-error, r=cjgillot
Yuki Okushi [Mon, 20 Jun 2022 07:41:49 +0000 (16:41 +0900)]
Rollup merge of #98274 - compiler-errors:self-type-error, r=cjgillot

Minor improvements on error for `Self` type in items that don't allow it

Fixes #93796

2 years agoRollup merge of #98273 - Piturnah:patch-1, r=compiler-errors
Yuki Okushi [Mon, 20 Jun 2022 07:41:48 +0000 (16:41 +0900)]
Rollup merge of #98273 - Piturnah:patch-1, r=compiler-errors

Fix minor documentation typo

Fixes incorrect pluralisation of `crate` in documentation for rustc_trait_selection

2 years agoRollup merge of #98268 - compiler-errors:disallowed-generics-better, r=lcnr
Yuki Okushi [Mon, 20 Jun 2022 07:41:47 +0000 (16:41 +0900)]
Rollup merge of #98268 - compiler-errors:disallowed-generics-better, r=lcnr

Improve `lifetime arguments are not allowed on` error message

Actually mention what thing we're improperly trying to add lifetime generics to.

2 years agoRollup merge of #98183 - dtolnay:emptybound, r=lcnr
Yuki Okushi [Mon, 20 Jun 2022 07:41:46 +0000 (16:41 +0900)]
Rollup merge of #98183 - dtolnay:emptybound, r=lcnr

Fix pretty printing of empty bound lists in where-clause

Repro:

```rust
macro_rules! assert_item_stringify {
    ($item:item $expected:literal) => {
        assert_eq!(stringify!($item), $expected);
    };
}

fn main() {
    assert_item_stringify! {
        fn f<'a, T>() where 'a:, T: {}
        "fn f<'a, T>() where 'a:, T: {}"
    }
}
```

Previously this assertion would fail because rustc renders the where-clause as `where 'a, T` which is invalid syntax.

This PR makes the above assertion pass.

This bug also affects `-Zunpretty=expanded`. The intention is for that to emit syntactically valid code, but the buggy output is not valid Rust syntax.

```console
$ rustc <(echo "fn f<'a, T>() where 'a:, T: {}") -Zunpretty=expanded
#![feature(prelude_import)]
#![no_std]
#[prelude_import]
use ::std::prelude::rust_2015::*;
#[macro_use]
extern crate std;
fn f<'a, T>() where 'a, T {}
```

```console
$ rustc <(echo "fn f<'a, T>() where 'a:, T: {}") -Zunpretty=expanded | rustc -
error: expected `:`, found `,`
 --> <anon>:7:23
  |
7 | fn f<'a, T>() where 'a, T {}
  |                       ^ expected `:`
```

2 years agopoint at private fields in struct literal
Takayuki Maeda [Mon, 20 Jun 2022 07:29:05 +0000 (16:29 +0900)]
point at private fields in struct literal

2 years agoFix typo in `HashMap::drain` docs
nils [Mon, 20 Jun 2022 07:17:08 +0000 (09:17 +0200)]
Fix typo in `HashMap::drain` docs

It's a map, not a vector.

2 years agoAuto merge of #98264 - compiler-errors:missing-arg-placeholder, r=jackh726
bors [Mon, 20 Jun 2022 05:37:17 +0000 (05:37 +0000)]
Auto merge of #98264 - compiler-errors:missing-arg-placeholder, r=jackh726

Make missing argument placeholder more obvious that it's a placeholder

Use `/* ty */` instead of `{ty}`, since people might be misled into thinking that this is valid syntax, and not just a diagnostic placeholder.

Fixes #96880

2 years agoAdd blank lines between methods in `proc_macro_server.rs`.
Nicholas Nethercote [Mon, 20 Jun 2022 03:52:48 +0000 (13:52 +1000)]
Add blank lines between methods in `proc_macro_server.rs`.

Because that's the standard way of doing it.

2 years agoInclude ForeignItem when visiting types for WF check
Preston From [Thu, 16 Jun 2022 04:44:07 +0000 (22:44 -0600)]
Include ForeignItem when visiting types for WF check

Addresses Issue 95665 by including `hir::Node::ForeignItem` as a valid
type to visit in `diagnostic_hir_wf_check`.

Fixes #95665

2 years agoMerge `TokenStreamBuilder::push` into `TokenStreamBuilder::build`.
Nicholas Nethercote [Mon, 20 Jun 2022 03:00:43 +0000 (13:00 +1000)]
Merge `TokenStreamBuilder::push` into `TokenStreamBuilder::build`.

Both functions do some modifying of streams using `make_mut`:
- `push` sometimes glues the first token of the next stream to the last
  token of the first stream.
- `build` appends tokens to the first stream.

By doing all of this in the one place, things are simpler. The first
stream can be modified in both ways (if necessary) in the one place, and
any next stream with the first token removed doesn't need to be stored.

2 years agoMention formatting macros when encountering ArgumentV1::new in const
Michael Goulet [Mon, 20 Jun 2022 03:13:08 +0000 (20:13 -0700)]
Mention formatting macros when encountering ArgumentV1::new in const

2 years agoAuto merge of #97931 - xldenis:fix-if-let-source-scopes, r=nagisa
bors [Mon, 20 Jun 2022 03:08:52 +0000 (03:08 +0000)]
Auto merge of #97931 - xldenis:fix-if-let-source-scopes, r=nagisa

Fix `SourceScope` for `if let` bindings.

Fixes #97799.

I'm not sure how to test this properly, is there any way to observe the difference in behavior apart from `ui` tests? I'm worried that they would be overlooked in the case of a regression.

2 years agoDon't suggest adding Self as a type parameter
Michael Goulet [Mon, 20 Jun 2022 02:25:50 +0000 (19:25 -0700)]
Don't suggest adding Self as a type parameter

2 years agoMention what item is using an invalid `Self` type
Michael Goulet [Mon, 20 Jun 2022 02:24:28 +0000 (19:24 -0700)]
Mention what item is using an invalid `Self` type

2 years agoFix minor documentation typo
Peter Hebden [Mon, 20 Jun 2022 02:30:21 +0000 (03:30 +0100)]
Fix minor documentation typo

Incorrect pluralisation of `crate`

2 years agoBe more specific for what lifetimes are not allowed on
Michael Goulet [Mon, 20 Jun 2022 00:54:19 +0000 (17:54 -0700)]
Be more specific for what lifetimes are not allowed on

2 years agoAuto merge of #98265 - JohnTitor:rollup-wtfqc4g, r=JohnTitor
bors [Mon, 20 Jun 2022 00:40:07 +0000 (00:40 +0000)]
Auto merge of #98265 - JohnTitor:rollup-wtfqc4g, r=JohnTitor

Rollup of 4 pull requests

Successful merges:

 - #95534 (Add `core::mem::copy` to complement `core::mem::drop`.)
 - #97912 (Stabilize `Path::try_exists()` and improve doc)
 - #98225 (Make debug_triple depend on target json file content rather than file path)
 - #98257 (Fix typos in `IntoFuture` docs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

2 years agoBe more hygenic with spans
Michael Goulet [Sun, 19 Jun 2022 23:46:26 +0000 (16:46 -0700)]
Be more hygenic with spans

2 years agoUse `Span::eq_ctxt` method instead of `.ctxt() == .ctxt()`
Michael Goulet [Sun, 19 Jun 2022 23:27:29 +0000 (16:27 -0700)]
Use `Span::eq_ctxt` method instead of `.ctxt() == .ctxt()`

2 years agoOnly omit trailing comma if block doesn't come from macro expansion
Michael Goulet [Sun, 19 Jun 2022 23:27:26 +0000 (16:27 -0700)]
Only omit trailing comma if block doesn't come from macro expansion

2 years agoRemove `TokenStream::from_streams`.
Nicholas Nethercote [Sun, 19 Jun 2022 23:33:08 +0000 (09:33 +1000)]
Remove `TokenStream::from_streams`.

By inlining it into the only non-test call site. The one test call site
is changed to use `TokenStreamBuilder`.

2 years agoRemove `Cursor::index`.
Nicholas Nethercote [Sun, 19 Jun 2022 23:27:58 +0000 (09:27 +1000)]
Remove `Cursor::index`.

It's unused.

2 years agoRemove `Cursor::append`.
Nicholas Nethercote [Sun, 19 Jun 2022 23:14:18 +0000 (09:14 +1000)]
Remove `Cursor::append`.

It's a weird function: it lets you modify the token stream in the middle
of iteration. There is only one call site, and it is only used for the
rare `ProceduralMasquerade` legacy case.

2 years agoRollup merge of #98257 - kadiwa4:into_future_doc_typos, r=Dylan-DPC
Yuki Okushi [Sun, 19 Jun 2022 22:37:43 +0000 (07:37 +0900)]
Rollup merge of #98257 - kadiwa4:into_future_doc_typos, r=Dylan-DPC

Fix typos in `IntoFuture` docs

2 years agoRollup merge of #98225 - bjorn3:stable_target_json_hash, r=nagisa
Yuki Okushi [Sun, 19 Jun 2022 22:37:42 +0000 (07:37 +0900)]
Rollup merge of #98225 - bjorn3:stable_target_json_hash, r=nagisa

Make debug_triple depend on target json file content rather than file path

This ensures that changes to target json files will force a recompilation. And more importantly that moving the files doesn't force a recompilation.

This should fix https://github.com/Rust-for-Linux/linux/issues/792 (cc ``@ojeda)``

2 years agoRollup merge of #97912 - Kixunil:stabilize_path_try_exists, r=dtolnay
Yuki Okushi [Sun, 19 Jun 2022 22:37:41 +0000 (07:37 +0900)]
Rollup merge of #97912 - Kixunil:stabilize_path_try_exists, r=dtolnay

Stabilize `Path::try_exists()` and improve doc

This stabilizes the `Path::try_exists()` method which returns
`Result<bool, io::Error>` instead of `bool` allowing handling of errors
unrelated to the file not existing. (e.g permission errors)

Along with the stabilization it also:

* Warns that the `exists()` method is error-prone and suggests to use
  the newly stabilized one.
* Suggests it instead of `metadata()` to handle errors.
* Mentions TOCTOU bugs to avoid false assumption that `try_exists()` is
  completely safe fixed version of `exists()`.
* Renames the feature of still-unstable `std::fs::try_exists()` to
  `fs_try_exists` to avoid name conflict.

The tracking issue #83186 remains open to track `fs_try_exists`.

2 years agoRollup merge of #95534 - jyn514:std-mem-copy, r=joshtriplett
Yuki Okushi [Sun, 19 Jun 2022 22:37:40 +0000 (07:37 +0900)]
Rollup merge of #95534 - jyn514:std-mem-copy, r=joshtriplett

Add `core::mem::copy` to complement `core::mem::drop`.

This is useful for combinators. I didn't add `clone` since you can already
use `Clone::clone` in its place; copy has no such corresponding function.

2 years agoAuto merge of #97268 - jyn514:faster-assemble, r=Mark-Simulacrum
bors [Sun, 19 Jun 2022 22:22:07 +0000 (22:22 +0000)]
Auto merge of #97268 - jyn514:faster-assemble, r=Mark-Simulacrum

Make "Assemble stage1 compiler" orders of magnitude faster (take 2)

This used to take upwards of 5 seconds for me locally. I found that the culprit was copying the downloaded LLVM shared object:
```
[22:28:03] Install "/home/jnelson/rust-lang/rust/build/x86_64-unknown-linux-gnu/ci-llvm/lib/libLLVM-14-rust-1.62.0-nightly.so" to "/home/jnelson/rust-lang/rust/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libLLVM-14-rust-1.62.0-nightly.so"
[22:28:09]   c Sysroot { compiler: Compiler { stage: 1, host: x86_64-unknown-linux-gnu(x86_64-unknown-linux-gnu) } }
```

It turned out that `install()` used full copies unconditionally. Change it to try using a hard-link before falling back to copying.

- Panic if we generate a symbolic link in a tarball
- Change install to use copy internally, like in my previous PR
- Change copy to dereference symbolic links, which avoids the previous regression in #96803.

I also took the liberty of fixing `x dist llvm-tools` to work even if you don't call `x build` previously.

2 years agoMake missing argument placeholder more obvious that it's a placeholder
Michael Goulet [Sun, 19 Jun 2022 22:10:42 +0000 (15:10 -0700)]
Make missing argument placeholder more obvious that it's a placeholder

2 years agoAdd `core::mem::copy` to complement `core::mem::drop`.
Joshua Nelson [Thu, 31 Mar 2022 18:01:26 +0000 (13:01 -0500)]
Add `core::mem::copy` to complement `core::mem::drop`.

This is useful for combinators. I didn't add `clone` since you can already
use `Clone::clone` in its place; copy has no such corresponding function.

2 years agoOnly use special async fn case for actual async fns in borrowck diagnostics.
Camille GILLOT [Fri, 13 May 2022 17:08:57 +0000 (19:08 +0200)]
Only use special async fn case for actual async fns in borrowck diagnostics.

2 years agoMake "Assemble stage1 compiler" orders of magnitude faster
Joshua Nelson [Sat, 7 May 2022 03:42:36 +0000 (22:42 -0500)]
Make "Assemble stage1 compiler" orders of magnitude faster

This used to take upwards of 5 seconds for me locally. I found that the
culprit was copying the downloaded LLVM shared object:
```
[22:28:03] Install "/home/jnelson/rust-lang/rust/build/x86_64-unknown-linux-gnu/ci-llvm/lib/libLLVM-14-rust-1.62.0-nightly.so" to "/home/jnelson/rust-lang/rust/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libLLVM-14-rust-1.62.0-nightly.so"
[22:28:09]   c Sysroot { compiler: Compiler { stage: 1, host: x86_64-unknown-linux-gnu(x86_64-unknown-linux-gnu) } }
```

It turned out that `install()` used full copies unconditionally. Change
it to use `copy()` internally, which uses hard links instead when
available.

Note that this has a change in behavior: Installing a file will also
change permissions on the source, not just the destination, if hard
links are used.

To avoid changing the behavior on symlinks for existing code, I
introduce a new function `copy_internal` which only dereferences
symlinks when told to do so.

2 years agoPanic if `dist` generates a symbolic link in a generated tarball
Joshua Nelson [Thu, 26 May 2022 15:27:44 +0000 (11:27 -0400)]
Panic if `dist` generates a symbolic link in a generated tarball

This avoids regressions in rustup-toolchain-install-master

2 years agoLeave the responsibility to create `Fresh` lifetimes to lowering.
Camille GILLOT [Mon, 6 Jun 2022 07:02:24 +0000 (09:02 +0200)]
Leave the responsibility to create `Fresh` lifetimes to lowering.

2 years agoGreatly improve error reporting for futures and generators in `note_obligation_cause_...
Joshua Nelson [Sun, 19 Jun 2022 18:59:36 +0000 (13:59 -0500)]
Greatly improve error reporting for futures and generators in `note_obligation_cause_code`

Most futures don't go through this code path, because they're caught by
`maybe_note_obligation_cause_for_async_await`. But all generators do,
and `maybe_note` is imperfect and doesn't catch all futures. Improve the error message for those it misses.

At some point, we may want to consider unifying this with the code for `maybe_note_async_await`,
so that `async_await` notes all parent constraints, and `note_obligation` can point to yield points.
But both functions are quite complicated, and it's not clear to me how to combine them;
this seems like a good incremental improvement.

2 years agoMake matches exhaustive.
Camille GILLOT [Sun, 5 Jun 2022 19:55:30 +0000 (21:55 +0200)]
Make matches exhaustive.

2 years agoRemove the `region` terminology.
Camille GILLOT [Sun, 5 Jun 2022 19:43:02 +0000 (21:43 +0200)]
Remove the `region` terminology.

2 years agoAuto merge of #98247 - jackh726:regionkind-rustc-type-ir, r=compiler-errors
bors [Sun, 19 Jun 2022 19:55:45 +0000 (19:55 +0000)]
Auto merge of #98247 - jackh726:regionkind-rustc-type-ir, r=compiler-errors

Move RegionKind to rustc_type_ir

(Also UniverseIndex)

r? rust-lang/types

2 years agoFix documentation for with_capacity and reserve families of methods
jmaargh [Sat, 9 Apr 2022 15:42:26 +0000 (16:42 +0100)]
Fix documentation for with_capacity and reserve families of methods

Documentation for the following methods

    with_capacity
    with_capacity_in
    with_capacity_and_hasher
    reserve
    reserve_exact
    try_reserve
    try_reserve_exact

was inconsistent and often not entirely correct where they existed on the following types

    Vec
    VecDeque
    String
    OsString
    PathBuf
    BinaryHeap
    HashSet
    HashMap
    BufWriter
    LineWriter

since the allocator is allowed to allocate more than the requested capacity in all such cases, and will frequently "allocate" much more in the case of zero-sized types (I also checked BufReader, but there the docs appear to be accurate as it appears to actually allocate the exact capacity).

Some effort was made to make the documentation more consistent between types as well.

Fix with_capacity* methods for Vec

Fix *reserve*  methods for Vec

Fix docs for *reserve* methods of VecDeque

Fix docs for String::with_capacity

Fix docs for *reserve* methods of String

Fix docs for OsString::with_capacity

Fix docs for *reserve* methods on OsString

Fix docs for with_capacity* methods on HashSet

Fix docs for *reserve methods of HashSet

Fix docs for with_capacity* methods of HashMap

Fix docs for *reserve methods on HashMap

Fix expect messages about OOM in doctests

Fix docs for BinaryHeap::with_capacity

Fix docs for *reserve* methods of BinaryHeap

Fix typos

Fix docs for with_capacity on BufWriter and LineWriter

Fix consistent use of `hasher` between `HashMap` and `HashSet`

Fix warning in doc test

Add test for capacity of vec with ZST

Fix doc test error

2 years agoAuto merge of #98224 - eddyb:proc-macro-spurious-repr, r=bjorn3
bors [Sun, 19 Jun 2022 17:32:12 +0000 (17:32 +0000)]
Auto merge of #98224 - eddyb:proc-macro-spurious-repr, r=bjorn3

proc_macro/bridge: remove `#[repr(C)]` from non-ABI-relevant types.

Not sure how this happened, maybe some of these were passed through the bridge a long time ago?

r? `@bjorn3`

2 years agoPreserve the path of the target spec json file for usage by rustdoc
bjorn3 [Sat, 18 Jun 2022 10:48:46 +0000 (10:48 +0000)]
Preserve the path of the target spec json file for usage by rustdoc

2 years agotypos in `IntoFuture` docs
KaDiWa4 [Sun, 19 Jun 2022 15:07:38 +0000 (17:07 +0200)]
typos in `IntoFuture` docs

2 years agoAuto merge of #98255 - Dylan-DPC:rollup-hr129rg, r=Dylan-DPC
bors [Sun, 19 Jun 2022 14:51:28 +0000 (14:51 +0000)]
Auto merge of #98255 - Dylan-DPC:rollup-hr129rg, r=Dylan-DPC

Rollup of 5 pull requests

Successful merges:

 - #98105 (rustdoc: remove tuple link on round braces)
 - #98136 (Rename `impl_constness` to `constness`)
 - #98146 (Remove --memory-init-file flag when linking with Emscripten)
 - #98219 (Skip late bound regions in GATSubstCollector)
 - #98233 (Remove accidental uses of `&A: Allocator`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

2 years agoRollup merge of #98233 - RalfJung:ref-alloc, r=thomcc
Dylan DPC [Sun, 19 Jun 2022 13:26:31 +0000 (15:26 +0200)]
Rollup merge of #98233 - RalfJung:ref-alloc, r=thomcc

Remove accidental uses of `&A: Allocator`

Cc https://github.com/rust-lang/rust/issues/98232

Fixes https://github.com/rust-lang/rust/issues/98176 (for real this time)

2 years agoRollup merge of #98219 - eggyal:gatsubstcollector-without-folding, r=jackh726
Dylan DPC [Sun, 19 Jun 2022 13:26:30 +0000 (15:26 +0200)]
Rollup merge of #98219 - eggyal:gatsubstcollector-without-folding, r=jackh726

Skip late bound regions in GATSubstCollector

#93227 liberated late bound regions when collecting GAT substs in wfcheck.  It should simply skip late bound regions instead.

r? ``@compiler-errors``

2 years agoRollup merge of #98146 - hoodmane:remove-memory-init-flag, r=petrochenkov
Dylan DPC [Sun, 19 Jun 2022 13:26:29 +0000 (15:26 +0200)]
Rollup merge of #98146 - hoodmane:remove-memory-init-flag, r=petrochenkov

Remove --memory-init-file flag when linking with Emscripten

This flag does nothing. It only applies when generating asmjs JavaScript.
``@sbc100``

2 years agoRollup merge of #98136 - fee1-dead-contrib:rename_impl_constness, r=oli-obk
Dylan DPC [Sun, 19 Jun 2022 13:26:28 +0000 (15:26 +0200)]
Rollup merge of #98136 - fee1-dead-contrib:rename_impl_constness, r=oli-obk

Rename `impl_constness` to `constness`

The current code is a basis for `is_const_fn_raw`, and `impl_constness`
is no longer a valid name, which is previously used for determining the
constness of impls, and not items in general.

r? `@oli-obk`

2 years agoRollup merge of #98105 - notriddle:notriddle/tuple-links, r=jsha
Dylan DPC [Sun, 19 Jun 2022 13:26:27 +0000 (15:26 +0200)]
Rollup merge of #98105 - notriddle:notriddle/tuple-links, r=jsha

rustdoc: remove tuple link on round braces

This is #98069 but for tuples. The reasoning is the same:

* This PR also changes it so that tuples with all-generic elements still link to the primitive.tuple.html page, just like slices. So there still plenty of on-ramps for anybody who doesn't know about it.
* It's too hard to see when round braces are a separate link from the type inside of them.
* It's too hard to click even if you do notice them.

Before:

* impl [ToSocketAddrs](https://doc.rust-lang.org/nightly/std/net/trait.ToSocketAddrs.html) for [(](https://doc.rust-lang.org/nightly/std/primitive.tuple.html)[IpAddr](https://doc.rust-lang.org/nightly/std/net/enum.IpAddr.html), [u16](https://doc.rust-lang.org/nightly/std/primitive.u16.html)[)](https://doc.rust-lang.org/nightly/std/primitive.tuple.html)
* impl<K, V> [FromIterator](https://notriddle.com/notriddle-rustdoc-test/std/iter/trait.FromIterator.html)<[(](https://notriddle.com/notriddle-rustdoc-test/std/primitive.tuple.html)K, V[)](https://notriddle.com/notriddle-rustdoc-test/std/primitive.tuple.html)> for [BTreeMap](https://notriddle.com/notriddle-rustdoc-test/std/collections/struct.BTreeMap.html)<K, V>

After:

* impl [ToSocketAddrs](https://doc.rust-lang.org/nightly/std/net/trait.ToSocketAddrs.html) for ([IpAddr](https://doc.rust-lang.org/nightly/std/net/enum.IpAddr.html), [u16](https://doc.rust-lang.org/nightly/std/primitive.u16.html))
* impl<K, V> [FromIterator](https://notriddle.com/notriddle-rustdoc-test/std/iter/trait.FromIterator.html)<[(K, V)](https://notriddle.com/notriddle-rustdoc-test/std/primitive.tuple.html)> for [BTreeMap](https://notriddle.com/notriddle-rustdoc-test/std/collections/struct.BTreeMap.html)<K, V>

2 years agoSmall refactoring
bjorn3 [Sun, 19 Jun 2022 12:49:12 +0000 (12:49 +0000)]
Small refactoring

2 years agoRemove the source archive functionality of ArchiveWriter
bjorn3 [Tue, 14 Jun 2022 15:16:51 +0000 (15:16 +0000)]
Remove the source archive functionality of ArchiveWriter

We now build archives through strictly additive means rather than taking
an existing archive and potentially substracting parts.

2 years agoFix "Remove src_files and remove_file"
bjorn3 [Sat, 18 Jun 2022 17:55:24 +0000 (17:55 +0000)]
Fix "Remove src_files and remove_file"

2 years agoAuto merge of #98238 - cjgillot:lint-mod, r=oli-obk
bors [Sun, 19 Jun 2022 12:28:59 +0000 (12:28 +0000)]
Auto merge of #98238 - cjgillot:lint-mod, r=oli-obk

Make some lints incremental.

Those lints do not track a state, so don't need to be performed for the full crate at once.

2 years agofix tests including dead_code warnings
Takayuki Maeda [Sun, 19 Jun 2022 12:00:25 +0000 (21:00 +0900)]
fix tests including dead_code warnings

2 years agocollapse dead code warnings into a single diagnostic
Takayuki Maeda [Fri, 10 Jun 2022 03:14:24 +0000 (12:14 +0900)]
collapse dead code warnings into a single diagnostic

add comments in `store_dead_field_or_variant`

support multiple log level

add a item ident label

fix ui tests

fix a ui test

fix a rustdoc ui test

use let chain

refactor: remove `store_dead_field_or_variant`

fix a tiny bug

2 years agoemit only one note per unused struct field
Takayuki Maeda [Wed, 8 Jun 2022 07:34:58 +0000 (16:34 +0900)]
emit only one note per unused struct field

2 years agoAuto merge of #97791 - m-ou-se:const-locks, r=m-ou-se
bors [Sun, 19 Jun 2022 08:20:36 +0000 (08:20 +0000)]
Auto merge of #97791 - m-ou-se:const-locks, r=m-ou-se

Make {Mutex, Condvar, RwLock}::new() const.

This makes it possible to have `static M: Mutex<_> = Mutex::new(..);` 🎉

Our implementations [on Linux](https://github.com/rust-lang/rust/pull/95035), [on Windows](https://github.com/rust-lang/rust/pull/77380), and various BSDs and some tier 3 platforms have already been using a non-allocating const-constructible implementation. As of https://github.com/rust-lang/rust/pull/97647, the remaining platforms (most notably macOS) now have a const-constructible implementation as well. This means we can finally make these functions publicly const.

Tracking issue: https://github.com/rust-lang/rust/issues/93740

2 years agoBless 32bit ui tests.
Camille GILLOT [Sun, 19 Jun 2022 07:53:00 +0000 (09:53 +0200)]
Bless 32bit ui tests.

2 years agoUse `ensure` for `UnusedBrokenConst`.
Camille GILLOT [Sun, 19 Jun 2022 07:44:23 +0000 (09:44 +0200)]
Use `ensure` for `UnusedBrokenConst`.

2 years agoAuto merge of #97367 - WaffleLapkin:stabilize_checked_slice_to_str_conv, r=dtolnay
bors [Sun, 19 Jun 2022 05:51:42 +0000 (05:51 +0000)]
Auto merge of #97367 - WaffleLapkin:stabilize_checked_slice_to_str_conv, r=dtolnay

Stabilize checked slice->str conversion functions

This PR stabilizes the following APIs as `const` functions in Rust 1.63:
```rust
// core::str

pub const fn from_utf8(v: &[u8]) -> Result<&str, Utf8Error>;

impl Utf8Error {
    pub const fn valid_up_to(&self) -> usize;
    pub const fn error_len(&self) -> Option<usize>;
}
```

Note that the `from_utf8_mut` function is not stabilized as unique references (`&mut _`) are [unstable in const context].

FCP: https://github.com/rust-lang/rust/issues/91006#issuecomment-1134593095

[unstable in const context]: https://github.com/rust-lang/rust/issues/57349

2 years agoMove RegionKind to rustc_type_ir
Jack Huey [Sun, 19 Jun 2022 04:20:27 +0000 (00:20 -0400)]
Move RegionKind to rustc_type_ir

2 years agoAuto merge of #97944 - nikic:freebsd-update, r=Mark-Simulacrum
bors [Sun, 19 Jun 2022 03:30:05 +0000 (03:30 +0000)]
Auto merge of #97944 - nikic:freebsd-update, r=Mark-Simulacrum

Update FreeBSD toolchain to 12.3

Update the FreeBSD toolchain to 12.3. FreeBSD 11 is EOL since September 30, 2021.

I've locally verified that the `dist-x86_64-freebsd` docker image builds successfully.

r? `@Mark-Simulacrum`

2 years agoENH Move --memory-init-file flag from EmLinker to asmjs target spec
Hood Chatham [Wed, 15 Jun 2022 19:33:27 +0000 (12:33 -0700)]
ENH Move --memory-init-file flag from EmLinker to asmjs target spec

2 years agoAuto merge of #98242 - matthiaskrgr:rollup-qbbkwtf, r=matthiaskrgr
bors [Sun, 19 Jun 2022 00:25:25 +0000 (00:25 +0000)]
Auto merge of #98242 - matthiaskrgr:rollup-qbbkwtf, r=matthiaskrgr

Rollup of 5 pull requests

Successful merges:

 - #97511 (Don't build the compiler before building rust-demangler)
 - #98165 (once cell renamings)
 - #98207 (Update cargo)
 - #98229 (Add new eslint checks)
 - #98230 (Fix weird js condition)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

2 years agoRollup merge of #98230 - GuillaumeGomez:weird-js-condition, r=notriddle
Matthias Krüger [Sat, 18 Jun 2022 22:17:16 +0000 (00:17 +0200)]
Rollup merge of #98230 - GuillaumeGomez:weird-js-condition, r=notriddle

Fix weird js condition

While going around the code, I found this weird condition. Fixing also affects the generated results in some cases apparently (could only find this one).

Any idea maybe `@notriddle?`

r? `@notriddle`

2 years agoRollup merge of #98229 - GuillaumeGomez:eslint-checks, r=Dylan-DPC
Matthias Krüger [Sat, 18 Jun 2022 22:17:15 +0000 (00:17 +0200)]
Rollup merge of #98229 - GuillaumeGomez:eslint-checks, r=Dylan-DPC

Add new eslint checks

r? ```@Dylan-DPC```

2 years agoRollup merge of #98207 - arlosi:update-cargo, r=Dylan-DPC
Matthias Krüger [Sat, 18 Jun 2022 22:17:14 +0000 (00:17 +0200)]
Rollup merge of #98207 - arlosi:update-cargo, r=Dylan-DPC

Update cargo

4 commits in 4d92f07f34ba7fb7d7f207564942508f46c225d3..8d42b0e8794ce3787c9f7d6d88b02ae80ebe8d19
2022-06-10 01:11:04 +0000 to 2022-06-17 16:46:26 +0000
- Use specific terminology for sparse HTTP-based registry (rust-lang/cargo#10764)
- chore: Upgrade to clap 3.2 (rust-lang/cargo#10753)
- Improve testing framework for http registries (rust-lang/cargo#10738)
- doc: Improve example of using the links field (rust-lang/cargo#10728)

2 years agoRollup merge of #98165 - WaffleLapkin:once_things_renamings, r=m-ou-se
Matthias Krüger [Sat, 18 Jun 2022 22:17:13 +0000 (00:17 +0200)]
Rollup merge of #98165 - WaffleLapkin:once_things_renamings, r=m-ou-se

once cell renamings

This PR does the renamings proposed in https://github.com/rust-lang/rust/issues/74465#issuecomment-1153703128

- Move/rename `lazy::{OnceCell, Lazy}` to `cell::{OnceCell, LazyCell}`
- Move/rename `lazy::{SyncOnceCell, SyncLazy}` to `sync::{OnceLock, LazyLock}`

(I used `Lazy...` instead of `...Lazy` as it seems to be more consistent, easier to pronounce, etc)

```@rustbot``` label +T-libs-api -T-libs

2 years agoRollup merge of #97511 - jyn514:faster-cargo-build, r=Mark-Simulacrum
Matthias Krüger [Sat, 18 Jun 2022 22:17:12 +0000 (00:17 +0200)]
Rollup merge of #97511 - jyn514:faster-cargo-build, r=Mark-Simulacrum

Don't build the compiler before building rust-demangler

This saves a lot of time compiling, since rust-demangler doesn't actually use any unstable features.

This is not quite ideal because it uses ToolStd, not ToolBootstrap, so rust-demangler would be able to add unstable library features in the future. But it's a lot better than before, and `builder.cargo` doesn't currently know how to handle stages other than 0.

2 years agoMake some lints incremental.
Camille GILLOT [Sat, 18 Jun 2022 17:48:44 +0000 (19:48 +0200)]
Make some lints incremental.

2 years agoAuto merge of #98237 - RalfJung:miri, r=RalfJung
bors [Sat, 18 Jun 2022 21:44:34 +0000 (21:44 +0000)]
Auto merge of #98237 - RalfJung:miri, r=RalfJung

update Miri

Fixes https://github.com/rust-lang/rust/issues/98107
r? `@ghost` Cc `@rust-lang/miri`

2 years agoRemove weird JS condition
Guillaume Gomez [Sat, 18 Jun 2022 14:11:12 +0000 (16:11 +0200)]
Remove weird JS condition

2 years agoupdate Miri
Ralf Jung [Sat, 18 Jun 2022 18:31:21 +0000 (11:31 -0700)]
update Miri

2 years agoAuto merge of #96501 - jyn514:individual-paths, r=Mark-Simulacrum
bors [Sat, 18 Jun 2022 18:02:39 +0000 (18:02 +0000)]
Auto merge of #96501 - jyn514:individual-paths, r=Mark-Simulacrum

Pass all paths to `Step::run` at once when using `ShouldRun::krate`

Helps with https://github.com/rust-lang/rust/pull/95503. The goal is to run `cargo test -p rustc_data_structures -p rustc_lint_defs` instead of `cargo test -p rustc_data_structures; cargo test -p rustc_lint_defs`, which should both recompile less and avoid replaying cached warnings.

This was surprisingly complicated. The main changes are:
1. Invert the order of iteration in `StepDescription::run`.

    Previously, it did something like:
    ```python
    for path in paths:
    for (step, should_run) in should_runs:
        if let Some(set) = should_run.pathset_for_path(path):
        step.run(builder, set)
    ```

    That worked ok for individual paths, but didn't allow passing more than one path at a time to `Step::run`
    (since `pathset_for_paths` only had one path available to it).
    Change it to instead look at the intersection of `paths` and `should_run.paths`:

    ```python
    for (step, should_run) in should_runs:
    if let Some(set) = should_run.pathset_for_paths(paths):
        step.run(builder, set)
    ```

2. Change `pathset_for_path` to take multiple pathsets.

    The goal is to avoid `x test library/alloc` testing *all* library crates, instead of just alloc.
    The changes here are similarly subtle, to use the intersection between the paths rather than all
    paths in `should_run.paths`. I added a test for the behavior to try and make it more clear.

    Note that we use pathsets instead of just paths to allow for sets with multiple aliases (*cough* `all_krates` *cough*).
    See the documentation added in the next commit for more detail.

3. Change `StepDescription::run` to explicitly handle 0 paths.

    Before this was implicitly handled by the `for` loop, which just didn't excute when there were no paths.
    Now it needs a check, to avoid trying to run all steps (this is a problem for steps that use `default_condition`).

4. Change `RunDescription` to have a list of pathsets, rather than a single path.

5. Remove paths as they're matched

    This allows checking at the end that no invalid paths are left over.
    Note that if two steps matched the same path, this will no longer run both;
    but that's a bug anyway.

6. Handle suite paths separately from regular sets.

    Running multiple suite paths at once instead of in separate `make_run` invocations is both tricky and not particularly useful.
    The respective test Steps already handle this by introspecting the original paths.

    Avoid having to deal with it by moving suite handling into a seperate loop than `PathSet::Set` checks.

`@rustbot` label +A-rustbuild

2 years agoFix bug when using `--bless`
Michael Howell [Sat, 18 Jun 2022 17:36:12 +0000 (10:36 -0700)]
Fix bug when using `--bless`

2 years agoAdd test cases for tuples with links
Michael Howell [Sat, 18 Jun 2022 17:35:19 +0000 (10:35 -0700)]
Add test cases for tuples with links

2 years agoAdd release notes for 1.62
Mark Rousskov [Fri, 27 May 2022 14:45:27 +0000 (10:45 -0400)]
Add release notes for 1.62

2 years agoAuto merge of #97924 - cuviper:unguarded-poison, r=Mark-Simulacrum
bors [Sat, 18 Jun 2022 15:18:50 +0000 (15:18 +0000)]
Auto merge of #97924 - cuviper:unguarded-poison, r=Mark-Simulacrum

Avoid `thread::panicking()` in non-poisoning methods of `Mutex` and `RwLock`

`Mutex::lock()` and `RwLock::write()` are poison-guarded against panics,
in that they set the poison flag if a panic occurs while they're locked.
But if we're already in a panic (`thread::panicking()`), they leave the
poison flag alone.

That check is a bit of a waste for methods that never set the poison
flag though, namely `get_mut()`, `into_inner()`, and `RwLock::read()`.
These use-cases are now split to avoid that unnecessary call.

2 years agoSeparate `AnonymousCreateParameter` and `ReportElidedInPath`.
Camille GILLOT [Sat, 21 May 2022 12:06:26 +0000 (14:06 +0200)]
Separate `AnonymousCreateParameter` and `ReportElidedInPath`.

2 years agoRefactor visit_fn.
Camille GILLOT [Sun, 5 Jun 2022 16:24:22 +0000 (18:24 +0200)]
Refactor visit_fn.

2 years agoAdd tests for fixed bugs
Joshua Nelson [Thu, 28 Apr 2022 04:43:33 +0000 (23:43 -0500)]
Add tests for fixed bugs

2 years agoRustfmt resolve_implementation.
Camille GILLOT [Sun, 5 Jun 2022 15:31:49 +0000 (17:31 +0200)]
Rustfmt resolve_implementation.

2 years agoExtract AssocItem handling.
Camille GILLOT [Fri, 1 Apr 2022 14:05:42 +0000 (16:05 +0200)]
Extract AssocItem handling.

2 years agoPass all paths to `Step::run` at once when using `ShouldRun::krate`
Joshua Nelson [Fri, 22 Apr 2022 03:19:36 +0000 (22:19 -0500)]
Pass all paths to `Step::run` at once when using `ShouldRun::krate`

This was surprisingly complicated. The main changes are:
1. Invert the order of iteration in `StepDescription::run`.

    Previously, it did something like:
    ```python
    for path in paths:
    for (step, should_run) in should_runs:
        if let Some(set) = should_run.pathset_for_path(path):
        step.run(builder, set)
    ```

    That worked ok for individual paths, but didn't allow passing more than one path at a time to `Step::run`
    (since `pathset_for_paths` only had one path available to it).
    Change it to instead look at the intersection of `paths` and `should_run.paths`:

    ```python
    for (step, should_run) in should_runs:
    if let Some(set) = should_run.pathset_for_paths(paths):
        step.run(builder, set)
    ```

2. Change `pathset_for_path` to take multiple pathsets.

    The goal is to avoid `x test library/alloc` testing *all* library crates, instead of just alloc.
    The changes here are similarly subtle, to use the intersection between the paths rather than all
    paths in `should_run.paths`. I added a test for the behavior to try and make it more clear.

    Note that we use pathsets instead of just paths to allow for sets with multiple aliases (*cough* `all_krates` *cough*).
    See the documentation added in the next commit for more detail.

3. Change `StepDescription::run` to explicitly handle 0 paths.

   Before this was implicitly handled by the `for` loop, which just didn't excute when there were no paths.
   Now it needs a check, to avoid trying to run all steps (this is a problem for steps that use `default_condition`).

4. Change `RunDescription` to have a list of pathsets, rather than a single path.

5. Remove paths as they're matched

   This allows checking at the end that no invalid paths are left over.
   Note that if two steps matched the same path, this will no longer run both;
   but that's a bug anyway.

6. Handle suite paths separately from regular sets.

   Running multiple suite paths at once instead of in separate `make_run` invocations is both tricky and not particularly useful.
   The respective test Steps already handle this by introspecting the original paths.

   Avoid having to deal with it by moving suite handling into a seperate loop than `PathSet::Set` checks.

2 years agomake std not use &A: Allocator instance
Ralf Jung [Sat, 18 Jun 2022 14:38:28 +0000 (07:38 -0700)]
make std not use &A: Allocator instance

2 years agomake btree not use &A: Allocator instance
Ralf Jung [Sat, 18 Jun 2022 14:37:41 +0000 (07:37 -0700)]
make btree not use &A: Allocator instance

2 years agoAdding new eslint checks:
Guillaume Gomez [Sat, 18 Jun 2022 14:02:44 +0000 (16:02 +0200)]
Adding new eslint checks:
 * no-sequences
 * no-throw-literal

2 years agoAuto merge of #98004 - paolobarbolini:vecdeque-extend-trustedlen, r=the8472
bors [Sat, 18 Jun 2022 12:54:01 +0000 (12:54 +0000)]
Auto merge of #98004 - paolobarbolini:vecdeque-extend-trustedlen, r=the8472

Add VecDeque::extend from TrustedLen specialization

Continuation of #95904

Inspired by how [`VecDeque::copy_slice` works](https://github.com/rust-lang/rust/blob/c08b235a5ce10167632bb0fddcd0c5d67f2d42e3/library/alloc/src/collections/vec_deque/mod.rs#L437-L454).

## Benchmarks

Before

```
test vec_deque::bench_extend_chained_bytes      ... bench:       1,026 ns/iter (+/- 17)
test vec_deque::bench_extend_chained_trustedlen ... bench:       1,024 ns/iter (+/- 40)
test vec_deque::bench_extend_trustedlen         ... bench:         637 ns/iter (+/- 693)
```

After

```
test vec_deque::bench_extend_chained_bytes      ... bench:         828 ns/iter (+/- 24)
test vec_deque::bench_extend_chained_trustedlen ... bench:          25 ns/iter (+/- 1)
test vec_deque::bench_extend_trustedlen         ... bench:          21 ns/iter (+/- 0)
```

## Why do it this way

https://rust.godbolt.org/z/15qY1fMYh

The Compiler Explorer example shows how "just" removing the capacity check, like the [`Vec` `TrustedLen` specialization](https://github.com/rust-lang/rust/blob/c08b235a5ce10167632bb0fddcd0c5d67f2d42e3/library/alloc/src/vec/spec_extend.rs#L22-L58) does, wouldn't have been enough for `VecDeque`. `wrap_add` would still have greatly limited what LLVM could do while optimizing.

---

r? `@the8472`

2 years agoMake debug_triple depend on target json file content rather than file path
bjorn3 [Sat, 18 Jun 2022 10:19:24 +0000 (10:19 +0000)]
Make debug_triple depend on target json file content rather than file path

This ensures that changes to target json files will force a
recompilation. And more importantly that moving the files doesn't force
a recompilation.

2 years agoAuto merge of #98153 - nnethercote:fix-MissingDoc-quadratic-behaviour, r=cjgillot
bors [Sat, 18 Jun 2022 09:57:00 +0000 (09:57 +0000)]
Auto merge of #98153 - nnethercote:fix-MissingDoc-quadratic-behaviour, r=cjgillot

Fix `MissingDoc` quadratic behaviour

Best reviewed one commit at a time.

r? `@cjgillot`

2 years agoproc_macro/bridge: remove `#[repr(C)]` from non-ABI-relevant types.
Eduard-Mihai Burtescu [Sat, 18 Jun 2022 09:14:25 +0000 (09:14 +0000)]
proc_macro/bridge: remove `#[repr(C)]` from non-ABI-relevant types.

2 years agoAuto merge of #98186 - mystor:tokenstream_as_vec_tt, r=eddyb
bors [Sat, 18 Jun 2022 07:37:14 +0000 (07:37 +0000)]
Auto merge of #98186 - mystor:tokenstream_as_vec_tt, r=eddyb

Batch proc_macro RPC for TokenStream iteration and combination operations

This is the first part of #86822, split off as requested in https://github.com/rust-lang/rust/pull/86822#pullrequestreview-1008655452. It reduces the number of RPC calls required for common operations such as iterating over and concatenating TokenStreams.