]>
git.lizzy.rs Git - rust.git/log
bors[bot] [Fri, 10 Jul 2020 21:20:36 +0000 (21:20 +0000)]
Merge #5300
5300: Update deps r=matklad a=kjeremy
Bumps tracing to 0.1.16 which reduces monomorphization: https://github.com/rust-analyzer/rust-analyzer/issues/1987#issuecomment-
654711560
Co-authored-by: kjeremy <kjeremy@gmail.com>
kjeremy [Fri, 10 Jul 2020 21:14:24 +0000 (17:14 -0400)]
Update deps
bors[bot] [Fri, 10 Jul 2020 20:31:11 +0000 (20:31 +0000)]
Merge #5299
5299: Reload when new example/test/etc is added r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 10 Jul 2020 20:29:40 +0000 (22:29 +0200)]
Optimize VFS processing
Aleksey Kladov [Fri, 10 Jul 2020 20:28:41 +0000 (22:28 +0200)]
Sort cargo metadata
See https://github.com/rust-lang/cargo/issues/8477
We need this to prevent spurious workspace reloads
Aleksey Kladov [Fri, 10 Jul 2020 16:53:01 +0000 (18:53 +0200)]
Add profiling calls
Aleksey Kladov [Fri, 10 Jul 2020 16:48:39 +0000 (18:48 +0200)]
Also reload when adding new examples, tests, etc
bors[bot] [Fri, 10 Jul 2020 16:22:38 +0000 (16:22 +0000)]
Merge #5298
5298: Better caret placement when filling match arms r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 10 Jul 2020 16:22:04 +0000 (18:22 +0200)]
Better caret placement when filling match arms
bors[bot] [Fri, 10 Jul 2020 15:57:18 +0000 (15:57 +0000)]
Merge #5297
5297: Better name r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 10 Jul 2020 15:56:55 +0000 (17:56 +0200)]
Better name
bors[bot] [Fri, 10 Jul 2020 15:43:14 +0000 (15:43 +0000)]
Merge #5296
5296: Don't add braces after struct r=matklad a=matklad
Unit structs are a thing
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 10 Jul 2020 15:42:18 +0000 (17:42 +0200)]
Don't add braces after struct
Unit structs are a thing
Aleksey Kladov [Fri, 10 Jul 2020 15:41:43 +0000 (17:41 +0200)]
Better complete expression keywords
bors[bot] [Fri, 10 Jul 2020 14:29:37 +0000 (14:29 +0000)]
Merge #5295
5295: Complete params in nested fns r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 10 Jul 2020 14:29:14 +0000 (16:29 +0200)]
Complete params in nested fns
bors[bot] [Fri, 10 Jul 2020 14:08:36 +0000 (14:08 +0000)]
Merge #5294
5294: Complete parameters more aggressively r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 10 Jul 2020 14:07:12 +0000 (16:07 +0200)]
Complete parameters more aggressively
Aleksey Kladov [Fri, 10 Jul 2020 14:05:01 +0000 (16:05 +0200)]
Refresh tests
bors[bot] [Fri, 10 Jul 2020 13:35:46 +0000 (13:35 +0000)]
Merge #5293
5293: Automatically reload project info on Cargo.toml changes r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 10 Jul 2020 13:27:34 +0000 (15:27 +0200)]
Automatically reload project info on Cargo.toml changes
bors[bot] [Fri, 10 Jul 2020 12:47:23 +0000 (12:47 +0000)]
Merge #5292
5292: Goto type definition improvements r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 10 Jul 2020 12:42:26 +0000 (14:42 +0200)]
Look through Arc for goto type definition
Aleksey Kladov [Fri, 10 Jul 2020 12:39:05 +0000 (14:39 +0200)]
Simplify tests
Aleksey Kladov [Fri, 10 Jul 2020 12:11:31 +0000 (14:11 +0200)]
Dont expose ID
Aleksey Kladov [Fri, 10 Jul 2020 12:09:31 +0000 (14:09 +0200)]
Rename
Aleksey Kladov [Fri, 10 Jul 2020 12:08:35 +0000 (14:08 +0200)]
Goto type definition works for self
bors[bot] [Fri, 10 Jul 2020 09:33:29 +0000 (09:33 +0000)]
Merge #5286
5286: Only take first 500 syntax errors r=jonas-schievink a=yihuang
Too many syntax errors make some editor/ide slow, fix #3434.
Co-authored-by: yihuang <yi.codeplayer@gmail.com>
yihuang [Fri, 10 Jul 2020 07:41:41 +0000 (15:41 +0800)]
Only take first 500 syntax errors
Too many syntax errors make some editor/ide slow, fix #3434.
bors[bot] [Fri, 10 Jul 2020 09:09:09 +0000 (09:09 +0000)]
Merge #5288
5288: Avoid accidently stumping over config values r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 9 Jul 2020 22:28:12 +0000 (00:28 +0200)]
Avoid accidently stumping over config values
bors[bot] [Thu, 9 Jul 2020 17:22:16 +0000 (17:22 +0000)]
Merge #5285
5285: Don't mess with cursor position when adding hashes r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 9 Jul 2020 17:21:41 +0000 (19:21 +0200)]
Don't mess with cursor position when adding hashes
bors[bot] [Thu, 9 Jul 2020 16:49:44 +0000 (16:49 +0000)]
Merge #5284
5284: Fold struct literals r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 9 Jul 2020 16:49:17 +0000 (18:49 +0200)]
Fold struct literals
bors[bot] [Thu, 9 Jul 2020 16:28:35 +0000 (16:28 +0000)]
Merge #5283
5283: Arg count mismatch diagnostic: Handle tuple struct/variant ctors r=jonas-schievink a=jonas-schievink
I didn't know `callable_item_signature` was a thing, that makes this really easy.
bors r+
Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
Jonas Schievink [Thu, 9 Jul 2020 16:24:02 +0000 (18:24 +0200)]
arg count mismatch: handle tuple ctors
bors[bot] [Thu, 9 Jul 2020 15:34:43 +0000 (15:34 +0000)]
Merge #5270
5270: Add argument count mismatch diagnostic r=matklad a=jonas-schievink
Closes https://github.com/rust-analyzer/rust-analyzer/issues/4025.
This currently has one false positive on this line, where `max` is resolved to `Iterator::max` instead of `Ord::max`:
https://github.com/rust-analyzer/rust-analyzer/blob/
8aa10c00a4c5b957d459fac5a103cd9688e8dcdd /crates/expect/src/lib.rs#L263
(I have no idea why it thinks that `usize` is an `Iterator`)
TODO:
* [x] Tests
* [x] Improve diagnostic text for method calls
Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
Jonas Schievink [Thu, 9 Jul 2020 15:33:49 +0000 (17:33 +0200)]
Address review comments
bors[bot] [Thu, 9 Jul 2020 14:19:14 +0000 (14:19 +0000)]
Merge #5282
5282: Move diagnostics tests to expect r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 9 Jul 2020 14:12:53 +0000 (16:12 +0200)]
Always put config first
Aleksey Kladov [Thu, 9 Jul 2020 14:04:29 +0000 (16:04 +0200)]
Move diagnostics tests to expect
Jonas Schievink [Thu, 9 Jul 2020 13:52:10 +0000 (15:52 +0200)]
Add tests
Jonas Schievink [Thu, 9 Jul 2020 13:51:32 +0000 (15:51 +0200)]
Fix diagnostic for method calls
Jonas Schievink [Thu, 9 Jul 2020 13:50:53 +0000 (15:50 +0200)]
Correctly pluralize message
Jonas Schievink [Thu, 9 Jul 2020 13:50:35 +0000 (15:50 +0200)]
Remove unnecessary DiagnosticSink handlers
Aleksey Kladov [Thu, 9 Jul 2020 13:41:13 +0000 (15:41 +0200)]
Add fixmes
Aleksey Kladov [Thu, 9 Jul 2020 13:35:52 +0000 (15:35 +0200)]
Simplify
Aleksey Kladov [Thu, 9 Jul 2020 13:34:37 +0000 (15:34 +0200)]
Cleanup diagnostic conversion code
bors[bot] [Thu, 9 Jul 2020 12:45:24 +0000 (12:45 +0000)]
Merge #5281
5281: Remove insta from ra_ide r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 9 Jul 2020 12:33:57 +0000 (14:33 +0200)]
Remove insta from ra_ide
Aleksey Kladov [Thu, 9 Jul 2020 12:33:03 +0000 (14:33 +0200)]
Cleanup diagnostics tests
Aleksey Kladov [Thu, 9 Jul 2020 11:59:49 +0000 (13:59 +0200)]
Reduce code duplication
Jonas Schievink [Thu, 9 Jul 2020 10:41:35 +0000 (12:41 +0200)]
Don't emit diagnostic if there are type errors
Jonas Schievink [Wed, 8 Jul 2020 17:58:45 +0000 (19:58 +0200)]
Add argument count mismatch diagnostic
bors[bot] [Thu, 9 Jul 2020 10:15:20 +0000 (10:15 +0000)]
Merge #5280
5280: Re-enable IDE features for incomplete impl blocs r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 9 Jul 2020 10:14:26 +0000 (12:14 +0200)]
Re-enable IDE features for incomplete impl blocs
bors[bot] [Thu, 9 Jul 2020 09:48:40 +0000 (09:48 +0000)]
Merge #5279
5279: Simplify r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 9 Jul 2020 09:47:27 +0000 (11:47 +0200)]
Simplify
bors[bot] [Thu, 9 Jul 2020 09:01:45 +0000 (09:01 +0000)]
Merge #5278
5278: expect should be a dev dep r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 9 Jul 2020 08:59:41 +0000 (10:59 +0200)]
expect should be a dev dep
Aleksey Kladov [Thu, 9 Jul 2020 08:58:56 +0000 (10:58 +0200)]
Unify tests
bors[bot] [Thu, 9 Jul 2020 08:34:12 +0000 (08:34 +0000)]
Merge #5276
5276: Streamline r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 9 Jul 2020 08:33:32 +0000 (10:33 +0200)]
No blank indent
Aleksey Kladov [Thu, 9 Jul 2020 08:30:47 +0000 (10:30 +0200)]
Prettier rendering
Aleksey Kladov [Thu, 9 Jul 2020 08:19:37 +0000 (10:19 +0200)]
Streamline
Aleksey Kladov [Thu, 9 Jul 2020 08:03:28 +0000 (10:03 +0200)]
Reduce API
Aleksey Kladov [Thu, 9 Jul 2020 07:56:15 +0000 (09:56 +0200)]
Cleanup
Aleksey Kladov [Thu, 9 Jul 2020 07:42:01 +0000 (09:42 +0200)]
Reduce API
Aleksey Kladov [Thu, 9 Jul 2020 07:39:53 +0000 (09:39 +0200)]
Rename
bors[bot] [Wed, 8 Jul 2020 22:11:52 +0000 (22:11 +0000)]
Merge #5273
5273: Refactor hover tests r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 8 Jul 2020 22:07:32 +0000 (00:07 +0200)]
Refactor hover tests
Aleksey Kladov [Wed, 8 Jul 2020 21:06:15 +0000 (23:06 +0200)]
Simplify tests
Aleksey Kladov [Wed, 8 Jul 2020 20:47:50 +0000 (22:47 +0200)]
better language
Aleksey Kladov [Wed, 8 Jul 2020 20:37:35 +0000 (22:37 +0200)]
Add Markup type
bors[bot] [Wed, 8 Jul 2020 20:03:19 +0000 (20:03 +0000)]
Merge #5272
5272: :arrow_up: deps r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 8 Jul 2020 20:02:54 +0000 (22:02 +0200)]
:arrow_up: deps
bors[bot] [Wed, 8 Jul 2020 18:42:46 +0000 (18:42 +0000)]
Merge #5271
5271: Tidyup hover r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 8 Jul 2020 18:26:20 +0000 (20:26 +0200)]
simplify
Aleksey Kladov [Wed, 8 Jul 2020 17:58:50 +0000 (19:58 +0200)]
Minimize API
Aleksey Kladov [Wed, 8 Jul 2020 17:54:50 +0000 (19:54 +0200)]
Dead code
Aleksey Kladov [Wed, 8 Jul 2020 17:41:57 +0000 (19:41 +0200)]
Reduce visibility
bors[bot] [Wed, 8 Jul 2020 17:33:03 +0000 (17:33 +0000)]
Merge #5266
5266: Remove relative_path dependency r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 8 Jul 2020 17:09:42 +0000 (19:09 +0200)]
Remove relative_path dependency
Aleksey Kladov [Wed, 8 Jul 2020 16:22:57 +0000 (18:22 +0200)]
Remove unwanted dependency
Aleksey Kladov [Wed, 8 Jul 2020 16:17:45 +0000 (18:17 +0200)]
Document failed refactor
bors[bot] [Wed, 8 Jul 2020 13:55:56 +0000 (13:55 +0000)]
Merge #5263
5263: Fix some clippy perf warnings r=matklad a=kjeremy
Co-authored-by: kjeremy <kjeremy@gmail.com>
kjeremy [Wed, 8 Jul 2020 13:45:29 +0000 (09:45 -0400)]
Clippy perf warnings
bors[bot] [Wed, 8 Jul 2020 12:12:14 +0000 (12:12 +0000)]
Merge #5262
5262: Workaround rollup messing up default imports r=matklad a=Veetaha
Tackles https://github.com/rust-analyzer/rust-analyzer/issues/5257#issuecomment-
655435271
Related: https://github.com/rollup/plugins/issues/491
Co-authored-by: Veetaha <veetaha2@gmail.com>
Veetaha [Wed, 8 Jul 2020 11:47:34 +0000 (14:47 +0300)]
Workaround rollup messing up default imports
bors[bot] [Tue, 7 Jul 2020 21:32:08 +0000 (21:32 +0000)]
Merge #5255
5255: Replace ad hocery with science r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 7 Jul 2020 20:53:12 +0000 (22:53 +0200)]
Replace ad hocery with science
bors[bot] [Tue, 7 Jul 2020 20:36:18 +0000 (20:36 +0000)]
Merge #4972
4972: Gzip artifacts r=Veetaha a=Veetaha
[Here is the test release](https://github.com/Veetaha/rust-analyzer/releases/tag/2020-06-21)
Change in size: `~ 25 MB -> ~ 8 MB (gzipped)`
The time to gzip during the dist build takes a somewhat considerable amount of time tho.
Having already compiled artifacts this takes in debug mode:
```
~/dev/rust-analyzer (feat/gzip-binaries) $ time cargo xtask dist
Finished dev [unoptimized] target(s) in 0.06s
Running `target/debug/xtask dist`
> cargo build --manifest-path ./crates/rust-analyzer/Cargo.toml --bin rust-analyzer --release
Finished release [optimized] target(s) in 0.05s
> strip ./target/release/rust-analyzer
real 0m34.331s
user 0m34.245s
sys 0m0.078s
```
In release mode this is much faster:
```
~/dev/rust-analyzer (feat/gzip-binaries) $ time cargo run -p xtask --release -- dist
Finished release [optimized] target(s) in 0.04s
Running `target/release/xtask dist`
> cargo build --manifest-path ./crates/rust-analyzer/Cargo.toml --bin rust-analyzer --release
Finished release [optimized] target(s) in 0.06s
> strip ./target/release/rust-analyzer
real 0m2.401s
```
**[UPD]** adding a profile override for `miniz_oxide` does the thing to ensure good performrance
We might need to notify all other ra plugins' maintainers about the change in our GH releases if we merge this PR, or we could leave uncompressed files along with gzipped for a while until everyone migrates.
Co-authored-by: Veetaha <veetaha2@gmail.com>
Veetaha [Sun, 21 Jun 2020 12:58:34 +0000 (15:58 +0300)]
Gzip artifacts
Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
Override miniz_oxide to build it with optimizations
Building this crate with optimizations decreases the gzipping
part of `cargo xtask dist` from `30-40s` down to `3s`,
the overhead for `rustc` to apply optimizations is miserable on this background
bors[bot] [Tue, 7 Jul 2020 16:39:04 +0000 (16:39 +0000)]
Merge #5253
5253: Automate rust-analyzer promotion r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 7 Jul 2020 16:38:34 +0000 (18:38 +0200)]
Automate rust-analyzer promotion
Aleksey Kladov [Tue, 7 Jul 2020 16:12:22 +0000 (18:12 +0200)]
.
bors[bot] [Tue, 7 Jul 2020 15:47:37 +0000 (15:47 +0000)]
Merge #5252
5252: Fix symbol search in salsa r=matklad a=matklad
Previous solution for binning paths into disjoint directories was
simple and fast -- just a single binary search.
Unfortunatelly, it wasn't coorrect: if the ditr are
/d
/d/a
/d/c
then partitioning the file /d/b/lib.rs won't pick /d as a correct
directory.
The correct solution here is a trie, but it requires exposing path
components.
So, we use a poor man's substitution -- a *vector* of sorted paths,
such that each bucket is prefix-free
closes #5246
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 7 Jul 2020 15:38:02 +0000 (17:38 +0200)]
Fix symbol search in salsa
Previous solution for binning paths into disjoint directories was
simple and fast -- just a single binary search.
Unfortunatelly, it wasn't coorrect: if the ditr are
/d
/d/a
/d/c
then partitioning the file /d/b/lib.rs won't pick /d as a correct
directory.
The correct solution here is a trie, but it requires exposing path
components.
So, we use a poor man's substitution -- a *vector* of sorted paths,
such that each bucket is prefix-free
closes #5246
bors[bot] [Tue, 7 Jul 2020 14:26:54 +0000 (14:26 +0000)]
Merge #5250
5250: :arrow_up: backtrace r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>