]>
git.lizzy.rs Git - rust.git/log
Michael Wright [Mon, 2 Apr 2018 04:22:10 +0000 (06:22 +0200)]
Fix clippy warning
Allow `many_single_char_names` on `SpanlessHash::hash_expr`. Each
variable has a small scope and the method is readable.
Michael Wright [Sun, 1 Apr 2018 08:17:48 +0000 (10:17 +0200)]
Fix clippy warnings from last commit
Michael Wright [Sun, 1 Apr 2018 07:28:53 +0000 (09:28 +0200)]
Make dogfood test output to seperate directory
This commit makes `cargo clippy` output the build artifacts to a
separate directory if the `CLIPPY_DOGFOOD` env var is set. This should
prevent dogfood builds from interfering with regular builds.
This should help with issue #2595.
Manish Goregaokar [Fri, 30 Mar 2018 08:46:20 +0000 (10:46 +0200)]
Merge pull request #2593 from rust-lang-nursery/rustup
Rustup to rustc 1.26.0-nightly (
ae544ee1c 2018-03-29)
Manish Goregaokar [Fri, 30 Mar 2018 08:38:42 +0000 (10:38 +0200)]
Bump to 0.191
Manish Goregaokar [Fri, 30 Mar 2018 08:38:35 +0000 (10:38 +0200)]
Update changelog for 0.191
Manish Goregaokar [Fri, 30 Mar 2018 08:35:51 +0000 (10:35 +0200)]
Rustup to rustc 1.26.0-nightly (
ae544ee1c 2018-03-29)
Manish Goregaokar [Thu, 29 Mar 2018 14:21:45 +0000 (16:21 +0200)]
Merge pull request #2589 from rust-lang-nursery/rangearg
Move RangeArgument
Oliver Schneider [Thu, 29 Mar 2018 12:34:21 +0000 (14:34 +0200)]
Merge pull request #2579 from rust-lang-nursery/lint_audit_mcve
lint audit: Implementation + move one lint
Oliver Schneider [Thu, 29 Mar 2018 11:41:53 +0000 (13:41 +0200)]
Address review comments
Manish Goregaokar [Thu, 29 Mar 2018 11:02:12 +0000 (13:02 +0200)]
Move RangeArgument
Oliver Schneider [Thu, 29 Mar 2018 11:04:52 +0000 (13:04 +0200)]
Document lint groups
Oliver Schneider [Thu, 29 Mar 2018 05:19:00 +0000 (07:19 +0200)]
Merge pull request #2585 from bjgill/use-check-manifest-handling
Use cargo check's manifest handling
Benjamin Gill [Wed, 28 Mar 2018 22:17:48 +0000 (23:17 +0100)]
Delete all code for handling manifest path
Now that we're using cargo check, we can stop needing to find out the
manifest path ourselves. Instead, we can delegate to cargo check, which
is perfectly capable of working out for itself what needs to be built.
This fixes #1707 and #2518.
Note that this PR will change the output. We will no longer output `bin:
foo` before each crate. This a bit unfortunate. However, given that
we're now going to be building in parallel (which is *much* faster), I
think this is acceptable - we'll be no worse than cargo itself.
Oliver Schneider [Wed, 28 Mar 2018 21:49:32 +0000 (23:49 +0200)]
Update test suite
Oliver Schneider [Wed, 28 Mar 2018 13:24:26 +0000 (15:24 +0200)]
Categorize all the lints!
Oliver Schneider [Wed, 28 Mar 2018 10:04:18 +0000 (12:04 +0200)]
Merge pull request #2582 from rust-lang-nursery/clippy_aint_no_compiler
Use cargo check instead of cargo rustc
Oliver Schneider [Wed, 28 Mar 2018 09:50:17 +0000 (11:50 +0200)]
Use cargo check instead of cargo rustc
Oliver Schneider [Tue, 27 Mar 2018 15:13:55 +0000 (17:13 +0200)]
Implementation + move one lint
Oliver Schneider [Tue, 27 Mar 2018 11:00:02 +0000 (13:00 +0200)]
Undo current_dir -> CARGO_MANIFEST_DIR move
Oliver Schneider [Tue, 27 Mar 2018 10:14:46 +0000 (12:14 +0200)]
Version bump
Oliver Schneider [Tue, 27 Mar 2018 05:07:27 +0000 (07:07 +0200)]
Merge pull request #2572 from flip1995/immut_while
Fix check of immutable condition in closure
Oliver Schneider [Tue, 27 Mar 2018 05:07:01 +0000 (07:07 +0200)]
Merge pull request #2578 from mikerite/fix_issue_2397_pr_2
Fix enum_glob_use false positives
Michael Wright [Mon, 26 Mar 2018 05:48:32 +0000 (07:48 +0200)]
Fix enum_glob_use false positives
Closes #2397.
This checks the def of the `ItemUse` path instead of checking the
capitalization of the path segements. It was noted that this def would
sometimes be `Def::Mod` instead of `Def::Enum` but it seems correct now.
flip1995 [Mon, 26 Mar 2018 10:32:21 +0000 (12:32 +0200)]
Skip the mutation in while body case for closures
flip1995 [Sun, 25 Mar 2018 15:23:31 +0000 (17:23 +0200)]
Fix check of immutable condition in closure
Oliver Schneider [Mon, 26 Mar 2018 22:06:16 +0000 (00:06 +0200)]
Merge pull request #2576 from kimsnj/infinite_loop
while_immutable_condition: fix handling of self
Karim Snj [Mon, 26 Mar 2018 21:24:57 +0000 (23:24 +0200)]
while_immutable_condition: limit suggestion span to condition
Karim Snj [Mon, 26 Mar 2018 18:37:34 +0000 (20:37 +0200)]
while_immutable_condition: fix handling of self
Oliver Schneider [Mon, 26 Mar 2018 20:50:48 +0000 (22:50 +0200)]
Merge pull request #2577 from phansch/false_positive_empty_line_after_outer_attr_with_enum
Fix false positive in empty_line_after_outer_attribute
Philipp Hansch [Mon, 26 Mar 2018 19:57:42 +0000 (21:57 +0200)]
Fix false positive in empty_line_after_outer_attribute
`empty_line_after_outer_attribute` produced a false positive warning when
deriving `Copy` and/or `Clone` for an item.
It looks like the second point in [this comment][that_comment] is related,
as the attribute that causes the false positive has a path of
`rustc_copy_clone_marker`.
Fixes #2475
[that_comment]: https://github.com/rust-lang/rust/issues/35900#issuecomment-
245978831
Oliver Schneider [Mon, 26 Mar 2018 05:22:32 +0000 (07:22 +0200)]
Merge pull request #2575 from rust-lang-nursery/oli-obk-patch-1
Update needless_lifetimes_impl_trait.rs
Oliver Schneider [Mon, 26 Mar 2018 05:05:46 +0000 (07:05 +0200)]
Update needless_lifetimes_impl_trait.rs
Oliver Schneider [Mon, 26 Mar 2018 05:04:42 +0000 (07:04 +0200)]
Merge pull request #2574 from mark-i-m/i128
i128 is stabilizing
Mark Mansi [Mon, 26 Mar 2018 02:26:10 +0000 (21:26 -0500)]
whitespace
Mark Mansi [Mon, 26 Mar 2018 02:17:38 +0000 (21:17 -0500)]
attempt fix stderr
Mark Mansi [Mon, 26 Mar 2018 02:04:05 +0000 (21:04 -0500)]
make it pass for now
Mark Mansi [Mon, 26 Mar 2018 01:35:23 +0000 (20:35 -0500)]
i128 is stable
Mark Mansi [Mon, 26 Mar 2018 01:34:44 +0000 (20:34 -0500)]
i128 is stable
Oliver Schneider [Sun, 25 Mar 2018 21:11:12 +0000 (23:11 +0200)]
Merge pull request #2570 from CYBAI/update-readme
Update configuration for leading dot filename
CYBAI [Sun, 25 Mar 2018 08:57:15 +0000 (16:57 +0800)]
Update configuration for leading dot filename
Oliver Schneider [Sun, 25 Mar 2018 08:41:39 +0000 (10:41 +0200)]
Merge pull request #2569 from rust-lang-nursery/oli-obk-patch-1
Undo a temporary fix for a cargo bug
Oliver Schneider [Sun, 25 Mar 2018 06:52:00 +0000 (08:52 +0200)]
Undo a temporary fix for a cargo bug
Fixes #2566
Oliver Schneider [Sat, 24 Mar 2018 14:15:03 +0000 (15:15 +0100)]
Merge pull request #2565 from mikerite/issue_2420_tests_pr
Add tests to ensure that issue #2420 is resolved
Michael Wright [Fri, 23 Mar 2018 18:26:52 +0000 (20:26 +0200)]
Add tests to ensure that issue #2420 is resolved
The issue was probably fixed by
ff32d5f7 . Closes #2420.
llogiq [Wed, 21 Mar 2018 19:55:35 +0000 (20:55 +0100)]
Merge pull request #2561 from mikerite/walk_ptrs_ty_depth_pr
Minor refactoring (walk_ptrs_ty_depth)
Michael Wright [Wed, 21 Mar 2018 18:10:10 +0000 (20:10 +0200)]
Minor refactoring (walk_ptrs_ty_depth)
Replace `walk_ptrs_ty_depth` with `walk_ptrs_ty` when the depth value is
ignored.
Oliver Schneider [Tue, 20 Mar 2018 07:22:04 +0000 (08:22 +0100)]
Merge pull request #2539 from Baelyk/master
Add suggestion to useless_format
Baelyk [Sat, 17 Mar 2018 05:58:56 +0000 (00:58 -0500)]
Add suggestion to useless_format
Resolves #2505
Suggests that you use `"foo".to_string()` instead of `format!("foo")`.
Oliver Schneider [Mon, 19 Mar 2018 08:26:59 +0000 (09:26 +0100)]
Merge remote-tracking branch 'origin/master'
Oliver Schneider [Mon, 19 Mar 2018 08:26:05 +0000 (09:26 +0100)]
Version bump
Oliver Schneider [Sun, 18 Mar 2018 17:38:49 +0000 (18:38 +0100)]
undo accidental push to master
Oliver Schneider [Sun, 18 Mar 2018 14:41:39 +0000 (15:41 +0100)]
Use rustc from latest merged PR instead of nightly
Oliver Schneider [Sun, 18 Mar 2018 12:26:57 +0000 (13:26 +0100)]
Rustup
Oliver Schneider [Sat, 17 Mar 2018 22:20:51 +0000 (23:20 +0100)]
Merge pull request #2545 from flip1995/sus_arith
Don't lint comparison operators in arithmetic impls
flip1995 [Sat, 17 Mar 2018 20:34:13 +0000 (21:34 +0100)]
Don't lint comparison operators in arithmetic impls
Oliver Schneider [Sat, 17 Mar 2018 20:48:43 +0000 (21:48 +0100)]
Merge pull request #2544 from flip1995/panic
Check if the panic message was created by the assert-macro
flip1995 [Sat, 17 Mar 2018 19:35:20 +0000 (20:35 +0100)]
Check if the panic message was created by the assert-macro
Oliver Schneider [Fri, 16 Mar 2018 11:50:34 +0000 (12:50 +0100)]
Merge pull request #2533 from mati865/dogfood
Code cleanup
Mateusz Mikuła [Fri, 16 Mar 2018 10:36:14 +0000 (11:36 +0100)]
Allow float_cmp in consts lint code
Signed-off-by: Mateusz Mikuła <mati865@gmail.com>
Mateusz Mikuła [Fri, 16 Mar 2018 10:09:05 +0000 (11:09 +0100)]
Remove attributes for stable features
Signed-off-by: Mateusz Mikuła <mati865@gmail.com>
Mateusz Mikuła [Fri, 16 Mar 2018 09:47:28 +0000 (10:47 +0100)]
Fix BiRem for floats
Signed-off-by: Mateusz Mikuła <mati865@gmail.com>
Mateusz Mikuła [Thu, 15 Mar 2018 15:08:49 +0000 (16:08 +0100)]
Format code
Signed-off-by: Mateusz Mikuła <mati865@gmail.com>
Mateusz Mikuła [Thu, 15 Mar 2018 15:07:15 +0000 (16:07 +0100)]
Apply clippy suggestions
Signed-off-by: Mateusz Mikuła <mati865@gmail.com>
Oliver Schneider [Fri, 16 Mar 2018 08:44:20 +0000 (09:44 +0100)]
Rustup
Oliver Schneider [Thu, 15 Mar 2018 15:42:09 +0000 (16:42 +0100)]
Merge pull request #2531 from mati865/master
Rustup
Mateusz Mikuła [Thu, 15 Mar 2018 12:24:51 +0000 (13:24 +0100)]
Fix warning
Signed-off-by: Mateusz Mikuła <mati865@gmail.com>
Mateusz Mikuła [Thu, 15 Mar 2018 09:58:52 +0000 (10:58 +0100)]
Update tests after merge
Signed-off-by: Mateusz Mikuła <mati865@gmail.com>
Mateusz Mikuła [Thu, 15 Mar 2018 09:49:13 +0000 (10:49 +0100)]
Merge branch 'miri'
Mateusz Mikuła [Thu, 15 Mar 2018 09:25:57 +0000 (10:25 +0100)]
Update tests
Signed-off-by: Mateusz Mikuła <mati865@gmail.com>
Mateusz Mikuła [Thu, 15 Mar 2018 09:25:40 +0000 (10:25 +0100)]
Rustup
Signed-off-by: Mateusz Mikuła <mati865@gmail.com>
llogiq [Tue, 13 Mar 2018 16:12:52 +0000 (16:12 +0000)]
Merge pull request #2524 from rust-lang-nursery/update_dependencies
Update dependencies
Oliver Schneider [Tue, 13 Mar 2018 14:02:40 +0000 (15:02 +0100)]
Update dependencies
Oliver Schneider [Tue, 13 Mar 2018 10:38:11 +0000 (11:38 +0100)]
Update to rustc master
Oliver Schneider [Mon, 12 Mar 2018 07:19:52 +0000 (08:19 +0100)]
Merge pull request #2520 from ordovicia/remove-duct
Remove duct dependency
Oliver Schneider [Sun, 11 Mar 2018 13:04:28 +0000 (14:04 +0100)]
Merge pull request #2519 from ordovicia/issue-2516
Fix #2516
Hidehito Yabuuchi [Sun, 11 Mar 2018 05:07:16 +0000 (14:07 +0900)]
Remove duct dependency
Hidehito Yabuuchi [Sun, 11 Mar 2018 05:03:09 +0000 (14:03 +0900)]
Fix comment
Hidehito Yabuuchi [Sun, 11 Mar 2018 04:57:28 +0000 (13:57 +0900)]
Ignore all macros in redundant_field_names
Oliver Schneider [Thu, 8 Mar 2018 07:15:26 +0000 (08:15 +0100)]
Merge pull request #2515 from kimsnj/infinite_loop
lint: while immutable condition: do not lint constants
Karim Snj [Wed, 7 Mar 2018 17:24:36 +0000 (18:24 +0100)]
lint: while immutable condition: do not lint constants
Oliver Schneider [Wed, 7 Mar 2018 07:09:48 +0000 (08:09 +0100)]
Merge pull request #2483 from kimsnj/infinite_loop
immutable while condition
Karim Snj [Tue, 6 Mar 2018 17:27:11 +0000 (18:27 +0100)]
lint: immutable condition: add internally mutable test
Oliver Schneider [Tue, 6 Mar 2018 13:35:54 +0000 (14:35 +0100)]
Merge pull request #2511 from flip1995/sus_impl
UnNeg and UnNot count as additional operations now
Oliver Schneider [Tue, 6 Mar 2018 13:35:18 +0000 (14:35 +0100)]
Merge pull request #2513 from niklasf/increase-unreadable-literal
Increase unreadable_literal digits (fixes #1958)
Niklas Fiekas [Tue, 6 Mar 2018 13:06:27 +0000 (14:06 +0100)]
Increase unreadable_literal digits (fixes #1958)
flip1995 [Tue, 6 Mar 2018 12:58:03 +0000 (13:58 +0100)]
UnNeg and UnNot count as additional operations now
Karim Snj [Mon, 5 Mar 2018 21:20:28 +0000 (22:20 +0100)]
lint: while immutable condition: refactor to use ExprUseVisitor
Oliver Schneider [Mon, 5 Mar 2018 10:13:55 +0000 (11:13 +0100)]
Merge pull request #2509 from ordovicia/redundant_field_names_range
Remove unused variable and a minor refactoring
Hidehito Yabuuchi [Mon, 5 Mar 2018 09:20:27 +0000 (18:20 +0900)]
Move call of `is_range_expression()` outside of blocks
Oliver Schneider [Mon, 5 Mar 2018 08:41:00 +0000 (09:41 +0100)]
Merge pull request #2507 from ordovicia/redundant_field_names_range
Don't lint range syntax with var name `start` and/or `end`
Hidehito Yabuuchi [Mon, 5 Mar 2018 08:40:42 +0000 (17:40 +0900)]
Unused variable is left
Oliver Schneider [Mon, 5 Mar 2018 08:35:11 +0000 (09:35 +0100)]
Merge pull request #2493 from bootandy/fix_cow
Lint passing Cow by reference
Hidehito Yabuuchi [Mon, 5 Mar 2018 08:30:07 +0000 (17:30 +0900)]
Make `redundant_field_name` not care range expressions
Hand-written `Range` struct family are treated normally.
Oliver Schneider [Mon, 5 Mar 2018 07:43:17 +0000 (08:43 +0100)]
Merge pull request #2497 from waywardmonkeys/single-char-pattern
Fix single_char_pattern for \n, \t, etc.
Oliver Schneider [Mon, 5 Mar 2018 07:42:19 +0000 (08:42 +0100)]
Merge branch 'master' into fix_cow
Oliver Schneider [Mon, 5 Mar 2018 07:38:32 +0000 (08:38 +0100)]
Merge pull request #2504 from flip1995/lit_float_repr
Fix unreadable_literal lint for scientific float notation
Oliver Schneider [Mon, 5 Mar 2018 07:33:37 +0000 (08:33 +0100)]
Typo
Oliver Schneider [Mon, 5 Mar 2018 07:32:32 +0000 (08:32 +0100)]
Merge pull request #2506 from HMPerson1/fix_2496
Fix #2496
Hidehito Yabuuchi [Mon, 5 Mar 2018 05:31:37 +0000 (14:31 +0900)]
Don't lint range syntax with var name `start` and `end`