]>
git.lizzy.rs Git - rust.git/log
mcarton [Wed, 23 Nov 2016 20:19:03 +0000 (21:19 +0100)]
Rustup to *rustc 1.15.0-nightly (
7b3eeea22 2016-11-21)*
Phil Turnbull [Tue, 22 Nov 2016 18:22:37 +0000 (13:22 -0500)]
Lint usage of `*&` and `*&mut`
fixes #1316
Martin Carton [Tue, 22 Nov 2016 17:21:30 +0000 (18:21 +0100)]
Merge pull request #1349 from philipturnbull/extend-chars
Lint `.extend(s.chars())` (closes #792)
Phil Turnbull [Sun, 20 Nov 2016 16:22:22 +0000 (11:22 -0500)]
Remove mention of `.push_str(s)` being faster
For the `.push_str(str.chars())` case the compiler will inline `push_str` and
call `extend_from_slice` on the underlying vector, so this isn't actually
faster.
Phil Turnbull [Sun, 20 Nov 2016 16:19:36 +0000 (11:19 -0500)]
Suggest `&s` instead of `s.as_str()`
Oliver Schneider [Sun, 20 Nov 2016 08:21:25 +0000 (09:21 +0100)]
Merge pull request #1347 from sinkuu/conditional_returns
Allow explicit returns with cfg attributes
Daniel S Poulin [Sun, 20 Nov 2016 03:16:36 +0000 (22:16 -0500)]
Further clarify recommended usage
Pushed the section on hard dependency installation to the bottom of the usage methods to further discourage its use. Also included a note in that section warning that it is not the recommended method. Lastly, changed what was said in the opening paragraph of the Usage section to reflect the multitude of options.
sinkuu [Sun, 20 Nov 2016 01:15:40 +0000 (10:15 +0900)]
Fix #1346
sinkuu [Sat, 19 Nov 2016 11:10:04 +0000 (20:10 +0900)]
Allow explicit returns with cfg attributes
Martin Carton [Sat, 19 Nov 2016 23:19:38 +0000 (00:19 +0100)]
Merge pull request #1351 from Manishearth/rustup-2016-11-18
Rustup to *rustc 1.15.0-nightly (
ac635aa95 2016-11-18)* and bump to 0.0.100
mcarton [Sat, 19 Nov 2016 23:14:25 +0000 (00:14 +0100)]
Bump to 0.0.100
mcarton [Sat, 19 Nov 2016 23:13:08 +0000 (00:13 +0100)]
Rustup to *rustc 1.15.0-nightly (
ac635aa95 2016-11-18)*
Phil Turnbull [Sat, 19 Nov 2016 15:36:23 +0000 (10:36 -0500)]
Add lint for `string.extend(string.chars())`
fixes #792
Phil Turnbull [Sat, 19 Nov 2016 15:21:40 +0000 (10:21 -0500)]
Add lint for `string.extend("str".chars())`
fixes #792
Phil Turnbull [Sun, 16 Oct 2016 19:13:09 +0000 (15:13 -0400)]
Factor out lint_vec_extend
Daniel S Poulin [Sat, 19 Nov 2016 03:46:12 +0000 (22:46 -0500)]
Clarify recco to install as a soft dependency
On IRC it was mentioned that clippy is not meant to be installed as a hard dependency.
As it was, the README placed the hard dependency instructions first and did not
mention the recommendation, misleading users into making it a hard dependency. A
quick survey of the dependent crates on crates.io reveals the reach of this issue.
Martin Carton [Fri, 18 Nov 2016 12:47:07 +0000 (13:47 +0100)]
Merge pull request #1344 from Manishearth/rustup
[WIP] Rustup to rustc 1.15.0-nightly (
0ed951993 2016-11-14)
mcarton [Fri, 18 Nov 2016 12:40:53 +0000 (13:40 +0100)]
Rustup to rustc 1.15.0-nightly (
0ed951993 2016-11-14)
mcarton [Fri, 18 Nov 2016 12:40:15 +0000 (13:40 +0100)]
Cleanup
Oliver Schneider [Fri, 18 Nov 2016 12:21:07 +0000 (13:21 +0100)]
fix the inspector
mcarton [Thu, 17 Nov 2016 18:44:18 +0000 (19:44 +0100)]
Handle closure with single expression blocks
mcarton [Wed, 16 Nov 2016 20:57:56 +0000 (21:57 +0100)]
Rustup to rustc 1.15.0-nightly (
0ed951993 2016-11-14)
Manish Goregaokar [Fri, 11 Nov 2016 05:20:13 +0000 (21:20 -0800)]
Merge pull request #1339 from dereckson/patch-1
Recognize quux as a metasyntactic variable
Sébastien Santoro [Fri, 11 Nov 2016 04:57:29 +0000 (05:57 +0100)]
Recognize quux as a metasyntactic variable
quux is another metasyntactic variable like foo and so
should be detected by the blacklisted names linter.
Martin Carton [Thu, 10 Nov 2016 17:51:08 +0000 (18:51 +0100)]
Merge pull request #1337 from oli-obk/master
fix ice in `len_zero` lint when type has no inherent impls at all
Oliver 'ker' Schneider [Thu, 10 Nov 2016 16:06:39 +0000 (17:06 +0100)]
fix ice in `len_zero` lint when type has no inherent impls at all
fixes #1336
Oliver Schneider [Wed, 9 Nov 2016 09:49:16 +0000 (10:49 +0100)]
Merge pull request #1328 from Machtan/master
Add '--version' flag and allow version and help flags when called as 'cargo-clippy'
Jakob Lautrup Nysom [Wed, 9 Nov 2016 09:44:55 +0000 (10:44 +0100)]
Remove unnecessary #[allow]
Oliver Schneider [Wed, 9 Nov 2016 08:49:20 +0000 (09:49 +0100)]
Merge pull request #1312 from devonhollowood/get-unwrap
Implement `get_unwrap` lint
Oliver Schneider [Wed, 9 Nov 2016 08:25:18 +0000 (09:25 +0100)]
Merge pull request #1332 from debris/fixed_1331
fixed #1331
debris [Tue, 8 Nov 2016 20:50:35 +0000 (21:50 +0100)]
fixed #1331
Machtan [Tue, 8 Nov 2016 13:28:46 +0000 (14:28 +0100)]
Add '--version' flag and use version and help flags when called as 'cargo-clippy'
Machtan [Tue, 8 Nov 2016 12:54:08 +0000 (13:54 +0100)]
Add '--version' flag and allow version and help flags when called as 'cargo-clippy'
Oliver Schneider [Tue, 8 Nov 2016 10:52:38 +0000 (11:52 +0100)]
Create PUBLISH.md
Oliver 'ker' Schneider [Tue, 8 Nov 2016 10:44:55 +0000 (11:44 +0100)]
version bump
Oliver Schneider [Tue, 8 Nov 2016 10:42:33 +0000 (11:42 +0100)]
Merge pull request #1327 from oli-obk/master
--sysroot isn't necessary anymore for the outer cargo clippy call
Oliver 'ker' Schneider [Tue, 8 Nov 2016 10:35:26 +0000 (11:35 +0100)]
--sysroot isn't necessary anymore for the outer cargo clippy call
Oliver 'ker' Schneider [Thu, 3 Nov 2016 20:23:49 +0000 (21:23 +0100)]
publish 0.97
Oliver Schneider [Thu, 3 Nov 2016 20:14:19 +0000 (21:14 +0100)]
Merge pull request #1321 from EpicatSupercell/master
fixed callback changes from rustc 1.14.0-nightly (
7c69b0d5a 2016-11-01)
Epicat Supercell [Wed, 2 Nov 2016 19:27:42 +0000 (21:27 +0200)]
fixed callback changes from rustc 1.14.0-nightly (
7c69b0d5a 2016-11-01)
Devon Hollowood [Wed, 2 Nov 2016 18:48:16 +0000 (11:48 -0700)]
Fix suggestion in `get_unwrap` lint
Martin Carton [Wed, 2 Nov 2016 17:25:38 +0000 (18:25 +0100)]
Merge pull request #1317 from oli-obk/cc_attr_used_fixed
mark cyclomatic complexity attribute as used
Oliver Schneider [Wed, 2 Nov 2016 09:29:57 +0000 (10:29 +0100)]
mark cyclomatic complexity attribute as used
fixes #1315
Devon Hollowood [Wed, 2 Nov 2016 00:48:32 +0000 (17:48 -0700)]
Remove false positives from `get_unwrap` lint
HashMap and BTreeMap don't implement `IndexMut`, so we shouldn't lint
for use of `get_mut().unwrap()` for those types.
Devon Hollowood [Wed, 2 Nov 2016 00:33:43 +0000 (17:33 -0700)]
Clean up `get_unwrap` code
Devon Hollowood [Tue, 1 Nov 2016 08:07:51 +0000 (01:07 -0700)]
Add tests for `get_unwrap` lint
Devon Hollowood [Tue, 1 Nov 2016 08:07:14 +0000 (01:07 -0700)]
Small fixes for `get_unwrap` lint
Devon Hollowood [Tue, 1 Nov 2016 06:43:19 +0000 (23:43 -0700)]
Run update_lints.py
Devon Hollowood [Tue, 1 Nov 2016 06:30:13 +0000 (23:30 -0700)]
Add `get_unwrap` lint
Manish Goregaokar [Mon, 31 Oct 2016 23:02:17 +0000 (16:02 -0700)]
Merge pull request #1311 from gibfahn/if_let_some_result
Add to docs for if_let_some_result
Gibson Fahnestock [Mon, 31 Oct 2016 22:55:22 +0000 (22:55 +0000)]
Add to docs for if_let_some_result
Oliver Schneider [Mon, 31 Oct 2016 13:06:14 +0000 (09:06 -0400)]
Merge pull request #1307 from Kha/partialeq_ne
Implement 'Re-implementing `PartialEq::ne`' lint
Sebastian Ullrich [Sun, 30 Oct 2016 15:43:19 +0000 (11:43 -0400)]
inspector: fix printing non-local trait refs
Sebastian Ullrich [Sun, 30 Oct 2016 01:33:57 +0000 (21:33 -0400)]
implement 'Re-implementing `PartialEq::ne`' lint
closes #86
Oliver Schneider [Sun, 30 Oct 2016 18:35:32 +0000 (14:35 -0400)]
Merge pull request #1299 from Manishearth/clippy-toml
Search for `clippy.toml` recursively
Oliver Schneider [Sun, 30 Oct 2016 18:33:40 +0000 (14:33 -0400)]
Merge pull request #1296 from Manishearth/features
Be more helping, less helpful and bring convenience back for the dead
Sebastian Ullrich [Sun, 30 Oct 2016 01:14:20 +0000 (21:14 -0400)]
fix `dogfood.sh`
Sebastian Ullrich [Sun, 30 Oct 2016 01:13:41 +0000 (21:13 -0400)]
factor out `is_automatically_derived` util fn
Oliver Schneider [Sun, 30 Oct 2016 18:20:54 +0000 (14:20 -0400)]
Merge pull request #1305 from d-dorazio/1289-lint-for-ignored-argument-in-result-option
Add lint for redundant pattern matching in if let for Result/Option
d-dorazio [Sat, 29 Oct 2016 16:56:12 +0000 (18:56 +0200)]
Add lint for redundant pattern matching in iflet for Result/Option
Martin Carton [Thu, 27 Oct 2016 08:38:15 +0000 (10:38 +0200)]
Merge pull request #1301 from devonhollowood/wrong-self-convention-fix
Fix false positive for `wrong_self_convention`
Devon Hollowood [Thu, 27 Oct 2016 08:11:34 +0000 (01:11 -0700)]
Fix false positive for `wrong_self_convention`
mcarton [Tue, 25 Oct 2016 17:41:24 +0000 (19:41 +0200)]
Search for `clippy.toml` recursively
mcarton [Tue, 25 Oct 2016 13:09:56 +0000 (15:09 +0200)]
Fix small nits on the help message
Martin Carton [Mon, 24 Oct 2016 15:49:10 +0000 (17:49 +0200)]
Merge pull request #1297 from oli-obk/deep_code_inspection
fix some doc issues for clippy_dump
Oliver Schneider [Mon, 24 Oct 2016 14:30:22 +0000 (16:30 +0200)]
clean up docs for clippy_dump
mcarton [Mon, 24 Oct 2016 14:29:36 +0000 (16:29 +0200)]
Allow `--help` to be any argument
Also dogfoog.
mcarton [Mon, 24 Oct 2016 14:04:00 +0000 (16:04 +0200)]
Revert "Revert "Automatically defines the `clippy` feature""
This reverts commit
e4dceef7e79c96c4ddeffd59a2c532bd239f98a6 .
Oliver Schneider [Mon, 24 Oct 2016 13:43:37 +0000 (15:43 +0200)]
properly name the docs
mcarton [Mon, 24 Oct 2016 13:31:11 +0000 (15:31 +0200)]
Be more helping with `cargo clippy --help`
Oliver Schneider [Mon, 24 Oct 2016 13:29:54 +0000 (15:29 +0200)]
Merge pull request #1284 from oli-obk/deep_code_inspection
initial implementation of the code inspector lint
Oliver Schneider [Mon, 24 Oct 2016 13:16:21 +0000 (15:16 +0200)]
dogfood
Oliver Schneider [Mon, 24 Oct 2016 12:29:09 +0000 (14:29 +0200)]
factor out decl dumping
Oliver Schneider [Mon, 24 Oct 2016 12:28:58 +0000 (14:28 +0200)]
add expression and pattern dump
Oliver Schneider [Mon, 24 Oct 2016 08:39:19 +0000 (10:39 +0200)]
Merge branch 'master' of github.com:Manishearth/rust-clippy into deep_code_inspection
Oliver Schneider [Mon, 24 Oct 2016 07:25:52 +0000 (09:25 +0200)]
Merge pull request #1288 from Arnavion/fix-1247
Don't assume the first package in the result of `cargo metadata` is the current crate.
Arnavion [Sun, 23 Oct 2016 19:29:33 +0000 (12:29 -0700)]
Use .expect() for extracting the current_dir.
Arnavion [Sun, 23 Oct 2016 19:24:16 +0000 (12:24 -0700)]
Changed signature of cargo::metadata according to review comment.
Arnavion [Sun, 23 Oct 2016 01:15:42 +0000 (18:15 -0700)]
Don't assume the first package in the result of `cargo metadata` is the current crate.
Instead find the one with the manifest path that matches the --manifest-path argument or the current directory.
Fixes #1247
mcarton [Sat, 22 Oct 2016 14:16:55 +0000 (16:16 +0200)]
Forbid default warnings in dogfood
mcarton [Sat, 22 Oct 2016 14:16:38 +0000 (16:16 +0200)]
Fix unused import warning
Martin Carton [Sat, 22 Oct 2016 14:10:18 +0000 (16:10 +0200)]
Merge pull request #1287 from Manishearth/rustup
Rustup to *rustc 1.14.0-nightly (
f09420685 2016-10-20)* and bump to 0.0.96
mcarton [Sat, 22 Oct 2016 14:00:17 +0000 (16:00 +0200)]
Bump to 0.0.96
mcarton [Sat, 22 Oct 2016 13:57:19 +0000 (15:57 +0200)]
Rustup to *rustc 1.14.0-nightly (
f09420685 2016-10-20)*
Oliver Schneider [Tue, 18 Oct 2016 15:29:01 +0000 (17:29 +0200)]
rename inspection attribute to `clippy_dump`
Oliver Schneider [Tue, 18 Oct 2016 14:57:39 +0000 (16:57 +0200)]
initial implementation of the code inspector lint
mcarton [Sun, 16 Oct 2016 12:01:55 +0000 (14:01 +0200)]
Remove the now stable `#[feature(question_mark)]`
Manish Goregaokar [Fri, 14 Oct 2016 12:20:51 +0000 (17:50 +0530)]
Merge pull request #1278 from d-dorazio/1112
Suggest `nth(X)` instead of `skip(X).next()`
d-dorazio [Fri, 14 Oct 2016 11:35:25 +0000 (13:35 +0200)]
Suggest `nth(X)` instead of `skip(X).next()`
Patrick Horlebein [Wed, 12 Oct 2016 13:22:21 +0000 (15:22 +0200)]
doc_markdown: Added "iOS" and "macOS" to the doc-valid-idents list
mcarton [Wed, 12 Oct 2016 10:00:26 +0000 (12:00 +0200)]
Test for #1275
Close #1275.
Martin Carton [Sat, 8 Oct 2016 16:07:05 +0000 (18:07 +0200)]
Merge pull request #1273 from d-dorazio/1272
Avoid redundant multiple pattern suggested when one pattern is _
d-dorazio [Sat, 8 Oct 2016 13:16:00 +0000 (15:16 +0200)]
Avoid redundant multiple pattern suggested when one pattern is _
llogiq [Thu, 6 Oct 2016 21:21:52 +0000 (23:21 +0200)]
Merge pull request #1268 from Manishearth/1265
Fix FP with `print_with_newline` and final arguments
mcarton [Thu, 6 Oct 2016 20:30:03 +0000 (22:30 +0200)]
Fix FP with `print_with_newline` and final arguments
mcarton [Thu, 6 Oct 2016 15:52:41 +0000 (17:52 +0200)]
Bump to 0.0.95
mcarton [Thu, 6 Oct 2016 15:50:11 +0000 (17:50 +0200)]
Fix dogfood problem
mcarton [Thu, 6 Oct 2016 15:46:50 +0000 (17:46 +0200)]
Rustup to *rustc 1.14.0-nightly (
3210fd5c2 2016-10-05)*
Martin Carton [Tue, 4 Oct 2016 21:00:05 +0000 (23:00 +0200)]
Merge pull request #1257 from KitFreddura/master
If let some lint
Manish Goregaokar [Tue, 4 Oct 2016 15:34:20 +0000 (21:04 +0530)]
Merge pull request #1262 from Manishearth/rustup
Remove warning in the latest nightly