]>
git.lizzy.rs Git - rust.git/log
Philipp Krones [Sun, 21 Oct 2018 19:27:01 +0000 (15:27 -0400)]
Add `Applicability`
HMPerson1 [Sun, 21 Oct 2018 03:46:13 +0000 (23:46 -0400)]
Add lint for calling `mem::discriminant` on a non-enum type
bors[bot] [Wed, 24 Oct 2018 21:17:43 +0000 (21:17 +0000)]
Merge #3312
3312: OUT_OF_BOUNDS_INDEXING false negative r=phansch a=JoshMcguigan
fixes #3102
Co-authored-by: Josh Mcguigan <joshmcg88@gmail.com>
bors[bot] [Wed, 24 Oct 2018 15:25:12 +0000 (15:25 +0000)]
Merge #3356
3356: Fix warnings introduced by #3349 r=flip1995 a=flip1995
I missed these warnings during review, should have checked the Travis log first.
Co-authored-by: flip1995 <hello@philkrones.com>
bors[bot] [Wed, 24 Oct 2018 14:42:40 +0000 (14:42 +0000)]
Merge #3338
3338: new_ret_no_self false positives r=flip1995 a=JoshMcguigan
~~WORK IN PROGRESS~~
I plan to fix all of the false positives in #3313 in this PR, but I wanted to open it now to start gathering feedback.
In this first commit, I've updated the lint to allow tuple return types as long as `Self` shows up at least once, in any position of the tuple. I believe this is the broadest possible interpretation of what should be allowed for tuple return types, but I would certainly be okay making the lint more strict.
fixes #3313
Co-authored-by: Josh Mcguigan <joshmcg88@gmail.com>
flip1995 [Wed, 24 Oct 2018 14:18:01 +0000 (16:18 +0200)]
Fix warnings introduced by #3349
Josh Mcguigan [Wed, 24 Oct 2018 13:43:21 +0000 (06:43 -0700)]
new_ret_no_self added test cases
bors[bot] [Wed, 24 Oct 2018 12:21:19 +0000 (12:21 +0000)]
Merge #3349
3349: Fixes #3347: Lint for wildcard dependencies in Cargo.toml r=ordovicia a=ordovicia
Add a lint for wildcard dependencies in Cargo.toml.
How should I write a test for this lint?
Fixes #3347
Co-authored-by: Hidehito Yabuuchi <hdht.ybuc@gmail.com>
Hidehito Yabuuchi [Wed, 24 Oct 2018 12:15:27 +0000 (21:15 +0900)]
Replace remaining `krate.span` with `DUMMY_SP`
Hidehito Yabuuchi [Wed, 24 Oct 2018 11:22:38 +0000 (20:22 +0900)]
Use DUMMY_SP in multiple_crate_versions
Hidehito Yabuuchi [Wed, 24 Oct 2018 11:18:19 +0000 (20:18 +0900)]
Some fixes for wildcard_dependencies
bors[bot] [Wed, 24 Oct 2018 07:59:06 +0000 (07:59 +0000)]
Merge #3350
3350: Don't emit `new_without_default_derive` if an impl of Default exists regardless of generics r=oli-obk a=pengowen123
Fixes #2226
Co-authored-by: Owen Sanchez <pengowen816@gmail.com>
Hidehito Yabuuchi [Wed, 24 Oct 2018 05:59:19 +0000 (14:59 +0900)]
Run util/update_lints.py
Hidehito Yabuuchi [Wed, 24 Oct 2018 02:34:36 +0000 (11:34 +0900)]
Minor changes on clippy_lints/src/wildcard_dependencies.rs
Hidehito Yabuuchi [Mon, 22 Oct 2018 13:39:51 +0000 (22:39 +0900)]
Lint for wildcard dependencies in Cargo.toml
bors[bot] [Wed, 24 Oct 2018 05:45:02 +0000 (05:45 +0000)]
Merge #3339
3339: Check for known array length in `needless_range_loop` r=phansch a=HMPerson1
In `VarVisitor`, we now keep track of the type of the thing that was directly indexed and, if it's an array, check if the range's end is (or is past) the array's length.
Fixes #3033
Co-authored-by: HMPerson1 <hmperson1@gmail.com>
bors[bot] [Wed, 24 Oct 2018 05:16:43 +0000 (05:16 +0000)]
Merge #3348
3348: Setup bors for Clippy r=phansch a=flip1995
Since [bors-ng](https://app.bors.tech/repositories/3993) is already installed for this repo for a while (https://github.com/rust-lang-nursery/rust-clippy/pull/3279#issuecomment-
427645938 ), the only thing missing, before we can use it, is the `bors.toml`. (bors-ng [docs](https://bors.tech/documentation/getting-started/))
If we want to move forward with this and this gets merged, the only thing left to do is to create the branches `staging` and `trying`.
@phansch @oli-obk
Co-authored-by: flip1995 <hello@philkrones.com>
Co-authored-by: Philipp Krones <hello@philkrones.com>
Philipp Hansch [Wed, 24 Oct 2018 05:02:20 +0000 (07:02 +0200)]
Merge pull request #3352 from gnieto/fix/doc-inspector
Fix inspector pass documentation
Owen Sanchez [Mon, 22 Oct 2018 04:59:45 +0000 (21:59 -0700)]
Don't emit `new_without_default_derive` if an impl of Default exists
Guillem Nieto [Tue, 23 Oct 2018 21:03:23 +0000 (23:03 +0200)]
Fix inspector pass documentation
When using `#[clippy_dump]`, the compiler complains about an unknown
attribute. The correct one seems to be `#[clippy::dump]`.
Philipp Krones [Mon, 22 Oct 2018 15:30:01 +0000 (17:30 +0200)]
Add branch configuration to appveyor.yml
flip1995 [Mon, 22 Oct 2018 11:09:48 +0000 (13:09 +0200)]
Setup bors
Josh Mcguigan [Sat, 20 Oct 2018 13:29:17 +0000 (06:29 -0700)]
new_ret_no_self added test cases
Josh Mcguigan [Sat, 20 Oct 2018 00:54:25 +0000 (17:54 -0700)]
new_ret_no_self walk return type to check for self
HMPerson1 [Fri, 19 Oct 2018 21:17:13 +0000 (17:17 -0400)]
Update `ui/for_loop` test output
HMPerson1 [Fri, 19 Oct 2018 20:34:16 +0000 (16:34 -0400)]
Check for known array length in `needless_range_loop`
Josh Mcguigan [Fri, 19 Oct 2018 12:20:33 +0000 (05:20 -0700)]
new_ret_no_self correct false positive on raw pointer return types
Josh Mcguigan [Fri, 19 Oct 2018 11:55:06 +0000 (04:55 -0700)]
new_ret_no_self correct linting of tuple return types
Philipp Krones [Thu, 18 Oct 2018 23:32:57 +0000 (01:32 +0200)]
Merge pull request #3334 from matthiaskrgr/new-ret-no-self__doc
new_ret_no_self: add sample from #3313 to Known Problems section.
Matthias Krüger [Thu, 18 Oct 2018 21:31:11 +0000 (23:31 +0200)]
new_ret_no_self: add sample from #3313 to Known Problems section.
fix trivial typo on the way
Philipp Hansch [Thu, 18 Oct 2018 20:26:33 +0000 (22:26 +0200)]
Merge pull request #3303 from shssoichiro/3069-unnecessary-fold-pattern-guard
Note known false positives in unnecessary_fold lint
Philipp Krones [Thu, 18 Oct 2018 18:12:28 +0000 (20:12 +0200)]
Merge pull request #3332 from lukasstevens/fix798
Check for comments in collapsible ifs
Lukas Stevens [Thu, 18 Oct 2018 16:57:16 +0000 (18:57 +0200)]
Support multiline comments and hopefully fix panic
Lukas Stevens [Tue, 16 Oct 2018 20:20:27 +0000 (22:20 +0200)]
Check for comments in collapsible ifs
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Thu, 18 Oct 2018 07:44:24 +0000 (09:44 +0200)]
Merge pull request #3323 from pengowen123/fix_manual_memcpy
Simplify manual_memcpy suggestion in some cases
Philipp Hansch [Wed, 17 Oct 2018 19:01:15 +0000 (21:01 +0200)]
Merge pull request #3330 from shssoichiro/3309-goblin-ice
Resolve ICE in needless range loop lint
Joshua Holmer [Wed, 17 Oct 2018 14:43:32 +0000 (10:43 -0400)]
Resolve ICE in needless range loop lint
An ICE would occur if the needless range loop was triggered
within a procedural macro, because Clippy would try to produce
a code suggestion which was invalid, and caused the compiler
to crash.
This commit takes the same approach which Clippy currently takes
to work around this type of crash in the needless pass by value lint,
which is to skip the lint if Clippy is inside of a macro.
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Wed, 17 Oct 2018 07:47:02 +0000 (09:47 +0200)]
Merge pull request #3327 from phansch/update_changelog_riir
RIIR update_lints: Update changelog links
Philipp Hansch [Wed, 17 Oct 2018 06:18:05 +0000 (08:18 +0200)]
RIIR update_lints: Update changelog links
This now also updates the link list at the bottom of the changelog.
Philipp Hansch [Wed, 17 Oct 2018 05:31:09 +0000 (07:31 +0200)]
Merge pull request #3281 from CYBAI/redundant-match
Add lint for redundant pattern matching for explicit return boolean
Philipp Hansch [Wed, 17 Oct 2018 05:27:10 +0000 (07:27 +0200)]
Merge pull request #3326 from mrbuzz/master
Reword help message for len_zero
CYBAI [Wed, 10 Oct 2018 15:13:53 +0000 (23:13 +0800)]
Rename if_let_redundant_pattern_matching to redundant_pattern_matching
Also, making the old one deprecated
CYBAI [Sun, 7 Oct 2018 13:36:42 +0000 (21:36 +0800)]
Add lint for redundant pattern matching for explicit return boolean
Giorgio Gambino [Tue, 16 Oct 2018 21:23:31 +0000 (23:23 +0200)]
Fix issue #3322: reword help message for len_zero
Owen Sanchez [Tue, 16 Oct 2018 04:12:59 +0000 (21:12 -0700)]
Simplify manual_memcpy suggestion in some cases
Philipp Hansch [Tue, 16 Oct 2018 19:35:25 +0000 (21:35 +0200)]
Merge pull request #3325 from phansch/riir_update_lints_first_replace_region
RIIR update_lints: Replace lint count in README.md
Philipp Hansch [Tue, 16 Oct 2018 18:58:00 +0000 (20:58 +0200)]
Fix dogfood
`expect_fun_call` causes a false-positive, so I disabled it for now.
Joshua Holmer [Tue, 16 Oct 2018 13:04:02 +0000 (09:04 -0400)]
Update known problems for unnecessary_fold
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Tue, 16 Oct 2018 08:45:55 +0000 (10:45 +0200)]
Merge pull request #3321 from 0ndorio/fix/1123_false_positive_on_boxed_local
Avoid linting `boxed_local` on trait implementations.
Philipp Hansch [Tue, 16 Oct 2018 06:00:31 +0000 (08:00 +0200)]
RIIR update_lints: Replace lint count in README.md
This allows the usage of `util/dev update_lints` which will write the
new lint_count to the `README.md`.
Philipp Hansch [Tue, 16 Oct 2018 05:24:32 +0000 (07:24 +0200)]
Rename `active_lints` to `usable_lints`
Because now `usable_lints` will also exclude internal lints.
Philipp Hansch [Tue, 16 Oct 2018 05:13:45 +0000 (07:13 +0200)]
Merge pull request #3320 from phansch/riir_update_lints_use_walkdir
RIIR update_lints: use WalkDir instead of read_dir
Philipp Hansch [Tue, 16 Oct 2018 05:13:03 +0000 (07:13 +0200)]
Merge pull request #3319 from majecty/webpage_link_category
Website: Make lint categories linkable
Philipp Hansch [Mon, 15 Oct 2018 19:10:22 +0000 (21:10 +0200)]
Add comment on WalkDir vs. fs::read_dir
Philipp Hansch [Mon, 15 Oct 2018 19:02:38 +0000 (21:02 +0200)]
sort_by -> sort_by_key
Philipp Hansch [Mon, 15 Oct 2018 18:47:19 +0000 (20:47 +0200)]
Some more documentation for clippy_dev
Philipp Hansch [Tue, 9 Oct 2018 06:08:50 +0000 (08:08 +0200)]
Use `WalkDir` to also gather from subdirectories
`fs::read_dir` does not recurse into subdirectories.
Bruno Kirschner [Mon, 15 Oct 2018 18:20:50 +0000 (20:20 +0200)]
Avoid linting `boxed_local` on trait implementations.
Park Juhyung [Mon, 15 Oct 2018 13:32:49 +0000 (22:32 +0900)]
Website: Make lint categories linkable
Fixes #2973
Josh Mcguigan [Mon, 15 Oct 2018 11:44:39 +0000 (04:44 -0700)]
out_of_bounds_indexing improved reporting of out of bounds value
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Mon, 15 Oct 2018 07:33:21 +0000 (09:33 +0200)]
Merge pull request #3316 from pengowen123/fix_needless_range_loop
Swap order of methods in `needless_range_loop` suggestion for efficiency in some cases
Manish Goregaokar [Mon, 15 Oct 2018 06:41:35 +0000 (23:41 -0700)]
Restore clippy_dummy's placeholder name
Fixes #3317
Owen Sanchez [Mon, 15 Oct 2018 03:07:21 +0000 (20:07 -0700)]
Swap order of methods in `needless_range_loop` suggestion in some cases
Manish Goregaokar [Sun, 14 Oct 2018 22:57:23 +0000 (15:57 -0700)]
Merge pull request #3315 from rust-lang-nursery/oli-obk-patch-1
fix for rustc master
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Sun, 14 Oct 2018 20:55:26 +0000 (22:55 +0200)]
fix for rustc master
Josh Mcguigan [Sun, 14 Oct 2018 14:49:28 +0000 (07:49 -0700)]
out_of_bounds_indexing refactoring
Martin Carton [Sun, 14 Oct 2018 12:15:31 +0000 (14:15 +0200)]
Merge pull request #3314 from matthiaskrgr/mem_forget_sample
mem_forget: fix syntax error in code sample
Matthias Krüger [Sun, 14 Oct 2018 08:30:04 +0000 (10:30 +0200)]
mem_forget: fix syntax error in code sample
Josh Mcguigan [Sat, 13 Oct 2018 20:51:53 +0000 (13:51 -0700)]
OUT_OF_BOUNDS_INDEXING fix #3102 false negative
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Sat, 13 Oct 2018 18:11:50 +0000 (20:11 +0200)]
Merge pull request #3310 from JoshMcguigan/explicit_counter_loop-3308
explicit_counter_loop fix #3308 false positive
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Sat, 13 Oct 2018 18:10:51 +0000 (20:10 +0200)]
Merge pull request #3253 from JoshMcguigan/new_ret_no_self-3220
new_ret_no_self
Josh Mcguigan [Sat, 13 Oct 2018 13:57:52 +0000 (06:57 -0700)]
explicit_counter_loop fix #3308 false positive
Josh Mcguigan [Sat, 13 Oct 2018 13:33:46 +0000 (06:33 -0700)]
new_ret_no_self test remove tool lints cfg flag
Josh Mcguigan [Tue, 9 Oct 2018 02:35:37 +0000 (19:35 -0700)]
Added new_ret_no_self exception to clippy to pass dogfood tests
Josh Mcguigan [Fri, 5 Oct 2018 04:37:28 +0000 (21:37 -0700)]
Removed new_ret_no_self tests from method.rs
Josh Mcguigan [Fri, 5 Oct 2018 02:01:04 +0000 (19:01 -0700)]
new_ret_no_self correctly lint impl return
Josh Mcguigan [Wed, 3 Oct 2018 12:00:43 +0000 (05:00 -0700)]
Removed unused variables
Josh Mcguigan [Wed, 3 Oct 2018 11:59:14 +0000 (04:59 -0700)]
new_ret_no_self fix false positive for impl trait return with associated type self
Josh Mcguigan [Wed, 3 Oct 2018 10:55:31 +0000 (03:55 -0700)]
new_ret_no_self corrected panic and added test stderr
Josh Mcguigan [Wed, 3 Oct 2018 03:11:56 +0000 (20:11 -0700)]
new_ret_no_self added positive test cases
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Sat, 13 Oct 2018 07:30:19 +0000 (09:30 +0200)]
Merge pull request #3233 from rust-lang-nursery/unused-unit
new lint: unused_unit
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Sat, 13 Oct 2018 07:24:55 +0000 (09:24 +0200)]
Merge pull request #3298 from devonhollowood/pedantic-dogfood-naming
Pedantic dogfood: naming and docs
Devon Hollowood [Sat, 13 Oct 2018 00:07:48 +0000 (17:07 -0700)]
Fix some more `stutter` warnings
Andre Bogus [Thu, 27 Sep 2018 17:10:20 +0000 (19:10 +0200)]
unused unit lint
Philipp Hansch [Fri, 12 Oct 2018 20:49:23 +0000 (22:49 +0200)]
Merge pull request #3304 from phansch/travis_windows_part2
Install Windows SDK 10.0 on travis
Philipp Hansch [Fri, 12 Oct 2018 20:04:58 +0000 (22:04 +0200)]
Install Windows SDK 10.0 on travis
Joshua Holmer [Fri, 12 Oct 2018 17:15:55 +0000 (13:15 -0400)]
Revert "Exclude pattern guards from unnecessary_fold lint"
This reverts commit
d3c06f7252fdca30b19aa6ff8ecf63c86675676e .
Joshua Holmer [Fri, 12 Oct 2018 14:26:55 +0000 (10:26 -0400)]
Exclude pattern guards from unnecessary_fold lint
Methods like `Iterator::any` borrow the iterator mutably,
which is not allowed within a pattern guard and will fail to compile.
This commit prevents clippy from suggesting this type of change.
Closes #3069
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Fri, 12 Oct 2018 13:07:12 +0000 (15:07 +0200)]
Merge pull request #3291 from JoshMcguigan/cmp_owned-3289
cmp_owned wording and false positive
Josh Mcguigan [Fri, 12 Oct 2018 11:48:54 +0000 (04:48 -0700)]
cmp_owned refactor
Josh Mcguigan [Fri, 12 Oct 2018 11:34:41 +0000 (04:34 -0700)]
cmp_owned correct error message if rhs is deref
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Fri, 12 Oct 2018 11:16:34 +0000 (13:16 +0200)]
Merge pull request #3301 from sigustin/patch-1
Specify which categories are enabled by default
sigustin [Fri, 12 Oct 2018 10:32:48 +0000 (12:32 +0200)]
Add a comment reminding to update README if the default changes
sigustin [Fri, 12 Oct 2018 10:15:20 +0000 (12:15 +0200)]
Specify which categories are enabled by default
Closes #3293
Philipp Hansch [Fri, 12 Oct 2018 07:27:32 +0000 (09:27 +0200)]
Merge pull request #3300 from phansch/travis_windows
Add Travis windows build
Philipp Hansch [Fri, 12 Oct 2018 05:59:08 +0000 (07:59 +0200)]
Only run markdown linter on linux
Because:
* There's no need to run it on more than one platform
* It doesn't work on windows
Philipp Hansch [Fri, 12 Oct 2018 05:41:25 +0000 (07:41 +0200)]
Move Travis Windows build to allowed failures
Until the remaining issues are fixed. This also enabled `fast_finish`.
It will finish even if the windows build is still running.
Philipp Hansch [Fri, 12 Oct 2018 05:19:34 +0000 (07:19 +0200)]
Add Travis windows build
See https://blog.travis-ci.com/2018-10-11-windows-early-release
Devon Hollowood [Thu, 11 Oct 2018 22:43:13 +0000 (15:43 -0700)]
Fix `doc_markdown` lints
Devon Hollowood [Thu, 11 Oct 2018 22:36:40 +0000 (15:36 -0700)]
Fix `stutter` lints