]> git.lizzy.rs Git - rust.git/log
rust.git
4 years agoPrune rustc dependencies.
Camille GILLOT [Fri, 7 Feb 2020 08:06:08 +0000 (09:06 +0100)]
Prune rustc dependencies.

4 years agoGate macro use.
Camille GILLOT [Wed, 8 Jan 2020 09:18:48 +0000 (10:18 +0100)]
Gate macro use.

4 years agoPrune features.
Camille GILLOT [Wed, 8 Jan 2020 08:31:01 +0000 (09:31 +0100)]
Prune features.

4 years agoRemove librustc_infer crate re-exports.
Camille GILLOT [Tue, 7 Jan 2020 21:07:22 +0000 (22:07 +0100)]
Remove librustc_infer crate re-exports.

4 years agoOther crates.
Camille GILLOT [Mon, 6 Jan 2020 22:31:06 +0000 (23:31 +0100)]
Other crates.

4 years agoMake librustc_traits compile.
Camille GILLOT [Mon, 6 Jan 2020 22:28:45 +0000 (23:28 +0100)]
Make librustc_traits compile.

4 years agoMake librustc_mir compile.
Camille GILLOT [Mon, 6 Jan 2020 22:21:41 +0000 (23:21 +0100)]
Make librustc_mir compile.

4 years agomacOS: avoid calling pthread_self() twice
Hiroki Noda [Sun, 2 Feb 2020 12:25:38 +0000 (21:25 +0900)]
macOS: avoid calling pthread_self() twice

4 years agoMake librustc_typeck compile.
Camille GILLOT [Mon, 6 Jan 2020 22:12:31 +0000 (23:12 +0100)]
Make librustc_typeck compile.

4 years agoMake librustc_infer compile.
Camille GILLOT [Mon, 6 Jan 2020 19:13:24 +0000 (20:13 +0100)]
Make librustc_infer compile.

4 years agoMake librustc compile.
Camille GILLOT [Mon, 6 Jan 2020 19:13:24 +0000 (20:13 +0100)]
Make librustc compile.

4 years agoMove librustc/{traits,infer} to librustc_infer.
Camille GILLOT [Mon, 6 Jan 2020 19:13:24 +0000 (20:13 +0100)]
Move librustc/{traits,infer} to librustc_infer.

4 years agoAuto merge of #69156 - ecstatic-morse:unified-dataflow-impls2, r=eddyb
bors [Sun, 16 Feb 2020 05:08:08 +0000 (05:08 +0000)]
Auto merge of #69156 - ecstatic-morse:unified-dataflow-impls2, r=eddyb

Use `ResultsCursor` for `elaborate_drops`

Some cleanup after #68241. The old code was using a custom cursor-like struct called `InitializationData`.

4 years agoAuto merge of #68814 - Aaron1011:fix/proc-macro-order-two, r=petrochenkov
bors [Sun, 16 Feb 2020 01:46:05 +0000 (01:46 +0000)]
Auto merge of #68814 - Aaron1011:fix/proc-macro-order-two, r=petrochenkov

Record proc macro harness order for use during metadata deserialization

Fixes #68690

When we generate the proc macro harness, we now explicitly recorder the
order in which we generate entries. We then use this ordering data to
deserialize the correct proc-macro-data from the crate metadata.

4 years agoFix printing of `Yield` terminator
Jonas Schievink [Sat, 15 Feb 2020 23:57:48 +0000 (00:57 +0100)]
Fix printing of `Yield` terminator

4 years agoFix running rustdoc-js test suite individually
Oliver Middleton [Sat, 15 Feb 2020 23:14:46 +0000 (23:14 +0000)]
Fix running rustdoc-js test suite individually

Without `Compiletest.path` set running `x.py test src/test/rustdoc-js` would run the `rustdoc-js` test suite with everything filtered out.

As this was the only place setting `Compiletest.path` to `None` this removes the `Option` wrapper as well.

4 years agoDetermine type of intrinsics instead of assuming the destination type is the same.
Ben Lewis [Sat, 15 Feb 2020 22:39:04 +0000 (11:39 +1300)]
Determine type of intrinsics instead of assuming the destination type is the same.

4 years agoAuto merge of #68668 - GuillaumeGomez:struct-variant-field-search, r=ollie27
bors [Sat, 15 Feb 2020 22:32:51 +0000 (22:32 +0000)]
Auto merge of #68668 - GuillaumeGomez:struct-variant-field-search, r=ollie27

Struct variant field search

Fixes #16017.

Reopening of #64724.

cc @tomjakubowski
cc @ollie27

r? @kinnison

4 years agoast: tweak AssocItemKind::Macro comment
Mazdak Farrokhzad [Sat, 15 Feb 2020 21:36:03 +0000 (22:36 +0100)]
ast: tweak AssocItemKind::Macro comment

4 years agoprint_item_const: remove extraneous space
Mazdak Farrokhzad [Sat, 15 Feb 2020 21:33:21 +0000 (22:33 +0100)]
print_item_const: remove extraneous space

4 years agoreject assoc statics & extern consts during parsing
Mazdak Farrokhzad [Sat, 15 Feb 2020 21:21:00 +0000 (22:21 +0100)]
reject assoc statics & extern consts during parsing

4 years agoCode review changes.
Ben Lewis [Sat, 15 Feb 2020 20:59:01 +0000 (09:59 +1300)]
Code review changes.

4 years agoAdd additional comment
Aaron Hill [Sat, 15 Feb 2020 20:51:40 +0000 (15:51 -0500)]
Add additional comment

4 years agoRecord proc macro harness order for use during metadata deserialization
Aaron Hill [Mon, 3 Feb 2020 23:34:36 +0000 (18:34 -0500)]
Record proc macro harness order for use during metadata deserialization

Fixes #68690

When we generate the proc macro harness, we now explicitly recorder the
order in which we generate entries. We then use this ordering data to
deserialize the correct proc-macro-data from the crate metadata.

4 years agovisit: unify extern & assoc item visiting
Mazdak Farrokhzad [Sat, 15 Feb 2020 17:42:43 +0000 (18:42 +0100)]
visit: unify extern & assoc item visiting

4 years agopprust: unify extern & associated item printing
Mazdak Farrokhzad [Sat, 15 Feb 2020 17:28:47 +0000 (18:28 +0100)]
pprust: unify extern & associated item printing

4 years agofuse extern & associated item parsing up to defaultness
Mazdak Farrokhzad [Sat, 15 Feb 2020 16:35:29 +0000 (17:35 +0100)]
fuse extern & associated item parsing up to defaultness

4 years agoast: make ForeignItemKind an alias of AssocItemKind
Mazdak Farrokhzad [Sat, 15 Feb 2020 01:34:19 +0000 (02:34 +0100)]
ast: make ForeignItemKind an alias of AssocItemKind

4 years agoparse extern consts
Mazdak Farrokhzad [Sat, 15 Feb 2020 01:23:10 +0000 (02:23 +0100)]
parse extern consts

4 years agoparse associated statics.
Mazdak Farrokhzad [Sat, 15 Feb 2020 00:50:26 +0000 (01:50 +0100)]
parse associated statics.

4 years agoast/parser: fuse `static` & `const` grammars in all contexts.
Mazdak Farrokhzad [Fri, 14 Feb 2020 14:56:05 +0000 (15:56 +0100)]
ast/parser: fuse `static` & `const` grammars in all contexts.

4 years agoast: make `= <expr>;` optional in free statics/consts.
Mazdak Farrokhzad [Fri, 14 Feb 2020 13:21:02 +0000 (14:21 +0100)]
ast: make `= <expr>;` optional in free statics/consts.

4 years agoAdd FIXME note
Yuki Okushi [Sat, 15 Feb 2020 19:36:44 +0000 (04:36 +0900)]
Add FIXME note

4 years agoAdd test for issue-68653
Yuki Okushi [Sat, 15 Feb 2020 17:55:03 +0000 (02:55 +0900)]
Add test for issue-68653

4 years agoAdd test for issue-63952
Yuki Okushi [Sat, 15 Feb 2020 17:54:51 +0000 (02:54 +0900)]
Add test for issue-63952

4 years agoAdd test for issue-62894
Yuki Okushi [Sat, 15 Feb 2020 17:54:33 +0000 (02:54 +0900)]
Add test for issue-62894

4 years agoAdd test for issue-51798
Yuki Okushi [Sat, 15 Feb 2020 17:54:16 +0000 (02:54 +0900)]
Add test for issue-51798

4 years agoAdd test for issue-39618
Yuki Okushi [Sat, 15 Feb 2020 17:53:58 +0000 (02:53 +0900)]
Add test for issue-39618

4 years agoPanic when hashing node IDs
John Kåre Alsaker [Sat, 15 Feb 2020 17:07:17 +0000 (18:07 +0100)]
Panic when hashing node IDs

4 years agoast: normalize `ForeignItemKind::Ty` & `AssocItemKind::TyAlias`.
Mazdak Farrokhzad [Fri, 14 Feb 2020 11:55:42 +0000 (12:55 +0100)]
ast: normalize `ForeignItemKind::Ty` & `AssocItemKind::TyAlias`.

4 years agoast: tweak comments of Foreign/AssocItemKind
Mazdak Farrokhzad [Thu, 13 Feb 2020 17:15:58 +0000 (18:15 +0100)]
ast: tweak comments of Foreign/AssocItemKind

4 years agoast: colocate AssocItem with ForeignItem
Mazdak Farrokhzad [Thu, 13 Feb 2020 17:05:40 +0000 (18:05 +0100)]
ast: colocate AssocItem with ForeignItem

4 years agoast: move Generics into AssocItemKinds
Mazdak Farrokhzad [Thu, 13 Feb 2020 17:03:38 +0000 (18:03 +0100)]
ast: move Generics into AssocItemKinds

4 years agoTreat NodeIs as pure values for incremental compilation
John Kåre Alsaker [Sun, 9 Feb 2020 14:08:31 +0000 (15:08 +0100)]
Treat NodeIs as pure values for incremental compilation

4 years agoClean up E0309 explanation
Guillaume Gomez [Sat, 15 Feb 2020 15:41:21 +0000 (16:41 +0100)]
Clean up E0309 explanation

4 years agoAdd fast path for is_freeze
Matthew Jasper [Sat, 15 Feb 2020 14:21:50 +0000 (14:21 +0000)]
Add fast path for is_freeze

4 years agoAlways qualify literals by type
Matthew Jasper [Mon, 3 Feb 2020 20:12:42 +0000 (20:12 +0000)]
Always qualify literals by type

4 years agoAuto merge of #69168 - brainlock:test-textrel-regression, r=Mark-Simulacrum,tmandry
bors [Sat, 15 Feb 2020 13:48:53 +0000 (13:48 +0000)]
Auto merge of #69168 - brainlock:test-textrel-regression, r=Mark-Simulacrum,tmandry

add regression test for issue #68794

This is a minimal regression test for the issue #68794: "TEXTREL in
i686", which was fixed with e86019c4a0968a1e393cdd0731649168624a88b8.

The test links a minimal rust static library into a shared library, and
checks that the linker didn't have to add the TEXTREL flag.

4 years agoImprove #Safety in various methods in core::ptr
Amos Onn [Fri, 31 Jan 2020 14:22:51 +0000 (15:22 +0100)]
Improve #Safety in various methods in core::ptr

For all methods which read a value of type T, `read`, `read_unaligned`,
`read_volatile` and `replace`, added missing
constraint:
The value they point to must be properly initialized

4 years agoImprove #Safety of core::ptr::replace
Amos Onn [Fri, 31 Jan 2020 14:18:27 +0000 (15:18 +0100)]
Improve #Safety of core::ptr::replace

Added missing condition:
`dst` must be readable

4 years agoImprove #Safety in various methods in core::ptr
Amos Onn [Sat, 15 Feb 2020 12:58:54 +0000 (13:58 +0100)]
Improve #Safety in various methods in core::ptr

s/for reads and writes/for both ...

4 years agoparser: `macro_rules` is a weak keyword
Vadim Petrochenkov [Sat, 15 Feb 2020 12:46:25 +0000 (15:46 +0300)]
parser: `macro_rules` is a weak keyword

4 years agoAuto merge of #69182 - Dylan-DPC:rollup-ifsa9fx, r=Dylan-DPC
bors [Sat, 15 Feb 2020 10:20:05 +0000 (10:20 +0000)]
Auto merge of #69182 - Dylan-DPC:rollup-ifsa9fx, r=Dylan-DPC

Rollup of 6 pull requests

Successful merges:

 - #64069 (Added From<Vec<NonZeroU8>> for CString)
 - #66721 (implement LowerExp and UpperExp for integers)
 - #69106 (Fix std::fs::copy on WASI target)
 - #69154 (Avoid calling `fn_sig` on closures)
 - #69166 (Check `has_typeck_tables` before calling `typeck_tables_of`)
 - #69180 (Suggest a comma if a struct initializer field fails to parse)

Failed merges:

r? @ghost

4 years agoRollup merge of #69180 - Aaron1011:feature/comma-struct-init, r=petrochenkov
Dylan DPC [Sat, 15 Feb 2020 08:45:49 +0000 (09:45 +0100)]
Rollup merge of #69180 - Aaron1011:feature/comma-struct-init, r=petrochenkov

Suggest a comma if a struct initializer field fails to parse

Currently, we emit a "try adding a comma" suggestion if a comma is
missing in a struct definition. However, we emit no such suggestion if a
comma is missing in a struct initializer.

This commit adds a "try adding a comma" suggestion when we don't find a
comma during the parsing of a struct initializer field.

The change to `src/test/ui/parser/removed-syntax-with-1.stderr` isn't
great, but I don't see a good way of avoiding it.

4 years agoRollup merge of #69166 - JohnTitor:ice-const-enum, r=matthewjasper
Dylan DPC [Sat, 15 Feb 2020 08:45:48 +0000 (09:45 +0100)]
Rollup merge of #69166 - JohnTitor:ice-const-enum, r=matthewjasper

Check `has_typeck_tables` before calling `typeck_tables_of`

Fixes #68684

r? @matthewjasper

4 years agoRollup merge of #69154 - JohnTitor:fix-macro-ices, r=petrochenkov
Dylan DPC [Sat, 15 Feb 2020 08:45:46 +0000 (09:45 +0100)]
Rollup merge of #69154 - JohnTitor:fix-macro-ices, r=petrochenkov

Avoid calling `fn_sig` on closures

Fixes #68060

r? @petrochenkov

4 years agoRollup merge of #69106 - RReverser:wasi-fs-copy, r=KodrAus
Dylan DPC [Sat, 15 Feb 2020 08:45:45 +0000 (09:45 +0100)]
Rollup merge of #69106 - RReverser:wasi-fs-copy, r=KodrAus

Fix std::fs::copy on WASI target

Previously `std::fs::copy` on wasm32-wasi would reuse code from the `sys_common` module and would successfully copy contents of the file just to fail right before closing it.

This was happening because `sys_common::copy` tries to copy permissions of the file, but permissions are not a thing in WASI (at least yet) and `set_permissions` is implemented as an unconditional runtime error.

This change instead adds a custom working implementation of `std::fs::copy` (like Rust already has on some other targets) that doesn't try to call `set_permissions` and is essentially a thin wrapper around `std::io::copy`.

Fixes #68560.

4 years agoRollup merge of #66721 - maxbla:exp-format-integers, r=KodrAus
Dylan DPC [Sat, 15 Feb 2020 08:45:43 +0000 (09:45 +0100)]
Rollup merge of #66721 - maxbla:exp-format-integers, r=KodrAus

implement LowerExp and UpperExp for integers

Addresses https://github.com/rust-lang/rust/issues/39479

This implementation is heavily based on the preexisting `macro_rules! impl_Display` in the same file. I don't like the liberal use of unsafe in that macro and would like to modify it so `unsafe` is only present where necessary. What is Rust's policy on doing such modifications?

Also, I couldn't figure out where to put tests, can I have some help with that?

4 years agoRollup merge of #64069 - danielhenrymantilla:feature/cstring_from_vec_of_nonzerou8...
Dylan DPC [Sat, 15 Feb 2020 08:45:38 +0000 (09:45 +0100)]
Rollup merge of #64069 - danielhenrymantilla:feature/cstring_from_vec_of_nonzerou8, r=KodrAus

Added From<Vec<NonZeroU8>> for CString

Added a `From<Vec<NonZeroU8>>` `impl` for `CString`

# Rationale

  - `CString::from_vec_unchecked` is a subtle function, that makes `unsafe` code harder to audit when the generated `Vec`'s creation is non-trivial. This `impl` allows to write safer `unsafe` code thanks to the very explicit semantics of the `Vec<NonZeroU8>` type.

  - One such situation is when trying to `.read()` a `CString`, see issue #59229.

      - this lead to a PR: #59314, that was closed for being too specific / narrow (it only targetted being able to `.read()` a `CString`, when this pattern could have been generalized).

     - the issue suggested another route, based on `From<Vec<NonZeroU8>>`, which is indeed a less general and more concise code pattern.

  - quoting @shnatsel:

      - >  For me the main thing about making this safe is simplifying auditing - people have spent like an hour looking at just this one unsafe block in libflate because it's not clear what exactly is unchecked, so you have to look it up when auditing anyway. This has distracted us from much more serious memory safety issues the library had.
Having this trivial impl in stdlib would turn this into safe code with compiler more or less guaranteeing that it's fine, and save anyone auditing the code a whole lot of time.

4 years agoMonomorphize const type during codegen.
Ben Lewis [Sat, 15 Feb 2020 04:43:14 +0000 (17:43 +1300)]
Monomorphize const type during codegen.

4 years agoSuggest a comma if a struct initializer field fails to parse
Aaron Hill [Sat, 15 Feb 2020 03:28:13 +0000 (22:28 -0500)]
Suggest a comma if a struct initializer field fails to parse

Currently, we emit a "try adding a comma" suggestion if a comma is
missing in a struct definition. However, we emit no such suggestion if a
comma is missing in a struct initializer.

This commit adds a "try adding a comma" suggestion when we don't find a
comma during the parsing of a struct initializer field.

The change to `src/test/ui/parser/removed-syntax-with-1.stderr` isn't
great, but I don't see a good way of avoiding it.

4 years agoimplement LowerExp and UpperExp for integers
Max Blachman [Sun, 24 Nov 2019 22:30:56 +0000 (14:30 -0800)]
implement LowerExp and UpperExp for integers

4 years agoAuto merge of #67681 - matthewjasper:infer-regions-in-borrowck, r=nikomatsakis
bors [Sat, 15 Feb 2020 02:24:04 +0000 (02:24 +0000)]
Auto merge of #67681 - matthewjasper:infer-regions-in-borrowck, r=nikomatsakis

Infer regions for opaque types in borrowck

This is a step towards the goal of typeck not doing region inference.

The commits up to `Arena allocate the result of mir_borrowck` are various bug fixes and prerequisites.
The remaining commits move opaque type inference to borrow checking.

r? @nikomatsakis

4 years agoFix emulate intrinsics return type.
Ben Lewis [Sat, 15 Feb 2020 01:45:36 +0000 (14:45 +1300)]
Fix emulate intrinsics return type.

4 years agoChange `const_field` and `const_caller_location` to return `ConstValue` instead of...
Ben Lewis [Fri, 14 Feb 2020 23:57:46 +0000 (12:57 +1300)]
Change `const_field` and `const_caller_location` to return `ConstValue` instead of `Const` as the type
in the returned const isn't needed.

4 years agoAuto merge of #69172 - JohnTitor:rollup-6cbmwcw, r=JohnTitor
bors [Fri, 14 Feb 2020 23:11:03 +0000 (23:11 +0000)]
Auto merge of #69172 - JohnTitor:rollup-6cbmwcw, r=JohnTitor

Rollup of 7 pull requests

Successful merges:

 - #68129 (Correct inference of primitive operand type behind binary operation)
 - #68475 (Use a `ParamEnvAnd<Predicate>` for caching in `ObligationForest`)
 - #68856 (typeck: clarify def_bm adjustments & add tests for or-patterns)
 - #69051 (simplify_try: address some of eddyb's comments)
 - #69128 (Fix extra subslice lowering)
 - #69150 (Follow-up to #68848)
 - #69164 (Update pulldown-cmark dependency)

Failed merges:

r? @ghost

4 years agoChange const eval to return `ConstValue`, instead of `Const` as the type inside it...
Ben Lewis [Fri, 14 Feb 2020 22:56:23 +0000 (11:56 +1300)]
Change const eval to return `ConstValue`, instead of `Const` as the type inside it shouldn't be used.

4 years agoFix tests after rebase
Matthew Jasper [Fri, 14 Feb 2020 22:39:55 +0000 (22:39 +0000)]
Fix tests after rebase

4 years agoSplit `type_of` out of collect.rs
Matthew Jasper [Fri, 17 Jan 2020 21:15:03 +0000 (21:15 +0000)]
Split `type_of` out of collect.rs

4 years agoAdd fast path to eq_opaque_type_and_type
Matthew Jasper [Fri, 17 Jan 2020 20:11:51 +0000 (20:11 +0000)]
Add fast path to eq_opaque_type_and_type

4 years agoFix and test nested impl Trait
Matthew Jasper [Sun, 12 Jan 2020 10:19:19 +0000 (10:19 +0000)]
Fix and test nested impl Trait

4 years agoUpdate tests
Matthew Jasper [Sat, 11 Jan 2020 17:18:58 +0000 (17:18 +0000)]
Update tests

4 years agoUse member constraint for most opaque types in NLL
Matthew Jasper [Sat, 11 Jan 2020 17:18:52 +0000 (17:18 +0000)]
Use member constraint for most opaque types in NLL

This ensures that NLL will infer suitable values for regions in opaque
types when it's possible.

4 years agoAlways check upper bounds when choosing member regions
Matthew Jasper [Sat, 11 Jan 2020 16:58:50 +0000 (16:58 +0000)]
Always check upper bounds when choosing member regions

Also correctly calculate what the upper bounds are.

4 years agoImprove opaque type lifetime errors
Matthew Jasper [Sat, 11 Jan 2020 14:12:39 +0000 (14:12 +0000)]
Improve opaque type lifetime errors

* Use better span for member constraint errors
* Avoid a bad suggestion
* Don't report member constraint errors if we have other universal
  region errors.

4 years agoHandle equal regions in opaque type inference
Matthew Jasper [Wed, 8 Jan 2020 21:20:38 +0000 (21:20 +0000)]
Handle equal regions in opaque type inference

4 years agoShow inferred opaque types with `#[rustc_regions]`
Matthew Jasper [Sun, 5 Jan 2020 18:27:51 +0000 (18:27 +0000)]
Show inferred opaque types with `#[rustc_regions]`

4 years agoAddress review comments
Matthew Jasper [Sun, 29 Dec 2019 14:23:20 +0000 (14:23 +0000)]
Address review comments

4 years agoUpdate tests
Matthew Jasper [Sat, 28 Dec 2019 15:54:27 +0000 (15:54 +0000)]
Update tests

4 years agoErase regions in opaque types in typeck
Matthew Jasper [Sat, 28 Dec 2019 15:52:51 +0000 (15:52 +0000)]
Erase regions in opaque types in typeck

4 years agoEnsure RPIT types get recorded in borrowck
Matthew Jasper [Sat, 28 Dec 2019 15:50:39 +0000 (15:50 +0000)]
Ensure RPIT types get recorded in borrowck

4 years agoAvoid unnecessary opaque type errors in borrowck
Matthew Jasper [Sat, 28 Dec 2019 15:50:06 +0000 (15:50 +0000)]
Avoid unnecessary opaque type errors in borrowck

4 years agoInfer opaque type regions in borrow checking
Matthew Jasper [Thu, 26 Dec 2019 21:16:28 +0000 (21:16 +0000)]
Infer opaque type regions in borrow checking

We want type checking for function bodies to ignore/erase regions. As
such, we need to infer the regions in opaque types in borrow check
instead.

4 years agoPrepare to use borrowck to resolve opaque types
Matthew Jasper [Wed, 25 Dec 2019 09:50:07 +0000 (09:50 +0000)]
Prepare to use borrowck to resolve opaque types

4 years agoArena allocate the result of mir_borrowck
Matthew Jasper [Thu, 26 Dec 2019 17:26:53 +0000 (17:26 +0000)]
Arena allocate the result of mir_borrowck

4 years agoGenerate more accurate MIR in `construct_error`
Matthew Jasper [Thu, 26 Dec 2019 17:51:39 +0000 (17:51 +0000)]
Generate more accurate MIR in `construct_error`

4 years agoAvoid calling `fn_sig` on closures
Yuki Okushi [Fri, 14 Feb 2020 03:46:06 +0000 (12:46 +0900)]
Avoid calling `fn_sig` on closures

4 years agoRollup merge of #69164 - GuillaumeGomez:update-pulldown-cmark, r=Dylan-DPC
Yuki Okushi [Fri, 14 Feb 2020 22:17:53 +0000 (07:17 +0900)]
Rollup merge of #69164 - GuillaumeGomez:update-pulldown-cmark, r=Dylan-DPC

Update pulldown-cmark dependency

r? @kinnison

cc @ollie27

Reopening of  #65894.

4 years agoRollup merge of #69150 - nnethercote:68848-follow-up, r=petrochenkov
Yuki Okushi [Fri, 14 Feb 2020 22:17:52 +0000 (07:17 +0900)]
Rollup merge of #69150 - nnethercote:68848-follow-up, r=petrochenkov

Follow-up to #68848

This PR contains some late changes to #68848 that somehow didn't get included when that PR was merged in a roll-up.

r? @petrochenkov

4 years agoRollup merge of #69128 - Centril:fix-69103, r=davidtwco
Yuki Okushi [Fri, 14 Feb 2020 22:17:50 +0000 (07:17 +0900)]
Rollup merge of #69128 - Centril:fix-69103, r=davidtwco

Fix extra subslice lowering

We are currently ICEing on e.g.
```rust
fn main() {
    let [.., b @ ..] = [1, 2];
    b;
}
```
This happens because `b @ ..` registers a binding such that `b;` is OK, but then we forget to lower that binding in `rustc_ast_lowering`.

Fixes #69103.

r? @davidtwco

4 years agoRollup merge of #69051 - Centril:st-fixes, r=eddyb
Yuki Okushi [Fri, 14 Feb 2020 22:17:49 +0000 (07:17 +0900)]
Rollup merge of #69051 - Centril:st-fixes, r=eddyb

simplify_try: address some of eddyb's comments

Addresses only https://github.com/rust-lang/rust/pull/66282#discussion_r376730986 and https://github.com/rust-lang/rust/pull/66282#discussion_r376730824.

r? @eddyb
cc @oli-obk

4 years agoRollup merge of #68856 - Centril:or-pat-ref-pat, r=matthewjasper
Yuki Okushi [Fri, 14 Feb 2020 22:17:47 +0000 (07:17 +0900)]
Rollup merge of #68856 - Centril:or-pat-ref-pat, r=matthewjasper

typeck: clarify def_bm adjustments & add tests for or-patterns

Clarify the adjustment algorithm for the expected type / default binding-modes when type checking patterns with more documentation and tweaks that make the algorithm more independent of the pattern forms.

Also resolve the FIXME noted for or-patterns by deciding that the current implementation is correct, noting the rationale and adding tests for the current implementation.

cc https://github.com/rust-lang/rust/issues/54883

r? @oli-obk @varkor

4 years agoRollup merge of #68475 - Aaron1011:fix/forest-caching, r=nikomatsakis
Yuki Okushi [Fri, 14 Feb 2020 22:17:45 +0000 (07:17 +0900)]
Rollup merge of #68475 - Aaron1011:fix/forest-caching, r=nikomatsakis

Use a `ParamEnvAnd<Predicate>` for caching in `ObligationForest`

Previously, we used a plain `Predicate` to cache results (e.g. successes
and failures) in ObligationForest. However, fulfillment depends on the
precise `ParamEnv` used, so this is unsound in general.

This commit changes the impl of `ForestObligation` for
`PendingPredicateObligation` to use `ParamEnvAnd<Predicate>` instead of
`Predicate` for the associated type. The associated type and method are
renamed from 'predicate' to 'cache_key' to reflect the fact that type is
no longer just a predicate.

4 years agoRollup merge of #68129 - varkor:infer-binary-operand-behind-reference, r=nikomatsakis
Yuki Okushi [Fri, 14 Feb 2020 22:17:43 +0000 (07:17 +0900)]
Rollup merge of #68129 - varkor:infer-binary-operand-behind-reference, r=nikomatsakis

Correct inference of primitive operand type behind binary operation

Fixes https://github.com/rust-lang/rust/issues/57447.

r? @nikomatsakis

4 years agoUpdate pulldown-cmark dependency
Guillaume Gomez [Thu, 13 Feb 2020 17:39:40 +0000 (18:39 +0100)]
Update pulldown-cmark dependency

4 years agoSimplify function signature in opaque_types
Matthew Jasper [Thu, 26 Dec 2019 20:46:38 +0000 (20:46 +0000)]
Simplify function signature in opaque_types

4 years agoGive some more queries descriptions
Matthew Jasper [Sat, 28 Dec 2019 11:24:26 +0000 (11:24 +0000)]
Give some more queries descriptions

4 years agoDistinguish RPIT from other impl trait
Matthew Jasper [Sat, 28 Dec 2019 15:39:52 +0000 (15:39 +0000)]
Distinguish RPIT from other impl trait

4 years agoCall `is_freeze` less in unsafety-checking
Matthew Jasper [Sat, 28 Dec 2019 15:51:44 +0000 (15:51 +0000)]
Call `is_freeze` less in unsafety-checking

This is to avoid cycles when calling `is_freeze` on an opaque type.

4 years agoCheck associated opaque types don't use unconstrained lifetimes
Matthew Jasper [Thu, 26 Dec 2019 23:41:32 +0000 (23:41 +0000)]
Check associated opaque types don't use unconstrained lifetimes