]> git.lizzy.rs Git - rust.git/log
rust.git
4 years agoRename macro_use_import -> macro_use_imports
flip1995 [Thu, 5 Mar 2020 18:22:17 +0000 (19:22 +0100)]
Rename macro_use_import -> macro_use_imports

4 years agoAuto merge of #5230 - DevinR528:macro-use, r=flip1995
bors [Thu, 5 Mar 2020 17:30:52 +0000 (17:30 +0000)]
Auto merge of #5230 - DevinR528:macro-use, r=flip1995

Macro use

---

changelog: This lint enforces Rust 2018 idiom of importing macro's directly without `#[macro_use]` fixes #5179 .

4 years agoAuto merge of #5235 - flip1995:tag_deploy_fix, r=phansch
bors [Thu, 5 Mar 2020 17:17:14 +0000 (17:17 +0000)]
Auto merge of #5235 - flip1995:tag_deploy_fix, r=phansch

Fix deploy script for tag deploys

By hand updating the documentation for the `rust-1.41.1` release, I found, that the deploy script was buggy for tag deploys. Luckily we weren't affected yet (will only run if the commit of the tag already has the workflow config, so probably ~`rust-1.43.0`)

The bug:

When a tag was deployed, until now it also updated the master documentation to the state of the tag. This was because the `git add .` not only updated the files created or modified by the tag commit, but also the master lints.json file.

changelog: none

4 years agoAuto merge of #5257 - mlegner:cast_hex_fp, r=flip1995
bors [Wed, 4 Mar 2020 16:11:40 +0000 (16:11 +0000)]
Auto merge of #5257 - mlegner:cast_hex_fp, r=flip1995

Resolve false positives of unnecessary_cast for non-decimal integers

This PR resolves false positives of `unnecessary_cast` for hexadecimal integers to floats and adds a corresponding test case.

Fixes: #5220
changelog: none

4 years agowarn on macro_use attr
Devin R [Wed, 26 Feb 2020 12:40:31 +0000 (07:40 -0500)]
warn on macro_use attr

4 years agoAuto merge of #5266 - sinkuu:questionmark, r=flip1995
bors [Wed, 4 Mar 2020 13:30:08 +0000 (13:30 +0000)]
Auto merge of #5266 - sinkuu:questionmark, r=flip1995

Lint `if let Some` and early return in question_mark lint

Fixes #5260

changelog: lint `if let Some` and early return in `question_mark` lint

4 years agoApply suggestions from code review
Shotaro Yamada [Wed, 4 Mar 2020 12:59:58 +0000 (12:59 +0000)]
Apply suggestions from code review

Co-Authored-By: Philipp Krones <hello@philkrones.com>
4 years agoSimplify if_chain.
mlegner [Wed, 4 Mar 2020 09:12:11 +0000 (10:12 +0100)]
Simplify if_chain.

4 years agoMove NumericLiteral to its own module.
mlegner [Tue, 3 Mar 2020 16:58:37 +0000 (17:58 +0100)]
Move NumericLiteral to its own module.

4 years agoIncluded binary and octal cases.
mlegner [Tue, 3 Mar 2020 16:05:09 +0000 (17:05 +0100)]
Included binary and octal cases.

4 years agoResolve false positives for hex int cast.
mlegner [Mon, 2 Mar 2020 21:44:32 +0000 (22:44 +0100)]
Resolve false positives for hex int cast.

4 years agoTest for unnecessary_cast of hex int literal.
mlegner [Mon, 2 Mar 2020 08:49:33 +0000 (09:49 +0100)]
Test for unnecessary_cast of hex int literal.

4 years agoAuto merge of #5258 - ThibsG:UselessBindingInStruct638, r=flip1995
bors [Wed, 4 Mar 2020 11:06:31 +0000 (11:06 +0000)]
Auto merge of #5258 - ThibsG:UselessBindingInStruct638, r=flip1995

Add lint for .. use in fully binded struct

This PR adds the lint `match-wild-in-fully-binded-struct` to prevent the use of the `..` pattern when all fields of the struct are already binded.

Fixes: #638
changelog: Add [`rest_pat_in_fully_bound_structs`] lint to warn against the use of `..` in fully binded struct

4 years agoAuto merge of #5246 - JarredAllen:master, r=flip1995
bors [Wed, 4 Mar 2020 10:53:03 +0000 (10:53 +0000)]
Auto merge of #5246 - JarredAllen:master, r=flip1995

Detect usage of custom floating-point abs implementation

Closes #5224

changelog: Enhance [`suboptimal_flops`] lint to detect manual implementations of the `abs` method

4 years agorun-rustfix
Shotaro Yamada [Wed, 4 Mar 2020 08:21:07 +0000 (17:21 +0900)]
run-rustfix

4 years agoLint `if let Some` in question_mark lint
Shotaro Yamada [Wed, 4 Mar 2020 07:59:16 +0000 (16:59 +0900)]
Lint `if let Some` in question_mark lint

4 years agoAdd restrictive pat use in full binded struct
ThibsG [Sun, 1 Mar 2020 16:36:14 +0000 (17:36 +0100)]
Add restrictive pat use in full binded struct

4 years agoUpdate test case answers to match cargo dev fmt
JarredAllen [Wed, 4 Mar 2020 03:23:04 +0000 (19:23 -0800)]
Update test case answers to match cargo dev fmt

4 years agoRan cargo dev fmt
JarredAllen [Wed, 4 Mar 2020 02:06:59 +0000 (18:06 -0800)]
Ran cargo dev fmt

4 years agoAuto merge of #5264 - flip1995:rustup, r=flip1995
bors [Wed, 4 Mar 2020 00:06:25 +0000 (00:06 +0000)]
Auto merge of #5264 - flip1995:rustup, r=flip1995

Rustup to rust-lang/rust#69506

changelog: none

4 years agoRustup to rust-lang/rust#69506
flip1995 [Tue, 3 Mar 2020 23:54:27 +0000 (00:54 +0100)]
Rustup to rust-lang/rust#69506

4 years agoRecommended changes from flip1995
JarredAllen [Tue, 3 Mar 2020 23:52:53 +0000 (15:52 -0800)]
Recommended changes from flip1995

4 years agoAuto merge of #5262 - JohnTitor:rls, r=flip1995
bors [Tue, 3 Mar 2020 20:13:19 +0000 (20:13 +0000)]
Auto merge of #5262 - JohnTitor:rls, r=flip1995

Revive rls integration test

RLS updated their dependencies in rust-lang/rls#1646 so we can revive the integration test. I confirm it passed on my local.

changelog: none

4 years agoRevive rls integration test
Yuki Okushi [Tue, 3 Mar 2020 19:32:42 +0000 (04:32 +0900)]
Revive rls integration test

4 years agoAuto merge of #5261 - matthiaskrgr:qmark, r=flip1995
bors [Tue, 3 Mar 2020 14:41:20 +0000 (14:41 +0000)]
Auto merge of #5261 - matthiaskrgr:qmark, r=flip1995

use question mark operator

changelog: none

4 years agouse question mark operator
Matthias Krüger [Tue, 3 Mar 2020 14:13:25 +0000 (15:13 +0100)]
use question mark operator

4 years agoAuto merge of #5256 - JohnTitor:try-eval-usize, r=phansch
bors [Tue, 3 Mar 2020 13:38:42 +0000 (13:38 +0000)]
Auto merge of #5256 - JohnTitor:try-eval-usize, r=phansch

Use `try_eval_usize` over `eval_usize`

Fixes #5223

changelog: Fix ICE in evaluating usizes

4 years agoAdd regression test
Yuki Okushi [Tue, 3 Mar 2020 12:39:45 +0000 (21:39 +0900)]
Add regression test

4 years agoUse `try_eval_usize` over `eval_usize`
Yuki Okushi [Mon, 2 Mar 2020 20:53:41 +0000 (05:53 +0900)]
Use `try_eval_usize` over `eval_usize`

4 years agoAuto merge of #5259 - flip1995:lang_items, r=phansch
bors [Tue, 3 Mar 2020 11:46:21 +0000 (11:46 +0000)]
Auto merge of #5259 - flip1995:lang_items, r=phansch

Use lang items instead of get_trait_def_id where possible

changelog: none

4 years agoAuto merge of #5047 - flip1995:use_debug, r=phansch
bors [Tue, 3 Mar 2020 11:32:51 +0000 (11:32 +0000)]
Auto merge of #5047 - flip1995:use_debug, r=phansch

Don't trigger use_debug lint in Debug impl

Fixes #5039

changelog: Don't trigger [`use_debug`] lint in Debug impl

4 years agoAuto merge of #5250 - mlegner:unused_fp, r=flip1995
bors [Tue, 3 Mar 2020 11:16:55 +0000 (11:16 +0000)]
Auto merge of #5250 - mlegner:unused_fp, r=flip1995

Whitelist unused attribute for use items.

This PR whitelists the `unused` attribute with `use` items and adds a corresponding test case.

Fixes: #5229
changelog: none

4 years agoAdd path for display trait
flip1995 [Tue, 3 Mar 2020 09:53:14 +0000 (10:53 +0100)]
Add path for display trait

4 years agoUse lang items instead of get_trait_def_id where possible
flip1995 [Tue, 3 Mar 2020 09:52:56 +0000 (10:52 +0100)]
Use lang items instead of get_trait_def_id where possible

4 years agoUpdate stderr
flip1995 [Tue, 14 Jan 2020 15:28:20 +0000 (16:28 +0100)]
Update stderr

4 years agoDon't lint debug formatting in debug impl
flip1995 [Tue, 14 Jan 2020 15:28:08 +0000 (16:28 +0100)]
Don't lint debug formatting in debug impl

4 years agoAuto merge of #5242 - matthiaskrgr:5238_test, r=flip1995
bors [Mon, 2 Mar 2020 20:31:27 +0000 (20:31 +0000)]
Auto merge of #5242 - matthiaskrgr:5238_test, r=flip1995

add test for #5238

changelog: none

4 years agoAuto merge of #5254 - JohnTitor:sugg, r=flip1995
bors [Mon, 2 Mar 2020 20:00:31 +0000 (20:00 +0000)]
Auto merge of #5254 - JohnTitor:sugg, r=flip1995

Rustup to rust-lang/rust#69469

changelog: none

4 years agoRustup to rust-lang/rust#69469
Yuki Okushi [Mon, 2 Mar 2020 19:37:39 +0000 (04:37 +0900)]
Rustup to rust-lang/rust#69469

4 years agoWhitelist unused attribute for use items.
mlegner [Mon, 2 Mar 2020 09:22:05 +0000 (10:22 +0100)]
Whitelist unused attribute for use items.

4 years agoFix one last test issue
JarredAllen [Mon, 2 Mar 2020 07:11:29 +0000 (23:11 -0800)]
Fix one last test issue

4 years agoRefactor suggested by krishna-veerareddy
JarredAllen [Mon, 2 Mar 2020 06:37:37 +0000 (22:37 -0800)]
Refactor suggested by krishna-veerareddy

4 years agoFixed compile error from merging
JarredAllen [Sun, 1 Mar 2020 21:12:56 +0000 (13:12 -0800)]
Fixed compile error from merging

4 years agoMerge branch 'master' of github.com:rust-lang/rust-clippy
JarredAllen [Sun, 1 Mar 2020 20:48:22 +0000 (12:48 -0800)]
Merge branch 'master' of github.com:rust-lang/rust-clippy

4 years agoAuto merge of #5247 - JohnTitor:syntax, r=flip1995
bors [Sun, 1 Mar 2020 15:41:00 +0000 (15:41 +0000)]
Auto merge of #5247 - JohnTitor:syntax, r=flip1995

Some rustups

changelog: none

4 years agoDisable rls test for now
Yuki Okushi [Sun, 1 Mar 2020 15:17:14 +0000 (00:17 +0900)]
Disable rls test for now

4 years agoRustup to rust-lang/rust#69579
Yuki Okushi [Sun, 1 Mar 2020 14:32:49 +0000 (23:32 +0900)]
Rustup to rust-lang/rust#69579

4 years agoRustup to rust-lang/rust#69592
Yuki Okushi [Sun, 1 Mar 2020 03:23:33 +0000 (12:23 +0900)]
Rustup to rust-lang/rust#69592

4 years agoChanged test output to reflect cargo fmt
JarredAllen [Sun, 1 Mar 2020 03:11:38 +0000 (19:11 -0800)]
Changed test output to reflect cargo fmt

4 years agoRun cargo dev fmt
JarredAllen [Sun, 1 Mar 2020 02:51:39 +0000 (18:51 -0800)]
Run cargo dev fmt

4 years agoFinished checking for cases of absolute values
JarredAllen [Sat, 29 Feb 2020 21:46:59 +0000 (13:46 -0800)]
Finished checking for cases of absolute values

4 years agoadd test for #5238
Matthias Krüger [Fri, 28 Feb 2020 21:00:20 +0000 (22:00 +0100)]
add test for #5238

4 years agoSome bugfixing
JarredAllen [Fri, 28 Feb 2020 20:40:13 +0000 (12:40 -0800)]
Some bugfixing

4 years agoCreated floating point abs lint and test, but not yet run
JarredAllen [Fri, 28 Feb 2020 06:31:41 +0000 (22:31 -0800)]
Created floating point abs lint and test, but not yet run

4 years agoFix deploy script for tag deploys
flip1995 [Thu, 27 Feb 2020 16:56:39 +0000 (17:56 +0100)]
Fix deploy script for tag deploys

4 years agoAuto merge of #5232 - JohnTitor:git2-0.12, r=phansch
bors [Thu, 27 Feb 2020 09:52:56 +0000 (09:52 +0000)]
Auto merge of #5232 - JohnTitor:git2-0.12, r=phansch

Update git2 to 0.12

changelog: none

4 years agoUpdate git2 to 0.12
Yuki Okushi [Thu, 27 Feb 2020 04:40:48 +0000 (13:40 +0900)]
Update git2 to 0.12

4 years agoAuto merge of #5231 - JohnTitor:associated-type-defaults, r=phansch
bors [Thu, 27 Feb 2020 06:40:31 +0000 (06:40 +0000)]
Auto merge of #5231 - JohnTitor:associated-type-defaults, r=phansch

Rustup to rust-lang/rust#61812

changelog: none

4 years agoRustup to rust-lang/rust#61812
Yuki Okushi [Thu, 27 Feb 2020 03:19:18 +0000 (12:19 +0900)]
Rustup to rust-lang/rust#61812

4 years agoAuto merge of #4897 - krishna-veerareddy:issue-2040-accurate-float-functions, r=flip1995
bors [Mon, 24 Feb 2020 08:33:03 +0000 (08:33 +0000)]
Auto merge of #4897 - krishna-veerareddy:issue-2040-accurate-float-functions, r=flip1995

Add lint to improve floating-point expressions

Looks for floating-point expressions that can be expressed using built-in methods to improve accuracy, performance and/or succinctness.

changelog: Add lint `floating_point_improvements`.

Fixes #4726
Partly addresses [#2040](https://github.com/rust-lang/rust-clippy/issues/2040)

Currently linted expressions:

| Expression | Suggestion |
|---------------------------------|------------|
| x.log(2.0) | x.log2() |
| x.log(10.0) | x.log10() |
| x.log(std::f32::consts::E) | x.ln() |
| (1 + x).ln() | x.ln_1p() |
| (2.0).powf(x) | x.exp2() |
| (std::f32::consts::E).powf(x) | x.exp() |
| x.powf(1/2) | x.sqrt() |
| x.powf(1/3) | x.cbrt() |
| x.powf(y), where y is whole | x.powi(y) |
| x.exp() - 1 | x.exp_m1() |
|x * y + z|x.mul_add(y, z)|

4 years agoAuto merge of #5222 - JohnTitor:dont-deploy, r=flip1995
bors [Mon, 24 Feb 2020 08:20:10 +0000 (08:20 +0000)]
Auto merge of #5222 - JohnTitor:dont-deploy, r=flip1995

Do not run deploy action on other repos

Usually, we don't have to run deploy action on other repos, let's ignore there.

changelog: none

4 years agoAdd `imprecise_flops` lint
Krishna Sai Veera Reddy [Mon, 24 Feb 2020 05:06:55 +0000 (21:06 -0800)]
Add `imprecise_flops` lint

Add lint to detect floating point operations that can be computed more
accurately at the cost of performance. `cbrt`, `ln_1p` and `exp_m1`
library functions call their equivalent cmath implementations which is
slower but more accurate so moving checks for these under this new lint.

4 years agoRename `mul_add` test file and add general improvements
Krishna Sai Veera Reddy [Mon, 24 Feb 2020 04:48:57 +0000 (20:48 -0800)]
Rename `mul_add` test file and add general improvements

4 years agoMove `manual_mul_add` into `suboptimal_flops` lint
Krishna Sai Veera Reddy [Sun, 23 Feb 2020 08:04:11 +0000 (00:04 -0800)]
Move `manual_mul_add` into `suboptimal_flops` lint

4 years agoRun rust-fix on tests
Krishna Sai Veera Reddy [Sun, 23 Feb 2020 04:32:13 +0000 (20:32 -0800)]
Run rust-fix on tests

4 years agoFix `powi` suggestion and add general improvements
Krishna Sai Veera Reddy [Sun, 23 Feb 2020 04:29:22 +0000 (20:29 -0800)]
Fix `powi` suggestion and add general improvements

4 years agoChange lint name to `suboptimal_flops`
Krishna Sai Veera Reddy [Mon, 17 Feb 2020 20:56:55 +0000 (12:56 -0800)]
Change lint name to `suboptimal_flops`

4 years agoRemove lint for logarithm division identity
Krishna Sai Veera Reddy [Mon, 17 Feb 2020 19:38:35 +0000 (11:38 -0800)]
Remove lint for logarithm division identity

4 years agoAdd type suffixes to unsuffixed method receiver suggestions
Krishna Veera Reddy [Sat, 4 Jan 2020 06:19:13 +0000 (22:19 -0800)]
Add type suffixes to unsuffixed method receiver suggestions

4 years agoDetect usage of `(x + 1).ln()` and suggest `x.ln_1p()` instead
Krishna Veera Reddy [Sat, 21 Dec 2019 04:07:03 +0000 (20:07 -0800)]
Detect usage of `(x + 1).ln()` and suggest `x.ln_1p()` instead

4 years agoSplit test cases into separate files
Krishna Veera Reddy [Sat, 21 Dec 2019 01:57:47 +0000 (17:57 -0800)]
Split test cases into separate files

4 years agoLint expressions of the form `x.log(b) / y.log(b)`
Krishna Veera Reddy [Tue, 17 Dec 2019 02:03:51 +0000 (18:03 -0800)]
Lint expressions of the form `x.log(b) / y.log(b)`

4 years agoSuggest usage of `powi` method when applicable
Krishna Veera Reddy [Mon, 16 Dec 2019 03:26:44 +0000 (19:26 -0800)]
Suggest usage of `powi` method when applicable

4 years agoConsolidate the accuracy and efficiency lints
Krishna Veera Reddy [Sun, 15 Dec 2019 04:10:23 +0000 (20:10 -0800)]
Consolidate the accuracy and efficiency lints

Merge the accuracy and efficiency lints into a single lint that
checks for improvements to accuracy, efficiency and readability
of floating-point expressions.

4 years agoAdd lints to detect inaccurate and inefficient FP operations
Krishna Veera Reddy [Sat, 14 Dec 2019 17:28:11 +0000 (09:28 -0800)]
Add lints to detect inaccurate and inefficient FP operations

Add lints to detect floating point computations that are either
inaccurate or inefficient and suggest better alternatives.

4 years agoDo not run deploy action on other repos
Yuki Okushi [Mon, 24 Feb 2020 04:38:35 +0000 (13:38 +0900)]
Do not run deploy action on other repos

4 years agoAuto merge of #5221 - JohnTitor:rustup, r=phansch
bors [Mon, 24 Feb 2020 05:58:17 +0000 (05:58 +0000)]
Auto merge of #5221 - JohnTitor:rustup, r=phansch

Rustup to rust-lang/rust#69366

changelog: none

4 years agoRustup to rust-lang/rust#69366
Yuki Okushi [Mon, 24 Feb 2020 04:33:04 +0000 (13:33 +0900)]
Rustup to rust-lang/rust#69366

4 years agoAuto merge of #5216 - krishna-veerareddy:issue-5192-fp-const-fn, r=flip1995
bors [Sat, 22 Feb 2020 12:44:06 +0000 (12:44 +0000)]
Auto merge of #5216 - krishna-veerareddy:issue-5192-fp-const-fn, r=flip1995

Prevent `missing_const_for_fn` on functions with const generic params

`const` functions cannot have const generic parameters so prevent the
`missing_const_for_fn` lint from firing in that case.

changelog: Fix false positive in `missing_const_for_fn`

Fixes #5192

4 years agoPrevent `missing_const_for_fn` on functions with const generic params
Krishna Sai Veera Reddy [Sat, 22 Feb 2020 03:52:04 +0000 (19:52 -0800)]
Prevent `missing_const_for_fn` on functions with const generic params

`const` functions cannot have const generic parameters so prevent the
`missing_const_for_fn` lint from firing in that case.

4 years agoAuto merge of #5029 - flip1995:wildcard_imports, r=phansch
bors [Fri, 21 Feb 2020 11:32:12 +0000 (11:32 +0000)]
Auto merge of #5029 - flip1995:wildcard_imports, r=phansch

New Lint: `wildcard imports`

Fixes #1228

### A few notes:
- I put this lint in the pedantic group, even though in the issue restriction was mentioned.
- Every fallout fix was automatically applied by `cargo fix` (This produced 3 `unused_imports` warnings) and are in commit 7e834c8. So reverting these changes wouldn't be a problem.

### A few ideas:
- A configuration to specify the amount of imported Items, where a `*` might be better.
- ~~A configuration to disable the lint for enums. Or just disable the lint for enums, since there is [`enum_glob_use`](https://rust-lang.github.io/rust-clippy/master/index.html#enum_glob_use)~~ I moved `enum_glob_use` into this lint in 12937f0

### A few quotes from the issue:
> Is there a way to ask the compiler about the modules or symbols that the current file is using?

Yes there is. I found it, once I was nearly finished implementing it myself. See 321d64a

> one hard optional feature would be to figure out what is currently used and add a suggestion to replace it with a full import list.

Yeah that was pretty hard, until I found the query for this. Queries are cool, but too hard to find.

> FWIW VS Code and Intellij IDEA both offer imports deglobbing which replace * with required imports.

And now, Clippy can do this too! :tada:

---

Your thoughts on the notes/ideas?

changelog: Add new lint [`wildcard imports`]. Add suggestion to [`enum_glob_use`]

4 years agoFix suggestion for weird formattings
flip1995 [Fri, 21 Feb 2020 09:15:38 +0000 (10:15 +0100)]
Fix suggestion for weird formattings

4 years agoDon't use use ty::TyKind::*
flip1995 [Fri, 21 Feb 2020 08:40:13 +0000 (09:40 +0100)]
Don't use use ty::TyKind::*

4 years agoFix fallout
flip1995 [Fri, 21 Feb 2020 08:39:38 +0000 (09:39 +0100)]
Fix fallout

4 years agoAdd test for prelude import
flip1995 [Sun, 9 Feb 2020 11:55:20 +0000 (12:55 +0100)]
Add test for prelude import

4 years agoFilter prelude glob imports
flip1995 [Sun, 9 Feb 2020 11:23:13 +0000 (12:23 +0100)]
Filter prelude glob imports

4 years agoMove enum_glob_use lint into wildcard_imports pass
flip1995 [Tue, 14 Jan 2020 12:52:08 +0000 (13:52 +0100)]
Move enum_glob_use lint into wildcard_imports pass

4 years agoLet's do it the easy way
flip1995 [Thu, 9 Jan 2020 17:12:54 +0000 (18:12 +0100)]
Let's do it the easy way

Queries are cool, but too hard to find.

4 years agoRun update_lints
flip1995 [Tue, 7 Jan 2020 16:54:08 +0000 (17:54 +0100)]
Run update_lints

4 years agoImplement wildcard_imports lint
flip1995 [Tue, 7 Jan 2020 16:53:56 +0000 (17:53 +0100)]
Implement wildcard_imports lint

4 years agoAdd tests for wildcard_imports lint
flip1995 [Tue, 7 Jan 2020 16:53:33 +0000 (17:53 +0100)]
Add tests for wildcard_imports lint

4 years agoAuto merge of #5202 - krishna-veerareddy:issue-5201-move-lossy-float-literal-restrict...
bors [Fri, 21 Feb 2020 09:43:55 +0000 (09:43 +0000)]
Auto merge of #5202 - krishna-veerareddy:issue-5201-move-lossy-float-literal-restriction, r=flip1995

Move check for lossy whole-number floats out of `excessive_precision`

changelog: Add new lint `lossy_float_literal` to detect lossy whole number float literals and move it out of `excessive_precision` again.

Fixes #5201

4 years agoAuto merge of #5213 - JohnTitor:warm-return-ty, r=flip1995
bors [Fri, 21 Feb 2020 08:27:37 +0000 (08:27 +0000)]
Auto merge of #5213 - JohnTitor:warm-return-ty, r=flip1995

Use generator own DefId

Fixes #5207

changelog: Fix ICE in `missing_errors_doc`

4 years agoAuto merge of #5200 - nipunn1313:unneeded_field_pattern, r=flip1995
bors [Fri, 21 Feb 2020 08:14:30 +0000 (08:14 +0000)]
Auto merge of #5200 - nipunn1313:unneeded_field_pattern, r=flip1995

Move unneeded_field_pattern to restriction group

Fixes #1741

changelog: Move unneeded_field_pattern to pedantic group

4 years agoUse generator own DefId
Yuki Okushi [Fri, 21 Feb 2020 07:24:58 +0000 (16:24 +0900)]
Use generator own DefId

4 years agoSeparate out lint to check lossy whole number float literals
Krishna Sai Veera Reddy [Fri, 21 Feb 2020 02:32:06 +0000 (18:32 -0800)]
Separate out lint to check lossy whole number float literals

4 years agoAuto merge of #5211 - krishna-veerareddy:rustup-69072, r=flip1995
bors [Fri, 21 Feb 2020 06:19:02 +0000 (06:19 +0000)]
Auto merge of #5211 - krishna-veerareddy:rustup-69072, r=flip1995

Rustup to rust-lang/rust#69072

changelog: none

4 years agoRustup to rust-lang/rust#69072
Krishna Sai Veera Reddy [Fri, 21 Feb 2020 05:20:49 +0000 (21:20 -0800)]
Rustup to rust-lang/rust#69072

4 years agoAuto merge of #5208 - matthiaskrgr:stderr, r=flip1995
bors [Thu, 20 Feb 2020 22:57:02 +0000 (22:57 +0000)]
Auto merge of #5208 - matthiaskrgr:stderr, r=flip1995

rustup https://github.com/rust-lang/rust/pull/69325, update test stderr

changelog: none

4 years agorustup https://github.com/rust-lang/rust/pull/69325, update test stderr
Matthias Krüger [Thu, 20 Feb 2020 22:54:10 +0000 (23:54 +0100)]
rustup https://github.com/rust-lang/rust/pull/69325, update test stderr