]>
git.lizzy.rs Git - rust.git/log
Josh Mcguigan [Tue, 9 Oct 2018 02:35:37 +0000 (19:35 -0700)]
Added new_ret_no_self exception to clippy to pass dogfood tests
Josh Mcguigan [Fri, 5 Oct 2018 04:37:28 +0000 (21:37 -0700)]
Removed new_ret_no_self tests from method.rs
Josh Mcguigan [Fri, 5 Oct 2018 02:01:04 +0000 (19:01 -0700)]
new_ret_no_self correctly lint impl return
Josh Mcguigan [Wed, 3 Oct 2018 12:00:43 +0000 (05:00 -0700)]
Removed unused variables
Josh Mcguigan [Wed, 3 Oct 2018 11:59:14 +0000 (04:59 -0700)]
new_ret_no_self fix false positive for impl trait return with associated type self
Josh Mcguigan [Wed, 3 Oct 2018 10:55:31 +0000 (03:55 -0700)]
new_ret_no_self corrected panic and added test stderr
Josh Mcguigan [Wed, 3 Oct 2018 03:11:56 +0000 (20:11 -0700)]
new_ret_no_self added positive test cases
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Sat, 13 Oct 2018 07:30:19 +0000 (09:30 +0200)]
Merge pull request #3233 from rust-lang-nursery/unused-unit
new lint: unused_unit
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Sat, 13 Oct 2018 07:24:55 +0000 (09:24 +0200)]
Merge pull request #3298 from devonhollowood/pedantic-dogfood-naming
Pedantic dogfood: naming and docs
Devon Hollowood [Sat, 13 Oct 2018 00:07:48 +0000 (17:07 -0700)]
Fix some more `stutter` warnings
Andre Bogus [Thu, 27 Sep 2018 17:10:20 +0000 (19:10 +0200)]
unused unit lint
Philipp Hansch [Fri, 12 Oct 2018 20:49:23 +0000 (22:49 +0200)]
Merge pull request #3304 from phansch/travis_windows_part2
Install Windows SDK 10.0 on travis
Philipp Hansch [Fri, 12 Oct 2018 20:04:58 +0000 (22:04 +0200)]
Install Windows SDK 10.0 on travis
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Fri, 12 Oct 2018 13:07:12 +0000 (15:07 +0200)]
Merge pull request #3291 from JoshMcguigan/cmp_owned-3289
cmp_owned wording and false positive
Josh Mcguigan [Fri, 12 Oct 2018 11:48:54 +0000 (04:48 -0700)]
cmp_owned refactor
Josh Mcguigan [Fri, 12 Oct 2018 11:34:41 +0000 (04:34 -0700)]
cmp_owned correct error message if rhs is deref
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Fri, 12 Oct 2018 11:16:34 +0000 (13:16 +0200)]
Merge pull request #3301 from sigustin/patch-1
Specify which categories are enabled by default
sigustin [Fri, 12 Oct 2018 10:32:48 +0000 (12:32 +0200)]
Add a comment reminding to update README if the default changes
sigustin [Fri, 12 Oct 2018 10:15:20 +0000 (12:15 +0200)]
Specify which categories are enabled by default
Closes #3293
Philipp Hansch [Fri, 12 Oct 2018 07:27:32 +0000 (09:27 +0200)]
Merge pull request #3300 from phansch/travis_windows
Add Travis windows build
Philipp Hansch [Fri, 12 Oct 2018 05:59:08 +0000 (07:59 +0200)]
Only run markdown linter on linux
Because:
* There's no need to run it on more than one platform
* It doesn't work on windows
Philipp Hansch [Fri, 12 Oct 2018 05:41:25 +0000 (07:41 +0200)]
Move Travis Windows build to allowed failures
Until the remaining issues are fixed. This also enabled `fast_finish`.
It will finish even if the windows build is still running.
Philipp Hansch [Fri, 12 Oct 2018 05:19:34 +0000 (07:19 +0200)]
Add Travis windows build
See https://blog.travis-ci.com/2018-10-11-windows-early-release
Devon Hollowood [Thu, 11 Oct 2018 22:43:13 +0000 (15:43 -0700)]
Fix `doc_markdown` lints
Devon Hollowood [Thu, 11 Oct 2018 22:36:40 +0000 (15:36 -0700)]
Fix `stutter` lints
Devon Hollowood [Thu, 11 Oct 2018 22:18:58 +0000 (15:18 -0700)]
Fix `similar_names` warnings
Most of these are just `#![allow]`ed, because they are things like using
l vs r to differentiate left vs right. These would be made less clear by
taking the advice of `similar_names`
Josh Mcguigan [Thu, 11 Oct 2018 12:03:02 +0000 (05:03 -0700)]
cmp_owned current suggestion for multiple deref
Oliver Scherer [Thu, 11 Oct 2018 10:18:27 +0000 (12:18 +0200)]
Remove now-useless `allow(unknown_lints)`
Oliver Scherer [Thu, 11 Oct 2018 10:16:22 +0000 (12:16 +0200)]
Stabilize tool lints
Philipp Hansch [Thu, 11 Oct 2018 08:53:05 +0000 (10:53 +0200)]
Merge pull request #3294 from mikerite/fix-3276
Fix fn_to_numeric_cast_with_truncation suppression
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Thu, 11 Oct 2018 07:20:20 +0000 (09:20 +0200)]
Merge pull request #3295 from phansch/refactor_clippy_dev
Use `impl Iterator` in arg position in clippy_dev
Philipp Hansch [Thu, 11 Oct 2018 06:34:51 +0000 (08:34 +0200)]
Use `impl Iterator` in arg position in clippy_dev
Small refactoring pulled out of work on #3266.
This should make the methods a bit more flexible.
Philipp Hansch [Thu, 11 Oct 2018 06:07:51 +0000 (08:07 +0200)]
Merge pull request #3288 from devonhollowood/pedantic-dogfood-casts
Pedantic dogfood: casts
Michael Wright [Thu, 11 Oct 2018 05:45:26 +0000 (07:45 +0200)]
Fix fn_to_numeric_cast_with_truncation suppression
Fixes #3276
mikerite [Thu, 11 Oct 2018 04:22:02 +0000 (06:22 +0200)]
Merge pull request #3127 from mikerite/fix-2937
Fix 2937
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Wed, 10 Oct 2018 20:35:02 +0000 (22:35 +0200)]
Merge pull request #3292 from kimsnj/commutative_assign_op
Limit commutative assign op lint to primitive types
Karim SENHAJI [Wed, 10 Oct 2018 15:05:16 +0000 (17:05 +0200)]
Limit commutative assign op lint to primitive types
Josh Mcguigan [Wed, 10 Oct 2018 11:51:06 +0000 (04:51 -0700)]
cmp_owned add test for multiple dereference
Devon Hollowood [Wed, 10 Oct 2018 06:35:10 +0000 (23:35 -0700)]
Clarify code
Take advantage of the fact that very large regexes are unlikely
Michael Wright [Wed, 10 Oct 2018 05:52:58 +0000 (07:52 +0200)]
Fix #2937
Josh Mcguigan [Wed, 10 Oct 2018 03:01:12 +0000 (20:01 -0700)]
Corrected single-character string constant used as pattern found in dogfood test
Josh Mcguigan [Wed, 10 Oct 2018 02:25:03 +0000 (19:25 -0700)]
Fixes 3289, cmp_owned wording and false positive
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Tue, 9 Oct 2018 08:01:31 +0000 (10:01 +0200)]
Merge pull request #3287 from JoshMcguigan/cmp_owned-2925
cmp_owned false positive
Devon Hollowood [Tue, 9 Oct 2018 05:34:10 +0000 (22:34 -0700)]
Fix cast_possible_wrap and cast_sign_loss warnings
Devon Hollowood [Tue, 9 Oct 2018 04:40:21 +0000 (21:40 -0700)]
Fix cast_possible_truncation warnings
Josh Mcguigan [Tue, 9 Oct 2018 02:04:29 +0000 (19:04 -0700)]
Fixes #2925 cmp_owned false positive
Philipp Hansch [Mon, 8 Oct 2018 19:54:08 +0000 (21:54 +0200)]
Merge pull request #3278 from d-dorazio/fix-contributing-manual-test-command
contributing.md: fix command to manually test an example
Philipp Hansch [Mon, 8 Oct 2018 19:31:04 +0000 (21:31 +0200)]
Merge pull request #3234 from matthiaskrgr/fix_3064_crash
if_let_redundant_pattern_matching: use Span.to() instead of Span.with_hi() to fix crash.
Matthias Krüger [Fri, 28 Sep 2018 19:09:57 +0000 (21:09 +0200)]
if_let_redundant_pattern_matching: use Span.to() instead of Span.with_hi() to fix crash.
Fixes #3064
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Mon, 8 Oct 2018 11:52:19 +0000 (13:52 +0200)]
Merge pull request #3286 from vmalloc/lifetime_elision_msg
Improve diagnostics in case of lifetime elision (closes #3284)
Rotem Yaari [Mon, 8 Oct 2018 08:43:13 +0000 (11:43 +0300)]
Improve diagnostics in case of lifetime elision (closes #3284)
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Mon, 8 Oct 2018 06:24:13 +0000 (08:24 +0200)]
Merge pull request #3282 from JoshMcguigan/excessive_precision-2840
Fix excessive_precision false positive
Philipp Hansch [Mon, 8 Oct 2018 06:22:09 +0000 (07:22 +0100)]
Merge pull request #3265 from mikerite/fix-export
Fix util/export.py to include lints from methods
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Mon, 8 Oct 2018 06:21:59 +0000 (08:21 +0200)]
Merge pull request #3283 from etaoins/dont-suggest-cloned-for-map-box-deref
Don't suggest cloned() for map Box deref
Philipp Hansch [Mon, 8 Oct 2018 05:59:55 +0000 (06:59 +0100)]
Merge pull request #3285 from devonhollowood/pedantic-dogfood-items-after-statements
Pedantic dogfood: `items_after_statements`
Devon Hollowood [Mon, 8 Oct 2018 00:08:20 +0000 (17:08 -0700)]
Fix items_after_statements for `const`s
Devon Hollowood [Mon, 8 Oct 2018 00:07:10 +0000 (17:07 -0700)]
Fix items_after_statements for sub-functions
Devon Hollowood [Mon, 8 Oct 2018 00:05:28 +0000 (17:05 -0700)]
Fix items_after_statements for `use` statements
Ryan Cumming [Sun, 7 Oct 2018 19:20:32 +0000 (06:20 +1100)]
Don't suggest cloned() for map Box deref
Boxes are a bit magic in that they need to use `*` to get an owned value
out of the box. They implement `Deref` but that only returns a
reference. This means an easy way to convert an `Option<Box<T>>` to an
`<Option<T>` is:
```
box_option.map(|b| *b)
```
However, since
b36bb0a6 the `map_clone` lint is detecting this as an
attempt to copy the box. Fix by excluding boxes completely from the
deref part of this lint.
Fixes #3274
Josh Mcguigan [Sun, 7 Oct 2018 18:38:20 +0000 (11:38 -0700)]
Fix excessive_precision false positive
Philipp Hansch [Sun, 7 Oct 2018 12:09:37 +0000 (13:09 +0100)]
Merge pull request #3280 from d-dorazio/fix-new_without_default-should-not-fire-unsafe-new
new_without_default should not warn about unsafe new
Manish Goregaokar [Sun, 7 Oct 2018 11:27:51 +0000 (04:27 -0700)]
Merge pull request #3279 from phansch/fix_fp_in_fn_to_numeric_cast_with_truncation
Fix FP in `fn_to_numeric_cast_with_truncation`
Philipp Hansch [Sun, 7 Oct 2018 10:18:40 +0000 (12:18 +0200)]
Fix FP in `fn_to_numeric_cast_with_truncation`
We only want this lint to check casts to numeric, as per the lint title.
Rust already has a built-in check for all other casts
[here][rust_check].
[rust_check]: https://github.com/rust-lang/rust/blob/
5472b0718f286266ab89acdf234c3552de7e973c /src/librustc_typeck/check/cast.rs#L430-L433
Daniele D'Orazio [Sun, 7 Oct 2018 10:39:54 +0000 (12:39 +0200)]
new_without_default should not warn about unsafe new
Daniele D'Orazio [Sat, 6 Oct 2018 18:07:41 +0000 (20:07 +0200)]
fix command to manually test an example
Philipp Hansch [Sun, 7 Oct 2018 09:02:46 +0000 (10:02 +0100)]
Merge pull request #3273 from maccoda/master
Adding more detail to filter_map lint documentation.
Manish Goregaokar [Sun, 7 Oct 2018 02:29:01 +0000 (19:29 -0700)]
Add license to README
Dylan Maccora [Sun, 7 Oct 2018 00:24:09 +0000 (11:24 +1100)]
Adding more detail to filter_map lint documentation.
Manish Goregaokar [Sat, 6 Oct 2018 17:21:57 +0000 (10:21 -0700)]
Merge pull request #3269 from rust-lang-nursery/relicense
Relicense clippy to the Rust license
Manish Goregaokar [Sat, 6 Oct 2018 17:20:48 +0000 (10:20 -0700)]
additional people
Manish Goregaokar [Sat, 6 Oct 2018 16:23:54 +0000 (09:23 -0700)]
Add license header to other files
Manish Goregaokar [Sat, 6 Oct 2018 16:18:06 +0000 (09:18 -0700)]
Add license header to Rust files
Manish Goregaokar [Fri, 5 Oct 2018 19:37:50 +0000 (12:37 -0700)]
Relicense clippy
Documentation on relicensing in previous commit
Fixes #2885
Also fixes #3093, fixes #3094, fixes 3095, fixes #3096, fixes #3097, fixes #3098,
fixes #3099, fixes #3100, fixes #3230
Manish Goregaokar [Fri, 5 Oct 2018 19:34:15 +0000 (12:34 -0700)]
Document relicensing process
Manish Goregaokar [Sat, 6 Oct 2018 05:35:04 +0000 (22:35 -0700)]
Merge pull request #3270 from rust-lang-nursery/rustup
Rustup for https://github.com/rust-lang/rust/pull/54741
Manish Goregaokar [Fri, 5 Oct 2018 20:41:40 +0000 (13:41 -0700)]
Rustup for https://github.com/rust-lang/rust/pull/54741
Manish Goregaokar [Fri, 5 Oct 2018 20:26:39 +0000 (13:26 -0700)]
Remove unused utils
Manish Goregaokar [Fri, 5 Oct 2018 18:14:55 +0000 (20:14 +0200)]
Merge pull request #3251 from rust-lang-nursery/relicense-rewrite
[do not merge] Relicensing rewrite
Philipp Krones [Fri, 5 Oct 2018 16:10:48 +0000 (18:10 +0200)]
Merge pull request #3268 from matthiaskrgr/rustup_macros_20
mini-macro: fix tests with latest rustc (rename feature: proc_macro_non_items -> proc_macro_hygiene).
Matthias Krüger [Fri, 5 Oct 2018 13:52:51 +0000 (15:52 +0200)]
mini-macro: fix tests with latest rustc (rename feature: proc_macro_non_items -> proc_macro_hygiene).
Philipp Krones [Fri, 5 Oct 2018 12:25:30 +0000 (14:25 +0200)]
Merge pull request #3267 from matthiaskrgr/travis_osx
travis: reenable osx
Matthias Krüger [Fri, 5 Oct 2018 10:01:52 +0000 (12:01 +0200)]
travis: reenable osx
Philipp Hansch [Fri, 5 Oct 2018 06:04:19 +0000 (07:04 +0100)]
Merge pull request #3264 from joelgallant/extern-type-complexity
Fixes #3222 by checking the BareFnTy Abi type
Michael Wright [Fri, 5 Oct 2018 06:02:44 +0000 (08:02 +0200)]
Fix util/export.py to include lints from methods
Philipp Hansch [Fri, 5 Oct 2018 05:49:08 +0000 (07:49 +0200)]
Fix fn_to_numeric_cast UI tests
This collapses both lint tests into one file.
Somehow allowing the other lint in the respective files did not work
correctly. Maybe that's fixed as part of fixing #3198.
Philipp Hansch [Fri, 5 Oct 2018 05:18:24 +0000 (07:18 +0200)]
Merge remote-tracking branch 'origin/master' into relicense-rewrite
Joel Gallant [Thu, 4 Oct 2018 23:30:45 +0000 (17:30 -0600)]
Solves #3222 by checking the BareFnTy Abi type
Philipp Hansch [Thu, 4 Oct 2018 20:26:54 +0000 (22:26 +0200)]
Only run tests if pointer width is 64bit
If the pointer width of the architechture is 32bit or something else,
then the tests will most likely produce different results.
Philipp Hansch [Thu, 4 Oct 2018 19:59:30 +0000 (21:59 +0200)]
Add hidden lifetime parameters to fix warning
Philipp Hansch [Thu, 4 Oct 2018 19:45:53 +0000 (20:45 +0100)]
Merge pull request #3259 from matthiaskrgr/build_warnings
resolve build warnings in clippy_lints/src/format.rs
Philipp Hansch [Thu, 4 Oct 2018 19:44:16 +0000 (21:44 +0200)]
Reimplement the `fn_to_numeric_cast_with_truncation` lint
Philipp Hansch [Thu, 4 Oct 2018 16:09:09 +0000 (18:09 +0200)]
Improve docs of fn_to_numeric_cast
Closes #2980
Philipp Krones [Thu, 4 Oct 2018 16:02:22 +0000 (18:02 +0200)]
Merge pull request #3261 from matthiaskrgr/travis_failure
make sure travis fails when clippy does not build.
Matthias Krüger [Thu, 4 Oct 2018 14:58:51 +0000 (16:58 +0200)]
make sure travis fails when clippy does not build.
Fixes #3260
Matthias Krüger [Thu, 4 Oct 2018 14:34:41 +0000 (16:34 +0200)]
resolve build warnings in clippy_lints/src/format.rs
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Thu, 4 Oct 2018 06:51:23 +0000 (08:51 +0200)]
Merge pull request #3255 from o01eg/env_logger
Allow to debug rustc_driver via logs.
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Thu, 4 Oct 2018 06:51:00 +0000 (08:51 +0200)]
Merge pull request #3256 from rust-lang-nursery/fix-2796
Fix 2796 and 3020
mcarton [Wed, 3 Oct 2018 18:59:59 +0000 (20:59 +0200)]
Don't suggest `to_string().to_string` in USELESS_FORMAT
O01eg [Wed, 3 Oct 2018 18:41:02 +0000 (21:41 +0300)]
Allow to debug rustc_driver via logs.
Philipp Hansch [Wed, 3 Oct 2018 10:02:06 +0000 (12:02 +0200)]
Reimplement the `fn_to_numeric_cast` lint