]>
git.lizzy.rs Git - rust.git/log
bors [Wed, 1 May 2019 01:55:14 +0000 (01:55 +0000)]
Auto merge of #4051 - yaahallo:master, r=Manishearth
use clippy-preview instead of clippy in dogfood
changelog: switch dogfood tests to use cargo clippy-preview
closes #4050
Jane Lusby [Wed, 1 May 2019 01:29:25 +0000 (18:29 -0700)]
use clippy-preview instead of clippy in cargo
bors [Tue, 30 Apr 2019 20:00:33 +0000 (20:00 +0000)]
Auto merge of #4039 - andrehjr:add-find-map-lints, r=flip1995
Add lints for find_map
changelog: adds lints for find_map and filter_map_next. Closes issue #3474
Hope I got everything correctly this time! Let me know if I missed something.
André Luis Leal Cardoso Junior [Sun, 28 Apr 2019 18:19:05 +0000 (15:19 -0300)]
Update find(p).map(p) occurrences to use find_map(p)
André Luis Leal Cardoso Junior [Sat, 27 Apr 2019 22:06:35 +0000 (19:06 -0300)]
Add lints for find_map
bors [Tue, 30 Apr 2019 07:20:58 +0000 (07:20 +0000)]
Auto merge of #4045 - matthiaskrgr:RTU, r=phansch
rustc_tools_util: try to handle case of not having CFG_RELEASE_CHANNEL better when getting compiler channel.
changelog: rustc_tools_util: try to handle case of not having CFG_RELEASE_CHANNEL better when getting compiler channel.
bors [Tue, 30 Apr 2019 05:34:55 +0000 (05:34 +0000)]
Auto merge of #4047 - rust-lang:rustup, r=Centril
Rustup to rustc 1.36.0-nightly (
f843ad60e 2019-04-30)
None
Manish Goregaokar [Tue, 30 Apr 2019 05:31:39 +0000 (22:31 -0700)]
Rustup to rustc 1.36.0-nightly (
f843ad60e 2019-04-30)
bors [Mon, 29 Apr 2019 07:03:54 +0000 (07:03 +0000)]
Auto merge of #4032 - phansch:add_tests, r=phansch
Add two more tests for redundant_closure
These two cases were fixed by #4008.
Closes #1439
changelog: none
bors [Mon, 29 Apr 2019 05:43:23 +0000 (05:43 +0000)]
Auto merge of #4046 - rust-lang:rustup, r=phansch
Rustup to rustc 1.36.0-nightly (
c7fcbfbf1 2019-04-29)
Updates to pass the lint introduced in https://github.com/rust-lang/rust/pull/60317
r? @oli-obk @mikerite
Manish Goregaokar [Mon, 29 Apr 2019 04:58:03 +0000 (21:58 -0700)]
Rustup to rustc 1.36.0-nightly (
c7fcbfbf1 2019-04-29)
See https://github.com/rust-lang/rust/pull/60317
bors [Sun, 28 Apr 2019 21:34:09 +0000 (21:34 +0000)]
Auto merge of #4044 - matthiaskrgr:travis_sort_jobs, r=phansch
travis: sort integration test jobs so that the jobs taking the most time are run first
changelog: none
Matthias Krüger [Sun, 28 Apr 2019 18:07:49 +0000 (20:07 +0200)]
rustc_tools_util: try to handle case of not having CFG_RELEASE_CHANNEL better when getting compiler channel.
Matthias Krüger [Sun, 28 Apr 2019 18:45:10 +0000 (20:45 +0200)]
travis: sort integration test jobs so that the jobs taking the most time are run first
bors [Sun, 28 Apr 2019 18:39:00 +0000 (18:39 +0000)]
Auto merge of #4043 - rust-lang:map-clone-iter, r=matthiaskrgr
Suggest .copied() for map_clone on iterators too
fixes https://github.com/rust-lang/rust-clippy/issues/3958
changelog: Make `map_clone` suggest the newly-stable `Iterator::copied()` when applicable
r? @mikerite @matthiaskrgr
Manish Goregaokar [Sun, 28 Apr 2019 18:14:39 +0000 (11:14 -0700)]
Suggest .copied() for map_clone on iterators too
bors [Sun, 28 Apr 2019 17:29:17 +0000 (17:29 +0000)]
Auto merge of #4042 - matthiaskrgr:toml_update, r=Manishearth
deps: bump toml from 0.4 to 0.5
changelog: none
Matthias Krüger [Sun, 28 Apr 2019 17:24:36 +0000 (19:24 +0200)]
deps: bump toml from 0.4 to 0.5
bors [Sun, 28 Apr 2019 15:19:12 +0000 (15:19 +0000)]
Auto merge of #4040 - mikerite:fix-build-
20190428 , r=Manishearth
Fix breakage due to rust-lang/rust#60225
Wrote this up before I saw that Manish already started on a fix in #4038. It no doubt contains errors. Feel free to close.
Michael Wright [Sun, 28 Apr 2019 07:11:20 +0000 (09:11 +0200)]
Fix breakage due to rust-lang/rust#60225
Philipp Hansch [Thu, 25 Apr 2019 19:46:34 +0000 (21:46 +0200)]
Add two more tests for redundant_closure
These two cases were fixed by #4008.
Closes #1439
changelog: none
bors [Thu, 25 Apr 2019 18:13:47 +0000 (18:13 +0000)]
Auto merge of #4008 - g-bartoszek:boxed-fnmut, r=phansch
Do not trigger redundant_closure for non-function types
fixes #3898
Added a check for the entity being called in the closure body to be a FnDef. This way lint does not trigger for ADTs (Box) but I'm not sure if it's correct and not too restrictive.
<!--
Thank you for making Clippy better!
We're collecting our changelog from pull request descriptions.
If your PR only updates to the latest nightly, you can leave the
`changelog` entry as `none`. Otherwise, please write a short comment
explaining your change.
If your PR fixes an issue, you can add "fixes #issue_number" into this
PR description. This way the issue will be automatically closed when
your PR is merged.
If you added a new lint, here's a checklist for things that will be
checked during review or continuous integration.
- [ ] Followed [lint naming conventions][lint_naming]
- [ ] Added passing UI tests (including committed `.stderr` file)
- [ ] `cargo test` passes locally
- [ ] Executed `util/dev update_lints`
- [ ] Added lint documentation
- [ ] Run `cargo fmt`
Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.
Delete this line and everything above before opening your PR -->
changelog: Fix false positive in `redundant_closure` pertaining to non-function types
bors [Thu, 25 Apr 2019 10:37:30 +0000 (10:37 +0000)]
Auto merge of #4026 - cemiloten:working-on-#3981, r=flip1995
Attempt to fix #3981
Fixes #3981
Hi, hopefully this is correct, happy to have feedback.
changelog: Don't trigger `unnecessary_cast` inside a macro
cemil [Wed, 24 Apr 2019 14:02:38 +0000 (16:02 +0200)]
Ignore unnecessary cast if inside macro
bors [Thu, 25 Apr 2019 09:16:46 +0000 (09:16 +0000)]
Auto merge of #4029 - phansch:update_pulldown_cmark, r=oli-obk
Update pulldown_cmark to 0.5
We now no longer have to use our own wrapper around `Parser` and can use
the new `OffsetIter`.
changelog: none
bors [Thu, 25 Apr 2019 06:38:38 +0000 (06:38 +0000)]
Auto merge of #4028 - phansch:skip_appveyor_on_pr_pushes, r=phansch
Only run AppVeyor on r+, try and the master branch
As it is right now, there is only one worker available in the `rust-lang-libs`
AppVeyor project and there are other repos as well that we share this worker
with. This has been a problem for us because we sometimes hit a bors timeout if there
are too many builds queued up.
To improve the situation, I think we could try to use AppVeyor a bit less
often. The average PR is not going to break windows related things anyway, so
it should be fine to run it on r+/try/master only.
changelog: none
bors [Thu, 25 Apr 2019 05:33:37 +0000 (05:33 +0000)]
Auto merge of #4030 - phansch:rustup190425, r=Manishearth
Rustup for https://github.com/rust-lang/rust/pull/59042
changelog: none
Philipp Hansch [Thu, 25 Apr 2019 05:29:23 +0000 (07:29 +0200)]
Rustup for https://github.com/rust-lang/rust/pull/59042
Philipp Hansch [Wed, 24 Apr 2019 05:47:01 +0000 (07:47 +0200)]
Update pulldown_cmark to 0.5
We now no longer have to use our own wrapper around `Parser` and can use
the new `OffsetIter`.
bors [Wed, 24 Apr 2019 20:40:36 +0000 (20:40 +0000)]
Auto merge of #4027 - kraai:remove-approx_constant-known-problems, r=phansch
Remove approx_constant known problems
Fixes #4025.
changelog: Remove `approx_constant`'s documentation's "Known problems" section.
Philipp Hansch [Wed, 24 Apr 2019 18:25:59 +0000 (20:25 +0200)]
Only run AppVeyor on r+, try and the master branch
As it is right now, there is only one worker available in the `rust-lang-libs`
AppVeyor project and there are other repos as well that we share this worker
with. This has been a problem for us because we sometimes hit a bors timeout if there
are too many builds queued up.
To improve the situation, I think we could try to use AppVeyor a bit less
often. The average PR is not going to break windows related things anyway, so
it should be fine to run it on r+/try/master only.
bors [Wed, 24 Apr 2019 17:16:59 +0000 (17:16 +0000)]
Auto merge of #4023 - phansch:add_test, r=flip1995
Add test for or_fun_call macro suggestion
changelog: none
Closes #1018
Matthew Kraai [Wed, 24 Apr 2019 16:01:12 +0000 (09:01 -0700)]
Remove approx_constant known problems
Fixes #4025.
bors [Wed, 24 Apr 2019 08:29:33 +0000 (08:29 +0000)]
Auto merge of #4022 - phansch:move_some_loop_tests, r=flip1995
UI test cleanup: Extract needless_range_loop tests
changelog: none
bors [Wed, 24 Apr 2019 07:29:35 +0000 (07:29 +0000)]
Auto merge of #4024 - kraai:suppress-let_and_return-if-let-has-attributes, r=flip1995
Suppress let_and_return if let has attributes
Fixes #3882.
changelog: suppress `let_and_return` if `let` has attributes
Matthew Kraai [Wed, 24 Apr 2019 06:32:16 +0000 (23:32 -0700)]
Suppress let_and_return if let has attributes
Fixes #3882.
Philipp Hansch [Wed, 24 Apr 2019 06:11:20 +0000 (08:11 +0200)]
Add test for or_fun_call macro suggestion
Closes #1018
Philipp Hansch [Wed, 24 Apr 2019 06:01:16 +0000 (08:01 +0200)]
UI test cleanup: Extract needless_range_loop tests
bors [Wed, 24 Apr 2019 05:27:17 +0000 (05:27 +0000)]
Auto merge of #4021 - kraai:change-cast_lossless-warning, r=Manishearth
Change "if types change" to "if you later change the type"
Fixes #3964.
changelog: change wording of `cast_lossless` message
Matthew Kraai [Tue, 23 Apr 2019 23:53:09 +0000 (16:53 -0700)]
Change "if types change" to "if you later change the type"
Fixes #3964.
bors [Tue, 23 Apr 2019 18:24:10 +0000 (18:24 +0000)]
Auto merge of #4018 - rust-lang:or_fn_call_variants, r=oli-obk
Ignore non-const ctor expressions in or_fn_call
Fixes https://github.com/rust-lang/rust-clippy/issues/1338
Should have been fixed by #919, however that focuses on const ctor expressions only, and `.or(Some(local))` isn't const.
This also automatically ignores things like `.or(Some(local.clone())` which we don't actually want to do; I need to figure out what to do here.
changelog: Fixed false positive in [`or_fn_call`] pertaining to enum variant constructors
r? @oli-obk @phansch
bors [Tue, 23 Apr 2019 16:19:29 +0000 (16:19 +0000)]
Auto merge of #4020 - rust-lang:rustup, r=phansch
Rustup to rustc 1.36.0-nightly (
fe0a415b4 2019-04-23)
r? @oli-obk @phansch
Manish Goregaokar [Tue, 23 Apr 2019 15:25:45 +0000 (08:25 -0700)]
Rustup to rustc 1.36.0-nightly (
fe0a415b4 2019-04-23)
Manish Goregaokar [Mon, 22 Apr 2019 22:39:38 +0000 (15:39 -0700)]
Add test
Manish Goregaokar [Mon, 22 Apr 2019 22:31:22 +0000 (15:31 -0700)]
Ignore all enum and struct constructors in lints about `*or(call())`
bors [Tue, 23 Apr 2019 08:37:44 +0000 (08:37 +0000)]
Auto merge of #4017 - Xanewok:wip-disambiguate-extern, r=oli-obk
compiletest: Disambiguate extern crate deps shared with the compiler
Fixes #4015.
changelog: Handle deps shared with the compiler in the internal compiletest suite
Attempts to fix the multiple matching crates error using the `--extern dep=path` disambiguation. This only includes `serde` at the moment because it's the only problematic dep right now (is inside Rust sysroot and pulled via `extern crate` in the test suite).
I'm not exactly sure this is the right approach (FWIW it fixes the issue locally), please do tell if this should be done differently.
Igor Matuszewski [Mon, 22 Apr 2019 13:04:48 +0000 (15:04 +0200)]
compiletest: Disambiguate extern crate deps shared with the compiler
bors [Sun, 21 Apr 2019 20:44:03 +0000 (20:44 +0000)]
Auto merge of #4013 - kraai:move-path_buf_push_overwrite-to-nursery, r=matthiaskrgr
Move path_buf_push_overwrite to nursery
See #4012.
changelog: move `path_buf_push_overwrite` to the nursery
bors [Sun, 21 Apr 2019 19:38:32 +0000 (19:38 +0000)]
Auto merge of #4014 - Xanewok:rustup-60124, r=matthiaskrgr
rustup: Use newly-introduced mutability query for statics
Fixes fallout from https://github.com/rust-lang/rust/pull/60124.
cc https://github.com/rust-lang/rust/issues/60154
changelog: none
Igor Matuszewski [Sun, 21 Apr 2019 19:00:52 +0000 (21:00 +0200)]
Use newly-introduced mutability query for statics
Fixes fallout from https://github.com/rust-lang/rust/pull/60124.
cc https://github.com/rust-lang/rust/issues/60154
Matthew Kraai [Sun, 21 Apr 2019 13:22:06 +0000 (06:22 -0700)]
Move path_buf_push_overwrite to nursery
See #4012.
Grzegorz [Sat, 20 Apr 2019 20:20:14 +0000 (22:20 +0200)]
redundant closure triggers for fnptrs and closures
bors [Sat, 20 Apr 2019 18:55:48 +0000 (18:55 +0000)]
Auto merge of #4011 - phansch:add_test_for_derive_expansion, r=flip1995
Add test for derives for used_underscore_binding lint
This closes #852 as I can't reproduce the original issue anymore.
changelog: none
bors [Sat, 20 Apr 2019 18:22:53 +0000 (18:22 +0000)]
Auto merge of #4007 - phansch:fix_allowing_toplevel_ref_arg, r=flip1995
Allow allowing of toplevel_ref_arg lint
I'm not sure why some lints need the `HirId` to be able to recognize the
lint level attributes, but this commit makes the lint level attributes
work for `toplevel_ref_arg`.
Fixes #2332
changelog: Allow allowing of `toplevel_ref_arg` lint
bors [Sat, 20 Apr 2019 17:21:20 +0000 (17:21 +0000)]
Auto merge of #4005 - phansch:rustfix_match_as_ref, r=flip1995
Add run-rustfix for match_as_ref lint
* Extracts `match_as_ref` into separate file
* Adds `// run-rustfix` to `tests/ui/match_as_ref.rs`
cc #3630
changelog: none
bors [Sat, 20 Apr 2019 16:58:51 +0000 (16:58 +0000)]
Auto merge of #4006 - phansch:fix_module_name_repetitions_fp, r=flip1995
Fix false positive in module_name_repetitions lint
This lint was triggering on modules inside expanded attrs, like
for example `#[cfg(test)]` and possibly more.
It was not reporting a location in #3892 because `span.lo()` and `span.hi()` both were 0.
Fixes #3892
changelog: Fix false positive in `module_name_repetitions` lint
Philipp Hansch [Sat, 20 Apr 2019 07:33:13 +0000 (09:33 +0200)]
Add test for derives for used_underscore_binding lint
This closes #852 as I can't reproduce the original issue anymore.
bors [Fri, 19 Apr 2019 17:11:13 +0000 (17:11 +0000)]
Auto merge of #4009 - phansch:update_compiletest, r=phansch
Update compiletest_rs
This includes a fix that make ICEs appear in UI tests again.
Philipp Hansch [Fri, 19 Apr 2019 16:23:25 +0000 (18:23 +0200)]
Update compiletest_rs
This includes a fix that make ICEs appear in UI tests again.
Philipp Hansch [Fri, 19 Apr 2019 13:18:32 +0000 (15:18 +0200)]
Allow allowing of toplevel_ref_arg lint
I'm not sure why some lints need the `HirId` to be able to recognize the
lint level attributes, but this commit makes the lint level attributes
work for `toplevel_ref_arg`.
Grzegorz [Sun, 31 Mar 2019 12:10:17 +0000 (14:10 +0200)]
redundant closure for functions restricted to FnDefs
Philipp Hansch [Fri, 19 Apr 2019 10:53:03 +0000 (12:53 +0200)]
Fix false positive in module_name_repetitions lint
This lint was triggering on modules inside expanded attrs, like
for example `#[cfg(test)]` and possibly more.
Philipp Hansch [Fri, 19 Apr 2019 10:08:00 +0000 (12:08 +0200)]
Add run-rustfix for match_as_ref lint
* Extracts `match_as_ref` into separate file
* Adds `// run-rustfix` to `tests/ui/match_as_ref.rs`
bors [Fri, 19 Apr 2019 09:57:35 +0000 (09:57 +0000)]
Auto merge of #3989 - flip1995:assert_on_const, r=phansch
Don't trigger assertions_on_constants on debug_assert!(false)
Fixes #3948
Fixes #3765
changelog: Fix `debug_assert!` false positive on `assertions_on_constants` lint
bors [Thu, 18 Apr 2019 23:16:15 +0000 (23:16 +0000)]
Auto merge of #3990 - felixrabe:patch-1, r=flip1995
Typo
changelog: none
bors [Thu, 18 Apr 2019 21:18:23 +0000 (21:18 +0000)]
Auto merge of #3978 - phansch:rustfix_len_zero, r=flip1995
Add run-rustfix for len_zero lint
* Extracts len_without_is_empty into separate file
* Adds `// run-rustfix` to `tests/ui/len_zero.rs`
cc #3630
Felix Rabe [Thu, 18 Apr 2019 13:08:14 +0000 (15:08 +0200)]
Typo
flip1995 [Thu, 18 Apr 2019 11:37:20 +0000 (13:37 +0200)]
Fix dogfood error
bors [Thu, 18 Apr 2019 11:29:43 +0000 (11:29 +0000)]
Auto merge of #3954 - andrehjr:add-lint-path-buf-overwrite, r=flip1995
Add Lint PathBufPushOverwrite
Closes #3923
This is a very simple Lint that checks if push is being called with a Root Path. Because that can make it overwrite the previous path.
I used std::path::Path to check if it's root, in order to keep it working across windows/linux environments instead of checking for '/'. Is that alright?
On the `if_chain!` block, Is there a way to make it short while getting the value of the first argument? I got the example from other lints.
Note that this is first Lint, I hope I got everything covered 🚀
André Luis Leal Cardoso Junior [Sat, 13 Apr 2019 16:47:46 +0000 (13:47 -0300)]
Add lint PathBufPushOverwrite
bors [Thu, 18 Apr 2019 10:06:55 +0000 (10:06 +0000)]
Auto merge of #3985 - phansch:move_some_cast_tests, r=flip1995
Move two cast_lossless tests to their correct files
First part of checking off the `tests/ui/cast.rs` checkbox in #3630.
flip1995 [Thu, 18 Apr 2019 10:05:09 +0000 (12:05 +0200)]
Update *.stderr file
flip1995 [Thu, 18 Apr 2019 10:04:46 +0000 (12:04 +0200)]
Remove code duplication
flip1995 [Thu, 18 Apr 2019 09:48:55 +0000 (11:48 +0200)]
Format code
flip1995 [Thu, 18 Apr 2019 09:48:19 +0000 (11:48 +0200)]
Add test for debug_assert!(false)
flip1995 [Thu, 18 Apr 2019 09:47:39 +0000 (11:47 +0200)]
Don't lint debug_assert!(false)
bors [Thu, 18 Apr 2019 09:43:42 +0000 (09:43 +0000)]
Auto merge of #3987 - phansch:rustfix_option_map_or_none, r=flip1995
Add run-rustfix for option_map_or_none lint
* Extracts `option_map_or_none` tests into separate file
* Adds `// run-rustfix` to `tests/ui/option_map_or_none.rs`
cc #3630
bors [Thu, 18 Apr 2019 07:49:09 +0000 (07:49 +0000)]
Auto merge of #3984 - phansch:bytecount_sugg, r=flip1995
Change naive_bytecount applicability to MaybeIncorrect
We can't use `MachineApplicable` here as applying the fix will cause
another error because `bytecount` would first have to be added to the
Cargo.toml.
Example:
```
error: You appear to be counting bytes the naive way
--> $DIR/bytecount.rs:5:13
|
LL | let _ = x.iter().filter(|&&a| a == 0).count(); // naive byte count
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider using the bytecount crate: `bytecount::count(x, 0)`
```
Just replacing it with the suggestion is not enough.
cc #3630
bors [Thu, 18 Apr 2019 07:24:35 +0000 (07:24 +0000)]
Auto merge of #3968 - kraai:lint-pass-macros, r=flip1995
Lint pass macros
Philipp Hansch [Thu, 18 Apr 2019 06:12:59 +0000 (08:12 +0200)]
Add run-rustfix for option_map_or_none lint
Philipp Hansch [Wed, 17 Apr 2019 19:03:22 +0000 (21:03 +0200)]
Move two cast_lossless tests to their correct files
First part of checking off the `tests/ui/cast.rs` checkbox in #3630.
Philipp Hansch [Wed, 17 Apr 2019 18:46:42 +0000 (20:46 +0200)]
Change naive_bytecount applicability MaybeIncorrect
We can't use `MachineApplicable` here as applying the fix will cause
another error because `bytecount` would first have to be added to the
Cargo.toml.
Matthew Kraai [Tue, 16 Apr 2019 22:21:12 +0000 (15:21 -0700)]
Add tests for declare_lint_pass and impl_lint_pass
Matthew Kraai [Mon, 8 Apr 2019 20:43:55 +0000 (13:43 -0700)]
Use lint pass macros
Fixes #3917.
Matthew Kraai [Mon, 8 Apr 2019 06:40:59 +0000 (23:40 -0700)]
Document `declare_lint_pass!`
flip1995 [Fri, 5 Apr 2019 20:21:19 +0000 (22:21 +0200)]
Fix lint_without_lint_pass internal lint
bors [Wed, 17 Apr 2019 11:09:25 +0000 (11:09 +0000)]
Auto merge of #3926 - flip1995:def_path_uplift, r=phansch
Use {get,match}_def_path from rustc
This is a follow up of the uplift of `{get,match}_def_path` to rustc.
~~This is blocked on rust-lang/rust#59779~~
flip1995 [Sun, 7 Apr 2019 17:44:10 +0000 (19:44 +0200)]
Use {get,match}_def_path from LateContext
flip1995 [Sun, 7 Apr 2019 17:40:46 +0000 (19:40 +0200)]
Remove uplifted functions {get,match}_def_path from Clippy
bors [Wed, 17 Apr 2019 04:46:19 +0000 (04:46 +0000)]
Auto merge of #3966 - flip1995:internal_lints, r=oli-obk
Enable rustc internal lints
Closes #3965
I'm not 100% sure if enabling the `-Zunstable-options` flag in the `.cargo/config` file is the right place.
bors [Wed, 17 Apr 2019 02:35:02 +0000 (02:35 +0000)]
Auto merge of #3977 - phansch:add_rustfix_bool_comparison, r=flip1995
Add run-rustfix for bool_comparison lint
cc #3630
bors [Wed, 17 Apr 2019 01:50:58 +0000 (01:50 +0000)]
Auto merge of #3976 - phansch:deref_addrof_rustfix, r=flip1995
Add run-rustfix for deref_addrof lint
* renames `tests/ui/reference.{rs,stderr}` to
`tests/ui/deref_addrof.{rs,stderr}
* Moves small part of the testfile to a separate file as the lint
triggered again on the fixed code (as intended)
* Adds `// run-rustfix` to `tests/ui/deref_addrof.rs`
cc #3630
bors [Wed, 17 Apr 2019 01:14:27 +0000 (01:14 +0000)]
Auto merge of #3975 - phansch:has_placeholders, r=flip1995
Change while_let_loop applicability to HasPlaceholders
The suggestion has been changed at some point to use `..` in the suggested code.
Due to that we can't make the lint MachineApplicable anymore.
cc #3630
bors [Tue, 16 Apr 2019 23:52:59 +0000 (23:52 +0000)]
Auto merge of #3972 - rust-lang:oli-obk-patch-1, r=flip1995,Manishearth
Create PULL_REQUEST_TEMPLATE
changelog: none
addresses https://github.com/rust-lang/rust-clippy/issues/3955#issuecomment-
483567400
Philipp Hansch [Tue, 16 Apr 2019 19:46:07 +0000 (21:46 +0200)]
Add run-rustfix for len_zero lint
* Extracts len_without_is_empty into separate file
* Adds `// run-rustfix` to `tests/ui/len_zero.rs`
Philipp Hansch [Tue, 16 Apr 2019 18:42:54 +0000 (20:42 +0200)]
Add run-rustfix for bool_comparison lint
Philipp Hansch [Tue, 16 Apr 2019 18:26:55 +0000 (20:26 +0200)]
Add run-rustfix for deref_addrof lint
* renames `tests/ui/reference.{rs,stderr}` to
`tests/ui/deref_addrof.{rs,stderr}
* Moves small part of the testfile to a separate file as the lint
triggered again on the fixed code (as intended)
* Adds `// run-rustfix` to `tests/ui/deref_addrof.rs`
Philipp Hansch [Tue, 16 Apr 2019 18:05:16 +0000 (20:05 +0200)]
while_let_loop uses placeholders in suggestions
Due to that we can't make the lint MachineApplicable anymore.
flip1995 [Tue, 16 Apr 2019 15:17:07 +0000 (17:17 +0200)]
Remove rust-toolchain file from clippy_dev
Oliver Scherer [Tue, 16 Apr 2019 13:16:08 +0000 (15:16 +0200)]
Update adding_lints.md