]>
git.lizzy.rs Git - rust.git/log
bors[bot] [Sat, 8 May 2021 11:14:24 +0000 (11:14 +0000)]
Merge #8764
8764: internal: add rust-analyzer version to panic context r=matklad a=matklad
bors r+
π€
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sat, 8 May 2021 11:03:12 +0000 (14:03 +0300)]
internal: add rust-analyzer version to panic context
bors[bot] [Sat, 8 May 2021 10:49:00 +0000 (10:49 +0000)]
Merge #8763
8763: feat: make troubleshooting a top-level section r=matklad a=matklad
bors r+
π€
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sat, 8 May 2021 10:48:25 +0000 (13:48 +0300)]
feat: make troubleshooting a top-level section
bors[bot] [Sat, 8 May 2021 10:37:01 +0000 (10:37 +0000)]
Merge #8762
8762: internal: disable broken incremental builds πΏ r=matklad a=matklad
bors r+
π€
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sat, 8 May 2021 10:36:06 +0000 (13:36 +0300)]
internal: disable broken incremental builds πΏ
bors[bot] [Sat, 8 May 2021 10:19:05 +0000 (10:19 +0000)]
Merge #8761
8761: feat: friendlier trouble shooting guide r=matklad a=matklad
bors r+
π€
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sat, 8 May 2021 10:18:25 +0000 (13:18 +0300)]
feat: friendlier trouble shooting guide
bors[bot] [Sat, 8 May 2021 09:20:57 +0000 (09:20 +0000)]
Merge #8760
8760: :arrow_up: package-lock.json r=matklad a=matklad
bors r+
π€
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sat, 8 May 2021 09:20:06 +0000 (12:20 +0300)]
:arrow_up: package-lock.json
bors[bot] [Sat, 8 May 2021 06:04:09 +0000 (06:04 +0000)]
Merge #8759
8759: docs: Add Kate installation section r=matklad a=meven
Replaces https://github.com/rust-analyzer/rust-analyzer.github.io/pull/111#issuecomment-
834797031
Co-authored-by: MΓ©ven Car <meven29@gmail.com>
MΓ©ven Car [Sat, 8 May 2021 05:33:24 +0000 (07:33 +0200)]
docs: Add Kate installation section
bors[bot] [Fri, 7 May 2021 21:27:20 +0000 (21:27 +0000)]
Merge #8755
8755: fix: direct people to the right repository r=matklad a=matklad
bors r+
π€
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 7 May 2021 21:19:01 +0000 (00:19 +0300)]
fix: direct people to the right repository
bors[bot] [Fri, 7 May 2021 20:50:47 +0000 (20:50 +0000)]
Merge #8753
8753: internal: expose cfg attrs from hir::Crate r=matklad a=matklad
bors r+
π€
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 7 May 2021 20:35:43 +0000 (23:35 +0300)]
internal: expose cfg attrs from hir::Crate
bors[bot] [Fri, 7 May 2021 19:47:09 +0000 (19:47 +0000)]
Merge #8752
8752: Switch from jemalloc to tikv-jemalloc r=matklad a=djrenren
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/8252.
No idea if we're still interested in this but it was a simple change so here's the PR.
Co-authored-by: John Renner <john@jrenner.net>
John Renner [Fri, 7 May 2021 19:41:07 +0000 (12:41 -0700)]
Use package renaming so source doesn't say tikv
John Renner [Fri, 7 May 2021 19:17:37 +0000 (12:17 -0700)]
Switch from jemalloc to tikv-jemalloc
bors[bot] [Fri, 7 May 2021 18:47:05 +0000 (18:47 +0000)]
Merge #8751
8751: minor: standard snippet r=matklad a=matklad
bors r+
π€
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 7 May 2021 18:46:25 +0000 (21:46 +0300)]
minor: standard snippet
bors[bot] [Fri, 7 May 2021 15:33:08 +0000 (15:33 +0000)]
Merge #8748
8748: fix: use raw idents in `make::{name, name_ref}` when used with a keyword r=jonas-schievink a=jonas-schievink
fixes https://github.com/rust-analyzer/rust-analyzer/issues/8680
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Jonas Schievink [Fri, 7 May 2021 13:35:02 +0000 (15:35 +0200)]
fix: use raw idents in `make::name{_ref}` with keywords
bors[bot] [Thu, 6 May 2021 22:28:35 +0000 (22:28 +0000)]
Merge #8745
8745: Support goto_type_definition for types r=matklad a=Veykril
I'm unsure if the approach of lowering an `ast::Type` to a `hir::Type` is a good idea, it seems fine to me at least.
Fixes #2882
Co-authored-by: Lukas Tobias Wirth <lukastw97@gmail.com>
bors[bot] [Thu, 6 May 2021 22:19:52 +0000 (22:19 +0000)]
Merge #8280
8280: Borrow text of immutable syntax node r=iDawer a=iDawer
In https://github.com/rust-analyzer/rowan/pull/101 `rowan::SyntaxNode::green` returns `Cow<'_, GreenNodeData>`. It returns borrow of green node of immutable syntax tree node.
Using this we can return borrowed text from `ast::Name::text`.
~~However now it allocates in case of mutable syntax trees.~~ (see next comment)
The idea comes from https://github.com/rust-analyzer/rowan/pull/100#issuecomment-
809330325
Co-authored-by: Dawer <7803845+iDawer@users.noreply.github.com>
bors[bot] [Thu, 6 May 2021 21:53:05 +0000 (21:53 +0000)]
Merge #8746
8746: Don't store call-site text offsets in hygiene info r=matklad a=jonas-schievink
This threads a lot more database references around in order to avoid storing a bare `TextOffset` in the hygiene info. This `TextOffset` made hygiene info and `ItemTree`s more volatile than they should be, leading to excessive recomputation of `ItemTree`s.
The incremental test added in https://github.com/rust-analyzer/rust-analyzer/pull/8721 is now passing with these changes.
closes https://github.com/rust-analyzer/rust-analyzer/pull/8721
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Jonas Schievink [Thu, 6 May 2021 21:23:50 +0000 (23:23 +0200)]
Reuse database in LowerCtx
Aleksey Kladov [Tue, 4 May 2021 14:12:35 +0000 (17:12 +0300)]
Update crates/hir_def/src/nameres/tests/incremental.rs
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Aleksey Kladov [Tue, 4 May 2021 12:31:23 +0000 (15:31 +0300)]
internal: add failing incremental test
Jonas Schievink [Thu, 6 May 2021 17:59:54 +0000 (19:59 +0200)]
Don't store call-site text offsets in hygiene info
bors[bot] [Thu, 6 May 2021 17:29:30 +0000 (17:29 +0000)]
Merge #8718
8718: 1.52.0 r=SomeoneToIgnore a=matklad
A lot of APIs we use in this release!
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
Kirill Bulatov [Thu, 6 May 2021 17:12:30 +0000 (20:12 +0300)]
Small macro fix
Aleksey Kladov [Tue, 4 May 2021 11:10:49 +0000 (14:10 +0300)]
internal: use API stabilized in 1.52
Lukas Tobias Wirth [Thu, 6 May 2021 15:05:49 +0000 (17:05 +0200)]
Support goto_type_definition for types
bors[bot] [Thu, 6 May 2021 14:48:16 +0000 (14:48 +0000)]
Merge #8744
8744: minor: simplify r=edwin0cheng a=edwin0cheng
cc #8742
bors r+
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
bors[bot] [Thu, 6 May 2021 14:41:14 +0000 (14:41 +0000)]
Merge #8743
8743: internal: explain why sentence-per-line r=matklad a=matklad
bors r+
π€
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 6 May 2021 14:40:36 +0000 (17:40 +0300)]
internal: explain why sentence-per-line
Edwin Cheng [Thu, 6 May 2021 14:39:51 +0000 (22:39 +0800)]
Simplify
bors[bot] [Thu, 6 May 2021 14:26:26 +0000 (14:26 +0000)]
Merge #8742
8742: fix: Do not overwrite comments and attrs in trait impl completion r=Veykril a=Jesse-Bakker
Fixes #8739
Co-authored-by: Jesse Bakker <github@jessebakker.com>
Jesse Bakker [Thu, 6 May 2021 13:56:48 +0000 (15:56 +0200)]
Fix: Do not overwrite comments and attrs in trait impl completion
Dawer [Thu, 6 May 2021 05:22:51 +0000 (10:22 +0500)]
Fix build
Dawer [Thu, 6 May 2021 05:07:06 +0000 (10:07 +0500)]
Hide implementation details of TokenText
Dawer [Thu, 6 May 2021 05:07:06 +0000 (10:07 +0500)]
Clean up
Dawer [Thu, 6 May 2021 05:07:06 +0000 (10:07 +0500)]
Borrow text from nodes of immutable syntax trees
Dawer [Thu, 6 May 2021 05:06:52 +0000 (10:06 +0500)]
Adapt to a new rowan borrowing node API.
Dawer [Thu, 6 May 2021 05:04:39 +0000 (10:04 +0500)]
Update to rowan 0.13.0-pre.5
bors[bot] [Wed, 5 May 2021 21:14:12 +0000 (21:14 +0000)]
Merge #8674
8674: fix for #8664: Emit folding ranges for multi-line where clauses r=matklad a=m5tfi
#8664
I added a test that assert folding multi-line where clauses while leaving single lined one. Please, let me know if the code needs further improvements.
Co-authored-by: m5tfi <72708423+m5tfi@users.noreply.github.com>
bors[bot] [Wed, 5 May 2021 21:03:50 +0000 (21:03 +0000)]
Merge #8736
8736: Update salsa r=jonas-schievink a=jonas-schievink
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Jonas Schievink [Wed, 5 May 2021 21:00:29 +0000 (23:00 +0200)]
Update salsa
bors[bot] [Wed, 5 May 2021 20:56:42 +0000 (20:56 +0000)]
Merge #8735
8735: simplify r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Tobias Wirth <lukastw97@gmail.com>
Lukas Tobias Wirth [Wed, 5 May 2021 20:55:12 +0000 (22:55 +0200)]
simplify
m5tfi [Wed, 5 May 2021 04:27:16 +0000 (06:27 +0200)]
remove unneeded `visited_where_clauses`
bors[bot] [Tue, 4 May 2021 20:36:26 +0000 (20:36 +0000)]
Merge #8733
8733: Add some cov marks for qualified_path completion r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Tobias Wirth <lukastw97@gmail.com>
Lukas Tobias Wirth [Tue, 4 May 2021 20:35:37 +0000 (22:35 +0200)]
Add some cov marks for qualified_path completion
bors[bot] [Tue, 4 May 2021 19:42:30 +0000 (19:42 +0000)]
Merge #8732
8732: internal: refactor expansion queries r=matklad a=matklad
bors r+
π€
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 4 May 2021 19:40:10 +0000 (22:40 +0300)]
Document expansion queries
Aleksey Kladov [Tue, 4 May 2021 19:20:04 +0000 (22:20 +0300)]
simplify macro expansion code
Using `Option` arguments such that you always pass `None` or `Some` at
the call site is a code smell.
Aleksey Kladov [Tue, 4 May 2021 19:03:16 +0000 (22:03 +0300)]
make illegal states unrepresentable
only declarative macros have def-site token map
Aleksey Kladov [Tue, 4 May 2021 18:49:00 +0000 (21:49 +0300)]
Cleanups
bors[bot] [Tue, 4 May 2021 19:05:19 +0000 (19:05 +0000)]
Merge #8731
8731: Complete enum variants through type aliases r=Veykril a=Veykril
Fixes #8730
bors r+
Co-authored-by: Lukas Tobias Wirth <lukastw97@gmail.com>
Lukas Tobias Wirth [Tue, 4 May 2021 19:03:35 +0000 (21:03 +0200)]
Complete enum variants through type aliases
bors[bot] [Tue, 4 May 2021 17:37:09 +0000 (17:37 +0000)]
Merge #8727
8727: minor: use standard import style r=matklad a=matklad
bors r+
π€
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 4 May 2021 17:36:48 +0000 (20:36 +0300)]
minor: use standard import style
bors[bot] [Tue, 4 May 2021 17:29:55 +0000 (17:29 +0000)]
Merge #8726
8726: internal: reduce visibility r=matklad a=matklad
bors r+
π€
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 4 May 2021 17:29:30 +0000 (20:29 +0300)]
internal: reduce visibility
bors[bot] [Tue, 4 May 2021 15:31:10 +0000 (15:31 +0000)]
Merge #8725
8725: internal: env var to toggle slow benches r=matklad a=matklad
bors r+
π€
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 4 May 2021 15:21:36 +0000 (18:21 +0300)]
internal: env var to toggle slow benches
bors[bot] [Tue, 4 May 2021 15:20:38 +0000 (15:20 +0000)]
Merge #8724
8724: minor: unconfuse myself about macro def vs macro rules r=matklad a=matklad
bors r+
π€
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 4 May 2021 15:20:10 +0000 (18:20 +0300)]
minor: unconfuse myself about macro def vs macro rules
bors[bot] [Tue, 4 May 2021 12:14:56 +0000 (12:14 +0000)]
Merge #8720
8720: internal: add integrated completion benchmark r=matklad a=matklad
bors r+
π€
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 4 May 2021 11:02:23 +0000 (14:02 +0300)]
internal: add integrated completion benchmark
bors[bot] [Tue, 4 May 2021 12:00:30 +0000 (12:00 +0000)]
Merge #8719
8719: Fix block comment intra doc link injection ranges r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Tobias Wirth <lukastw97@gmail.com>
Lukas Tobias Wirth [Tue, 4 May 2021 11:51:57 +0000 (13:51 +0200)]
Fix block comment intra doc link injection ranges
bors[bot] [Tue, 4 May 2021 11:51:09 +0000 (11:51 +0000)]
Merge #8711
8711: Only resolve selected assist r=matklad a=SomeoneToIgnore
Part of https://github.com/rust-analyzer/rust-analyzer/issues/8700
Now resolves only the assist that was selected out of the list, while before the whole assist list was resolved despite a single popup selection.
Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
Aleksey Kladov [Tue, 4 May 2021 07:23:47 +0000 (10:23 +0300)]
More searchable name
bors[bot] [Tue, 4 May 2021 07:07:06 +0000 (07:07 +0000)]
Merge #8714
8714: internal: remove one more usage of the rewriter r=matklad a=matklad
bors r+
π€
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Mon, 3 May 2021 19:33:27 +0000 (22:33 +0300)]
internal: remove one more usage of the rewriter
bors[bot] [Tue, 4 May 2021 03:41:48 +0000 (03:41 +0000)]
Merge #8716
8716: Replace `memmap` with `memmap2` in `proc_macro_api` r=edwin0cheng a=memoryruins
#7522 did the same for `proc_macro_srv` before this usage of `memmap` was introduced to `proc_macro_api` in #6822 .
Something like [`cargo-deny`](https://github.com/EmbarkStudios/cargo-deny-action) could help prevent specific crates (and versions, licenses, etc) from being introduced into the crate tree, but that's unrelated to this pull request.
Co-authored-by: memoryruins <memoryruinsmusic@gmail.com>
memoryruins [Tue, 4 May 2021 00:20:47 +0000 (20:20 -0400)]
Replace `memmap` to `memmap2` in `proc_macro_api`
Kirill Bulatov [Mon, 3 May 2021 19:58:53 +0000 (22:58 +0300)]
Code review fixes
bors[bot] [Mon, 3 May 2021 19:36:40 +0000 (19:36 +0000)]
Merge #8715
8715: Make CompletionContext expected_type smarter r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Tobias Wirth <lukastw97@gmail.com>
Lukas Tobias Wirth [Mon, 3 May 2021 19:34:34 +0000 (21:34 +0200)]
Make CompletionContext expected_type smarter
bors[bot] [Mon, 3 May 2021 16:57:51 +0000 (16:57 +0000)]
Merge #8482
8482: Mention how to customize unsafe operation styles r=matklad a=danielzfranklin
I was confused about how to do this, so I filed #8474. I apologize for initially filing this incorrectly and spamming people.
Co-authored-by: Daniel Franklin <daniel@danielzfranklin.org>
Daniel Franklin [Mon, 3 May 2021 16:54:09 +0000 (17:54 +0100)]
Merge with semantic style section
bors[bot] [Mon, 3 May 2021 16:36:59 +0000 (16:36 +0000)]
Merge #8712
8712: Map nodes to their mutable counterpart before mutating in reorder_impl r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Tobias Wirth <lukastw97@gmail.com>
Lukas Tobias Wirth [Mon, 3 May 2021 16:22:18 +0000 (18:22 +0200)]
Don't mutate the tree while traversing in reorder_impl
Kirill Bulatov [Mon, 3 May 2021 16:35:44 +0000 (19:35 +0300)]
Index retrieval fix
Kirill Bulatov [Mon, 3 May 2021 16:00:24 +0000 (19:00 +0300)]
Touch lsp-extensions.md
Kirill Bulatov [Mon, 3 May 2021 15:44:58 +0000 (18:44 +0300)]
Small fixes
Kirill Bulatov [Mon, 3 May 2021 15:40:04 +0000 (18:40 +0300)]
Tests added
Kirill Bulatov [Mon, 3 May 2021 15:18:45 +0000 (18:18 +0300)]
Less panics in the assist resolution
Kirill Bulatov [Mon, 3 May 2021 15:16:35 +0000 (18:16 +0300)]
Add docs and use better naming
Kirill Bulatov [Mon, 3 May 2021 15:03:28 +0000 (18:03 +0300)]
Resolve single assist only
Kirill Bulatov [Mon, 3 May 2021 14:08:09 +0000 (17:08 +0300)]
Add a way to resolve certain assists
bors[bot] [Mon, 3 May 2021 14:00:07 +0000 (14:00 +0000)]
Merge #8710
8710: feat: build releases with lto=true r=matklad a=matklad
bors r+
π€
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Mon, 3 May 2021 13:55:30 +0000 (16:55 +0300)]
feat: build releases with lto=true
closes #8050
bors[bot] [Mon, 3 May 2021 13:37:12 +0000 (13:37 +0000)]
Merge #8427
8427: Move CI to rust-cache Action r=matklad a=Swatinem
This is humbling. I actually took inspiration from RAs pre-cache xtask when developing my action ;-)
Closes #7731
Co-authored-by: Arpad Borsos <swatinem@swatinem.de>
bors[bot] [Sun, 2 May 2021 19:18:18 +0000 (19:18 +0000)]
Merge #8709
8709: cargo update r=kjeremy a=kjeremy
Co-authored-by: Jeremy Kolb <kjeremy@gmail.com>
Jeremy Kolb [Sun, 2 May 2021 19:17:04 +0000 (15:17 -0400)]
cargo update
bors[bot] [Sun, 2 May 2021 18:45:22 +0000 (18:45 +0000)]
Merge #8708
8708: fix: don't duplicate Progerss::Finised for cache priming r=matklad a=matklad
bors r+
π€
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>