]>
git.lizzy.rs Git - rust.git/log
Philipp Hansch [Thu, 30 Jan 2020 07:33:48 +0000 (08:33 +0100)]
Deprecate util/dev in favor of cargo alias
If you've been using `./util/dev` before, this now becomes `cargo dev`.
The key part of this change is found in `.cargo/config`.
This means one less shell script and a bit more cross-platform support
for contributors.
bors [Wed, 29 Jan 2020 16:29:05 +0000 (16:29 +0000)]
Auto merge of #5058 - xiongmao86:issue4903, r=flip1995
Closes Issue4903
fixes #4903.
Check list:
- [x] Followed [lint naming conventions][lint_naming]
- [x] Added passing UI tests (including committed `.stderr` file)
- [x] `cargo test` passes locally
- [x] Executed `./util/dev update_lints`
- [x] Added lint documentation
- [x] Run `./util/dev fmt`
[lint_naming]: https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints
---
changelog: implement lint that warn about single component path imports(`use ident;`).
xiongmao86 [Wed, 29 Jan 2020 16:23:47 +0000 (00:23 +0800)]
Reformat code.
xiongmao86 [Wed, 29 Jan 2020 16:22:42 +0000 (00:22 +0800)]
Add test and update reference.
xiongmao86 [Wed, 29 Jan 2020 16:21:29 +0000 (00:21 +0800)]
Declare lint and implement lint logic.
bors [Wed, 29 Jan 2020 08:31:51 +0000 (08:31 +0000)]
Auto merge of #5104 - JohnTitor:rustup-0129, r=Manishearth
Rustup to rust-lang/rust#68512
changelog: none
Yuki Okushi [Wed, 29 Jan 2020 08:15:56 +0000 (17:15 +0900)]
Rustup to rust-lang/rust#68512
bors [Mon, 27 Jan 2020 11:09:45 +0000 (11:09 +0000)]
Auto merge of #5099 - JohnTitor:split-up-non-copy-const, r=flip1995
Split up `non_copy_const` ui test
Part of #2038
Maybe there is a better way to avoid duplications of constants.
changelog: none
bors [Mon, 27 Jan 2020 10:37:17 +0000 (10:37 +0000)]
Auto merge of #5098 - JohnTitor:rename-span-lints, r=flip1995
Rename `span_{help, note}_and_lint` to `span_lint_and_*`
`span_*_and_lint` and `span_lint_and_*` make us confused. The order should be the same.
[context](https://github.com/rust-lang/rust-clippy/pull/5084#issuecomment-
578411309 )
changelog: none
Yuki Okushi [Mon, 27 Jan 2020 03:14:11 +0000 (12:14 +0900)]
Split up `non_copy_const` ui test
Yuki Okushi [Mon, 27 Jan 2020 02:26:42 +0000 (11:26 +0900)]
Rename `span_note_and_lint` to `span_lint_and_note`
Yuki Okushi [Mon, 27 Jan 2020 01:56:22 +0000 (10:56 +0900)]
Rename `span_help_and_lint` to `span_lint_and_help`
bors [Sun, 26 Jan 2020 15:28:39 +0000 (15:28 +0000)]
Auto merge of #5084 - JohnTitor:clean-up-span-lint, r=flip1995
Clean up `span_lint` in `methods/mod.rs`
Uses `span_help_and_lint` instead of `span_lint` and `span_lint_and_sugg` instead of `span_lint_and_then`.
changelog: none
bors [Sun, 26 Jan 2020 10:50:47 +0000 (10:50 +0000)]
Auto merge of #5097 - phansch:remove_fixme, r=llogiq
Resolve FIXME: String::new is now a const fn
`const_string_new` is stable since Rust 1.39
changelog: none
Philipp Hansch [Sun, 26 Jan 2020 10:03:53 +0000 (11:03 +0100)]
Resolve FIXME: String::new is now a const fn
`const_string_new` is stable since Rust 1.39
bors [Sun, 26 Jan 2020 07:42:55 +0000 (07:42 +0000)]
Auto merge of #5096 - eddyb:mac-name, r=oli-obk
Don't use ExpnKind::descr to get the name of a bang macro.
This is the same change as the first commit in rust-lang/rust#68407, but applied to clippy.
The new code should work both before and after the changes in rust-lang/rust#68407.
changelog: none
Eduard-Mihai Burtescu [Sun, 26 Jan 2020 01:12:44 +0000 (03:12 +0200)]
Don't use ExpnKind::descr to get the name of a bang macro.
Yuki Okushi [Sat, 25 Jan 2020 22:01:16 +0000 (07:01 +0900)]
Apply review comments
bors [Sat, 25 Jan 2020 17:47:54 +0000 (17:47 +0000)]
Auto merge of #5083 - Areredify:issue-4399, r=flip1995
dont fire `possible_missing_comma` if intendation is present
Closes #4399
changelog: dont fire `possible_missing_comma` if intendation is present
I suspect there is already a utils function for indentation (but searching indent didn't yield a function for that), and my solution is certainly not universal, but it's probably the best we can do.
Mikhail Babenko [Thu, 23 Jan 2020 21:27:01 +0000 (00:27 +0300)]
dont fire possible_missing_comma if intendation is present
bors [Sat, 25 Jan 2020 16:11:43 +0000 (16:11 +0000)]
Auto merge of #5081 - Areredify:vec_box_threshold, r=flip1995
add size parameter for `vec_box` lint
changelog: add size threshold for the `vec_box` lint, currently 4096 bytes (one page) (subject to change). Closes #3547.
diff is a little bit confusing due to some refactoring (moving free functions to lint struct functions), relevant portion is [this](https://github.com/rust-lang/rust-clippy/compare/master...Areredify:vec_box_threshold?expand=1#diff-1096120ca9143af89dcc9175ea92b54aR294-R298). In hindsight should've been different commits, but oh well.
Mikhail Babenko [Thu, 23 Jan 2020 14:52:41 +0000 (17:52 +0300)]
add size parameter for lint
bors [Sat, 25 Jan 2020 07:28:31 +0000 (07:28 +0000)]
Auto merge of #5090 - JohnTitor:split-up-match-same-arms, r=phansch
Split up `match_same_arms` ui test
Part of #2038
changelog: none
Yuki Okushi [Sat, 25 Jan 2020 05:25:45 +0000 (14:25 +0900)]
Split up `match_same_arms` ui test
bors [Fri, 24 Jan 2020 22:30:07 +0000 (22:30 +0000)]
Auto merge of #5087 - Areredify:issue-4905, r=phansch
improve `empty_enum` documentation
closes #4905
changelog: improve `empty_enum` help message and documentation.
bors [Fri, 24 Jan 2020 21:42:46 +0000 (21:42 +0000)]
Auto merge of #5086 - Areredify:issue-3746, r=phansch
don't fire `empty_loop` in `no_std` crates
closes #3746.
changelog: move no_std detection to utils, don't fire empty_loop in no_std crates
bors [Fri, 24 Jan 2020 21:10:10 +0000 (21:10 +0000)]
Auto merge of #5085 - JohnTitor:split-up-test, r=phansch
Split up `needless_range_loop` ui test
Part of #2038
changelog: none
Mikhail Babenko [Fri, 24 Jan 2020 10:50:03 +0000 (13:50 +0300)]
don't fire empty_loop in no_std crates
Mikhail Babenko [Fri, 24 Jan 2020 11:37:16 +0000 (14:37 +0300)]
improve empty_enum documentation
Yuki Okushi [Fri, 24 Jan 2020 08:21:50 +0000 (17:21 +0900)]
Split up `needless_range_loop` ui test
Yuki Okushi [Fri, 24 Jan 2020 08:04:46 +0000 (17:04 +0900)]
Update stderrs
Yuki Okushi [Fri, 24 Jan 2020 08:04:37 +0000 (17:04 +0900)]
Clean up `methods/mod.rs`
bors [Fri, 24 Jan 2020 06:44:09 +0000 (06:44 +0000)]
Auto merge of #5027 - sinkuu:vectored_io, r=phansch
Lint vectored IO in unused_io_amount lint
`read_vectored` & `write_vectored` require handling returned value likewise non-vectored methods. https://github.com/rust-lang/rust/issues/68041
---
changelog: lint vectored IO in `unused_io_amount` lint
bors [Thu, 23 Jan 2020 18:29:28 +0000 (18:29 +0000)]
Auto merge of #5082 - Areredify:issue-4980, r=flip1995
disable let_underscore_must_use in external macros
changelog: disable let_underscore_must_use in external macros
Closes #4980
Mikhail Babenko [Thu, 23 Jan 2020 15:20:50 +0000 (18:20 +0300)]
disable let_underscore_must_use in external macros
bors [Thu, 23 Jan 2020 16:56:48 +0000 (16:56 +0000)]
Auto merge of #4945 - Areredify:as_deref, r=flip1995
add `option_as_ref_deref` lint
changelog: add a new lint that lints `option.as_ref().map(Deref::deref)` (and similar calls), which could be expressed more succinctly as `option.as_deref[_mut]()`. Closes #4918.
Areredify [Mon, 23 Dec 2019 04:48:15 +0000 (07:48 +0300)]
add `option_as_ref_deref` lint
bors [Wed, 22 Jan 2020 11:36:04 +0000 (11:36 +0000)]
Auto merge of #5079 - JohnTitor:fix-eq-op, r=flip1995
Ignore macros with `!` operators in `eq_op`
`SpanlessEq::eq_expr` doesn't ignore macros with `!` operators and I'm not sure we should ignore there, so I ignore in `eq_op` (and `op_ref`).
Fixes #5077
changelog: Fix false positive in `eq_op`
Yuki Okushi [Wed, 22 Jan 2020 07:48:00 +0000 (16:48 +0900)]
Ignore macros with `!` operators in `eq_op`
bors [Tue, 21 Jan 2020 22:35:15 +0000 (22:35 +0000)]
Auto merge of #5075 - JohnTitor:rustup-0122, r=flip1995
Rustup to rust-lang/rust#68140
changelog: none
Yuki Okushi [Tue, 21 Jan 2020 22:26:07 +0000 (07:26 +0900)]
Rustup to rust-lang/rust#68140
bors [Tue, 21 Jan 2020 06:22:05 +0000 (06:22 +0000)]
Auto merge of #5068 - JohnTitor:split-up-transmute, r=phansch
Split up `transmute` ui test
Part of #2038
changelog: none
bors [Tue, 21 Jan 2020 05:53:46 +0000 (05:53 +0000)]
Auto merge of #5028 - krishna-veerareddy:issue-5026-mem-ordering-fences, r=phansch
Detect usage of invalid atomic ordering in memory fences
Detect usage of `core::sync::atomic::{fence, compiler_fence}` with `Ordering::Relaxed` and suggest valid alternatives.
changelog: Extend `invalid_atomic_ordering` to lint memory fences
Fixes #5026
Yuki Okushi [Mon, 20 Jan 2020 21:43:01 +0000 (06:43 +0900)]
Decrease line length limit for stderr files
bors [Mon, 20 Jan 2020 17:28:38 +0000 (17:28 +0000)]
Auto merge of #5067 - JohnTitor:lint-skip-while-next, r=flip1995
Add `skip_while_next` lint
Fixes #4036
changelog: Add `skip_while_next` lint
bors [Mon, 20 Jan 2020 12:12:03 +0000 (12:12 +0000)]
Auto merge of #5070 - JohnTitor:suspicious-map-doc, r=flip1995
Improve `suspicious_map`documentation
Fixes #4793
changelog: none
Yuki Okushi [Mon, 20 Jan 2020 12:07:31 +0000 (21:07 +0900)]
Apply review comment
bors [Mon, 20 Jan 2020 11:42:08 +0000 (11:42 +0000)]
Auto merge of #5069 - JohnTitor:tweak-wording, r=flip1995
Tweak wording in `assertions_on_constants`
Displays actual macro names
changelog: none
Yuki Okushi [Mon, 20 Jan 2020 06:05:40 +0000 (15:05 +0900)]
Improve `suspicious_map`documentation
Yuki Okushi [Mon, 20 Jan 2020 02:52:58 +0000 (11:52 +0900)]
Tweak wording in `assertions_on_constants`
Yuki Okushi [Mon, 20 Jan 2020 02:16:50 +0000 (11:16 +0900)]
Split up `transmute` ui test
Yuki Okushi [Mon, 20 Jan 2020 01:55:23 +0000 (10:55 +0900)]
Remove trailing whitespaces
Yuki Okushi [Mon, 20 Jan 2020 01:54:54 +0000 (10:54 +0900)]
Add `skip_while_next` lint
bors [Sun, 19 Jan 2020 14:41:28 +0000 (14:41 +0000)]
Auto merge of #5056 - rust-lang:dissasociate-mut-key, r=flip1995
Avoid mut_key on types of unknown layout
This fixes #5020 by requiring a known layout for the key type before linting. Edit: This fixes #5043, too.
changelog: none
Andre Bogus [Thu, 16 Jan 2020 23:18:37 +0000 (00:18 +0100)]
Avoid mut_key on types of unknown layout
bors [Sun, 19 Jan 2020 12:27:35 +0000 (12:27 +0000)]
Auto merge of #5032 - JohnTitor:add-sugg-some-result, r=flip1995
Add suggestions for `if_let_some_result`
Fixes #4991
This approach may be fragile though...
changelog: Add suggestions for `if_let_some_result`
Yuki Okushi [Sun, 19 Jan 2020 12:14:47 +0000 (21:14 +0900)]
Treat more strange pattern
bors [Sun, 19 Jan 2020 07:49:48 +0000 (07:49 +0000)]
Auto merge of #5066 - JohnTitor:split-up-1447, r=llogiq
Split up `if_same_then_else` ui test
Part of #2038
changelog: none
Yuki Okushi [Sun, 19 Jan 2020 06:04:41 +0000 (15:04 +0900)]
Split up `if_same_then_else` ui test
Yuki Okushi [Sun, 19 Jan 2020 01:00:34 +0000 (10:00 +0900)]
Apply review comments
Yuki Okushi [Fri, 10 Jan 2020 21:02:02 +0000 (06:02 +0900)]
Run `update_lints`
Yuki Okushi [Fri, 10 Jan 2020 19:34:01 +0000 (04:34 +0900)]
Reduce span range
Yuki Okushi [Fri, 10 Jan 2020 18:29:55 +0000 (03:29 +0900)]
Rename `ok_if_let` to `if_let_some_result`
Yuki Okushi [Fri, 10 Jan 2020 18:05:10 +0000 (03:05 +0900)]
Apply review comments
Yuki Okushi [Thu, 9 Jan 2020 23:34:13 +0000 (08:34 +0900)]
Add suggestion in `if_let_some_result`
bors [Sat, 18 Jan 2020 22:44:46 +0000 (22:44 +0000)]
Auto merge of #5065 - matthiaskrgr:rustup_28, r=matthiaskrgr
rustup https://github.com/rust-lang/rust/pull/67712
slice_patterns have been stabilized.
changelog: none
Matthias Krüger [Sat, 18 Jan 2020 22:40:35 +0000 (23:40 +0100)]
rustup https://github.com/rust-lang/rust/pull/67712
slice_patterns have been stabilized.
bors [Sat, 18 Jan 2020 19:51:46 +0000 (19:51 +0000)]
Auto merge of #5046 - JohnTitor:order-nonminimal-bool, r=flip1995
Keep the ordering in `nonminimal_bool` lint
I believe it shouldn't cause any regression but feel free to let me know if you have a doubtful example.
Also, splits up `booleans` ui test.
Fixes #5045
changelog: none
bors [Sat, 18 Jan 2020 16:58:30 +0000 (16:58 +0000)]
Auto merge of #5063 - JohnTitor:allow-correctly, r=flip1995
Allow `unused_self` lint at the function level
Another approach of #5062.
Fixes #5053
changelog: Allow `unused_self` lint at the function level
Yuki Okushi [Sat, 18 Jan 2020 12:05:42 +0000 (21:05 +0900)]
Allow `unused_self` lint at the function level
bors [Sat, 18 Jan 2020 10:23:46 +0000 (10:23 +0000)]
Auto merge of #5057 - rust-lang:pedantic_range_plus_one, r=flip1995
Downgrade range_plus_one to pedantic
This fixes #2217
changelog: Downgrade [`range_plus_one`] to `pedantic`
Andre Bogus [Fri, 17 Jan 2020 09:15:14 +0000 (10:15 +0100)]
Downgrade range_plus_one to pedantic
bors [Sat, 18 Jan 2020 08:10:56 +0000 (08:10 +0000)]
Auto merge of #5059 - JohnTitor:rustup-0118, r=llogiq
Rustup to rust-lang/rust#68204
changelog: none
Yuki Okushi [Sat, 18 Jan 2020 05:14:36 +0000 (14:14 +0900)]
Rustup to rust-lang/rust#68204
bors [Thu, 16 Jan 2020 19:43:22 +0000 (19:43 +0000)]
Auto merge of #5055 - krishna-veerareddy:fix-new-lint-generator-import, r=llogiq
Fix new lint generator import
Fix `rustc_lint` import path and add lifetimes to `LateLintPass` in `new_lint` command.
changelog: none
Krishna Sai Veera Reddy [Thu, 16 Jan 2020 18:05:29 +0000 (10:05 -0800)]
Add lifetimes to `LateLintPass`
Krishna Sai Veera Reddy [Thu, 16 Jan 2020 17:44:45 +0000 (09:44 -0800)]
Fix rustc lint import paths generated by `new_lint`
bors [Thu, 16 Jan 2020 16:24:41 +0000 (16:24 +0000)]
Auto merge of #4994 - bradsherman:new_lint_gen, r=flip1995
Autogenerate new lints
Add option in clippy_dev to automatically generate boilerplate code for adding new lints
example:
`./util/dev new_lint --name=iter_nth_zero --type=late`
Fixes #4942
changelog: none
bors [Thu, 16 Jan 2020 15:04:45 +0000 (15:04 +0000)]
Auto merge of #5054 - flip1995:rustup, r=flip1995
Update custom_ice_message.stderr
changelog: none
flip1995 [Thu, 16 Jan 2020 15:01:31 +0000 (16:01 +0100)]
Update custom_ice_message.stderr
Brad Sherman [Sat, 11 Jan 2020 20:08:27 +0000 (14:08 -0600)]
Add lint for default lint description
- Lint for any new lints that have the default lint description
from the automation
Brad Sherman [Sat, 11 Jan 2020 19:26:25 +0000 (13:26 -0600)]
Update documentation for adding new lints
- Add instructions for adding new lints with
the new automation
Brad Sherman [Wed, 1 Jan 2020 01:07:39 +0000 (18:07 -0700)]
Generate new lints easily
- Add option in clippy_dev to automatically generate boilerplate
code for adding new lints
bors [Wed, 15 Jan 2020 21:17:21 +0000 (21:17 +0000)]
Auto merge of #5034 - ThibsG:MatchWildErrArmImprove5024, r=flip1995
Match wild err arm improvements
This lint should trigger on other identifiers which have `_` prefix (such as `_e`) and only if they are unused in the panic block.
_Note_: the `is_unused` function is greatly inspired from `pat_is_wild` function in [loops lints](https://github.com/rust-lang/rust-clippy/blob/
43ac9416d935942d6c7d2b2e0c876c551652c4ec /clippy_lints/src/loops.rs#L1689).
I've been considering doing some refactoring, maybe in utils. Maybe this PR or a new one. What do you think ?
fixes #5024
changelog: none
bors [Wed, 15 Jan 2020 07:35:30 +0000 (07:35 +0000)]
Auto merge of #5048 - justjavac:patch-1, r=llogiq
update license year to 2020
Happy new year 2020
changelog: none
迷渡 [Wed, 15 Jan 2020 07:00:54 +0000 (15:00 +0800)]
update license year to 2020
bors [Tue, 14 Jan 2020 21:21:58 +0000 (21:21 +0000)]
Auto merge of #5023 - rust-lang:doc-main, r=phansch
Omit doc safety/errors header checking for main
This omits checking `main` methods, which are not usually documented in the way the others are.
changelog: none
Andre Bogus [Tue, 14 Jan 2020 17:20:56 +0000 (18:20 +0100)]
Omit doc safety/errors header checking for main
Yuki Okushi [Mon, 13 Jan 2020 22:41:11 +0000 (07:41 +0900)]
Split up `booleans` ui test
bors [Mon, 13 Jan 2020 22:09:39 +0000 (22:09 +0000)]
Auto merge of #4543 - xiongmao86:issue4503, r=flip1995
Fix issue4503
Fixes #4503.
changelog: Add a lint checking user are using FileType.is_file() method and suggest using !FileType.is_dir().
- [x] Followed [lint naming conventions][lint_naming]
- [x] Added passing UI tests (including committed `.stderr` file)
- [x] `cargo test` passes locally
- [x] Executed `./util/dev update_lints`
- [x] Added lint documentation
- [x] Run `./util/dev fmt`
Yuki Okushi [Mon, 13 Jan 2020 22:08:45 +0000 (07:08 +0900)]
Fix the ordering on `nonminimal_bool`
bors [Mon, 13 Jan 2020 20:21:04 +0000 (20:21 +0000)]
Auto merge of #5033 - JohnTitor:split-use-self, r=flip1995
Split up `use_self` ui test
Part of #2038
changelog: none
ThibsG [Fri, 10 Jan 2020 16:14:17 +0000 (17:14 +0100)]
Extract visitor to utils
ThibsG [Fri, 10 Jan 2020 14:12:21 +0000 (15:12 +0100)]
Change note message
ThibsG [Fri, 10 Jan 2020 14:09:37 +0000 (15:09 +0100)]
Fix formatting
ThibsG [Fri, 10 Jan 2020 09:56:09 +0000 (10:56 +0100)]
Better binding name on Err for note
ThibsG [Fri, 10 Jan 2020 09:42:21 +0000 (10:42 +0100)]
Match underscore-prefixed variable also
bors [Mon, 13 Jan 2020 13:17:27 +0000 (13:17 +0000)]
Auto merge of #5042 - JohnTitor:rustup-0112, r=phansch
Rustup to rust-lang/rust#68045
This is blocked because `rustc_lint::context` is not pub module and `CheckLintNameResult` is not marked as `pub use`.
changelog: none
Yuki Okushi [Sun, 12 Jan 2020 06:08:41 +0000 (15:08 +0900)]
Rustup to rust-lang/rust#68045
xiongmao86 [Sat, 11 Jan 2020 03:57:49 +0000 (11:57 +0800)]
Pull master, rebase, and update_lints again.