]>
git.lizzy.rs Git - rust.git/log
bors[bot] [Sat, 24 Apr 2021 10:37:42 +0000 (10:37 +0000)]
Merge #8643
8643: fix: correct version string to contain hash, build date and channel r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sat, 24 Apr 2021 10:36:45 +0000 (13:36 +0300)]
fix: correct version string to contain hash, build date and channel
Aleksey Kladov [Sat, 24 Apr 2021 07:31:58 +0000 (10:31 +0300)]
minor
bors[bot] [Sat, 24 Apr 2021 06:09:21 +0000 (06:09 +0000)]
Merge #8641
8641: minor r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sat, 24 Apr 2021 06:08:56 +0000 (09:08 +0300)]
minor
bors[bot] [Fri, 23 Apr 2021 19:09:37 +0000 (19:09 +0000)]
Merge #8639
8639: fix: 'configuration.property' error in VS Code r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 23 Apr 2021 19:08:09 +0000 (22:08 +0300)]
fix: 'configuration.property' error in VS Code
closes #7789
bors[bot] [Fri, 23 Apr 2021 16:49:08 +0000 (16:49 +0000)]
Merge #8591 #8638
8591: Remove SyntaxRewriter usage in insert_use in favor of mutable syntax trees r=matklad a=Veykril
Unfortunately changing `insert_use` to not use `SyntaxRewriter` creates a lot of changes since so much relies on that. But on the other hand this should be the biggest usage of `SyntaxRewriter` I believe.
8638: Remove SyntaxRewriter::from_fn r=Veykril a=Veykril
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Fri, 23 Apr 2021 16:36:43 +0000 (18:36 +0200)]
Remove SyntaxRewriter::from_fn
bors[bot] [Fri, 23 Apr 2021 15:28:55 +0000 (15:28 +0000)]
Merge #8637
8637: Tag `yield` and `await` as ControlFlow in semantic highlighting r=Veykril a=Veykril
and shuffle some code around
Closes #8634
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Fri, 23 Apr 2021 15:19:46 +0000 (17:19 +0200)]
Simplify highlight token match guards
Lukas Wirth [Fri, 23 Apr 2021 14:57:03 +0000 (16:57 +0200)]
Sort HlMod variants and ALL const
Lukas Wirth [Fri, 23 Apr 2021 14:43:48 +0000 (16:43 +0200)]
Tag `yield` and `await` as ControlFlow in semantic highlighting
bors[bot] [Fri, 23 Apr 2021 13:37:48 +0000 (13:37 +0000)]
Merge #8317
8317: Convert tuple struct to named struct assist r=Veykril a=unexge
Closes https://github.com/rust-analyzer/rust-analyzer/issues/8192
Co-authored-by: unexge <unexge@gmail.com>
unexge [Fri, 23 Apr 2021 13:18:10 +0000 (16:18 +0300)]
Add missing test case for "Convert to named struct" assist
unexge [Fri, 23 Apr 2021 10:08:07 +0000 (13:08 +0300)]
Stop iterating reference after made an edit in "Convert to named struct" assist
bors[bot] [Thu, 22 Apr 2021 18:48:53 +0000 (18:48 +0000)]
Merge #8628
8628: minor: Add one more profiling span to add_dep r=lnicola a=lnicola
CC #8623
bors r+
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Thu, 22 Apr 2021 18:48:17 +0000 (21:48 +0300)]
Add one more profiling span to add_dep
bors[bot] [Thu, 22 Apr 2021 18:26:09 +0000 (18:26 +0000)]
Merge #8627
8627: Add profiling spans under cargo_to_crate_graph r=lnicola a=lnicola
bors r+
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Thu, 22 Apr 2021 18:25:29 +0000 (21:25 +0300)]
Add profiling spans under cargo_to_crate_graph
bors[bot] [Thu, 22 Apr 2021 17:35:41 +0000 (17:35 +0000)]
Merge #8605
8605: internal: Automatically categorize the changelog entries r=matklad a=lnicola
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
bors[bot] [Thu, 22 Apr 2021 15:22:43 +0000 (15:22 +0000)]
Merge #8620
8620: Remove unnecessary braces for extracted block expression r=Veykril a=brandondong
This change addresses the first bullet point of https://github.com/rust-analyzer/rust-analyzer/issues/7839.
Specifically, when extracting block expressions, remove the unneeded extra braces inside the generated function.
Co-authored-by: Brandon <brandondong604@hotmail.com>
unexge [Thu, 22 Apr 2021 08:33:56 +0000 (11:33 +0300)]
Move reference editing logic into own function to make error handling more ease in "Convert to named struct" assist
bors[bot] [Thu, 22 Apr 2021 08:29:01 +0000 (08:29 +0000)]
Merge #8621
8621: feat: make sure nightly regressions don't break users r=lnicola a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 22 Apr 2021 08:15:20 +0000 (11:15 +0300)]
feat: make sure nightly regressions don't break users
Brandon [Wed, 21 Apr 2021 06:41:17 +0000 (23:41 -0700)]
Remove unnecessary braces for extracted block expression
bors[bot] [Wed, 21 Apr 2021 23:54:47 +0000 (23:54 +0000)]
Merge #8595
8595: Diagnostic paths support specifying `remapPrefix` r=rickvanprim a=rickvanprim
Currently VSCode Problem Matchers will resolve a path like `//foo_crate/src/main.rs` if `${workspaceFolder}/foo_crate/src/main.rs` exists. Presumably their behavior is functionally a string concatenation that would produce `${workspaceFolder///foo_crate/src/main.rs` and repeated path separators get ignored.
This PR attempts to mimic this behavior by stripping any `Component::RootDir` from `file_name` before joining it to `workspace_root`, and then checking if the file exists. If it does, this path is used, and if not, the behavior falls through to the existing Rust path join behavior.
Co-authored-by: James Leitch <rickvanprim@gmail.com>
Lukas Wirth [Wed, 21 Apr 2021 22:54:31 +0000 (00:54 +0200)]
Don't filter equal nodes in reorder assists
James Leitch [Wed, 21 Apr 2021 22:09:37 +0000 (15:09 -0700)]
Code review feedback.
James Leitch [Wed, 21 Apr 2021 03:03:35 +0000 (20:03 -0700)]
Diagnostic Remap Path Prefixes added.
James Leitch [Tue, 20 Apr 2021 03:18:54 +0000 (20:18 -0700)]
Diagnostic paths attempt to use VSCode's path join behavior before defaulting to Rust's path join behavior.
bors[bot] [Wed, 21 Apr 2021 21:56:54 +0000 (21:56 +0000)]
Merge #8570
8570: Flycheck tries to parse both Cargo and Rustc messages. r=rickvanprim a=rickvanprim
This change allows non-Cargo build systems to be used for Flycheck provided they call `rustc` with `--error-format=json` and emit those JSON messages to `stdout`.
Co-authored-by: James Leitch <rickvanprim@gmail.com>
bors[bot] [Wed, 21 Apr 2021 16:20:56 +0000 (16:20 +0000)]
Merge #8616
8616: minor: Bump deps r=lnicola a=lnicola
bors r+
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Wed, 21 Apr 2021 16:20:18 +0000 (19:20 +0300)]
Bump other deps
Laurențiu Nicola [Wed, 21 Apr 2021 16:20:01 +0000 (19:20 +0300)]
Bump chalk
Laurențiu Nicola [Wed, 21 Apr 2021 16:19:27 +0000 (19:19 +0300)]
Bump rustc_lexer
bors[bot] [Wed, 21 Apr 2021 16:10:55 +0000 (16:10 +0000)]
Merge #8615
8615: skip: Remove `ItemTree::all_inner_items` r=jonas-schievink a=jonas-schievink
It's unused.
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Jonas Schievink [Wed, 21 Apr 2021 16:10:25 +0000 (18:10 +0200)]
Remove `ItemTree::all_inner_items`
bors[bot] [Wed, 21 Apr 2021 15:58:57 +0000 (15:58 +0000)]
Merge #8613
8613: skip: Add failing local items test r=jonas-schievink a=jonas-schievink
This is currently broken due to the way ItemTree stores inner items. This test serves as a reminder until this gets fixed.
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Jonas Schievink [Wed, 21 Apr 2021 15:57:45 +0000 (17:57 +0200)]
Add failing local items test
bors[bot] [Wed, 21 Apr 2021 14:48:03 +0000 (14:48 +0000)]
Merge #8611
8611: Add support for fill match arms of boolean values r=flodiebold a=komonad
- Add support for boolean inside tuple
closes #8593
Co-authored-by: Comonad <comonad@foxmail.com>
unexge [Wed, 21 Apr 2021 13:42:47 +0000 (16:42 +0300)]
Use multiple loops instead of `Iterator::chain` in `FindUsages`
unexge [Wed, 21 Apr 2021 13:20:08 +0000 (16:20 +0300)]
Add multi file test for "Convert to named struct" assist
unexge [Wed, 21 Apr 2021 13:01:13 +0000 (16:01 +0300)]
Remove `unwrap`s in "Convert to named struct" assist
Comonad [Wed, 21 Apr 2021 11:33:45 +0000 (19:33 +0800)]
Add support for fill match arms of boolean values
- Add support for boolean inside tuple
bors[bot] [Wed, 21 Apr 2021 09:12:08 +0000 (09:12 +0000)]
Merge #8609
8609: Parse outer atttributes for RecordPatField r=Veykril a=Veykril
Fixes #8608
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Wed, 21 Apr 2021 09:08:15 +0000 (11:08 +0200)]
Parse outer atttributes for RecordPatField
unexge [Wed, 21 Apr 2021 07:57:36 +0000 (10:57 +0300)]
Add larger example for "Convert to named struct" assist
unexge [Wed, 21 Apr 2021 07:27:26 +0000 (10:27 +0300)]
Fix incorrectly replacing method calls in "Convert to named struct" assist
bors[bot] [Tue, 20 Apr 2021 21:25:27 +0000 (21:25 +0000)]
Merge #8606
8606: fix: no more Registering progress handler for token rustAnalyzer/Ind… r=jonas-schievink a=matklad
…exing failed.
closes #8509
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 20 Apr 2021 19:54:05 +0000 (22:54 +0300)]
fix: no more Registering progress handler for token rustAnalyzer/Indexing failed.
Lukas Wirth [Tue, 20 Apr 2021 17:28:18 +0000 (19:28 +0200)]
Add cov_marks to insert_use tests
Laurențiu Nicola [Mon, 29 Mar 2021 05:55:43 +0000 (08:55 +0300)]
Automatically categorize the changelog entries
Lukas Wirth [Tue, 20 Apr 2021 15:36:36 +0000 (17:36 +0200)]
Rewrite extract_struct_from_enum_variant assist
bors[bot] [Tue, 20 Apr 2021 15:05:33 +0000 (15:05 +0000)]
Merge #8600
8600: fix: no longer get stuck on windows r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 20 Apr 2021 13:06:20 +0000 (16:06 +0300)]
fix: no longer get stuck on windows
reading both stdout & stderr is a common gotcha, you need to drain them
concurrently to avoid deadlocks. Not sure why I didn't do the right
thing from the start. Seems like I assumed the stderr is short? That's
not the case when cargo spams `compiling xyz` messages
bors[bot] [Tue, 20 Apr 2021 14:27:08 +0000 (14:27 +0000)]
Merge #8602
8602: Fix panic in `replace_derive_with_manual_impl` r=jonas-schievink a=jonas-schievink
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Jonas Schievink [Tue, 20 Apr 2021 14:26:07 +0000 (16:26 +0200)]
Follow testing style guide
Jonas Schievink [Tue, 20 Apr 2021 14:25:24 +0000 (16:25 +0200)]
Fix panic in `replace_derive_with_manual_impl`
bors[bot] [Tue, 20 Apr 2021 14:18:51 +0000 (14:18 +0000)]
Merge #8601
8601: Trigger "Inline variable" assist when on a use of the variable r=jonas-schievink a=jonas-schievink
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/8530
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Jonas Schievink [Tue, 20 Apr 2021 14:16:23 +0000 (16:16 +0200)]
"Inline variable" when on a use of the variable
bors[bot] [Tue, 20 Apr 2021 07:45:04 +0000 (07:45 +0000)]
Merge #8598
8598: minor: fix ugly line wrapping in the rendered manual r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 20 Apr 2021 07:44:06 +0000 (10:44 +0300)]
minor: fix ugly line wrapping in the rendered manual
Lukas Wirth [Tue, 20 Apr 2021 00:05:22 +0000 (02:05 +0200)]
Remove SyntaxRewriter usage in insert_use in favor of ted
Lukas Wirth [Mon, 19 Apr 2021 18:29:14 +0000 (20:29 +0200)]
Replace SyntaxRewriter usage with ted in reorder_impl assist
James Leitch [Mon, 19 Apr 2021 19:26:04 +0000 (12:26 -0700)]
Code review feedback.
bors[bot] [Mon, 19 Apr 2021 18:38:34 +0000 (18:38 +0000)]
Merge #8588
8588: internal: Add guidelines for release notes PR descriptions r=matklad a=lnicola
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Mon, 19 Apr 2021 18:09:24 +0000 (21:09 +0300)]
internal: Add guidelines for release notes PR descriptions
bors[bot] [Mon, 19 Apr 2021 18:03:56 +0000 (18:03 +0000)]
Merge #8586
8586: Replace SyntaxRewriter usage with ted in eager::eager_macro_recur r=Veykril a=Veykril
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
bors[bot] [Mon, 19 Apr 2021 17:54:34 +0000 (17:54 +0000)]
Merge #8587
8587: Fix some find_path bugs around inner items r=jonas-schievink a=jonas-schievink
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/8519
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Jonas Schievink [Mon, 19 Apr 2021 17:53:29 +0000 (19:53 +0200)]
Add autoimport test with inner items
Jonas Schievink [Mon, 19 Apr 2021 17:50:11 +0000 (19:50 +0200)]
Fix some find_path bugs around inner items
Lukas Wirth [Mon, 19 Apr 2021 17:43:26 +0000 (19:43 +0200)]
Replace SyntaxRewriter with ted in exppand_macro::expand_macro_recur
Lukas Wirth [Mon, 19 Apr 2021 17:28:41 +0000 (19:28 +0200)]
Remove SyntaxRewriter usage in eager::eager_macro_recur
bors[bot] [Mon, 19 Apr 2021 16:04:44 +0000 (16:04 +0000)]
Merge #8584
8584: internal: fix slightly broken test r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Mon, 19 Apr 2021 15:57:47 +0000 (18:57 +0300)]
internal: fix slightly broken test
bors[bot] [Mon, 19 Apr 2021 15:55:29 +0000 (15:55 +0000)]
Merge #8583
8583: Simplify r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
bors[bot] [Mon, 19 Apr 2021 15:47:18 +0000 (15:47 +0000)]
Merge #8582
8582: Fix typo: comparision -> comparison r=kjeremy a=stanciuadrian
Closes #8576
Co-authored-by: Adrian Stanciu <stanciu.adrian@gmail.com>
Adrian Stanciu [Mon, 19 Apr 2021 15:44:38 +0000 (18:44 +0300)]
Fix typo: comparision -> comparison
bors[bot] [Mon, 19 Apr 2021 15:12:49 +0000 (15:12 +0000)]
Merge #8580
8580: Remove confusion around serverStatusNotification r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Mon, 19 Apr 2021 15:10:33 +0000 (18:10 +0300)]
Remove confusion around serverStatusNotification
Lukas Wirth [Mon, 19 Apr 2021 15:11:30 +0000 (17:11 +0200)]
Simplify
bors[bot] [Mon, 19 Apr 2021 14:56:39 +0000 (14:56 +0000)]
Merge #8579
8579: Fix spec bug r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Mon, 19 Apr 2021 14:55:51 +0000 (17:55 +0300)]
Fix spec bug
bors[bot] [Mon, 19 Apr 2021 14:37:54 +0000 (14:37 +0000)]
Merge #8578
8578: fix: false positive about inner attrs in docs r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Mon, 19 Apr 2021 14:11:49 +0000 (17:11 +0300)]
fix: false positive about inner attrs in docs
closes #8541
bors[bot] [Mon, 19 Apr 2021 13:51:57 +0000 (13:51 +0000)]
Merge #8577
8577: Support crates/module roots in external_docs r=Veykril a=Veykril
Fixes #8575
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Mon, 19 Apr 2021 13:50:04 +0000 (15:50 +0200)]
Support crates/module roots in external_docs
bors[bot] [Mon, 19 Apr 2021 13:18:21 +0000 (13:18 +0000)]
Merge #8502
8502: internal: document review requesting etiquette r=matklad a=matklad
* don't feel obliged to quickly review every PR assigned to you
* so that other folks can notify you about interesting PRs without
thinking to much about creating additional work for you
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
bors[bot] [Mon, 19 Apr 2021 13:09:18 +0000 (13:09 +0000)]
Merge #8524 #8527
8524: Fix extract function with partial block selection r=matklad a=brandondong
**Reproduction:**
```rust
fn foo() {
let n = 1;
let mut v = $0n * n;$0
v += 1;
}
```
1. Select the snippet ($0) and use the "Extract into function" assist.
2. Extracted function is incorrect and does not compile:
```rust
fn foo() {
let n = 1;
let mut v = fun_name(n);
v += 1;
}
fn fun_name(n: i32) {}
```
3. Omitting the ending semicolon from the selection fixes the extracted function:
```rust
fn fun_name(n: i32) -> i32 {
n * n
}
```
**Cause:**
- When `extraction_target` uses a block extraction (semicolon case) instead of an expression extraction (no semicolon case), the user selection is directly used as the TextRange.
- However, the existing function extraction logic for blocks requires that the TextRange spans from start to end of complete statements to work correctly.
- For example:
```rust
fn foo() {
let m = 2;
let n = 1;
let mut v = m $0* n;
let mut w = 3;$0
v += 1;
w += 1;
}
```
produces
```rust
fn foo() {
let m = 2;
let n = 1;
let mut v = m let mut w = fun_name(n);
v += 1;
w += 1;
}
fn fun_name(n: i32) -> i32 {
let mut w = 3;
w
}
```
- The user selected TextRange is directly replaced by the function call which is now in the middle of another statement. The extracted function body only contains statements that were fully covered by the TextRange and so the `* n` code is deleted. The logic for calculating variable usage and outlived variables for the function parameters and return type respectively search within the TextRange and so do not include `m` or `v`.
**Fix:**
- Only extract full statements when using block extraction. If a user selected part of a statement, extract that full statement.
8527: Switch introduce_named_lifetime assist to use mutable syntax tree r=matklad a=iDawer
This extends `GenericParamsOwnerEdit` trait with `get_or_create_generic_param_list` method
Co-authored-by: Brandon <brandondong604@hotmail.com>
Co-authored-by: Dawer <7803845+iDawer@users.noreply.github.com>
Aleksey Kladov [Tue, 13 Apr 2021 11:53:02 +0000 (14:53 +0300)]
Update docs/dev/README.md
Co-authored-by: Laurențiu Nicola <lnicola@users.noreply.github.com>
Aleksey Kladov [Tue, 13 Apr 2021 11:13:50 +0000 (14:13 +0300)]
internal: document review requesting etiquette
* don't feel obliged to quickly review every PR assigned to you
* so that other folks can notify you about interesting PRs without
thinking to much about creating additional work for you
bors[bot] [Mon, 19 Apr 2021 13:01:30 +0000 (13:01 +0000)]
Merge #8462
8462: Expand macros at type position r=jonas-schievink a=cynecx
Co-authored-by: cynecx <me@cynecx.net>
bors[bot] [Mon, 19 Apr 2021 11:39:45 +0000 (11:39 +0000)]
Merge #8574
8574: Check for rust doc code attributes like rustdoc does r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Mon, 19 Apr 2021 11:20:37 +0000 (13:20 +0200)]
Check for rust doc code attributes like rustdoc does
bors[bot] [Mon, 19 Apr 2021 11:32:22 +0000 (11:32 +0000)]
Merge #8565
8565: Fill match arms assist: add remaining arms for tuple of enums r=iDawer a=iDawer
Fix for #8493
However, the assist is still flaky and does not use `hir_ty::diagnostics::match_check`
Co-authored-by: Dawer <7803845+iDawer@users.noreply.github.com>
Dawer [Mon, 19 Apr 2021 11:24:09 +0000 (16:24 +0500)]
Unindent test according to the style guide.
Lukas Wirth [Mon, 19 Apr 2021 09:41:45 +0000 (11:41 +0200)]
Don't require all doc fences to be valid for identifying rust code
bors[bot] [Mon, 19 Apr 2021 07:57:40 +0000 (07:57 +0000)]
Merge #8540
8540: Prevent being able to rename items that are not part of the workspace r=Veykril a=Veykril
This change causes renames that happen on items coming from crates outside the workspace to fail. I believe this should be the right approach, but usage of cargo's workspace might not be entirely correct for preventing these kinds of refactoring from touching things they shouldn't. I'm not entirely sure?
cc #6623, this is one of the bigger footguns when it comes to refactoring, especially in combination with import aliases people tend to rename items coming from a crates dependency which this prevents.
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
bors[bot] [Mon, 19 Apr 2021 06:09:48 +0000 (06:09 +0000)]
Merge #8572
8572: minor: update bug report template r=lnicola a=lnicola
bors r+
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>