]>
git.lizzy.rs Git - rust.git/log
bors [Tue, 28 May 2019 23:07:19 +0000 (23:07 +0000)]
Auto merge of #61296 - Centril:rollup-
5ad68b0 , r=Centril
Rollup of 9 pull requests
Successful merges:
- #60742 (Allow const parameters in array sizes to be unified)
- #60756 (Add better tests for hidden lifetimes in impl trait)
- #60928 (Changes the type `mir::Mir` into `mir::Body`)
- #61024 (tests: Centralize proc macros commonly used for testing)
- #61157 (BufReader: In Seek impl, remove extra discard_buffer call)
- #61195 (Special-case `.llvm` in mangler)
- #61202 (Print PermissionExt::mode() in octal in Documentation Examples)
- #61259 (Mailmap fixes)
- #61273 (mention that MaybeUninit is a bit like Option)
Failed merges:
r? @ghost
Mazdak Farrokhzad [Tue, 28 May 2019 22:20:06 +0000 (00:20 +0200)]
Rollup merge of #61273 - RalfJung:maybe-uninit, r=Centril
mention that MaybeUninit is a bit like Option
Mazdak Farrokhzad [Tue, 28 May 2019 22:20:04 +0000 (00:20 +0200)]
Rollup merge of #61259 - JosephTLyons:mailmap-fixes, r=nikomatsakis
Mailmap fixes
I've made a few fixes and additions to the .mailmap file.
- I've added my information to it, as I noticed it was popping up twice at the [Thanks](https://thanks.rust-lang.org/rust/all-time/) website (I've made contributions to the Rust Book).
- I noticed that @carols10cents‘ information was popping up in multiple places at the [Thanks](https://thanks.rust-lang.org/rust/all-time/) website and when running `git shortlog -s -e > out.txt`, and fixed her information
- I alphabetized the list using Atom's [Sort Lines package](https://github.com/atom/sort-lines)
The output from before and after running `git shortlog -s -e > out.txt` for Carol:
<img width="708" alt="Carol Before" src="https://user-images.githubusercontent.com/
19867440 /
58472843 -
2d8ca880 -8115-11e9-9624-
d31ed23ae9b5 .png">
<img width="523" alt="Carol After" src="https://user-images.githubusercontent.com/
19867440 /
58472844 -
2d8ca880 -8115-11e9-95c6-
80b17cc04790 .png">
The output from before and after running `git shortlog -s -e > out.txt` for myself:
<img width="489" alt="Joseph After" src="https://user-images.githubusercontent.com/
19867440 /
58472941 -
6e84bd00 -8115-11e9-8266-
1d7fcd53d0bc .png">
<img width="421" alt="Joseph Before" src="https://user-images.githubusercontent.com/
19867440 /
58472943 -
6e84bd00 -8115-11e9-9fd2-
d7ace7e3d636 .png">
Mazdak Farrokhzad [Tue, 28 May 2019 22:20:01 +0000 (00:20 +0200)]
Rollup merge of #61202 - oberien:permissionext-print-octal, r=varkor
Print PermissionExt::mode() in octal in Documentation Examples
Printing the file permission mode on unix systems in decimal feels unintuitive. Printing it in octal gives the expected form of e.g. `664`.
Mazdak Farrokhzad [Tue, 28 May 2019 22:20:00 +0000 (00:20 +0200)]
Rollup merge of #61195 - davidtwco:seg-fault-mangler, r=eddyb
Special-case `.llvm` in mangler
Fixes #60925 and fixes #53912.
r? @michaelwoerister
cc @eddyb
Mazdak Farrokhzad [Tue, 28 May 2019 22:19:58 +0000 (00:19 +0200)]
Rollup merge of #61157 - czipperz:BufReader-Seek-remove-extra-discard_buffer, r=nikomatsakis
BufReader: In Seek impl, remove extra discard_buffer call
As far as I can tell, this code does nothing. I'm not sure why it even is there.
Mazdak Farrokhzad [Tue, 28 May 2019 22:19:57 +0000 (00:19 +0200)]
Rollup merge of #61024 - petrochenkov:proctest, r=nikomatsakis
tests: Centralize proc macros commonly used for testing
Many proc macros in `ui\proc-macro\auxiliary` were doing same things.
(I added a fair share of those myself.)
Now commonly used macros (empty, identity, etc) are collected in one place - `ui\proc-macro\auxiliary\test-macros.rs`.
Mazdak Farrokhzad [Tue, 28 May 2019 22:19:55 +0000 (00:19 +0200)]
Rollup merge of #60928 - TheSirC:fix/60229, r=eddyb
Changes the type `mir::Mir` into `mir::Body`
Fixes part 1 of #60229 (previously attempted in #60242).
I stumbled upon the issue and it seems that the previous attempt at solving it was not merged. This is a second try more up-to-date.
The commit should have changed comments as well.
At the time of writting, it passes the tidy and check tool.
Mazdak Farrokhzad [Tue, 28 May 2019 22:19:53 +0000 (00:19 +0200)]
Rollup merge of #60756 - matthewjasper:extra-impl-trait-tests, r=nikomatsakis
Add better tests for hidden lifetimes in impl trait
cc #60670
Mazdak Farrokhzad [Tue, 28 May 2019 22:19:52 +0000 (00:19 +0200)]
Rollup merge of #60742 - varkor:fn-const-array-parameter, r=eddyb
Allow const parameters in array sizes to be unified
Fixes https://github.com/rust-lang/rust/issues/60632.
Fixes https://github.com/rust-lang/rust/issues/60744.
Fixes https://github.com/rust-lang/rust/pull/60923.
(The last commit should probably be viewed in isolation, as it just renames things from `type` to `kind`.)
r? @eddyb
Eduard-Mihai Burtescu [Tue, 28 May 2019 21:27:42 +0000 (00:27 +0300)]
syntax: bail out of `find_width_of_character_at_span` if the span doesn't start and end in the same file.
Eduard-Mihai Burtescu [Tue, 28 May 2019 21:26:56 +0000 (00:26 +0300)]
rustc: rename Mir to mir::Body in comments and to MIR in error strings.
varkor [Tue, 28 May 2019 20:34:18 +0000 (21:34 +0100)]
Use assert_eq! instead of println! in tests
varkor [Tue, 28 May 2019 19:25:21 +0000 (20:25 +0100)]
Fix nits
varkor [Mon, 27 May 2019 13:30:16 +0000 (14:30 +0100)]
Make sure array length diagnostic doesn't regress
varkor [Mon, 27 May 2019 13:28:20 +0000 (14:28 +0100)]
Correct pluralisation of tuple/array/associated type binding mismatch errors
varkor [Mon, 27 May 2019 13:05:29 +0000 (14:05 +0100)]
Reintroduce `TypeError::FixedArraySize`
varkor [Sat, 25 May 2019 20:00:29 +0000 (21:00 +0100)]
Use Display rather than Debug printing for const mismatch
varkor [Sat, 25 May 2019 19:42:14 +0000 (20:42 +0100)]
Update tests after pretty printing
varkor [Tue, 21 May 2019 09:14:44 +0000 (10:14 +0100)]
Fix test after rebase
varkor [Mon, 20 May 2019 22:03:38 +0000 (23:03 +0100)]
Add broken MIR regression tests
varkor [Mon, 13 May 2019 20:24:00 +0000 (21:24 +0100)]
Remove FixedArraySize error
varkor [Mon, 13 May 2019 20:15:08 +0000 (21:15 +0100)]
Eagerly evaluate in `super_relate_consts`
varkor [Sun, 12 May 2019 21:28:26 +0000 (22:28 +0100)]
Update test output
varkor [Sat, 11 May 2019 18:08:26 +0000 (19:08 +0100)]
Rename `OpportunisticTypeResolver` to `OpportunisticVarResolver`
varkor [Sat, 11 May 2019 17:58:15 +0000 (18:58 +0100)]
Add tests for uninferred consts during codegen
varkor [Sat, 11 May 2019 17:54:14 +0000 (18:54 +0100)]
Resolve consts in OpportunisticTypeResolver
varkor [Sat, 11 May 2019 17:02:05 +0000 (18:02 +0100)]
Add a test for a function taking a const param array as an argument
varkor [Sat, 11 May 2019 17:01:50 +0000 (18:01 +0100)]
Relate identical parameters in array lengths
David Wood [Sat, 25 May 2019 21:29:18 +0000 (22:29 +0100)]
Special-case `.llvm` in mangler to fix segfaults
This commit special cases `.llvm` in the mangler to print `.llvm$6d$`
instead. This will avoid segfaults when names in a user's Rust code are
`llvm`.
bors [Tue, 28 May 2019 17:38:01 +0000 (17:38 +0000)]
Auto merge of #61274 - Centril:rollup-23dekk4, r=Centril
Rollup of 4 pull requests
Successful merges:
- #61123 (Allow to specify profiling data output directory as -Zself-profile argument.)
- #61159 (split core::ptr module into multiple files)
- #61164 (rename Scalar::Bits to Scalar::Raw and bits field to data)
- #61250 (Remove special case for *ios* builds in run-make-fulldeps/print-target-list Makefile)
Failed merges:
r? @ghost
Claude-Alban RANÉLY-VERGÉ-DÉPRÉ [Fri, 17 May 2019 21:55:04 +0000 (23:55 +0200)]
Changes the type `mir::Mir` into `mir::Body`
The commit should have changed comments as well.
At the time of writting, it passes the tidy and check tool.
Revisions asked by eddyb :
- Renamed of all the occurences of {visit/super}_mir
- Renamed test structures `CachedMir` to `Cached`
Fixing the missing import on `AggregateKind`
Ralf Jung [Tue, 28 May 2019 16:20:24 +0000 (18:20 +0200)]
Update src/libcore/mem.rs
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
Mazdak Farrokhzad [Tue, 28 May 2019 16:15:41 +0000 (18:15 +0200)]
Rollup merge of #61250 - rye:print-target-list--rm-ios-case, r=alexcrichton
Remove special case for *ios* builds in run-make-fulldeps/print-target-list Makefile
Previous `TODO` comment in this file mentions [an issue that was closed](https://github.com/rust-lang/rust/issues/29812), and I was able to confirm locally that provided code in that issue no longer produces an ICE. Discussion on that issue seems to indicate this code was no longer needed as of 1.12.0.
I removed the `*ios*` branch from this `case` statement as it may cause confusion, then removed the case statement entirely as it only had a wildcard branch.
Mazdak Farrokhzad [Tue, 28 May 2019 16:15:39 +0000 (18:15 +0200)]
Rollup merge of #61164 - RalfJung:scalar, r=oli-obk
rename Scalar::Bits to Scalar::Raw and bits field to data
Also use this opportunity to seal some abstraction leaks (other modules constructing `Scalar::Bits` directly instead of using a constructor).
r? @oli-obk
Mazdak Farrokhzad [Tue, 28 May 2019 16:15:38 +0000 (18:15 +0200)]
Rollup merge of #61159 - RalfJung:ptr, r=alexcrichton
split core::ptr module into multiple files
Cc @Centril
Mazdak Farrokhzad [Tue, 28 May 2019 16:15:35 +0000 (18:15 +0200)]
Rollup merge of #61123 - michaelwoerister:self-profile-dir, r=wesleywiser
Allow to specify profiling data output directory as -Zself-profile argument.
The PR also makes `rustc` include the crate-name (if already available) in the output file name.
r? @wesleywiser
At some point we should add some basic tests for `-Zself-profile`.
Ralf Jung [Tue, 28 May 2019 16:04:37 +0000 (18:04 +0200)]
mention that MaybeUninit is a bit like Option
bors [Tue, 28 May 2019 14:42:27 +0000 (14:42 +0000)]
Auto merge of #61246 - oli-obk:clippy, r=oli-obk
Update clippy submodule
fixes #61240
Michael Woerister [Tue, 28 May 2019 14:13:59 +0000 (16:13 +0200)]
Rename PgoGenerate to something more general.
Michael Woerister [Fri, 24 May 2019 14:36:44 +0000 (16:36 +0200)]
Allow to specify profiling data output directory as -Zself-profile argument.
bors [Tue, 28 May 2019 11:50:14 +0000 (11:50 +0000)]
Auto merge of #61258 - Centril:rollup-l2mof9t, r=Centril
Rollup of 9 pull requests
Successful merges:
- #61084 (Clarify docs for unreachable! macro)
- #61220 (Added error message for E0284)
- #61227 (Use .await syntax instead of await!)
- #61230 (avoid creating Boxes of uninitalized values in RawVec)
- #61237 (Updated the Iterator docs with information about overriding methods.)
- #61241 (Check place iterative)
- #61242 (Make dest_needs_borrow iterate instead of recurse)
- #61247 (Make eval_place iterate instead of recurse)
- #61248 (Use Place::local)
Failed merges:
r? @ghost
Joseph Lyons [Tue, 28 May 2019 10:42:47 +0000 (06:42 -0400)]
Alphabetized lines with Atom's Sort Lines package
https://github.com/atom/sort-lines
Joseph Lyons [Tue, 28 May 2019 10:40:41 +0000 (06:40 -0400)]
Adding mailmap for myself
Joseph Lyons [Tue, 28 May 2019 10:40:16 +0000 (06:40 -0400)]
Fixing mailmap for Carol
Oliver Scherer [Mon, 27 May 2019 20:49:37 +0000 (22:49 +0200)]
Update clippy submodule
Mazdak Farrokhzad [Tue, 28 May 2019 09:49:09 +0000 (11:49 +0200)]
Rollup merge of #61248 - spastorino:use-place-local-fn, r=oli-obk
Use Place::local
r? @oli-obk
Mazdak Farrokhzad [Tue, 28 May 2019 09:49:08 +0000 (11:49 +0200)]
Rollup merge of #61247 - spastorino:eval-place-iterate, r=wesleywiser
Make eval_place iterate instead of recurse
r? @oli-obk
Mazdak Farrokhzad [Tue, 28 May 2019 09:49:04 +0000 (11:49 +0200)]
Rollup merge of #61242 - spastorino:dest-needs-borrow-iterate, r=oli-obk
Make dest_needs_borrow iterate instead of recurse
r? @oli-obk
Mazdak Farrokhzad [Tue, 28 May 2019 09:49:02 +0000 (11:49 +0200)]
Rollup merge of #61241 - spastorino:check-place-iterative, r=oli-obk
Check place iterative
r? @oli-obk
Mazdak Farrokhzad [Tue, 28 May 2019 09:49:00 +0000 (11:49 +0200)]
Rollup merge of #61237 - DevQps:expand-iterator-docs, r=Mark-Simulacrum
Updated the Iterator docs with information about overriding methods.
# Description
Updated the Iterator docs with information about overriding methods.
closes #60223
Mazdak Farrokhzad [Tue, 28 May 2019 09:48:58 +0000 (11:48 +0200)]
Rollup merge of #61230 - matklad:ub-comment, r=RalfJung
avoid creating Boxes of uninitalized values in RawVec
`RawVec<bool>::into_box` is definitely instant UB, if not all values are initialized.
See https://gankro.github.io/blah/initialize-me-maybe/
Mazdak Farrokhzad [Tue, 28 May 2019 09:48:56 +0000 (11:48 +0200)]
Rollup merge of #61227 - diwic:patch-2, r=Centril
Use .await syntax instead of await!
Tiny doc fix.
Mazdak Farrokhzad [Tue, 28 May 2019 09:48:55 +0000 (11:48 +0200)]
Rollup merge of #61220 - imbrem:error_explanations, r=estebank
Added error message for E0284
Work on #61137
Mazdak Farrokhzad [Tue, 28 May 2019 09:48:53 +0000 (11:48 +0200)]
Rollup merge of #61084 - blkerby:unreachable_doc, r=KodrAus
Clarify docs for unreachable! macro
Fixes #60754.
bors [Tue, 28 May 2019 05:28:13 +0000 (05:28 +0000)]
Auto merge of #60955 - agnxy:rename-assoc, r=oli-obk,Centril
Rename "Associated*" to "Assoc*"
This change is for #60163.
r? @oli-obk
bors [Tue, 28 May 2019 01:56:44 +0000 (01:56 +0000)]
Auto merge of #61036 - michaelwoerister:pgo-xlto-test, r=alexcrichton
PGO - Add a smoketest for combining PGO with cross-language LTO.
This PR
- Adds a test making sure that PGO can be combined with cross-language LTO.
- Does a little cleanup on how the `pgo-use` flag is handled internally.
- Makes the compiler error if the `pgo-use` file given to `rustc` doesn't actually exist. LLVM only gives a warning and then just doesn't do PGO. Clang, on the other hand, does give an error in this case.
- Makes the build system also build `compiler-rt` when building LLDB. This way the Clang compiler that we get from building LLDB can perform PGO, which is something that the new test case wants to do. CI compile times shouldn't be affected too much.
Kristofer Rye [Tue, 28 May 2019 00:40:11 +0000 (19:40 -0500)]
Fix an sh error
Didn't think it was this particular about things, but I also should
have tested locally.
It makes sense, though---`\` followed by LF would eat it, so we'd have
`sysroot done` instead of `sysroot; done` as it is parsed. This should
pass now.
Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
Tested-by: Kristofer Rye <kristofer.rye@gmail.com>
Jad Ghalayini [Mon, 27 May 2019 23:37:20 +0000 (19:37 -0400)]
Incorporated suggested changes
bors [Mon, 27 May 2019 23:04:54 +0000 (23:04 +0000)]
Auto merge of #61078 - pietroalbini:nightly-next, r=Centril
Bump nightly to 1.37.0
r? @Mark-Simulacrum
Kristofer Rye [Mon, 27 May 2019 21:52:54 +0000 (16:52 -0500)]
Remove now-dead case statement in print-target-list Makefile
Since this case statement no longer has any branches, remove it.
Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
Kristofer Rye [Mon, 27 May 2019 21:44:16 +0000 (16:44 -0500)]
Remove *ios* case from print-target-list Makefile
Based on the TODO, this case was added to short-circuit for ios builds,
which is no longer necessary.
The comment in this Makefile mentions rust-lang/rust#29812 as a
dependency, but that issue has been since closed, with a statement that
the ICE of concern was resolved circa 1.12.
Here we remove this case, and just run the same branch for all targets.
Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
Santiago Pastorino [Mon, 27 May 2019 21:03:38 +0000 (23:03 +0200)]
Use Place::local
Santiago Pastorino [Mon, 27 May 2019 20:47:30 +0000 (22:47 +0200)]
Make eval_place iterate instead of recurse
Santiago Pastorino [Mon, 27 May 2019 19:47:24 +0000 (21:47 +0200)]
Make check_place iterate instead of recurse
Santiago Pastorino [Mon, 27 May 2019 20:00:44 +0000 (22:00 +0200)]
Make dest_needs_borrow iterate instead of recurse
bors [Mon, 27 May 2019 20:12:14 +0000 (20:12 +0000)]
Auto merge of #61140 - estebank:attr-diagnostics, r=michaelwoerister
Reword malformed attribute input diagnostics
- Handle empty `cfg_attr` attribute
- Reword empty `derive` attribute error
- Use consistend error message: "malformed `attrname` attribute input"
- Provide suggestions when possible
- Move note/help to label/suggestion
- Use consistent wording "ill-formed" -> "malformed"
- Move diagnostic logic out of parser
Split up from https://github.com/rust-lang/rust/pull/61026, where there's prior conversation.
Santiago Pastorino [Mon, 27 May 2019 19:40:22 +0000 (21:40 +0200)]
Remove unused tcx and mir params
Aleksey Kladov [Mon, 27 May 2019 19:42:50 +0000 (22:42 +0300)]
Update src/liballoc/boxed.rs
Co-Authored-By: Ralf Jung <post@ralfj.de>
Aleksey Kladov [Mon, 27 May 2019 06:43:20 +0000 (09:43 +0300)]
make Box<str>::clone simpler & safer
bors [Mon, 27 May 2019 15:36:32 +0000 (15:36 +0000)]
Auto merge of #60827 - oli-obk:late_symbol, r=nnethercote
Use `Symbol` more in lint APIs
r? @nnethercote
This will cause clippy breakage, but super trivial to fix since we can then remove the hacky `match_def_path` function that I added and go back to calling rustc's `match_def_path` method.
Michael Woerister [Mon, 27 May 2019 13:09:26 +0000 (15:09 +0200)]
Only build clang_rt when RUSTBUILD_FORCE_CLANG_BASED_TESTS is set.
Christian [Mon, 27 May 2019 14:17:39 +0000 (16:17 +0200)]
Updated the Iterator docs with information about overriding methods.
bors [Mon, 27 May 2019 12:46:12 +0000 (12:46 +0000)]
Auto merge of #59627 - LooMaclin:issue_57128_improve_miri_error_reporting_in_check_in_alloc, r=RalfJung
Improve miri error reporting in check_in_alloc
Fixes https://github.com/rust-lang/rust/issues/57128
r? @RalfJung @oli-obk
Michael Woerister [Wed, 22 May 2019 13:41:56 +0000 (15:41 +0200)]
Fix unit test after pgo-use change.
Michael Woerister [Mon, 20 May 2019 09:43:38 +0000 (11:43 +0200)]
Add a smoketest for combining PGO with xLTO.
Michael Woerister [Wed, 22 May 2019 11:01:12 +0000 (13:01 +0200)]
rustbuild: Also build compiler-rt when building LLDB. This allows clang-based run-make tests to use PGO.
Michael Woerister [Wed, 22 May 2019 11:00:09 +0000 (13:00 +0200)]
PGO: Check that pgo-use file actually exists. LLVM seems to only emit an easy-to-overlook warning otherwise.
Michael Woerister [Wed, 22 May 2019 10:58:56 +0000 (12:58 +0200)]
Use a PathBuf instead of String for representing the pgo-use path internally.
Ralf Jung [Sun, 26 May 2019 21:28:09 +0000 (23:28 +0200)]
factor out some common code and make the on-elimination truncation test debug-only
Ralf Jung [Mon, 27 May 2019 07:40:13 +0000 (09:40 +0200)]
fix truncate and sign_extend for size == 0
Oliver Scherer [Tue, 14 May 2019 13:58:22 +0000 (15:58 +0200)]
Use `Symbol` more in lint APIs
bors [Mon, 27 May 2019 09:49:18 +0000 (09:49 +0000)]
Auto merge of #60967 - Zoxc:fix-syntax-sync, r=michaelwoerister
Short circuit Send and Sync impls for TokenTree
Workaround to make the parallel compiler build after https://github.com/rust-lang/rust/pull/60444.
r? @nikomatsakis
Aleksey Kladov [Mon, 27 May 2019 06:43:20 +0000 (09:43 +0300)]
avoid materializing unintialized Boxes in RawVec
John Kåre Alsaker [Sun, 19 May 2019 18:44:06 +0000 (20:44 +0200)]
Short circuit Send and Sync impls for TokenTree
bors [Mon, 27 May 2019 06:53:53 +0000 (06:53 +0000)]
Auto merge of #61035 - nnethercote:avoid-more-symbol-interning, r=petrochenkov
Avoid more symbol interning
r? @petrochenkov
diwic [Mon, 27 May 2019 05:27:13 +0000 (07:27 +0200)]
Use .await syntax instead of await!
Nicholas Nethercote [Thu, 23 May 2019 06:23:11 +0000 (16:23 +1000)]
Use `Symbol` equality in `may_begin_with` and `parse_nt`.
Nicholas Nethercote [Thu, 23 May 2019 06:11:52 +0000 (16:11 +1000)]
Use `Symbol` equality in `check_ident_token`.
Nicholas Nethercote [Thu, 23 May 2019 05:31:43 +0000 (15:31 +1000)]
Use `Symbol` equality in `is_ident_named`.
Nicholas Nethercote [Thu, 23 May 2019 02:34:38 +0000 (12:34 +1000)]
Avoid some re-interning in `to_lit_token`.
Nicholas Nethercote [Thu, 23 May 2019 02:22:43 +0000 (12:22 +1000)]
Add `to_symbol` methods.
bors [Mon, 27 May 2019 03:58:56 +0000 (03:58 +0000)]
Auto merge of #61215 - paoloteti:armebv7r, r=alexcrichton
Docker: remove environment variable `CC_armebv7r_none_eabi`
`cc-rs` take care of selecting the tool-chain, so this `ENV` variable can be safely removed.
Nicholas Nethercote [Wed, 22 May 2019 09:25:39 +0000 (19:25 +1000)]
Pre-intern "0", "1", ..., "9", and use where appropriate.
Nicholas Nethercote [Wed, 22 May 2019 04:41:15 +0000 (14:41 +1000)]
Pass symbols to `ExtCtxt::std_path` instead of strings.
Because this function is hot.
Also remove the dead `ty_option` function.
Nicholas Nethercote [Wed, 22 May 2019 02:42:23 +0000 (12:42 +1000)]
Avoid unnecessary internings.
Most involving `Symbol::intern` on string literals.
Nicholas Nethercote [Wed, 22 May 2019 00:15:32 +0000 (10:15 +1000)]
Avoid interning in `resolve_place_op`.
This function is hot for `keccak`.
bors [Mon, 27 May 2019 01:10:22 +0000 (01:10 +0000)]
Auto merge of #61147 - estebank:suggest-as-ref, r=oli-obk
When encountering move error on an `Option`, suggest using `as_ref`
Fix #61109, cc #15457.
bors [Sun, 26 May 2019 21:38:04 +0000 (21:38 +0000)]
Auto merge of #61214 - oli-obk:clippy, r=Manishearth
Update clippy submodule
r? @Manishearth
Jad Ghalayini [Sun, 26 May 2019 20:48:02 +0000 (16:48 -0400)]
Added error message for E0284