]>
git.lizzy.rs Git - rust.git/log
Josh Holmer [Tue, 4 Sep 2018 03:50:24 +0000 (23:50 -0400)]
Rustup
Josh Holmer [Fri, 31 Aug 2018 22:26:04 +0000 (18:26 -0400)]
Apply applicability
Josh Holmer [Fri, 31 Aug 2018 22:14:33 +0000 (18:14 -0400)]
Majority of PR changes
Josh Holmer [Thu, 30 Aug 2018 03:01:24 +0000 (23:01 -0400)]
Lint against needless uses of `collect()`
Handles cases of `.collect().len()`, `.collect().is_empty()`, and
`.collect().contains()`. This lint is intended to be generic enough to
be added to at a later time with other similar patterns that could be
optimized.
Closes #3034
Philipp Hansch [Mon, 3 Sep 2018 15:24:33 +0000 (17:24 +0200)]
Merge pull request #3092 from illicitonion/issue-2879
default_trait_access skips <F as Default>::default()
Manish Goregaokar [Mon, 3 Sep 2018 09:37:18 +0000 (09:37 +0000)]
Merge pull request #3120 from rust-lang-nursery/ci_integration
Update travis integration tests to tool_lints
Philipp Krones [Mon, 3 Sep 2018 08:55:43 +0000 (10:55 +0200)]
Merge pull request #3119 from joshtriplett/a-message-from-the-save-the-iters-foundation
iter conservation efforts: save the endangered .iter() and .into_iter()
Philipp Krones [Mon, 3 Sep 2018 08:52:42 +0000 (10:52 +0200)]
Update travis integration tests to tool_lints
`clippy_pedantic` -> `clippy::pedantic`
`clippy_nursery` -> `clippy::nursery`
Josh Triplett [Mon, 3 Sep 2018 07:19:59 +0000 (00:19 -0700)]
iter conservation efforts: save the endangered .iter() and .into_iter()
Make explicit_iter_loop and explicit_into_iter_loop allow-by-default, so
that people can turn them on if they want to enforce that style; avoid
presenting them as *the* idiomatic Rust style, rather than just *a* style.
Philipp Hansch [Mon, 3 Sep 2018 06:35:24 +0000 (07:35 +0100)]
Merge pull request #3116 from phansch/fix_warning
Fix clippy -> clippy::all warning in CI
Philipp Hansch [Mon, 3 Sep 2018 06:03:05 +0000 (08:03 +0200)]
Fix clippy -> clippy::all warning in CI
Manish Goregaokar [Mon, 3 Sep 2018 05:48:46 +0000 (05:48 +0000)]
Merge pull request #3115 from rust-lang-nursery/rm-token
Remove dependence of ci on github token
Manish Goregaokar [Mon, 3 Sep 2018 03:42:06 +0000 (09:12 +0530)]
Remove dependence of ci on github token
Manish Goregaokar [Mon, 3 Sep 2018 02:44:45 +0000 (08:14 +0530)]
Merge pull request #2941 from rust-lang-nursery/prs
Run travis on rustc-master instead of nightly
Manish Goregaokar [Mon, 3 Sep 2018 02:06:58 +0000 (07:36 +0530)]
Merge pull request #3114 from nrc/pub-conf
Make `Conf::default` available
Nick Cameron [Mon, 3 Sep 2018 01:57:50 +0000 (13:57 +1200)]
Make `Conf::default` available
Fixes RLS
Daniel Wagner-Hall [Sun, 2 Sep 2018 23:01:57 +0000 (00:01 +0100)]
Merge branch 'master' into issue-2879
Daniel Wagner-Hall [Sun, 2 Sep 2018 22:42:07 +0000 (23:42 +0100)]
Simplify
Daniel Wagner-Hall [Sun, 2 Sep 2018 22:37:28 +0000 (23:37 +0100)]
Use types rather than strings
Philipp Hansch [Sun, 2 Sep 2018 09:31:39 +0000 (11:31 +0200)]
Trigger rebuild for AppVeyor (and fix grammar)
Philipp Hansch [Sun, 2 Sep 2018 09:05:49 +0000 (11:05 +0200)]
Merge remote-tracking branch 'upstream/master' into prs
Manish Goregaokar [Sun, 2 Sep 2018 07:59:06 +0000 (13:29 +0530)]
Merge pull request #3113 from mikerite/fix-3112
Fix #3112
Michael Wright [Sun, 2 Sep 2018 07:38:25 +0000 (09:38 +0200)]
Fix #3112
Manish Goregaokar [Sat, 1 Sep 2018 05:52:23 +0000 (11:22 +0530)]
Merge pull request #2977 from flip1995/tool_lints
Implement tool_lints
Manish Goregaokar [Fri, 31 Aug 2018 07:38:27 +0000 (00:38 -0700)]
Fix ptr offset tests
Manish Goregaokar [Fri, 31 Aug 2018 07:34:48 +0000 (00:34 -0700)]
declare_lint -> declare_tool_lint
Oliver Schneider [Fri, 31 Aug 2018 07:05:39 +0000 (09:05 +0200)]
Merge pull request #3081 from mikerite/fix-3078
Fix #3078
Michael Wright [Fri, 31 Aug 2018 04:17:11 +0000 (06:17 +0200)]
Merge branch 'master' into fix-3078
Michael Wright [Fri, 31 Aug 2018 04:10:30 +0000 (06:10 +0200)]
Revert "fix-3078: verify test case"
This reverts commit
6256ad05bac1f708298f827fdfa7b54042961294 .
Oliver Schneider [Thu, 30 Aug 2018 08:16:36 +0000 (10:16 +0200)]
Merge pull request #2962 from phansch/further_automate_pre_publish
Further automate pre_publish.sh
Philipp Hansch [Thu, 30 Aug 2018 05:33:53 +0000 (07:33 +0200)]
Remove git diffing part
Because we no bump versions
Philipp Hansch [Wed, 29 Aug 2018 19:09:38 +0000 (20:09 +0100)]
Merge pull request #3076 from mbrubeck/patch-1
Remove incorrect note from string_add_assign docs
Manish Goregaokar [Wed, 29 Aug 2018 18:24:00 +0000 (11:24 -0700)]
Merge pull request #3105 from frewsxcv/frewsxcv-private
Make clippy_lints::{utils,consts} modules private, remove unused items.
flip1995 [Tue, 28 Aug 2018 12:16:31 +0000 (14:16 +0200)]
Implement backwards compatibility changes introduced by rust-lang/rust#53762
flip1995 [Tue, 28 Aug 2018 09:27:17 +0000 (11:27 +0200)]
Fix some rebase fallout
flip1995 [Wed, 1 Aug 2018 20:48:41 +0000 (22:48 +0200)]
Adapt codebase to the tool_lints
flip1995 [Wed, 1 Aug 2018 20:38:04 +0000 (22:38 +0200)]
Adapt ui-toml-tests to the tool_lints
flip1995 [Mon, 30 Jul 2018 09:33:44 +0000 (11:33 +0200)]
Adapt run-pass tests to the tool_lints
flip1995 [Wed, 1 Aug 2018 14:30:44 +0000 (16:30 +0200)]
Adapt the *.stderr files of the ui-tests to the tool_lints
flip1995 [Sat, 28 Jul 2018 15:34:52 +0000 (17:34 +0200)]
Adapt ui-tests to the tool_lints
flip1995 [Sat, 28 Jul 2018 15:35:41 +0000 (17:35 +0200)]
Adapt scripts to the tool_lints
flip1995 [Sat, 28 Jul 2018 15:35:24 +0000 (17:35 +0200)]
Adapt documentation to the tool_lints
flip1995 [Sun, 29 Jul 2018 09:04:40 +0000 (11:04 +0200)]
Switch to declare_tool_lint macro
flip1995 [Sat, 28 Jul 2018 15:34:24 +0000 (17:34 +0200)]
Switch to tool_lints
Oliver Schneider [Wed, 29 Aug 2018 14:32:11 +0000 (16:32 +0200)]
Merge pull request #3104 from frewsxcv/frewsxcv-ptr-offset-with-cast
New lint: Suggest `ptr.add([usize])` over `ptr.offset([usize] as isize)`.
Corey Farwell [Wed, 29 Aug 2018 13:59:38 +0000 (08:59 -0500)]
dont deref
Corey Farwell [Wed, 29 Aug 2018 13:27:32 +0000 (08:27 -0500)]
clippy suggestion
Corey Farwell [Wed, 29 Aug 2018 13:01:05 +0000 (08:01 -0500)]
derive copy/clone
Corey Farwell [Wed, 29 Aug 2018 12:46:03 +0000 (07:46 -0500)]
bring back sugg::range
Corey Farwell [Wed, 29 Aug 2018 12:43:40 +0000 (07:43 -0500)]
eof newline
Corey Farwell [Wed, 29 Aug 2018 12:42:43 +0000 (07:42 -0500)]
utilize carrier
Corey Farwell [Wed, 29 Aug 2018 12:40:00 +0000 (07:40 -0500)]
suggest wrapping_offset as well
Corey Farwell [Wed, 29 Aug 2018 12:12:22 +0000 (07:12 -0500)]
if no suggestion, dont add suggestion
Corey Farwell [Wed, 29 Aug 2018 12:08:59 +0000 (07:08 -0500)]
utilize .is_unsafe_ptr
Corey Farwell [Wed, 29 Aug 2018 12:07:23 +0000 (07:07 -0500)]
utilize cx.tcx.types.usize
Corey Farwell [Wed, 29 Aug 2018 12:03:50 +0000 (07:03 -0500)]
tweak comment
Corey Farwell [Wed, 29 Aug 2018 12:02:26 +0000 (07:02 -0500)]
switch lint from 'style' to 'complexity'
Corey Farwell [Mon, 27 Aug 2018 13:49:54 +0000 (09:49 -0400)]
New lint: Suggest `ptr.add([usize])` over `ptr.offset([usize] as isize)`.
First part of #3047.
Corey Farwell [Wed, 29 Aug 2018 02:32:20 +0000 (21:32 -0500)]
Make clippy_lints::{utils,consts} modules private, remove unused items.
Oliver Schneider [Tue, 28 Aug 2018 11:13:42 +0000 (13:13 +0200)]
Update imports and rustup
Philipp Hansch [Tue, 28 Aug 2018 05:42:36 +0000 (06:42 +0100)]
Merge pull request #3101 from pickfire/patch-1
Fix typo for panel cursor
Ivan Tham [Tue, 28 Aug 2018 02:24:21 +0000 (10:24 +0800)]
Fix typo for panel cursor
Daniel Wagner-Hall [Mon, 27 Aug 2018 22:22:07 +0000 (23:22 +0100)]
default_trait_access skips <F as Default>::default()
This includes the type name, so is clear, and may be necessary.
There doesn't seem to be an obviously cleaner way to pull out the
literal text of the named type here.
Fixes #2879
llogiq [Mon, 27 Aug 2018 19:00:53 +0000 (21:00 +0200)]
Merge pull request #3090 from matthiaskrgr/new_without_default_highlight
docs: make example in new_without_default lint syntax highlighted
Matthias Krüger [Mon, 27 Aug 2018 15:35:30 +0000 (17:35 +0200)]
docs: make example in new_without_default lint syntax highlighted
Oliver Schneider [Mon, 27 Aug 2018 09:08:58 +0000 (11:08 +0200)]
Merge pull request #3018 from rust-lang-nursery/beta
We are riding the trains to stable, there's no point in trying to check the rustc version
Oliver Schneider [Sun, 26 Aug 2018 14:29:11 +0000 (16:29 +0200)]
Merge pull request #3087 from rust-lang-nursery/run
Use the compilers exit code computation instead of rolling our own
Oliver Schneider [Sun, 26 Aug 2018 13:49:08 +0000 (15:49 +0200)]
Use the compilers exit code computation instead of rolling our own
Philipp Krones [Sun, 26 Aug 2018 13:08:21 +0000 (15:08 +0200)]
Merge pull request #3082 from mikerite/move-range-lints
Move some range lints to complexity
Oliver Schneider [Sun, 26 Aug 2018 10:20:35 +0000 (12:20 +0200)]
Merge pull request #3084 from mikerite/fix-3083
Remove `iterator_find_map` feature attribute
Michael Wright [Sun, 26 Aug 2018 09:11:47 +0000 (11:11 +0200)]
Remove `iterator_find_map` feature attribute
Closes #3083
Michael Wright [Sun, 26 Aug 2018 08:57:04 +0000 (10:57 +0200)]
Move some range lints to complexity
Recategorize `range_plus_one` and `range_minus_one` to `complexity`.
This moves `range_plus_one` out of the nursery as the inclusive range
syntax is now stable. Both are moved to `complexity` as it is more
consistent with other lints such as `int_plus_one`.
Michael Wright [Sat, 25 Aug 2018 20:35:06 +0000 (22:35 +0200)]
fix-3078: verify test case
Check the crash test case by commenting out the fix
Michael Wright [Sat, 25 Aug 2018 12:49:56 +0000 (14:49 +0200)]
Fix #3078
Philipp Hansch [Fri, 24 Aug 2018 18:09:50 +0000 (20:09 +0200)]
Merge pull request #3079 from matthiaskrgr/update_cargo_metadata
deps: update cargo_metadata from 0.5 to 0.6.
Philipp Krones [Fri, 24 Aug 2018 17:47:17 +0000 (19:47 +0200)]
Merge pull request #3080 from matthiaskrgr/manual_swap_example
add how-to example for std::mem::transmute() usage instead of manual swap
Matthias Krüger [Fri, 24 Aug 2018 16:41:49 +0000 (18:41 +0200)]
add how-to example for std::mem::transmute() usage instead of manual swap
Philipp Krones [Fri, 24 Aug 2018 16:29:31 +0000 (18:29 +0200)]
Merge pull request #3048 from goodmanjonathan/assign_op
deprecate assign_ops lint
Philipp Krones [Fri, 24 Aug 2018 16:28:50 +0000 (18:28 +0200)]
Merge pull request #3059 from elpiel/writeln_empty_string_harcoded-suggestion
#3016 writeln_empty_string Hardcoded suggestion
Matthias Krüger [Fri, 24 Aug 2018 16:14:49 +0000 (18:14 +0200)]
deps: update cargo_metadata from 0.5 to 0.6.
Philipp Krones [Fri, 24 Aug 2018 10:27:48 +0000 (12:27 +0200)]
Merge pull request #2924 from niklasf/copy-iterator
Add copy_iterator lint (#1534)
Niklas Fiekas [Tue, 17 Jul 2018 17:22:55 +0000 (19:22 +0200)]
Add copy_iterator lint (#1534)
Philipp Krones [Thu, 23 Aug 2018 21:29:00 +0000 (23:29 +0200)]
Merge pull request #3077 from matthiaskrgr/rustup_2
fix clippy breakage due to https://github.com/rust-lang/rust/pull/52602
Matthias Krüger [Thu, 23 Aug 2018 19:41:30 +0000 (21:41 +0200)]
fix clippy breakage due to https://github.com/rust-lang/rust/pull/52602
Matt Brubeck [Thu, 23 Aug 2018 15:38:41 +0000 (08:38 -0700)]
Remove incorrect note from string_add_assign docs
The docs claim that `String::push_str` is better than `String::add` because `String::add` allocates a new string and drops the old one, but this is not true. In fact, `add` reuses the existing string and grows it only if its capacity is exceeded, exactly like `push_str`. Their performance is identical since `add` is just a wrapper for `push_str`:
```
fn add(mut self, other: &str) -> String {
self.push_str(other);
self
}
```
https://github.com/rust-lang/rust/blob/
35bf1ae25799a4e62131159f052e0a3cbd27c960 /src/liballoc/string.rs#L1922-L1925
Philipp Krones [Thu, 23 Aug 2018 13:53:07 +0000 (15:53 +0200)]
Merge pull request #3072 from matthiaskrgr/rustup
rustup, fix breakage introduced by rust-lang/rust#53581 and rust-lang/rust#53459
Matthias Krüger [Thu, 23 Aug 2018 11:12:27 +0000 (13:12 +0200)]
remove macro_vis_matcher feature gate since it is stable now.
Warning was:
warning: the feature `macro_vis_matcher` has been stable since 1.29.0 and no longer requires an attribute to enable
--> src/lib.rs:4:12
|
4 | #![feature(macro_vis_matcher)]
| ^^^^^^^^^^^^^^^^^
|
= note: #[warn(stable_features)] on by default
flip1995 [Thu, 23 Aug 2018 13:36:07 +0000 (15:36 +0200)]
Remove now stable tool_attributes feature
Matthias Krüger [Wed, 22 Aug 2018 21:34:52 +0000 (23:34 +0200)]
rustup, fix breakage introduced by https://github.com/rust-lang/rust/pull/53581
flip1995 [Wed, 22 Aug 2018 16:08:52 +0000 (18:08 +0200)]
Add LD_LIBRARY_PATH and GITHUB_TOKEN
flip1995 [Wed, 22 Aug 2018 16:07:39 +0000 (18:07 +0200)]
Remove MinGW from CI
flip1995 [Wed, 22 Aug 2018 15:47:54 +0000 (17:47 +0200)]
Remove unused code
Oliver Schneider [Fri, 20 Jul 2018 14:22:28 +0000 (16:22 +0200)]
Remove rust-toolchain file in CI
Oliver Schneider [Fri, 20 Jul 2018 08:33:46 +0000 (10:33 +0200)]
Keep the rustc master install in the travis file so we can use `travis_retry`
Oliver Schneider [Mon, 19 Mar 2018 09:48:26 +0000 (10:48 +0100)]
Try running appveyor on master instead of nightly
Lachezar Lechev [Mon, 20 Aug 2018 13:50:15 +0000 (15:50 +0200)]
#3016 Add backticks for the msg
Lachezar Lechev [Mon, 20 Aug 2018 13:33:43 +0000 (15:33 +0200)]
#3016 Add feedback and implement test for fixed hardcoded suggestion
Lachezar Lechev [Mon, 20 Aug 2018 12:03:13 +0000 (14:03 +0200)]
#3016 [WIP] Implement feedback and suggestions
Manish Goregaokar [Mon, 20 Aug 2018 02:16:54 +0000 (19:16 -0700)]
Merge pull request #3065 from rust-lang-nursery/rustup
Rustup to rustc 1.30.0-nightly (
6bf6d50a6 2018-08-19)
Manish Goregaokar [Mon, 20 Aug 2018 02:07:31 +0000 (19:07 -0700)]
Remove implied rust_2018 feature
We are already on the edition and this feature is implied.