]>
git.lizzy.rs Git - rust.git/log
Lzu Tao [Wed, 19 Jun 2019 18:36:23 +0000 (01:36 +0700)]
Fix warnings about unnecessary lifetime bounds
Rustup https://github.com/rust-lang/rust/pull/61172
bors [Wed, 19 Jun 2019 10:35:28 +0000 (10:35 +0000)]
Auto merge of #4218 - lzutao:rustup, r=phansch
Rustup
changelog: none
Lzu Tao [Wed, 19 Jun 2019 10:16:42 +0000 (17:16 +0700)]
Fix lifetime mismatch between LateContext and Ty
Lzu Tao [Wed, 19 Jun 2019 09:59:25 +0000 (16:59 +0700)]
Fix missing field in ExprKind::Yield
Rustup rust-lang/rust#61941
bors [Wed, 19 Jun 2019 07:57:27 +0000 (07:57 +0000)]
Auto merge of #4210 - dtolnay:division, r=flip1995
Downgrade integer_division to restriction
I believe that this lint falls outside of the scope of opinionated pedantism of the other pedantic lints.
changelog: Downgrade integer_division lint from pedantic to restriction
bors [Wed, 19 Jun 2019 07:19:26 +0000 (07:19 +0000)]
Auto merge of #4217 - Manishearth:clog, r=flip1995
Update changelog headings
1.36 is beta now
changelog: none
flip1995 [Wed, 19 Jun 2019 07:18:19 +0000 (09:18 +0200)]
Unify heading style
Manish Goregaokar [Tue, 18 Jun 2019 22:12:18 +0000 (15:12 -0700)]
Make headings stable
Manish Goregaokar [Tue, 18 Jun 2019 22:09:53 +0000 (15:09 -0700)]
Update changelog
bors [Tue, 18 Jun 2019 18:38:30 +0000 (18:38 +0000)]
Auto merge of #4216 - phansch:replace_nodeset, r=matthiaskrgr
Refactor: Replace NodeSet with HirIdSet
This saves us one HirId -> NodeId conversion.
changelog: none
Philipp Hansch [Tue, 18 Jun 2019 17:45:01 +0000 (19:45 +0200)]
Refactor: Replace NodeSet with HirIdSet
This saves us one HirId -> NodeId conversion.
bors [Tue, 18 Jun 2019 10:05:04 +0000 (10:05 +0000)]
Auto merge of #4215 - matthiaskrgr:rustup_9, r=flip1995
rustup https://github.com/rust-lang/rust/pull/61836/
changelog: none
Matthias Krüger [Tue, 18 Jun 2019 09:15:47 +0000 (11:15 +0200)]
rustup https://github.com/rust-lang/rust/pull/61836/
bors [Mon, 17 Jun 2019 15:18:31 +0000 (15:18 +0000)]
Auto merge of #4214 - d-dorazio:4204-fix-float-cmp-neq, r=flip1995
fix suggestion for floating point inequality
It should be of the form `(a - b).abs() > error` whereas it was `(a - b).abs() < error` that is instead what should be used for equality.
fixes #4204.
changelog: fix suggestion for floating point inequality
Daniele D'Orazio [Mon, 17 Jun 2019 14:42:41 +0000 (16:42 +0200)]
fix suggestion for floating points inequality
It should be of the form `(a - b).abs() > error` whereas it was
`(a - b).abs() < error` that is instead what should be used for equality.
David Tolnay [Sat, 15 Jun 2019 07:11:53 +0000 (00:11 -0700)]
Downgrade integer_division to restriction
bors [Fri, 14 Jun 2019 20:45:56 +0000 (20:45 +0000)]
Auto merge of #4209 - lzutao:TyCtxt-lifetime, r=Manishearth
Fix wrong lifetime of TyCtxt
Rustup rust-lang/rust#61817
changelog: none
Lzu Tao [Fri, 14 Jun 2019 16:47:48 +0000 (23:47 +0700)]
Fix wrong lifetime of TyCtxt
bors [Fri, 14 Jun 2019 12:55:22 +0000 (12:55 +0000)]
Auto merge of #4206 - rust-lang:update_lints, r=phansch
Use replace_region_in_file for creating the lint list
r? @phansch
changelog: none
flip1995 [Fri, 14 Jun 2019 08:36:43 +0000 (10:36 +0200)]
Use replace_region_in_file for creating the lint list
bors [Fri, 14 Jun 2019 08:47:43 +0000 (08:47 +0000)]
Auto merge of #4162 - krk:static-static, r=flip1995
Add lint for statics with explicit static lifetime.
changelog: Add lint for statics with explicit static lifetime, fixes #4138.
flip1995 [Fri, 14 Jun 2019 07:54:34 +0000 (09:54 +0200)]
Restructure rename tests
krk [Thu, 13 Jun 2019 21:54:05 +0000 (23:54 +0200)]
Register rename to the LintStore.
krk [Thu, 13 Jun 2019 21:47:06 +0000 (23:47 +0200)]
Rename REDUNDANT_STATIC_LIFETIME to REDUNDANT_STATIC_LIFETIMES.
Kerem [Wed, 12 Jun 2019 17:57:49 +0000 (19:57 +0200)]
Remove pub from RedundantStaticLifetime.visit_type function.
Co-Authored-By: Philipp Krones <hello@philkrones.com>
krk [Tue, 11 Jun 2019 19:52:18 +0000 (21:52 +0200)]
Rename const_static_lifetime to redundant_static_lifetime.
krk [Tue, 11 Jun 2019 19:32:38 +0000 (21:32 +0200)]
Merge StaticConst and StaticStatic lints into StaticConst.
krk [Mon, 10 Jun 2019 17:25:00 +0000 (19:25 +0200)]
Use RedundantStaticLifetime in StaticStatic.
krk [Mon, 10 Jun 2019 17:01:05 +0000 (19:01 +0200)]
Move type-checking logic in StaticConst to RedundantStaticLifetime.
krk [Sat, 1 Jun 2019 10:10:15 +0000 (12:10 +0200)]
Add lint for statics with explicit static lifetime.
bors [Thu, 13 Jun 2019 08:51:53 +0000 (08:51 +0000)]
Auto merge of #4175 - yaahallo:master, r=oli-obk
Implement better help for clippy-driver
https://github.com/rust-lang/rust-clippy/issues/4173
bors [Thu, 13 Jun 2019 05:01:02 +0000 (05:01 +0000)]
Auto merge of #4201 - mgr-inz-rafal:typos_in_docs, r=matthiaskrgr
Typos and minor grammar corrections
Just some minor grammar issues and typos in documentation.
bors [Wed, 12 Jun 2019 22:54:02 +0000 (22:54 +0000)]
Auto merge of #4200 - lzutao:tyctxt-lifetime, r=matthiaskrgr
Fix wrong lifetime of TyCtxt
Rustup https://github.com/rust-lang/rust/pull/61722
changelog: none
Lzu Tao [Wed, 12 Jun 2019 17:27:14 +0000 (00:27 +0700)]
Fix wrong lifetime of TyCtxt
Lzu Tao [Wed, 12 Jun 2019 19:18:54 +0000 (02:18 +0700)]
travis: Wait at most 30 minutes for base test
Sometimes travis gets slow and makes the builds spurious failure because
of no output in 10 minutes. This commit increase Travis timing-out time
at most 30 minutes before terminating the build.
Jane Lusby [Wed, 12 Jun 2019 19:29:23 +0000 (12:29 -0700)]
minor fix
Jane Lusby [Mon, 10 Jun 2019 22:47:31 +0000 (15:47 -0700)]
make it pass dogfood
Jane Lusby [Mon, 10 Jun 2019 18:14:54 +0000 (11:14 -0700)]
run rustfmt
Jane Lusby [Mon, 10 Jun 2019 18:03:51 +0000 (11:03 -0700)]
fix padding and put clippy someplaces
Jane Lusby [Sun, 9 Jun 2019 00:08:16 +0000 (17:08 -0700)]
show default lint levels
Jane Lusby [Sat, 8 Jun 2019 21:49:33 +0000 (14:49 -0700)]
group printing
Jane Lusby [Sat, 8 Jun 2019 21:19:16 +0000 (14:19 -0700)]
prelim arg parse
Jane Lusby [Sat, 8 Jun 2019 18:47:24 +0000 (11:47 -0700)]
move Lint static def into its own module
Jane Lusby [Sat, 8 Jun 2019 18:29:27 +0000 (11:29 -0700)]
switch to sorted usable lints
Jane Lusby [Thu, 6 Jun 2019 22:19:42 +0000 (15:19 -0700)]
Update clippy_dev/src/main.rs
Co-Authored-By: Philipp Krones <hello@philkrones.com>
Jane Lusby [Wed, 5 Jun 2019 00:32:03 +0000 (17:32 -0700)]
initial commit for help improvements on clippy-driver
mgr-inz-rafal [Wed, 12 Jun 2019 18:07:10 +0000 (20:07 +0200)]
Typos and minor grammar corrections
bors [Wed, 12 Jun 2019 13:19:26 +0000 (13:19 +0000)]
Auto merge of #4195 - thiagoarrais:division-of-integer-literals, r=flip1995
Adds lint for integer division
Hi, folks! This is my first contribution to clippy and my first real piece of Rust code.
This is supposed to add a lint that warns for division of integers (#109). Please let me know if you need any changes.
Fixes #109
changelog: Add lint for integer division
Thiago Arrais [Tue, 11 Jun 2019 16:53:12 +0000 (13:53 -0300)]
Adds lint for integer division
bors [Wed, 12 Jun 2019 11:56:24 +0000 (11:56 +0000)]
Auto merge of #4191 - g-bartoszek:redundant-closure-deref, r=flip1995
redundant_closure_for_method_calls fixes
lint does not trigger when there is a difference in mutability
lint does not trigger when the method belongs to a trait which is not implemebted directly (Deref)
<!--
Thank you for making Clippy better!
We're collecting our changelog from pull request descriptions.
If your PR only updates to the latest nightly, you can leave the
`changelog` entry as `none`. Otherwise, please write a short comment
explaining your change.
If your PR fixes an issue, you can add "fixes #issue_number" into this
PR description. This way the issue will be automatically closed when
your PR is merged.
If you added a new lint, here's a checklist for things that will be
checked during review or continuous integration.
- [ ] Followed [lint naming conventions][lint_naming]
- [ ] Added passing UI tests (including committed `.stderr` file)
- [ ] `cargo test` passes locally
- [ ] Executed `util/dev update_lints`
- [ ] Added lint documentation
- [ ] Run `cargo fmt`
Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.
Delete this line and everything above before opening your PR -->
changelog: none
Grzegorz [Sun, 9 Jun 2019 11:24:34 +0000 (13:24 +0200)]
redundant_closure_for_method_calls fixes:
lint does not trigger when there is a difference in mutability
lint does not trigger when the method belongs to a trait which is not implemebted directly (Deref)
bors [Wed, 12 Jun 2019 09:58:24 +0000 (09:58 +0000)]
Auto merge of #4199 - flip1995:implicit_return_docs, r=flip1995
Fix implicit_return docs
Resolves #4197
changelog: none
bors [Wed, 12 Jun 2019 09:29:00 +0000 (09:29 +0000)]
Auto merge of #4198 - matthiaskrgr:rustup_8, r=flip1995
rustup
changelog: none
cc @lzutao
r? @phansch
flip1995 [Wed, 12 Jun 2019 08:51:14 +0000 (10:51 +0200)]
Fix implicit_return docs
Matthias Krüger [Wed, 12 Jun 2019 08:28:58 +0000 (10:28 +0200)]
rustup https://github.com/rust-lang/rust/pull/61758/files
Lzu Tao [Wed, 12 Jun 2019 03:07:48 +0000 (10:07 +0700)]
Remove wrong lifetime from LintContext
bors [Mon, 10 Jun 2019 19:03:18 +0000 (19:03 +0000)]
Auto merge of #4190 - projedi:fix-eta, r=flip1995
Fixing eta with respect to lazy evaluation.
This fixes #4187
changelog: `redundant_closure`: stop linting on expressions returning a function, which is then directly used by the closure
Alexander Shabalin [Mon, 10 Jun 2019 17:19:29 +0000 (20:19 +0300)]
Workaround for rust-lang/rustfmt#3615
Alexander Shabalin [Mon, 10 Jun 2019 09:22:33 +0000 (12:22 +0300)]
Fixing eta with respect to lazy evaluation.
bors [Sun, 9 Jun 2019 18:59:35 +0000 (18:59 +0000)]
Auto merge of #4188 - matthiaskrgr:rustup_7, r=Manishearth
rustup https://github.com/rust-lang/rust/pull/61669/
changelog: none
Matthias Krüger [Sun, 9 Jun 2019 18:53:24 +0000 (20:53 +0200)]
travis: disable rls integration test.
Matthias Krüger [Sun, 9 Jun 2019 13:21:28 +0000 (15:21 +0200)]
rustup https://github.com/rust-lang/rust/pull/61669/
bors [Sat, 8 Jun 2019 14:00:02 +0000 (14:00 +0000)]
Auto merge of #4185 - mikerite:outer_expn_info, r=Manishearth
Add OUTER_EXPN_INFO lint
changelog: none
Michael Wright [Sat, 8 Jun 2019 11:32:43 +0000 (13:32 +0200)]
Add OUTER_EXPN_INFO lint
bors [Thu, 6 Jun 2019 10:25:13 +0000 (10:25 +0000)]
Auto merge of #4177 - mikerite:compiler_lint_functions_fewer_strings, r=phansch
Remove `to_string()`s from CompilerLintFunctions
changelog: none
bors [Thu, 6 Jun 2019 08:26:48 +0000 (08:26 +0000)]
Auto merge of #4136 - euclio:println-writeln-suggestions, r=flip1995
add suggestions for print/write with newline lint
changelog: Add machine-applicable suggestions for `print!`/`write!` with newline lints.
bors [Thu, 6 Jun 2019 07:28:10 +0000 (07:28 +0000)]
Auto merge of #4178 - matthiaskrgr:rustup_6, r=oli-obk
rustup https://github.com/rust-lang/rust/pull/57428/
changelog: none
Matthias Krüger [Thu, 6 Jun 2019 07:21:19 +0000 (09:21 +0200)]
rustup https://github.com/rust-lang/rust/pull/57428/
Michael Wright [Thu, 6 Jun 2019 05:12:12 +0000 (07:12 +0200)]
Remove `to_string()`s from CompilerLintFunctions
bors [Tue, 4 Jun 2019 06:28:23 +0000 (06:28 +0000)]
Auto merge of #4164 - mikerite:fix-4144, r=mikerite
Fix .map(..).unwrap_or_else(..) bad suggestion
Closes #4144
mikerite [Tue, 4 Jun 2019 06:27:31 +0000 (08:27 +0200)]
Fix comment grammar
Co-Authored-By: Philipp Krones <hello@philkrones.com>
bors [Mon, 3 Jun 2019 09:39:23 +0000 (09:39 +0000)]
Auto merge of #4168 - lzutao:fix-script, r=flip1995
Do not install rustup-toolchain if it is in PATH
I find it quiet annoying because I manually build `rustup-toolchain-install-master`
and install it in `PATH` other than in `~/.cargo/bin`. So everytime I run the script,
it always reinstall `rustup-toolchain-install-master` for me.
changelog: none
bors [Mon, 3 Jun 2019 08:28:15 +0000 (08:28 +0000)]
Auto merge of #4165 - BO41:needless_range_loop, r=phansch
Add example to needless_range_loop
adds a "could be written as" example
btw, is it correct that the lint triggers even if the index is used not just for getting the values by index?
So that I have to add `.iter().enumerate()` to still get an index?
changelog: none
bors [Mon, 3 Jun 2019 07:59:30 +0000 (07:59 +0000)]
Auto merge of #4163 - lzutao:doc-fix-foo-example, r=phansch
doc: Remove `pub` from trait definition in foo lint example
changelog: none
bors [Mon, 3 Jun 2019 02:39:06 +0000 (02:39 +0000)]
Auto merge of #4169 - lzutao:bump-cargo_metadata, r=Manishearth
Bump cargo metadata
Sorry, I forgot to bump `cargo_metadata` in sub-crates.
changelog: none
r? @matthiaskrgr
Lzu Tao [Mon, 3 Jun 2019 02:36:23 +0000 (09:36 +0700)]
Bump clap in clippy_dev
Lzu Tao [Mon, 3 Jun 2019 02:23:15 +0000 (09:23 +0700)]
Do not install rustup-toolchain if it is in PATH
Lzu Tao [Mon, 3 Jun 2019 02:13:33 +0000 (09:13 +0700)]
Bump cargo_metadata of clippy_lints
BO41 [Sun, 2 Jun 2019 18:06:50 +0000 (20:06 +0200)]
Change from ignore to rust
bors [Sun, 2 Jun 2019 17:07:33 +0000 (17:07 +0000)]
Auto merge of #4166 - mati865:rustup, r=Manishearth
Rustup for https://github.com/rust-lang/rust/pull/61276
changelog: none
Mateusz Mikuła [Sun, 2 Jun 2019 16:58:11 +0000 (18:58 +0200)]
Cargo fmt
Mateusz Mikuła [Sun, 2 Jun 2019 16:30:40 +0000 (18:30 +0200)]
Rustup for https://github.com/rust-lang/rust/pull/61276
BO41 [Sun, 2 Jun 2019 13:28:32 +0000 (15:28 +0200)]
Add example to needless_range_loop
bors [Sun, 2 Jun 2019 13:11:34 +0000 (13:11 +0000)]
Auto merge of #4160 - lzutao:bump-cargo_metadata, r=matthiaskrgr
Bump cargo_metadata to 0.8.0
changelog: none
bors [Sun, 2 Jun 2019 10:01:50 +0000 (10:01 +0000)]
Auto merge of #4159 - lzutao:into-outer_expn_info, r=matthiaskrgr
Make use of new `outer_expn_info()` function
Find by simple command: `git grep -w expn_info`.
changelog: none
Closes #4151
Michael Wright [Sun, 2 Jun 2019 06:47:06 +0000 (08:47 +0200)]
Fix .map(..).unwrap_or_else(..) bad suggestion
Closes #4144
Lzu Tao [Sat, 1 Jun 2019 12:51:49 +0000 (19:51 +0700)]
doc: Remove `pub` from trait definition in foo lint example
Lzu Tao [Sat, 1 Jun 2019 09:49:10 +0000 (16:49 +0700)]
Bump cargo_metadata to 0.8.0
Lzu Tao [Sat, 1 Jun 2019 09:25:51 +0000 (16:25 +0700)]
Make use of new `outer_expn_info()` function
bors [Sat, 1 Jun 2019 05:57:58 +0000 (05:57 +0000)]
Auto merge of #4158 - phansch:rustup_tests, r=Manishearth
Fix ellipsis_inclusive_range_patterns lint warnings
Changed from `allow` to `warn` in https://github.com/rust-lang/rust/pull/61342
changelog: none
Philipp Hansch [Sat, 1 Jun 2019 05:54:47 +0000 (07:54 +0200)]
Fix ellipsis_inclusive_range_patterns lint warnings
Changed from `allow` to `warn` in https://github.com/rust-lang/rust/pull/61342
Andy Russell [Thu, 23 May 2019 18:11:38 +0000 (14:11 -0400)]
add suggestions for print/write with newline lint
bors [Thu, 30 May 2019 12:07:48 +0000 (12:07 +0000)]
Auto merge of #4157 - phansch:update_pulldown_cmark2, r=matthiaskrgr
Update pulldown_cmark to 0.5.2
Includes various parsing fixes. Most notably [this PR][pr]
changelog: none
[pr]: https://github.com/raphlinus/pulldown-cmark/pull/325
bors [Thu, 30 May 2019 10:34:56 +0000 (10:34 +0000)]
Auto merge of #4113 - rust-lang:author, r=flip1995
Fix `Block` dump in author lint
changelog: The `#[clippy::author]` attribute now emits correct pattern code for block expressions
Philipp Hansch [Thu, 30 May 2019 10:26:22 +0000 (12:26 +0200)]
Update pulldown_cmark to 0.5.2
Includes various parsing fixes. Most notably [this PR][pr]
[pr]: https://github.com/raphlinus/pulldown-cmark/pull/325
bors [Thu, 30 May 2019 07:29:28 +0000 (07:29 +0000)]
Auto merge of #4155 - phansch:rustup_trait_obj, r=oli-obk
Rustup to https://github.com/rust-lang/rust/pull/61203
See https://github.com/rust-lang/rust/pull/61203
Migrates all trait objects to use `dyn` in our ui tests
changelog: none
Philipp Hansch [Thu, 30 May 2019 06:23:47 +0000 (08:23 +0200)]
Rustup to https://github.com/rust-lang/rust/pull/61203
Migrates all trait objects to use `dyn`
bors [Wed, 29 May 2019 20:01:57 +0000 (20:01 +0000)]
Auto merge of #4153 - matthiaskrgr:rustup_5, r=flip1995
rustup https://github.com/rust-lang/rust/pull/60928
changelog: none
Matthias Krüger [Tue, 28 May 2019 22:41:34 +0000 (00:41 +0200)]
rustup https://github.com/rust-lang/rust/pull/60928
bors [Tue, 28 May 2019 22:26:50 +0000 (22:26 +0000)]
Auto merge of #4152 - matthiaskrgr:rustup_4, r=matthiaskrgr
rustup https://github.com/rust-lang/rust/pull/61164
(which is included in https://github.com/rust-lang/rust/pull/61274)
changelog: none