]>
git.lizzy.rs Git - rust.git/log
bors [Mon, 15 Jul 2019 05:20:34 +0000 (05:20 +0000)]
Auto merge of #3418 - phansch:add_travis_windows_build, r=me,flip1995
Fix Travis Windows build
Closes #3306
flip1995 [Sun, 14 Jul 2019 13:21:50 +0000 (15:21 +0200)]
Disable dogfood on windows for faster build time on travis
flip1995 [Sun, 14 Jul 2019 13:13:47 +0000 (15:13 +0200)]
Revert "Remove `CARGO_INCREMENTAL=0` from windows build"
This reverts commit
876a7e1f01cb14a63eee54cb44524a87161d5454 .
Using incremental build on windows increases the build time on travis by
about 8 minutes.
flip1995 [Sat, 13 Jul 2019 11:26:26 +0000 (13:26 +0200)]
Remove `CARGO_INCREMENTAL=0` from windows build
flip1995 [Sat, 13 Jul 2019 09:42:44 +0000 (11:42 +0200)]
Test with different sysroots dependent on the OS
flip1995 [Fri, 12 Jul 2019 12:13:15 +0000 (14:13 +0200)]
Build sys_root in driver with PathBuf instead of String
flip1995 [Fri, 12 Jul 2019 10:12:53 +0000 (12:12 +0200)]
Don't re-set the LD_LIBRARY_PATH in base_tests.sh
flip1995 [Fri, 12 Jul 2019 08:58:06 +0000 (10:58 +0200)]
Add master toolchain binaries to the PATH
Philipp Hansch [Wed, 28 Nov 2018 06:29:05 +0000 (07:29 +0100)]
Change conditional
Maybe uname == Linux was true on the windows VM?
This could be a way to avoid the secret environment variable issue with
Travis CI.
Philipp Hansch [Fri, 9 Nov 2018 06:13:34 +0000 (07:13 +0100)]
Stop allowing failures in Travis windows build
bors [Sat, 13 Jul 2019 10:05:15 +0000 (10:05 +0000)]
Auto merge of #4229 - euclio:lint-doc-generation-fix, r=flip1995
don't strip blank lines in lint documentation
changelog: don't strip blank lines in lint documentation
Fixes #4116.
This PR also switches the docs headings to deterministically display in the order that they are declared in the source, with "Configuration" always appearing last. It doesn't seem like there was a defined order before.
bors [Sat, 13 Jul 2019 09:26:16 +0000 (09:26 +0000)]
Auto merge of #4232 - mikerite:dev-fmt-4, r=flip1995
Add dev fmt subcommand
changelog: none
bors [Sat, 13 Jul 2019 08:59:12 +0000 (08:59 +0000)]
Auto merge of #4268 - mikerite:fix-4260, r=flip1995
Fix bug in `implicit_hasher` causing crashes
Skip linting if the type is from an external macro. Closes #4260.
changelog: Fix bug in `implicit_hasher` causing crashes
Michael Wright [Sat, 13 Jul 2019 07:20:54 +0000 (09:20 +0200)]
Merge branch 'master' into dev-fmt-4
bors [Fri, 12 Jul 2019 07:26:03 +0000 (07:26 +0000)]
Auto merge of #4269 - lzutao:rustup, r=flip1995
Rustup `macro expansion and resolution`
Rustup https://github.com/rust-lang/rust/pull/62476
changelog: none
Lzu Tao [Thu, 11 Jul 2019 14:45:34 +0000 (21:45 +0700)]
Rustup `macro expansion and resolution`
Michael Wright [Thu, 11 Jul 2019 06:47:05 +0000 (08:47 +0200)]
Fix bug in `implicit_hasher` causing crashes
Skip linting if the type is from an external macro. Closes #4260.
Michael Wright [Thu, 11 Jul 2019 05:21:44 +0000 (05:21 +0000)]
Avoid rustfmt bug on Windows
bors [Tue, 9 Jul 2019 15:28:26 +0000 (15:28 +0000)]
Auto merge of #4257 - skade:improve-cast-alignment, r=flip1995
Improve cast_ptr_alignment lint
<!--
Thank you for making Clippy better!
We're collecting our changelog from pull request descriptions.
If your PR only updates to the latest nightly, you can leave the
`changelog` entry as `none`. Otherwise, please write a short comment
explaining your change.
If your PR fixes an issue, you can add "fixes #issue_number" into this
PR description. This way the issue will be automatically closed when
your PR is merged.
If you added a new lint, here's a checklist for things that will be
checked during review or continuous integration.
- [x] Followed [lint naming conventions][lint_naming]
- [x] Added passing UI tests (including committed `.stderr` file)
- [x] `cargo test` passes locally
- [x] Executed `util/dev update_lints`
- [x] Added lint documentation
- [x] Run `cargo fmt`
Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.
Delete this line and everything above before opening your PR -->
* print alignment in bytes in the lint message
* ignore ZST left-hand types
Fixes #3797 and #4256
changelog:
* `cast_ptr_alignment`: Print alignment in bytes in the lint message
* `cast_ptr_alignment`: Ignore casting from ZST left-hand types
Florian Gilcher [Sat, 6 Jul 2019 09:40:14 +0000 (11:40 +0200)]
Improve cast_ptr_alignment lint
* print alignment in bytes in the lint message
* ignore ZST left-hand types
bors [Tue, 9 Jul 2019 13:15:29 +0000 (13:15 +0000)]
Auto merge of #4265 - vks:patch-1, r=flip1995
cast_ptr_alignment: Mention legal use under known problems
Refs #2881.
changelog: Mention know problems for cast_ptr_alignment
Vinzent Steinberg [Tue, 9 Jul 2019 12:48:48 +0000 (14:48 +0200)]
cast_ptr_alignment: Mention legal use under known problems
Refs #2881.
bors [Tue, 9 Jul 2019 11:40:43 +0000 (11:40 +0000)]
Auto merge of #4264 - flip1995:appveyor, r=flip1995
Disable AppVeyor builds on the master branch
AppVeyor is already checked on every merge of a PR, rechecking it
immediately after on the master branch is not necessary.
Resolves #4263
changelog: none
flip1995 [Tue, 9 Jul 2019 11:34:22 +0000 (13:34 +0200)]
Disable AppVeyor builds on the master branch
AppVeyor is already checked on every merge of a PR, rechecking it
immediately after on the master branch is not necessary.
bors [Tue, 9 Jul 2019 09:48:33 +0000 (09:48 +0000)]
Auto merge of #4233 - thiagoarrais:jens1o-fix-1208, r=phansch,flip1995
Avoid reporting string_lit_as_bytes for long strings
Port of @jens1o code ([
b76f939 ][jens1o_commit])
Fixes #1208
[jens1o_commit]: https://github.com/jens1o/rust-clippy/commit/
b76f939ac2efcfe24900c286b3b7713d972d9088
<!--
Thank you for making Clippy better!
We're collecting our changelog from pull request descriptions.
If your PR only updates to the latest nightly, you can leave the
`changelog` entry as `none`. Otherwise, please write a short comment
explaining your change.
If your PR fixes an issue, you can add "fixes #issue_number" into this
PR description. This way the issue will be automatically closed when
your PR is merged.
If you added a new lint, here's a checklist for things that will be
checked during review or continuous integration.
- [ ] Followed [lint naming conventions][lint_naming]
- [ ] Added passing UI tests (including committed `.stderr` file)
- [ ] `cargo test` passes locally
- [ ] Executed `util/dev update_lints`
- [ ] Added lint documentation
- [ ] Run `cargo fmt`
Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.
Delete this line and everything above before opening your PR -->
changelog: bugfix for long strings as bytes
bors [Tue, 9 Jul 2019 09:10:07 +0000 (09:10 +0000)]
Auto merge of #4262 - bara86:master, r=flip1995
Use empty block instead of unit type for needless return
fixes #4238
changelog: Use empty block instead of unit type for needless return
Thiago Arrais [Mon, 8 Jul 2019 16:12:51 +0000 (13:12 -0300)]
Extract semantic constant
Bara [Mon, 8 Jul 2019 18:45:51 +0000 (20:45 +0200)]
Use empty block instead of unit type for needless return
Jens Hausdorf [Sun, 10 Mar 2019 10:06:19 +0000 (11:06 +0100)]
Avoid reporting string_lit_as_bytes for long strings
Port of @jens1o code ([
b76f939 ][jens1o_commit])
Fixes #1208
[jens1o_commit]: https://github.com/jens1o/rust-clippy/commit/
b76f939ac2efcfe24900c286b3b7713d972d9088
Co-authored-by: Thiago Arrais <thiago.arrais@gmail.com>
Michael Wright [Mon, 8 Jul 2019 05:20:11 +0000 (07:20 +0200)]
Add rustfmt nightly to appveyor install
Michael Wright [Fri, 5 Jul 2019 05:49:19 +0000 (07:49 +0200)]
Work around rustup fallback error on Windows
flip1995 [Thu, 4 Jul 2019 12:35:27 +0000 (14:35 +0200)]
Update documentation to the dev fmt command
Michael Wright [Thu, 4 Jul 2019 04:35:33 +0000 (06:35 +0200)]
Remove format checks from CI scripts again.
Michael Wright [Wed, 3 Jul 2019 05:35:55 +0000 (07:35 +0200)]
Remove format checks from CI script
Michael Wright [Wed, 26 Jun 2019 04:08:33 +0000 (06:08 +0200)]
Improve fmt test failure message
Michael Wright [Tue, 25 Jun 2019 05:30:29 +0000 (07:30 +0200)]
Fix crash on `dev --limit-stderr-length`
Michael Wright [Tue, 25 Jun 2019 04:43:38 +0000 (06:43 +0200)]
Add dev fmt subcommand
bors [Sun, 7 Jul 2019 02:25:07 +0000 (02:25 +0000)]
Auto merge of #4258 - mikerite:fix-breakage-
20190706 , r=Manishearth
Fix breakage due to rust-lang/rust#61988
changelog: none
Michael Wright [Sat, 6 Jul 2019 17:43:34 +0000 (19:43 +0200)]
rustfmt
Michael Wright [Sat, 6 Jul 2019 17:35:08 +0000 (19:35 +0200)]
Address reviews
Michael Wright [Sat, 6 Jul 2019 17:06:49 +0000 (19:06 +0200)]
Fix breakage due to rust-lang/rust#61988
bors [Sat, 6 Jul 2019 07:19:20 +0000 (07:19 +0000)]
Auto merge of #4255 - mikerite:fix-warnings-
20190706 , r=Manishearth
Fix unknown lint warnings
changelog: none
Michael Wright [Sat, 6 Jul 2019 07:15:48 +0000 (09:15 +0200)]
Fix unknown lint warnings
bors [Sat, 6 Jul 2019 06:30:15 +0000 (06:30 +0000)]
Auto merge of #4254 - lzutao:hiridification-62168, r=Manishearth
Rustup HirIdification
Rustup https://github.com/rust-lang/rust/pull/62168
changelog: none
Lzu Tao [Sat, 6 Jul 2019 05:30:11 +0000 (12:30 +0700)]
Remove lint for ONCE_INIT
ONCE_INIT will be deprecated in rust 1.38.0
Lzu Tao [Sat, 6 Jul 2019 04:04:03 +0000 (04:04 +0000)]
Update rustfix tests
Lzu Tao [Sat, 6 Jul 2019 03:52:51 +0000 (10:52 +0700)]
Rename hir::map::local_def_id_from_hir_id to local_def_id
bors [Thu, 4 Jul 2019 08:30:18 +0000 (08:30 +0000)]
Auto merge of #4252 - mikerite:fix-unused-import-
20190704 , r=flip1995
Remove unused import
changelog: none
Michael Wright [Thu, 4 Jul 2019 04:49:31 +0000 (06:49 +0200)]
Remove unused import
bors [Wed, 3 Jul 2019 20:22:46 +0000 (20:22 +0000)]
Auto merge of #4251 - matthiaskrgr:rustup_10, r=Manishearth
rustup https://github.com/rust-lang/rust/pull/61995
changelog: none
Matthias Krüger [Wed, 3 Jul 2019 16:00:35 +0000 (18:00 +0200)]
rustup https://github.com/rust-lang/rust/pull/61995
bors [Wed, 3 Jul 2019 07:03:49 +0000 (07:03 +0000)]
Auto merge of #4250 - mikerite:fix-3992, r=phansch
Fix allow bug in `trivially_copy_pass_by_ref`
Closes #3992
changelog: Fix allow bug in `trivially_copy_pass_by_ref`
bors [Wed, 3 Jul 2019 06:36:32 +0000 (06:36 +0000)]
Auto merge of #4249 - matthiaskrgr:license_url, r=phansch
readme: fix urls in the license
The ">" at the end was detected as part of the url and caused it to 404.
changelog: none
Michael Wright [Wed, 3 Jul 2019 05:15:21 +0000 (07:15 +0200)]
Fix allow bug in `trivially_copy_pass_by_ref`
Closes #3992
Matthias Krüger [Tue, 2 Jul 2019 18:06:18 +0000 (20:06 +0200)]
readme: fix urls in the license
bors [Tue, 2 Jul 2019 07:25:21 +0000 (07:25 +0000)]
Auto merge of #4246 - mikerite:fix-4244, r=flip1995
Fix `match_same_arms` false negative
Closes #4244
changelog: Fix `match_same_arms` false negative
Michael Wright [Tue, 2 Jul 2019 06:08:28 +0000 (08:08 +0200)]
Fix `match_same_arms` false negative
Closes #4244
bors [Mon, 1 Jul 2019 13:58:48 +0000 (13:58 +0000)]
Auto merge of #4245 - flip1995:ice_4121, r=matthiaskrgr
Test for melted ICE #4121
resolves #4121
r? @matthiaskrgr
changelog: none
flip1995 [Mon, 1 Jul 2019 13:56:06 +0000 (15:56 +0200)]
Reenable cargo and rls tests in travis
flip1995 [Mon, 1 Jul 2019 13:53:48 +0000 (15:53 +0200)]
Test for melted ICE #4121
bors [Mon, 1 Jul 2019 08:10:25 +0000 (08:10 +0000)]
Auto merge of #4243 - mikerite:fix-4058, r=flip1995
Fix `never_loop` false positive
Closes #4058
changelog: none
bors [Mon, 1 Jul 2019 07:41:33 +0000 (07:41 +0000)]
Auto merge of #4222 - jfrikker:try_err, r=flip1995
Adding try_err lint
changelog: Adds the "try_err" lint, which catches instances of the following: Err(x)?
fixes #4212
Michael Wright [Mon, 1 Jul 2019 05:16:32 +0000 (07:16 +0200)]
Fix `never_loop` false positive
Closes #4058
Joe Frikker [Sun, 30 Jun 2019 22:28:12 +0000 (18:28 -0400)]
Running rustfmt on test
bors [Sun, 30 Jun 2019 13:14:38 +0000 (13:14 +0000)]
Auto merge of #4240 - alex:uninit-intrinsic-prep, r=Manishearth
Removed use of intrinsics::uninit from tests.
This is in preperation for https://github.com/rust-lang/rust/pull/62150
Also allows deprecations in preperations for intrinsics::init being deprecated, which is a planned future step.
changelog: none
Alex Gaynor [Sat, 29 Jun 2019 13:34:42 +0000 (09:34 -0400)]
Removed use of intrinsics::uninit from tests.
This is in preperation for https://github.com/rust-lang/rust/pull/62150
Also allows deprecations in preperations for intrinsics::init being deprecated, which is a planned future step.
bors [Tue, 25 Jun 2019 22:35:35 +0000 (22:35 +0000)]
Auto merge of #4235 - Manishearth:rustup, r=Manishearth
Rustup to
5f9c0448dde167128d668da4555879f64e56af1d
Fixes fallout from https://github.com/rust-lang/rust/pull/62091/files
changelog: none
Manish Goregaokar [Tue, 25 Jun 2019 21:41:10 +0000 (14:41 -0700)]
fmt
Manish Goregaokar [Tue, 25 Jun 2019 21:34:47 +0000 (14:34 -0700)]
Remove a hir_to_node_id
Manish Goregaokar [Tue, 25 Jun 2019 21:34:07 +0000 (14:34 -0700)]
find_by_hir_id -> find
Manish Goregaokar [Tue, 25 Jun 2019 21:33:51 +0000 (14:33 -0700)]
get_parent_node_by_hir_id -> get_parent_node
Joe Frikker [Tue, 25 Jun 2019 01:28:46 +0000 (21:28 -0400)]
Making try_err machine applicable
bors [Mon, 24 Jun 2019 16:27:01 +0000 (16:27 +0000)]
Auto merge of #4230 - flip1995:unsugar_if, r=Manishearth
Replace `unsugar_if` function with `is_if` function
cc https://github.com/rust-lang/rust-clippy/pull/4123#discussion_r296581719
changelog: none
r? @Manishearth
flip1995 [Mon, 24 Jun 2019 07:51:19 +0000 (09:51 +0200)]
Simplify unsugar_if to just an if expr check
flip1995 [Mon, 24 Jun 2019 07:39:12 +0000 (09:39 +0200)]
Remove ast:: prefix from types
bors [Mon, 24 Jun 2019 05:21:52 +0000 (05:21 +0000)]
Auto merge of #4123 - Centril:rustup-let-chains-ast, r=Manishearth
Fix fallout from rust-lang/rust PR 60861
Fixes incoming breakage for unlanded https://github.com/rust-lang/rust/pull/60861.
Tests are passing locally; the Rust PR now needs to land first.
@Manishearth also says we'll want to split out to a `collapsible_if_let` once we have let-chains working in Rust nightly or something.
Mazdak Farrokhzad [Mon, 24 Jun 2019 05:20:52 +0000 (07:20 +0200)]
Put 'if let' back into comment.
Mazdak Farrokhzad [Mon, 24 Jun 2019 02:54:23 +0000 (04:54 +0200)]
Pacify rustfmt.
Mazdak Farrokhzad [Mon, 24 Jun 2019 02:00:05 +0000 (04:00 +0200)]
Fix dogfood test failures.
Joe Frikker [Sat, 22 Jun 2019 20:34:07 +0000 (16:34 -0400)]
PR comments
Andy Russell [Sun, 23 Jun 2019 19:57:37 +0000 (15:57 -0400)]
don't strip blank lines in lint documentation
Mazdak Farrokhzad [Tue, 21 May 2019 06:17:47 +0000 (08:17 +0200)]
Account for let_chains in collapsible_if ui test cases.
Mazdak Farrokhzad [Tue, 21 May 2019 05:43:43 +0000 (07:43 +0200)]
Fix fallout from rust-lang/rust PR 60861.
Joe Frikker [Wed, 19 Jun 2019 03:22:51 +0000 (23:22 -0400)]
Adding try_err lint
bors [Sat, 22 Jun 2019 09:38:53 +0000 (09:38 +0000)]
Auto merge of #4220 - d-dorazio:4182-needless-return-void-functions, r=flip1995
make needless_return work with void functions
fixes https://github.com/rust-lang/rust-clippy/issues/4181.
changelog: make needless_return work with void functions.
I don't think the failure is related to my changes, but I'm not sure :thinking:
bors [Sat, 22 Jun 2019 08:42:09 +0000 (08:42 +0000)]
Auto merge of #4227 - lzutao:node-pruning, r=flip1995
Fix fallout cause NodeId pruning
Rustup rust-lang/rust#61984
changelog: none
Lzu Tao [Sat, 22 Jun 2019 06:41:16 +0000 (13:41 +0700)]
Fix fallout cause NodeId pruning
Daniele D'Orazio [Fri, 21 Jun 2019 14:47:34 +0000 (16:47 +0200)]
cargo fmt
bors [Fri, 21 Jun 2019 13:47:13 +0000 (13:47 +0000)]
Auto merge of #4225 - jeremystucki:refactoring, r=flip1995
Remove needless lifetimes
changelog: none
Daniele D'Orazio [Fri, 21 Jun 2019 12:46:34 +0000 (14:46 +0200)]
more idiomatic code
bors [Fri, 21 Jun 2019 12:43:15 +0000 (12:43 +0000)]
Auto merge of #3919 - matthiaskrgr:readme_3, r=flip1995
readme: update
Remove the crates.io badge from the readme.
Installing clippy via crates.io is deprecated and rustup should be used instead, thus we should not promote crates.io here.
Don't have clippy::correctness" lint category in bold letters, I think it looks a little off.
flip1995 [Fri, 21 Jun 2019 12:41:52 +0000 (14:41 +0200)]
Remove another unnecessary lifetime
Jeremy Stucki [Fri, 21 Jun 2019 11:31:20 +0000 (13:31 +0200)]
Remove needless lifetimes
Daniele D'Orazio [Thu, 20 Jun 2019 11:44:00 +0000 (13:44 +0200)]
update tests and fix lints in clippy
Daniele D'Orazio [Wed, 19 Jun 2019 12:56:02 +0000 (14:56 +0200)]
make needless_return work with void functions
bors [Fri, 21 Jun 2019 10:33:53 +0000 (10:33 +0000)]
Auto merge of #4223 - mikerite:fix-breakage-2019-06-21, r=flip1995
Fix breakage due to rust-lang/rust#61968
<!--
Thank you for making Clippy better!
We're collecting our changelog from pull request descriptions.
If your PR only updates to the latest nightly, you can leave the
`changelog` entry as `none`. Otherwise, please write a short comment
explaining your change.
If your PR fixes an issue, you can add "fixes #issue_number" into this
PR description. This way the issue will be automatically closed when
your PR is merged.
If you added a new lint, here's a checklist for things that will be
checked during review or continuous integration.
- [ ] Followed [lint naming conventions][lint_naming]
- [ ] Added passing UI tests (including committed `.stderr` file)
- [ ] `cargo test` passes locally
- [ ] Executed `util/dev update_lints`
- [ ] Added lint documentation
- [ ] Run `cargo fmt`
Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.
Delete this line and everything above before opening your PR -->
changelog: none
flip1995 [Fri, 21 Jun 2019 10:32:39 +0000 (12:32 +0200)]
Remove unnecssary lifetime from trait_ref_of_method
Michael Wright [Fri, 21 Jun 2019 06:14:07 +0000 (08:14 +0200)]
Fix breakage due to rust-lang/rust#61968
Matthias Krüger [Thu, 4 Apr 2019 09:28:11 +0000 (11:28 +0200)]
readme: update
Remove the crates.io badge from the readme.
Installing clippy via crates.io is deprecated and rustup should be used instead, thus we should not promote crates.io here.
Don't have the entire clippy::correctness line in bold letters, I think it looks a little off.
bors [Wed, 19 Jun 2019 23:19:51 +0000 (23:19 +0000)]
Auto merge of #4221 - lzutao:redundant-lifetime, r=matthiaskrgr
Fix warnings about unnecessary lifetime bounds
Rustup https://github.com/rust-lang/rust/pull/61172
changelog: none