]>
git.lizzy.rs Git - rust.git/log
bors[bot] [Fri, 24 Apr 2020 01:28:53 +0000 (01:28 +0000)]
Merge #4101
4101: Panic proc macro srv if read request failed r=matklad a=edwin0cheng
This PR fixed a bug when the rust-analyzer is killed suddenly, the `rust-analyzer proc-macro` will become stale.
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
Edwin Cheng [Fri, 24 Apr 2020 01:27:37 +0000 (09:27 +0800)]
Refactor a bit
bors[bot] [Fri, 24 Apr 2020 00:58:44 +0000 (00:58 +0000)]
Merge #4118
4118: :arrow_up: crates (to bust the caches) r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 24 Apr 2020 00:58:21 +0000 (02:58 +0200)]
:arrow_up: crates (to bust the caches)
bors[bot] [Fri, 24 Apr 2020 00:45:34 +0000 (00:45 +0000)]
Merge #4117
4117: Honor snippet capability r=matklad a=matklad
closes #2518
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 24 Apr 2020 00:39:07 +0000 (02:39 +0200)]
Honor snippet capability
closes #2518
bors[bot] [Fri, 24 Apr 2020 00:27:38 +0000 (00:27 +0000)]
Merge #4116
4116: Make sure that adding a snippet requires corresponding capability r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 24 Apr 2020 00:26:38 +0000 (02:26 +0200)]
Make sure that adding a snippet requires corresponding capability
Aleksey Kladov [Fri, 24 Apr 2020 00:06:12 +0000 (02:06 +0200)]
Introduce internal snippet cap
Aleksey Kladov [Fri, 24 Apr 2020 00:01:23 +0000 (02:01 +0200)]
Move CompletionConfig to a separate module
bors[bot] [Thu, 23 Apr 2020 23:54:21 +0000 (23:54 +0000)]
Merge #4114
4114: Refactor completion sorting r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 23 Apr 2020 23:52:26 +0000 (01:52 +0200)]
Don't set sortText
I might be reading this wrong, but it looks like we are setting it to
essentially arbitrary string at the moment, as there are no defined
order on the items in the *set* of completions.
Aleksey Kladov [Thu, 23 Apr 2020 23:48:32 +0000 (01:48 +0200)]
Add test marks
Aleksey Kladov [Thu, 23 Apr 2020 23:46:00 +0000 (01:46 +0200)]
Introduce ActiveParameter
Aleksey Kladov [Thu, 23 Apr 2020 23:25:54 +0000 (01:25 +0200)]
Move tests to where they belong
Aleksey Kladov [Thu, 23 Apr 2020 23:24:08 +0000 (01:24 +0200)]
Refactor
Aleksey Kladov [Thu, 23 Apr 2020 23:17:33 +0000 (01:17 +0200)]
Restore CompletionItem immutability
Aleksey Kladov [Thu, 23 Apr 2020 23:08:27 +0000 (01:08 +0200)]
More functional
Aleksey Kladov [Thu, 23 Apr 2020 22:11:33 +0000 (00:11 +0200)]
Move
bors[bot] [Thu, 23 Apr 2020 21:58:52 +0000 (21:58 +0000)]
Merge #4106
4106: Fix wrong substitution code r=matklad a=flodiebold
We need to shift in when we're substituting inside a binder.
This should fix #4053 (it doesn't fix the occasional overflow that also occurs on the Diesel codebase though).
Co-authored-by: Florian Diebold <flodiebold@gmail.com>
Florian Diebold [Thu, 23 Apr 2020 18:50:14 +0000 (20:50 +0200)]
Fix wrong substitution code
We need to shift in when we're substituting inside a binder.
This should fix #4053 (it doesn't fix the occasional overflow that also occurs
on the Diesel codebase though).
bors[bot] [Thu, 23 Apr 2020 21:48:45 +0000 (21:48 +0000)]
Merge #3954
3954: Improve autocompletion by looking on the type and name r=matklad a=bnjjj
This tweet (https://twitter.com/tjholowaychuk/status/
1248918374731714560 ) gaves me the idea to implement that in rust-analyzer.
Basically for this first example I made some examples when we are in a function call definition. I look on the parameter list to prioritize autocompletions for the same types and if it's the same type + the same name then it's displayed first in the completion list.
So here is a draft, first step to open a discussion and know what you think about the implementation. It works (cf tests) but maybe I can make a better implementation at some places. Be careful the code needs some refactoring to be better and concise.
PS: It was lot of fun writing this haha
Co-authored-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
bors[bot] [Thu, 23 Apr 2020 21:37:06 +0000 (21:37 +0000)]
Merge #4111 #4112
4111: Record definitions in `extern` blocks r=jonas-schievink a=jonas-schievink
Enables completion of extern functions and statics.
Closes https://github.com/rust-analyzer/rust-analyzer/issues/3711
4112: Add Launch configuration for release build r=matklad a=jonas-schievink
The debug build takes very long until I can test anything useful, with the release build it's much quicker. Add another Run configuration for it.
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Jonas Schievink [Thu, 23 Apr 2020 21:10:14 +0000 (23:10 +0200)]
Record definitions in `extern` blocks
Jonas Schievink [Thu, 23 Apr 2020 21:29:40 +0000 (23:29 +0200)]
Add Launch configuration for release build
bors[bot] [Thu, 23 Apr 2020 21:18:41 +0000 (21:18 +0000)]
Merge #4110
4110: minor r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 23 Apr 2020 21:18:18 +0000 (23:18 +0200)]
minor
bors[bot] [Thu, 23 Apr 2020 19:24:20 +0000 (19:24 +0000)]
Merge #4108
4108: Fully get rid of SyntaxNodePtr::range r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 23 Apr 2020 19:23:36 +0000 (21:23 +0200)]
Fully get rid of SyntaxNodePtr::range
bors[bot] [Thu, 23 Apr 2020 19:06:50 +0000 (19:06 +0000)]
Merge #4107
4107: Disable onEnter command by default r=matklad a=matklad
We are transitioning from experimental to production-ready stance, so
it makes sense to disable potentially disruptive features by default.
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 23 Apr 2020 18:46:44 +0000 (20:46 +0200)]
Disable onEnter command by default
We are transitioning from experimental to production-ready stance, so
it makes sense to disable potentially disruptive features by default.
Edwin Cheng [Thu, 23 Apr 2020 17:38:58 +0000 (01:38 +0800)]
Bubble up error
bors[bot] [Thu, 23 Apr 2020 16:56:05 +0000 (16:56 +0000)]
Merge #4102
4102: Cleanup proc_macro config r=matklad a=matklad
In general, there should be no reason to call `.to_string_lossy`.
If you want to display the path, use `.display()`.
If you want to pass the path to an OS API (like std::process::Command)
than use `PathBuf` or `OsString`.
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 23 Apr 2020 16:50:25 +0000 (18:50 +0200)]
Cleanup proc_macro config
In general, there should be no reason to call `.to_string_lossy`.
If you want to display the path, use `.display()`.
If you want to pass the path to an OS API (like std::process::Command)
than use `PathBuf` or `OsString`.
bors[bot] [Thu, 23 Apr 2020 16:40:26 +0000 (16:40 +0000)]
Merge #4100
4100: Bump required rust to 1.43 r=matklad a=kjeremy
This only impacts source builds
Co-authored-by: kjeremy <kjeremy@gmail.com>
Edwin Cheng [Thu, 23 Apr 2020 16:16:17 +0000 (00:16 +0800)]
Fix typo
Edwin Cheng [Thu, 23 Apr 2020 16:06:01 +0000 (00:06 +0800)]
Panic proc macro srv if read request failed
kjeremy [Thu, 23 Apr 2020 15:56:17 +0000 (11:56 -0400)]
Bump required rust to 1.43
bors[bot] [Thu, 23 Apr 2020 15:35:31 +0000 (15:35 +0000)]
Merge #4065
4065: Complete unqualified enum names in patterns and expressions r=matklad a=nathanwhit
This PR implements the completion described in #4014.
The result looks like so for patterns:
<img width="542" alt="Screen Shot 2020-04-20 at 3 53 55 PM" src="https://user-images.githubusercontent.com/
17734409 /
79794010 -
8f529400 -831f-11ea-9673-
f838aa9bc962 .png">
and for `expr`s:
<img width="620" alt="Screen Shot 2020-04-21 at 3 51 24 PM" src="https://user-images.githubusercontent.com/
17734409 /
79908784 -
d73ded80 -83e9-11ea-991d-
921f0cb27e6f .png">
I'm not confident that the completion text itself is very robust, as it will unconditionally add completions for enum variants with the form `Enum::Variant`. This means (I believe) it would still suggest `Enum::Variant` even if the local name is changed i.e. `use Enum as Foo` or the variants are brought into scope such as through `use Enum::*`.
Co-authored-by: nathanwhit <nathan.whitaker01@gmail.com>
bors[bot] [Thu, 23 Apr 2020 14:40:07 +0000 (14:40 +0000)]
Merge #4099
4099: Remove SyntaxPtr::range from more places r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 23 Apr 2020 14:33:01 +0000 (16:33 +0200)]
Remove SyntaxPtr::range from more places
bors[bot] [Thu, 23 Apr 2020 09:49:03 +0000 (09:49 +0000)]
Merge #4093
4093: Simplify config r=matklad a=Veetaha
Co-authored-by: veetaha <veetaha2@gmail.com>
bors[bot] [Thu, 23 Apr 2020 09:32:45 +0000 (09:32 +0000)]
Merge #4094
4094: proc_macro: add ability to log to stderr and view output in vscode r=matklad a=Veetaha
r? @edwin0cheng
Co-authored-by: veetaha <veetaha2@gmail.com>
bors[bot] [Thu, 23 Apr 2020 09:24:15 +0000 (09:24 +0000)]
Merge #4092
4092: feat: run ignored tests r=matklad a=hdevalke
I started making some exercices on https://exercism.io/ and a lot of test have the `#[ignore]` attribute.
The `Run Test|Debug` code lens show up, but running the test results in:
```
running 1 test
test test_one_piece ... ignored
test result: ok. 0 passed; 0 failed; 1 ignored; 0 measured; 5 filtered out
```
This pull request adds the `--ignored` flag if needed.
Co-authored-by: Hannes De Valkeneer <hannes@de-valkeneer.be>
bors[bot] [Thu, 23 Apr 2020 09:11:56 +0000 (09:11 +0000)]
Merge #4098
4098: Add YouCompleteMe as a LSP option for vim/neovim r=matklad a=weihanglo
As YouCompleteMe supports [arbitrary LSP implementation](https://ycm-core.github.io/YouCompleteMe/#plugging-an-arbitrary-lsp-server), it could be added to the list of vim LSP implementation. It works like a charm.
Co-authored-by: Weihang Lo <weihanglo@users.noreply.github.com>
Weihang Lo [Thu, 23 Apr 2020 09:09:37 +0000 (17:09 +0800)]
Add YouCompleteMe as a LSP option for vim/neovim
bors[bot] [Thu, 23 Apr 2020 08:55:07 +0000 (08:55 +0000)]
Merge #4096
4096: tasks.json Support r=matklad a=jcdickinson
Move the task provider anonymous class into a real class, as this seems to be how Microsoft do this in their documentation.
resolveTask is now implemented, which is used by VSCode to determine how to execute tasks that the user has defined in tasks.json.
Resolves #3983
Co-authored-by: Jonathan Dickinson <jonathanD@k2.com>
bors[bot] [Thu, 23 Apr 2020 05:35:12 +0000 (05:35 +0000)]
Merge #4095
4095: Fix typo r=edwin0cheng a=Veetaha
Co-authored-by: veetaha <veetaha2@gmail.com>
Jonathan Dickinson [Thu, 23 Apr 2020 00:05:04 +0000 (17:05 -0700)]
tasks.json Support
Move the task provider anonymous class into a real class, as this seems
to be how Microsoft do this in their documentation.
resolveTask is now implemented, which is used by VSCode to determine how
to execute tasks that the user has defined in tasks.json.
veetaha [Wed, 22 Apr 2020 23:00:56 +0000 (02:00 +0300)]
Fix typo
veetaha [Wed, 22 Apr 2020 22:57:02 +0000 (01:57 +0300)]
proc_macro: add ability to log to stderr and view output in vscode
veetaha [Wed, 22 Apr 2020 22:30:55 +0000 (01:30 +0300)]
Simplify config
Hannes De Valkeneer [Wed, 22 Apr 2020 20:52:12 +0000 (22:52 +0200)]
feat: run ignored tests
nathanwhit [Mon, 20 Apr 2020 19:49:50 +0000 (15:49 -0400)]
Update tests to reflect new completions
nathanwhit [Mon, 20 Apr 2020 19:29:53 +0000 (15:29 -0400)]
Add tests for enum completion
Adds tests for completion of enum variants in match arms, if-let statements, and basic expressions.
nathanwhit [Mon, 20 Apr 2020 18:01:30 +0000 (14:01 -0400)]
Complete unqualified enum variants when possible
nathanwhit [Tue, 21 Apr 2020 18:28:49 +0000 (14:28 -0400)]
Add utility fn for expected type of a node
Adds `expected_type_of` to `CompletionContext` to return the expected type of a
node, if it is known.
bors[bot] [Wed, 22 Apr 2020 15:26:47 +0000 (15:26 +0000)]
Merge #4090
4090: Fix config naming r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 22 Apr 2020 15:22:59 +0000 (17:22 +0200)]
Align the name of proc-macro enabling flag
We use `enable`, not `enabled` elsewhere
Aleksey Kladov [Wed, 22 Apr 2020 15:22:18 +0000 (17:22 +0200)]
Match implementation of diagnostics flag to the docs
bors[bot] [Wed, 22 Apr 2020 15:05:15 +0000 (15:05 +0000)]
Merge #4089
4089: npm update r=kjeremy a=kjeremy
Co-authored-by: kjeremy <kjeremy@gmail.com>
kjeremy [Wed, 22 Apr 2020 14:58:50 +0000 (10:58 -0400)]
npm update
bors[bot] [Wed, 22 Apr 2020 14:54:30 +0000 (14:54 +0000)]
Merge #4088
4088: cargo update r=kjeremy a=kjeremy
Co-authored-by: kjeremy <kjeremy@gmail.com>
kjeremy [Wed, 22 Apr 2020 14:34:53 +0000 (10:34 -0400)]
cargo update
bors[bot] [Wed, 22 Apr 2020 11:55:18 +0000 (11:55 +0000)]
Merge #4082
4082: Don't panic on `rust-analyzer --help` r=matklad a=eminence
Special case handling for `-h` and `--help` if no subcommand is given.
Closes #4068
Co-authored-by: Andrew Chin <achin@eminence32.net>
bors[bot] [Wed, 22 Apr 2020 11:05:18 +0000 (11:05 +0000)]
Merge #4081
4081: Work around crlf in syntax tree r=matklad a=Veetaha
Workarounds fixes #4067
Co-authored-by: veetaha <veetaha2@gmail.com>
veetaha [Tue, 21 Apr 2020 23:28:44 +0000 (02:28 +0300)]
Refactor the workaround a bit
veetaha [Tue, 21 Apr 2020 23:04:28 +0000 (02:04 +0300)]
Work around crlf in syntax tree
bors[bot] [Wed, 22 Apr 2020 09:10:13 +0000 (09:10 +0000)]
Merge #4080
4080: Fix .rast tmGrammar to account for numbers in identifiers r=matklad a=Veetaha
Co-authored-by: veetaha <veetaha2@gmail.com>
Andrew Chin [Wed, 22 Apr 2020 00:23:01 +0000 (20:23 -0400)]
Don't panic on `rust-analyzer --help`
Special case handling for `-h` and `--help` if no subcommand is given.
Closes #4068
veetaha [Tue, 21 Apr 2020 23:00:58 +0000 (02:00 +0300)]
Fix .rast tmGrammar to account for numbers in identifiers
bors[bot] [Tue, 21 Apr 2020 20:13:17 +0000 (20:13 +0000)]
Merge #4078
4078: Do not add default and closure types in 'add explicit type' assist r=matklad a=SomeoneToIgnore
Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
Kirill Bulatov [Tue, 21 Apr 2020 19:56:11 +0000 (22:56 +0300)]
Do not add default and closure types in 'add explicit type' assist
bors[bot] [Tue, 21 Apr 2020 18:50:53 +0000 (18:50 +0000)]
Merge #4076
4076: Improve remove derive attrs r=matklad a=edwin0cheng
This PR implemented a proper `remove_derive_attrs` function which **merely** remove any `#[derive(*)]` attributes.
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
Edwin Cheng [Tue, 21 Apr 2020 17:44:21 +0000 (01:44 +0800)]
Improve remove dervie attrs
Benjamin Coenen [Tue, 21 Apr 2020 15:19:18 +0000 (17:19 +0200)]
Improve autocompletion by looking on the type and name
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
bors[bot] [Tue, 21 Apr 2020 12:58:27 +0000 (12:58 +0000)]
Merge #4038
4038: Group generated ast boilerplate apart from the interesting part r=matklad a=Veetaha
Boilerplate `AstNode` and `From` impls are moved to the end further from the interesting part in `generated.rs`
Co-authored-by: veetaha <veetaha2@gmail.com>
Benjamin Coenen [Tue, 21 Apr 2020 12:36:56 +0000 (14:36 +0200)]
Improve autocompletion by looking on the type and name
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Benjamin Coenen [Tue, 21 Apr 2020 12:32:02 +0000 (14:32 +0200)]
Merge branch 'master' of github.com:rust-analyzer/rust-analyzer
Benjamin Coenen [Tue, 21 Apr 2020 12:31:57 +0000 (14:31 +0200)]
Improve autocompletion by looking on the type and name
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
bors[bot] [Tue, 21 Apr 2020 10:10:22 +0000 (10:10 +0000)]
Merge #4071
4071: Cleanup args a bit r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 21 Apr 2020 10:06:25 +0000 (12:06 +0200)]
Cleanup args a bit
bors[bot] [Tue, 21 Apr 2020 10:02:41 +0000 (10:02 +0000)]
Merge #4070
4070: docs(readme): improve user docs r=matklad a=fannheyward
cleanup unavailable configurations/commands
Co-authored-by: Heyward Fann <fannheyward@gmail.com>
Heyward Fann [Tue, 21 Apr 2020 09:54:13 +0000 (17:54 +0800)]
docs(readme): improve user docs
cleanup unavailable configurations/commands
bors[bot] [Tue, 21 Apr 2020 09:18:55 +0000 (09:18 +0000)]
Merge #4069
4069: More detailed Sublime Text install instructions r=lnicola a=nnmm
* People might typically jump directly to their editor and wonder where the part about installing rust-analyzer is – at least I did. I added a link to the relevant section for ST.
* Make ST instructions more detailed and user friendly (especially beginners), include troubleshooting tips.
* Minor grammar improvements throughout.
Co-authored-by: Nikolai Morin <nnmmgit@gmail.com>
Nikolai Morin [Tue, 21 Apr 2020 09:17:12 +0000 (11:17 +0200)]
Move the PATH issue up to the non-editor specific section
Nikolai Morin [Tue, 21 Apr 2020 08:16:30 +0000 (10:16 +0200)]
Delete comma
Nikolai Morin [Tue, 21 Apr 2020 08:15:49 +0000 (10:15 +0200)]
Update docs/user/readme.adoc
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
Nikolai Morin [Tue, 21 Apr 2020 08:13:33 +0000 (10:13 +0200)]
Update docs/user/readme.adoc
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
Nikolai Morin [Tue, 21 Apr 2020 07:20:14 +0000 (09:20 +0200)]
More detailed Sublime Text install instructions
* People might typically jump directly to their editor and wonder where the part about installing rust-analyzer is – at least I did. I added a link to the relevant section for ST.
* Make ST instructions more detailed and user friendly (especially beginners), include troubleshooting tips.
* Minor grammar improvements throughout.
bors[bot] [Mon, 20 Apr 2020 21:26:25 +0000 (21:26 +0000)]
Merge #4066
4066: Fix restart missing arguments in proc-macro-srv r=edwin0cheng a=edwin0cheng
cc @Veetaha
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
Edwin Cheng [Mon, 20 Apr 2020 21:22:17 +0000 (05:22 +0800)]
Refactor a bit
Edwin Cheng [Mon, 20 Apr 2020 20:57:55 +0000 (04:57 +0800)]
Fix restart missing arguments in proc-macro-srv
bors[bot] [Mon, 20 Apr 2020 20:25:33 +0000 (20:25 +0000)]
Merge #4061
4061: ra_proc_macro: cleanups here and there r=edwin0cheng a=Veetaha
r? @edwin0cheng
Co-authored-by: veetaha <veetaha2@gmail.com>
Co-authored-by: Veetaha <veetaha2@gmail.com>
veetaha [Mon, 20 Apr 2020 19:42:36 +0000 (22:42 +0300)]
Migrate to Result<T, io::Error> -> io::Result<T>
veetaha [Mon, 20 Apr 2020 19:24:10 +0000 (22:24 +0300)]
Fix doc comment
Veetaha [Mon, 20 Apr 2020 19:07:47 +0000 (22:07 +0300)]
Fix typo
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
Veetaha [Mon, 20 Apr 2020 18:54:43 +0000 (21:54 +0300)]
Display path not debug it
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
Veetaha [Mon, 20 Apr 2020 18:50:06 +0000 (21:50 +0300)]
Display path not debug it
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
veetaha [Mon, 20 Apr 2020 18:26:10 +0000 (21:26 +0300)]
ra_proc_macro: cleanups here and there