]>
git.lizzy.rs Git - rust.git/log
bors [Wed, 27 Oct 2021 07:33:00 +0000 (07:33 +0000)]
Auto merge of #7880 - Alexendoo:newlint-add-pass, r=flip1995
Register the generated lints from `cargo dev new_lint`
How to register a lint was something that took me a couple reads to figure out, this will hopefully make that easier. It appends the created lint to the end of the list when running `cargo dev new_lint`
changelog: none
bors [Tue, 26 Oct 2021 23:46:21 +0000 (23:46 +0000)]
Auto merge of #7860 - dswij:question-mark-fp, r=giraffate
Fix `question_mark` FP on custom error type
Closes #7859
#7840 aims to ignore `question_mark` when the return type is custom, which is [covered here](https://github.com/rust-lang/rust-clippy/blob/
df65291edd6b89a241fed483ab165c32df468746 /tests/ui/question_mark.rs#L144-L149). But this fails when there is a call in conditional predicate
changelog: [`question_mark`] Fix false positive when there is call in conditional predicate
bors [Tue, 26 Oct 2021 21:16:44 +0000 (21:16 +0000)]
Auto merge of #7884 - devonhollowood:rename-cleanup, r=xFrednet
Clean up tests/ui/rename.rs
Part one of #7057, cleaning up `tests/ui/rename.rs`. `tests/ui/deprecated.rs` will be updated in a subsequent PR.
changelog: none
Devon Hollowood [Tue, 26 Oct 2021 21:01:46 +0000 (14:01 -0700)]
Update tests after reviewer suggestions
bors [Tue, 26 Oct 2021 20:56:23 +0000 (20:56 +0000)]
Auto merge of #7887 - xFrednet:7172-hiding-hidden-lines-online, r=flip1995
Remove hidden code lines in Clippy's lint list
This PR removes code lines from Clippy's lint list, which would also be hidden, when generating docs with rustdoc.
"A picture is worth a thousand words"... and here are even two pictures:
**Before:**
![image](https://user-images.githubusercontent.com/
17087237 /
138952314 -
676dd9e7 -ee80-459e-b521-
bc42d8d03517 .png)
**After:**
![image](https://user-images.githubusercontent.com/
17087237 /
138952684 -
4fef969d -6880-4434-a338-
b1a5a45539f0 .png)
---
changelog: none
r? `@camsteffen` (Since you implemented the code block filtering :upside_down_face: )
Devon Hollowood [Tue, 26 Oct 2021 20:55:51 +0000 (13:55 -0700)]
Apply suggestions from code review
Co-authored-by: Fridtjof Stoldt <xFrednet@gmail.com>
xFrednet [Tue, 26 Oct 2021 19:39:32 +0000 (21:39 +0200)]
Remove hidden code lines in Clippy's lint list
Alex Macleod [Mon, 25 Oct 2021 17:14:54 +0000 (18:14 +0100)]
Register the generated lints from `cargo dev new_lint`
Devon Hollowood [Tue, 26 Oct 2021 17:26:35 +0000 (10:26 -0700)]
Further clean up tests/ui/rename.rs
Now it is just a collection of lints + an empty main function
Dharma Saputra Wijaya [Tue, 26 Oct 2021 13:22:22 +0000 (21:22 +0800)]
Rename variable name in `question_mark`
dswij [Fri, 22 Oct 2021 06:11:04 +0000 (14:11 +0800)]
Update `question_mark` test to behave better
dswij [Fri, 22 Oct 2021 05:43:21 +0000 (13:43 +0800)]
Update `question_mark` expected test output
dswij [Fri, 22 Oct 2021 05:41:46 +0000 (13:41 +0800)]
Fix `question_mark` FP on calls
dswij [Fri, 22 Oct 2021 05:36:13 +0000 (13:36 +0800)]
Add #7859 FP test case for `question_mark`
bors [Tue, 26 Oct 2021 08:11:49 +0000 (08:11 +0000)]
Auto merge of #7878 - rust-lang:string-slice, r=giraffate
new lint: string-slice
This is a restriction lint to highlight code that should have tests containing non-ascii characters. See #6623.
changelog: new lint: [`string-slice`]
Devon Hollowood [Tue, 26 Oct 2021 07:53:53 +0000 (00:53 -0700)]
Clean up tests/ui/rename.rs
Andre Bogus [Mon, 25 Oct 2021 07:46:47 +0000 (09:46 +0200)]
new lint: string-slice
bors [Mon, 25 Oct 2021 21:34:11 +0000 (21:34 +0000)]
Auto merge of #7865 - Herschel:fix-match-str-case-mismatch, r=xFrednet
Fix `match_str_case_mismatch` on uncased chars
False positives would result because `char::is_lowercase` and friends will return `false` for non-alphabetic chars and alphabetic chars lacking case (such as CJK scripts). Care also has to be taken for handling titlecase characters (`Dz`) and lowercased chars with no uppercase equivalent (`ʁ`).
For example, when verifying lowercase:
* Check `!any(char::is_ascii_uppercase)` instead of `all(char::is_ascii_lowercase)` for ASCII.
* Check that `all(|c| c.to_lowercase() == c)` instead of `all(char::is_lowercase)` for non-ASCII
Fixes #7863.
changelog: Fix false positives in [`match_str_case_mismatch`] on uncased characters
bors [Mon, 25 Oct 2021 19:20:05 +0000 (19:20 +0000)]
Auto merge of #7873 - xFrednet:7869-string-index-ice, r=Manishearth
Update `str` utils to prevent ICEs and FNs
This PR reworks some string handling for lints regarding enum naming. I hope the refactoring will prevent future ICEs and help with new bug free implementations.
It might be better to review this PR by going through the commits, as `clippy_utils::camel_case` was renamed to `clippy_utils::str_utils` and then changed further. GH sadly doesn't really make the changes that obvious :upside_down_face:
Not too much more to say. Have a nice day :sun_with_face:
---
Fixes: rust-lang/rust-clippy#7869
changelog: ICE Fix: [`enum_variant_names`] #7869
bors [Mon, 25 Oct 2021 18:56:57 +0000 (18:56 +0000)]
Auto merge of #7874 - xFrednet:7756-move-lint, r=llogiq
Move `non_send_fields_in_send_ty` to `suspicious`
Stabilize the `non_send_fields_in_send_ty` lint and update the lint for the `allowed_scripts` configuration.
---
closes: rust-lang/rust-clippy#7756
changelog: Move `non_send_fields_in_send_ty` to `suspicious`
xFrednet [Sun, 24 Oct 2021 21:01:44 +0000 (23:01 +0200)]
Move `non_send_fields_in_send_ty` to `suspicious`
Also updated one configuration for nicer formatting
bors [Mon, 25 Oct 2021 11:05:25 +0000 (11:05 +0000)]
Auto merge of #7855 - flip1995:changelog, r=xFrednet
Update CHANGELOG
r? `@xFrednet` (you showed to be a reliable reviewer for this :) )
[Rendered](https://github.com/flip1995/rust-clippy/blob/changelog/CHANGELOG.md)
changelog: none
flip1995 [Thu, 21 Oct 2021 15:37:57 +0000 (17:37 +0200)]
Update CHANGELOG
bors [Mon, 25 Oct 2021 08:46:51 +0000 (08:46 +0000)]
Auto merge of #7872 - calebcartwright:sync-use-new-branch, r=flip1995
recommend new branch or deleting branch when synching from rust
changelog: none
r? `@flip1995` - thanks again for your assistance in zulip earlier, figured I'd take a pass at incorporating your recommendation to delete or use a new branch into the excellent docs here
xFrednet [Sun, 24 Oct 2021 20:47:39 +0000 (22:47 +0200)]
Refactored some string handling to prevent ICEs and FNs
Caleb Cartwright [Sun, 24 Oct 2021 20:14:45 +0000 (15:14 -0500)]
docs: recommend new branch
xFrednet [Sun, 24 Oct 2021 19:06:17 +0000 (21:06 +0200)]
Refactor `camel_case` util functions for new `StrIndex`
bors [Sun, 24 Oct 2021 17:55:49 +0000 (17:55 +0000)]
Auto merge of #7871 - camsteffen:fmt-update, r=camsteffen
Update rustfmt
changelog: none
Something changed with `rustup update nightly`
Cameron Steffen [Sun, 24 Oct 2021 17:52:38 +0000 (12:52 -0500)]
Update rustfmt
xFrednet [Sun, 24 Oct 2021 15:42:13 +0000 (17:42 +0200)]
Rename `clippy_utils::camal_case` to `clippy_utils::str_utils`
bors [Sat, 23 Oct 2021 16:09:45 +0000 (16:09 +0000)]
Auto merge of #7867 - dswij:utils-typo, r=llogiq
Fix typo on utils/lib
Found some typo when looking through `clippy_utils/src/lib.rs` :slightly_smiling_face:
changelog: none
Dharma Saputra Wijaya [Sat, 23 Oct 2021 15:42:31 +0000 (23:42 +0800)]
Fix typo on utils/lib
Mike Welsh [Sat, 23 Oct 2021 06:47:38 +0000 (23:47 -0700)]
Fix `match_str_case_mismatch` false positives
Properly consider uncased and titlecased characters.
Fixes #7863.
bors [Thu, 21 Oct 2021 21:51:24 +0000 (21:51 +0000)]
Auto merge of #7856 - Manishearth:impl-safety, r=xFrednet
missing_safety_doc: Handle 'implementation safety' headers as well
We hit some FPs on this in `yoke`, it's somewhat normal to mark trait impl safety with "implementation safety". We could also broaden the check for headers which contain the word "safety" somehow, or split out impl safety stuff to only apply to traits.
changelog: handle 'implementation safety' headers in `missing_safety_doc`
Manish Goregaokar [Thu, 21 Oct 2021 21:40:33 +0000 (14:40 -0700)]
use a variable
bors [Thu, 21 Oct 2021 20:54:47 +0000 (20:54 +0000)]
Auto merge of #7857 - flip1995:fix_deploy, r=xFrednet
Fix deploy script
I broke this script in #7502, so that the stable symlink isn't generated
anymore. This reverts this change.
changelog: none
bors [Thu, 21 Oct 2021 18:15:23 +0000 (18:15 +0000)]
Auto merge of #7801 - aDotInTheVoid:empty-format, r=camsteffen
Make useless_format recognize format!("")
Closes #7796
changelog: [`useless_format`] Fix for false negitive for `format!("")`
bors [Thu, 21 Oct 2021 18:01:39 +0000 (18:01 +0000)]
Auto merge of #7850 - ThibsG:PossibleCastTruncation5395, r=camsteffen
Fix FP: no lint when cast is coming from `signum` method call for `cast_possible_truncation` lint
Fixes a FP when cast is coming from `signum` method call
fixes: #5395
changelog: [`cast_possible_truncation`] Fix FP when cast is coming from `signum` method call
Nixon Enraght-Moony [Mon, 11 Oct 2021 00:03:11 +0000 (01:03 +0100)]
Make useless_format recognize format!("")
Closes #7796
ThibsG [Wed, 20 Oct 2021 19:44:05 +0000 (21:44 +0200)]
Do not lint when cast is coming from `signum` method call
flip1995 [Thu, 21 Oct 2021 16:00:57 +0000 (18:00 +0200)]
Fix deploy script
I broke this script in #7502, so that the stable symlink isn't generated
anymore. This reverts this change.
Manish Goregaokar [Thu, 21 Oct 2021 15:50:50 +0000 (08:50 -0700)]
Handle 'implementation safety' headers as well
bors [Thu, 21 Oct 2021 10:23:11 +0000 (10:23 +0000)]
Auto merge of #7853 - flip1995:rustup, r=flip1995
Rustup
r? `@ghost`
changelog: none
flip1995 [Thu, 21 Oct 2021 10:19:46 +0000 (12:19 +0200)]
Bump nightly version -> 2021-10-21
flip1995 [Thu, 21 Oct 2021 10:19:32 +0000 (12:19 +0200)]
Bump Clippy Version -> 0.1.58
flip1995 [Thu, 21 Oct 2021 10:18:12 +0000 (12:18 +0200)]
Merge remote-tracking branch 'upstream/master' into rustup
bors [Thu, 21 Oct 2021 09:08:22 +0000 (09:08 +0000)]
Auto merge of #7852 - surechen:fix_typo, r=xFrednet
Fix typo for invalid_null_ptr_usage and missing_inline_in_public_items.
Fix typo for invalid_null_ptr_usage and missing_inline_in_public_items.
changelog: none
surechen [Thu, 21 Oct 2021 06:33:43 +0000 (14:33 +0800)]
Fix typo for INVALID_NULL_PTR_USAGE and MISSING_INLINE_IN_PUBLIC_ITEMS.
bors [Wed, 20 Oct 2021 20:35:58 +0000 (20:35 +0000)]
Auto merge of #7838 - nhamovitz:trailing_zs_arr_wo_repr, r=Manishearth
Warn on structs with a trailing zero-sized array but no `repr` attribute
Closes #2868
changelog: Implement ``[`trailing_empty_array`]``, which warns if a struct is defined where the last field is a zero-sized array but there are no `repr` attributes. Zero-sized arrays aren't very useful in Rust itself, so such a struct is likely being created to pass to C code or in some other situation where control over memory layout matters. Either way, a `repr` attribute is needed.
bors [Wed, 20 Oct 2021 16:46:38 +0000 (16:46 +0000)]
Auto merge of #7849 - ThibsG:SafetyDoc, r=llogiq
FIx FP in `missing_safety_doc` lint
Fix FP where lint souldn't fire if any parent has `#[doc(hidden)]` attribute
fixes: #7347
changelog: [`missing_safety_doc`] Fix FP if any parent has `#[doc(hidden)]` attribute
ThibsG [Thu, 14 Oct 2021 10:16:35 +0000 (12:16 +0200)]
Do not lint if any parent has hidden attribute
bors [Wed, 20 Oct 2021 12:02:32 +0000 (12:02 +0000)]
Auto merge of #7848 - Veykril:patch-1, r=xFrednet
Fix doc heading of `transmute_num_to_bytes`
changelog: none
Lukas Wirth [Wed, 20 Oct 2021 11:46:12 +0000 (13:46 +0200)]
Fix doc heading of TRANSMUTE_NUM_TO_BYTES
bors [Wed, 20 Oct 2021 09:33:45 +0000 (09:33 +0000)]
Auto merge of #7775 - F3real:no_effect, r=xFrednet
Detect underscored variables with no side effects
Fixes #7545
changelog: Lint on underscored variables with no side effects in [`no_effect`]
bors [Wed, 20 Oct 2021 07:27:13 +0000 (07:27 +0000)]
Auto merge of #7840 - dswij:question-mark-result, r=llogiq
Cover `Result` for `question_mark`
closes #7135
changelog: [`question_mark`] now covers `Result`
dswij [Wed, 20 Oct 2021 05:41:44 +0000 (13:41 +0800)]
Small refactor on `question_mark` condition checks
bors [Tue, 19 Oct 2021 23:47:20 +0000 (23:47 +0000)]
Auto merge of #7833 - Dmitry-Borodin:patch-1, r=giraffate
Add reference to another doc with explanation
Add reference to another doc that explains which repository should be passed in this command since this is not covered in the command help itself.
changelog: none
F3real [Mon, 4 Oct 2021 21:49:53 +0000 (23:49 +0200)]
Lint on underscore variable assignment
Fix tests after no_effect update
Add a drop testcase
Don't lint _ variables in macro expansion
Address review comments and update tests
Don't shadow unnecessary operation lint if no_effect is allowed
Revert shadowing change and remove no_effect allows
Update clippy_lints/src/no_effect.rs
Co-authored-by: Takayuki Nakata <f.seasons017@gmail.com>
Update clippy_lints/src/no_effect.rs
Co-authored-by: Takayuki Nakata <f.seasons017@gmail.com>
Address review comments
Nathaniel Hamovitz [Tue, 19 Oct 2021 21:33:43 +0000 (14:33 -0700)]
Rename lint
Nathaniel Hamovitz [Tue, 19 Oct 2021 21:23:55 +0000 (14:23 -0700)]
remove resolved note
bors [Tue, 19 Oct 2021 19:54:40 +0000 (19:54 +0000)]
Auto merge of #7811 - rust-lang:eq-op-testless, r=xFrednet
avoid `eq_op` in test code
Add a check to `eq_op` that will avoid linting in functions annotated with `#[test]`
---
*Please write a short comment explaining your change (or "none" for internal only changes)*
changelog: avoid `eq_op` in test functions
Yuki Okushi [Tue, 19 Oct 2021 19:35:14 +0000 (04:35 +0900)]
Rollup merge of #88860 - nbdd0121:panic, r=m-ou-se
Deduplicate panic_fmt
std's begin_panic_fmt and core's panic_fmt are duplicates. Merge them to declutter code and remove a lang item.
Andre Bogus [Tue, 12 Oct 2021 17:18:22 +0000 (19:18 +0200)]
avoid `eq_op` in test code
Dmitry Borodin [Tue, 19 Oct 2021 18:33:39 +0000 (20:33 +0200)]
made description of intellij a link by moving outside of code block.
Gary Guo [Tue, 19 Oct 2021 12:58:58 +0000 (13:58 +0100)]
Remove begin_panic_fmt from clippy
dswij [Tue, 19 Oct 2021 10:27:37 +0000 (18:27 +0800)]
Update test for `question_mark` to cover `Result`
dswij [Tue, 19 Oct 2021 10:26:50 +0000 (18:26 +0800)]
Cover `Result` for `question_mark`
Nathaniel Hamovitz [Tue, 19 Oct 2021 01:42:01 +0000 (18:42 -0700)]
formatting 🙃
Nathaniel Hamovitz [Tue, 19 Oct 2021 01:32:00 +0000 (18:32 -0700)]
Use real type in doc examples
Nathaniel Hamovitz [Tue, 19 Oct 2021 01:20:35 +0000 (18:20 -0700)]
Remove explicit lifetime
Nathaniel Hamovitz [Tue, 19 Oct 2021 01:03:00 +0000 (18:03 -0700)]
Remove comment
Nathaniel Hamovitz [Tue, 19 Oct 2021 00:41:27 +0000 (17:41 -0700)]
One more test + final tidying
Nathaniel Hamovitz [Tue, 19 Oct 2021 00:18:07 +0000 (17:18 -0700)]
Revert "!: this is the commit that demonstrates the ICE"
This reverts commit
d85f903c91d909534003ee2ff0e16316b20687dc .
Nathaniel Hamovitz [Tue, 19 Oct 2021 00:07:51 +0000 (17:07 -0700)]
!: this is the commit that demonstrates the ICE
Nathaniel Hamovitz [Mon, 18 Oct 2021 23:53:17 +0000 (16:53 -0700)]
Don't need `rustc_attr` anymore
Nathaniel Hamovitz [Mon, 18 Oct 2021 23:53:05 +0000 (16:53 -0700)]
Improve help message
Nathaniel Hamovitz [Mon, 18 Oct 2021 22:33:11 +0000 (15:33 -0700)]
All five `has_repr_attr` agree + are correct
Nathaniel Hamovitz [Mon, 18 Oct 2021 14:02:00 +0000 (07:02 -0700)]
Exploring emitting other sorts of `span`s
Nathaniel Hamovitz [Mon, 18 Oct 2021 11:59:03 +0000 (04:59 -0700)]
Better testcase names
Nathaniel Hamovitz [Mon, 18 Oct 2021 11:22:43 +0000 (04:22 -0700)]
One more test
Nathaniel Hamovitz [Mon, 18 Oct 2021 10:56:49 +0000 (03:56 -0700)]
Still renaming lmao
Nathaniel Hamovitz [Mon, 18 Oct 2021 10:52:57 +0000 (03:52 -0700)]
Improve doc and span messages
Nathaniel Hamovitz [Mon, 18 Oct 2021 10:52:37 +0000 (03:52 -0700)]
Rename stderr
Nathaniel Hamovitz [Mon, 18 Oct 2021 10:45:08 +0000 (03:45 -0700)]
Rename lint
Nathaniel Hamovitz [Mon, 18 Oct 2021 10:16:10 +0000 (03:16 -0700)]
run rustfmt
Nathaniel Hamovitz [Mon, 18 Oct 2021 10:13:48 +0000 (03:13 -0700)]
Tidy import + update expected stderr
Nathaniel Hamovitz [Mon, 18 Oct 2021 10:04:50 +0000 (03:04 -0700)]
Tidy imports
Nathaniel Hamovitz [Mon, 18 Oct 2021 10:03:48 +0000 (03:03 -0700)]
Check for tuple structs
Nathaniel Hamovitz [Mon, 18 Oct 2021 07:51:30 +0000 (00:51 -0700)]
Refactor ZS array detection again and this one seems great 👍
Nathaniel Hamovitz [Mon, 18 Oct 2021 00:28:45 +0000 (17:28 -0700)]
update testsuite and expand `if_chain`
Nathaniel Hamovitz [Sun, 17 Oct 2021 05:03:08 +0000 (22:03 -0700)]
Tidy comments + tests; revert 'size-is-zero' detection
Nathaniel Hamovitz [Sun, 17 Oct 2021 00:49:13 +0000 (17:49 -0700)]
tried to simplify but it doesn't work :/
Nathaniel Hamovitz [Sat, 16 Oct 2021 23:13:14 +0000 (16:13 -0700)]
intermediate step
Nathaniel Hamovitz [Sat, 16 Oct 2021 22:26:10 +0000 (15:26 -0700)]
add multiple `get_attrs` and `includes_repr` and they all work!
Nathaniel Hamovitz [Sat, 16 Oct 2021 09:26:08 +0000 (02:26 -0700)]
Ran `dev bless`!
Nathaniel Hamovitz [Sat, 16 Oct 2021 09:01:17 +0000 (02:01 -0700)]
output looks fantastic
Nathaniel Hamovitz [Sat, 16 Oct 2021 07:51:09 +0000 (00:51 -0700)]
it works i think (incl some `dbg`s)
Nathaniel Hamovitz [Sat, 16 Oct 2021 06:44:39 +0000 (23:44 -0700)]
Implement getting an array of attributes!
Nathaniel Hamovitz [Fri, 15 Oct 2021 23:16:27 +0000 (16:16 -0700)]
Implement detecting trailing zero-sized array
Nathaniel Hamovitz [Fri, 15 Oct 2021 08:31:26 +0000 (01:31 -0700)]
ayy it compiles! ship it, right? 😎 /s
why was `rustc_lint_defs` not already externed in `lib.rs`?
and how was r-a able to find it but cargo wasn't? 🤔