]> git.lizzy.rs Git - rust.git/log
rust.git
2 years agofix: make signature info response conform to spec
Alex Muscar [Mon, 11 Oct 2021 19:42:16 +0000 (20:42 +0100)]
fix: make signature info response conform to spec

This addreses
https://github.com/rust-analyzer/rust-analyzer/issues/10464.

This patch picks up `lsp-types` 0.90.1, which serialises the
`SignatureInformation` and `ParameterInformation` with the right casing.
It also adds `activeSignature` field as part of the top-level signature
response. It keeps `activeParameter` at the top-level for backwards
compatibility.

2 years agoMerge #10509
bors[bot] [Sun, 10 Oct 2021 12:44:39 +0000 (12:44 +0000)]
Merge #10509

10509: internal: consistent module naming r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2 years agointernal: consistent module naming
Aleksey Kladov [Sun, 10 Oct 2021 12:44:03 +0000 (15:44 +0300)]
internal: consistent module naming

2 years agoMerge #10508
bors[bot] [Sun, 10 Oct 2021 12:32:03 +0000 (12:32 +0000)]
Merge #10508

10508: internal: move some tests r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2 years agomove tests
Aleksey Kladov [Sun, 10 Oct 2021 12:30:54 +0000 (15:30 +0300)]
move tests

2 years agomove tests
Aleksey Kladov [Sun, 10 Oct 2021 12:28:24 +0000 (15:28 +0300)]
move tests

2 years agointernal: move builtin macro tests to macro expansion suite
Aleksey Kladov [Sun, 10 Oct 2021 12:17:53 +0000 (15:17 +0300)]
internal: move builtin macro tests to macro expansion suite

2 years agodrop obsolete tests
Aleksey Kladov [Sun, 10 Oct 2021 12:11:33 +0000 (15:11 +0300)]
drop obsolete tests

2 years agomove test
Aleksey Kladov [Sun, 10 Oct 2021 12:06:41 +0000 (15:06 +0300)]
move test

2 years agomove tests
Aleksey Kladov [Sun, 10 Oct 2021 11:58:25 +0000 (14:58 +0300)]
move tests

2 years agomove tests
Aleksey Kladov [Sun, 10 Oct 2021 11:40:13 +0000 (14:40 +0300)]
move tests

2 years agomove test
Aleksey Kladov [Sun, 10 Oct 2021 11:28:04 +0000 (14:28 +0300)]
move test

2 years agomove tests
Aleksey Kladov [Sun, 10 Oct 2021 11:26:47 +0000 (14:26 +0300)]
move tests

2 years agomove test
Aleksey Kladov [Sun, 10 Oct 2021 11:23:52 +0000 (14:23 +0300)]
move test

2 years agomove tests
Aleksey Kladov [Sun, 10 Oct 2021 11:21:47 +0000 (14:21 +0300)]
move tests

2 years agomove tests
Aleksey Kladov [Sun, 10 Oct 2021 11:08:49 +0000 (14:08 +0300)]
move tests

2 years agoadd directory for regression tests
Aleksey Kladov [Sun, 10 Oct 2021 10:56:41 +0000 (13:56 +0300)]
add directory for regression tests

2 years agomove test
Aleksey Kladov [Sun, 10 Oct 2021 10:54:44 +0000 (13:54 +0300)]
move test

2 years agomove test
Aleksey Kladov [Sun, 10 Oct 2021 10:26:07 +0000 (13:26 +0300)]
move test

2 years agomove test
Aleksey Kladov [Sun, 10 Oct 2021 10:24:48 +0000 (13:24 +0300)]
move test

2 years agointernal: move test
Aleksey Kladov [Sun, 10 Oct 2021 10:21:42 +0000 (13:21 +0300)]
internal: move test

2 years agomove test
Aleksey Kladov [Sun, 10 Oct 2021 09:57:18 +0000 (12:57 +0300)]
move test

2 years agomove test
Aleksey Kladov [Sun, 10 Oct 2021 09:55:31 +0000 (12:55 +0300)]
move test

2 years agomove tests
Aleksey Kladov [Sun, 10 Oct 2021 09:52:28 +0000 (12:52 +0300)]
move tests

2 years agointernal: move tests
Aleksey Kladov [Sun, 10 Oct 2021 09:45:17 +0000 (12:45 +0300)]
internal: move tests

2 years agointernal: move tests
Aleksey Kladov [Sun, 10 Oct 2021 09:39:58 +0000 (12:39 +0300)]
internal: move tests

2 years agoMerge #10507
bors[bot] [Sun, 10 Oct 2021 08:46:29 +0000 (08:46 +0000)]
Merge #10507

10507: internal: move tests r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2 years agointernal: consistently use `ok!();` for succesfull macro expansion
Aleksey Kladov [Sun, 10 Oct 2021 08:45:05 +0000 (11:45 +0300)]
internal: consistently use `ok!();` for succesfull macro expansion

2 years agomove some tests
Aleksey Kladov [Sun, 10 Oct 2021 08:44:46 +0000 (11:44 +0300)]
move some tests

2 years agomove tests
Aleksey Kladov [Sun, 10 Oct 2021 08:39:08 +0000 (11:39 +0300)]
move tests

2 years agomove test
Aleksey Kladov [Sun, 10 Oct 2021 08:29:26 +0000 (11:29 +0300)]
move test

2 years agomove test
Aleksey Kladov [Sun, 10 Oct 2021 08:26:18 +0000 (11:26 +0300)]
move test

2 years agotest formatting
Aleksey Kladov [Sun, 10 Oct 2021 08:22:12 +0000 (11:22 +0300)]
test formatting

2 years agotest formatting
Aleksey Kladov [Sun, 10 Oct 2021 08:16:25 +0000 (11:16 +0300)]
test formatting

2 years agomove tests
Aleksey Kladov [Sun, 10 Oct 2021 08:15:42 +0000 (11:15 +0300)]
move tests

2 years agointernal: move tests
Aleksey Kladov [Sun, 10 Oct 2021 08:11:50 +0000 (11:11 +0300)]
internal: move tests

2 years agoMerge #10501
bors[bot] [Sun, 10 Oct 2021 08:09:50 +0000 (08:09 +0000)]
Merge #10501

10501: internal: move some mbe tests r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2 years agodead code
Aleksey Kladov [Sun, 10 Oct 2021 08:09:16 +0000 (11:09 +0300)]
dead code

2 years agointernal: move some mbe tests
Aleksey Kladov [Sat, 9 Oct 2021 20:33:43 +0000 (23:33 +0300)]
internal: move some mbe tests

2 years agomove tests
Aleksey Kladov [Sat, 9 Oct 2021 19:23:38 +0000 (22:23 +0300)]
move tests

2 years agofix tests
Aleksey Kladov [Sat, 9 Oct 2021 19:19:42 +0000 (22:19 +0300)]
fix tests

2 years agoMerge #10506
bors[bot] [Sun, 10 Oct 2021 07:56:47 +0000 (07:56 +0000)]
Merge #10506

10506: Add comment r=lnicola a=k-nasa

## Why

This code looks logic-bug ...

https://github.com/rust-analyzer/rust-analyzer/blob/ce86534e1cb22685e83c3f91ea89025edbfcbc98/crates/syntax/src/syntax_node.rs#L50

However, this code has been intentionally disabled.
It's a good idea to write a comment

ref: https://github.com/rust-analyzer/rust-analyzer/pull/10357

## What

- I added comment

Co-authored-by: k-nasa <htilcs1115@gmail.com>
2 years agoAdd comment
k-nasa [Sun, 10 Oct 2021 07:53:37 +0000 (16:53 +0900)]
Add comment

2 years agoMerge #10504
bors[bot] [Sun, 10 Oct 2021 07:17:52 +0000 (07:17 +0000)]
Merge #10504

10504: Remove needless clone r=lnicola a=k-nasa

## Why

Delete clones for efficiency

## What

- I erased unnecessary clones

Co-authored-by: k-nasa <htilcs1115@gmail.com>
2 years agoremove comment
k-nasa [Sun, 10 Oct 2021 04:16:34 +0000 (13:16 +0900)]
remove comment

2 years agoRevert "update comment"
k-nasa [Sun, 10 Oct 2021 01:51:45 +0000 (10:51 +0900)]
Revert "update comment"

This reverts commit 820393f72d68c6bf1df125057296402ba83ca982.

2 years agoRemove neesless clone
k-nasa [Sun, 10 Oct 2021 01:50:51 +0000 (10:50 +0900)]
Remove neesless clone

2 years agoupdate comment
k-nasa [Sun, 10 Oct 2021 01:16:32 +0000 (10:16 +0900)]
update comment

2 years agoAdd code comment
k-nasa [Sun, 10 Oct 2021 01:10:52 +0000 (10:10 +0900)]
Add code comment

2 years agoMerge #10499
bors[bot] [Sat, 9 Oct 2021 19:46:47 +0000 (19:46 +0000)]
Merge #10499

10499: feat: be more precise in mismatch arg counts highlighting r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2 years agofeat: be more precise in mismatch arg counts highlighting
Aleksey Kladov [Sat, 9 Oct 2021 19:45:54 +0000 (22:45 +0300)]
feat: be more precise in mismatch arg counts highlighting

2 years agoMerge #10497
bors[bot] [Sat, 9 Oct 2021 16:11:30 +0000 (16:11 +0000)]
Merge #10497

10497: internal: move tests r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2 years agomove test
Aleksey Kladov [Sat, 9 Oct 2021 15:55:50 +0000 (18:55 +0300)]
move test

2 years agointernal: move tests
Aleksey Kladov [Sat, 9 Oct 2021 15:54:15 +0000 (18:54 +0300)]
internal: move tests

2 years agointernal: move test
Aleksey Kladov [Sat, 9 Oct 2021 15:51:26 +0000 (18:51 +0300)]
internal: move test

2 years agointernal: move test
Aleksey Kladov [Sat, 9 Oct 2021 15:49:14 +0000 (18:49 +0300)]
internal: move test

2 years agointernal: drop duplicated test
Aleksey Kladov [Sat, 9 Oct 2021 15:47:04 +0000 (18:47 +0300)]
internal: drop duplicated test

2 years agointernal: move test
Aleksey Kladov [Sat, 9 Oct 2021 15:46:16 +0000 (18:46 +0300)]
internal: move test

2 years agointernal: move tests
Aleksey Kladov [Sat, 9 Oct 2021 15:43:15 +0000 (18:43 +0300)]
internal: move tests

2 years agoMerge #10496
bors[bot] [Sat, 9 Oct 2021 15:19:39 +0000 (15:19 +0000)]
Merge #10496

10496: internal: move some macro tests r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2 years agointernal: move some tests
Aleksey Kladov [Sat, 9 Oct 2021 15:18:56 +0000 (18:18 +0300)]
internal: move some tests

2 years agointernal: move some macro tests
Aleksey Kladov [Sat, 9 Oct 2021 15:15:05 +0000 (18:15 +0300)]
internal: move some macro tests

2 years agointernal: make sure macro test expand to valid syntax
Aleksey Kladov [Sat, 9 Oct 2021 15:06:24 +0000 (18:06 +0300)]
internal: make sure macro test expand to valid syntax

2 years agointernal: allow macro tests to inspect parse tree
Aleksey Kladov [Sat, 9 Oct 2021 14:58:17 +0000 (17:58 +0300)]
internal: allow macro tests to inspect parse tree

2 years agomove tests
Aleksey Kladov [Sat, 9 Oct 2021 14:43:07 +0000 (17:43 +0300)]
move tests

2 years agoindent macro output when pprinting
Aleksey Kladov [Sat, 9 Oct 2021 14:36:41 +0000 (17:36 +0300)]
indent macro output when pprinting

2 years agoalign tests to code style
Aleksey Kladov [Sat, 9 Oct 2021 14:31:04 +0000 (17:31 +0300)]
align tests to code style

2 years agomove some tests
Aleksey Kladov [Sat, 9 Oct 2021 14:27:38 +0000 (17:27 +0300)]
move some tests

2 years agointernal: don't un-indent macro tests manually
Aleksey Kladov [Sat, 9 Oct 2021 14:17:37 +0000 (17:17 +0300)]
internal: don't un-indent macro tests manually

2 years agointernal: update expect
Aleksey Kladov [Sat, 9 Oct 2021 14:17:16 +0000 (17:17 +0300)]
internal: update expect

2 years agoMerge #10495
bors[bot] [Sat, 9 Oct 2021 13:32:11 +0000 (13:32 +0000)]
Merge #10495

10495: internal: move some mbe tests r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2 years agointernal: move test
Aleksey Kladov [Sat, 9 Oct 2021 13:31:26 +0000 (16:31 +0300)]
internal: move test

2 years agorename
Aleksey Kladov [Sat, 9 Oct 2021 13:28:11 +0000 (16:28 +0300)]
rename

2 years agomove test
Aleksey Kladov [Sat, 9 Oct 2021 13:27:19 +0000 (16:27 +0300)]
move test

2 years agomove test
Aleksey Kladov [Sat, 9 Oct 2021 13:25:37 +0000 (16:25 +0300)]
move test

2 years agomove test
Aleksey Kladov [Sat, 9 Oct 2021 13:22:42 +0000 (16:22 +0300)]
move test

2 years agointernal: move test
Aleksey Kladov [Sat, 9 Oct 2021 13:19:19 +0000 (16:19 +0300)]
internal: move test

2 years agoMerge #10494
bors[bot] [Sat, 9 Oct 2021 12:30:27 +0000 (12:30 +0000)]
Merge #10494

10494: Macro expansion tests r=matklad a=matklad

bors r+

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2 years agointernal: docs
Aleksey Kladov [Sat, 9 Oct 2021 12:29:31 +0000 (15:29 +0300)]
internal: docs

2 years agofeat: report errors in macro definition
Aleksey Kladov [Sat, 9 Oct 2021 12:23:55 +0000 (15:23 +0300)]
feat: report errors in macro definition

Reporting macro *definition* error at the macro *call site* is a rather
questionable approach, but at least we don't erase the errors
altogether!

2 years agoget organizized
Aleksey Kladov [Sat, 9 Oct 2021 11:53:15 +0000 (14:53 +0300)]
get organizized

2 years agofuture proof structure
Aleksey Kladov [Sat, 9 Oct 2021 11:48:38 +0000 (14:48 +0300)]
future proof structure

2 years agomove test
Aleksey Kladov [Sat, 9 Oct 2021 11:45:52 +0000 (14:45 +0300)]
move test

2 years agomove tests
Aleksey Kladov [Sat, 9 Oct 2021 11:38:57 +0000 (14:38 +0300)]
move tests

2 years agointernal: move tests
Aleksey Kladov [Sat, 9 Oct 2021 11:22:49 +0000 (14:22 +0300)]
internal: move tests

2 years agointernal: move test
Aleksey Kladov [Sat, 9 Oct 2021 11:18:53 +0000 (14:18 +0300)]
internal: move test

2 years agointernal: move test
Aleksey Kladov [Sat, 9 Oct 2021 10:51:02 +0000 (13:51 +0300)]
internal: move test

2 years agointernal: start new macro test suite
Aleksey Kladov [Sat, 9 Oct 2021 10:42:32 +0000 (13:42 +0300)]
internal: start new macro test suite

I don't like our macro tests -- they are brittle and don't inspire
confidence. I think the reason for that is that we try to unit-test
them, but that is at odds with reality, where macro expansion
fundamentally depends on name resolution.

2 years agoMerge #10474
bors[bot] [Thu, 7 Oct 2021 15:09:42 +0000 (15:09 +0000)]
Merge #10474

10474: feat: Support `let...else` r=jonas-schievink a=jonas-schievink

bors r+

closes https://github.com/rust-analyzer/rust-analyzer/issues/10469

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
2 years agoSupport `let...else`
Jonas Schievink [Thu, 7 Oct 2021 15:05:50 +0000 (17:05 +0200)]
Support `let...else`

2 years agoMerge #10477 #10482
bors[bot] [Thu, 7 Oct 2021 13:05:18 +0000 (13:05 +0000)]
Merge #10477 #10482

10477: parser: fix parsing of macro call inside generic args r=Veykril a=cynecx

10482: fix: fix `inline_call` trying to use an uncached syntax node in Semantics r=Veykril a=Veykril

Fixes https://github.com/rust-analyzer/rust-analyzer/issues/10475
bors r+

Co-authored-by: cynecx <me@cynecx.net>
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2 years agoExpose HasSource::source through Semantics with caching behaviour
Lukas Wirth [Thu, 7 Oct 2021 12:46:49 +0000 (14:46 +0200)]
Expose HasSource::source through Semantics with caching behaviour

2 years agoMerge #10480
bors[bot] [Thu, 7 Oct 2021 12:56:28 +0000 (12:56 +0000)]
Merge #10480

10480: fix: Change `stdx::to_snake_case` to match rustc implementation r=Veykril a=Crauzer

Fixes #10473

Co-authored-by: crauzer <filip.quitko@gmail.com>
2 years agoMerge #10467
bors[bot] [Wed, 6 Oct 2021 21:47:22 +0000 (21:47 +0000)]
Merge #10467

10467: Optimize CodeLens for references/impls r=Veykril a=ericsampson

Don't do unnecessary work.
Followup to #10447 . cc `@Veykril`

Co-authored-by: Eric Sampson <esampson@eaze.com>
2 years agoRefactor to eliminate a vector allocation.
Eric Sampson [Wed, 6 Oct 2021 21:43:37 +0000 (16:43 -0500)]
Refactor to eliminate a vector allocation.

2 years agofix test
crauzer [Wed, 6 Oct 2021 21:37:43 +0000 (23:37 +0200)]
fix test

2 years agoFix stdx::to_snake_case
crauzer [Wed, 6 Oct 2021 21:24:47 +0000 (23:24 +0200)]
Fix stdx::to_snake_case

2 years agoMerge #10479
bors[bot] [Wed, 6 Oct 2021 20:54:27 +0000 (20:54 +0000)]
Merge #10479

10479: fix: fix "index out of bounds" panic in name resolution r=jonas-schievink a=jonas-schievink

Closes https://github.com/rust-analyzer/rust-analyzer/issues/10084
Closes https://github.com/rust-analyzer/rust-analyzer/issues/9163

This is really just a salsa update to a version that removes the problematic code (see https://github.com/rust-analyzer/rust-analyzer/issues/10084#issuecomment-934445711)

bors r+

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
2 years agoMerge #10476
bors[bot] [Wed, 6 Oct 2021 20:45:14 +0000 (20:45 +0000)]
Merge #10476

10476: feat: Add `replace_try_expr_with_match` assist r=Veykril a=Crauzer

Adds the replace_try_expr_with_match assist
#10424

Co-authored-by: crauzer <filip.quitko@gmail.com>
2 years agoUpdate salsa
Jonas Schievink [Wed, 6 Oct 2021 20:42:54 +0000 (22:42 +0200)]
Update salsa