]> git.lizzy.rs Git - rust.git/log
rust.git
18 months agoMake `<*{const,mut} T>::{,wrapping_}sub` methods `#[inline(always)]`
Eduardo Sánchez Muñoz [Fri, 9 Dec 2022 19:30:06 +0000 (20:30 +0100)]
Make `<*{const,mut} T>::{,wrapping_}sub` methods `#[inline(always)]`

18 months agoAuto merge of #105262 - eduardosm:more-inline-always, r=thomcc
bors [Fri, 9 Dec 2022 15:42:18 +0000 (15:42 +0000)]
Auto merge of #105262 - eduardosm:more-inline-always, r=thomcc

Make some trivial functions `#[inline(always)]`

This is some kind of follow-up of PRs like https://github.com/rust-lang/rust/pull/85218, https://github.com/rust-lang/rust/pull/84061, https://github.com/rust-lang/rust/pull/87150. Functions that do very basic operations are made `#[inline(always)]` to avoid pessimizing them in debug builds when compared to using built-in operations directly.

18 months agoAuto merge of #104572 - pkubaj:patch-1, r=cuviper
bors [Fri, 9 Dec 2022 12:00:58 +0000 (12:00 +0000)]
Auto merge of #104572 - pkubaj:patch-1, r=cuviper

Fix build on powerpc-unknown-freebsd

Probably also fixes build on arm and mips*. Related to https://github.com/rust-lang/rust/issues/104220

18 months agoAuto merge of #105486 - matthiaskrgr:rollup-o7c4l1c, r=matthiaskrgr
bors [Fri, 9 Dec 2022 09:19:26 +0000 (09:19 +0000)]
Auto merge of #105486 - matthiaskrgr:rollup-o7c4l1c, r=matthiaskrgr

Rollup of 10 pull requests

Successful merges:

 - #105216 (Remove unused GUI test)
 - #105245 (attempt to clarify align_to docs)
 - #105387 (Improve Rustdoc scrape-examples UI)
 - #105389 (Enable profiler in dist-powerpc64le-linux)
 - #105427 (Dont silently ignore rustdoc errors)
 - #105442 (rustdoc: clean up docblock table CSS)
 - #105443 (Move some queries and methods)
 - #105455 (use the correct `Reveal` during validation)
 - #105470 (Clippy: backport ICE fix before beta branch)
 - #105474 (lib docs: fix typo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

18 months agoRollup merge of #105474 - RalfJung:typo, r=dtolnay
Matthias Krüger [Fri, 9 Dec 2022 06:25:48 +0000 (07:25 +0100)]
Rollup merge of #105474 - RalfJung:typo, r=dtolnay

lib docs: fix typo

r? `@thomcc`

18 months agoRollup merge of #105470 - flip1995:clippy_backport, r=Manishearth
Matthias Krüger [Fri, 9 Dec 2022 06:25:47 +0000 (07:25 +0100)]
Rollup merge of #105470 - flip1995:clippy_backport, r=Manishearth

Clippy: backport ICE fix before beta branch

r? `@Manishearth`

Before beta is branched tomorrow we should backport the fix from https://github.com/rust-lang/rust-clippy/pull/10027 for an ICE. That way we'll get this into stable one release sooner.

This only cherry-picks the fix, not the tests for it. The proper sync of this will be done next week Thursday.

18 months agoRollup merge of #105455 - lcnr:correct-reveal-in-validate, r=jackh726
Matthias Krüger [Fri, 9 Dec 2022 06:25:47 +0000 (07:25 +0100)]
Rollup merge of #105455 - lcnr:correct-reveal-in-validate, r=jackh726

use the correct `Reveal` during validation

supersedes #105454. Deals with https://github.com/rust-lang/rust/issues/105009#issuecomment-1342395333, not closing #105009 as the ICE may leak into beta

The issue was the following:
- we optimize the mir, using `Reveal::All`
- some optimization relies on the hidden type of an opaque type
- we then validate using `Reveal::UserFacing` again which is not able to observe the hidden type

r? `@jackh726`

18 months agoRollup merge of #105443 - compiler-errors:move-more, r=oli-obk
Matthias Krüger [Fri, 9 Dec 2022 06:25:46 +0000 (07:25 +0100)]
Rollup merge of #105443 - compiler-errors:move-more, r=oli-obk

Move some queries and methods

Each commit's title should be self-explanatory. Motivated to break up some large, general files and move queries into leaf crates.

18 months agoRollup merge of #105442 - notriddle:notriddle/docblock-table-css, r=GuillaumeGomez
Matthias Krüger [Fri, 9 Dec 2022 06:25:46 +0000 (07:25 +0100)]
Rollup merge of #105442 - notriddle:notriddle/docblock-table-css, r=GuillaumeGomez

rustdoc: clean up docblock table CSS

# Preview

http://notriddle.com/notriddle-rustdoc-demos/table-2/test_dingus/fn.test.html

# Before

![image](https://user-images.githubusercontent.com/1593513/206364287-1b80eaaf-2e0e-4138-8b56-4aa8ff39abac.png)

# After

![image](https://user-images.githubusercontent.com/1593513/206364209-d287d165-31be-4de1-9b43-05b35ce2a86b.png)

# Details

* The rule `display: block` had no noticeable effect. Technically, because markdown tables have a tbody and thead, they get wrapped in an [anonymous table box] in the CSS tree, nested within the `<table>` element's block layout box.

  This rule was added in #87230 to make the table side-scrolling, but this same issue was doubly fixed in #88742 by wrapping it in an explicit `<div>` tag. Since accessibility advocates recommend the wrapper div over marking the table as `display: block`, we'll stick with that.

  https://adrianroselli.com/2020/11/under-engineered-responsive-tables.html

* The rule `width: calc(100% - 2px)` had no visible effect, because the anonymous table box was not affected.

* The style is tweaked to basically be the same style GitHub uses. In particular, it adds zebra stripes, and removes dotted borders.

  https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/Markdown.20table.20styling

[anonymous table box]: https://www.w3.org/TR/CSS2/tables.html#anonymous-boxes

18 months agoRollup merge of #105427 - GuillaumeGomez:dont-silently-ignore-rustdoc-errors, r=notriddle
Matthias Krüger [Fri, 9 Dec 2022 06:25:45 +0000 (07:25 +0100)]
Rollup merge of #105427 - GuillaumeGomez:dont-silently-ignore-rustdoc-errors, r=notriddle

Dont silently ignore rustdoc errors

I applied the suggestions from https://github.com/rust-lang/rust/pull/104995 and also checked the rustdoc-ui error but couldn't reproduce it.

r? `@notriddle`

18 months agoRollup merge of #105389 - ogarokpeter:patch-1, r=Mark-Simulacrum
Matthias Krüger [Fri, 9 Dec 2022 06:25:45 +0000 (07:25 +0100)]
Rollup merge of #105389 - ogarokpeter:patch-1, r=Mark-Simulacrum

Enable profiler in dist-powerpc64le-linux

Build the profiler runtime to allow using -C profile-generate and -C instrument-coverage on POWER little endian systems.

I have verified locally that the runtime builds and the profiler is working fine on the platform.

Similar pull request for a different system: https://github.com/rust-lang/rust/pull/104304

18 months agoRollup merge of #105387 - willcrichton:scrape-examples-ui-improvements, r=notriddle
Matthias Krüger [Fri, 9 Dec 2022 06:25:44 +0000 (07:25 +0100)]
Rollup merge of #105387 - willcrichton:scrape-examples-ui-improvements, r=notriddle

Improve Rustdoc scrape-examples UI

This PR combines a few different improvements to the scrape-examples UI. See a live demo here: https://willcrichton.net/misc/scrape-examples/small-first-example/clap/struct.Arg.html

### 1. The first scraped example now takes up significantly less screen height.
Inserting the first scraped example takes up a lot of vertical screen space. I don't want this addition to overwhelm users, so I decided to reduce the height of the initial example in two ways: (A) the default un-expanded height is reduced from 240px (10 LOC) to 120px (5 LOC), and (B) the link to the example is now positioned *over* the example instead of *atop* the example (only on desktop though, not mobile). The changes to `scrape-examples.js` and `rustdoc.css` implement this fix.

Here is what an example docblock now looks like:

![Screen Shot 2022-12-06 at 10 02 21 AM](https://user-images.githubusercontent.com/663326/205987450-3940063c-5973-4a34-8579-baff6a43aa9b.png)

### 2. Expanding all docblocks will not expand "More examples".
The "More examples blocks" are huge, so fully expanding everything on the page would take up too much vertical space. The changes to `main.js` implement this fix. This is tested in `scrape-examples-toggle.goml`.

### 3. Examples from binary crates are sorted higher than examples from library crates.
Code that is written as an example of an API is probably better for learning than code that happens to use an API, but isn't intended for pedagogic purposes. Unfortunately Rustc doesn't know whether a particular crate comes from an example target (only Cargo knows this). But we can at least create a proxy that prefers examples from binary crates over library crates, which we know from `--crate-type`.

This change is implemented by adding a new field `bin_crate` in `Options` (see `config.rs`). An `is_bin` field has been added to the scraped examples metadata (see `scrape_examples.rs`). Then the example sorting metric uses `is_bin` as the first entry of a lexicographic sort on `(is_bin, example_size, display_name)` (see `render/mod.rs`).

Note that in the future we can consider adding another flag like `--scrape-examples-cargo-target` that would pass target information from Cargo into the example metadata. But I'm proposing a less intrusive change for now.

### 4. The scrape-examples help page has been updated to reflect the latest Cargo interface.

See `scrape-examples-help.md`.

r? `@notriddle`

P.S. once this PR and rust-lang/cargo#11450 are merged, then I think the scrape-examples feature is officially ready for deployment on docs.rs!

18 months agoRollup merge of #105245 - RalfJung:align_to, r=Amanieu
Matthias Krüger [Fri, 9 Dec 2022 06:25:44 +0000 (07:25 +0100)]
Rollup merge of #105245 - RalfJung:align_to, r=Amanieu

attempt to clarify align_to docs

This is not intended the change the docs at all, but `@workingjubilee` said the current docs are incomprehensible to some people so this is an attempt to fix that. No idea if it helps, so -- feedback welcome.

(Please let's not use this to discuss *changing* the spec. Whoever wants to change the spec should please make a separate PR for that.)

18 months agoRollup merge of #105216 - GuillaumeGomez:rm-unused-gui-test, r=notriddle
Matthias Krüger [Fri, 9 Dec 2022 06:25:43 +0000 (07:25 +0100)]
Rollup merge of #105216 - GuillaumeGomez:rm-unused-gui-test, r=notriddle

Remove unused GUI test

It's not testing anything so better just remove it.

r? `@notriddle`

18 months agoAuto merge of #104449 - oli-obk:unhide_unknown_spans, r=estebank,RalfJung
bors [Fri, 9 Dec 2022 06:24:28 +0000 (06:24 +0000)]
Auto merge of #104449 - oli-obk:unhide_unknown_spans, r=estebank,RalfJung

Start emitting labels even if their pointed to file is not available locally

r? `@estebank`

cc `@RalfJung`

fixes #97699

18 months agoAuto merge of #105456 - matthiaskrgr:rollup-yennygf, r=matthiaskrgr
bors [Fri, 9 Dec 2022 03:05:27 +0000 (03:05 +0000)]
Auto merge of #105456 - matthiaskrgr:rollup-yennygf, r=matthiaskrgr

Rollup of 10 pull requests

Successful merges:

 - #104922 (Detect long types in E0308 and write them to disk)
 - #105120 (kmc-solid: `std::sys` code maintenance)
 - #105255 (Make nested RPIT inherit the parent opaque's generics.)
 - #105317 (make retagging work even with 'unstable' places)
 - #105405 (Stop passing -export-dynamic to wasm-ld.)
 - #105408 (Add help for `#![feature(impl_trait_in_fn_trait_return)]`)
 - #105423 (Use `Symbol` for the crate name instead of `String`/`str`)
 - #105433 (CI: add missing line continuation marker)
 - #105434 (Fix warning when libcore is compiled with no_fp_fmt_parse)
 - #105441 (Remove `UnsafetyState`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

18 months agoFix build on powerpc-unknown-freebsd
pkubaj [Fri, 18 Nov 2022 12:36:49 +0000 (12:36 +0000)]
Fix build on powerpc-unknown-freebsd

Probably also fixes build on mips*. Related to https://github.com/rust-lang/rust/issues/104220

18 months agoAuto merge of #105477 - tmiasko:make, r=ehuss
bors [Thu, 8 Dec 2022 23:50:39 +0000 (23:50 +0000)]
Auto merge of #105477 - tmiasko:make, r=ehuss

Ignore errors when including clear_expected_if_blessed

Include is there only for the effect executing the rule. The file is not intended to be remade successfully to be actually included.

I erroneously changed this in #100912.

18 months agoIgnore errors when including clear_expected_if_blessed
Tomasz Miąsko [Thu, 8 Dec 2022 00:00:00 +0000 (00:00 +0000)]
Ignore errors when including clear_expected_if_blessed

Include is there only for the effect executing the rule.
The file is not intended to be remade successfully to be
actually included.

18 months agolib docs: fix typo
Ralf Jung [Thu, 8 Dec 2022 21:36:57 +0000 (22:36 +0100)]
lib docs: fix typo

18 months agoFix #10021
Samuel Moelius [Sat, 3 Dec 2022 01:41:29 +0000 (20:41 -0500)]
Fix #10021

18 months agorustdoc: add GUI test case for docblock table colors
Michael Howell [Thu, 8 Dec 2022 16:38:27 +0000 (09:38 -0700)]
rustdoc: add GUI test case for docblock table colors

18 months agoUpdate rustdoc test to check its error output
Guillaume Gomez [Wed, 7 Dec 2022 15:08:58 +0000 (16:08 +0100)]
Update rustdoc test to check its error output

18 months agoRollup merge of #105441 - nnethercote:rm-UnsafetyState, r=lcnr
Matthias Krüger [Thu, 8 Dec 2022 11:57:33 +0000 (12:57 +0100)]
Rollup merge of #105441 - nnethercote:rm-UnsafetyState, r=lcnr

Remove `UnsafetyState`

r? `@lcnr`

18 months agoRollup merge of #105434 - nbdd0121:lib, r=thomcc
Matthias Krüger [Thu, 8 Dec 2022 11:57:33 +0000 (12:57 +0100)]
Rollup merge of #105434 - nbdd0121:lib, r=thomcc

Fix warning when libcore is compiled with no_fp_fmt_parse

Discovered when trying to compile Rust-for-Linux with Rust 1.66 beta.

It'll be helpful if this is backported to beta (should be trivial enough for backporting), so Rust-for-Linux's rust version bump wouldn't need to do `--cap-lints allow` for libcore.

18 months agoRollup merge of #105433 - ComputerDruid:docker_continuation_fix, r=jyn514
Matthias Krüger [Thu, 8 Dec 2022 11:57:32 +0000 (12:57 +0100)]
Rollup merge of #105433 - ComputerDruid:docker_continuation_fix, r=jyn514

CI: add missing line continuation marker

Resolves this docker warning:

```
[WARNING]: Empty continuation line found in:
    RUN apt-get update && apt-get install -y --no-install-recommends   g++   gcc-multilib   make   ninja-build   file   curl   ca-certificates   python2.7   python3.9   git   cmake   sudo   gdb   llvm-13-tools   llvm-13-dev   libedit-dev   libssl-dev   pkg-config   zlib1g-dev   xz-utils   nodejs     apt-transport-https software-properties-common &&     curl -s "https://packages.microsoft.com/config/ubuntu/$(lsb_release -rs)/packages-microsoft-prod.deb" > packages-microsoft-prod.deb &&     dpkg -i packages-microsoft-prod.deb &&     apt-get update &&     apt-get install -y powershell     && rm -rf /var/lib/apt/lists/*
Warning: : Empty continuation lines will become errors in a future release.
```

18 months agoRollup merge of #105423 - oli-obk:symbols, r=jackh726
Matthias Krüger [Thu, 8 Dec 2022 11:57:32 +0000 (12:57 +0100)]
Rollup merge of #105423 - oli-obk:symbols, r=jackh726

Use `Symbol` for the crate name instead of `String`/`str`

It always got converted to a symbol anyway

18 months agoRollup merge of #105408 - cuviper:help-rpitirpit, r=compiler-errors
Matthias Krüger [Thu, 8 Dec 2022 11:57:31 +0000 (12:57 +0100)]
Rollup merge of #105408 - cuviper:help-rpitirpit, r=compiler-errors

Add help for `#![feature(impl_trait_in_fn_trait_return)]`

This adds a new variant `ImplTraitContext::FeatureGated`, so we can
generalize the help for `return_position_impl_trait_in_trait` to also
work for `impl_trait_in_fn_trait_return`.

cc #99697

18 months agoRollup merge of #105405 - sunfishcode:sunfishcode/export-dynamic, r=TaKO8Ki
Matthias Krüger [Thu, 8 Dec 2022 11:57:30 +0000 (12:57 +0100)]
Rollup merge of #105405 - sunfishcode:sunfishcode/export-dynamic, r=TaKO8Ki

Stop passing -export-dynamic to wasm-ld.

-export-dynamic was a temporary hack added in the early days of the Rust wasm32 target when Rust didn't have a way to specify wasm exports in the source code. This flag causes all global symbols, and some compiler-internal symbols, to be exported, which is often more than needed.

Rust now does have a way to specify exports in the source code: `#[export_name = "..."]`.

So as the original comment suggests, -export-dynamic can now be removed, allowing users to have smaller binaries and better encapsulation in their wasm32-unknown-unknown modules.

It's possible that this change will require existing wasm32-unknown-unknown users will to add explicit `#[export_name = "..."]` directives to exporrt the symbols that their programs depend on having exported.

18 months agoRollup merge of #105317 - RalfJung:retag-rework, r=oli-obk
Matthias Krüger [Thu, 8 Dec 2022 11:57:30 +0000 (12:57 +0100)]
Rollup merge of #105317 - RalfJung:retag-rework, r=oli-obk

make retagging work even with 'unstable' places

This is based on top of https://github.com/rust-lang/rust/pull/105301. Only the last two commits are new.

While investigating https://github.com/rust-lang/unsafe-code-guidelines/issues/381 I realized that we would have caught this issue much earlier if the add_retag pass wouldn't bail out on assignments of the form `*ptr = ...`.

So this PR changes our retag strategy:
- When a new reference is created via `Rvalue::Ref` (or a raw ptr via `Rvalue::AddressOf`), we do the retagging as part of just executing that address-taking operation.
- For everything else, we still insert retags -- these retags basically serve to ensure that references stored in local variables (and their fields) are always freshly tagged, so skipping this for assignments like `*ptr = ...` is less egregious.
r? ```@oli-obk```

18 months agoRollup merge of #105255 - cjgillot:issue-105197, r=compiler-errors
Matthias Krüger [Thu, 8 Dec 2022 11:57:29 +0000 (12:57 +0100)]
Rollup merge of #105255 - cjgillot:issue-105197, r=compiler-errors

Make nested RPIT inherit the parent opaque's generics.

Fixes https://github.com/rust-lang/rust/issues/105197

r? ```@compiler-errors```

18 months agoRollup merge of #105120 - solid-rs:patch/kmc-solid/maintainance, r=thomcc
Matthias Krüger [Thu, 8 Dec 2022 11:57:29 +0000 (12:57 +0100)]
Rollup merge of #105120 - solid-rs:patch/kmc-solid/maintainance, r=thomcc

kmc-solid: `std::sys` code maintenance

Includes a set of changes to fix the [`*-kmc-solid_*`](https://doc.rust-lang.org/nightly/rustc/platform-support/kmc-solid.html) Tier 3 targets and make some other improvements.

- Address `fuzzy_provenance_casts` by using `expose_addr` and `from_exposed_addr` for pointer-integer casts
- Add a stub implementation of `is_terminal` (#98070)
- Address `unused_imports` and `unused_unsafe`
- Stop doing `Box::from_raw(&*(x: Box<T>) as *const T as *mut T)`

18 months agoRollup merge of #104922 - estebank:fur-elize, r=oli-obk
Matthias Krüger [Thu, 8 Dec 2022 11:57:28 +0000 (12:57 +0100)]
Rollup merge of #104922 - estebank:fur-elize, r=oli-obk

Detect long types in E0308 and write them to disk

On type error with long types, print an abridged type and write the full type to disk.

Print the widest possible short type while still fitting in the terminal.

18 months agoadd regression test for #105009
lcnr [Thu, 8 Dec 2022 11:23:10 +0000 (12:23 +0100)]
add regression test for #105009

18 months agovalidate: use the correct reveal during opts
lcnr [Thu, 8 Dec 2022 10:24:25 +0000 (11:24 +0100)]
validate: use the correct reveal during opts

18 months agoAuto merge of #105415 - nikic:update-llvm-10, r=cuviper
bors [Thu, 8 Dec 2022 07:46:42 +0000 (07:46 +0000)]
Auto merge of #105415 - nikic:update-llvm-10, r=cuviper

Update LLVM submodule

This is a rebase to LLVM 15.0.6.

Fixes #103380.
Fixes #104099.

18 months agoMove some suggestions from error_reporting to error_reporting::suggest
Michael Goulet [Thu, 8 Dec 2022 05:58:30 +0000 (05:58 +0000)]
Move some suggestions from error_reporting to error_reporting::suggest

18 months agorustdoc: clean up docblock table CSS
Michael Howell [Thu, 8 Dec 2022 04:59:54 +0000 (21:59 -0700)]
rustdoc: clean up docblock table CSS

* The rule `display: block` had no noticeable effect. Technically, because
  markdown tables have a tbody and thead, they get wrapped in an [anonymous
  table box] in the CSS tree, nested within the `<table>` element's block
  layout box.

  This rule was added in #87230 to make the table side-scrolling, but
  this same issue was doubly fixed in #88742 by wrapping it in an explicit
  `<div>` tag. Since accessibility advocates recommend the wrapper div over
  marking the table as `display: block`, we'll stick with that.

  https://adrianroselli.com/2020/11/under-engineered-responsive-tables.html

* The rule `width: calc(100% - 2px)` had no visible effect, because the
  anonymous table box was not affected.

* The style is tweaked to basically be the same style GitHub uses.
  In particular, it adds zebra stripes, and removes dotted borders.

[anonymous table box]: https://www.w3.org/TR/CSS2/tables.html#anonymous-boxes

18 months agoMove codegen_select_candidate to a rustc_traits
Michael Goulet [Thu, 8 Dec 2022 05:16:39 +0000 (05:16 +0000)]
Move codegen_select_candidate to a rustc_traits

18 months agoMove vtable methods into its own module
Michael Goulet [Thu, 8 Dec 2022 04:51:46 +0000 (04:51 +0000)]
Move vtable methods into its own module

18 months agoMove has_structural_eq_impls provider to rustc_ty_utils
Michael Goulet [Thu, 8 Dec 2022 04:02:50 +0000 (04:02 +0000)]
Move has_structural_eq_impls provider to rustc_ty_utils

18 months agoFix a typo.
Nicholas Nethercote [Thu, 8 Dec 2022 04:53:31 +0000 (15:53 +1100)]
Fix a typo.

18 months agoRemove `UnsafetyState`.
Nicholas Nethercote [Thu, 8 Dec 2022 04:42:12 +0000 (15:42 +1100)]
Remove `UnsafetyState`.

`FnCtxt::ps` is the only occurrence. It gets updated during HIR
typechecking, but is never looked at.

18 months agoAuto merge of #105425 - matthiaskrgr:rollup-3ngvxmt, r=matthiaskrgr
bors [Thu, 8 Dec 2022 03:04:51 +0000 (03:04 +0000)]
Auto merge of #105425 - matthiaskrgr:rollup-3ngvxmt, r=matthiaskrgr

Rollup of 6 pull requests

Successful merges:

 - #105267 (Don't ICE in ExprUseVisitor on FRU for non-existent struct)
 - #105343 (Simplify attribute handling in rustc_ast_lowering)
 - #105368 (Remove more `ref` patterns from the compiler)
 - #105400 (normalize before handling simple checks for evaluatability of `ty::Const`)
 - #105403 (rustdoc: simplify CSS selectors for item table `.stab`)
 - #105418 (fix: remove hack from link.rs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

18 months agoFix warning when libcore is compiled with no_fp_fmt_parse
Gary Guo [Thu, 8 Dec 2022 00:07:00 +0000 (00:07 +0000)]
Fix warning when libcore is compiled with no_fp_fmt_parse

18 months agoCI: add missing line continuation marker
Dan Johnson [Wed, 7 Dec 2022 22:15:56 +0000 (14:15 -0800)]
CI: add missing line continuation marker

Resolves this docker warning:

```
[WARNING]: Empty continuation line found in:
    RUN apt-get update && apt-get install -y --no-install-recommends   g++   gcc-multilib   make   ninja-build   file   curl   ca-certificates   python2.7   python3.9   git   cmake   sudo   gdb   llvm-13-tools   llvm-13-dev   libedit-dev   libssl-dev   pkg-config   zlib1g-dev   xz-utils   nodejs     apt-transport-https software-properties-common &&     curl -s "https://packages.microsoft.com/config/ubuntu/$(lsb_release -rs)/packages-microsoft-prod.deb" > packages-microsoft-prod.deb &&     dpkg -i packages-microsoft-prod.deb &&     apt-get update &&     apt-get install -y powershell     && rm -rf /var/lib/apt/lists/*
Warning: : Empty continuation lines will become errors in a future release.
```

18 months agoUse `Symbol` for the crate name instead of `String`/`str`
Oli Scherer [Tue, 6 Dec 2022 12:46:10 +0000 (12:46 +0000)]
Use `Symbol` for the crate name instead of `String`/`str`

18 months agoImprove calculation of scraped example minimized height
Will Crichton [Wed, 7 Dec 2022 18:24:16 +0000 (10:24 -0800)]
Improve calculation of scraped example minimized height

18 months agoRevert crate_types change, add new bin_crate field
Will Crichton [Tue, 6 Dec 2022 20:56:02 +0000 (12:56 -0800)]
Revert crate_types change, add new bin_crate field

18 months agoFix rustdoc error with no providec crate-type, fix scrape examples button colors...
Will Crichton [Tue, 6 Dec 2022 19:24:26 +0000 (11:24 -0800)]
Fix rustdoc error with no providec crate-type, fix scrape examples button colors w/ themes

18 months agoFix es-check
Will Crichton [Tue, 6 Dec 2022 18:22:23 +0000 (10:22 -0800)]
Fix es-check

18 months agoUpdate scrape-examples help, fix documentation typos
Will Crichton [Tue, 6 Dec 2022 18:11:55 +0000 (10:11 -0800)]
Update scrape-examples help, fix documentation typos

18 months agoFactor scrape-examples toggle test into a new file
Will Crichton [Tue, 6 Dec 2022 17:59:49 +0000 (09:59 -0800)]
Factor scrape-examples toggle test into a new file

18 months agoInclude additional documentation for scrape-examples changes
Will Crichton [Tue, 6 Dec 2022 17:34:37 +0000 (09:34 -0800)]
Include additional documentation for scrape-examples changes

18 months agoOnly put title over example on large screens
Will Crichton [Tue, 6 Dec 2022 07:48:07 +0000 (23:48 -0800)]
Only put title over example on large screens

18 months agoAdd explanations to scrape-examples integration test
Will Crichton [Tue, 6 Dec 2022 07:34:02 +0000 (23:34 -0800)]
Add explanations to scrape-examples integration test

18 months agoImprove several aspects of the Rustdoc scrape-examples UI.
Will Crichton [Sun, 27 Nov 2022 19:11:21 +0000 (13:11 -0600)]
Improve several aspects of the Rustdoc scrape-examples UI.
* Examples take up less screen height.
* Snippets from binary crates are prioritized.
* toggle-all-docs does not expand "More examples" sections.

18 months agoMake some trivial functions `#[inline(always)]`
Eduardo Sánchez Muñoz [Wed, 7 Dec 2022 16:11:17 +0000 (17:11 +0100)]
Make some trivial functions `#[inline(always)]`

18 months agoDon't silently ignore errors that happen during rendering
Guillaume Gomez [Wed, 7 Dec 2022 15:08:13 +0000 (16:08 +0100)]
Don't silently ignore errors that happen during rendering

18 months agoRollup merge of #105418 - BelovDV:fix-libc-hack, r=petrochenkov
Matthias Krüger [Wed, 7 Dec 2022 14:39:09 +0000 (15:39 +0100)]
Rollup merge of #105418 - BelovDV:fix-libc-hack, r=petrochenkov

fix: remove hack from link.rs

This logic implemented in libc.

r? `@petrochenkov`

18 months agoRollup merge of #105403 - notriddle:notriddle/item-stab-css, r=GuillaumeGomez
Matthias Krüger [Wed, 7 Dec 2022 14:39:09 +0000 (15:39 +0100)]
Rollup merge of #105403 - notriddle:notriddle/item-stab-css, r=GuillaumeGomez

rustdoc: simplify CSS selectors for item table `.stab`

The module-item and import-item classes are attached to the item-left. Just target that, instead.

18 months agoRollup merge of #105400 - BoxyUwU:braced_param_evaluatability, r=oli-obk
Matthias Krüger [Wed, 7 Dec 2022 14:39:08 +0000 (15:39 +0100)]
Rollup merge of #105400 - BoxyUwU:braced_param_evaluatability, r=oli-obk

normalize before handling simple checks for evaluatability of `ty::Const`

`{{{{{{{ N }}}}}}}` is desugared into a `ConstKind::Unevaluated` for an anonymous `const` item so when calling `is_const_evaluatable` on it we skip the `ConstKind::Param(_) => Ok(())` arm which is incorrect.

18 months agoRollup merge of #105368 - WaffleLapkin:deref-even-harder, r=TaKO8Ki
Matthias Krüger [Wed, 7 Dec 2022 14:39:07 +0000 (15:39 +0100)]
Rollup merge of #105368 - WaffleLapkin:deref-even-harder, r=TaKO8Ki

Remove more `ref` patterns from the compiler

Previous PR: #105045

18 months agoRollup merge of #105343 - nbdd0121:hir, r=fee1-dead
Matthias Krüger [Wed, 7 Dec 2022 14:39:07 +0000 (15:39 +0100)]
Rollup merge of #105343 - nbdd0121:hir, r=fee1-dead

Simplify attribute handling in rustc_ast_lowering

Given that attributes is stored in a separate BTreeMap, it's not necessary to pass it in when constructing `hir::Expr`. We can just construct `hir::Expr` and then call `self.lower_attrs` later if it needs attributes.

As most desugaring code don't use attributes, this allows some code cleanup.

18 months agoRollup merge of #105267 - compiler-errors:issue-104613, r=oli-obk
Matthias Krüger [Wed, 7 Dec 2022 14:39:06 +0000 (15:39 +0100)]
Rollup merge of #105267 - compiler-errors:issue-104613, r=oli-obk

Don't ICE in ExprUseVisitor on FRU for non-existent struct

Fixes #104613
Fixes #105202

18 months agoAuto merge of #103459 - ChrisDenton:propagate-nulls, r=thomcc
bors [Wed, 7 Dec 2022 13:52:52 +0000 (13:52 +0000)]
Auto merge of #103459 - ChrisDenton:propagate-nulls, r=thomcc

Pass on null handle values to child process

Fixes #101645

In Windows, stdio handles are (semantically speaking) `Option<Handle>` where `Handle` is a non-zero value. When spawning a process with `Stdio::Inherit`, Rust currently turns zero values into `-1` values. This has the unfortunate effect of breaking console subprocesses (which typically need stdio) that are spawned from gui applications (that lack stdio by default) because the console process won't be assigned handles from the newly created console (as they usually would in that situation). Worse, `-1` is actually [a valid handle](https://doc.rust-lang.org/std/os/windows/io/struct.OwnedHandle.html) which means "the current process". So if a console process, for example, waits on stdin and it has a `-1` value then the process will end up waiting on itself.

This PR fixes it by propagating the nulls instead of converting them to `-1`.

While I think the current behaviour is a mistake, changing it (however justified) is an API change so I think this PR should at least have some input from t-libs-api. So choosing at random...

r? `@joshtriplett`

18 months agoMake -Zsimulate-remapped-rust-src-base reproducible on CI
Oli Scherer [Wed, 7 Dec 2022 10:36:08 +0000 (10:36 +0000)]
Make -Zsimulate-remapped-rust-src-base reproducible on CI

18 months agoAuto merge of #104799 - pcc:linkage-fn, r=tmiasko
bors [Wed, 7 Dec 2022 10:24:59 +0000 (10:24 +0000)]
Auto merge of #104799 - pcc:linkage-fn, r=tmiasko

Support Option and similar enums as type of static variable with linkage attribute

Compiler MCP:
rust-lang/compiler-team#565

18 months agofix: remove hack from link.rs (moved to libc)
Daniil Belov [Wed, 7 Dec 2022 10:13:58 +0000 (13:13 +0300)]
fix: remove hack from link.rs (moved to libc)

18 months agoAvoid remapping paths back to `$SRC_DIR` in CI
Oli Scherer [Wed, 7 Dec 2022 09:19:49 +0000 (09:19 +0000)]
Avoid remapping paths back to `$SRC_DIR` in CI

18 months agoUpdate LLVM submodule
Nikita Popov [Wed, 7 Dec 2022 07:40:49 +0000 (08:40 +0100)]
Update LLVM submodule

18 months agoAuto merge of #105395 - sunfishcode:sunfishcode/update-wasi, r=pietroalbini
bors [Wed, 7 Dec 2022 06:16:19 +0000 (06:16 +0000)]
Auto merge of #105395 - sunfishcode:sunfishcode/update-wasi, r=pietroalbini

Update the wasi toolchain.

Update the WASI build to LLVM 15.0 and the wasi-libc version from [wasi-sdk-17].

This will require a ci-mirrors.rust-lang.org file load. Specifically, we need [this LLVM release tarball] uploaded to be downloadable from [this URL].

The biggest change in wasi-sdk-17 is that user exports no longer automatically run constructor functions. More details at: https://github.com/WebAssembly/WASI/issues/493.

[this LLVM release tarball]: https://github.com/llvm/llvm-project/releases/download/llvmorg-15.0.6/clang+llvm-15.0.6-x86_64-linux-gnu-ubuntu-18.04.tar.xz
[this URL]: https://ci-mirrors.rust-lang.org/rustc/2022-12-06-clang%2Bllvm-15.0.6-x86_64-linux-gnu-ubuntu-18.04.tar.xz
[wasi-sdk-17]: https://github.com/WebAssembly/wasi-sdk/releases/tag/wasi-sdk-17

18 months agoAuto merge of #105291 - nnethercote:remove-LintPassObjects, r=cjgillot
bors [Wed, 7 Dec 2022 03:52:19 +0000 (03:52 +0000)]
Auto merge of #105291 - nnethercote:remove-LintPassObjects, r=cjgillot

Remove `{Early,Late}LintPassObjects`.

`EarlyContextAndPass` wraps a single early lint pass. We aggregate multiple passes into that single pass by using `EarlyLintPassObjects`.

This commit removes `EarlyLintPassObjects` by changing `EarlyContextAndPass` into `EarlyContextAndPasses`. I.e. it just removes a level of indirection. This makes the code simpler and slightly faster.

The commit does likewise for late lints.

r? `@cjgillot`

18 months agoAdd help for `#![feature(impl_trait_in_fn_trait_return)]`
Josh Stone [Wed, 7 Dec 2022 01:53:50 +0000 (17:53 -0800)]
Add help for `#![feature(impl_trait_in_fn_trait_return)]`

This adds a new variant `ImplTraitContext::FeatureGated`, so we can
generalize the help for `return_position_impl_trait_in_trait` to also
work for `impl_trait_in_fn_trait_return`.

18 months agoStop passing -export-dynamic to wasm-ld.
Dan Gohman [Wed, 7 Dec 2022 00:50:29 +0000 (16:50 -0800)]
Stop passing -export-dynamic to wasm-ld.

-export-dynamic was a temporary hack added in the early days of the Rust
wasm32 target when Rust didn't have a way to specify wasm exports in the
source code. This flag causes all global symbols, and some compiler-internal
symbols, to be exported, which is often more than needed.

Rust now does have a way to specify exports in the source code:
`#[export_name = "..."]`.

So as the original comment suggests, -export-dynamic can now be removed,
allowing users to have smaller binaries and better encapsulation in
their wasm32-unknown-unknown modules.

It's possible that this change will require existing wasm32-unknown-unknown
users will to add explicit `#[export_name = "..."]` directives to
exporrt the symbols that their programs depend on having exported.

18 months agoAuto merge of #105397 - matthiaskrgr:rollup-xv5imz8, r=matthiaskrgr
bors [Wed, 7 Dec 2022 00:32:57 +0000 (00:32 +0000)]
Auto merge of #105397 - matthiaskrgr:rollup-xv5imz8, r=matthiaskrgr

Rollup of 6 pull requests

Successful merges:

 - #105298 (llvm-wrapper: adapt for an LLVM API change)
 - #105358 (Add a test for #104260)
 - #105380 (add const generics ping files things for me)
 - #105382 (remove an excess `this`)
 - #105388 (rustdoc: remove redundant CSS `.import-item .stab { font-size }`)
 - #105390 (unstable-book: Add `ignore` to `abi_efiapi` example code)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

18 months agorustdoc: simplify CSS selectors for item table `.stab`
Michael Howell [Wed, 7 Dec 2022 00:05:43 +0000 (17:05 -0700)]
rustdoc: simplify CSS selectors for item table `.stab`

The module-item and import-item classes are attached to the item-left.
Just target that, instead.

18 months agonormalize before matching on `ConstKind`
Boxy [Tue, 6 Dec 2022 22:53:08 +0000 (22:53 +0000)]
normalize before matching on `ConstKind`

18 months agoRollup merge of #105390 - nicholasbishop:bishop-example-ignore, r=ehuss
Matthias Krüger [Tue, 6 Dec 2022 22:13:52 +0000 (23:13 +0100)]
Rollup merge of #105390 - nicholasbishop:bishop-example-ignore, r=ehuss

unstable-book: Add `ignore` to `abi_efiapi` example code

This example doesn't compile on targets that don't support UEFI, as reported here:
https://github.com/rust-lang/rust/pull/104793#issuecomment-1339783727

18 months agoRollup merge of #105388 - notriddle:notriddle/item-stab-font-size, r=GuillaumeGomez
Matthias Krüger [Tue, 6 Dec 2022 22:13:51 +0000 (23:13 +0100)]
Rollup merge of #105388 - notriddle:notriddle/item-stab-font-size, r=GuillaumeGomez

rustdoc: remove redundant CSS `.import-item .stab { font-size }`

This sets the exact same font size that `.stab` has by default anyway. It used to be slightly different, but dd5ff428edbc7cd4fa600b81f27bbec28589704f made it identical.

18 months agoRollup merge of #105382 - BoxyUwU:fixme_typo_sadface, r=lcnr
Matthias Krüger [Tue, 6 Dec 2022 22:13:51 +0000 (23:13 +0100)]
Rollup merge of #105382 - BoxyUwU:fixme_typo_sadface, r=lcnr

remove an excess `this`

18 months agoRollup merge of #105380 - BoxyUwU:triagebot_ping_pls, r=lcnr
Matthias Krüger [Tue, 6 Dec 2022 22:13:50 +0000 (23:13 +0100)]
Rollup merge of #105380 - BoxyUwU:triagebot_ping_pls, r=lcnr

add const generics ping files things for me

r? `@lcnr`

18 months agoRollup merge of #105358 - TaKO8Ki:fix-104260, r=estebank
Matthias Krüger [Tue, 6 Dec 2022 22:13:50 +0000 (23:13 +0100)]
Rollup merge of #105358 - TaKO8Ki:fix-104260, r=estebank

Add a test for #104260

Fixes #104260

18 months agoRollup merge of #105298 - krasimirgg:llvm-16-dec-1, r=cuviper
Matthias Krüger [Tue, 6 Dec 2022 22:13:49 +0000 (23:13 +0100)]
Rollup merge of #105298 - krasimirgg:llvm-16-dec-1, r=cuviper

llvm-wrapper: adapt for an LLVM API change

Adapts llvm-wrapper for https://github.com/llvm/llvm-project/commit/8c7c20f033c7036a8bf231ca6f9e02172cb581f0.
No functional changes intended.

Found via our experimental rust + llvm @ HEAD bot: https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/15404#0184d95d-5a68-4db6-ad32-51ddbc3ab543/202-571

18 months agoAuto merge of #105271 - eduardosm:inline-always-int-conv, r=scottmcm
bors [Tue, 6 Dec 2022 21:41:04 +0000 (21:41 +0000)]
Auto merge of #105271 - eduardosm:inline-always-int-conv, r=scottmcm

Make integer-to-integer `From` impls `#[inline(always)]`

Splited from https://github.com/rust-lang/rust/pull/105262

18 months agoUpdate the wasi toolchain.
Dan Gohman [Tue, 6 Dec 2022 21:08:30 +0000 (13:08 -0800)]
Update the wasi toolchain.

Update the WASI build to LLVM 15.0 and the wasi-libc version from [wasi-sdk-17].

This will require a ci-mirrors.rust-lang.org file load. Specifically, we
need [this LLVM release tarball] uploaded to be downloadable from
[this URL].

[this LLVM release tarball]: https://github.com/llvm/llvm-project/releases/download/llvmorg-15.0.6/clang+llvm-15.0.6-x86_64-linux-gnu-ubuntu-18.04.tar.xz
[this URL]: https://ci-mirrors.rust-lang.org/rustc/2022-12-06-clang%2Bllvm-15.0.6-x86_64-linux-gnu-ubuntu-18.04.tar.xz
[wasi-sdk-17]: https://github.com/WebAssembly/wasi-sdk/releases/tag/wasi-sdk-17

18 months agounstable-book: Add `ignore` to `abi_efiapi` example code
Nicholas Bishop [Tue, 6 Dec 2022 19:22:56 +0000 (14:22 -0500)]
unstable-book: Add `ignore` to `abi_efiapi` example code

This example doesn't compile on targets that don't support UEFI, as
reported here:
https://github.com/rust-lang/rust/pull/104793#issuecomment-1339783727

18 months agoFilter out precise alloc ids from diagnostics
Oli Scherer [Mon, 5 Dec 2022 10:42:59 +0000 (10:42 +0000)]
Filter out precise alloc ids from diagnostics

18 months agoEmit full spans in miri
Oli Scherer [Thu, 1 Dec 2022 20:25:43 +0000 (20:25 +0000)]
Emit full spans in miri

18 months agoBless 32 bit tests
Oli Scherer [Wed, 30 Nov 2022 12:10:41 +0000 (12:10 +0000)]
Bless 32 bit tests

18 months agoBless after rebase
Oli Scherer [Tue, 29 Nov 2022 16:40:25 +0000 (16:40 +0000)]
Bless after rebase

18 months agoProperly indent messages
Oli Scherer [Tue, 29 Nov 2022 13:35:13 +0000 (13:35 +0000)]
Properly indent messages

18 months agoChange CTFE backtraces to use `note` instead of `label` to preserve their order
Oli Scherer [Tue, 29 Nov 2022 13:10:42 +0000 (13:10 +0000)]
Change CTFE backtraces to use `note` instead of `label` to preserve their order

labels are reordered within the file in which they are reported, which can mess up the stack trace

18 months agoReintroduce the span printing in miri (plus point to spans where possible)
Oli Scherer [Tue, 15 Nov 2022 16:24:52 +0000 (16:24 +0000)]
Reintroduce the span printing in miri (plus point to spans where possible)

18 months agoRemove now-redundant file/line info from const backtraces
Oli Scherer [Tue, 15 Nov 2022 15:44:33 +0000 (15:44 +0000)]
Remove now-redundant file/line info from const backtraces

18 months agoStart emitting labels even if their pointed to file is not available locally
Oli Scherer [Tue, 15 Nov 2022 15:24:54 +0000 (15:24 +0000)]
Start emitting labels even if their pointed to file is not available locally

18 months agoremove an unnecessary `?`
Oli Scherer [Tue, 15 Nov 2022 09:58:43 +0000 (09:58 +0000)]
remove an unnecessary `?`

18 months agoSimplify span fallback
Oli Scherer [Tue, 15 Nov 2022 09:43:04 +0000 (09:43 +0000)]
Simplify span fallback

18 months agoSimplify some nested conditions
Oli Scherer [Mon, 14 Nov 2022 11:12:51 +0000 (11:12 +0000)]
Simplify some nested conditions

18 months agoEnable profiler in dist-powerpc64le-linux
Petr Ogarok [Tue, 6 Dec 2022 18:58:36 +0000 (19:58 +0100)]
Enable profiler in dist-powerpc64le-linux

Build the profiler runtime to allow using -C profile-generate and -C instrument-coverage on POWER systems.

I have verified locally that the runtime builds and the profiler is working fine on the platform.