]> git.lizzy.rs Git - rust.git/log
rust.git
4 years agoAdd async fn test for #66695
Matthew Jasper [Wed, 27 Nov 2019 19:02:13 +0000 (19:02 +0000)]
Add async fn test for #66695

4 years agoDraw vertical lines in compiler error messages with multiline annotations correctly...
Christoph Schmidler [Wed, 20 Nov 2019 22:17:30 +0000 (23:17 +0100)]
Draw vertical lines in compiler error messages with multiline annotations correctly when non-1space unicode characters are to the left

For this we use the correct calculation of the 'left' identation

4 years agoUse intra-doc links
CreepySkeleton [Wed, 27 Nov 2019 18:36:09 +0000 (21:36 +0300)]
Use intra-doc links

4 years agoElaborate on std::ptr::{as_ref,as_mod} and clarify docs
CreepySkeleton [Wed, 13 Nov 2019 17:43:45 +0000 (20:43 +0300)]
Elaborate on std::ptr::{as_ref,as_mod} and clarify docs

4 years agoAuto merge of #56231 - eddyb:mir-debuginfo, r=oli-obk
bors [Wed, 27 Nov 2019 17:44:49 +0000 (17:44 +0000)]
Auto merge of #56231 - eddyb:mir-debuginfo, r=oli-obk

rustc: move debug info from LocalDecl and UpvarDecl into a dedicated VarDebugInfo.

This PR introduces a MIR "user variable" debuginfo system, which amounts to mapping a variable name, in some `SourceScope`, to a `Place`, so that:

* each name can appear multiple times (e.g. due to macro hygiene), even in the same scope
* each `Place` can appear multiple times (e.g. in the future from optimizations like NRVO, which collapse multiple MIR locals into one)
* the `Place`s aren't limited to just locals, so they can describe the (right now quite ad-hoc) closure upvars and generator saved state fields, and can be properly transformed by optimizations (e.g. inlining - see `src/test/mir-opt/inline-closure-captures.rs`)

The main motivation for this was that #48300 and further optimizations were blocked on being able to describe complex debuginfo transformations (see https://github.com/rust-lang/rust/pull/48300#discussion_r170020762).

<hr/>

In the textual representation, the "user variable" debuginfo can be found in each scope, and consists of `debug NAME => PLACE;` "declarations", e.g. the MIR for `let x = ...; let y = ...; ...` is now:
```rust
    let _1: T;                           // in scope 0 at ...
    scope 1 {
        debug x => _1;                   // in scope 1 at ...
        let _2: T;                       // in scope 1 at ...
        scope 2 {
            debug y => _2;               // in scope 2 at ...
        }
    }
```
For reference, this is how the information was represented before this PR:
(notably, the scopes in which the variables are visible for debuginfo weren't even shown anywhere, making `scope 2` look pointless, and user variable names were part of MIR locals)
```rust
    let _1: T;                           // "x" in scope 0 at ...
    scope 1 {
        let _2: T;                       // "y" in scope 1 at ...
        scope 2 {
        }
    }
```

cc @nikomatsakis @michaelwoerister

4 years agorustc: move debug info from LocalDecl and UpvarDecl into a dedicated VarDebugInfo.
Eduard-Mihai Burtescu [Wed, 16 May 2018 15:58:54 +0000 (18:58 +0300)]
rustc: move debug info from LocalDecl and UpvarDecl into a dedicated VarDebugInfo.

4 years agoClean up E0091 long explanation
Guillaume Gomez [Wed, 27 Nov 2019 12:51:50 +0000 (13:51 +0100)]
Clean up E0091 long explanation

4 years agoClean up E0081 long explanation
Guillaume Gomez [Wed, 27 Nov 2019 12:51:44 +0000 (13:51 +0100)]
Clean up E0081 long explanation

4 years agoClean up E0080 long explanation
Guillaume Gomez [Wed, 27 Nov 2019 12:51:38 +0000 (13:51 +0100)]
Clean up E0080 long explanation

4 years agoFix tidy issues
Guillaume Gomez [Tue, 26 Nov 2019 13:11:32 +0000 (14:11 +0100)]
Fix tidy issues

4 years agoPut back tidy check on error codes
Guillaume Gomez [Tue, 26 Nov 2019 13:11:21 +0000 (14:11 +0100)]
Put back tidy check on error codes

4 years agoCorrect typo in src/librustc_mir/const_eval.rs
David Hewitt [Wed, 27 Nov 2019 16:44:53 +0000 (16:44 +0000)]
Correct typo in src/librustc_mir/const_eval.rs

Co-Authored-By: lqd <remy.rakic+github@gmail.com>
4 years agoUse new ErrorKind enum
Guillaume Gomez [Wed, 27 Nov 2019 12:15:16 +0000 (13:15 +0100)]
Use new ErrorKind enum

4 years agorustc_metadata: use a macro to deduplicate LazyPerDefTables and PerDefTableBuilders.
Eduard-Mihai Burtescu [Thu, 14 Nov 2019 02:42:21 +0000 (04:42 +0200)]
rustc_metadata: use a macro to deduplicate LazyPerDefTables and PerDefTableBuilders.

4 years agorustc_metadata: remove Encodable requirements from LazyMeta impls.
Eduard-Mihai Burtescu [Thu, 14 Nov 2019 00:52:59 +0000 (02:52 +0200)]
rustc_metadata: remove Encodable requirements from LazyMeta impls.

4 years agorustc_metadata: use a separate TableBuilder type to build a Table.
Eduard-Mihai Burtescu [Thu, 14 Nov 2019 00:44:24 +0000 (02:44 +0200)]
rustc_metadata: use a separate TableBuilder type to build a Table.

4 years agorustc_metadata: replace PerDefTable<T> with Table<DefIndex, T>.
Eduard-Mihai Burtescu [Wed, 13 Nov 2019 20:10:58 +0000 (22:10 +0200)]
rustc_metadata: replace PerDefTable<T> with Table<DefIndex, T>.

4 years agoAllocate HIR Forest on arena.
Camille GILLOT [Wed, 27 Nov 2019 12:32:28 +0000 (13:32 +0100)]
Allocate HIR Forest on arena.

4 years agoMisc renames.
Camille GILLOT [Wed, 27 Nov 2019 12:24:19 +0000 (13:24 +0100)]
Misc renames.

4 years agoSimplify handling of AllArenas.
Camille GILLOT [Wed, 27 Nov 2019 12:19:33 +0000 (13:19 +0100)]
Simplify handling of AllArenas.

4 years agoClean up E0071 long explanation
Guillaume Gomez [Tue, 26 Nov 2019 12:47:20 +0000 (13:47 +0100)]
Clean up E0071 long explanation

4 years agoClean up E0077 long explanation
Guillaume Gomez [Tue, 26 Nov 2019 12:47:06 +0000 (13:47 +0100)]
Clean up E0077 long explanation

4 years agoClean up E0076 long explanation
Guillaume Gomez [Tue, 26 Nov 2019 12:44:48 +0000 (13:44 +0100)]
Clean up E0076 long explanation

4 years agoRename BoxedGlobalCtxt.
Camille GILLOT [Wed, 27 Nov 2019 12:17:58 +0000 (13:17 +0100)]
Rename BoxedGlobalCtxt.

4 years agoAuto merge of #66691 - dtolnay:fmt0, r=sfackler
bors [Wed, 27 Nov 2019 12:16:52 +0000 (12:16 +0000)]
Auto merge of #66691 - dtolnay:fmt0, r=sfackler

Format libcore with rustfmt

I am interested in whether we can begin cautious incremental progress on #66688 and assess along the way whether we can keep the disruption sufficiently small.

This PR applies rustfmt with default settings to files in src/libcore *that are not involved in any currently open PR* to minimize merge conflicts. The list of files involved in open PRs was determined by querying GitHub's GraphQL API  [with this script](https://gist.github.com/dtolnay/aa9c34993dc051a4f344d1b10e4487e8).

With the list of files from the script in `outstanding_files`, the relevant commands were:

```console
$ find src/libcore -name '*.rs' | xargs rustfmt --edition=2018
$ rg libcore outstanding_files | xargs git checkout --
```

Repeating this process several months apart should get us coverage of most of the rest of libcore.

4 years agoRename lifetimes.
Camille GILLOT [Wed, 27 Nov 2019 12:13:57 +0000 (13:13 +0100)]
Rename lifetimes.

4 years agoReplace Iterator::find calls with Iterator::any when better
Guillaume Gomez [Tue, 26 Nov 2019 12:25:14 +0000 (13:25 +0100)]
Replace Iterator::find calls with Iterator::any when better

4 years agoAdd support for intra-doc link fields of enum variant
Guillaume Gomez [Sun, 24 Nov 2019 15:27:52 +0000 (16:27 +0100)]
Add support for intra-doc link fields of enum variant

4 years agolittle intra-doc code cleanup
Guillaume Gomez [Sun, 24 Nov 2019 13:05:12 +0000 (14:05 +0100)]
little intra-doc code cleanup

4 years agoAdd memoization for const function evaluations
David Hewitt [Mon, 11 Nov 2019 14:32:36 +0000 (14:32 +0000)]
Add memoization for const function evaluations

When a const function is being evaluated, as long as all its
arguments are zero-sized-types (or it has no arguments) then we
can trivially memoize the evaluation result using the existing
query mechanism.

4 years agoUpdate mod.rs
Dylan DPC [Wed, 27 Nov 2019 09:27:30 +0000 (10:27 +0100)]
Update mod.rs

4 years agoAuto merge of #66677 - wesleywiser:fix_const_prop_alloc_id_ice, r=oli-obk
bors [Wed, 27 Nov 2019 08:00:58 +0000 (08:00 +0000)]
Auto merge of #66677 - wesleywiser:fix_const_prop_alloc_id_ice, r=oli-obk

[const prop] Fix "alloc id without corresponding allocation" ICE

r? @oli-obk

4 years agoBless ui tests for libcore reformat
David Tolnay [Wed, 27 Nov 2019 06:49:55 +0000 (22:49 -0800)]
Bless ui tests for libcore reformat

4 years agoFormat libcore with rustfmt
David Tolnay [Sun, 24 Nov 2019 09:43:32 +0000 (01:43 -0800)]
Format libcore with rustfmt

This commit applies rustfmt with default settings to files in
src/libcore *that are not involved in any currently open PR* to minimize
merge conflicts. The list of files involved in open PRs was determined
by querying GitHub's GraphQL API with this script:
https://gist.github.com/dtolnay/aa9c34993dc051a4f344d1b10e4487e8

With the list of files from the script in `outstanding_files`, the
relevant commands were:

    $ find src/libcore -name '*.rs' | xargs rustfmt --edition=2018
    $ rg libcore outstanding_files | xargs git checkout --

Repeating this process several months apart should get us coverage of
most of the rest of libcore.

4 years agoCombine similar tests for const match
Joshua Nelson [Wed, 27 Nov 2019 05:02:04 +0000 (00:02 -0500)]
Combine similar tests for const match

See https://github.com/rust-lang/rust/pull/66788#issuecomment-558799307
for context.

4 years agoAuto merge of #66675 - GuillaumeGomez:support-anchors-intra-doc-links, r=kinnison
bors [Wed, 27 Nov 2019 04:51:31 +0000 (04:51 +0000)]
Auto merge of #66675 - GuillaumeGomez:support-anchors-intra-doc-links, r=kinnison

Support anchors intra doc links

Fixes #62833
Part of #43466.

cc @ollie27
r? @kinnison

4 years agoFix spelling typos
Brian Wignall [Wed, 27 Nov 2019 03:19:54 +0000 (22:19 -0500)]
Fix spelling typos

4 years agoFixes small typo in array docs r? @steveklabnik
Mark Lodato [Wed, 27 Nov 2019 01:58:38 +0000 (20:58 -0500)]
Fixes small typo in array docs r? @steveklabnik

4 years agoAuto merge of #66794 - tmandry:rollup-99qrpr0, r=tmandry
bors [Wed, 27 Nov 2019 00:32:30 +0000 (00:32 +0000)]
Auto merge of #66794 - tmandry:rollup-99qrpr0, r=tmandry

Rollup of 14 pull requests

Successful merges:

 - #66128 (alloc: Add new_zeroed() versions like new_uninit().)
 - #66661 (Add riscv64gc-unknown-linux-gnu target)
 - #66663 (Miri: print leak report even without tracing)
 - #66711 (Add hardware floating point features to aarch64-pc-windows-msvc)
 - #66713 (introduce a target to build the kernel of the unikernel HermitCore)
 - #66717 (tidy: Accommodate rustfmt's preferred layout of stability attributes)
 - #66719 (Store pointer width as u32 on Config)
 - #66720 (Move ErrorReported to rustc_errors)
 - #66737 (Error codes cleanup)
 - #66754 (Various tweaks to diagnostic output)
 - #66763 (Minor edit for documentation-tests.md that increases clarity)
 - #66779 (follow the same function order in the trait)
 - #66786 (Add wildcard test for const_if_match)
 - #66788 (Allow `Unreachable` terminators through `min_const_fn` checks)

Failed merges:

r? @ghost

4 years agoRollup merge of #66788 - ecstatic-morse:const-fn-unreachable, r=Centril
Tyler Mandry [Tue, 26 Nov 2019 23:56:25 +0000 (17:56 -0600)]
Rollup merge of #66788 - ecstatic-morse:const-fn-unreachable, r=Centril

Allow `Unreachable` terminators through `min_const_fn` checks

Resolves #66756.

This allows `Unreachable` terminators through the `min_const_fn` checks if `#![feature(const_if_match)]` is enabled. We could probably just allow them with no feature flag, but it seems okay to be conservative here.

r? @oli-obk

4 years agoRollup merge of #66786 - jyn514:const-if-match-tests, r=Centril
Tyler Mandry [Tue, 26 Nov 2019 23:56:23 +0000 (17:56 -0600)]
Rollup merge of #66786 - jyn514:const-if-match-tests, r=Centril

Add wildcard test for const_if_match

Closes https://github.com/rust-lang/rust/issues/66758

Many thanks to @Centril for his help getting me started!

4 years agoRollup merge of #66779 - guanqun:reorder-funcs, r=Dylan-DPC
Tyler Mandry [Tue, 26 Nov 2019 23:56:22 +0000 (17:56 -0600)]
Rollup merge of #66779 - guanqun:reorder-funcs, r=Dylan-DPC

follow the same function order in the trait

With this change, the function order in both traits and implementation matches.

And this fix removes several warnings in IDE.

4 years agoRollup merge of #66763 - Parth:patch-2, r=steveklabnik
Tyler Mandry [Tue, 26 Nov 2019 23:56:20 +0000 (17:56 -0600)]
Rollup merge of #66763 - Parth:patch-2, r=steveklabnik

Minor edit for documentation-tests.md that increases clarity

4 years agoRollup merge of #66754 - estebank:rustdoc-capitalization, r=Dylan-DPC
Tyler Mandry [Tue, 26 Nov 2019 23:56:19 +0000 (17:56 -0600)]
Rollup merge of #66754 - estebank:rustdoc-capitalization, r=Dylan-DPC

Various tweaks to diagnostic output

4 years agoRollup merge of #66737 - GuillaumeGomez:err-codes-cleanup, r=Dylan-DPC
Tyler Mandry [Tue, 26 Nov 2019 23:56:17 +0000 (17:56 -0600)]
Rollup merge of #66737 - GuillaumeGomez:err-codes-cleanup, r=Dylan-DPC

Error codes cleanup

r? @Dylan-DPC

4 years agoRollup merge of #66720 - Mark-Simulacrum:error-reported, r=Centril
Tyler Mandry [Tue, 26 Nov 2019 23:56:16 +0000 (17:56 -0600)]
Rollup merge of #66720 - Mark-Simulacrum:error-reported, r=Centril

Move ErrorReported to rustc_errors

The new location is more consistent with what this type is for, though we don't remove it from the old location (via a re-export) to avoid changing the dozens of use sites (~139 at this time).

4 years agoRollup merge of #66719 - Mark-Simulacrum:int-normalization, r=Centril
Tyler Mandry [Tue, 26 Nov 2019 23:56:15 +0000 (17:56 -0600)]
Rollup merge of #66719 - Mark-Simulacrum:int-normalization, r=Centril

Store pointer width as u32 on Config

This removes the dependency on IntTy, UintTy from Session.

It's not obviously a win, but it seems a bit odd to store the AST IntTy/UintTy in Session, rather we store the pointer width as an integer and add normalization methods to IntTy and UintTy.

4 years agoRollup merge of #66717 - dtolnay:tidy, r=Mark-Simulacrum
Tyler Mandry [Tue, 26 Nov 2019 23:56:13 +0000 (17:56 -0600)]
Rollup merge of #66717 - dtolnay:tidy, r=Mark-Simulacrum

tidy: Accommodate rustfmt's preferred layout of stability attributes

Previously tidy would require that the `feature = "name_of_feature"` part of the stability attribute was on the same line as the `#[stable(` / `#[unstable(` opening part of the attribute, and that `)]` was on the same line as the last key-value pair.

That didn't work with rustfmt's preferred layout of long attributes, which is like:

```rust
#[unstable(
    feature = "c_variadic",
    reason = "the `c_variadic` feature has not been properly tested on \
              all supported platforms",
    issue = "44930"
)]
```

4 years agoRollup merge of #66713 - hermitcore:hermit, r=alexcrichton
Tyler Mandry [Tue, 26 Nov 2019 23:56:11 +0000 (17:56 -0600)]
Rollup merge of #66713 - hermitcore:hermit, r=alexcrichton

introduce a target to build the kernel of the unikernel HermitCore

We are developing the unikernel HermitCore, where the kernel is written in Rust and is already supported by the Rust Standard Library. To compile the kernel with the new build flag "-Z build-std", we introduce a new target, which avoids the usage of SSE & AVX within the kernel.

4 years agoRollup merge of #66711 - mattico:aarch-msvc-fp, r=nagisa
Tyler Mandry [Tue, 26 Nov 2019 23:56:10 +0000 (17:56 -0600)]
Rollup merge of #66711 - mattico:aarch-msvc-fp, r=nagisa

Add hardware floating point features to aarch64-pc-windows-msvc

Fixes #66701

4 years agoRollup merge of #66663 - RalfJung:miri-leaks, r=oli-obk
Tyler Mandry [Tue, 26 Nov 2019 23:56:08 +0000 (17:56 -0600)]
Rollup merge of #66663 - RalfJung:miri-leaks, r=oli-obk

Miri: print leak report even without tracing

Currently, the rustup-installed Miri has no way to actually print a leak report (as `trace!` is compiled out). Make it print that per default instead when there is a leak.

r? @oli-obk

4 years agoRollup merge of #66661 - msizanoen1:riscv-gnu, r=alexcrichton
Tyler Mandry [Tue, 26 Nov 2019 23:56:07 +0000 (17:56 -0600)]
Rollup merge of #66661 - msizanoen1:riscv-gnu, r=alexcrichton

Add riscv64gc-unknown-linux-gnu target

This PR add the target, but doesn't build std on CI yet.
I have a port for `libc` crate and std which I will upstream soon after this target is added.

r? @alexcrichton

4 years agoRollup merge of #66128 - emilio:new-zeroed, r=SimonSapin
Tyler Mandry [Tue, 26 Nov 2019 23:56:05 +0000 (17:56 -0600)]
Rollup merge of #66128 - emilio:new-zeroed, r=SimonSapin

alloc: Add new_zeroed() versions like new_uninit().

MaybeUninit has both uninit() and zeroed(), it seems reasonable to have the same
surface on Box/Rc/Arc.

Needs tests.

cc #63291

4 years agoRecord temporary static references in generator witnesses
Matthew Jasper [Tue, 26 Nov 2019 22:30:54 +0000 (22:30 +0000)]
Record temporary static references in generator witnesses

4 years agoMove local Arena to Queries.
Camille GILLOT [Tue, 26 Nov 2019 22:16:48 +0000 (23:16 +0100)]
Move local Arena to Queries.

4 years agoFormatting.
Camille GILLOT [Tue, 26 Nov 2019 21:56:05 +0000 (22:56 +0100)]
Formatting.

4 years agoHave Queries own the GlobalCtxt.
Camille GILLOT [Tue, 26 Nov 2019 21:51:02 +0000 (22:51 +0100)]
Have Queries own the GlobalCtxt.

The construction of the GlobalCtxt is moved from a generator's stack to
the Queries struct.  Since the GlobalCtxt requires the HIR Forest and the
arenas to live longer, those are moved into Queries the same way.

The resulting handling of objects is more brittle, because consumers of
the Once objects need to be careful of their initialisation.

4 years agoMake the HIR map own the Definitions.
Camille GILLOT [Tue, 26 Nov 2019 21:48:41 +0000 (22:48 +0100)]
Make the HIR map own the Definitions.

4 years agoStabilize nested self receivers
Taylor Cramer [Mon, 9 Sep 2019 22:27:33 +0000 (15:27 -0700)]
Stabilize nested self receivers

Previously, only Self, &Self, &mut Self, Arc<Self>, Rc<Self>,
and Box<Self> were available as stable method receivers.

This commit stabilizes nested uses of all the above types.
However, nested receivers remain non-object-safe.

4 years agoAuto merge of #66646 - RalfJung:unwind_to_block, r=oli-obk
bors [Tue, 26 Nov 2019 20:38:47 +0000 (20:38 +0000)]
Auto merge of #66646 - RalfJung:unwind_to_block, r=oli-obk

refactor goto_block and also add unwind_to_block

r? @oli-obk

4 years agoRemove test for #66758
Dylan MacKenzie [Tue, 26 Nov 2019 20:13:15 +0000 (12:13 -0800)]
Remove test for #66758

4 years agoMove ErrorReported to rustc_errors
Mark Rousskov [Sun, 24 Nov 2019 21:59:56 +0000 (16:59 -0500)]
Move ErrorReported to rustc_errors

4 years agoAdd regression test for #66756
Dylan MacKenzie [Tue, 26 Nov 2019 19:37:16 +0000 (11:37 -0800)]
Add regression test for #66756

4 years agoAllow `Unreachable` terminators behind `const_if_match`
Dylan MacKenzie [Tue, 26 Nov 2019 19:36:53 +0000 (11:36 -0800)]
Allow `Unreachable` terminators behind `const_if_match`

4 years agoRefactor 'parse_enum_item' to use 'parse_delim_comma_seq'
Janusz Marcinkiewicz [Sun, 24 Nov 2019 21:33:00 +0000 (22:33 +0100)]
Refactor 'parse_enum_item' to use 'parse_delim_comma_seq'

4 years agoTest multiple variants
Joshua Nelson [Tue, 26 Nov 2019 17:37:55 +0000 (12:37 -0500)]
Test multiple variants

Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
4 years agoReview nits.
Camille GILLOT [Tue, 26 Nov 2019 16:20:32 +0000 (17:20 +0100)]
Review nits.

4 years agoAuto merge of #66776 - Mark-Simulacrum:revert-try-breakage, r=Mark-Simulacrum
bors [Tue, 26 Nov 2019 16:03:50 +0000 (16:03 +0000)]
Auto merge of #66776 - Mark-Simulacrum:revert-try-breakage, r=Mark-Simulacrum

Revert "DO NOT MERGE: enable windows try builder"

This reverts commit 90a37bce44d145715eeac9f1f2f34433fc813ef0.

4 years agoAdd tracking issue number.
Mara Bos [Tue, 26 Nov 2019 10:20:54 +0000 (11:20 +0100)]
Add tracking issue number.

4 years agoAdd core::{f32,f64}::consts::TAU.
Mara Bos [Tue, 26 Nov 2019 09:47:52 +0000 (10:47 +0100)]
Add core::{f32,f64}::consts::TAU.

4 years agofollow the same function order in the trait
Guanqun Lu [Tue, 26 Nov 2019 14:55:01 +0000 (22:55 +0800)]
follow the same function order in the trait

This removes several warnings in IDE.

4 years agoMove tests to ui, split them and add some
Nadrieril [Tue, 26 Nov 2019 14:53:54 +0000 (14:53 +0000)]
Move tests to ui, split them and add some

4 years agoMake the ice a fatal error
Nadrieril [Tue, 26 Nov 2019 14:32:47 +0000 (14:32 +0000)]
Make the ice a fatal error

4 years agoRevert "DO NOT MERGE: enable windows try builder"
Mark Rousskov [Tue, 26 Nov 2019 13:06:13 +0000 (08:06 -0500)]
Revert "DO NOT MERGE: enable windows try builder"

This reverts commit 90a37bce44d145715eeac9f1f2f34433fc813ef0.

4 years agoClean up E0075 long explanation
Guillaume Gomez [Tue, 26 Nov 2019 12:42:19 +0000 (13:42 +0100)]
Clean up E0075 long explanation

4 years agoClean up E0072 long explanation
Guillaume Gomez [Tue, 26 Nov 2019 12:40:48 +0000 (13:40 +0100)]
Clean up E0072 long explanation

4 years agoAuto merge of #66631 - michaelwoerister:additional-pgo-tests, r=alexcrichton
bors [Tue, 26 Nov 2019 12:35:39 +0000 (12:35 +0000)]
Auto merge of #66631 - michaelwoerister:additional-pgo-tests, r=alexcrichton

Add additional regression tests for PGO

This PR adds regression tests for making sure that
- instrumentation records the right counts for branches taken and functions called, and that
- the indirect call promotion pass actually is able to promote indirect calls.

r? @alexcrichton

4 years agoReduce righward drift.
Camille GILLOT [Tue, 26 Nov 2019 11:16:36 +0000 (12:16 +0100)]
Reduce righward drift.

4 years agoPGO: Make branch-weights regression test more robust.
Michael Woerister [Tue, 26 Nov 2019 09:34:48 +0000 (10:34 +0100)]
PGO: Make branch-weights regression test more robust.

4 years agorename update_count_then_panic -> rust_panic_without_hook
Ralf Jung [Tue, 26 Nov 2019 09:23:15 +0000 (10:23 +0100)]
rename update_count_then_panic -> rust_panic_without_hook

4 years agoexplain why __rust_start_panic does not take a Box
Ralf Jung [Tue, 26 Nov 2019 08:29:39 +0000 (09:29 +0100)]
explain why __rust_start_panic does not take a Box

4 years agoexpand comment
Ralf Jung [Tue, 26 Nov 2019 08:27:11 +0000 (09:27 +0100)]
expand comment

4 years agoabort on BoxMeUp misuse
Ralf Jung [Tue, 26 Nov 2019 08:24:39 +0000 (09:24 +0100)]
abort on BoxMeUp misuse

4 years agopanic_handler -> begin_panic_handler (and more comments)
Ralf Jung [Tue, 26 Nov 2019 07:18:57 +0000 (08:18 +0100)]
panic_handler -> begin_panic_handler (and more comments)

4 years agoAuto merge of #66561 - TimoFreiberg:trait-name-report, r=estebank
bors [Tue, 26 Nov 2019 05:07:02 +0000 (05:07 +0000)]
Auto merge of #66561 - TimoFreiberg:trait-name-report, r=estebank

Add version mismatch help message for unimplemented trait

Improves issue #22750

The error reporting for E0277 (the trait `X` is not implemented for `Foo`)
now checks whether `Foo` implements a trait with the same path as `X`,
which probably means that the programmer wanted to actually use only one
version of the trait `X` instead of the two.

Still open:
* the same diagnostic should be added for [the trait method case](https://github.com/rust-lang/rust/issues/22750#issuecomment-372077056)
* Showing the real crate versions would be nice, but rustc currently doesn't have that information [according to Esteban](https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/diagnostics.20for.20crate.20version.20mismatch/near/180572989)

4 years agoAuto merge of #66522 - tmiasko:sanitize-flags, r=alexcrichton
bors [Tue, 26 Nov 2019 01:54:53 +0000 (01:54 +0000)]
Auto merge of #66522 - tmiasko:sanitize-flags, r=alexcrichton

Add support for sanitizer recover and tracking origins of uninitialized memory

* Add support for sanitizer recovery `-Zsanitizer-recover=...` (equivalent to `-fsanitize-recover` in clang).
* Add support for tracking origins of uninitialized memory in MemorySanitizer `-Zsanitizer-memory-track-origins` (equivalent to `-fsanitize-memory-track-origins` in clang).

4 years agoAdd wildcard test for const_if_match
Joshua Nelson [Tue, 26 Nov 2019 00:44:35 +0000 (19:44 -0500)]
Add wildcard test for const_if_match

Closes https://github.com/rust-lang/rust/issues/66758

4 years agoUpdate documentation-tests.md
Parth Mehrotra [Tue, 26 Nov 2019 00:34:32 +0000 (19:34 -0500)]
Update documentation-tests.md

4 years agomore panicking comments
Ralf Jung [Mon, 25 Nov 2019 11:24:39 +0000 (12:24 +0100)]
more panicking comments

4 years agoAuto merge of #66178 - Aaron1011:fix/opaque-normalize, r=varkor
bors [Mon, 25 Nov 2019 22:45:50 +0000 (22:45 +0000)]
Auto merge of #66178 - Aaron1011:fix/opaque-normalize, r=varkor

Fix opaque types resulting from projections in function signature

When we normalize the types in a function signature, we may end up
resolving a projection to an opaque type (e.g. `Self::MyType` when
we have `type MyType = impl SomeTrait`). When the projection is
resolved, we will instantiate the generic parameters into fresh
inference variables.

While we do want to normalize projections to opaque types, we don't want
to replace the explicit generic parameters (e.g. `T` in `impl
MyTrait<T>`) with inference variables. We want the opaque type in the
function signature to be eligible to be a defining use of that opaque
type - adding inference variables prevents this, since the opaque type
substs now appears to refer to some specific type, rather than a generic
type.

To resolve this issue, we inspect the opaque types in the function
signature after normalization. Any inference variables in the substs are
replaced with the corresponding generic parameter in the identity substs
(e.g. `T` in `impl MyTrait<T>`). Note that normalization is the only way
that we can end up with inference variables in opaque substs in a
function signature - users have no way of getting inference variables
into a function signature.

Note that all of this refers to the opaque type (ty::Opaque) and its
subst - *not* to the underlying type.

Fixes #59342

4 years agoreview feedback: comments and spacing
Ralf Jung [Mon, 25 Nov 2019 21:45:00 +0000 (22:45 +0100)]
review feedback: comments and spacing

4 years agomake sure we handle all transmute invocations, including diverging ones
Ralf Jung [Mon, 25 Nov 2019 21:37:31 +0000 (22:37 +0100)]
make sure we handle all transmute invocations, including diverging ones

4 years agoVarious cleanups
Esteban Küber [Mon, 25 Nov 2019 20:37:07 +0000 (12:37 -0800)]
Various cleanups

4 years agoTweak removed feature error
Esteban Küber [Mon, 25 Nov 2019 20:36:26 +0000 (12:36 -0800)]
Tweak removed feature error

4 years agoTweak bad `continue` error
Esteban Küber [Mon, 25 Nov 2019 20:35:30 +0000 (12:35 -0800)]
Tweak bad `continue` error

4 years agoTweak duplicate matcher binding error
Esteban Küber [Mon, 25 Nov 2019 20:34:56 +0000 (12:34 -0800)]
Tweak duplicate matcher binding error

4 years agoTweak duplicate fmt arg error
Esteban Küber [Mon, 25 Nov 2019 20:34:16 +0000 (12:34 -0800)]
Tweak duplicate fmt arg error

4 years agoTweak move error due to non-Copy
Esteban Küber [Mon, 25 Nov 2019 20:32:57 +0000 (12:32 -0800)]
Tweak move error due to non-Copy

4 years agoTweak multiple allocators error
Esteban Küber [Mon, 25 Nov 2019 20:27:50 +0000 (12:27 -0800)]
Tweak multiple allocators error

4 years agomiri: couple ret place and ret block together (they both exist or both don't)
Ralf Jung [Mon, 25 Nov 2019 21:00:58 +0000 (22:00 +0100)]
miri: couple ret place and ret block together (they both exist or both don't)