]> git.lizzy.rs Git - rust.git/log
rust.git
4 years agoSupport raw_ref_op's raw reference operator
robojumper [Thu, 28 May 2020 19:42:22 +0000 (21:42 +0200)]
Support raw_ref_op's raw reference operator

4 years agoMerge #4640
bors[bot] [Thu, 28 May 2020 13:37:37 +0000 (13:37 +0000)]
Merge #4640

4640: Add `inRustProject` when-clause for commands in vscode r=vsrs a=vsrs

At the moment all rust-analyzer commands always visible in the command palette, even if there is no rust project opened.

This PR adds special [when-clause](https://code.visualstudio.com/docs/getstarted/keybindings#_when-clause-contexts) context. This context also might be used in key bindings.

Co-authored-by: vsrs <vit@conrlab.com>
Co-authored-by: vsrs <62505555+vsrs@users.noreply.github.com>
4 years agoAdd `inRustProject` context documentation.
vsrs [Thu, 28 May 2020 13:04:42 +0000 (16:04 +0300)]
Add `inRustProject` context documentation.

4 years agoMerge #4641
bors[bot] [Thu, 28 May 2020 09:34:33 +0000 (09:34 +0000)]
Merge #4641

4641: Upgrade Chalk r=matklad a=flodiebold

Chalk newly added TypeName::Never and Array; I implemented the conversion for
Never, but not Array since that expects a const argument.

Co-authored-by: Florian Diebold <flodiebold@gmail.com>
4 years agoMerge #4646
bors[bot] [Thu, 28 May 2020 08:20:43 +0000 (08:20 +0000)]
Merge #4646

4646: Link forum topic r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoLink forum topic
Aleksey Kladov [Thu, 28 May 2020 08:19:01 +0000 (10:19 +0200)]
Link forum topic

4 years agoMerge #4639
bors[bot] [Wed, 27 May 2020 19:14:11 +0000 (19:14 +0000)]
Merge #4639

4639: Fixed missing newline on each field on "Missing structure fields". r=flodiebold a=flipbit03

Co-authored-by: Cadu <cadu.coelho@gmail.com>
4 years agoUpgrade Chalk
Florian Diebold [Wed, 27 May 2020 19:05:21 +0000 (21:05 +0200)]
Upgrade Chalk

Chalk newly added TypeName::Never and Array; I implemented the conversion for
Never, but not Array since that expects a const argument.

4 years agoAdd `inRustProject` when-clause for commands.
vsrs [Wed, 27 May 2020 16:40:13 +0000 (19:40 +0300)]
Add `inRustProject` when-clause for commands.

4 years agoFixed missing newline on each field on "Missing structure fields".
Cadu [Wed, 27 May 2020 16:15:19 +0000 (13:15 -0300)]
Fixed missing newline on each field on "Missing structure fields".

4 years agoMerge #4592
bors[bot] [Wed, 27 May 2020 13:22:26 +0000 (13:22 +0000)]
Merge #4592

4592: fix textedit range returned for completion when left token is a keyword r=bnjjj a=bnjjj

close #4545

Co-authored-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
4 years agofix textedit range returned for completion when left token is a keyword
Benjamin Coenen [Wed, 27 May 2020 13:15:19 +0000 (15:15 +0200)]
fix textedit range returned for completion when left token is a keyword

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
4 years agoMerge #4596
bors[bot] [Wed, 27 May 2020 12:41:38 +0000 (12:41 +0000)]
Merge #4596

4596: Strip leading underscores of argument names in function/method r=matklad a=kuy

Closes #4510

### Goal

When I select a function/method from completions, I get a snippet that doesn't contain leading underscores of argument names.

### Solution

- Option 1: All signatures don't contain underscores
- Option 2: Keep same signature, but inserted snippet doesn't contain underscores

I choose Option 2 because I think that leading underscores is a part of "signature". Users should get correct signatures. On the other hand, trimming underscores is an assist by IDE.

### Other impls.

rls: Complete argument names with underscores (same as actual ra)
IntelliJ Rust: Doesn't complete argument names
VSCode (TypeScript): Doesn't complete argument names

### Working example

![Screen Shot 2020-05-25 at 0 03 21](https://user-images.githubusercontent.com/151614/82757771-a05e5b80-9e1d-11ea-9dbc-1263c960e2ae.png)

Co-authored-by: Yuki Kodama <endflow.net@gmail.com>
4 years agoMerge #4625 #4629
bors[bot] [Wed, 27 May 2020 12:34:03 +0000 (12:34 +0000)]
Merge #4625 #4629

4625: Partially fix displaying inlay hints in Github PR diff views r=matklad a=Veetaha

See the comment in https://github.com/rust-analyzer/rust-analyzer/issues/4608#issuecomment-63424257

It partially fixes the left side of diff view (the one where old code is displayed), but the diff editor with new code changes still has `file` scheme and will proceed displaying inlay hints...

4629: Fix the `should_panic` snippet r=matklad a=eminence

Closes #4628

Co-authored-by: veetaha <veetaha2@gmail.com>
Co-authored-by: Andrew Chin <achin@eminence32.net>
4 years agoMerge #4633
bors[bot] [Wed, 27 May 2020 12:25:20 +0000 (12:25 +0000)]
Merge #4633

4633: typo r=matklad a=Veetaha

Co-authored-by: Veetaha <veetaha2@gmail.com>
4 years agotypo
Veetaha [Wed, 27 May 2020 11:04:57 +0000 (14:04 +0300)]
typo

4 years agoMerge #4632
bors[bot] [Wed, 27 May 2020 10:21:31 +0000 (10:21 +0000)]
Merge #4632

4632: Document inlay hints and runnables r=matklad a=matklad

We want to change those, but let's document what we have in meantime

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoDocument inlay hints and runnables
Aleksey Kladov [Wed, 27 May 2020 10:20:47 +0000 (12:20 +0200)]
Document inlay hints and runnables

We want to change those, but let's document what we have in meantime

4 years agoMerge #4622
bors[bot] [Wed, 27 May 2020 06:42:04 +0000 (06:42 +0000)]
Merge #4622

4622: Pass trivially copy types as copy r=matklad a=kjeremy

Co-authored-by: kjeremy <kjeremy@gmail.com>
4 years agoFix the `should_panic` snippet
Andrew Chin [Tue, 26 May 2020 22:45:14 +0000 (18:45 -0400)]
Fix the `should_panic` snippet

Closes #4628

4 years agoPartially fix displaying inlay hints in Github PR diff views
veetaha [Tue, 26 May 2020 19:51:04 +0000 (22:51 +0300)]
Partially fix displaying inlay hints in Github PR diff views

4 years agoMerge #4623
bors[bot] [Tue, 26 May 2020 19:23:53 +0000 (19:23 +0000)]
Merge #4623

4623: Update deps r=kjeremy a=kjeremy

Co-authored-by: kjeremy <kjeremy@gmail.com>
4 years agoUpdate lexer
kjeremy [Tue, 26 May 2020 18:35:09 +0000 (14:35 -0400)]
Update lexer

4 years agoUpdate crates
kjeremy [Tue, 26 May 2020 18:32:56 +0000 (14:32 -0400)]
Update crates

4 years agoPass trivially copy types as copy
kjeremy [Tue, 26 May 2020 18:12:13 +0000 (14:12 -0400)]
Pass trivially copy types as copy

4 years agoMerge #4621
bors[bot] [Tue, 26 May 2020 18:09:41 +0000 (18:09 +0000)]
Merge #4621

4621: Highlight question mark operator r=matklad a=kuy

Fixes #4597

Co-authored-by: Yuki Kodama <endflow.net@gmail.com>
4 years agoMerge #4534
bors[bot] [Tue, 26 May 2020 12:12:52 +0000 (12:12 +0000)]
Merge #4534

4534: Add call postfix completion r=matklad a=vain0x

To make it easier to wrap an expression with Ok/Some/Rc::new etc.

Note I agree with conclusion of the discussion in #1431 that adding many completions is not the way to go. However, this PR still could be justified due to versatility of use.

Co-authored-by: vain0x <vainzerox@gmail.com>
4 years agoMerge #4617
bors[bot] [Tue, 26 May 2020 07:20:56 +0000 (07:20 +0000)]
Merge #4617

4617: Hover tooltip module name is monospace once again r=matklad a=aloucks

The line separator is also moved below the function signature to split regions between the docs. This is very similar to how IntelliJ displays tooltips. Adding an additional separator between the module name and function signature currently has rendering issues.

Fixes #4594
Alternative to #4615

@kjeremy @Veetaha

Note that I have semantic coloring disabled so ignore any differences due to that.

![image](https://user-images.githubusercontent.com/221559/82857507-30180e80-9edf-11ea-903a-f25c60055a93.png)

![image](https://user-images.githubusercontent.com/221559/82857407-e6c7bf00-9ede-11ea-9ae0-d348279552e7.png)

Co-authored-by: Aaron Loucks <aloucks@cofront.net>
4 years agoHover tooltip module name is monospace once again
Aaron Loucks [Tue, 26 May 2020 03:18:45 +0000 (23:18 -0400)]
Hover tooltip module name is monospace once again

The line separator is moved below the function signature to split
regions between the docs. This is very similar to how IntelliJ
displays tooltips. Adding an additional separator between the module
name and function signature currently has rendering issues.

Fixes #4594
Alternative to #4615

4 years agoMerge #4614
bors[bot] [Mon, 25 May 2020 17:47:11 +0000 (17:47 +0000)]
Merge #4614

4614: Fix some clippy perf warnings r=kjeremy a=kjeremy

Co-authored-by: Jeremy Kolb <kjeremy@gmail.com>
4 years agoAdd question mark operator
Yuki Kodama [Mon, 25 May 2020 17:36:34 +0000 (02:36 +0900)]
Add question mark operator

4 years agoFix some clippy perf warnings
Jeremy Kolb [Mon, 25 May 2020 17:35:52 +0000 (13:35 -0400)]
Fix some clippy perf warnings

4 years agoTrim at presentation layer
Yuki Kodama [Mon, 25 May 2020 16:05:50 +0000 (01:05 +0900)]
Trim at presentation layer

4 years agoFix test to consider multiple underscores
Yuki Kodama [Sun, 24 May 2020 15:14:56 +0000 (00:14 +0900)]
Fix test to consider multiple underscores

4 years agoUse built-in method
Yuki Kodama [Sun, 24 May 2020 14:43:44 +0000 (23:43 +0900)]
Use built-in method

4 years agoSeparate assertions
Yuki Kodama [Sun, 24 May 2020 14:01:26 +0000 (23:01 +0900)]
Separate assertions

4 years agoReflect test case
Yuki Kodama [Sun, 24 May 2020 13:39:09 +0000 (22:39 +0900)]
Reflect test case

4 years agoStrip leading underscore
Yuki Kodama [Sun, 24 May 2020 09:09:42 +0000 (18:09 +0900)]
Strip leading underscore

4 years agoFix conflict between nightly branch and tag
Aleksey Kladov [Mon, 25 May 2020 14:31:19 +0000 (16:31 +0200)]
Fix conflict between nightly branch and tag

4 years agoMerge pull request #4612 from matklad/fix-tag
Aleksey Kladov [Mon, 25 May 2020 14:29:24 +0000 (16:29 +0200)]
Merge pull request #4612 from matklad/fix-tag

Try fixing release tags

4 years agoTry fixing release tags
Aleksey Kladov [Mon, 25 May 2020 14:26:01 +0000 (16:26 +0200)]
Try fixing release tags

closes #4319

4 years agoMerge #4602 #4603
bors[bot] [Mon, 25 May 2020 14:08:21 +0000 (14:08 +0000)]
Merge #4602 #4603

4602: Add boolean literal semantic token type to package.json r=matklad a=lnicola

Closes #4583.

CC @GrayJack

4603: Add self keyword semantic token type r=matklad a=lnicola

Not sure if this is warranted a new token type or just a modifier.

---

CC #4583, @GrayJack

Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
4 years agoMerge #4611
bors[bot] [Mon, 25 May 2020 14:00:24 +0000 (14:00 +0000)]
Merge #4611

4611: Document `parentModule` experimental LSP request r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoDocument `parentModule` experimental LSP request
Aleksey Kladov [Mon, 25 May 2020 13:55:25 +0000 (15:55 +0200)]
Document `parentModule` experimental LSP request

4 years agoMerge #4610
bors[bot] [Mon, 25 May 2020 12:58:50 +0000 (12:58 +0000)]
Merge #4610

4610: Cleanup lsp extensions on the client side r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoCleanup lsp extensions on the client side
Aleksey Kladov [Mon, 25 May 2020 12:56:26 +0000 (14:56 +0200)]
Cleanup lsp extensions on the client side

4 years agoMerge #4607
bors[bot] [Mon, 25 May 2020 12:29:47 +0000 (12:29 +0000)]
Merge #4607

4607: Less rust-analyzer specific onEnter r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoLess rust-analyzer specific onEnter
Aleksey Kladov [Mon, 25 May 2020 12:12:53 +0000 (14:12 +0200)]
Less rust-analyzer specific onEnter

4 years agoMerge #4605
bors[bot] [Mon, 25 May 2020 10:17:40 +0000 (10:17 +0000)]
Merge #4605

4605: Reorganize TypeScript r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoFlatten commands.ts
Aleksey Kladov [Mon, 25 May 2020 10:02:30 +0000 (12:02 +0200)]
Flatten commands.ts

4 years agoFlatten simple commands
Aleksey Kladov [Mon, 25 May 2020 09:10:31 +0000 (11:10 +0200)]
Flatten simple commands

4 years agoAdd self keyword semantic token type
Laurențiu Nicola [Mon, 25 May 2020 08:51:56 +0000 (11:51 +0300)]
Add self keyword semantic token type

4 years agoRemove dead code
Aleksey Kladov [Mon, 25 May 2020 08:59:54 +0000 (10:59 +0200)]
Remove dead code

4 years agoAdd boolean literals to package.json
Laurențiu Nicola [Mon, 25 May 2020 08:39:56 +0000 (11:39 +0300)]
Add boolean literals to package.json

4 years agoMerge #4601
bors[bot] [Mon, 25 May 2020 07:14:43 +0000 (07:14 +0000)]
Merge #4601

4601: Introduce `toggle inlay hints` vscode command r=matklad a=Veetaha

Users now can assign a shortcut for this command
via the general vscode
keybindings ui or `keybindings.json` file

<details>
<summary>Demo</summary>

![demo](https://user-images.githubusercontent.com/36276403/82768941-b4fd1c80-9e3a-11ea-9d5b-a40fa1e4dbc6.gif)

</details>

<details>
<summary>Howto assign a shortcut</summary>

![demo2](https://user-images.githubusercontent.com/36276403/82769350-c8a98280-9e3c-11ea-8a95-1266a539826d.gif)

</details>

Closes: #4599
Co-authored-by: veetaha <veetaha2@gmail.com>
4 years agoIntroduce `toggle inlay hints` vscode command
veetaha [Mon, 25 May 2020 00:47:33 +0000 (03:47 +0300)]
Introduce `toggle inlay hints` vscode command

Users now can assign a shortcut for this command
via the general vscode
keybindings ui or `keybinding.json file`

Closes: #4599
4 years agoMerge #4593
bors[bot] [Sun, 24 May 2020 15:05:20 +0000 (15:05 +0000)]
Merge #4593

4593: Document some rust-analyzer specific protocol extensions r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoFix formatting
Aleksey Kladov [Sun, 24 May 2020 15:04:17 +0000 (17:04 +0200)]
Fix formatting

4 years agoDocument some rust-analyzer specific protocol extensions
Aleksey Kladov [Sun, 24 May 2020 15:01:40 +0000 (17:01 +0200)]
Document some rust-analyzer specific protocol extensions

4 years agoDocument matchingBrace LSP request
Aleksey Kladov [Sun, 24 May 2020 14:18:46 +0000 (16:18 +0200)]
Document matchingBrace LSP request

4 years agofix textedit range returned for completion when left token is a keyword #4545
Benjamin Coenen [Sun, 24 May 2020 14:47:35 +0000 (16:47 +0200)]
fix textedit range returned for completion when left token is a keyword #4545

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
4 years agoMerge #4556
bors[bot] [Sun, 24 May 2020 14:20:22 +0000 (14:20 +0000)]
Merge #4556

4556: More highlighting improvements r=matthewjasper a=matthewjasper

* Separate `true` and `false` from keywords (this matches the Textmate grammar).
* Handle more cases in `highlight_name_by_syntax`.

Co-authored-by: Matthew Jasper <mjjasper1@gmail.com>
4 years agoHandle more cases in `highlight_name_by_syntax`
Matthew Jasper [Thu, 21 May 2020 16:44:45 +0000 (17:44 +0100)]
Handle more cases in `highlight_name_by_syntax`

4 years agoHighlight `true` and `false` as literals
Matthew Jasper [Thu, 21 May 2020 16:40:52 +0000 (17:40 +0100)]
Highlight `true` and `false` as literals

4 years agoFix bors config?
Aleksey Kladov [Sun, 24 May 2020 14:07:46 +0000 (16:07 +0200)]
Fix bors config?

4 years agoMerge pull request #4574 from lnicola/bump-deps
Aleksey Kladov [Sun, 24 May 2020 14:05:41 +0000 (16:05 +0200)]
Merge pull request #4574 from lnicola/bump-deps

Bump some dependencies

4 years agoReorgonise extensions docs
Aleksey Kladov [Sun, 24 May 2020 13:49:32 +0000 (15:49 +0200)]
Reorgonise extensions docs

4 years agoFix tests
Aleksey Kladov [Sun, 24 May 2020 13:47:05 +0000 (15:47 +0200)]
Fix tests

4 years agoFix Cargo.lock
Aleksey Kladov [Sun, 24 May 2020 13:42:11 +0000 (15:42 +0200)]
Fix Cargo.lock

4 years agoMerge pull request #4548 from bnjjj/fix_4464
Aleksey Kladov [Sun, 24 May 2020 13:34:35 +0000 (15:34 +0200)]
Merge pull request #4548 from bnjjj/fix_4464

add support of feature flag for runnables

4 years agoMerge pull request #4495 from vsrs/fixture_meta
Aleksey Kladov [Sun, 24 May 2020 13:32:52 +0000 (15:32 +0200)]
Merge pull request #4495 from vsrs/fixture_meta

Test fixtures parsing improvements

4 years agoMerge pull request #4474 from georgewfraser/color_attrs
Aleksey Kladov [Sun, 24 May 2020 13:32:31 +0000 (15:32 +0200)]
Merge pull request #4474 from georgewfraser/color_attrs

Color attribute functions

4 years agoBump more crates
Laurențiu Nicola [Sun, 24 May 2020 10:41:46 +0000 (13:41 +0300)]
Bump more crates

4 years agoBump more npm deps
Laurențiu Nicola [Fri, 22 May 2020 18:34:53 +0000 (21:34 +0300)]
Bump more npm deps

4 years agoBump some npm deps
Laurențiu Nicola [Fri, 22 May 2020 18:20:59 +0000 (21:20 +0300)]
Bump some npm deps

4 years agoBump rustc_lexer
Laurențiu Nicola [Fri, 22 May 2020 18:16:06 +0000 (21:16 +0300)]
Bump rustc_lexer

4 years agoMerge pull request #4590 from Julian-Wollersberger/update_unescape
Aleksey Kladov [Sun, 24 May 2020 13:27:58 +0000 (15:27 +0200)]
Merge pull request #4590 from Julian-Wollersberger/update_unescape

Update to rustc_lexer version 660

4 years agoadd support of feature flag for runnables #4464
Benjamin Coenen [Sun, 24 May 2020 11:34:34 +0000 (13:34 +0200)]
add support of feature flag for runnables #4464

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
4 years agoSome FIXMEs were outdated:
Julian Wollersberger [Sun, 24 May 2020 11:17:16 +0000 (13:17 +0200)]
Some FIXMEs were outdated:
* Done at line 243: "Add validation of `crate` keyword not appearing in the middle of the symbol path"
* Already happened: "Remove validation of unterminated literals (it is already implemented in `tokenize()`)"
* Happens in `unescape()`: "Add validation of character literal containing only a single char"
* Missing: "raw string literals and raw byte string literals"

4 years agoUpdate to rustc_lexer version 660.
Julian Wollersberger [Sun, 24 May 2020 11:12:16 +0000 (13:12 +0200)]
Update to rustc_lexer version 660.
Change `unescape_*()` to `unescape_literal()`.

4 years agoadd support of feature flag for runnables #4464
Benjamin Coenen [Sat, 23 May 2020 18:59:18 +0000 (20:59 +0200)]
add support of feature flag for runnables #4464

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
4 years agoMerge pull request #4538 from vsrs/vscode_tests
Aleksey Kladov [Sat, 23 May 2020 14:39:04 +0000 (16:39 +0200)]
Merge pull request #4538 from vsrs/vscode_tests

vscode client side tests

4 years agovscode tests configuration for more verbose output
vsrs [Sat, 23 May 2020 14:07:25 +0000 (17:07 +0300)]
vscode tests configuration for more verbose output

4 years agoOS matrix for TypeScript
vsrs [Sat, 23 May 2020 13:39:30 +0000 (16:39 +0300)]
OS matrix for TypeScript

4 years agoxvfb-action fix
vsrs [Sat, 23 May 2020 13:24:21 +0000 (16:24 +0300)]
xvfb-action fix

4 years agoTry GabrielBB/xvfb to run vscode tests
vsrs [Sat, 23 May 2020 13:13:47 +0000 (16:13 +0300)]
Try GabrielBB/xvfb to run vscode tests

4 years agoStart xvfb manually on ubuntu
vsrs [Sat, 23 May 2020 13:04:14 +0000 (16:04 +0300)]
Start xvfb manually on ubuntu

4 years agotry to run TypeScript CI on windows
vsrs [Sat, 23 May 2020 12:37:07 +0000 (15:37 +0300)]
try to run TypeScript CI on windows

4 years agoAdd `npm test` to CI
vsrs [Sat, 23 May 2020 12:20:46 +0000 (15:20 +0300)]
Add `npm test` to CI

4 years agoMerge #4555 #4575
bors[bot] [Sat, 23 May 2020 11:32:26 +0000 (11:32 +0000)]
Merge #4555 #4575

4555: VSCode: added patchelf after download for NixOS support r=matklad a=cab404

This adds Nix support, and fixes #4542

4575: Use Chalk's built-in representations for fn items and pointers r=matklad a=flodiebold

The `TypeName::FnDef` was just added; the function pointer variant has existed for a while, I just forgot about it because it's special (because fn pointers can be higher-ranked over lifetimes).

We *could* also make `FnPtr` a separate `Ty` variant instead of a `TypeCtor` variant, which would make the conversion code a bit less special-casey, but it doesn't seem worth doing right now.

Co-authored-by: Vladimir Serov <me@cab404.ru>
Co-authored-by: Cabia Rangris <me@cab404.ru>
Co-authored-by: Florian Diebold <florian.diebold@freiheit.com>
4 years agoMerge #4578
bors[bot] [Sat, 23 May 2020 11:24:28 +0000 (11:24 +0000)]
Merge #4578

4578: Remove unnecessary clone that prevented clippy from moving on r=matklad a=kjeremy

Co-authored-by: kjeremy <kjeremy@gmail.com>
4 years agoMerge #4559
bors[bot] [Sat, 23 May 2020 11:09:24 +0000 (11:09 +0000)]
Merge #4559

4559: Module name on hover shows another newline after it r=matklad a=Arthamys

This changes the display of hover information to add a newline between the module path of the item and the signature of the item, as suggested in #3813

**Before**

![before_3813](https://user-images.githubusercontent.com/11710698/82609224-5d517d80-9bbc-11ea-9a08-0a1558409c6b.png)

**After**

![after_3813](https://user-images.githubusercontent.com/11710698/82609208-562a6f80-9bbc-11ea-8cb6-4430269c5800.png)

Co-authored-by: Galilée 'Bill' Enguehard <galilee.enguehard@gmail.com>
4 years agoFix resolve_proc_macro heavy test
Galilée 'Bill' Enguehard [Sat, 23 May 2020 06:59:51 +0000 (08:59 +0200)]
Fix resolve_proc_macro heavy test

4 years agoAnd a few drive-bys
kjeremy [Fri, 22 May 2020 21:26:31 +0000 (17:26 -0400)]
And a few drive-bys

4 years agoRemove unnecessary clone that prevented clippy from moving on
kjeremy [Fri, 22 May 2020 21:13:14 +0000 (17:13 -0400)]
Remove unnecessary clone that prevented clippy from moving on

4 years agoUse Chalk's Ty::Function for function pointer types
Florian Diebold [Fri, 22 May 2020 17:13:17 +0000 (19:13 +0200)]
Use Chalk's Ty::Function for function pointer types

Function pointers can be 'higher-ranked' over lifetimes, which is why they're
not an application type in Chalk, but since we don't model lifetimes it doesn't
matter for us yet.

4 years agoUse Chalk's built-in representation of function item types
Florian Diebold [Fri, 22 May 2020 16:15:53 +0000 (18:15 +0200)]
Use Chalk's built-in representation of function item types

4 years agoMerge #4573
bors[bot] [Fri, 22 May 2020 18:16:28 +0000 (18:16 +0000)]
Merge #4573

4573: Chalk cleanups r=matklad a=flodiebold

 - split off the `Interner` impl and the conversion code into their own modules
 - use `TypeCtorId` as `AdtId` directly (instead of raw `InternId`s), and rename the type alias `StructId` -> `AdtId`
 - provide missing Chalk debug impls

Co-authored-by: Florian Diebold <florian.diebold@freiheit.com>
4 years agoUpdate tests to accept new hover formatting
Galilée 'Bill' Enguehard [Fri, 22 May 2020 18:11:24 +0000 (20:11 +0200)]
Update tests to accept new hover formatting

4 years agoFix formatting error when no modpath is present
Galilée 'Bill' Enguehard [Fri, 22 May 2020 18:10:37 +0000 (20:10 +0200)]
Fix formatting error when no modpath is present