]>
git.lizzy.rs Git - rust.git/log
Aleksey Kladov [Thu, 28 Jan 2021 16:10:48 +0000 (19:10 +0300)]
Simplify heavy tests
Progress notifications are edge triggered, while status is level
triggered. This makes it a hared to misuse signal for the readiness of
the server.
bors[bot] [Thu, 28 Jan 2021 16:00:43 +0000 (16:00 +0000)]
Merge #7477
7477: :arrow_up: cm r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 28 Jan 2021 15:59:54 +0000 (18:59 +0300)]
:arrow_up: cm
bors[bot] [Thu, 28 Jan 2021 14:57:01 +0000 (14:57 +0000)]
Merge #7475
7475: cargo update r=kjeremy a=kjeremy
net -13 crates
Co-authored-by: kjeremy <kjeremy@gmail.com>
kjeremy [Thu, 28 Jan 2021 14:55:34 +0000 (09:55 -0500)]
cargo update
bors[bot] [Thu, 28 Jan 2021 14:08:54 +0000 (14:08 +0000)]
Merge #7474
7474: Make logger-based debugging more pleasant r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 28 Jan 2021 14:04:44 +0000 (17:04 +0300)]
Make logger-based debugging more pleasant
bors[bot] [Thu, 28 Jan 2021 13:49:30 +0000 (13:49 +0000)]
Merge #7473
7473: Use RA_LOG in tests r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 28 Jan 2021 13:49:07 +0000 (16:49 +0300)]
Use RA_LOG in tests
bors[bot] [Thu, 28 Jan 2021 13:01:29 +0000 (13:01 +0000)]
Merge #7472
7472: Easier to debug timeouts in tests r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 28 Jan 2021 13:00:33 +0000 (16:00 +0300)]
Easier to debug timeouts in tests
bors[bot] [Thu, 28 Jan 2021 11:29:41 +0000 (11:29 +0000)]
Merge #7471
7471: Force XCode version r=lnicola a=lnicola
Pin an Xcode version in the release workflow to avoid:
```
Run SDKROOT=$(xcrun -sdk macosx11.0 --show-sdk-path) MACOSX_DEPLOYMENT_TARGET=$(xcrun -sdk macosx11.0 --show-sdk-platform-version) cargo xtask dist
xcodebuild: error: SDK "macosx11.0" cannot be located.
xcodebuild: error: SDK "macosx11.0" cannot be located.
xcrun: error: unable to lookup item 'Path' in SDK 'macosx11.0'
xcodebuild: error: SDK "macosx11.0" cannot be located.
xcodebuild: error: SDK "macosx11.0" cannot be located.
xcrun: error: unable to lookup item 'PlatformVersion' in SDK 'macosx11.0'
```
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Thu, 28 Jan 2021 09:48:23 +0000 (11:48 +0200)]
Force XCode version
bors[bot] [Wed, 27 Jan 2021 21:35:57 +0000 (21:35 +0000)]
Merge #7468
7468: Enable fill_match_arms in macros r=Veykril a=Veykril
Fixes #3936
The indentation is a bit off, but I don't think it's worth trying to fix that up until we have a proper formatting thing set up, as this most likely requires some hand picked specializing making the implementation worse to read(Assuming this can even be fixed for all cases by hardcoding indentation fixes).
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Wed, 27 Jan 2021 21:32:40 +0000 (22:32 +0100)]
Enable fill_match_arms in macros
bors[bot] [Wed, 27 Jan 2021 18:17:54 +0000 (18:17 +0000)]
Merge #7466
7466: Fix legacy macro resolution in block expressions r=jonas-schievink a=jonas-schievink
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Jonas Schievink [Wed, 27 Jan 2021 18:16:29 +0000 (19:16 +0100)]
Fix legacy macro resolution in block expressions
bors[bot] [Wed, 27 Jan 2021 15:48:35 +0000 (15:48 +0000)]
Merge #7451
7451: rust-analyzer.files.excludeDirs r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
bors[bot] [Wed, 27 Jan 2021 14:40:57 +0000 (14:40 +0000)]
Merge #7465
7465: Only hide parameter hints for path, field and methodcall expressions r=SomeoneToIgnore a=Veykril
Doing this check for other expressions makes little sense to me.
Fixes #7458
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Wed, 27 Jan 2021 13:20:58 +0000 (14:20 +0100)]
Only hide parameter hints for path, field and methodcall expressions
bors[bot] [Wed, 27 Jan 2021 13:26:18 +0000 (13:26 +0000)]
Merge #7464
7464: Export `CARGO` for proc. macros r=jonas-schievink a=jonas-schievink
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/7462
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Jonas Schievink [Wed, 27 Jan 2021 13:21:05 +0000 (14:21 +0100)]
Export `CARGO` for proc. macros
bors[bot] [Wed, 27 Jan 2021 12:22:55 +0000 (12:22 +0000)]
Merge #7463
7463: Bump deps r=lnicola a=lnicola
bors r+
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Wed, 27 Jan 2021 12:22:19 +0000 (14:22 +0200)]
Bump deps
bors[bot] [Wed, 27 Jan 2021 09:40:52 +0000 (09:40 +0000)]
Merge #7461
7461: Squelch a warning r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 27 Jan 2021 09:40:15 +0000 (12:40 +0300)]
Squelch a warning
Aleksey Kladov [Wed, 27 Jan 2021 09:16:24 +0000 (12:16 +0300)]
add more counts
bors[bot] [Wed, 27 Jan 2021 09:16:54 +0000 (09:16 +0000)]
Merge #7460
7460: add more counts r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 27 Jan 2021 09:16:24 +0000 (12:16 +0300)]
add more counts
bors[bot] [Tue, 26 Jan 2021 22:37:11 +0000 (22:37 +0000)]
Merge #7457
7457: Add no-buffering file logging and wait for a debugger option. r=vsrs a=vsrs
Adds two command line flags: `--no-buffering` and `--wait-dbg`.
Not sure if someone else needs this, but personally I found both flags extremely useful trying to figure out why RA does not work with Visual Studio. Or better to say why Visual Studio does not work with RA.
Co-authored-by: vsrs <vit@conrlab.com>
vsrs [Tue, 26 Jan 2021 21:59:31 +0000 (00:59 +0300)]
Apply suggestions.
vsrs [Tue, 26 Jan 2021 21:33:27 +0000 (00:33 +0300)]
cargo fmt
vsrs [Tue, 26 Jan 2021 21:09:15 +0000 (00:09 +0300)]
Add debug only guard for the --wait-dbg flag
bors[bot] [Tue, 26 Jan 2021 19:14:16 +0000 (19:14 +0000)]
Merge #7455
7455: Make always-assert crate reusable r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 26 Jan 2021 19:11:12 +0000 (22:11 +0300)]
Make always-assert crate reusable
bors[bot] [Tue, 26 Jan 2021 13:57:10 +0000 (13:57 +0000)]
Merge #7405
7405: fill_match_arms: don't duplicate Ident-like arms r=matklad a=bugadani
Co-authored-by: Dániel Buga <bugadani@gmail.com>
Dániel Buga [Fri, 22 Jan 2021 22:15:38 +0000 (23:15 +0100)]
Add failing test case
Aleksey Kladov [Tue, 26 Jan 2021 13:18:01 +0000 (16:18 +0300)]
Add config option to ignore directories
Aleksey Kladov [Tue, 26 Jan 2021 13:10:51 +0000 (16:10 +0300)]
Allow non-absolute paths to rust source
bors[bot] [Tue, 26 Jan 2021 13:24:04 +0000 (13:24 +0000)]
Merge #7450
7450: Remove the need to manually sync config in package.json r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 26 Jan 2021 13:03:24 +0000 (16:03 +0300)]
Remove the need to manually sync config in package.json
bors[bot] [Tue, 26 Jan 2021 13:08:35 +0000 (13:08 +0000)]
Merge #7433
7433: Support Macro v2 in mbe r=jonas-schievink a=edwin0cheng
Added `mbe::MacroDef` for Macro v2.
cc @jonas-schievink
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
bors[bot] [Tue, 26 Jan 2021 12:29:47 +0000 (12:29 +0000)]
Merge #7393
7393: Document `paths` items r=matklad a=arnaudgolfouse
Co-authored-by: Arnaud <arnaud.golfouse@laposte.net>
bors[bot] [Tue, 26 Jan 2021 12:12:45 +0000 (12:12 +0000)]
Merge #7406
7406: if_let_match: don't assume happy path r=matklad a=bugadani
Closes #7392
Co-authored-by: Dániel Buga <bugadani@gmail.com>
bors[bot] [Tue, 26 Jan 2021 11:19:03 +0000 (11:19 +0000)]
Merge #7445
7445: Document design label r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 26 Jan 2021 11:18:28 +0000 (14:18 +0300)]
Document design label
bors[bot] [Tue, 26 Jan 2021 06:35:20 +0000 (06:35 +0000)]
Merge #7438
7438: Shorten hir::TypeParam ranges for traits in NavigationTarget r=matklad a=Veykril
I noticed that selecting `Self` here highlights the entire trait,
![Code_a8DMOEUuWY](https://user-images.githubusercontent.com/
3757771 /
105779993 -
d2592c00 -5f6f-11eb-81d1-
bd99f9369cf7 .png)
this should cut it down to just the trait name and the `Self` which imo seems better.
![image](https://user-images.githubusercontent.com/
3757771 /
105780410 -
ac805700 -5f70-11eb-882b-
10ed63b951f2 .png)
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Mon, 25 Jan 2021 23:44:27 +0000 (00:44 +0100)]
Shorten hir::TypeParam full_range in NavigationTarget
Edwin Cheng [Mon, 25 Jan 2021 21:15:47 +0000 (05:15 +0800)]
Support Macro v2 in mbe
bors[bot] [Mon, 25 Jan 2021 18:40:57 +0000 (18:40 +0000)]
Merge #7430
7430: Simplify file download code r=matklad a=lnicola
This avoids leaving the user with no LSP binary available if their network goes down during the download, and should not keep the current behavior: overwriting a running executable works on Unix and fails on Windows.
It also removes the `overwrite` argument, which is always enabled and wasn't working anyway.
Nominally closes #3896 (although that's already fixed)
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
bors[bot] [Mon, 25 Jan 2021 18:24:04 +0000 (18:24 +0000)]
Merge #7431
7431: Handle `super` paths inside blocks correctly r=jonas-schievink a=jonas-schievink
We now intern `BlockLoc` and use `BlockId` to refer to block expressions. This is needed to keep `ModuleId` simple, since it would otherwise have to store an arbitrarily long chain of blocks and couldn't be `Copy`.
The `DefMap` hierarchy is now created as the caller descends into an item body. This is necessary to link the correct module as the block's parent, which is important for correct name resolution.
As a result, we can now resolve `super` paths inside block expressions by climbing the `DefMap` chain.
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Jonas Schievink [Mon, 25 Jan 2021 18:15:39 +0000 (19:15 +0100)]
Traverse parent DefMap for `super` paths
Jonas Schievink [Mon, 25 Jan 2021 18:02:05 +0000 (19:02 +0100)]
Intern block locations and handle them in ModuleId
Laurențiu Nicola [Mon, 25 Jan 2021 17:12:54 +0000 (19:12 +0200)]
Simplify file download code
vsrs [Mon, 25 Jan 2021 13:38:58 +0000 (16:38 +0300)]
Add RA_WAIT_DBG and docs
vsrs [Mon, 25 Jan 2021 12:55:15 +0000 (15:55 +0300)]
Add "Win Attach to Server" debug configuration
vsrs [Sun, 24 Jan 2021 15:04:47 +0000 (18:04 +0300)]
Add the ability to wait for a debugger.
vsrs [Sun, 24 Jan 2021 14:41:02 +0000 (17:41 +0300)]
Add stderr flush
vsrs [Sun, 24 Jan 2021 14:06:55 +0000 (17:06 +0300)]
Add --no-buffering flag for the file logging.
bors[bot] [Mon, 25 Jan 2021 14:22:24 +0000 (14:22 +0000)]
Merge #7426
7426: Create all `ModuleId`s through a `DefMap` method r=jonas-schievink a=jonas-schievink
`ModuleId` needs to be able to represent blocks, and only the
associated `DefMap` will know how to construct that `ModuleId`
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Jonas Schievink [Mon, 25 Jan 2021 14:21:33 +0000 (15:21 +0100)]
Create all `ModuleId`s through a `DefMap` method
`ModuleId` needs to be able to represent blocks, and only the
associated `DefMap` will know how to construct that `ModuleId`
bors[bot] [Mon, 25 Jan 2021 12:31:48 +0000 (12:31 +0000)]
Merge #7424
7424: Derive Default on ItemTree r=lnicola a=lnicola
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
bors[bot] [Mon, 25 Jan 2021 12:15:16 +0000 (12:15 +0000)]
Merge #7425
7425: Fix typo in style guide r=lnicola a=lnicola
bors r+
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Mon, 25 Jan 2021 12:14:43 +0000 (14:14 +0200)]
Fix typo in style guide
Laurențiu Nicola [Mon, 25 Jan 2021 12:12:53 +0000 (14:12 +0200)]
Derive Default on ItemTree
bors[bot] [Mon, 25 Jan 2021 11:35:37 +0000 (11:35 +0000)]
Merge #7422
7422: Disallow non-boolean literals in concat! r=lnicola a=lnicola
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Mon, 25 Jan 2021 11:30:55 +0000 (13:30 +0200)]
Disallow non-boolean literals in concat!
bors[bot] [Mon, 25 Jan 2021 11:18:58 +0000 (11:18 +0000)]
Merge #7409 #7421
7409: Add References CodeLens. r=matklad a=vsrs
Closes #5836
7421: Fix RA_LOG example in dev docs r=lnicola a=lnicola
bors r+
Co-authored-by: vsrs <vit@conrlab.com>
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Mon, 25 Jan 2021 11:14:31 +0000 (13:14 +0200)]
Fix RA_LOG example in dev docs
bors[bot] [Mon, 25 Jan 2021 11:04:23 +0000 (11:04 +0000)]
Merge #7419
7419: Unquote strings when expanding concat! r=matklad a=lnicola
Fixes #7417.
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Mon, 25 Jan 2021 10:53:44 +0000 (12:53 +0200)]
Unquote strings and handle boolean literals in concat!
bors[bot] [Mon, 25 Jan 2021 09:33:04 +0000 (09:33 +0000)]
Merge #7418
7418: :arrow_up: rowan r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Mon, 25 Jan 2021 09:32:35 +0000 (12:32 +0300)]
:arrow_up: rowan
bors[bot] [Mon, 25 Jan 2021 08:34:36 +0000 (08:34 +0000)]
Merge #7415
7415: Code: reduce progress notification spam r=lnicola a=lnicola
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Sun, 24 Jan 2021 14:13:33 +0000 (16:13 +0200)]
Code: reduce progress notification spam
bors[bot] [Sun, 24 Jan 2021 01:18:58 +0000 (01:18 +0000)]
Merge #7414
7414: Add validation for mutable const items r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Sun, 24 Jan 2021 01:17:41 +0000 (02:17 +0100)]
Add validation for mutable const items
bors[bot] [Sun, 24 Jan 2021 00:42:59 +0000 (00:42 +0000)]
Merge #7413
7413: Handle unions in symbol search r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Sun, 24 Jan 2021 00:32:52 +0000 (01:32 +0100)]
Support unions in symbol search
bors[bot] [Sat, 23 Jan 2021 16:30:26 +0000 (16:30 +0000)]
Merge #7411
7411: cargo update r=kjeremy a=kjeremy
Co-authored-by: Jeremy Kolb <kjeremy@gmail.com>
Jeremy Kolb [Sat, 23 Jan 2021 16:28:59 +0000 (11:28 -0500)]
cargo update
vsrs [Sat, 23 Jan 2021 13:56:20 +0000 (16:56 +0300)]
Add References code lens.
For Struct, Enum, Union and Trait symbols.
bors[bot] [Sat, 23 Jan 2021 08:42:45 +0000 (08:42 +0000)]
Merge #7062
7062: Add diagnostic for filter_map followed by next r=theotherphil a=theotherphil
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/1725
Co-authored-by: Phil Ellison <phil.j.ellison@gmail.com>
Phil Ellison [Sat, 23 Jan 2021 07:54:45 +0000 (07:54 +0000)]
Remove use of SourceFileEdit
Phil Ellison [Fri, 1 Jan 2021 21:40:11 +0000 (21:40 +0000)]
Update tests to register the required standard library types
Phil Ellison [Fri, 1 Jan 2021 21:17:54 +0000 (21:17 +0000)]
Fix test names
Phil Ellison [Fri, 1 Jan 2021 21:11:08 +0000 (21:11 +0000)]
Identify methods using functions ids rather than string names
Phil Ellison [Wed, 30 Dec 2020 16:15:00 +0000 (16:15 +0000)]
cargo fmt
Phil Ellison [Wed, 30 Dec 2020 16:14:35 +0000 (16:14 +0000)]
Address review comments
Phil Ellison [Wed, 30 Dec 2020 15:52:36 +0000 (15:52 +0000)]
cargo fmt
Phil Ellison [Wed, 30 Dec 2020 15:46:05 +0000 (15:46 +0000)]
Implement fix, add tests
Phil Ellison [Mon, 28 Dec 2020 13:41:15 +0000 (13:41 +0000)]
Add diagnostic for filter_map followed by next
bors[bot] [Sat, 23 Jan 2021 04:04:09 +0000 (04:04 +0000)]
Merge #7391
7391: Fix error when using "extern crate self as" r=kazatsuyu a=kazatsuyu
Fix #6957
Co-authored-by: kazatsuyu <shirayama.kazatsuyu@gmail.com>
Dániel Buga [Fri, 22 Jan 2021 22:31:19 +0000 (23:31 +0100)]
Deduplicate variant matching
Dániel Buga [Fri, 22 Jan 2021 22:29:51 +0000 (23:29 +0100)]
replace_if_let_with_match: don't assume sad pattern
bors[bot] [Fri, 22 Jan 2021 17:11:48 +0000 (17:11 +0000)]
Merge #7399
7399: Make `ModuleId`'s `krate` field private and audit uses r=jonas-schievink a=jonas-schievink
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Jonas Schievink [Fri, 22 Jan 2021 17:09:55 +0000 (18:09 +0100)]
Make `ModuleId`'s `krate` field private
bors[bot] [Fri, 22 Jan 2021 16:51:45 +0000 (16:51 +0000)]
Merge #7398
7398: stave off zombies r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 22 Jan 2021 16:50:56 +0000 (19:50 +0300)]
stave off zombies
bors[bot] [Fri, 22 Jan 2021 16:16:22 +0000 (16:16 +0000)]
Merge #7396
7396: More annoying asserts r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>