]> git.lizzy.rs Git - rust.git/log
rust.git
3 years agoSimplify cfg representation
Jonas Schievink [Wed, 21 Oct 2020 11:57:12 +0000 (13:57 +0200)]
Simplify cfg representation

3 years agoMerge #6299
bors[bot] [Tue, 20 Oct 2020 16:35:05 +0000 (16:35 +0000)]
Merge #6299

6299: Diagnose items that are #[cfg]d out r=jonas-schievink a=jonas-schievink

This emits a hint-level diagnostic with `Unnecessary` tag to "gray out" any items whose `#[cfg]` attributes remove the item before name resolution.

Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
3 years agoFixup botched rename
Jonas Schievink [Tue, 20 Oct 2020 16:29:47 +0000 (18:29 +0200)]
Fixup botched rename

3 years agoMore detailed message
Jonas Schievink [Tue, 20 Oct 2020 16:23:55 +0000 (18:23 +0200)]
More detailed message

3 years agoRename UnconfiguredCode -> InactiveCode
Jonas Schievink [Tue, 20 Oct 2020 16:22:31 +0000 (18:22 +0200)]
Rename UnconfiguredCode -> InactiveCode

3 years agoMerge #6301
bors[bot] [Tue, 20 Oct 2020 16:14:40 +0000 (16:14 +0000)]
Merge #6301

6301: Don't rely on display names in inlay_hints r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoDon't rely on display names in inlay_hints
Aleksey Kladov [Tue, 20 Oct 2020 15:38:21 +0000 (17:38 +0200)]
Don't rely on display names in inlay_hints

3 years agoAdd a (hint) diagnostic for unconfigured items
Jonas Schievink [Tue, 20 Oct 2020 15:49:21 +0000 (17:49 +0200)]
Add a (hint) diagnostic for unconfigured items

3 years agoSimplify diagnostic construction, add unused field
Jonas Schievink [Tue, 20 Oct 2020 15:48:43 +0000 (17:48 +0200)]
Simplify diagnostic construction, add unused field

3 years agoMerge #6297
bors[bot] [Tue, 20 Oct 2020 15:15:58 +0000 (15:15 +0000)]
Merge #6297

6297: Support Display name in project.json r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoSupport Display name in project.json
Aleksey Kladov [Tue, 20 Oct 2020 15:13:15 +0000 (17:13 +0200)]
Support Display name in project.json

3 years agoMerge #6295
bors[bot] [Tue, 20 Oct 2020 15:09:51 +0000 (15:09 +0000)]
Merge #6295

6295: More type safety around names r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoMore type safety around names
Aleksey Kladov [Tue, 20 Oct 2020 15:04:38 +0000 (17:04 +0200)]
More type safety around names

3 years agoIntroduce CrateDisplayName
Aleksey Kladov [Tue, 20 Oct 2020 14:00:51 +0000 (16:00 +0200)]
Introduce CrateDisplayName

3 years agoRename declaration_name -> display_name
Aleksey Kladov [Tue, 20 Oct 2020 13:38:11 +0000 (15:38 +0200)]
Rename declaration_name -> display_name

Declaration names sounds like a name of declaration -- something you
can use for analysis. It empathically isn't, and is just a label
displayed in various UI. It's important not to confuse the two, least
we accidentally mix semantics with UI (I believe, there's already a
case of this in the FamousDefs at least).

3 years agoMerge #6294
bors[bot] [Tue, 20 Oct 2020 10:36:28 +0000 (10:36 +0000)]
Merge #6294

6294: Add a hacky remidy for #6038 r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoAdd a hacky remidy for #6038
Aleksey Kladov [Tue, 20 Oct 2020 10:34:39 +0000 (12:34 +0200)]
Add a hacky remidy for #6038

The proper fix I think is:

* move rust-lang/rust library crates to a separate workspace
* when packaging rust-src component, vendor sources of external deps

3 years agoMerge #6266
bors[bot] [Tue, 20 Oct 2020 09:46:43 +0000 (09:46 +0000)]
Merge #6266

6266: Generate diagnostics docs r=matklad a=popzxc

Resolves #6215

Co-authored-by: Igor Aleksanov <popzxc@yandex.ru>
3 years agoAdd generated_diagnostic.adoc to the release.rs and smoke_test_docs_generation
Igor Aleksanov [Mon, 19 Oct 2020 18:07:40 +0000 (21:07 +0300)]
Add generated_diagnostic.adoc to the release.rs and smoke_test_docs_generation

3 years agoUse xshell::read_file instead of fs::read_to_string
Igor Aleksanov [Mon, 19 Oct 2020 17:58:32 +0000 (20:58 +0300)]
Use xshell::read_file instead of fs::read_to_string

3 years agoAdd descriptions for diagnostics parseable by xtask
Igor Aleksanov [Sat, 17 Oct 2020 14:29:06 +0000 (17:29 +0300)]
Add descriptions for diagnostics parseable by xtask

3 years agoCreate xtask module to generate diagnostics docs
Igor Aleksanov [Sat, 17 Oct 2020 14:06:42 +0000 (17:06 +0300)]
Create xtask module to generate diagnostics docs

3 years agoMerge #6290
bors[bot] [Mon, 19 Oct 2020 17:06:34 +0000 (17:06 +0000)]
Merge #6290

6290: Fix deprecation warning r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoFix deprecation warning
Aleksey Kladov [Mon, 19 Oct 2020 17:05:55 +0000 (19:05 +0200)]
Fix deprecation warning

See https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

3 years agoMerge #6288
bors[bot] [Mon, 19 Oct 2020 16:30:09 +0000 (16:30 +0000)]
Merge #6288

6288: Tag release branch rather than master r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoTag release branch rather than master
Aleksey Kladov [Mon, 19 Oct 2020 16:28:59 +0000 (18:28 +0200)]
Tag release branch rather than master

3 years agoMerge #6274
bors[bot] [Mon, 19 Oct 2020 15:35:32 +0000 (15:35 +0000)]
Merge #6274

6274: Check cargoExtraArgs for undefined before using r=matklad a=feileacan

Fixes #6273

Co-authored-by: feileacan <54381366+feileacan@users.noreply.github.com>
3 years agoMerge #6284
bors[bot] [Mon, 19 Oct 2020 14:04:58 +0000 (14:04 +0000)]
Merge #6284

6284: Document logging of project model r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoDocument logging of project model
Aleksey Kladov [Mon, 19 Oct 2020 14:04:22 +0000 (16:04 +0200)]
Document logging of project model

3 years agoMerge #6283
bors[bot] [Mon, 19 Oct 2020 13:54:16 +0000 (13:54 +0000)]
Merge #6283

6283: Minor, rename feature r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoMinor, rename feature
Aleksey Kladov [Mon, 19 Oct 2020 13:53:48 +0000 (15:53 +0200)]
Minor, rename feature

3 years agoMerge #6282
bors[bot] [Mon, 19 Oct 2020 13:19:33 +0000 (13:19 +0000)]
Merge #6282

6282: Try to fix publishing r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoTry to fix publishing
Aleksey Kladov [Mon, 19 Oct 2020 13:18:28 +0000 (15:18 +0200)]
Try to fix publishing

This errro specifically:

Updating crates.io index
 error: failed to select a version for the requirement `ra_ap_stdx = "^0.0.0"`
 candidate versions found which didn't match: 0.0.20
 location searched: /home/runner/work/rust-analyzer/rust-analyzer/crates/stdx
 required by package `ra_ap_completion v0.0.20 (/home/runner/work/rust-analyzer/rust-analyzer/crates/completion)`
 error: unable to update Cargo.lock
 Error: Process completed with exit code 1.

3 years agoMerge #6280
bors[bot] [Mon, 19 Oct 2020 11:58:33 +0000 (11:58 +0000)]
Merge #6280

6280: :arrow_up: crates r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years ago:arrow_up: crates
Aleksey Kladov [Mon, 19 Oct 2020 11:54:01 +0000 (13:54 +0200)]
:arrow_up: crates

3 years agoMerge #6277
bors[bot] [Sun, 18 Oct 2020 15:06:08 +0000 (15:06 +0000)]
Merge #6277

6277: Change visibility works for type aliases r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoChange visibility works for type aliases
Aleksey Kladov [Sun, 18 Oct 2020 15:04:12 +0000 (17:04 +0200)]
Change visibility works for type aliases

3 years agoMerge #6276
bors[bot] [Sun, 18 Oct 2020 10:41:46 +0000 (10:41 +0000)]
Merge #6276

6276: Extract call_info and completion into separate crates r=matklad a=popzxc

As it was discussed in [zulip](https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/Completion.20refactoring), we need to move `completions` into a separate crate.

Unfortunately, the dependency on `call_info::ActiveParameter` doesn't look easy to get rid of, and it seems to be a topic for a separate PR, thus I also extracted `call_info` into a separate crate (on which both `ide` and `completion` crates depend).

Additionally, a few `FIXME`s in doc-comments were resolved in order to make `tidy` happy.

Co-authored-by: Igor Aleksanov <popzxc@yandex.ru>
3 years agoExtract call_info and completion into separate crates
Igor Aleksanov [Sun, 18 Oct 2020 10:09:00 +0000 (13:09 +0300)]
Extract call_info and completion into separate crates

3 years agoMerge #6275
bors[bot] [Sun, 18 Oct 2020 08:30:28 +0000 (08:30 +0000)]
Merge #6275

6275: Textmate grammar: prevent unwanted interpolation scopes r=matklad a=dustypomerleau

Fixes the issues noted by @matklad after merging #6248.

1. prevent accidental interpolation scopes when `{` is used in a string
1. prevent interpolations from extending beyond the end of a string

Co-authored-by: Dusty Pomerleau <dustypomerleau@users.noreply.github.com>
3 years agofix: prevent unwanted interpolation scopes
Dusty Pomerleau [Sun, 18 Oct 2020 02:27:03 +0000 (13:27 +1100)]
fix: prevent unwanted interpolation scopes

3 years agoCheck cargoExtraArgs for undefined before using
feileacan [Sun, 18 Oct 2020 00:40:48 +0000 (11:40 +1100)]
Check cargoExtraArgs for undefined before using

3 years agoMerge #6272
bors[bot] [Sat, 17 Oct 2020 23:53:42 +0000 (23:53 +0000)]
Merge #6272

6272: :arrow_up: xshell r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoupdate deps
Aleksey Kladov [Sat, 17 Oct 2020 23:53:01 +0000 (01:53 +0200)]
update deps

3 years ago:arrow_up: xshell
Aleksey Kladov [Sat, 17 Oct 2020 23:51:39 +0000 (01:51 +0200)]
:arrow_up: xshell

3 years agoMerge #6271
bors[bot] [Sat, 17 Oct 2020 22:45:32 +0000 (22:45 +0000)]
Merge #6271

6271: Complete methods when receiver is a macro r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoMerge #6248
bors[bot] [Sat, 17 Oct 2020 22:38:04 +0000 (22:38 +0000)]
Merge #6248

6248: Textmate grammar: prevent early termination of raw strings with hash (closes #6042) r=matklad a=dustypomerleau

Problematic sample code from #6042:

```rust
#[derive(Debug, Clone, Logos)]
enum Quoted<'source> {
    #[regex(r#"[^\\"']+"#)]
    Text(&'source str),
    #[token("\\")]
    StartEscape,
    #[token("\'", |_| Quote::Single)]
    #[token("\"", |_| Quote::Double)]
    End(Quote),

    #[error]
    Error,
}
```

Before fix:

<img width="400" alt="Screen Shot 2020-10-16 at 10 45 59" src="https://user-images.githubusercontent.com/6304651/96198390-6a726d00-0fa0-11eb-8428-e76b2866836b.png">

After fix:

<img width="400" alt="Screen Shot 2020-10-16 at 10 45 33" src="https://user-images.githubusercontent.com/6304651/96198408-7a8a4c80-0fa0-11eb-9104-ca708009fe63.png">

Co-authored-by: Dusty Pomerleau <dustypomerleau@users.noreply.github.com>
3 years agoComplete methods when receiver is a macro
Aleksey Kladov [Sat, 17 Oct 2020 21:43:13 +0000 (23:43 +0200)]
Complete methods when receiver is a macro

3 years agoImprove readability
Aleksey Kladov [Sat, 17 Oct 2020 21:35:21 +0000 (23:35 +0200)]
Improve readability

3 years agoMerge #6265
bors[bot] [Sat, 17 Oct 2020 11:25:48 +0000 (11:25 +0000)]
Merge #6265

6265: :arrow_up: xshell r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years ago:arrow_up: xshell
Aleksey Kladov [Sat, 17 Oct 2020 11:25:22 +0000 (13:25 +0200)]
:arrow_up: xshell

3 years agoMerge #6262
bors[bot] [Sat, 17 Oct 2020 10:31:37 +0000 (10:31 +0000)]
Merge #6262

6262: Do not spawn redundant hints r=SomeoneToIgnore a=popzxc

Closes #5206

This is a second part of the fix (first was #5997).

This PR adds a new method to the `CompletionContext`: `no_completion_required`. If this method returns `true`, it essentially means that user is unlikely to expect any hints from the IDE at this cursor position.

Currently, checks for the following cases were added:

- Previous item is `fn`: user creates a new function, names of existing functions won't be helpful. Exception for this case is `impl Foo for Bar` -- we must suggest trait function names.
- User entered `for _ i<|>`: it's obviously going to be `in` keyword, any hints here will be confusing.

More checks may be added there later, but currently I've only figured two cases.

![no_redundant_hints](https://user-images.githubusercontent.com/12111581/96332088-da4d2a00-106a-11eb-89a1-1159ece18f9d.png)

Co-authored-by: Igor Aleksanov <popzxc@yandex.ru>
3 years agoScan all ancestors for the impl trait block check
Igor Aleksanov [Sat, 17 Oct 2020 08:17:58 +0000 (11:17 +0300)]
Scan all ancestors for the impl trait block check

3 years agoAllow hints after 'fn' keyword if it's an impl trait block
Igor Aleksanov [Sat, 17 Oct 2020 08:03:07 +0000 (11:03 +0300)]
Allow hints after 'fn' keyword if it's an impl trait block

3 years agoAdd test for new pattern functions
Igor Aleksanov [Sat, 17 Oct 2020 07:56:00 +0000 (10:56 +0300)]
Add test for new pattern functions

3 years agoImprove test_no_completions_required test
Igor Aleksanov [Sat, 17 Oct 2020 07:47:35 +0000 (10:47 +0300)]
Improve test_no_completions_required test

3 years agoRemove redundant completions
Igor Aleksanov [Mon, 12 Oct 2020 07:59:15 +0000 (10:59 +0300)]
Remove redundant completions

3 years agoMerge #6260
bors[bot] [Sat, 17 Oct 2020 00:44:12 +0000 (00:44 +0000)]
Merge #6260

6260: xshell r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoSwitch from not_bash to xshell
Aleksey Kladov [Fri, 16 Oct 2020 17:46:03 +0000 (19:46 +0200)]
Switch from not_bash to xshell

3 years agoMerge #6253
bors[bot] [Fri, 16 Oct 2020 18:00:21 +0000 (18:00 +0000)]
Merge #6253

6253: Document change of 'cargo' Runnable kind in lsp-extensions.md r=lnicola a=popzxc

As was requested in https://github.com/rust-analyzer/rust-analyzer/pull/5954#issuecomment-708325521

Co-authored-by: Igor Aleksanov <popzxc@yandex.ru>
3 years agoDocument change of 'cargo' Runnable kind in lsp-extensions.md
Igor Aleksanov [Fri, 16 Oct 2020 16:30:05 +0000 (19:30 +0300)]
Document change of 'cargo' Runnable kind in lsp-extensions.md

3 years agoMerge #6255
bors[bot] [Fri, 16 Oct 2020 17:49:08 +0000 (17:49 +0000)]
Merge #6255

6255: Improve compile time a tiny bit r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoImprove compile time a tiny bit
Aleksey Kladov [Fri, 16 Oct 2020 17:47:47 +0000 (19:47 +0200)]
Improve compile time a tiny bit

3 years agoMerge #6245
bors[bot] [Fri, 16 Oct 2020 12:59:11 +0000 (12:59 +0000)]
Merge #6245

6245: Update GNOME Builder docs r=lnicola a=lnicola

Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
3 years agoMerge #6246
bors[bot] [Fri, 16 Oct 2020 12:53:10 +0000 (12:53 +0000)]
Merge #6246

6246: Follow symlinks when walking project trees r=lnicola a=dfoxfranke

Fixes #3691.

~~WIP pending further testing~~:

- [X] Verify that symlinked files get indexed.
- [x] Verify that files in symlinked directories get indexed.
- [x] Verify that inotify events are properly received and handled when the target of a symlink resides outside the project tree.

Co-authored-by: Daniel Fox Franke <dfoxfranke@gmail.com>
3 years agoMerge #6250
bors[bot] [Fri, 16 Oct 2020 10:50:34 +0000 (10:50 +0000)]
Merge #6250

6250: Expand code order section r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoExpand code order section
Aleksey Kladov [Fri, 16 Oct 2020 10:50:09 +0000 (12:50 +0200)]
Expand code order section

3 years agofix: prevent early termination of raw strings with hash
Dusty Pomerleau [Fri, 16 Oct 2020 00:08:59 +0000 (11:08 +1100)]
fix: prevent early termination of raw strings with hash

3 years agoFollow symlinks when walking project trees
Daniel Fox Franke [Thu, 15 Oct 2020 18:22:36 +0000 (14:22 -0400)]
Follow symlinks when walking project trees

Fixes #3691

3 years agoMerge #6220
bors[bot] [Thu, 15 Oct 2020 18:02:27 +0000 (18:02 +0000)]
Merge #6220

6220: implement binary operator overloading type inference r=flodiebold a=ruabmbua

Extend type inference of *binary operator expression*, by adding support for operator overloads.

Before this merge request, the type inference of binary expressions could only resolve operations done on built-in primitive types. This merge requests adds a code path, which is executed in case the built-in inference could not get any results. It resolves the proper operator overload trait in *core::ops* via lang items, and then resolves the associated *Output* type.

```rust
struct V2([f32; 2]);

#[lang = "add"]
pub trait Add<Rhs = Self> {
    /// The resulting type after applying the `+` operator.
    type Output;

    /// Performs the `+` operation.
    #[must_use]
    fn add(self, rhs: Rhs) -> Self::Output;
}

impl Add<V2> for V2 {
    type Output = V2;

    fn add(self, rhs: V2) -> V2 {
        let x = self.0[0] + rhs.0[0];
        let y = self.0[1] + rhs.0[1];
        V2([x, y])
    }
}

fn test() {
    let va = V2([0.0, 1.0]);
    let vb = V2([0.0, 1.0]);

    let r = va + vb; // This infers to V2 now
}
```

There is a problem with operator overloads, which do not explicitly set the *Rhs* type parameter in the respective impl block.

**Example:**

```rust
impl Add for V2 {
    type Output = V2;

    fn add(self, rhs: V2) -> V2 {
        let x = self.0[0] + rhs.0[0];
        let y = self.0[1] + rhs.0[1];
        V2([x, y])
    }
}
```

In this case, the trait solver does not realize, that the *Rhs* type parameter is actually self in the context of the impl block. This stops type inference in its tracks, and it can not resolve the associated *Output* type.

I guess we can still merge this back, because it increases the amount of resolved types, and does not regress anything (in the tests).

Somewhat blocked by https://github.com/rust-analyzer/rust-analyzer/issues/5685
Resolves  https://github.com/rust-analyzer/rust-analyzer/issues/5544

Co-authored-by: Roland Ruckerbauer <roland.rucky@gmail.com>
3 years agoUpdate GNOME Builder docs
Laurențiu Nicola [Thu, 15 Oct 2020 16:58:12 +0000 (19:58 +0300)]
Update GNOME Builder docs

3 years agoMerge #6244
bors[bot] [Thu, 15 Oct 2020 16:14:54 +0000 (16:14 +0000)]
Merge #6244

6244: Document awkward names r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoDocument awkward names
Aleksey Kladov [Thu, 15 Oct 2020 16:14:30 +0000 (18:14 +0200)]
Document awkward names

3 years agoMerge #6243
bors[bot] [Thu, 15 Oct 2020 15:39:35 +0000 (15:39 +0000)]
Merge #6243

6243: Clarify classification API r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoClarify the names one more time
Aleksey Kladov [Thu, 15 Oct 2020 15:33:32 +0000 (17:33 +0200)]
Clarify the names one more time

3 years agoMore idiomatic classification API
Aleksey Kladov [Thu, 15 Oct 2020 15:27:50 +0000 (17:27 +0200)]
More idiomatic classification API

3 years agoMore clarifications
Aleksey Kladov [Thu, 15 Oct 2020 15:18:07 +0000 (17:18 +0200)]
More clarifications

3 years agoUnconfuse expression and pattern field init shorthands
Aleksey Kladov [Thu, 15 Oct 2020 14:23:55 +0000 (16:23 +0200)]
Unconfuse expression and pattern field init shorthands

3 years agoClarify NameClass names a bit
Aleksey Kladov [Thu, 15 Oct 2020 14:15:01 +0000 (16:15 +0200)]
Clarify NameClass names a bit

3 years agoMerge #6242
bors[bot] [Thu, 15 Oct 2020 15:11:36 +0000 (15:11 +0000)]
Merge #6242

6242: Diagnost shorthand in patterns r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoMove field_shorthand to a separate module
Aleksey Kladov [Thu, 15 Oct 2020 15:07:53 +0000 (17:07 +0200)]
Move field_shorthand to a separate module

3 years agoDiagnose shorthand in patterns as well
Aleksey Kladov [Thu, 15 Oct 2020 15:03:52 +0000 (17:03 +0200)]
Diagnose shorthand in patterns as well

3 years agoflatten
Aleksey Kladov [Thu, 15 Oct 2020 14:51:55 +0000 (16:51 +0200)]
flatten

3 years agoPrepare for pat_field_shorthand
Aleksey Kladov [Thu, 15 Oct 2020 14:48:25 +0000 (16:48 +0200)]
Prepare for pat_field_shorthand

3 years agoMerge #6234
bors[bot] [Thu, 15 Oct 2020 13:09:27 +0000 (13:09 +0000)]
Merge #6234

6234: Fix hover over field pattern shorthand r=matklad a=Vlad-Shcherbina

Instead of the information about the field, it now shows the information
about the local.

Fixes #6146

Co-authored-by: Vlad Shcherbina <vlad.shcherbina@gmail.com>
3 years agoMerge #6240
bors[bot] [Thu, 15 Oct 2020 12:59:49 +0000 (12:59 +0000)]
Merge #6240

6240: Document auto_import as a feature r=Veykril a=Veykril

Closes #6225

Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
3 years agoDocument auto_import as a feature
Lukas Wirth [Thu, 15 Oct 2020 12:44:46 +0000 (14:44 +0200)]
Document auto_import as a feature

3 years agoMerge #6236
bors[bot] [Thu, 15 Oct 2020 10:50:26 +0000 (10:50 +0000)]
Merge #6236

6236: Code: Insert a ZWNJ before `after` type hints r=matklad a=lnicola

to prevent the editor from displaying a ligature there.

Fixes #6235

Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
3 years agoMerge #6239
bors[bot] [Thu, 15 Oct 2020 10:22:01 +0000 (10:22 +0000)]
Merge #6239

6239: Cleanup alloc advice r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoCleanup alloc advice
Aleksey Kladov [Thu, 15 Oct 2020 10:21:38 +0000 (12:21 +0200)]
Cleanup alloc advice

3 years agoInsert a ZWNJ before type hints
Laurențiu Nicola [Thu, 15 Oct 2020 07:29:30 +0000 (10:29 +0300)]
Insert a ZWNJ before  type hints

3 years agoMerge #6231
bors[bot] [Wed, 14 Oct 2020 20:52:41 +0000 (20:52 +0000)]
Merge #6231

6231: Factor macro_rules and format-string highlighting out into submodules r=Veykril a=Veykril

This moves `format`-like macro string highlighting and macro_rules highlight skipping out of the main module.

Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
3 years agoDefault::default the highlighters
Lukas Wirth [Wed, 14 Oct 2020 20:21:58 +0000 (22:21 +0200)]
Default::default the highlighters

3 years agoFix hover over field pattern shorthand
Vlad Shcherbina [Wed, 14 Oct 2020 18:22:00 +0000 (21:22 +0300)]
Fix hover over field pattern shorthand

Instead of the information about the field, it now shows the information
about the local.

Fixes #6146

3 years agoMerge #6233
bors[bot] [Wed, 14 Oct 2020 18:02:36 +0000 (18:02 +0000)]
Merge #6233

6233: Style: default over new r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoStyle: default over new
Aleksey Kladov [Wed, 14 Oct 2020 18:02:03 +0000 (20:02 +0200)]
Style: default over new

3 years agoFactor macro_rules! highlighting out
Lukas Wirth [Wed, 14 Oct 2020 17:23:59 +0000 (19:23 +0200)]
Factor macro_rules! highlighting out

3 years agoFactor format string highlighting out
Lukas Wirth [Tue, 13 Oct 2020 22:56:41 +0000 (00:56 +0200)]
Factor format string highlighting out

3 years agobinary operator overload type inference: add test mark
Roland Ruckerbauer [Wed, 14 Oct 2020 17:00:04 +0000 (19:00 +0200)]
binary operator overload type inference: add test mark

3 years agoMerge #6230
bors[bot] [Wed, 14 Oct 2020 15:23:02 +0000 (15:23 +0000)]
Merge #6230

6230: Log around sysroot discovery r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>