]>
git.lizzy.rs Git - rust.git/log
bors[bot] [Tue, 25 Aug 2020 12:51:28 +0000 (12:51 +0000)]
Merge #5873
5873: Correct sed replacement when called in a bash file r=matklad a=pksunkara
There's so much trial and error regarding shells and stuff I needed to do to get this correctly working on github runner.
Co-authored-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
bors[bot] [Tue, 25 Aug 2020 12:45:02 +0000 (12:45 +0000)]
Merge #5874
5874: Remove AttrDef
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 25 Aug 2020 12:44:15 +0000 (14:44 +0200)]
Remove AttrDef
Pavan Kumar Sunkara [Tue, 25 Aug 2020 10:45:06 +0000 (12:45 +0200)]
Correct sed replacement when called in a bash file
bors[bot] [Tue, 25 Aug 2020 10:58:27 +0000 (10:58 +0000)]
Merge #5870
5870: Move code_model attrs to a new module r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 25 Aug 2020 10:57:15 +0000 (12:57 +0200)]
Simplify
Aleksey Kladov [Tue, 25 Aug 2020 10:56:01 +0000 (12:56 +0200)]
Move attrs from code_module to a separate module
bors[bot] [Tue, 25 Aug 2020 10:48:51 +0000 (10:48 +0000)]
Merge #5869
5869: Minor
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 25 Aug 2020 10:47:36 +0000 (12:47 +0200)]
Minor
bors[bot] [Tue, 25 Aug 2020 10:14:45 +0000 (10:14 +0000)]
Merge #5867
5867: Use the same abstraction for attrs and docs
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 25 Aug 2020 10:13:31 +0000 (12:13 +0200)]
Use the same abstraction for attrs and docs
Doc comments *are* attributes, so there's no reason to have two crates
here.
bors[bot] [Tue, 25 Aug 2020 09:46:21 +0000 (09:46 +0000)]
Merge #5866
5866: Improve logging
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 25 Aug 2020 09:27:22 +0000 (11:27 +0200)]
Improve logging
bors[bot] [Tue, 25 Aug 2020 09:40:36 +0000 (09:40 +0000)]
Merge #5865
5865: Rename rust_analyzer lib in the binaries before publishing r=matklad a=pksunkara
@matklad Tested and working with publish dry run. Please run the action manually once merged.
Co-authored-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
Pavan Kumar Sunkara [Tue, 25 Aug 2020 09:32:22 +0000 (11:32 +0200)]
Rename rust_analyzer lib in the binaries before publishing
bors[bot] [Tue, 25 Aug 2020 09:11:26 +0000 (09:11 +0000)]
Merge #4873
4873: Resolve links in hover documentation r=matklad a=zacps
This PR resolves links in hover documentation. Both the upcoming intra-doc-links style and the old "path-based" style.
## Todo
* [x] More tests
* [ ] Benchmark (Is there an easy way to benchmark this?)
* [x] ~~Resolve issues with the markdown parser/get rid of it~~ Migrate to `pulldown_cmark_to_cmark`
* [x] Reorganise code (Tips appreciated)
---
Fixes #503
Co-authored-by: Zac Pullar-Strecker <zacmps@gmail.com>
bors[bot] [Tue, 25 Aug 2020 09:01:12 +0000 (09:01 +0000)]
Merge #5863
5863: Cleanup invert-if
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 25 Aug 2020 08:57:51 +0000 (10:57 +0200)]
Cleanup invert-if
* stick to trivial factory functions in make
* compress the logic for inverting Option/Result
Zac Pullar-Strecker [Tue, 25 Aug 2020 04:44:36 +0000 (16:44 +1200)]
Merge remote-tracking branch 'upstream/master' into 503-hover-doc-links
Zac Pullar-Strecker [Tue, 25 Aug 2020 04:40:43 +0000 (16:40 +1200)]
Changes from review
bors[bot] [Mon, 24 Aug 2020 20:10:16 +0000 (20:10 +0000)]
Merge #5861
5861: Support extern types r=matklad a=jonas-schievink
This is a currently unstable feature tracked at https://github.com/rust-lang/rust/issues/43467
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Jonas Schievink [Mon, 24 Aug 2020 20:02:55 +0000 (22:02 +0200)]
Support extern types
bors[bot] [Mon, 24 Aug 2020 15:31:25 +0000 (15:31 +0000)]
Merge #5859
5859: Allow rust-analyzer auto publishing r=matklad a=pksunkara
Co-authored-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
Pavan Kumar Sunkara [Mon, 24 Aug 2020 15:27:13 +0000 (17:27 +0200)]
Allow rust-analyzer auto publishing
bors[bot] [Mon, 24 Aug 2020 14:33:35 +0000 (14:33 +0000)]
Merge #5841
5841: Gate stream.pipeline workaround on fixed versions of node r=matklad a=Veetaha
Fixes the symptom of https://github.com/cdr/code-server/issues/1810
Original report here: https://github.com/rust-analyzer/rust-analyzer/issues/3167#issuecomment-
678390564
Thanks to @hjfreyer for precise investigation :D
Co-authored-by: Veetaha <veetaha2@gmail.com>
bors[bot] [Mon, 24 Aug 2020 14:26:33 +0000 (14:26 +0000)]
Merge #5733
5733: Fix expand glob import bugs r=matklad a=unexge
fixes https://github.com/rust-analyzer/rust-analyzer/issues/5709
TODOs:
- [x] Incorrect node replacing
<details>
<summary>Details</summary>
```rust
use crate::{
body::scope::{ExprScopes, ScopeId},
body::Body,
builtin_type::BuiltinType,
db::DefDatabase,
expr::{ExprId, PatId},
generics::GenericParams,
item_scope::{BuiltinShadowMode, BUILTIN_SCOPE},
nameres::CrateDefMap,
path::*<|>,
per_ns::PerNs,
visibility::{RawVisibility, Visibility},
AdtId, AssocContainerId, ConstId, ContainerId, DefWithBodyId, EnumId, EnumVariantId,
FunctionId, GenericDefId, HasModule, ImplId, LocalModuleId, Lookup, ModuleDefId, ModuleId,
StaticId, StructId, TraitId, TypeAliasId, TypeParamId, VariantId,
};
```
becames
```rust
use crate::{PathKind, name, name, ModPath};
```
</details>
- [x] Ignoring visibility
<details>
<summary>Details</summary>
```rust
mod foo {
mod bar {
pub struct Bar;
}
}
use foo::bar::*;
fn baz(bar: Bar) {}
```
becames
```rust
mod foo {
mod bar {
pub struct Bar;
}
}
use foo::bar::Bar;
fn baz(bar: Bar) {}
```
although mod `bar` is private
</details>
- [x] Eating attributes
Co-authored-by: unexge <unexge@gmail.com>
bors[bot] [Mon, 24 Aug 2020 11:39:56 +0000 (11:39 +0000)]
Merge #5855
5855: Add TBD description to arena r=matklad a=pksunkara
Sorry I missed this, @matklad. Please run manually again once this is merged.
Co-authored-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
Pavan Kumar Sunkara [Mon, 24 Aug 2020 11:29:10 +0000 (13:29 +0200)]
Add TBD description to arena
bors[bot] [Mon, 24 Aug 2020 11:14:45 +0000 (11:14 +0000)]
Merge #4776
4776: Do a weekly minor publish to crates.io r=matklad a=pksunkara
This is the same system I set up on Chalk repo.
Every week it creates a new minor version, pushes it to github and then deploys it to crates.io.
Co-authored-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
bors[bot] [Mon, 24 Aug 2020 11:08:11 +0000 (11:08 +0000)]
Merge #5845
5845: Omit lenses for not runnable doctests r=matklad a=SomeoneToIgnore
Ideally, we should properly parse the doctest attributes before, but since I need it for the code lens only, this way should suffice for now
Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
Pavan Kumar Sunkara [Mon, 24 Aug 2020 11:06:30 +0000 (13:06 +0200)]
Add description for crates that will be published
Pavan Kumar Sunkara [Sat, 6 Jun 2020 19:50:28 +0000 (21:50 +0200)]
Added weekly publish workflow
bors[bot] [Mon, 24 Aug 2020 11:01:56 +0000 (11:01 +0000)]
Merge #5851
5851: Invert if should be smart about is_some, is_none, is_ok, is_err r=matklad a=dragfire
Fixes #5827
Co-authored-by: dragfire <asem.devajit@gmail.com>
bors[bot] [Mon, 24 Aug 2020 10:56:04 +0000 (10:56 +0000)]
Merge #5852
5852: Add Early Return rule to style r=matklad a=matklad
bors r+
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
bors[bot] [Mon, 24 Aug 2020 10:50:04 +0000 (10:50 +0000)]
Merge #5853
5853: Avoid monomorphization
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Mon, 24 Aug 2020 10:49:36 +0000 (12:49 +0200)]
Avoid monomorphization
Aleksey Kladov [Mon, 24 Aug 2020 10:19:12 +0000 (12:19 +0200)]
Add Early Return rule to style
Zac Pullar-Strecker [Mon, 24 Aug 2020 09:50:30 +0000 (21:50 +1200)]
Renames, comments, and dead code removal
Zac Pullar-Strecker [Mon, 24 Aug 2020 09:19:53 +0000 (21:19 +1200)]
Merge remote-tracking branch 'upstream/master' into 503-hover-doc-links
Pavan Kumar Sunkara [Mon, 24 Aug 2020 08:25:19 +0000 (10:25 +0200)]
Add version to deps in cargo.toml
Zac Pullar-Strecker [Mon, 24 Aug 2020 08:47:10 +0000 (20:47 +1200)]
Add a test to document unimplemented case
Zac Pullar-Strecker [Mon, 24 Aug 2020 08:26:45 +0000 (20:26 +1200)]
Reorganise code
dragfire [Sun, 23 Aug 2020 20:30:07 +0000 (14:30 -0600)]
Invert if should be smart about is_some, is_none, is_ok, is_err
Kirill Bulatov [Sat, 22 Aug 2020 19:03:02 +0000 (22:03 +0300)]
Omit lenses for not runnable doctests
bors[bot] [Sat, 22 Aug 2020 14:41:17 +0000 (14:41 +0000)]
Merge #5823
5823: Don't underline function definition if self is &mut r=Nashenas88 a=matklad
The self is right there, and is already underlined, so it makes little
sense to emit even more underlines.
before:
![before](https://user-images.githubusercontent.com/
1711539 /
90672843 -
0d379500 -e257-11ea-840f-
b0caed4410f1 .png)
after:
![after](https://user-images.githubusercontent.com/
1711539 /
90672840 -
0c9efe80 -e257-11ea-9739-
23af433841c6 .png)
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
bors[bot] [Fri, 21 Aug 2020 19:47:22 +0000 (19:47 +0000)]
Merge #5839
5839: Dont ask me why... r=kjeremy a=Veetaha
Co-authored-by: Veetaha <veetaha2@gmail.com>
Veetaha [Fri, 21 Aug 2020 19:12:22 +0000 (22:12 +0300)]
Gate stream.pipeline workaround on fixed versions of node
Veetaha [Fri, 21 Aug 2020 18:14:40 +0000 (21:14 +0300)]
Dont ask me why...
bors[bot] [Fri, 21 Aug 2020 17:15:09 +0000 (17:15 +0000)]
Merge #5838
5838: :arrow_up: autocfg
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 21 Aug 2020 17:14:44 +0000 (19:14 +0200)]
:arrow_up: autocfg
Aleksey Kladov [Fri, 21 Aug 2020 17:12:38 +0000 (19:12 +0200)]
:arrow_up: ungrammar
bors[bot] [Fri, 21 Aug 2020 11:21:05 +0000 (11:21 +0000)]
Merge #5835
5835: Switch to expect_test from crates.io
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 21 Aug 2020 11:19:31 +0000 (13:19 +0200)]
Switch to expect_test from crates.io
Aleksey Kladov [Fri, 21 Aug 2020 11:15:56 +0000 (13:15 +0200)]
Remove expect crate
unexge [Wed, 19 Aug 2020 17:16:03 +0000 (20:16 +0300)]
Use new `Definition::usages` API in expand glob import
unexge [Mon, 17 Aug 2020 17:22:14 +0000 (20:22 +0300)]
Fix importing private modules in expand glob import
unexge [Sun, 16 Aug 2020 15:37:15 +0000 (18:37 +0300)]
Fix importing unused traits in expand glob import
unexge [Sun, 16 Aug 2020 13:42:44 +0000 (16:42 +0300)]
Use fixme instead of todo
unexge [Sun, 16 Aug 2020 13:25:10 +0000 (16:25 +0300)]
Use `Definition::find_usages` for finding used items in expand glob import
unexge [Fri, 14 Aug 2020 19:17:26 +0000 (22:17 +0300)]
Run rustfmt
unexge [Fri, 14 Aug 2020 19:10:49 +0000 (22:10 +0300)]
Handle more cases in AST replacing in expand glob import
unexge [Wed, 12 Aug 2020 21:51:15 +0000 (00:51 +0300)]
Improve AST replacing in expand glob import
bors[bot] [Thu, 20 Aug 2020 16:52:02 +0000 (16:52 +0000)]
Merge #5832
5832: Update crates r=kjeremy a=kjeremy
Co-authored-by: kjeremy <kjeremy@gmail.com>
kjeremy [Thu, 20 Aug 2020 16:50:43 +0000 (12:50 -0400)]
Update crates
bors[bot] [Wed, 19 Aug 2020 22:55:54 +0000 (22:55 +0000)]
Merge #5824
5824: Optimize reference search
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 19 Aug 2020 22:54:44 +0000 (00:54 +0200)]
Optimize reference search
bors[bot] [Wed, 19 Aug 2020 20:01:59 +0000 (20:01 +0000)]
Merge #5813
5813: Try lld r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 19 Aug 2020 18:06:04 +0000 (20:06 +0200)]
Use lld on winsows
Aleksey Kladov [Wed, 19 Aug 2020 18:02:33 +0000 (20:02 +0200)]
Don't underline function definition if self is &mut
The self is right there, and is already underlined, so it makes little
sense to emit even more underlines.
bors[bot] [Wed, 19 Aug 2020 17:56:19 +0000 (17:56 +0000)]
Merge #5822
5822: Remove dead code
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 19 Aug 2020 17:54:00 +0000 (19:54 +0200)]
Remove dead code
bors[bot] [Wed, 19 Aug 2020 17:49:36 +0000 (17:49 +0000)]
Merge #5821
5821: **Remove Unused Parameter** refactoring
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 19 Aug 2020 16:44:33 +0000 (18:44 +0200)]
**Remove Unused Parameter** refactoring
bors[bot] [Wed, 19 Aug 2020 17:00:01 +0000 (17:00 +0000)]
Merge #5820
5820: Future proof find-usages API
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 19 Aug 2020 16:58:48 +0000 (18:58 +0200)]
Future proof find-usages API
We might want to provide more efficient impls for check if usages
exist, limiting the search, filtering and cancellation, so let's
violate YAGNI a bit here.
bors[bot] [Wed, 19 Aug 2020 15:57:21 +0000 (15:57 +0000)]
Merge #5819
5819: Apply couple of rule of thumbs to simplify highlighting code
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 19 Aug 2020 15:53:41 +0000 (17:53 +0200)]
Apply couple of rule of thumbs to simplify highlighting code
Main one: instead of adding a parameter to function to handle special
case, make the caller handle it.
Second main one: make sure that function does a reasonable thing.
`highlight_def` picks a color for def, *regardless* of the context
the def is use. Feeding an info from the call-site muddies the
responsibilities here.
Minor smells, flagging the function as having space for improvement in
the first place:
* many parameters, some of which are set as constants on most
call-sites (introduce severalfunction instad)
* boolean param (add two functions instead)
bors[bot] [Wed, 19 Aug 2020 15:42:26 +0000 (15:42 +0000)]
Merge #5818
5818: Some trivial local simiplifications r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 19 Aug 2020 15:41:56 +0000 (17:41 +0200)]
Inline trivial function
Aleksey Kladov [Wed, 19 Aug 2020 15:37:19 +0000 (17:37 +0200)]
Simplify
Aleksey Kladov [Wed, 19 Aug 2020 15:33:25 +0000 (17:33 +0200)]
Minor
Aleksey Kladov [Wed, 19 Aug 2020 15:31:26 +0000 (17:31 +0200)]
Minor cleanups
Aleksey Kladov [Wed, 19 Aug 2020 15:30:43 +0000 (17:30 +0200)]
Better name
bors[bot] [Wed, 19 Aug 2020 15:03:35 +0000 (15:03 +0000)]
Merge #5817
5817: Better API factoring around self access modes
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 19 Aug 2020 15:02:50 +0000 (17:02 +0200)]
Better API factoring around self access modes
bors[bot] [Wed, 19 Aug 2020 14:34:36 +0000 (14:34 +0000)]
Merge #5816
5816: Better error if Cargo is not in Path
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 19 Aug 2020 14:34:11 +0000 (16:34 +0200)]
Better error if Cargo is not in Path
bors[bot] [Wed, 19 Aug 2020 14:05:22 +0000 (14:05 +0000)]
Merge #5815
5815: Introduce hir::Param
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 19 Aug 2020 14:04:11 +0000 (16:04 +0200)]
Introduce hir::Param
We generally shouldn't expose TypeRef out of hir. So, let's just use a
placehoder here.
bors[bot] [Wed, 19 Aug 2020 13:17:05 +0000 (13:17 +0000)]
Merge #5814
5814: Add SelfParam to code_model
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 19 Aug 2020 13:16:24 +0000 (15:16 +0200)]
Add SelfParam to code_model
bors[bot] [Wed, 19 Aug 2020 11:51:47 +0000 (11:51 +0000)]
Merge #5812
5812: Minor cleanups
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 19 Aug 2020 11:46:34 +0000 (13:46 +0200)]
Minor cleanups
bors[bot] [Wed, 19 Aug 2020 11:34:29 +0000 (11:34 +0000)]
Merge #5811
5811: Minor
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 19 Aug 2020 11:33:51 +0000 (13:33 +0200)]
Minor
bors[bot] [Wed, 19 Aug 2020 11:27:02 +0000 (11:27 +0000)]
Merge #5643
5643: Add new consuming modifier, apply consuming and mutable to methods r=matklad a=Nashenas88
This adds a new `consuming` semantic modifier for syntax highlighters.
This also emits `mutable` and `consuming` in two cases:
- When a method takes `&mut self`, then it now has `function.mutable` emitted.
- When a method takes `self`, and the type of `Self` is not `Copy`, then `function.consuming` is emitted.
CC @flodiebold
Co-authored-by: Paul Daniel Faria <Nashenas88@users.noreply.github.com>
bors[bot] [Tue, 18 Aug 2020 21:57:52 +0000 (21:57 +0000)]
Merge #5809
5809: :arrow_up: crates
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 18 Aug 2020 21:52:29 +0000 (23:52 +0200)]
:arrow_up: crates
bors[bot] [Tue, 18 Aug 2020 21:51:29 +0000 (21:51 +0000)]
Merge #5808
5808: Make RacyFlag actually work
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 18 Aug 2020 21:51:01 +0000 (23:51 +0200)]
Make RacyFlag actually work