]>
git.lizzy.rs Git - rust.git/log
bors [Tue, 10 Mar 2020 21:30:44 +0000 (21:30 +0000)]
Auto merge of #5298 - rust-lang:needless_doc_main_code, r=flip1995,Manishearth
needless_doc_main: only check rust code
This fixes #5280 by checking the language attribute on code blocks.
---
changelog: none
Manish Goregaokar [Tue, 10 Mar 2020 21:30:07 +0000 (14:30 -0700)]
Update tests/ui/needless_doc_main.rs
Co-Authored-By: Philipp Krones <hello@philkrones.com>
bors [Tue, 10 Mar 2020 21:05:46 +0000 (21:05 +0000)]
Auto merge of #5299 - JohnTitor:contrib, r=flip1995
Clean-up docs
Fixes #5268
changelog: none
Yuki Okushi [Tue, 10 Mar 2020 20:55:25 +0000 (05:55 +0900)]
Move links to the end of each chapter on adding_lints
Yuki Okushi [Tue, 10 Mar 2020 20:40:53 +0000 (05:40 +0900)]
Move links to the end of each chapter on CONTRIBUTING
Yuki Okushi [Tue, 10 Mar 2020 20:21:28 +0000 (05:21 +0900)]
Clean-up adding_lints.md
Yuki Okushi [Tue, 10 Mar 2020 09:50:06 +0000 (18:50 +0900)]
Clean-up CONTRIBUTING.md
Andre Bogus [Tue, 10 Mar 2020 19:19:37 +0000 (20:19 +0100)]
needless_doc_main: only check rust code
bors [Tue, 10 Mar 2020 12:25:07 +0000 (12:25 +0000)]
Auto merge of #5296 - sinkuu:fix_ice_trivial_bounds, r=flip1995
Fix ICE with trivial_bounds feature
https://github.com/rust-lang/rust/issues/69874#issuecomment-
596890446
changelog: Fix ICE with trivial_bounds feature
bors [Tue, 10 Mar 2020 10:37:51 +0000 (10:37 +0000)]
Auto merge of #5297 - JohnTitor:shadow, r=phansch
Use `node_type_opt` over `node_type`
Fix ICE reported in rust-lang/rust#69873.
changelog: Fix ICE in checking bindings
Yuki Okushi [Tue, 10 Mar 2020 09:18:34 +0000 (18:18 +0900)]
Use `node_type_opt` over `node_type`
Shotaro Yamada [Tue, 10 Mar 2020 04:27:33 +0000 (13:27 +0900)]
Fix doc
Shotaro Yamada [Tue, 10 Mar 2020 04:17:15 +0000 (13:17 +0900)]
Fix ICE with trivial_bounds feature
bors [Tue, 10 Mar 2020 00:09:26 +0000 (00:09 +0000)]
Auto merge of #5295 - matthiaskrgr:lints_readme, r=flip1995
clippy_lints: readme: don't mention crates.io since it is no longer used to publish clippy
changelog: none
Matthias Krüger [Tue, 10 Mar 2020 00:05:17 +0000 (01:05 +0100)]
clippy_lints: readme: don't mention crates.io since it is no longer used to publish clippy.
bors [Mon, 9 Mar 2020 23:46:50 +0000 (23:46 +0000)]
Auto merge of #5277 - chrissimpkins:rustc-dev-guide-transition, r=flip1995
Update rustc-guide to rustc-dev-guide
The rustc-guide is being renamed to the rustc-dev-guide. The discussion is in rust-lang/rustc-guide#470.
This PR revises rustc-guide to rustc-dev-guide in the Readme Markdown file.
Transition tracker: rust-lang/rustc-guide#602
changelog: none
Chris Simpkins [Mon, 9 Mar 2020 21:58:39 +0000 (17:58 -0400)]
update rust-lang.github.io to rustc-dev-guide.rust-lang.org
bors [Mon, 9 Mar 2020 19:51:13 +0000 (19:51 +0000)]
Auto merge of #5292 - jpospychala:map-placeholder, r=flip1995
Improve placeholder in map_unit_fn
Instead of using `_` as a default placeholder use `a`.
fixes #5180
changelog: Improve default placeholder in map_unit_fn
Jacek Pospychala [Sun, 8 Mar 2020 22:43:40 +0000 (23:43 +0100)]
Improve placeholder in map_unit_fn
bors [Mon, 9 Mar 2020 17:25:09 +0000 (17:25 +0000)]
Auto merge of #5287 - matthiaskrgr:pat_isref, r=flip1995
redundant_pattern: take binding (ref, ref mut) into account in suggestion
fixes #5271
changelog: redundant_pattern: take binding (ref, ref mut) into account in suggestion (#5271)
bors [Mon, 9 Mar 2020 17:09:38 +0000 (17:09 +0000)]
Auto merge of #5286 - matthiaskrgr:delay_vec_creation, r=flip1995
check_pat: delay creation of the "normal" vec until we reach the branch where it is actually needed
changelog: none
bors [Mon, 9 Mar 2020 16:04:26 +0000 (16:04 +0000)]
Auto merge of #5291 - ThibsG:FixSingleBinding, r=flip1995
Fix match single binding when in a let stmt
Fix bad suggestion when `match_single_binding` lints when inside a local (let) statement.
Fixes #5267
changelog: none
ThibsG [Sun, 8 Mar 2020 21:57:35 +0000 (22:57 +0100)]
Fix match single binding when in a let stmt
bors [Mon, 9 Mar 2020 14:29:40 +0000 (14:29 +0000)]
Auto merge of #5285 - matthiaskrgr:dep_it, r=flip1995
deps: bump itertools 0.8 -> 0.9
changelog: none
bors [Mon, 9 Mar 2020 13:11:23 +0000 (13:11 +0000)]
Auto merge of #5290 - polybuildr:map-message, r=phansch
Improve error messages for {option,result}_map_unit_fn
Instead of saying "unit function", use the phrase the description uses: "function that returns the unit type".
Fixes #5180.
changelog: Improve error messages for {option,result}_map_unit_fn
bors [Sun, 8 Mar 2020 22:24:26 +0000 (22:24 +0000)]
Auto merge of #5289 - polybuildr:setup, r=matthiaskrgr
Mention the setup instructions in CONTRIBUTING
Multiple people seem to have missed this based on questions asked in the Discord channel. Might as well mention it up front.
changelog: none
Vivek Ghaisas [Sun, 8 Mar 2020 21:28:06 +0000 (21:28 +0000)]
Improve error messages for {option,result}_map_unit_fn
Instead of saying "unit function", use the phrase the description
uses: "function that returns the unit type".
Fixes #5180.
Vivek Ghaisas [Sun, 8 Mar 2020 20:57:42 +0000 (20:57 +0000)]
Mention the setup instructions in CONTRIBUTING
Multiple people seem to have missed this based on questions asked in the
Discord channel. Might as well mention it up front.
Matthias Krüger [Sun, 8 Mar 2020 09:00:23 +0000 (10:00 +0100)]
redundant_pattern: take binding (ref, ref mut) into account in suggestion.
fixes #5271
Matthias Krüger [Sun, 8 Mar 2020 01:50:33 +0000 (02:50 +0100)]
check_pat: delay creation of the "normal" vec until we reach the branch where is is actually needed
Matthias Krüger [Sun, 8 Mar 2020 00:33:17 +0000 (01:33 +0100)]
deps: bump itertools 0.8 -> 0.9
changelog: none
Chris Simpkins [Fri, 6 Mar 2020 04:32:04 +0000 (23:32 -0500)]
transition rustc-guide to rustc-dev-guide
bors [Thu, 5 Mar 2020 18:25:07 +0000 (18:25 +0000)]
Auto merge of #5276 - flip1995:macro_use, r=flip1995
Rename macro_use_import -> macro_use_imports
I missed this during review of #5230. We can just do this, without deprecating the old name, since this lint didn't hit nightly rustc yet.
changelog: none
flip1995 [Thu, 5 Mar 2020 18:22:17 +0000 (19:22 +0100)]
Rename macro_use_import -> macro_use_imports
bors [Thu, 5 Mar 2020 17:30:52 +0000 (17:30 +0000)]
Auto merge of #5230 - DevinR528:macro-use, r=flip1995
Macro use
---
changelog: This lint enforces Rust 2018 idiom of importing macro's directly without `#[macro_use]` fixes #5179 .
bors [Thu, 5 Mar 2020 17:17:14 +0000 (17:17 +0000)]
Auto merge of #5235 - flip1995:tag_deploy_fix, r=phansch
Fix deploy script for tag deploys
By hand updating the documentation for the `rust-1.41.1` release, I found, that the deploy script was buggy for tag deploys. Luckily we weren't affected yet (will only run if the commit of the tag already has the workflow config, so probably ~`rust-1.43.0`)
The bug:
When a tag was deployed, until now it also updated the master documentation to the state of the tag. This was because the `git add .` not only updated the files created or modified by the tag commit, but also the master lints.json file.
changelog: none
bors [Wed, 4 Mar 2020 16:11:40 +0000 (16:11 +0000)]
Auto merge of #5257 - mlegner:cast_hex_fp, r=flip1995
Resolve false positives of unnecessary_cast for non-decimal integers
This PR resolves false positives of `unnecessary_cast` for hexadecimal integers to floats and adds a corresponding test case.
Fixes: #5220
changelog: none
Devin R [Wed, 26 Feb 2020 12:40:31 +0000 (07:40 -0500)]
warn on macro_use attr
bors [Wed, 4 Mar 2020 13:30:08 +0000 (13:30 +0000)]
Auto merge of #5266 - sinkuu:questionmark, r=flip1995
Lint `if let Some` and early return in question_mark lint
Fixes #5260
changelog: lint `if let Some` and early return in `question_mark` lint
Shotaro Yamada [Wed, 4 Mar 2020 12:59:58 +0000 (12:59 +0000)]
Apply suggestions from code review
Co-Authored-By: Philipp Krones <hello@philkrones.com>
mlegner [Wed, 4 Mar 2020 09:12:11 +0000 (10:12 +0100)]
Simplify if_chain.
mlegner [Tue, 3 Mar 2020 16:58:37 +0000 (17:58 +0100)]
Move NumericLiteral to its own module.
mlegner [Tue, 3 Mar 2020 16:05:09 +0000 (17:05 +0100)]
Included binary and octal cases.
mlegner [Mon, 2 Mar 2020 21:44:32 +0000 (22:44 +0100)]
Resolve false positives for hex int cast.
mlegner [Mon, 2 Mar 2020 08:49:33 +0000 (09:49 +0100)]
Test for unnecessary_cast of hex int literal.
bors [Wed, 4 Mar 2020 11:06:31 +0000 (11:06 +0000)]
Auto merge of #5258 - ThibsG:UselessBindingInStruct638, r=flip1995
Add lint for .. use in fully binded struct
This PR adds the lint `match-wild-in-fully-binded-struct` to prevent the use of the `..` pattern when all fields of the struct are already binded.
Fixes: #638
changelog: Add [`rest_pat_in_fully_bound_structs`] lint to warn against the use of `..` in fully binded struct
bors [Wed, 4 Mar 2020 10:53:03 +0000 (10:53 +0000)]
Auto merge of #5246 - JarredAllen:master, r=flip1995
Detect usage of custom floating-point abs implementation
Closes #5224
changelog: Enhance [`suboptimal_flops`] lint to detect manual implementations of the `abs` method
Shotaro Yamada [Wed, 4 Mar 2020 08:21:07 +0000 (17:21 +0900)]
run-rustfix
Shotaro Yamada [Wed, 4 Mar 2020 07:59:16 +0000 (16:59 +0900)]
Lint `if let Some` in question_mark lint
ThibsG [Sun, 1 Mar 2020 16:36:14 +0000 (17:36 +0100)]
Add restrictive pat use in full binded struct
JarredAllen [Wed, 4 Mar 2020 03:23:04 +0000 (19:23 -0800)]
Update test case answers to match cargo dev fmt
JarredAllen [Wed, 4 Mar 2020 02:06:59 +0000 (18:06 -0800)]
Ran cargo dev fmt
bors [Wed, 4 Mar 2020 00:06:25 +0000 (00:06 +0000)]
Auto merge of #5264 - flip1995:rustup, r=flip1995
Rustup to rust-lang/rust#69506
changelog: none
flip1995 [Tue, 3 Mar 2020 23:54:27 +0000 (00:54 +0100)]
Rustup to rust-lang/rust#69506
JarredAllen [Tue, 3 Mar 2020 23:52:53 +0000 (15:52 -0800)]
Recommended changes from flip1995
bors [Tue, 3 Mar 2020 20:13:19 +0000 (20:13 +0000)]
Auto merge of #5262 - JohnTitor:rls, r=flip1995
Revive rls integration test
RLS updated their dependencies in rust-lang/rls#1646 so we can revive the integration test. I confirm it passed on my local.
changelog: none
Yuki Okushi [Tue, 3 Mar 2020 19:32:42 +0000 (04:32 +0900)]
Revive rls integration test
bors [Tue, 3 Mar 2020 14:41:20 +0000 (14:41 +0000)]
Auto merge of #5261 - matthiaskrgr:qmark, r=flip1995
use question mark operator
changelog: none
Matthias Krüger [Tue, 3 Mar 2020 14:13:25 +0000 (15:13 +0100)]
use question mark operator
bors [Tue, 3 Mar 2020 13:38:42 +0000 (13:38 +0000)]
Auto merge of #5256 - JohnTitor:try-eval-usize, r=phansch
Use `try_eval_usize` over `eval_usize`
Fixes #5223
changelog: Fix ICE in evaluating usizes
Yuki Okushi [Tue, 3 Mar 2020 12:39:45 +0000 (21:39 +0900)]
Add regression test
Yuki Okushi [Mon, 2 Mar 2020 20:53:41 +0000 (05:53 +0900)]
Use `try_eval_usize` over `eval_usize`
bors [Tue, 3 Mar 2020 11:46:21 +0000 (11:46 +0000)]
Auto merge of #5259 - flip1995:lang_items, r=phansch
Use lang items instead of get_trait_def_id where possible
changelog: none
bors [Tue, 3 Mar 2020 11:32:51 +0000 (11:32 +0000)]
Auto merge of #5047 - flip1995:use_debug, r=phansch
Don't trigger use_debug lint in Debug impl
Fixes #5039
changelog: Don't trigger [`use_debug`] lint in Debug impl
bors [Tue, 3 Mar 2020 11:16:55 +0000 (11:16 +0000)]
Auto merge of #5250 - mlegner:unused_fp, r=flip1995
Whitelist unused attribute for use items.
This PR whitelists the `unused` attribute with `use` items and adds a corresponding test case.
Fixes: #5229
changelog: none
flip1995 [Tue, 3 Mar 2020 09:53:14 +0000 (10:53 +0100)]
Add path for display trait
flip1995 [Tue, 3 Mar 2020 09:52:56 +0000 (10:52 +0100)]
Use lang items instead of get_trait_def_id where possible
flip1995 [Tue, 14 Jan 2020 15:28:20 +0000 (16:28 +0100)]
Update stderr
flip1995 [Tue, 14 Jan 2020 15:28:08 +0000 (16:28 +0100)]
Don't lint debug formatting in debug impl
bors [Mon, 2 Mar 2020 20:31:27 +0000 (20:31 +0000)]
Auto merge of #5242 - matthiaskrgr:5238_test, r=flip1995
add test for #5238
changelog: none
bors [Mon, 2 Mar 2020 20:00:31 +0000 (20:00 +0000)]
Auto merge of #5254 - JohnTitor:sugg, r=flip1995
Rustup to rust-lang/rust#69469
changelog: none
Yuki Okushi [Mon, 2 Mar 2020 19:37:39 +0000 (04:37 +0900)]
Rustup to rust-lang/rust#69469
mlegner [Mon, 2 Mar 2020 09:22:05 +0000 (10:22 +0100)]
Whitelist unused attribute for use items.
JarredAllen [Mon, 2 Mar 2020 07:11:29 +0000 (23:11 -0800)]
Fix one last test issue
JarredAllen [Mon, 2 Mar 2020 06:37:37 +0000 (22:37 -0800)]
Refactor suggested by krishna-veerareddy
JarredAllen [Sun, 1 Mar 2020 21:12:56 +0000 (13:12 -0800)]
Fixed compile error from merging
JarredAllen [Sun, 1 Mar 2020 20:48:22 +0000 (12:48 -0800)]
Merge branch 'master' of github.com:rust-lang/rust-clippy
bors [Sun, 1 Mar 2020 15:41:00 +0000 (15:41 +0000)]
Auto merge of #5247 - JohnTitor:syntax, r=flip1995
Some rustups
changelog: none
Yuki Okushi [Sun, 1 Mar 2020 15:17:14 +0000 (00:17 +0900)]
Disable rls test for now
Yuki Okushi [Sun, 1 Mar 2020 14:32:49 +0000 (23:32 +0900)]
Rustup to rust-lang/rust#69579
Yuki Okushi [Sun, 1 Mar 2020 03:23:33 +0000 (12:23 +0900)]
Rustup to rust-lang/rust#69592
JarredAllen [Sun, 1 Mar 2020 03:11:38 +0000 (19:11 -0800)]
Changed test output to reflect cargo fmt
JarredAllen [Sun, 1 Mar 2020 02:51:39 +0000 (18:51 -0800)]
Run cargo dev fmt
JarredAllen [Sat, 29 Feb 2020 21:46:59 +0000 (13:46 -0800)]
Finished checking for cases of absolute values
Matthias Krüger [Fri, 28 Feb 2020 21:00:20 +0000 (22:00 +0100)]
add test for #5238
JarredAllen [Fri, 28 Feb 2020 20:40:13 +0000 (12:40 -0800)]
Some bugfixing
JarredAllen [Fri, 28 Feb 2020 06:31:41 +0000 (22:31 -0800)]
Created floating point abs lint and test, but not yet run
flip1995 [Thu, 27 Feb 2020 16:56:39 +0000 (17:56 +0100)]
Fix deploy script for tag deploys
bors [Thu, 27 Feb 2020 09:52:56 +0000 (09:52 +0000)]
Auto merge of #5232 - JohnTitor:git2-0.12, r=phansch
Update git2 to 0.12
changelog: none
Yuki Okushi [Thu, 27 Feb 2020 04:40:48 +0000 (13:40 +0900)]
Update git2 to 0.12
bors [Thu, 27 Feb 2020 06:40:31 +0000 (06:40 +0000)]
Auto merge of #5231 - JohnTitor:associated-type-defaults, r=phansch
Rustup to rust-lang/rust#61812
changelog: none
Yuki Okushi [Thu, 27 Feb 2020 03:19:18 +0000 (12:19 +0900)]
Rustup to rust-lang/rust#61812
bors [Mon, 24 Feb 2020 08:33:03 +0000 (08:33 +0000)]
Auto merge of #4897 - krishna-veerareddy:issue-2040-accurate-float-functions, r=flip1995
Add lint to improve floating-point expressions
Looks for floating-point expressions that can be expressed using built-in methods to improve accuracy, performance and/or succinctness.
changelog: Add lint `floating_point_improvements`.
Fixes #4726
Partly addresses [#2040](https://github.com/rust-lang/rust-clippy/issues/2040)
Currently linted expressions:
| Expression | Suggestion |
|---------------------------------|------------|
| x.log(2.0) | x.log2() |
| x.log(10.0) | x.log10() |
| x.log(std::f32::consts::E) | x.ln() |
| (1 + x).ln() | x.ln_1p() |
| (2.0).powf(x) | x.exp2() |
| (std::f32::consts::E).powf(x) | x.exp() |
| x.powf(1/2) | x.sqrt() |
| x.powf(1/3) | x.cbrt() |
| x.powf(y), where y is whole | x.powi(y) |
| x.exp() - 1 | x.exp_m1() |
|x * y + z|x.mul_add(y, z)|
bors [Mon, 24 Feb 2020 08:20:10 +0000 (08:20 +0000)]
Auto merge of #5222 - JohnTitor:dont-deploy, r=flip1995
Do not run deploy action on other repos
Usually, we don't have to run deploy action on other repos, let's ignore there.
changelog: none
Krishna Sai Veera Reddy [Mon, 24 Feb 2020 05:06:55 +0000 (21:06 -0800)]
Add `imprecise_flops` lint
Add lint to detect floating point operations that can be computed more
accurately at the cost of performance. `cbrt`, `ln_1p` and `exp_m1`
library functions call their equivalent cmath implementations which is
slower but more accurate so moving checks for these under this new lint.
Krishna Sai Veera Reddy [Mon, 24 Feb 2020 04:48:57 +0000 (20:48 -0800)]
Rename `mul_add` test file and add general improvements
Krishna Sai Veera Reddy [Sun, 23 Feb 2020 08:04:11 +0000 (00:04 -0800)]
Move `manual_mul_add` into `suboptimal_flops` lint
Krishna Sai Veera Reddy [Sun, 23 Feb 2020 04:32:13 +0000 (20:32 -0800)]
Run rust-fix on tests
Krishna Sai Veera Reddy [Sun, 23 Feb 2020 04:29:22 +0000 (20:29 -0800)]
Fix `powi` suggestion and add general improvements
Krishna Sai Veera Reddy [Mon, 17 Feb 2020 20:56:55 +0000 (12:56 -0800)]
Change lint name to `suboptimal_flops`