]> git.lizzy.rs Git - rust.git/log
rust.git
3 years agoRollup merge of #82764 - m-ou-se:map-try-insert, r=Amanieu
Mara [Fri, 5 Mar 2021 09:57:22 +0000 (10:57 +0100)]
Rollup merge of #82764 - m-ou-se:map-try-insert, r=Amanieu

Add {BTreeMap,HashMap}::try_insert

`{BTreeMap,HashMap}::insert(key, new_val)` returns `Some(old_val)` if the key was already in the map. It's often useful to assert no duplicate values are inserted.

We experimented with `map.insert(key, val).unwrap_none()` (https://github.com/rust-lang/rust/issues/62633), but decided that that's not the kind of method we'd like to have on `Option`s.

`insert` always succeeds because it replaces the old value if it exists. One could argue that `insert()` is never the right method for panicking on duplicates, since already handles that case by replacing the value, only allowing you to panic after that already happened.

This PR adds a `try_insert` method that instead returns a `Result::Err` when the key already exists. This error contains both the `OccupiedEntry` and the value that was supposed to be inserted. This means that unwrapping that result gives more context:
```rust
    map.insert(10, "world").unwrap_none();
    // thread 'main' panicked at 'called `Option::unwrap_none()` on a `Some` value: "hello"', src/main.rs:8:29
```

```rust
    map.try_insert(10, "world").unwrap();
    // thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value:
    // OccupiedError { key: 10, old_value: "hello", new_value: "world" }', src/main.rs:6:33
```

It also allows handling the failure in any other way, as you have full access to the `OccupiedEntry` and the value.

`try_insert` returns a reference to the value in case of success, making it an alternative to `.entry(key).or_insert(value)`.

r? ```@Amanieu```

Fixes https://github.com/rust-lang/rfcs/issues/3092

3 years agoRollup merge of #82728 - calebsander:refactor/bufreader-buf, r=m-ou-se
Mara [Fri, 5 Mar 2021 09:57:20 +0000 (10:57 +0100)]
Rollup merge of #82728 - calebsander:refactor/bufreader-buf, r=m-ou-se

Avoid unnecessary Vec construction in BufReader

As mentioned in #80460, creating a `Vec` and calling `Vec::into_boxed_slice()` emits unnecessary calls to `realloc()` and `free()`. Updated the code to use `Box::new_uninit_slice()` to create a boxed slice directly. I think this also makes it more explicit that the initial contents of the buffer are uninitialized.

r? ``@m-ou-se``

3 years agoRollup merge of #82289 - SkiFire13:fix-issue-82282, r=m-ou-se
Mara [Fri, 5 Mar 2021 09:57:19 +0000 (10:57 +0100)]
Rollup merge of #82289 - SkiFire13:fix-issue-82282, r=m-ou-se

Fix underflow in specialized ZipImpl::size_hint

Fixes #82282

3 years agoRollup merge of #81939 - kper:fixing-81584-allocate-in-iter, r=davidtwco
Mara [Fri, 5 Mar 2021 09:57:18 +0000 (10:57 +0100)]
Rollup merge of #81939 - kper:fixing-81584-allocate-in-iter, r=davidtwco

Add suggestion `.collect()` for iterators in iterators

Closes #81584

```
error[E0515]: cannot return value referencing function parameter `y`
 --> main3.rs:4:38
  |
4 | ...                   .map(|y| y.iter().map(|x| x + 1))
  |                                -^^^^^^^^^^^^^^^^^^^^^^
  |                                |
  |                                returns a value referencing data owned by the current function
  |                                `y` is borrowed here
  |                                help: Maybe use `.collect()` to allocate the iterator
```

Added the suggestion: `help: Maybe use `.collect()` to allocate the iterator`

3 years agoRollup merge of #81136 - Xavientois:io_reader_size_hint, r=cramertj
Mara [Fri, 5 Mar 2021 09:57:17 +0000 (10:57 +0100)]
Rollup merge of #81136 - Xavientois:io_reader_size_hint, r=cramertj

Improved IO Bytes Size Hint

After trying to implement better `size_hint()` return values for `File` in [this PR](https://github.com/rust-lang/rust/pull/81044) and changing to implementing it for `BufReader` in [this PR](https://github.com/rust-lang/rust/pull/81052), I have arrived at this implementation that provides tighter bounds for the `Bytes` iterator of various readers including `BufReader`, `Empty`, and `Chain`.

Unfortunately, for `BufReader`, the size_hint only improves after calling `fill_buffer` due to it using the contents of the buffer for the hint. Nevertheless, the the tighter bounds  should result in better pre-allocation of space to handle the contents of the `Bytes` iterator.

Closes #81052

3 years agoRollup merge of #80763 - petrochenkov:pubusecrate, r=estebank
Mara [Fri, 5 Mar 2021 09:57:15 +0000 (10:57 +0100)]
Rollup merge of #80763 - petrochenkov:pubusecrate, r=estebank

resolve: Reduce scope of `pub_use_of_private_extern_crate` deprecation lint

This lint was deny-by-default since July 2017, crater showed 7 uses on crates.io back then (https://github.com/rust-lang/rust/pull/42894#issuecomment-311921147).

Unfortunately, the construction `pub use foo as bar` where `foo` is `extern crate foo;` was used by an older version `bitflags`, so turning it into an error causes too many regressions.
So, this PR reduces the scope of the lint instead of turning it into a hard error, and only turns some more rarely used components of it into errors.

3 years agoRollup merge of #80723 - rylev:noop-lint-pass, r=estebank
Mara [Fri, 5 Mar 2021 09:57:14 +0000 (10:57 +0100)]
Rollup merge of #80723 - rylev:noop-lint-pass, r=estebank

Implement NOOP_METHOD_CALL lint

Implements the beginnings of https://github.com/rust-lang/lang-team/issues/67 - a lint for detecting noop method calls (e.g, calling `<&T as Clone>::clone()` when `T: !Clone`).

This PR does not fully realize the vision and has a few limitations that need to be addressed either before merging or in subsequent PRs:
* [ ] No UFCS support
* [ ] The warning message is pretty plain
* [ ] Doesn't work for `ToOwned`

The implementation uses [`Instance::resolve`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/ty/instance/struct.Instance.html#method.resolve) which is normally later in the compiler. It seems that there are some invariants that this function relies on that we try our best to respect. For instance, it expects substitutions to have happened, which haven't yet performed, but we check first for `needs_subst` to ensure we're dealing with a monomorphic type.

Thank you to ```@davidtwco,``` ```@Aaron1011,``` and ```@wesleywiser``` for helping me at various points through out this PR ❤️.

3 years agoAuto merge of #71481 - estebank:inherit-stability, r=nikomatsakis
bors [Fri, 5 Mar 2021 05:28:07 +0000 (05:28 +0000)]
Auto merge of #71481 - estebank:inherit-stability, r=nikomatsakis

Inherit `#[stable(..)]` annotations in enum variants and fields from its item

Lint changes for #65515. The stdlib will have to be updated once this lands in beta and that version is promoted in master.

3 years agoAuto merge of #82747 - JohnTitor:pin-es-check-version, r=Mark-Simulacrum
bors [Thu, 4 Mar 2021 19:24:21 +0000 (19:24 +0000)]
Auto merge of #82747 - JohnTitor:pin-es-check-version, r=Mark-Simulacrum

Pin es-check version to prevent unrelated CI failures

es-check v5.2.1 causes a lot of unrelated CI failures on mingw-check, e.g. https://github.com/rust-lang/rust/pull/80723#issuecomment-790294196.
es-check v5.2.2 fixes it but let's pin its version to prevent further failures.

3 years agoAdd tracking issue for map_try_insert.
Mara Bos [Thu, 4 Mar 2021 15:54:28 +0000 (16:54 +0100)]
Add tracking issue for map_try_insert.

3 years agoRemove unnecessary bound from HashMap::try_insert.
Mara Bos [Thu, 4 Mar 2021 15:46:41 +0000 (16:46 +0100)]
Remove unnecessary bound from HashMap::try_insert.

3 years agoIgnore file length tidy warning in hash/map.rs.
Mara Bos [Thu, 4 Mar 2021 15:25:24 +0000 (16:25 +0100)]
Ignore file length tidy warning in hash/map.rs.

3 years agoAuto merge of #81451 - nikic:llvm-12, r=nagisa
bors [Thu, 4 Mar 2021 15:16:44 +0000 (15:16 +0000)]
Auto merge of #81451 - nikic:llvm-12, r=nagisa

Upgrade to LLVM 12

This implements the necessary adjustments to make rustc work with LLVM 12. I didn't encounter any major issues so far.

r? `@cuviper`

3 years agoImplement Error for OccupiedError.
Mara Bos [Thu, 4 Mar 2021 14:57:26 +0000 (15:57 +0100)]
Implement Error for OccupiedError.

3 years agoImprove Debug implementations of OccupiedError.
Mara Bos [Thu, 4 Mar 2021 14:56:38 +0000 (15:56 +0100)]
Improve Debug implementations of OccupiedError.

3 years agoAdd HashMap::try_insert and hash_map::OccupiedError.
Mara Bos [Thu, 4 Mar 2021 14:34:47 +0000 (15:34 +0100)]
Add HashMap::try_insert and hash_map::OccupiedError.

3 years agoAdd BTreeMap::try_insert and btree_map::OccupiedError.
Mara Bos [Thu, 4 Mar 2021 14:34:47 +0000 (15:34 +0100)]
Add BTreeMap::try_insert and btree_map::OccupiedError.

3 years agoAuto merge of #82756 - JohnTitor:rollup-e4ij7h6, r=JohnTitor
bors [Thu, 4 Mar 2021 11:02:13 +0000 (11:02 +0000)]
Auto merge of #82756 - JohnTitor:rollup-e4ij7h6, r=JohnTitor

Rollup of 8 pull requests

Successful merges:

 - #80527 (Make rustdoc lints a tool lint instead of built-in)
 - #82310 (Load rustdoc's JS search index on-demand.)
 - #82315 (Improve page load performance in rustdoc)
 - #82564 (Revert `Vec::spare_capacity_mut` impl to prevent pointers invalidation)
 - #82697 (Fix stabilization version of move_ref_pattern)
 - #82717 (Account for macros when suggesting adding lifetime)
 - #82740 (Fix commit detected when using `download-rustc`)
 - #82744 (Pass `CrateNum` by value instead of by reference)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

3 years agoRollup merge of #82744 - camelid:cratenum-byval, r=GuillaumeGomez
Yuki Okushi [Thu, 4 Mar 2021 11:01:12 +0000 (20:01 +0900)]
Rollup merge of #82744 - camelid:cratenum-byval, r=GuillaumeGomez

Pass `CrateNum` by value instead of by reference

It's more idiomatic to pass a small Copy type by value and `CrateNum` is
half the size of `&CrateNum` on 64-bit systems. The memory use change is
almost certainly insignificant, but why not!

3 years agoRollup merge of #82740 - jyn514:proper-history, r=Mark-Simulacrum
Yuki Okushi [Thu, 4 Mar 2021 11:01:10 +0000 (20:01 +0900)]
Rollup merge of #82740 - jyn514:proper-history, r=Mark-Simulacrum

Fix commit detected when using `download-rustc`

On reflection on the issue in https://github.com/rust-lang/rust/pull/79540#discussion_r572572280, I think the bug was actually using the `compiler/` filter, not using `--author=bors`. https://github.com/rust-lang/rust/commit/9a1d6174c925f54c923599e29b09d6855e6b3a78 has no CI artifacts because it was merged as part of a rollup:
```
$ curl -I https://ci-artifacts.rust-lang.org/rustc-builds/96e843ce6ae42e0aa519ba45e148269de347fd84/rust-std-nightly-x86_64-unknown-linux-gnu.tar.xz
HTTP/2 404
```
So 9a1d6174c925f54c923599e29b09d6855e6b3a78 is the correct commit to download, and that's what `--author=bors` does:

$ git log --author=bors 4aec8a5da5547d6e1c24e99dad0003b7cac107f5
commit 9a1d6174c925f54c923599e29b09d6855e6b3a78

Ideally it would look for "the most recent bors commit not followed by a change to `compiler/`", which would exclude things like documentation changes and avoid redownloading more than necessary, but
- Redownloading isn't the end of the world,
- That metric is hard to implement, and
- Documentation-only or library-only changes are very rare anyway since they're usually rolled up with changes to the compiler.

Helps with https://github.com/rust-lang/rust/issues/81930.

r? `@Mark-Simulacrum`

3 years agoRollup merge of #82717 - estebank:issue-70152, r=lcnr
Yuki Okushi [Thu, 4 Mar 2021 11:01:09 +0000 (20:01 +0900)]
Rollup merge of #82717 - estebank:issue-70152, r=lcnr

Account for macros when suggesting adding lifetime

Fix #70152.

3 years agoRollup merge of #82697 - jplatte:patch-1, r=davidtwco
Yuki Okushi [Thu, 4 Mar 2021 11:01:07 +0000 (20:01 +0900)]
Rollup merge of #82697 - jplatte:patch-1, r=davidtwco

Fix stabilization version of move_ref_pattern

Both the [changelog](https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1490-2020-12-31) and the milestone of the [stabilization PR](https://github.com/rust-lang/rust/pull/76119) say 1.49.0, but the source says 1.48.0. I think the former is correct.

3 years agoRollup merge of #82564 - WaffleLapkin:revert_spare_mut, r=RalfJung
Yuki Okushi [Thu, 4 Mar 2021 11:01:06 +0000 (20:01 +0900)]
Rollup merge of #82564 - WaffleLapkin:revert_spare_mut, r=RalfJung

Revert `Vec::spare_capacity_mut` impl to prevent pointers invalidation

The implementation was changed in #79015.

Later it was [pointed out](https://github.com/rust-lang/rust/issues/81944#issuecomment-782849785) that the implementation invalidates pointers to the buffer (initialized elements) by creating a unique reference to the buffer. This PR reverts the implementation.

r? ```@RalfJung```

3 years agoRollup merge of #82315 - jsha:font-display-swap, r=GuillaumeGomez
Yuki Okushi [Thu, 4 Mar 2021 11:01:04 +0000 (20:01 +0900)]
Rollup merge of #82315 - jsha:font-display-swap, r=GuillaumeGomez

Improve page load performance in rustdoc

Add an explicit height to icons (which already had an explicit width) to allow browsers to lay out the page more accurately before the icons have been loaded. https://web.dev/optimize-cls/.

Add min-width: 115px to the crate search dropdown. When the HTML first loads, this dropdown includes only the text "All crates." Later, JS loads the items underneath it, some of which are wider. That causes the dropdown to get wider, causing a distracting reflow. This sets a min-width based on the size that the dropdown eventually becomes based on the crates on doc.rust-lang.org, reducing page movement during load.

Add font-display: swap. Per https://web.dev/font-display/, this prevents "flash of invisible text" during load by using a system font until the custom font is available. I've noticed this flash of invisible text occasionally when reading Rust docs. Note that users without cached fonts will see text, and then see it reflow. For `docs.rust-lang.org`, [setting caching headers will help a lot](https://github.com/rust-lang/simpleinfra/issues/62).

Generated output at https://jacob.hoffman-andrews.com/rust/flow-improvements/std/string/struct.String.html.

3 years agoRollup merge of #82310 - jsha:rustdoc-search-onfocus, r=GuillaumeGomez
Yuki Okushi [Thu, 4 Mar 2021 11:01:03 +0000 (20:01 +0900)]
Rollup merge of #82310 - jsha:rustdoc-search-onfocus, r=GuillaumeGomez

Load rustdoc's JS search index on-demand.

Instead of being loaded on every page, the JS search index is now loaded when either (a) there is a `?search=` param, or (b) the search input is focused.

This saves both CPU and bandwidth. As of Feb 2021, https://doc.rust-lang.org/search-index1.50.0.js is 273,838 bytes gzipped or 2,544,939 bytes uncompressed. Evaluating it takes 445 ms of CPU time in Chrome 88 on a i7-10710U CPU (out of a total ~2,100 ms page reload).

Tested on Firefox and Chrome.

New:
https://jacob.hoffman-andrews.com/rust/search-on-demand/std/primitive.slice.html
https://jacob.hoffman-andrews.com/rust/search-on-demand/std/primitive.slice.html?search=fn

Old:
https://jacob.hoffman-andrews.com/rust/search-on-load/std/primitive.slice.html
https://jacob.hoffman-andrews.com/rust/search-on-load/std/primitive.slice.html?search=fn

3 years agoRollup merge of #80527 - jyn514:rustdoc-lints, r=GuillaumeGomez
Yuki Okushi [Thu, 4 Mar 2021 11:01:01 +0000 (20:01 +0900)]
Rollup merge of #80527 - jyn514:rustdoc-lints, r=GuillaumeGomez

Make rustdoc lints a tool lint instead of built-in

- Rename `broken_intra_doc_links` to `rustdoc::broken_intra_doc_links` (and similar for other rustdoc lints; I don't expect any others to be used frequently, though).
- Ensure that the old lint names still work and give deprecation errors
- Register lints even when running doctests
- Move lint machinery into a separate file
- Add `declare_rustdoc_lint!` macro

Unblocks https://github.com/rust-lang/rust/pull/80300, https://github.com/rust-lang/rust/pull/79816, https://github.com/rust-lang/rust/pull/80965. Makes the strangeness in https://github.com/rust-lang/rust/pull/77364 more apparent to the end user (note that `missing_docs` is *not* moved to rustdoc in this PR). Closes https://github.com/rust-lang/rust/issues/78786.

## Current status

This is blocked on #82620 (see https://github.com/rust-lang/rust/pull/80527#issuecomment-787401519)

3 years agoPin es-check version to prevent unrelated CI failures
Yuki Okushi [Thu, 4 Mar 2021 06:03:01 +0000 (15:03 +0900)]
Pin es-check version to prevent unrelated CI failures

3 years agoAuto merge of #82304 - LeSeulArtichaut:unpretty-ast, r=spastorino
bors [Thu, 4 Mar 2021 05:46:43 +0000 (05:46 +0000)]
Auto merge of #82304 - LeSeulArtichaut:unpretty-ast, r=spastorino

Add `-Z unpretty` flags for the AST

Implements rust-lang/compiler-team#408.
Builds on #82269, but if that PR is rejected or stalls out, I can implement this without #82269.
cc rust-lang/rustc-dev-guide#1062

3 years agoPass `CrateNum` by value instead of by reference
Camelid [Thu, 4 Mar 2021 04:04:27 +0000 (20:04 -0800)]
Pass `CrateNum` by value instead of by reference

It's more idiomatic to pass a small Copy type by value and `CrateNum` is
half the size of `&CrateNum` on 64-bit systems. The memory use change is
almost certainly insignificant, but why not!

3 years agoFix commit detected when using `download-rustc`
Joshua Nelson [Thu, 4 Mar 2021 03:11:07 +0000 (22:11 -0500)]
Fix commit detected when using `download-rustc`

On reflection on the issue in https://github.com/rust-lang/rust/pull/79540#discussion_r572572280,  I think the bug was actually using the `compiler/` filter, not using `--author=bors`. https://github.com/rust-lang/rust/commit/9a1d6174c925f54c923599e29b09d6855e6b3a78 has no CI artifacts because it was merged as part of a rollup:
```
$ curl -I https://ci-artifacts.rust-lang.org/rustc-builds/96e843ce6ae42e0aa519ba45e148269de347fd84/rust-std-nightly-x86_64-unknown-linux-gnu.tar.xz
HTTP/2 404
```
So 9a1d6174c925f54c923599e29b09d6855e6b3a78 is the correct commit to download, and that's what `--author=bors` does:

$ git log --author=bors 4aec8a5da5547d6e1c24e99dad0003b7cac107f5
commit 9a1d6174c925f54c923599e29b09d6855e6b3a78

Ideally it would look for "the most recent bors commit not followed by a change to `compiler/`", which would exclude things like documentation changes and avoid redownloading more than necessary, but
- Redownloading isn't the end of the world,
- That metric is hard to implement, and
- Documentation-only or library-only changes are very rare anyway since they're usually rolled up with changes to the compiler.

3 years agoAuto merge of #81114 - bugadani:generator, r=estebank
bors [Thu, 4 Mar 2021 00:23:42 +0000 (00:23 +0000)]
Auto merge of #81114 - bugadani:generator, r=estebank

Box generator-related Body fields

Might save some memory on functions that aren't generators.

3 years agoAuto merge of #82702 - jyn514:downgrade-err, r=Manishearth
bors [Wed, 3 Mar 2021 21:35:32 +0000 (21:35 +0000)]
Auto merge of #82702 - jyn514:downgrade-err, r=Manishearth

Change error about unknown attributes to a warning

Hard errors should go through a future-compatibility phase first, especially since these attributes only have no effect and don't actively cause bugs.

Follow-up to https://github.com/rust-lang/rust/pull/82662. Fixes ecosystem breakage like https://github.com/rust-lang/rust-clippy/issues/6832.

r? `@GuillaumeGomez`

3 years agoRemove useless comparison since now self.index <= self.len is an invariant
Giacomo Stevanato [Fri, 19 Feb 2021 11:17:48 +0000 (12:17 +0100)]
Remove useless comparison since now self.index <= self.len is an invariant

3 years agoAdd test for underflow in specialized Zip's size_hint
Giacomo Stevanato [Fri, 19 Feb 2021 11:16:12 +0000 (12:16 +0100)]
Add test for underflow in specialized Zip's size_hint

3 years agoIncrement self.len in specialized ZipImpl to avoid underflow in size_hint
Giacomo Stevanato [Fri, 19 Feb 2021 11:15:37 +0000 (12:15 +0100)]
Increment self.len in specialized ZipImpl to avoid underflow in size_hint

3 years agoreworded message
Esteban Küber [Wed, 3 Mar 2021 20:15:26 +0000 (12:15 -0800)]
reworded message

3 years agoExplicitly disable preinline during pgo-use test
Nikita Popov [Wed, 3 Mar 2021 16:58:39 +0000 (17:58 +0100)]
Explicitly disable preinline during pgo-use test

We previously used -Os to disable this pass, but since
https://reviews.llvm.org/D91673 this no longer works. Explicitly
disable it using -Cllvm-args instead.

3 years agoSchedule ThinLTOBuffer passes again after sanitizer passes
Nikita Popov [Tue, 2 Mar 2021 20:54:03 +0000 (21:54 +0100)]
Schedule ThinLTOBuffer passes again after sanitizer passes

This works around a design defect in the LLVM 12 pass builder
implementation. In LLVM 13, the PreLink ThinLTO pipeline properly
respects the OptimizerLastEPCallbacks.

3 years agoAuto merge of #82553 - tmiasko:update-tracing, r=Mark-Simulacrum
bors [Wed, 3 Mar 2021 18:01:29 +0000 (18:01 +0000)]
Auto merge of #82553 - tmiasko:update-tracing, r=Mark-Simulacrum

Update tracing to 0.1.25

* Update tracing from 0.1.18 to 0.1.25
* Update tracing-subscriber from 0.2.13 to 0.2.16
* Update tracing-tree from 0.1.6 to 0.1.8
* Add pin-project-lite to the list of allowed dependencies (it is now a direct dependency of tracing).

3 years agoAvoid unnecessary Vec construction in BufReader
Caleb Sander [Mon, 28 Dec 2020 20:45:36 +0000 (15:45 -0500)]
Avoid unnecessary Vec construction in BufReader

3 years agoUpdate library/alloc/src/vec/mod.rs
Waffle Lapkin [Wed, 3 Mar 2021 17:04:20 +0000 (20:04 +0300)]
Update library/alloc/src/vec/mod.rs

Co-authored-by: Ralf Jung <post@ralfj.de>
3 years agoChange error about unknown doc attributes to a warning
Joshua Nelson [Tue, 2 Mar 2021 14:42:32 +0000 (09:42 -0500)]
Change error about unknown doc attributes to a warning

This prevents breakage across the ecosystem, since the error was just
introduced recently without first having a warning period.

3 years agoAdd `-Z unpretty` flags for the AST
LeSeulArtichaut [Fri, 19 Feb 2021 21:40:28 +0000 (22:40 +0100)]
Add `-Z unpretty` flags for the AST

3 years agoAuto merge of #82704 - RalfJung:miri-atomic-minmax, r=oli-obk
bors [Wed, 3 Mar 2021 11:05:01 +0000 (11:05 +0000)]
Auto merge of #82704 - RalfJung:miri-atomic-minmax, r=oli-obk

enable atomic_min/max tests in Miri

Thanks to `@henryboisdequin` and `@GregBowyer,` Miri now supports these intrinsics. :)
Also includes the necessary Miri update.

3 years agoWarn in doc test
Ryan Levick [Wed, 17 Feb 2021 09:06:23 +0000 (10:06 +0100)]
Warn in doc test

3 years agoFix borrow and deref
Ryan Levick [Tue, 16 Feb 2021 21:39:05 +0000 (22:39 +0100)]
Fix borrow and deref

3 years agoRemove lint pass on borrow and deref
Ryan Levick [Tue, 16 Feb 2021 14:12:19 +0000 (15:12 +0100)]
Remove lint pass on borrow and deref

3 years agoMove unrelated ui test back to what it was before
Ryan Levick [Wed, 10 Feb 2021 10:08:00 +0000 (11:08 +0100)]
Move unrelated ui test back to what it was before

3 years agoAllow noop_method_call in clippy ui test
Ryan Levick [Mon, 18 Jan 2021 13:15:19 +0000 (14:15 +0100)]
Allow noop_method_call in clippy ui test

3 years agoClean up code rightward drift
Esteban Küber [Wed, 13 Jan 2021 18:39:25 +0000 (10:39 -0800)]
Clean up code rightward drift

3 years agoIncrease accuracy of lint trigger
Esteban Küber [Wed, 13 Jan 2021 02:37:32 +0000 (18:37 -0800)]
Increase accuracy of lint trigger

3 years agoImprove error messages
Ryan Levick [Tue, 12 Jan 2021 13:58:51 +0000 (14:58 +0100)]
Improve error messages

3 years agoFix tidy error
Ryan Levick [Mon, 11 Jan 2021 18:02:19 +0000 (19:02 +0100)]
Fix tidy error

3 years agoUpdate error message
Ryan Levick [Mon, 11 Jan 2021 10:47:16 +0000 (11:47 +0100)]
Update error message

3 years agoFix tidy errors
Ryan Levick [Fri, 8 Jan 2021 11:09:29 +0000 (12:09 +0100)]
Fix tidy errors

3 years agoImprove warning
Ryan Levick [Fri, 8 Jan 2021 10:37:52 +0000 (11:37 +0100)]
Improve warning

3 years agoFix std tests
Ryan Levick [Thu, 7 Jan 2021 12:13:25 +0000 (13:13 +0100)]
Fix std tests

3 years agoOnly allow new lint when not bootstrapping - since beta doesn't know about the lint
Ryan Levick [Thu, 7 Jan 2021 10:24:32 +0000 (11:24 +0100)]
Only allow new lint when not bootstrapping - since beta doesn't know about the lint

3 years agoFix core tests
Ryan Levick [Wed, 6 Jan 2021 20:11:08 +0000 (21:11 +0100)]
Fix core tests

3 years agoFix ui-full-deps suite
Ryan Levick [Wed, 6 Jan 2021 16:56:34 +0000 (17:56 +0100)]
Fix ui-full-deps suite

3 years agoBless test where order of error message changed
Ryan Levick [Wed, 6 Jan 2021 13:48:06 +0000 (14:48 +0100)]
Bless test where order of error message changed

3 years agoFix tests
Ryan Levick [Tue, 5 Jan 2021 15:46:50 +0000 (16:46 +0100)]
Fix tests

3 years agoAdd tests and support two more noop methods
Ryan Levick [Tue, 5 Jan 2021 15:14:39 +0000 (16:14 +0100)]
Add tests and support two more noop methods

3 years agoFirst version of noop-lint
Ryan Levick [Tue, 5 Jan 2021 09:07:50 +0000 (10:07 +0100)]
First version of noop-lint

3 years agoAuto merge of #82718 - JohnTitor:rollup-vpfx3j2, r=JohnTitor
bors [Wed, 3 Mar 2021 08:36:46 +0000 (08:36 +0000)]
Auto merge of #82718 - JohnTitor:rollup-vpfx3j2, r=JohnTitor

Rollup of 10 pull requests

Successful merges:

 - #81223 ([rustdoc] Generate redirect map file)
 - #82439 (BTree: fix untrue safety)
 - #82469 (Use a crate to produce rustdoc tree comparisons instead of the `diff` command)
 - #82589 (unix: Non-mutable bufs in send_vectored_with_ancillary_to)
 - #82689 (meta: Notify Zulip for rustdoc nominated issues)
 - #82695 (Revert non-power-of-two vector restriction)
 - #82706 (use outer_expn_data() instead of outer_expn().expn_data())
 - #82710 (FloatToInit: Replacing round_unchecked_to --> to_int_unchecked)
 - #82712 (Remove unnecessary conditional `cfg(target_os)` for `redox` and `vxworks`)
 - #82713 (Update cargo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

3 years agoRollup merge of #82713 - ehuss:update-cargo, r=ehuss
Yuki Okushi [Wed, 3 Mar 2021 07:27:48 +0000 (16:27 +0900)]
Rollup merge of #82713 - ehuss:update-cargo, r=ehuss

Update cargo

12 commits in 572e201536dc2e4920346e28037b63c0f4d88b3c..c68432f1e5cbbc09833699a951b1b5b059651dff
2021-02-24 16:51:20 +0000 to 2021-03-02 18:26:29 +0000
- Don't panic when printing JSON with non-utf8 paths (rust-lang/cargo#9226)
- Detect changes for JSON spec targets. (rust-lang/cargo#9223)
- Fix `cargo_target_empty_cfg` test with env var. (rust-lang/cargo#9225)
- Correct default cargo new edition (rust-lang/cargo#9202)
- Update split-debuginfo docs around the default. (rust-lang/cargo#9224)
- Minor update to registry API error messages. (rust-lang/cargo#9213)
- Some minor code cleanup. (rust-lang/cargo#9214)
- doc: Fix spelling worksapce-&gt;workspace (rust-lang/cargo#9212)
- Update SPDX version in docs. (rust-lang/cargo#9209)
- Throw error if CARGO_TARGET_DIR is an empty string (rust-lang/cargo#8939)
- testsuite: Use split debuginfo on macos. (rust-lang/cargo#9207)
- testsuite: Improve performance when using rustup. (rust-lang/cargo#9206)

3 years agoRollup merge of #82712 - CDirkx:cfg-target_os, r=dtolnay
Yuki Okushi [Wed, 3 Mar 2021 07:27:47 +0000 (16:27 +0900)]
Rollup merge of #82712 - CDirkx:cfg-target_os, r=dtolnay

Remove unnecessary conditional `cfg(target_os)` for `redox` and `vxworks`

`redox` and `vxworks` are now part of target_family `unix`, thus `cfg(unix)` already implies `cfg(target_os="redox")` and `cfg(target_os="vxworks")`

https://github.com/rust-lang/rust/blob/35dbef235048f9a2939dc20effe083ca483c37ff/compiler/rustc_target/src/spec/redox_base.rs#L26

https://github.com/rust-lang/rust/blob/35dbef235048f9a2939dc20effe083ca483c37ff/compiler/rustc_target/src/spec/vxworks_base.rs#L27

3 years agoRollup merge of #82710 - peter-kehl:FloatToInit_82709, r=sfackler
Yuki Okushi [Wed, 3 Mar 2021 07:27:46 +0000 (16:27 +0900)]
Rollup merge of #82710 - peter-kehl:FloatToInit_82709, r=sfackler

FloatToInit: Replacing round_unchecked_to --> to_int_unchecked

FloatToInit docs: Replacing round_unchecked_to with
to_int_unchecked. Bug #82709.

3 years agoRollup merge of #82706 - klensy:expn-data, r=petrochenkov
Yuki Okushi [Wed, 3 Mar 2021 07:27:45 +0000 (16:27 +0900)]
Rollup merge of #82706 - klensy:expn-data, r=petrochenkov

use outer_expn_data() instead of outer_expn().expn_data()

From the comment in hygiene.rs, so use it:
https://github.com/rust-lang/rust/blob/master/compiler/rustc_span/src/hygiene.rs#L627-L632

3 years agoRollup merge of #82695 - XAMPPRocky:remove-non-power-of-two-limit, r=nagisa
Yuki Okushi [Wed, 3 Mar 2021 07:27:44 +0000 (16:27 +0900)]
Rollup merge of #82695 - XAMPPRocky:remove-non-power-of-two-limit, r=nagisa

Revert non-power-of-two vector restriction

Removes the power of two restriction from rustc. As discussed in https://github.com/rust-lang/stdsimd/issues/63

r? ```@calebzulawski```

cc ```@workingjubilee``` ```@thomcc```

3 years agoRollup merge of #82689 - camelid:rustdoc-nominated, r=Manishearth
Yuki Okushi [Wed, 3 Mar 2021 07:27:42 +0000 (16:27 +0900)]
Rollup merge of #82689 - camelid:rustdoc-nominated, r=Manishearth

meta: Notify Zulip for rustdoc nominated issues

The rustdoc team does not currently use the `I-nominated` label, unlike
the libs and compiler teams (and maybe others). One reason for this is
that the other teams discuss their nominated issues in meetings, while
rustdoc is an async-only team.

However, it might be helpful to start using the `I-nominated` label for
rustdoc. The team currently uses a `cc ``@rust-lang/rustdoc``` ping as the
equivalent, but it's easier to track issues when they use `I-nominated`.
Also we'd be more consistent with the other teams' procedures.

Since rustdoc doesn't have meetings, I propose we instead use the
triagebot notify Zulip functionality to create a topic in `#rustdoc` on
Zulip and ping the team. So it would look a bit like the procedure for
WG-prioritization when an issue acquires the `I-prioritize` label.

cc ``@rust-lang/rustdoc`` for approval of the change
r? ``@Mark-Simulacrum`` to make sure I configured triagebot correctly

3 years agoRollup merge of #82589 - LinkTed:master, r=joshtriplett
Yuki Okushi [Wed, 3 Mar 2021 07:27:41 +0000 (16:27 +0900)]
Rollup merge of #82589 - LinkTed:master, r=joshtriplett

unix: Non-mutable bufs in send_vectored_with_ancillary_to

This is the same PR as [#79753](https://github.com/rust-lang/rust/pull/79753). It was closed because of inactivity. Therefore, I create a new one. ````@lukaslihotzki````

3 years agoRollup merge of #82469 - notriddle:bring-our-own-diff, r=Mark-Simulacrum
Yuki Okushi [Wed, 3 Mar 2021 07:27:40 +0000 (16:27 +0900)]
Rollup merge of #82469 - notriddle:bring-our-own-diff, r=Mark-Simulacrum

Use a crate to produce rustdoc tree comparisons instead of the `diff` command

It doesn't come with Windows, so bring [our own](https://github.com/notriddle/rust-unified-diff/).

Fixes #82409

![image](https://user-images.githubusercontent.com/1593513/109230755-9a1d5700-7782-11eb-8359-353a506875ab.png)

3 years agoRollup merge of #82439 - ssomers:btree_fix_unsafety, r=Mark-Simulacrum
Yuki Okushi [Wed, 3 Mar 2021 07:27:39 +0000 (16:27 +0900)]
Rollup merge of #82439 - ssomers:btree_fix_unsafety, r=Mark-Simulacrum

BTree: fix untrue safety

Fix needless and missing `unsafe` tags.

r? ````@Mark-Simulacrum````

3 years agoRollup merge of #81223 - GuillaumeGomez:generate-redirect-map, r=jyn514
Yuki Okushi [Wed, 3 Mar 2021 07:27:38 +0000 (16:27 +0900)]
Rollup merge of #81223 - GuillaumeGomez:generate-redirect-map, r=jyn514

[rustdoc] Generate redirect map file

Fixes #81134.

So with this code:

```rust
#![crate_name = "foo"]

pub use private::Quz;
pub use hidden::Bar;

mod private {
    pub struct Quz;
}

#[doc(hidden)]
pub mod hidden {
    pub struct Bar;
}

#[macro_export]
macro_rules! foo {
() => {}
}
```

It generates:

```json
{
  "foo/macro.foo!.html": "foo/macro.foo.html",
  "foo/private/struct.Quz.html": "foo/struct.Quz.html",
  "foo/hidden/struct.Bar.html": "foo/struct.Bar.html"
}
```

Do the pathes look as you expected ````@pietroalbini?````

r? ````@jyn514````

3 years agoAuto merge of #76345 - okready:sgx-mem-range-overflow-checks, r=joshtriplett
bors [Wed, 3 Mar 2021 05:45:50 +0000 (05:45 +0000)]
Auto merge of #76345 - okready:sgx-mem-range-overflow-checks, r=joshtriplett

Add is_enclave_range/is_user_range overflow checks

Fixes #76343.

This adds overflow checking to `is_enclave_range` and `is_user_range` in `sgx::os::fortanix_sgx::mem` in order to mitigate possible security issues with enclave code. It also accounts for an edge case where the memory range provided ends exactly at the end of the address space, where calculating `p + len` would overflow back to zero despite the range potentially being valid.

3 years agoUse Arial as fallback font instead of sans-serif.
Jacob Hoffman-Andrews [Wed, 3 Mar 2021 02:27:34 +0000 (18:27 -0800)]
Use Arial as fallback font instead of sans-serif.

On most platforms and browsers, `sans-serif` is equivalent to Arial.
However, on Firefox on Ubuntu (and possibly other Linuxes), `sans-serif`
is DejaVu Sans, a much wider font. This creates a larger shift in text
when the custom fonts finally load. Arial is a web-safe font, and
specifying it explicitly gives us more cross-platform consistency, as
well as reducing the layout shift that happens when fonts load.

3 years agoAccount for macros when suggesting adding lifetime
Esteban Küber [Wed, 3 Mar 2021 02:24:13 +0000 (18:24 -0800)]
Account for macros when suggesting adding lifetime

Fix #70152.

3 years agoImprove page load performance in rustdoc.
Jacob Hoffman-Andrews [Sat, 20 Feb 2021 01:54:41 +0000 (17:54 -0800)]
Improve page load performance in rustdoc.

Add font-display: swap. Per https://web.dev/font-display/, this prevents
"flash of invisible text" during load by using a system font until the
custom font is available. I've noticed this flash of invisible text
occasionally when reading Rust docs.

Add an explicit height to icons (which already had an explicit width)
to allow browsers to lay out the page more accurately before the icons
have been loaded. https://web.dev/optimize-cls/.

Add min-width: 115px to the crate search dropdown. When the HTML first
loads, this dropdown includes only the text "All crates." Later, JS
loads the items underneath it, some of which are wider. That causes
the dropdown to get wider, causing a distracting reflow. This sets a
min-width based on the size that the dropdown eventually becomes based
on the crates on doc.rust-lang.org, reducing page movement during load.

3 years agoUpdate cargo
Eric Huss [Wed, 3 Mar 2021 00:24:14 +0000 (16:24 -0800)]
Update cargo

3 years agoRemove unnecessary conditional `cfg(target_os)` for `redox` and `vxworks`
Christiaan Dirkx [Wed, 3 Mar 2021 00:14:17 +0000 (01:14 +0100)]
Remove unnecessary conditional `cfg(target_os)` for `redox` and `vxworks`

`redox` and `vxworks` are part of target_family `unix`, thus `cfg(unix)` already implies `cfg(target_os="redox")` and `(target_os="vxworks")`

3 years agoMake Vec::split_at_spare_mut impl safer & simplier
Waffle [Tue, 2 Mar 2021 22:04:20 +0000 (01:04 +0300)]
Make Vec::split_at_spare_mut impl safer & simplier

3 years agoAdd test that Vec::spare_capacity_mut doesn't invalidate pointers
Waffle [Tue, 2 Mar 2021 22:00:59 +0000 (01:00 +0300)]
Add test that Vec::spare_capacity_mut doesn't invalidate pointers

3 years agoLoad rustdoc's JS search index on-demand.
Jacob Hoffman-Andrews [Sat, 20 Feb 2021 01:22:30 +0000 (17:22 -0800)]
Load rustdoc's JS search index on-demand.

Instead of being loaded on every page, the JS search index is now
loaded when either (a) there is a `?search=` param, or (b) the search
input is focused.

This saves both CPU and bandwidth. As of Feb 2021,
https://doc.rust-lang.org/search-index1.50.0.js is 273,838 bytes
gzipped or 2,544,939 bytes uncompressed. Evaluating it takes 445 ms
of CPU time in Chrome 88 on a i7-10710U CPU (out of a total ~2,100
ms page reload).

Generate separate JS file with crate names.

This is much smaller than the full search index, and is used in the "hot
path" to draw the page. In particular it's used to crate the dropdown
for the search bar, and to append a list of crates to the sidebar (on
some pages).

Skip early search that can bypass 500ms timeout.

This was occurring when someone had typed some text during the load of
search-index.js. Their query was usually not ready to execute, and the
search itself is fairly expensive, delaying the overall load, which
delayed the input / keyup events, which delayed eventually executing the
query.

3 years agoAuto merge of #82562 - llogiq:one-up-82248, r=oli-obk
bors [Tue, 2 Mar 2021 21:01:47 +0000 (21:01 +0000)]
Auto merge of #82562 - llogiq:one-up-82248, r=oli-obk

Optimize counting digits in line numbers during error reporting further

This one-ups #82248 by switching the strategy: Instead of dividing the value by 10 repeatedly, we compare with a limit that we multiply by 10 repeatedly. In my benchmarks, this took between 50% and 25% of the original time. The reasons for being faster are:

1. While LLVM is able to replace a division by constant with a multiply + shift, a plain multiplication is still faster. However, this doesn't even factor, because
2. Multiplication, unlike division, is const. We also use a simple for-loop instead of a more complex loop + break, which allows
3. rustc to const-fold the whole loop, and indeed the assembly output simply shows a series of comparisons.

3 years agoFloatToInit: Replacing round_unchecked_to --> to_int_unchecked
Peter Kehl [Tue, 2 Mar 2021 20:38:22 +0000 (12:38 -0800)]
FloatToInit: Replacing round_unchecked_to --> to_int_unchecked

FloatToInit docs: Replacing round_unchecked_to with
to_int_unchecked. Bug #82709.

3 years agouse outer_expn_data() instead of outer_expn().expn_data()
klensy [Tue, 2 Mar 2021 19:01:29 +0000 (22:01 +0300)]
use outer_expn_data() instead of outer_expn().expn_data()

3 years agoupdate Miri
Ralf Jung [Tue, 2 Mar 2021 19:01:25 +0000 (20:01 +0100)]
update Miri

3 years agoenable atomic_min/max tests in Miri
Ralf Jung [Tue, 2 Mar 2021 18:58:55 +0000 (19:58 +0100)]
enable atomic_min/max tests in Miri

3 years agoAuto merge of #82043 - tmiasko:may-have-side-effect, r=kennytm
bors [Tue, 2 Mar 2021 16:08:32 +0000 (16:08 +0000)]
Auto merge of #82043 - tmiasko:may-have-side-effect, r=kennytm

Turn may_have_side_effect into an associated constant

The `may_have_side_effect` is an implementation detail of `TrustedRandomAccess`
trait. It describes if obtaining an iterator element may have side effects. It
is currently implemented as an associated function.

Turn `may_have_side_effect` into an associated constant. This makes the
value immediately available to the optimizer.

3 years agoAuto merge of #82698 - JohnTitor:rollup-htd533c, r=JohnTitor
bors [Tue, 2 Mar 2021 12:57:06 +0000 (12:57 +0000)]
Auto merge of #82698 - JohnTitor:rollup-htd533c, r=JohnTitor

Rollup of 10 pull requests

Successful merges:

 - #80189 (Convert primitives in the standard library to intra-doc links)
 - #80874 (Update intra-doc link documentation to match the implementation)
 - #82376 (Add option to enable MIR inlining independently of mir-opt-level)
 - #82516 (Add incomplete feature gate for inherent associate types.)
 - #82579 (Fix turbofish recovery with multiple generic args)
 - #82593 (Teach rustdoc how to display WASI.)
 - #82597 (Get TyCtxt from self instead of passing as argument in AutoTraitFinder)
 - #82627 (Erase late bound regions to avoid ICE)
 - #82661 (:arrow_up: rust-analyzer)
 - #82691 (Update books)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

3 years agoRollup merge of #82691 - ehuss:update-books, r=ehuss
Yuki Okushi [Tue, 2 Mar 2021 12:23:22 +0000 (21:23 +0900)]
Rollup merge of #82691 - ehuss:update-books, r=ehuss

Update books

## reference

2 commits in 361367c126290ac17cb4089f8d38fd8b2ac43f98..3b6fe80c205d2a2b5dc8a276192bbce9eeb9e9cf
2021-02-15 09:58:13 -0800 to 2021-02-22 22:09:17 -0800
- Add an extra fn() entry to the variance table in the subtyping chapter (rust-lang-nursery/reference#874)
- Turbofish: Explain what the example is of. (rust-lang-nursery/reference#966)

## book

28 commits in db5e8a5105aa22979490dce30e33b68d8645761d..0f87daf683ae3de3cb725faecb11b7e7e89f0e5a
2021-02-12 16:58:20 -0500 to 2021-03-01 08:54:04 -0500
- Ohhh the should_panic was for mdbook test. Oops
- Fix bad regex in the update rustc script and regenerate broken output
- Clarify that we only mentioned unwrap_or_else, but haven't explained it
- Add ferris to some listings that don't compile. Fixes rust-lang/book#2598
- Remove fancy quote from a code comment
- Panic now points at our code, not stdlib slice code
- Disable playground on thread::sleep examples
- Disable playground button on listings in ch 12 that use CLI args
- Reword ambiguous sentence. Fixes rust-lang/book#2317.
- Rename shoes_in_my_size to shoes_in_size to be a better example
- Fix visible "ANCHOR: here" in listing 13-21 (rust-lang/book#2628)
- minor clarification about deriving Copy and Clone (rust-lang/book#2627)
- Clarify relationship of trait to mock object
- Fix "message" that should be "method"
- Fix rust-lang/book#2625 (rust-lang/book#2626)
- fix misleading hash claim (rust-lang/book#2621)
- Make link syntax consistent and word wrap
- Added hyperlinks to Appendices
- Use console syntax highlighting in some more places
- Merge remote-tracking branch 'origin/pr/2615'
- Fix broken blockquote
- Update one more bit of output caught by the update rust script
- Update and clarify some text affected by the rand update
- Update lock files and output
- Update error output for changes to chapter 10 listings
- Merge remote-tracking branch 'origin/pr/2542'
- Tweak wording in for loop explanation
- Merge remote-tracking branch 'origin/pr/2460'

## rust-by-example

1 commits in 551cc4bc8394feccea6acd21f86d9a4e1d2271a0..3e0d98790c9126517fa1c604dc3678f396e92a27
2021-02-03 17:12:37 -0300 to 2021-02-25 08:23:10 -0300
- Make flow_control/for/.into_iter() example run (rust-lang/rust-by-example#1415)

## rustc-dev-guide

530 commits in 7adfab42bab045a848126895c2f1e09927c1331a..c431f8c29a41413dddcb3bfa0d71c9cabe366317
2020-04-08 08:52:05 +0200 to 2021-02-28 16:35:20 -0500

... Many updates.

## embedded-book

1 commits in 4cf7981696a85c3e633076c6401611bd3f6346c4..a96d096cffe5fa2c84af1b4b61e1492f839bb2e1
2021-02-11 10:55:22 +0000 to 2021-02-17 08:08:52 +0000
- Add note about using more recent openocd interface file. Closes rust-embedded/book#277 and rust-embedded/book#263  (rust-embedded/book#284)

3 years agoRollup merge of #82661 - lnicola:rust-analyzer-2021-03-01, r=jonas-schievink
Yuki Okushi [Tue, 2 Mar 2021 12:23:21 +0000 (21:23 +0900)]
Rollup merge of #82661 - lnicola:rust-analyzer-2021-03-01, r=jonas-schievink

:arrow_up: rust-analyzer

3 years agoRollup merge of #82627 - JohnTitor:issue-82612, r=estebank
Yuki Okushi [Tue, 2 Mar 2021 12:23:20 +0000 (21:23 +0900)]
Rollup merge of #82627 - JohnTitor:issue-82612, r=estebank

Erase late bound regions to avoid ICE

Fixes #82612, which is caused by #81769.

r? `@estebank`

3 years agoRollup merge of #82597 - noslaver:fix-82137, r=nagisa
Yuki Okushi [Tue, 2 Mar 2021 12:23:19 +0000 (21:23 +0900)]
Rollup merge of #82597 - noslaver:fix-82137, r=nagisa

Get TyCtxt from self instead of passing as argument in AutoTraitFinder

First contribution :crab:, let me know if anything is amiss.

Fix #82137.

3 years agoRollup merge of #82593 - sunfishcode:wasi-docs, r=alexcrichton
Yuki Okushi [Tue, 2 Mar 2021 12:23:18 +0000 (21:23 +0900)]
Rollup merge of #82593 - sunfishcode:wasi-docs, r=alexcrichton

Teach rustdoc how to display WASI.

As a followup to [this comment] in #82420, this patch teaches rustdoc
how to display WASI.

[this comment]: https://github.com/rust-lang/rust/pull/82420#issuecomment-784523826

r? `@alexcrichton`

3 years agoRollup merge of #82579 - osa1:issue82566, r=estebank
Yuki Okushi [Tue, 2 Mar 2021 12:23:17 +0000 (21:23 +0900)]
Rollup merge of #82579 - osa1:issue82566, r=estebank

Fix turbofish recovery with multiple generic args

This consists of two commits, each can be individually reviewed.

- First commit fixes the issue in [this comment](https://github.com/rust-lang/rust/issues/82566#issuecomment-786924466).
- Second commit fixes #82566

---

r? ````@estebank````

3 years agoRollup merge of #82516 - PoignardAzur:inherent-impl-ty, r=oli-obk
Yuki Okushi [Tue, 2 Mar 2021 12:23:15 +0000 (21:23 +0900)]
Rollup merge of #82516 - PoignardAzur:inherent-impl-ty, r=oli-obk

Add incomplete feature gate for inherent associate types.

Mentored by ``````@oli-obk``````

So far the only change is that instead of giving an automatic error, the following code compiles:

```rust
struct Foo;

impl Foo {
    type Bar = isize;
}
```

The backend work to make it actually usable isn't there yet. In particular, this:

```rust
let x : Foo::Bar;
```

will give you:

```sh
error[E0223]: ambiguous associated type
  --> /$RUSTC_DIR/src/test/ui/assoc-inherent.rs:15:13
   |
LL |     let x : Foo::Bar;
   |             ^^^^^^^^ help: use fully-qualified syntax: `<Foo as Trait>::Bar`
```

3 years agoRollup merge of #82376 - tmiasko:inline-options, r=oli-obk
Yuki Okushi [Tue, 2 Mar 2021 12:23:14 +0000 (21:23 +0900)]
Rollup merge of #82376 - tmiasko:inline-options, r=oli-obk

Add option to enable MIR inlining independently of mir-opt-level

Add `-Zinline-mir` option that enables MIR inlining independently of the
current MIR opt level. The primary use-case is enabling MIR inlining on the
default MIR opt level.

Turn inlining thresholds into optional values to make it possible to configure
different defaults depending on the current mir-opt-level (although thresholds
are yet to be used in such a manner).

3 years agoRollup merge of #80874 - jyn514:intra-doc-docs, r=Manishearth
Yuki Okushi [Tue, 2 Mar 2021 12:23:13 +0000 (21:23 +0900)]
Rollup merge of #80874 - jyn514:intra-doc-docs, r=Manishearth

Update intra-doc link documentation to match the implementation

r? `@Manishearth`
cc `@camelid` `@m-ou-se`

Relevant PRs:
- https://github.com/rust-lang/rust/pull/74489
- https://github.com/rust-lang/rust/pull/80181
- https://github.com/rust-lang/rust/pull/76078
- https://github.com/rust-lang/rust/pull/77519
- https://github.com/rust-lang/rust/pull/73101

Relevant issues:
- https://github.com/rust-lang/rust/issues/78800
- https://github.com/rust-lang/rust/issues/77200
- https://github.com/rust-lang/rust/issues/77199 / https://github.com/rust-lang/rust/issues/54191/

I haven't documented things that I consider 'just bugs', like https://github.com/rust-lang/rust/issues/77732, but I have documented features that aren't implemented, like https://github.com/rust-lang/rust/issues/78800.