]>
git.lizzy.rs Git - rust.git/log
Philipp Hansch [Wed, 10 Apr 2019 05:50:34 +0000 (07:50 +0200)]
Code formatting/cleanup
Philipp Hansch [Tue, 9 Apr 2019 18:53:38 +0000 (20:53 +0200)]
Exclude ice-3891.rs from rustfmt run
Because the code triggers a rustc parse error which makes rustfmt fail.
Philipp Hansch [Mon, 8 Apr 2019 20:06:02 +0000 (22:06 +0200)]
Fix ICE in decimal_literal_representation lint
Handling the integer parsing properly instead of just unwrapping.
Note that the test is not catching the ICE because plain UI tests
[currently hide ICEs][compiletest_issue]. Once that issue is fixed, this
test would fail properly again.
[compiletest_issue]: https://github.com/laumann/compiletest-rs/issues/169
bors [Mon, 8 Apr 2019 14:01:20 +0000 (14:01 +0000)]
Auto merge of #3929 - KarboniteKream:single-char-pattern, r=oli-obk
Escape a single quote in single_char_pattern hint
This PR correctly escapes single quotes in the hint for `single_char_pattern`.
For instance, the hint for `x.split("'")` was `'''`, while it should be `'\''`.
Klemen Košir [Mon, 8 Apr 2019 12:55:50 +0000 (21:55 +0900)]
Escape a single quote in single_char_pattern hint
bors [Mon, 8 Apr 2019 08:42:13 +0000 (08:42 +0000)]
Auto merge of #3921 - euclio:single-char-names-multispan, r=flip1995
use a multispan for MANY_SINGLE_CHAR_NAMES
bors [Mon, 8 Apr 2019 07:20:25 +0000 (07:20 +0000)]
Auto merge of #3848 - felix91gr:null_transmute, r=flip1995
Transmuting known null ptr to ref
Working on implementing #628
bors [Mon, 8 Apr 2019 06:28:15 +0000 (06:28 +0000)]
Auto merge of #3901 - rail-rain:issue_1670, r=flip1995
Fix `explicit_counter_loop` suggestion
#1670
This code seems to me to work, but I have two question.
* Because range expression desugared in hir, `Sugg::hir` doesn't add parenthesis to range expression. Which function is better to check range do you think, `check_for_loop_explicit_counter` or `hir_from_snippet`?
* Do you think we need to distinguish between range expression and struct expression that creates `std::ops::Range*`?
bors [Mon, 8 Apr 2019 05:58:34 +0000 (05:58 +0000)]
Auto merge of #3885 - mikerite:clippy_dev_toolchain, r=phansch
Add rust-toolchain for clippy_dev
AFAIK, `clippy_dev` is supposed to be built on stable. (This is why it's not a `[bin]` inside the root `Cargo.toml`.) This adds a `rust-toolchain` file for easy switching.
bors [Sun, 7 Apr 2019 21:36:51 +0000 (21:36 +0000)]
Auto merge of #3928 - rust-lang:tmpadd, r=Manishearth
Re-add tmp feature to compiletest
Got accidentally removed in the rustup
Manish Goregaokar [Sun, 7 Apr 2019 21:35:57 +0000 (14:35 -0700)]
Re-add tmp feature to compiletest
Got accidentally removed in the rustup
bors [Sun, 7 Apr 2019 20:41:39 +0000 (20:41 +0000)]
Auto merge of #3927 - rust-lang:rustup, r=Manishearth
Revert compiletest hacks, use latest compiletest
The libtest changes have been reverted, see https://github.com/rust-lang/rust/pull/59766, https://github.com/laumann/compiletest-rs/pull/174
Manish Goregaokar [Sun, 7 Apr 2019 19:39:43 +0000 (12:39 -0700)]
Remove libtest from deps
Manish Goregaokar [Sun, 7 Apr 2019 19:07:20 +0000 (12:07 -0700)]
Re-allow clippy::identity_conversion in compiletest
Manish Goregaokar [Sun, 7 Apr 2019 19:02:22 +0000 (12:02 -0700)]
Use latest compiletest-rs
Manish Goregaokar [Sun, 7 Apr 2019 19:01:39 +0000 (12:01 -0700)]
Matthias Krüger [Sun, 7 Apr 2019 08:29:51 +0000 (10:29 +0200)]
Merge pull request #3918 from matthiaskrgr/typos
NFC: fix typos
Oliver Scherer [Sat, 6 Apr 2019 16:33:52 +0000 (18:33 +0200)]
Merge pull request #3922 from rust-lang/run-pass
Add missing `// run-pass` annotations to ICE tests
Andy Russell [Wed, 3 Apr 2019 19:06:39 +0000 (15:06 -0400)]
use a multispan for MANY_SINGLE_CHAR_NAMES
Philipp Hansch [Fri, 5 Apr 2019 05:22:36 +0000 (07:22 +0200)]
Add missing `// run-pass` annotations to ICE tests
compiletest UI tests do not fail when encountering panics and ICEs
unless the `// run-pass` flag is used.
(This was forgotten in https://github.com/rust-lang/rust-clippy/pull/3743)
Michael Wright [Fri, 5 Apr 2019 04:00:27 +0000 (06:00 +0200)]
Remove clippy_dev as dev-dependency
Michael Wright [Fri, 5 Apr 2019 03:59:46 +0000 (05:59 +0200)]
Merge branch 'master' into clippy_dev_toolchain
Matthias Krüger [Thu, 4 Apr 2019 09:15:30 +0000 (11:15 +0200)]
NFC: fix typos
Philipp Krones [Wed, 3 Apr 2019 09:43:26 +0000 (11:43 +0200)]
Merge pull request #3916 from matthiaskrgr/rustup
rustup https://github.com/rust-lang/rust/pull/59657
Matthias Krüger [Wed, 3 Apr 2019 08:48:54 +0000 (10:48 +0200)]
rustup https://github.com/rust-lang/rust/pull/59657
commit:
4122d2221ec65232bc211a266d0796a4713e0d39
Félix Fischer [Tue, 26 Mar 2019 14:12:14 +0000 (11:12 -0300)]
Add TransmutingNull Lint
* Late Lint pass, catches:
* One liner: 0 -> null -> transmute
* One liner: std:null() -> transmute
* Const (which resolves to null) -> transmute
* UI Test case for Lint
* Updated test for issue 3849, because now the lint that code generated is in Clippy.
* Expanded `const.rs` miri-based Constant Folding code, to cover
raw pointers
Philipp Krones [Mon, 1 Apr 2019 20:15:42 +0000 (22:15 +0200)]
Merge pull request #3905 from rust-lang/compiletest
Hacky rustup
flip1995 [Mon, 1 Apr 2019 08:28:07 +0000 (10:28 +0200)]
Run rustfmt
flip1995 [Mon, 1 Apr 2019 07:49:39 +0000 (09:49 +0200)]
Set level of identity_conversion FP to warn
Philipp Hansch [Mon, 1 Apr 2019 05:19:05 +0000 (07:19 +0200)]
Rustup to https://github.com/rust-lang/rust/pull/58805
Matthias Krüger [Sat, 30 Mar 2019 14:58:14 +0000 (15:58 +0100)]
Félix Fischer [Fri, 29 Mar 2019 04:47:09 +0000 (01:47 -0300)]
Updated source to match with recent rustc `master` toolchain changes
flip1995 [Wed, 27 Mar 2019 12:22:40 +0000 (13:22 +0100)]
Fix dogfood error of question_mark lint fix
flip1995 [Wed, 27 Mar 2019 10:46:33 +0000 (11:46 +0100)]
Fix question_mark lint+test
rail [Wed, 27 Mar 2019 23:51:57 +0000 (08:51 +0900)]
use `span_lint_and_sugg` in `explicit_counter_loop`
Félix Fischer [Tue, 26 Mar 2019 16:57:03 +0000 (13:57 -0300)]
Fix some test failures
Oliver Scherer [Tue, 26 Mar 2019 09:55:03 +0000 (10:55 +0100)]
Hacky rustup
Manish Goregaokar [Sat, 23 Mar 2019 23:53:01 +0000 (16:53 -0700)]
Merge pull request #3902 from matthiaskrgr/rustup
rustup https://github.com/rust-lang/rust/pull/59096/
Matthias Krüger [Sat, 23 Mar 2019 22:39:58 +0000 (23:39 +0100)]
run cargo fmt
Matthias Krüger [Sat, 23 Mar 2019 22:37:38 +0000 (23:37 +0100)]
rustup https://github.com/rust-lang/rust/pull/59096/
rail [Sat, 23 Mar 2019 06:36:48 +0000 (15:36 +0900)]
Change explicit_counter_loop's message to add parentheses if necessary
rail [Sat, 23 Mar 2019 06:30:17 +0000 (15:30 +0900)]
Change explicit_counter_loop's message to reflect original variable name
bors [Tue, 19 Mar 2019 06:26:01 +0000 (06:26 +0000)]
Auto merge of #3888 - phansch:extract_mistyped_literal_suffix_tests_and_rustfix, r=flip1995
Add rustfix tests for mistyped_literal_suffix lint
This moves all `mistyped_literal_suffix` tests to their own file and
enables rustfix tests for them.
cc #3603, #2038
Based on #3887
bors [Tue, 19 Mar 2019 06:05:41 +0000 (06:05 +0000)]
Auto merge of #3894 - markcatley:adding_lint_documentation_fixes, r=phansch
Add implementation for the EarlyLintPass trait into the Adding Lints …
…documentation.
To follow along with the adding lint documentation you need to implement this trait in order to register the lint pass.
Philipp Hansch [Fri, 15 Mar 2019 19:14:33 +0000 (20:14 +0100)]
cargo fmt
Philipp Hansch [Fri, 15 Mar 2019 07:06:01 +0000 (08:06 +0100)]
Add rustfix tests for mistyped_literal_suffix lint
This moves all `mistyped_literal_suffix` tests to their own file and
enables rustfix tests for them.
cc #3603, #2038
Based on #3887
Philipp Hansch [Fri, 15 Mar 2019 06:50:31 +0000 (07:50 +0100)]
Move some `unreadable_literal` ui tests to correct file
The moved tests were part of `tests/ui/literals.rs` before. Now they are
placed in `tests/ui/unreadable_literal.rs`, which now also runs
`rustfix` on these 4 extra let statements.
Mark Catley [Tue, 19 Mar 2019 00:39:19 +0000 (13:39 +1300)]
Add implementation for the EarlyLintPass trait into the Adding Lints documentation.
To follow along with the adding lint documentation you need to implement this trait in order to register the lint pass.
bors [Mon, 18 Mar 2019 16:21:56 +0000 (16:21 +0000)]
Auto merge of #3893 - mati865:rustup, r=oli-obk
Rustup
Supersedes https://github.com/rust-lang/rust-clippy/pull/3889
Addresses some review comments from previous PR and rustups to https://github.com/rust-lang/rust/pull/58899
Mateusz Mikuła [Mon, 18 Mar 2019 11:31:49 +0000 (12:31 +0100)]
Cargo fmt
Mateusz Mikuła [Mon, 18 Mar 2019 11:30:22 +0000 (12:30 +0100)]
Drop range_contains feature
Mateusz Mikuła [Mon, 18 Mar 2019 11:29:56 +0000 (12:29 +0100)]
Fix rustfmt::skip detection
Mateusz Mikuła [Mon, 18 Mar 2019 11:29:09 +0000 (12:29 +0100)]
Rework clippy detection in attribute lint
Mateusz Mikuła [Mon, 18 Mar 2019 11:15:23 +0000 (12:15 +0100)]
name -> check_name
Mateusz Mikuła [Mon, 18 Mar 2019 11:05:20 +0000 (12:05 +0100)]
span -> span()
Mateusz Mikuła [Mon, 18 Mar 2019 11:04:06 +0000 (12:04 +0100)]
name -> ident_str
Mateusz Mikuła [Mon, 18 Mar 2019 10:59:09 +0000 (11:59 +0100)]
NestedMetaItemKind -> NestedMetaItem
Mateusz Mikuła [Mon, 18 Mar 2019 11:52:24 +0000 (12:52 +0100)]
Drop redundant &
Mateusz Mikuła [Mon, 18 Mar 2019 11:49:12 +0000 (12:49 +0100)]
Fix path_qualified
As suggested by eddyb
Mateusz Mikuła [Mon, 18 Mar 2019 11:43:10 +0000 (12:43 +0100)]
Replace most of ty:Ty with Ty
flip1995 [Sat, 16 Mar 2019 14:39:02 +0000 (15:39 +0100)]
Feed dog
flip1995 [Sat, 16 Mar 2019 14:22:31 +0000 (15:22 +0100)]
Adapt paths to new formatting
flip1995 [Sat, 16 Mar 2019 10:51:57 +0000 (11:51 +0100)]
cargo fmt
flip1995 [Sat, 16 Mar 2019 10:45:29 +0000 (11:45 +0100)]
Use LocalInternedString inside of AbsolutePathPrinter
flip1995 [Sat, 16 Mar 2019 10:17:36 +0000 (11:17 +0100)]
AbsolutePathBuffer -> AbsolutePathPrinter
flip1995 [Fri, 15 Mar 2019 22:44:42 +0000 (23:44 +0100)]
Remove ty::TyKind from eta_reduction and replace it with ty::Ty
flip1995 [Fri, 15 Mar 2019 22:44:04 +0000 (23:44 +0100)]
parent_def_id -> parent
flip1995 [Fri, 15 Mar 2019 22:43:42 +0000 (23:43 +0100)]
item_path_str -> def_path_str
flip1995 [Fri, 15 Mar 2019 22:41:30 +0000 (23:41 +0100)]
Reimplement AbsolutePathBuffer
bors [Fri, 15 Mar 2019 09:43:29 +0000 (09:43 +0000)]
Auto merge of #3886 - phansch:rustfix_useless_asref, r=flip1995
Enable rustfix for `useless_asref` lint tests
cc #3630
Philipp Hansch [Fri, 15 Mar 2019 06:29:12 +0000 (07:29 +0100)]
Enable rustfix for `useless_asref` lint tests
bors [Fri, 15 Mar 2019 06:18:28 +0000 (06:18 +0000)]
Auto merge of #3883 - daxpedda:missing_docs_in_private_items, r=phansch
Add `doc(include = ...)` detection to `missing_docs_in_private_items`
The whole `missing documentation in crate` part doesn't have any tests. If I should add test cases tell me.
Michael Wright [Fri, 15 Mar 2019 06:17:44 +0000 (08:17 +0200)]
Add rust-toolchain for clippy_dev
daxpedda [Thu, 14 Mar 2019 18:38:41 +0000 (19:38 +0100)]
Another test for missing crate documentation.
daxpedda [Thu, 14 Mar 2019 18:33:06 +0000 (19:33 +0100)]
Add a test for `doc(include)`
Tiny code improvement.
daxpedda [Thu, 14 Mar 2019 17:32:39 +0000 (18:32 +0100)]
Add `doc(include = ...)` detection to `missing_docs_in_private_items`
bors [Thu, 14 Mar 2019 17:29:19 +0000 (17:29 +0000)]
Auto merge of #3879 - phansch:rustfix_string_lit_as_bytes, r=flip1995
Run rustfix for string_lit_as_bytes tests
This moves the `string_lit_as_bytes` tests into a new file and enables
rustfix tests for them.
cc #3603, #2038
bors [Thu, 14 Mar 2019 16:32:15 +0000 (16:32 +0000)]
Auto merge of #3877 - rink1969:3842, r=flip1995
casting integer literal to float is unnecessary
fix issue https://github.com/rust-lang/rust-clippy/issues/3842
rink1969 [Tue, 12 Mar 2019 07:49:26 +0000 (15:49 +0800)]
casting integer literal to float is unnecessary
bors [Thu, 14 Mar 2019 07:52:00 +0000 (07:52 +0000)]
Auto merge of #3880 - phansch:uicleanup9001, r=oli-obk
UI test cleanup: Extract manual_memcpy tests
cc #2038
Philipp Hansch [Thu, 14 Mar 2019 06:26:47 +0000 (07:26 +0100)]
UI test cleanup: Extract manual_memcpy tests
Philipp Hansch [Thu, 14 Mar 2019 05:59:30 +0000 (06:59 +0100)]
Run rustfix for string_lit_as_bytes tests
This moves the `string_lit_as_bytes` tests into a new file and enables
rustfix tests for them.
bors [Wed, 13 Mar 2019 08:45:23 +0000 (08:45 +0000)]
Auto merge of #3873 - phansch:hiridification, r=flip1995
Some more HirId-ification
*
8a59f81 : Rename span_lint_node* functions to span_lint_hir*
*
a457258 : Use `HirId` instead of `NodeId` for lookup
Philipp Hansch [Wed, 13 Mar 2019 05:51:57 +0000 (06:51 +0100)]
cargo fmt
bors [Tue, 12 Mar 2019 12:09:56 +0000 (12:09 +0000)]
Auto merge of #3869 - taiki-e:use_self, r=flip1995
Fix `use_self` false positive on nested functions
Related to https://github.com/rust-lang/rust-clippy/pull/3640
The current `use_self` warns the following code.
```rust
#![warn(clippy::use_self)]
struct Foo {}
impl Foo {
fn bar() {
fn baz() -> Foo { //^ warning: unnecessary structure name repetition
Foo {} //^ warning: unnecessary structure name repetition
}
}
}
```
bors [Tue, 12 Mar 2019 09:34:04 +0000 (09:34 +0000)]
Auto merge of #3872 - phansch:some_feature_cleanup, r=oli-obk
Remove some unused features and `error-pattern`s
None
bors [Tue, 12 Mar 2019 07:43:14 +0000 (07:43 +0000)]
Auto merge of #3794 - mikerite:fix-3739, r=phansch
Fix `boxed_local` suggestion
Don't warn about an argument that is moved into a closure.
ExprUseVisitor doesn't walk into nested bodies so use a new
visitor that collects the variables that are moved into closures.
Fixes #3739
Philipp Hansch [Tue, 12 Mar 2019 07:11:57 +0000 (08:11 +0100)]
Use `HirId` instead of `NodeId` for lookup
Philipp Hansch [Tue, 12 Mar 2019 06:32:02 +0000 (07:32 +0100)]
Remove some unused features and `error-pattern`s
bors [Tue, 12 Mar 2019 07:04:44 +0000 (07:04 +0000)]
Auto merge of #3871 - taiki-e:needless_continue, r=phansch
Fix `needless_continue` false positive
If the `continue` has a label, check it matches the label of the loop.
Fixes https://github.com/rust-lang/rust-clippy/issues/2329
Philipp Hansch [Tue, 12 Mar 2019 07:01:21 +0000 (08:01 +0100)]
Rename span_lint_node* functions to span_lint_hir*
Because they now take a `hir_id` instead of a `node_id` argument.
bors [Tue, 12 Mar 2019 06:22:00 +0000 (06:22 +0000)]
Auto merge of #3865 - phansch:run_more_doc_tests, r=flip1995
Run more doc tests
This executes some more doc tests that were ignored before.
Michael Wright [Tue, 12 Mar 2019 06:13:44 +0000 (08:13 +0200)]
Merge branch 'master' into fix-3739
bors [Tue, 12 Mar 2019 06:01:00 +0000 (06:01 +0000)]
Auto merge of #3868 - taiki-e:needless_pass_by_value, r=phansch
Filter out proc_macro and proc_macro_attribute
Related to https://github.com/rust-lang/rust-clippy/pull/1617
Fixes https://github.com/rust-lang/rust-clippy/issues/3067 (this issue has already been closed, but in fact the false positive in `#[proc_macro]` and `#[proc_macro_attribute]` has not been fixed yet)
Philipp Hansch [Sat, 9 Mar 2019 07:51:23 +0000 (08:51 +0100)]
Run more doc tests
This executes some more doc tests that were ignored before.
Taiki Endo [Mon, 11 Mar 2019 18:40:30 +0000 (03:40 +0900)]
Fix `needless_continue` false positive
Taiki Endo [Mon, 11 Mar 2019 14:24:49 +0000 (23:24 +0900)]
Fix `use_self` false positive on nested functions
Taiki Endo [Mon, 11 Mar 2019 11:45:57 +0000 (20:45 +0900)]
Filter out proc_macro and proc_macro_attribute
bors [Sun, 10 Mar 2019 23:21:48 +0000 (23:21 +0000)]
Auto merge of #3767 - alexreg:cosmetic-2, r=flip1995
Various cosmetic improvements
Related to the larger effort of https://github.com/rust-lang/rust/pull/58036.
flip1995 [Sun, 10 Mar 2019 22:01:56 +0000 (23:01 +0100)]
Fix/Ignore doc tests