]>
git.lizzy.rs Git - rust.git/log
Lukas Wirth [Mon, 13 Dec 2021 15:32:57 +0000 (16:32 +0100)]
minor: fixup generate assist priorities
bors[bot] [Fri, 10 Dec 2021 22:31:55 +0000 (22:31 +0000)]
Merge #10978
10978: internal: Only prime direct dependencies of the workspace crates r=jonas-schievink a=lnicola
This reduces the number of primed crates on `self` from 177 to 105.
```text
# baseline
86521 me 20 0 2939M 562M 14320 S 0.0 0.9 0:07.10 37 rust-analyzer
# pr
99947 me 20 0 2935M 549M 14424 S 0.0 0.9 0:07.10 37 rust-analyzer
```
The RAM usage seems to vary a lot, so I'm not sure the improvement shown above is real.
We also drop the topological sorting, although it might still make sense to do the dependencies before the workspace crates. But since it's only used to make the progress reporting a bit more fine, it probably doesn't matter too much.
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
bors[bot] [Fri, 10 Dec 2021 19:02:51 +0000 (19:02 +0000)]
Merge #10981
10981: internal: Remove some allocations r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Fri, 10 Dec 2021 19:01:24 +0000 (20:01 +0100)]
Remove some allocations
bors[bot] [Fri, 10 Dec 2021 18:19:02 +0000 (18:19 +0000)]
Merge #10979
10979: fix: Don't show trait flyimports for impl trait and placeholders r=Veykril a=Veykril
cc #8539
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Fri, 10 Dec 2021 18:18:21 +0000 (19:18 +0100)]
Don't show trait flyimports for impl trait and placeholders
Lukas Wirth [Fri, 10 Dec 2021 17:25:54 +0000 (18:25 +0100)]
Show enum completions for single variant enums in irrefutable patterns
Laurențiu Nicola [Fri, 10 Dec 2021 14:24:07 +0000 (16:24 +0200)]
Only prime direct dependencies of the workspace crates
bors[bot] [Fri, 10 Dec 2021 14:19:51 +0000 (14:19 +0000)]
Merge #10977
10977: fix: fix `concat!` with captured expression r=jonas-schievink a=jonas-schievink
Adds another hack on top of https://github.com/rust-analyzer/rust-analyzer/pull/10623 to fix `concat!`.
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/10721
bors r+
Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
Jonas Schievink [Fri, 10 Dec 2021 14:17:31 +0000 (15:17 +0100)]
Fix `concat!` with captured expression
bors[bot] [Thu, 9 Dec 2021 17:41:01 +0000 (17:41 +0000)]
Merge #10975
10975: internal: Shrink TraitImpls and InherentImpls HashMaps r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Thu, 9 Dec 2021 17:39:46 +0000 (18:39 +0100)]
internal: Shrink TraitImpls and InherentImpls HashMaps
bors[bot] [Thu, 9 Dec 2021 17:28:53 +0000 (17:28 +0000)]
Merge #10974
10974: minor: Simplify r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Thu, 9 Dec 2021 17:28:10 +0000 (18:28 +0100)]
Simplify
Lukas Wirth [Thu, 9 Dec 2021 17:13:15 +0000 (18:13 +0100)]
Use known names instead of string literals
Lukas Wirth [Thu, 9 Dec 2021 17:04:32 +0000 (18:04 +0100)]
Remove some allocs
bors[bot] [Thu, 9 Dec 2021 15:18:41 +0000 (15:18 +0000)]
Merge #10972
10972: minor: Bump vscode to 1.62 r=lnicola a=lnicola
bors r+
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Thu, 9 Dec 2021 15:16:30 +0000 (17:16 +0200)]
Bump eslint
Laurențiu Nicola [Thu, 9 Dec 2021 15:15:21 +0000 (17:15 +0200)]
Bump vscode
bors[bot] [Wed, 8 Dec 2021 16:12:37 +0000 (16:12 +0000)]
Merge #10966
10966: fix: Fix library target overriding sysroot deps r=jonas-schievink a=jonas-schievink
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/10827
bors r+
Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
Jonas Schievink [Wed, 8 Dec 2021 16:05:00 +0000 (17:05 +0100)]
Fix library target overriding sysroot deps
bors[bot] [Wed, 8 Dec 2021 14:46:13 +0000 (14:46 +0000)]
Merge #10964
10964: minor: Move synstructure hack out of ItemTree lowering r=jonas-schievink a=jonas-schievink
Don't set the name to `None` for the rest of the IDE if it's generated by synstructure.
bors r+
Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
Jonas Schievink [Wed, 8 Dec 2021 14:44:52 +0000 (15:44 +0100)]
Move synstructure hack out of ItemTree lowering
bors[bot] [Tue, 7 Dec 2021 21:57:59 +0000 (21:57 +0000)]
Merge #10950
10950: internal: completion: split out more PathKinds from ImmediateLocation r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Mon, 6 Dec 2021 14:51:33 +0000 (15:51 +0100)]
internal: completion: split out more PathKinds from ImmediateLocation
bors[bot] [Tue, 7 Dec 2021 16:52:21 +0000 (16:52 +0000)]
Merge #10960
10960: fix: fix handling of macros in `extern` blocks r=jonas-schievink a=jonas-schievink
- Removes knowledge of what's in an extern block from `ItemTree`.
- Treats extern blocks as `AssocContainerId` and renames the latter to `ItemContainerId`.
- Threads the container through name resolution (which is a bit messy).
- Considers statics to be associated items, since they can be in an extern block. (it might be better to further distinguish potentially-associated-items from potentially-in-an-extern-block-items, but currently I don't expect much of a benefit)
- Adds a test for the incorrect-case diagnostic demonstrating the impact of this change.
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/8913
bors r+
Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
Jonas Schievink [Tue, 7 Dec 2021 16:31:26 +0000 (17:31 +0100)]
Treat extern blocks as item containers
bors[bot] [Tue, 7 Dec 2021 15:44:05 +0000 (15:44 +0000)]
Merge #10958
10958: internal: add "Shuffle Crate Graph" command r=jonas-schievink a=jonas-schievink
May be useful for debugging issues like https://github.com/rust-analyzer/rust-analyzer/issues/10084
bors r+
Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
Jonas Schievink [Tue, 7 Dec 2021 15:41:24 +0000 (16:41 +0100)]
Update lsp-extensions.md
Jonas Schievink [Tue, 7 Dec 2021 14:38:12 +0000 (15:38 +0100)]
internal: add "Shuffle Crate Graph" command
bors[bot] [Tue, 7 Dec 2021 14:51:07 +0000 (14:51 +0000)]
Merge #10957
10957: fix: Fix some TryToNav impls not upmapping ranges out of macros r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Tue, 7 Dec 2021 14:42:54 +0000 (15:42 +0100)]
Adjust incorrect runnable tests
Lukas Wirth [Tue, 7 Dec 2021 14:06:56 +0000 (15:06 +0100)]
Simplify
Lukas Wirth [Tue, 7 Dec 2021 14:02:22 +0000 (15:02 +0100)]
Fix some TryToNav impls not upmapping ranges out of macros
bors[bot] [Mon, 6 Dec 2021 19:26:51 +0000 (19:26 +0000)]
Merge #10953
10953: minor: Bump `tracing` r=lnicola a=lnicola
bors r+
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Mon, 6 Dec 2021 18:47:02 +0000 (20:47 +0200)]
Bump tracing
bors[bot] [Mon, 6 Dec 2021 09:50:49 +0000 (09:50 +0000)]
Merge #10949
10949: Bump parser step limit a little r=lnicola a=lnicola
Fixes #10948
This doesn't actually make the limit configurable, but at least uses the same `Limit` struct, so we can fix all of them at once when we get to it.
We also bump the limit from 10 to 15M, which is a small enough increase to not worry about making the experience worse for non-`windows` users. We still crash when we reach the limit.
bors r+
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Mon, 6 Dec 2021 09:47:36 +0000 (11:47 +0200)]
Bump parser step limit a little
bors[bot] [Sun, 5 Dec 2021 15:28:28 +0000 (15:28 +0000)]
Merge #10944
10944: internal: Prefer resolution of inert attributes r=Veykril a=Veykril
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/10942
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Sun, 5 Dec 2021 15:23:20 +0000 (16:23 +0100)]
internal: Prefer resolution of inert attributes
bors[bot] [Sun, 5 Dec 2021 15:14:10 +0000 (15:14 +0000)]
Merge #10943
10943: feat: Enable completions for attributes r=Veykril a=Veykril
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Sun, 5 Dec 2021 14:57:28 +0000 (15:57 +0100)]
feat: Enable flyimport completions for attributes
bors[bot] [Sun, 5 Dec 2021 12:12:44 +0000 (12:12 +0000)]
Merge #10940
10940: minor: Fix HttpsProxyAgent creation and avoid deprecated call r=lnicola a=lnicola
bors r+
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Sun, 5 Dec 2021 12:11:49 +0000 (14:11 +0200)]
Fix HttpsProxyAgent creation and avoid deprecated call
bors[bot] [Sun, 5 Dec 2021 11:55:36 +0000 (11:55 +0000)]
Merge #10939
10939: minor: Clean up some unused cross-crate dependencies r=lnicola a=lnicola
bors r+
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Sun, 5 Dec 2021 11:54:35 +0000 (13:54 +0200)]
Clean up some unused cross-crate dependencies
bors[bot] [Sun, 5 Dec 2021 11:40:23 +0000 (11:40 +0000)]
Merge #10938
10938: minor: Bump d3 r=lnicola a=lnicola
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Sun, 5 Dec 2021 11:38:31 +0000 (13:38 +0200)]
Bump d3
bors[bot] [Sun, 5 Dec 2021 11:02:55 +0000 (11:02 +0000)]
Merge #10937
10937: fix: Add highlighting hack back for unresolved attributes r=Veykril a=Veykril
cc https://github.com/rust-analyzer/rust-analyzer/issues/10935
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Sun, 5 Dec 2021 10:59:07 +0000 (11:59 +0100)]
fix: Add highlighting hack back for unresolved attributes
bors[bot] [Sun, 5 Dec 2021 10:52:54 +0000 (10:52 +0000)]
Merge #10902
10902: Handle multiple cargo check quick fix spans r=Veykril a=brandondong
Resolves https://github.com/rust-analyzer/rust-analyzer/issues/10705.
**Cause:**
- For a cargo check diagnostic with multiple spans, only a single quick fix action would be created at the location of `spans[0]`. Additionally, the hover window details would only show the location of `spans[0]` next to the message.
**Fix:**
- Allow cargo check quick fix actions to be triggerable from multiple selection ranges. Specifically, if the selection intersects with any of the replacement spans, the quick fix action is shown.
- No change in behavior for the hover window details. It's pretty minor and I think showing multiple locations next to the message may be more confusing anyways.
Co-authored-by: Brandon <brandondong604@hotmail.com>
Brandon [Sun, 5 Dec 2021 05:26:07 +0000 (21:26 -0800)]
Update expected test results
Brandon [Sun, 5 Dec 2021 04:59:26 +0000 (20:59 -0800)]
Handle multiple cargo check quick fix spans
Brandon [Sun, 5 Dec 2021 03:59:05 +0000 (19:59 -0800)]
Refactor away unnecessary Vec
bors[bot] [Sat, 4 Dec 2021 18:08:11 +0000 (18:08 +0000)]
Merge #10930
10930: fix: Fix self keyword not being tagged as such in highlighting properly r=Veykril a=Veykril
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/10575
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Sat, 4 Dec 2021 18:07:18 +0000 (19:07 +0100)]
fix: Fix self keyword not being tagged as such in highlighting properly
bors[bot] [Sat, 4 Dec 2021 17:33:16 +0000 (17:33 +0000)]
Merge #10929
10929: internal: Split up macro/attribute semantic tokens a bit more r=Veykril a=Veykril
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/9172
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Sat, 4 Dec 2021 17:23:25 +0000 (18:23 +0100)]
Update semantic token docs
Lukas Wirth [Sat, 4 Dec 2021 17:18:09 +0000 (18:18 +0100)]
Introduce SymbolKind::Derive
Lukas Wirth [Sat, 4 Dec 2021 17:01:22 +0000 (18:01 +0100)]
Introduce SymbolKind::Attribute
bors[bot] [Sat, 4 Dec 2021 13:21:40 +0000 (13:21 +0000)]
Merge #10928
10928: minor: Bump deps r=lnicola a=lnicola
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Sat, 4 Dec 2021 13:21:04 +0000 (15:21 +0200)]
Bump pulldown-cmark-to-cmark
Laurențiu Nicola [Sat, 4 Dec 2021 13:17:30 +0000 (15:17 +0200)]
Bump miow
Laurențiu Nicola [Sat, 4 Dec 2021 13:14:31 +0000 (15:14 +0200)]
Bump countme
Laurențiu Nicola [Sat, 4 Dec 2021 13:08:43 +0000 (15:08 +0200)]
Bump chalk
Laurențiu Nicola [Sat, 4 Dec 2021 12:54:54 +0000 (14:54 +0200)]
Bump most deps
bors[bot] [Sat, 4 Dec 2021 12:37:19 +0000 (12:37 +0000)]
Merge #10927
10927: minor: bump the rest of the npm deps r=lnicola a=lnicola
bors r+
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Sat, 4 Dec 2021 12:28:48 +0000 (14:28 +0200)]
Bump rest of the npm deps
Laurențiu Nicola [Fri, 3 Dec 2021 19:50:17 +0000 (21:50 +0200)]
Bump node-fetch
Laurențiu Nicola [Fri, 3 Dec 2021 19:47:04 +0000 (21:47 +0200)]
Bump vsce
Laurențiu Nicola [Fri, 3 Dec 2021 19:37:17 +0000 (21:37 +0200)]
Bump eslint
Laurențiu Nicola [Fri, 3 Dec 2021 19:37:04 +0000 (21:37 +0200)]
Bump engine in lockfile
bors[bot] [Sat, 4 Dec 2021 12:17:29 +0000 (12:17 +0000)]
Merge #10925
10925: minor: Simplify `.vscodeignore` r=lnicola a=lnicola
The quadruple negation we used to have here was quite confusing:
```gitignore
**
!out
out/**
!out/src
```
Let's ignore everything and cherry-pick what we want to include.
~~And also include the extension sourcemap, just in case someone wants to debug the extension.~~
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Sat, 4 Dec 2021 10:34:13 +0000 (12:34 +0200)]
Simplify `.vscodeignore`
bors[bot] [Sat, 4 Dec 2021 11:44:27 +0000 (11:44 +0000)]
Merge #10924
10924: minor: Add LICENSE file to make vsce happy r=lnicola a=lnicola
Newer `vsce` versions error out if a `LICENSE` file is missing, even if the license is specified in `package.json`. Concatenate the two licenses we use and add a file with that to make a future `vsce` upgrade easier.
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
bors[bot] [Sat, 4 Dec 2021 10:46:05 +0000 (10:46 +0000)]
Merge #10926
10926: minor: Bump Node to 14 in release workflow r=lnicola a=lnicola
bors r+
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Sat, 4 Dec 2021 10:45:08 +0000 (12:45 +0200)]
Bump Node to 14 in release workflow
Laurențiu Nicola [Sat, 4 Dec 2021 10:17:35 +0000 (12:17 +0200)]
Add LICENSE file to make vsce happy
bors[bot] [Fri, 3 Dec 2021 23:52:28 +0000 (23:52 +0000)]
Merge #10921
10921: minor: Update list of safe intrinsics r=Veykril a=Veykril
Closes https://github.com/rust-analyzer/rust-analyzer/issues/4798
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Fri, 3 Dec 2021 23:51:50 +0000 (00:51 +0100)]
minor: Update list of safe intrinsics
bors[bot] [Fri, 3 Dec 2021 23:27:50 +0000 (23:27 +0000)]
Merge #10920
10920: minor: Shorten spans of mismatched_arg_count diag r=Veykril a=Veykril
Fixes #5289
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Fri, 3 Dec 2021 23:16:47 +0000 (00:16 +0100)]
minor: Shorten spans of mismatched_arg_count diag
bors[bot] [Fri, 3 Dec 2021 22:53:32 +0000 (22:53 +0000)]
Merge #10919
10919: internal: Define missing semantic token hierarchies in package.json r=Veykril a=Veykril
Closes https://github.com/rust-analyzer/rust-analyzer/issues/10077
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Fri, 3 Dec 2021 21:16:57 +0000 (22:16 +0100)]
Add some more semantic token to textmate grammar mapping
Lukas Wirth [Fri, 3 Dec 2021 20:59:34 +0000 (21:59 +0100)]
Define missing semantic token hierarchies in package.json
bors[bot] [Fri, 3 Dec 2021 20:21:55 +0000 (20:21 +0000)]
Merge #10916
10916: feat: ide: Convert while let to loop r=Veykril a=rainy-me
close #10901
Co-authored-by: rainy-me <github@yue.coffee>
rainy-me [Fri, 3 Dec 2021 19:50:06 +0000 (04:50 +0900)]
fix: defer condition construction
bors[bot] [Fri, 3 Dec 2021 19:28:36 +0000 (19:28 +0000)]
Merge #10915
10915: feat: Resolve builtin-attr and tools in ide layer r=Veykril a=Veykril
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Fri, 3 Dec 2021 19:28:15 +0000 (20:28 +0100)]
Improve hover message for inert attributes
bors[bot] [Fri, 3 Dec 2021 18:54:52 +0000 (18:54 +0000)]
Merge #10917
10917: minor: Bump some npm deps r=lnicola a=lnicola
bors r+
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Fri, 3 Dec 2021 18:52:41 +0000 (20:52 +0200)]
Bump engine
Laurențiu Nicola [Fri, 3 Dec 2021 18:52:29 +0000 (20:52 +0200)]
Bump esbuild
Laurențiu Nicola [Fri, 3 Dec 2021 18:49:38 +0000 (20:49 +0200)]
Bump typescript
Laurențiu Nicola [Fri, 3 Dec 2021 18:48:15 +0000 (20:48 +0200)]
Bump @types/vscode
Laurențiu Nicola [Fri, 3 Dec 2021 18:46:19 +0000 (20:46 +0200)]
Bump eslint
Laurențiu Nicola [Fri, 3 Dec 2021 18:40:29 +0000 (20:40 +0200)]
Bump vscode-test
Laurențiu Nicola [Fri, 3 Dec 2021 18:35:22 +0000 (20:35 +0200)]
Bump tslib
Laurențiu Nicola [Fri, 3 Dec 2021 18:33:14 +0000 (20:33 +0200)]
Bump node-fetch and @types/node-fetch
Laurențiu Nicola [Fri, 3 Dec 2021 18:30:26 +0000 (20:30 +0200)]
Bump @types/node
Laurențiu Nicola [Fri, 3 Dec 2021 18:29:30 +0000 (20:29 +0200)]
Bump d3