]>
git.lizzy.rs Git - rust.git/log
Shotaro Yamada [Sat, 28 Sep 2019 11:29:35 +0000 (20:29 +0900)]
Resolve reviews
Shotaro Yamada [Wed, 18 Sep 2019 05:56:30 +0000 (14:56 +0900)]
Apply suggestion
Co-Authored-By: ecstatic-morse <ecstaticmorse@gmail.com>
Shotaro Yamada [Mon, 16 Sep 2019 15:50:36 +0000 (00:50 +0900)]
Test fixes
Shotaro Yamada [Tue, 10 Sep 2019 02:56:34 +0000 (11:56 +0900)]
Add run-rustfix
Shotaro Yamada [Mon, 16 Sep 2019 15:50:15 +0000 (00:50 +0900)]
Fix false-positive of redundant_clone and move to clippy::perf
bors [Wed, 2 Oct 2019 17:16:29 +0000 (17:16 +0000)]
Auto merge of #4599 - lzutao:zero-ptr-suggestion, r=flip1995
Add suggestion for zero-ptr lint
changelog: Improve suggestion of `zero_ptr` lint
bors [Wed, 2 Oct 2019 15:51:58 +0000 (15:51 +0000)]
Auto merge of #4603 - rust-lang:needless-doc-main, r=flip1995
New lint: needless_doc_main
changelog: Add `needless_doc_main` lint
Lzu Tao [Wed, 2 Oct 2019 15:38:00 +0000 (22:38 +0700)]
Add suggestion for zero-ptr lint
Andre Bogus [Mon, 30 Sep 2019 22:10:24 +0000 (00:10 +0200)]
New lint: needless_doc_main
bors [Wed, 2 Oct 2019 08:56:56 +0000 (08:56 +0000)]
Auto merge of #4590 - flip1995:ice_4579, r=Manishearth
Fix ICE #4579
Fixes #4579
Fixes #4584
r? @phansch
changelog: Fix ICE caused by Clippys const-utils
flip1995 [Wed, 2 Oct 2019 08:55:52 +0000 (10:55 +0200)]
Disable hyper and futures-rs integration tests
flip1995 [Fri, 27 Sep 2019 13:36:56 +0000 (15:36 +0200)]
Fix ICE #4579
flip1995 [Fri, 27 Sep 2019 13:36:20 +0000 (15:36 +0200)]
Add regression test for ICE #4579
Manish Goregaokar [Wed, 2 Oct 2019 00:53:14 +0000 (17:53 -0700)]
Merge pull request #4606 from Manishearth/rustup
Fix some tests
Manish Goregaokar [Tue, 1 Oct 2019 23:45:07 +0000 (16:45 -0700)]
Remove tests that only ICE on CI
Manish Goregaokar [Tue, 1 Oct 2019 23:37:22 +0000 (16:37 -0700)]
Allow const_err in out_of_bounds_indexing tests
Manish Goregaokar [Tue, 1 Oct 2019 18:30:22 +0000 (11:30 -0700)]
Merge pull request #4604 from Manishearth/rustup
Rustup to rustc 1.40.0-nightly (
702b45e40 2019-10-01)
Manish Goregaokar [Tue, 1 Oct 2019 17:14:15 +0000 (10:14 -0700)]
Use new spans for expansion checking in loop lints
bors [Sun, 29 Sep 2019 17:05:36 +0000 (17:05 +0000)]
Auto merge of #4601 - lzutao:clean-up-unused-vars, r=phansch
Clean up some unused vars
changelog: none
Lzu Tao [Sun, 29 Sep 2019 16:40:38 +0000 (23:40 +0700)]
Clean up some unused vars
bors [Sun, 29 Sep 2019 16:06:56 +0000 (16:06 +0000)]
Auto merge of #4600 - lzutao:rustup-63492, r=oli-obk
Rustup rust-lang/rust#63492
changelog: none
Lzu Tao [Sun, 29 Sep 2019 15:58:17 +0000 (22:58 +0700)]
Rustup rust-lang/rust#63492
bors [Sun, 29 Sep 2019 06:21:55 +0000 (06:21 +0000)]
Auto merge of #4593 - james9909:fix-multiple-inherent-impls, r=llogiq
Fix false positive in `multiple_inherent_impl`
changelog: Fix false positive in `multiple_inherent_impl` by ignoring impls derived from macros.
Closes #4578.
bors [Sat, 28 Sep 2019 09:51:08 +0000 (09:51 +0000)]
Auto merge of #4594 - matthiaskrgr:rustup_18, r=phansch
rustup https://github.com/rust-lang/rust/pull/64781/
cc https://github.com/rust-lang/rust/issues/64867
changelog: none
Matthias Krüger [Sat, 28 Sep 2019 08:42:41 +0000 (10:42 +0200)]
rustup https://github.com/rust-lang/rust/pull/64781/
cc https://github.com/rust-lang/rust/issues/64867
James Wang [Sat, 28 Sep 2019 01:46:55 +0000 (20:46 -0500)]
Ignore impls derived from macros
bors [Fri, 27 Sep 2019 16:19:14 +0000 (16:19 +0000)]
Auto merge of #4591 - flip1995:rustup, r=flip1995
Rustup to rust-lang/rust#64813
cc rust-lang/rust#64843
changelog: none
flip1995 [Fri, 27 Sep 2019 16:10:18 +0000 (18:10 +0200)]
Remove clippy::author attribute from trailing_zeroes test
flip1995 [Fri, 27 Sep 2019 16:07:07 +0000 (18:07 +0200)]
Move author issue test to author subdir
flip1995 [Fri, 27 Sep 2019 16:01:04 +0000 (18:01 +0200)]
Fix author lint
flip1995 [Fri, 27 Sep 2019 15:16:06 +0000 (17:16 +0200)]
Rustup to rust-lang/rust#64813
bors [Fri, 27 Sep 2019 06:16:55 +0000 (06:16 +0000)]
Auto merge of #4589 - mikerite:booleans-refactor-
20190925 , r=phansch
Refactor `booleans`
Remove unused output from `suggest(..)`
changelog: none
Michael Wright [Fri, 27 Sep 2019 05:59:34 +0000 (07:59 +0200)]
Refactor `booleans`
Remove unused output from `suggest(..)`
bors [Fri, 27 Sep 2019 04:46:06 +0000 (04:46 +0000)]
Auto merge of #4585 - michaelsproul:arith-assign-op, r=llogiq
Detect mutating arithmetic in integer_arithmetic restriction lint
changelog: detect mutating arithmetic (like +=) in `integer_arithmetic` restriction lint
Michael Sproul [Thu, 26 Sep 2019 07:47:06 +0000 (17:47 +1000)]
Detect assignment ops in integer_arithmetic
bors [Thu, 26 Sep 2019 17:32:24 +0000 (17:32 +0000)]
Auto merge of #4582 - matthiaskrgr:rustup_17, r=Manishearth
rustup https://github.com/rust-lang/rust/pull/64515
changelog: none
Matthias Krüger [Thu, 26 Sep 2019 16:34:43 +0000 (18:34 +0200)]
rustup https://github.com/rust-lang/rust/pull/64515
changelog: none
bors [Thu, 26 Sep 2019 10:33:44 +0000 (10:33 +0000)]
Auto merge of #4581 - Manishearth:osx-enable, r=matthiaskrgr
Re enable OSX builders
Fixes #4576
changelog: none
Manish Goregaokar [Thu, 26 Sep 2019 10:31:06 +0000 (03:31 -0700)]
Re enable OSX builders
Fixes #4576
bors [Thu, 26 Sep 2019 09:13:59 +0000 (09:13 +0000)]
Auto merge of #4580 - lzutao:rustup, r=flip1995
Rustup rust-lang/rust#64513
changelog: none
Lzu Tao [Thu, 26 Sep 2019 09:04:45 +0000 (16:04 +0700)]
Remove unused import
Lzu Tao [Thu, 26 Sep 2019 09:03:36 +0000 (16:03 +0700)]
Rustup https://github.com/rust-lang/rust/pull/64513
bors [Thu, 26 Sep 2019 08:06:16 +0000 (08:06 +0000)]
Auto merge of #4568 - mikerite:fix-4548, r=flip1995
Fix `nonminimal-bool` false positive
Closes #4548
Closes #3847
changelog: Fix `nonminimal-bool` false positive
bors [Thu, 26 Sep 2019 07:38:08 +0000 (07:38 +0000)]
Auto merge of #4569 - james9909:add-comparison-chain, r=oli-obk
Add a new lint for comparison chains
changelog: Adds a new lint: `comparison_chain`.
`comparison_chain` lints all `if` conditional chains where all the conditions are binary comparisons on the same two operands and will suggest a rewrite with `match`.
Closes #4531.
bors [Thu, 26 Sep 2019 06:02:21 +0000 (06:02 +0000)]
Auto merge of #4570 - lzutao:call_site_toplevel_ref_arg, r=phansch
Fix macro expansion in toplevel_ref_arg lint
changelog: Fix macro expansion in toplevel_ref_arg lint
Lzu Tao [Thu, 26 Sep 2019 01:53:39 +0000 (01:53 +0000)]
Remove unused attribute in test
Lzu Tao [Thu, 26 Sep 2019 01:46:51 +0000 (08:46 +0700)]
Fix macro expansion in toplevel_ref_arg lint
Lzu Tao [Wed, 25 Sep 2019 04:06:52 +0000 (11:06 +0700)]
Add regression test for macro expansion
bors [Wed, 25 Sep 2019 21:54:14 +0000 (21:54 +0000)]
Auto merge of #4575 - Manishearth:suggestions, r=oli-obk
Make more tests rustfixable
Fixes https://github.com/rust-lang/rust-clippy/issues/3630
changelog: Improve suggestions for many lints in preparation for `cargo fix --clippy`
r? @phansch @yaahc
Manish Goregaokar [Wed, 25 Sep 2019 21:53:20 +0000 (14:53 -0700)]
Downgrade op_ref to a MaybeIncorrect suggestion
Manish Goregaokar [Wed, 25 Sep 2019 17:49:56 +0000 (10:49 -0700)]
unnecessary_operation: make test rustfixable
Manish Goregaokar [Wed, 25 Sep 2019 17:46:14 +0000 (10:46 -0700)]
unnecessary_clone: split rustfixable lint out into separate test
Manish Goregaokar [Wed, 25 Sep 2019 17:33:48 +0000 (10:33 -0700)]
string_add, string_add_assign: split tests, make one rustfixable
Manish Goregaokar [Wed, 25 Sep 2019 17:21:08 +0000 (10:21 -0700)]
redundant_static_lifetimes: split test, make rustfixable
Manish Goregaokar [Wed, 25 Sep 2019 17:08:19 +0000 (10:08 -0700)]
renamed_builtin_attr: make test rustfixable
Manish Goregaokar [Wed, 25 Sep 2019 17:01:21 +0000 (10:01 -0700)]
redundant_pattern_matching: make rustfixable
Manish Goregaokar [Wed, 25 Sep 2019 16:30:27 +0000 (09:30 -0700)]
redundant_closure_call: split tests into fixable
Manish Goregaokar [Wed, 25 Sep 2019 16:03:32 +0000 (09:03 -0700)]
map_unit_fn: make test rustfixable
Manish Goregaokar [Wed, 25 Sep 2019 15:49:23 +0000 (08:49 -0700)]
map_unit_fn: fix applicability
Manish Goregaokar [Wed, 25 Sep 2019 15:48:09 +0000 (08:48 -0700)]
option_map_unit_fn: Split into fixable/unfixable
Manish Goregaokar [Wed, 25 Sep 2019 15:39:45 +0000 (08:39 -0700)]
map_unit_fn: rename tests to fixable
Manish Goregaokar [Wed, 25 Sep 2019 12:39:56 +0000 (05:39 -0700)]
non_copy_const: remove incorrect suggestion
Manish Goregaokar [Wed, 25 Sep 2019 12:28:19 +0000 (05:28 -0700)]
needless_return: add allow()s to test, make rustfixable
Manish Goregaokar [Wed, 25 Sep 2019 12:25:31 +0000 (05:25 -0700)]
needless_collect: fix suggestion, make test rustfixable
Manish Goregaokar [Wed, 25 Sep 2019 12:19:09 +0000 (05:19 -0700)]
needless_borrowed_ref: fix false positive, make rustfixable
Manish Goregaokar [Wed, 25 Sep 2019 12:03:28 +0000 (05:03 -0700)]
needless_borrow: allow other lints, make fixable
Manish Goregaokar [Wed, 25 Sep 2019 11:59:10 +0000 (04:59 -0700)]
mem_discriminant: split test, make rustfixable
Manish Goregaokar [Wed, 25 Sep 2019 11:50:23 +0000 (04:50 -0700)]
map_flatten: make it a rustfix test
Manish Goregaokar [Wed, 25 Sep 2019 11:49:38 +0000 (04:49 -0700)]
Leave note on non-rustfixable tests
Manish Goregaokar [Wed, 25 Sep 2019 11:46:43 +0000 (04:46 -0700)]
Remove large-digit-groups test from literals.rs
Manish Goregaokar [Wed, 25 Sep 2019 11:38:17 +0000 (04:38 -0700)]
map_entry test: Fix semicolon, add run-rustfix
Manish Goregaokar [Wed, 25 Sep 2019 11:31:46 +0000 (04:31 -0700)]
Split map_entry tests into fixable and unfixable
bors [Wed, 25 Sep 2019 20:56:22 +0000 (20:56 +0000)]
Auto merge of #4574 - Manishearth:rustup, r=yaahc,centril
Rustup to rustc 1.39.0-nightly (
acf7b50c7 2019-09-25)
changelog: none
fixes https://github.com/rust-lang/rust/issues/64777
r? @phansch @yaahc
Manish Goregaokar [Wed, 25 Sep 2019 11:29:39 +0000 (04:29 -0700)]
Remove suggestion for complex map_entry cases
Manish Goregaokar [Wed, 25 Sep 2019 20:51:29 +0000 (13:51 -0700)]
allow osx failures
Manish Goregaokar [Wed, 25 Sep 2019 20:34:55 +0000 (13:34 -0700)]
ignore single-match for or patterns
Manish Goregaokar [Wed, 25 Sep 2019 19:00:17 +0000 (12:00 -0700)]
arm.pats -> arm.pat
Manish Goregaokar [Wed, 25 Sep 2019 11:16:25 +0000 (04:16 -0700)]
Rustup to rustc 1.39.0-nightly (
acf7b50c7 2019-09-25)
- Addresses inference error
- Updates compiletest
Michael Wright [Wed, 25 Sep 2019 04:20:40 +0000 (06:20 +0200)]
Refactor `booleans`
Inline `snip (..)` function
James Wang [Wed, 25 Sep 2019 00:07:03 +0000 (19:07 -0500)]
Update refactor according to code review
James Wang [Tue, 24 Sep 2019 22:05:43 +0000 (17:05 -0500)]
Fix example in docs
James Wang [Tue, 24 Sep 2019 21:55:05 +0000 (16:55 -0500)]
Add a new lint for comparison chains
Michael Wright [Tue, 24 Sep 2019 06:06:58 +0000 (08:06 +0200)]
Fix `nonminimal-bool` false positive
Closes #4548
Closes #3847
bors [Mon, 23 Sep 2019 17:01:13 +0000 (17:01 +0000)]
Auto merge of #4567 - phansch:toplevel_ref_arg, r=flip1995
Add run-rustfix for toplevel_ref_arg lint
changelog: none
cc #3630
Philipp Hansch [Mon, 23 Sep 2019 09:19:24 +0000 (11:19 +0200)]
Add run-rustfix for toplevel_ref_arg lint
bors [Mon, 23 Sep 2019 08:25:38 +0000 (08:25 +0000)]
Auto merge of #4561 - rust-lang:let-return-fix, r=phansch
Fix let_and_return lint
This fixes #4555 (false positive for the `let_and_return` lint).
changelog: none
Andre Bogus [Fri, 20 Sep 2019 16:20:49 +0000 (18:20 +0200)]
Fix let_and_return lint
bors [Mon, 23 Sep 2019 07:11:21 +0000 (07:11 +0000)]
Auto merge of #4566 - phansch:update_changelog2, r=flip1995
Update the changelog for Rust 1.38
[Rendered](https://github.com/phansch/rust-clippy/blob/update_changelog2/CHANGELOG.md#rust-138)
changelog: none
bors [Mon, 23 Sep 2019 05:51:04 +0000 (05:51 +0000)]
Auto merge of #4537 - mikerite:unneeded_wildcard_pattern, r=phansch
Add `unneeded-wildcard-pattern` lint
changelog: Add `unneeded-wildcard-pattern` lint
Michael Wright [Mon, 23 Sep 2019 03:26:47 +0000 (05:26 +0200)]
Merge branch 'master' into unneeded_wildcard_pattern
Philipp Hansch [Sun, 22 Sep 2019 17:12:42 +0000 (19:12 +0200)]
Update the changelog for Rust 1.38
bors [Sun, 22 Sep 2019 11:40:35 +0000 (11:40 +0000)]
Auto merge of #4518 - imp:4517_license-file, r=phansch
clippy::cargo_common_metadata: check for license-file
When license property is missing in Cargo.toml check for license-file
as it may be used instead of the former. The check implemented here is
very naive as it only verifies that the field is present and is not
empty. More scrutiny can be applied by verifying the file is actually
present.
Fixes #4517
changelog: clippy::cargo_common_metadata now checks for license-file when license is missing
bors [Sun, 22 Sep 2019 10:36:32 +0000 (10:36 +0000)]
Auto merge of #4565 - matthiaskrgr:rustup_16, r=phansch
rustup https://github.com/rust-lang/rust/pull/64666
changelog: none
Matthias Krüger [Sun, 22 Sep 2019 10:35:20 +0000 (12:35 +0200)]
rustup https://github.com/rust-lang/rust/pull/64666
Cyril Plisko [Sat, 7 Sep 2019 08:00:02 +0000 (11:00 +0300)]
clippy::cargo_common_metadata: check for license-file
When license property is missing in Cargo.toml check for license-file
as it may be used instead of the former. The check implemented here is
very naive as it only verifies that the field is present and is not
empty. More scrutiny can be applied by verifying the file is actually
present.
Fixes #4517
Michael Wright [Sun, 22 Sep 2019 07:10:39 +0000 (09:10 +0200)]
Add additional tests to unneeded_wildcard_pattern
Michael Wright [Sun, 22 Sep 2019 06:59:23 +0000 (08:59 +0200)]
Merge branch 'master' into unneeded_wildcard_pattern
bors [Sat, 21 Sep 2019 11:42:15 +0000 (11:42 +0000)]
Auto merge of #4562 - phansch:wildcard_enum_match_rustfix, r=llogiq
Add run-rustfix for wildcard_enum_match_arm lint
changelog: none
cc #3630
Philipp Hansch [Sat, 21 Sep 2019 05:26:18 +0000 (07:26 +0200)]
Add run-rustfix for wildcard_enum_match_arm lint
bors [Sat, 21 Sep 2019 01:01:21 +0000 (01:01 +0000)]
Auto merge of #4558 - Manishearth:suggestions, r=phansch
Make more tests rustfixable
changelog: Fix various lint suggestions
Progress towards https://github.com/rust-lang/rust-clippy/issues/3630
r? @phansch