]>
git.lizzy.rs Git - rust.git/log
Shotaro Yamada [Sun, 9 Dec 2018 11:19:21 +0000 (20:19 +0900)]
Lint redundant clone of projection
Shotaro Yamada [Sun, 9 Dec 2018 10:18:44 +0000 (19:18 +0900)]
Fix test
`if true` is recognized by MIR optimization.
Shotaro Yamada [Sun, 9 Dec 2018 10:18:35 +0000 (19:18 +0900)]
Cleanup
Philipp Hansch [Sat, 8 Dec 2018 12:42:01 +0000 (13:42 +0100)]
Merge pull request #3512 from matthiaskrgr/rustup
rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )
Philipp Hansch [Sat, 8 Dec 2018 11:41:04 +0000 (12:41 +0100)]
s/rustfmt-preview/rustfmt/
Philipp Hansch [Sat, 8 Dec 2018 11:09:32 +0000 (12:09 +0100)]
Swap if branches
Philipp Hansch [Sat, 8 Dec 2018 10:57:25 +0000 (11:57 +0100)]
Fix c_void false positive caused by libc refactoring
The path of `libc::c_void` has changes in https://github.com/rust-lang/libc/commit/
5c1a6b8a6d558882927a0816d91c01b9c2a88018
The DefId path is now always platform specific like
`libc::windows::c_void`. This fixes our c_void detection to only check
the first and last elements.
Matthias Krüger [Sat, 8 Dec 2018 00:56:03 +0000 (01:56 +0100)]
rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )
Philipp Hansch [Sat, 8 Dec 2018 08:59:02 +0000 (09:59 +0100)]
Merge pull request #3336 from HMPerson1/clone_on_copy_deref
Fix `clone_on_copy` not detecting derefs sometimes
Philipp Hansch [Fri, 7 Dec 2018 21:20:19 +0000 (22:20 +0100)]
Merge pull request #3507 from flying-sheep/patch-1
typo: emum → enum
Philipp A [Fri, 7 Dec 2018 11:24:59 +0000 (12:24 +0100)]
typo: emum → enum
Philipp Hansch [Thu, 6 Dec 2018 21:11:29 +0000 (22:11 +0100)]
Merge pull request #3257 from o01eg/remove-sysroot
Don't try to determine sysroot. rustc_driver will use default value.
Philipp Hansch [Thu, 6 Dec 2018 16:17:40 +0000 (17:17 +0100)]
Merge pull request #3501 from matthiaskrgr/rustup
rustup clippy build with latest rustc
Manish Goregaokar [Thu, 6 Dec 2018 16:17:18 +0000 (11:17 -0500)]
Merge pull request #3502 from rust-lang/nrc-patch-1
Remove -preview suffix from README
Nick Cameron [Thu, 6 Dec 2018 16:11:50 +0000 (11:11 -0500)]
Remove -preview suffix from README
Matthias Krüger [Thu, 6 Dec 2018 15:38:32 +0000 (16:38 +0100)]
rustup clippy build with latest rustc
(breakage due to https://github.com/rust-lang/rust/commit/
08f8faedd0e30f45762afbb8d4873f7041e7462c )
Fixes #3500
Philipp Hansch [Thu, 6 Dec 2018 13:13:20 +0000 (14:13 +0100)]
Merge pull request #3497 from daxpedda/master
Fix bug in `implicit_return`.
daxpedda [Thu, 6 Dec 2018 12:23:42 +0000 (13:23 +0100)]
Forgot to remove some debugging code ...
daxpedda [Thu, 6 Dec 2018 12:21:04 +0000 (13:21 +0100)]
Improved code noted by clippy.
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Thu, 6 Dec 2018 11:26:43 +0000 (12:26 +0100)]
Merge pull request #3496 from fkohlgrueber/macro-in-closure-in-if-cond
fix #3482 and add ui test for it
daxpedda [Thu, 6 Dec 2018 11:22:54 +0000 (12:22 +0100)]
Fix bug in `implicit_return`.
Bug was already covered by test, but test was not checked for.
O01eg [Thu, 6 Dec 2018 10:46:23 +0000 (13:46 +0300)]
Fix format.
O01eg [Thu, 6 Dec 2018 10:21:45 +0000 (13:21 +0300)]
Add sysroot gettinh code to dogfood tests.
Felix Kohlgrüber [Thu, 6 Dec 2018 10:07:10 +0000 (11:07 +0100)]
fix #3482 and add ui test for it
O01eg [Thu, 22 Nov 2018 12:40:29 +0000 (15:40 +0300)]
Add sysroot getting code to tests.
O01eg [Thu, 4 Oct 2018 07:58:09 +0000 (10:58 +0300)]
Don't try to determine sysroot. rustc_driver will use default value.
Philipp Hansch [Thu, 6 Dec 2018 06:12:01 +0000 (07:12 +0100)]
Merge pull request #3494 from daxpedda/master
Added `IMPLICIT_RETURN` lint.
Philipp Hansch [Thu, 6 Dec 2018 06:10:04 +0000 (07:10 +0100)]
Merge pull request #3444 from waynr/fix-dogfood-tests
Fix dogfood tests
Wayne Warren [Fri, 30 Nov 2018 18:54:47 +0000 (12:54 -0600)]
Don't change current working directory of cargo tests
Wayne Warren [Sat, 24 Nov 2018 21:24:13 +0000 (15:24 -0600)]
Use cargo's "PROFILE" envvar and set CLIPPY_DOGFOOD
Wayne Warren [Sat, 24 Nov 2018 21:22:23 +0000 (15:22 -0600)]
Use dogfood_runner for deterministic test ordering
Wayne Warren [Wed, 21 Nov 2018 15:15:32 +0000 (09:15 -0600)]
Remove unnecessary documentation
Wayne Warren [Wed, 21 Nov 2018 15:14:42 +0000 (09:14 -0600)]
Fix dogfood tests.
daxpedda [Wed, 5 Dec 2018 14:01:19 +0000 (15:01 +0100)]
Added additional reasoning to `Why is this bad?`.
Added comment to explain usage of MIR.
daxpedda [Wed, 5 Dec 2018 13:39:09 +0000 (14:39 +0100)]
Renamed to `implicit_return`.
Covered all other kinds besides `ExprKind::Lit`.
Added check for replacing `break` with `return`.
Philipp Krones [Wed, 5 Dec 2018 12:34:20 +0000 (13:34 +0100)]
Merge pull request #3495 from flip1995/tykind_fix
Fix usage of ty::TyKind
flip1995 [Tue, 4 Dec 2018 23:14:44 +0000 (00:14 +0100)]
Fix ty::TyKind usage
flip1995 [Tue, 4 Dec 2018 22:19:42 +0000 (23:19 +0100)]
Fix TyKind::<kind> usage in codebase
daxpedda [Wed, 5 Dec 2018 10:26:40 +0000 (11:26 +0100)]
Appeasing the Test Gods.
Seems I'm not smart enough to run the tests locally before committing.
daxpedda [Wed, 5 Dec 2018 09:54:21 +0000 (10:54 +0100)]
Renamed `forced_return` to `missing_returns`.
Better clarification in the docs.
Ran `update_lints`.
daxpedda [Wed, 5 Dec 2018 00:59:09 +0000 (01:59 +0100)]
Added `FORCED_RETURN` lint.
Philipp Krones [Tue, 4 Dec 2018 13:57:19 +0000 (14:57 +0100)]
Merge pull request #3490 from phansch/extract_single_match_else_ui_test
Extract single_match_else UI test
Philipp Hansch [Tue, 4 Dec 2018 06:26:29 +0000 (07:26 +0100)]
Merge pull request #3473 from lucasloisp/additional-bool-comparisons
Adds inequality cases to bool comparison (#3438)
Philipp Hansch [Tue, 4 Dec 2018 06:24:11 +0000 (07:24 +0100)]
Merge pull request #3488 from phansch/fix_cargo_lint_bug
Fix wildcard_dependencies false positive
Philipp Hansch [Tue, 4 Dec 2018 06:17:53 +0000 (07:17 +0100)]
Extract single_match_else UI test
There's only one test currently.
I also updated the lint doc with a 'good' example and changed the lint
help text a bit.
cc #2038
Philipp Hansch [Tue, 4 Dec 2018 05:47:41 +0000 (06:47 +0100)]
cargo fmt
Lucas Lois [Fri, 30 Nov 2018 13:21:11 +0000 (10:21 -0300)]
Adds inequality cases to bool comparison lint
The lint now checks cases like `y != true`
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Mon, 3 Dec 2018 11:42:31 +0000 (12:42 +0100)]
Merge pull request #3478 from dtolnay/setlen
Remove unsafe_vector_initialization lint
David Tolnay [Mon, 3 Dec 2018 10:43:01 +0000 (02:43 -0800)]
Remove unsafe_vector_initialization lint
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Mon, 3 Dec 2018 10:06:56 +0000 (11:06 +0100)]
Merge pull request #3479 from dtolnay/literal
Downgrade large_digit_groups to pedantic
Philipp Hansch [Mon, 3 Dec 2018 07:12:35 +0000 (08:12 +0100)]
Fix wildcard_dependencies false positive
This now only checks for wildcard_dependencies if the source is a
non-git source.
I tried adding a compiletest suite for the cargo lints, but I was unable
to override the `Cargo.toml` of the original executable.
I tested this manually by modifying the main `Cargo.toml`.
Fixes #3458
Philipp Hansch [Mon, 3 Dec 2018 06:44:43 +0000 (07:44 +0100)]
Merge pull request #3487 from phansch/fix_fmt
Fix rustfmt format
Philipp Hansch [Mon, 3 Dec 2018 06:13:00 +0000 (07:13 +0100)]
Fix rustfmt format
Philipp Hansch [Sun, 2 Dec 2018 15:29:38 +0000 (16:29 +0100)]
Merge pull request #3486 from phansch/make_windows_travis_run_more_stuff
Travis: Add rustc sysroot bin to PATH for windows build
Philipp Hansch [Sun, 2 Dec 2018 14:08:11 +0000 (15:08 +0100)]
Disable incremental build for windows
Testing if this speeds up compilation time for the Windows CI build.
Philipp Hansch [Sun, 2 Dec 2018 13:33:19 +0000 (14:33 +0100)]
Travis: Add rustc sysroot bin to PATH for windows build
Philipp Hansch [Sun, 2 Dec 2018 11:35:14 +0000 (12:35 +0100)]
Merge pull request #3483 from phansch/mention_triage_procedure_in_contributing
Mention triage procedure in contributing.md
Philipp Hansch [Sun, 2 Dec 2018 11:33:09 +0000 (12:33 +0100)]
Merge pull request #3485 from phansch/fix_some_nursery_links
Fix some nursery links
Philipp Hansch [Sun, 2 Dec 2018 10:45:05 +0000 (11:45 +0100)]
Fix some nursery links
Philipp Hansch [Sun, 2 Dec 2018 10:37:05 +0000 (11:37 +0100)]
Merge pull request #3484 from phansch/fix_windows_lineendings
git: Enforce LF lineendings for everything
Philipp Hansch [Sun, 2 Dec 2018 09:57:56 +0000 (10:57 +0100)]
Enforce LF lineendings for everything
Someone on discord reported issues with UI tests.
This should make sure that git never automatically converts lineendings
for text files to `CRLF`. They should always be `LF` now.
Probably this means that we can stop using dos2unix for #3306, too.
Taken from [Rust's .gitattributes file](https://github.com/rust-lang/rust/blob/master/.gitattributes).
Philipp Hansch [Sun, 2 Dec 2018 08:33:23 +0000 (09:33 +0100)]
Mention triage procedure in contributing.md
David Tolnay [Sun, 2 Dec 2018 01:23:53 +0000 (17:23 -0800)]
Keep testing large_digit_groups as ui test
David Tolnay [Sun, 2 Dec 2018 01:19:39 +0000 (17:19 -0800)]
Keep testing unsafe_vector_initialization as ui test
David Tolnay [Sun, 2 Dec 2018 00:46:03 +0000 (16:46 -0800)]
Downgrade large_digit_groups to pedantic
I believe if the user already decided to put underscores in their
literal, Clippy should be willing to believe that they put a number of
underscores that they felt was readable.
David Tolnay [Sun, 2 Dec 2018 00:20:58 +0000 (16:20 -0800)]
Downgrade unsafe_vector_initialization to restriction
This lint looks for:
let mut vec = Vec::with_capacity(len);
vec.set_len(len);
The suggested replacement is `vec![0; len]`.
This is far too opinionated to be a deny-by-default lint because the performance
characteristics of the suggested replacement are totally different.
I am not convinced that this lint has value beyond what deny(unsafe_code) gives
you. Unsafe code is unsafe but please don't deny-by-default lint it if that's
the only reason.
Philipp Hansch [Fri, 30 Nov 2018 09:20:24 +0000 (10:20 +0100)]
Merge pull request #3471 from matthiaskrgr/mamor_warn
remove macro_at_most_once_rep feature attribute since it's stable
Matthias Krüger [Fri, 30 Nov 2018 08:14:18 +0000 (09:14 +0100)]
remove macro_at_most_once_rep feature attribute since it's stable
Warning was:
warning: the feature `macro_at_most_once_rep` has been stable since 1.32.0 and no longer requires an attribute to enable
--> clippy_lints/src/lib.rs:19:12
|
19 | #![feature(macro_at_most_once_rep)]
| ^^^^^^^^^^^^^^^^^^^^^^
|
= note: #[warn(stable_features)] on by default
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Wed, 28 Nov 2018 15:19:55 +0000 (16:19 +0100)]
Merge pull request #3465 from flip1995/rustfmt
rustfmt everything once and for all
Philipp Krones [Wed, 28 Nov 2018 14:40:44 +0000 (15:40 +0100)]
Merge pull request #3466 from phansch/clippy_rfc_readme
Update docs in regards to the merged RFC
Philipp Krones [Wed, 28 Nov 2018 13:39:25 +0000 (14:39 +0100)]
Add missing word
Co-Authored-By: phansch <dev@phansch.net>
Philipp Hansch [Wed, 28 Nov 2018 07:11:28 +0000 (08:11 +0100)]
Update docs in regards to the merged RFC
Philipp Hansch [Wed, 28 Nov 2018 06:19:49 +0000 (07:19 +0100)]
Merge pull request #3464 from flip1995/no_fork_integration
Don't run integration tests in forks
flip1995 [Tue, 27 Nov 2018 21:36:25 +0000 (22:36 +0100)]
Document how to run rustfmt in CONTRIBUTING.md
flip1995 [Tue, 27 Nov 2018 21:01:22 +0000 (22:01 +0100)]
Don't run integration tests in forks
flip1995 [Tue, 27 Nov 2018 20:49:09 +0000 (21:49 +0100)]
Fix some formatting issues
flip1995 [Tue, 27 Nov 2018 20:14:15 +0000 (21:14 +0100)]
Run rustfmt on clippy_lints
flip1995 [Tue, 27 Nov 2018 20:13:26 +0000 (21:13 +0100)]
Run rustfmt on build.rs
flip1995 [Tue, 27 Nov 2018 20:13:08 +0000 (21:13 +0100)]
Run rustfmt on clippy_dev
flip1995 [Tue, 27 Nov 2018 20:12:38 +0000 (21:12 +0100)]
Run rustfmt on rustc_tools_util
flip1995 [Tue, 27 Nov 2018 20:12:13 +0000 (21:12 +0100)]
Run rustfmt on src
flip1995 [Tue, 27 Nov 2018 20:11:50 +0000 (21:11 +0100)]
Run rustfmt on the tests
flip1995 [Tue, 27 Nov 2018 20:11:05 +0000 (21:11 +0100)]
Let travis run cargo fmt --all -- --check
flip1995 [Tue, 27 Nov 2018 19:46:11 +0000 (20:46 +0100)]
Error on line overflow
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Tue, 27 Nov 2018 17:29:33 +0000 (18:29 +0100)]
Merge pull request #3459 from flip1995/sugg_appl
Add Applicability to suggestion lints: Take 2
flip1995 [Tue, 27 Nov 2018 16:31:17 +0000 (17:31 +0100)]
Fix NAIVE_BYTECOUNT applicability
flip1995 [Tue, 27 Nov 2018 15:59:52 +0000 (16:59 +0100)]
Fix dogfood error
flip1995 [Tue, 27 Nov 2018 15:59:39 +0000 (16:59 +0100)]
Change Applicability of MISTYPED_LITERAL_SUFFIX
flip1995 [Tue, 27 Nov 2018 14:13:57 +0000 (15:13 +0100)]
Add applicability level to (nearly) every span_lint_and_sugg function
flip1995 [Tue, 27 Nov 2018 14:27:34 +0000 (15:27 +0100)]
Update stderr file
flip1995 [Tue, 27 Nov 2018 14:11:13 +0000 (15:11 +0100)]
Fix bugs and improve documentation
Some bugs and some documentation is unrelated to the Applicability change, but
these bugs were serious and the documentation was kind of required to
understand what's going on.
flip1995 [Tue, 20 Nov 2018 13:06:29 +0000 (14:06 +0100)]
Add Applicability::Unspecified to span_lint_and_sugg functions
flip1995 [Tue, 20 Nov 2018 09:33:40 +0000 (10:33 +0100)]
Introduce snippet_with_applicability and hir_with_applicability functions
Philipp Krones [Mon, 26 Nov 2018 13:31:48 +0000 (14:31 +0100)]
Merge pull request #3412 from matthiaskrgr/readme_2
readme: tell how to install clippy on travis from git if it is not shipped with a nightly.
Matthias Krüger [Sun, 4 Nov 2018 23:12:42 +0000 (00:12 +0100)]
readme: tell how to install clippy on travis from git if it is not shipped with a nightly.
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Mon, 26 Nov 2018 12:37:46 +0000 (13:37 +0100)]
Merge pull request #3365 from gnieto/lint/slow-initialization
Add slow vector initializations lint
Philipp Hansch [Mon, 26 Nov 2018 06:19:14 +0000 (07:19 +0100)]
Merge pull request #3456 from matthiaskrgr/builtin
constants: add u128 i128 builtin types and fix outdated url
Matthias Krüger [Mon, 26 Nov 2018 00:12:12 +0000 (01:12 +0100)]
constants: add u128 i128 builtin types and fix outdated url
Guillem Nieto [Sun, 25 Nov 2018 22:36:04 +0000 (14:36 -0800)]
Update lints
Guillem Nieto [Sun, 18 Nov 2018 22:45:53 +0000 (23:45 +0100)]
Lint only the first statment/expression after alloc
Instead of searching for all the successive expressions after a vector
allocation, check only the first expression.
This is done to minimize the amount of false positives of the lint.