]>
git.lizzy.rs Git - rust.git/log
bors[bot] [Wed, 24 Jun 2020 22:09:28 +0000 (22:09 +0000)]
Merge #5025
5025: Don't mess with messy temp dir and just download into extension dir r=matklad a=Veetaha
Temp dirs are messy. Dealing with them requires handling quite a bunch of
edge cases. As proposed by lnicola this seems better to just put the temp files
in the extension dir and not care much about suddenly leaving garbage.
Instead we get shorter and less platform-caveat-y code.
We will also assume users don't try to issue a download in different vscode windows simultaneously.
Fixes #5019
Co-authored-by: Veetaha <veetaha2@gmail.com>
Veetaha [Wed, 24 Jun 2020 22:00:30 +0000 (01:00 +0300)]
Append 10 random hex chars to temp artifact files
bors[bot] [Wed, 24 Jun 2020 16:58:44 +0000 (16:58 +0000)]
Merge #5039
5039: Flatten module hierarchy r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 24 Jun 2020 16:57:30 +0000 (18:57 +0200)]
Flatten module hierarchy
Aleksey Kladov [Wed, 24 Jun 2020 16:54:05 +0000 (18:54 +0200)]
Cleanup visibility
bors[bot] [Wed, 24 Jun 2020 15:45:39 +0000 (15:45 +0000)]
Merge #5038
5038: Make `iterate_method_candidates` non-generic r=jonas-schievink a=jonas-schievink
Closes https://github.com/rust-analyzer/rust-analyzer/issues/4975
bors r+ :robot: ;)
Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
Jonas Schievink [Wed, 24 Jun 2020 15:45:38 +0000 (17:45 +0200)]
Make `iterate_method_candidates` non-generic
bors[bot] [Wed, 24 Jun 2020 15:18:13 +0000 (15:18 +0000)]
Merge #5035 #5037
5035: Less error-prone naming r=matklad a=matklad
bors r+
🤖
5037: Don't watch dirs if not asked to r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 24 Jun 2020 15:11:07 +0000 (17:11 +0200)]
Don't watch dirs if not asked to
bors[bot] [Wed, 24 Jun 2020 15:07:37 +0000 (15:07 +0000)]
Merge #4990
4990: Introduce an ItemTree layer to avoid reparsing files r=matklad a=jonas-schievink
This reduces the latency of "go to definition" in a simple benchmark on rust-analyzer by around 30%.
cc https://github.com/rust-analyzer/rust-analyzer/issues/1650
Closes https://github.com/rust-analyzer/rust-analyzer/issues/3485
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Aleksey Kladov [Wed, 24 Jun 2020 14:58:49 +0000 (16:58 +0200)]
Less error-prone naming
Aleksey Kladov [Wed, 24 Jun 2020 14:56:27 +0000 (16:56 +0200)]
Fix infinite cargo check bug
Jonas Schievink [Wed, 24 Jun 2020 14:50:23 +0000 (16:50 +0200)]
Reorder items
Jonas Schievink [Wed, 24 Jun 2020 14:46:44 +0000 (16:46 +0200)]
Clean up and fix inner item collection a bit
Jonas Schievink [Wed, 24 Jun 2020 14:26:26 +0000 (16:26 +0200)]
Use a HashMap instead of Vec
This is no longer enforcing stack discipline, so a Vec isn't necessary
or helpful
Jonas Schievink [Wed, 24 Jun 2020 14:21:00 +0000 (16:21 +0200)]
Remove unneeded HirFileId argument
Jonas Schievink [Wed, 24 Jun 2020 14:14:58 +0000 (16:14 +0200)]
Shrink arenas after building ItemTree
Jonas Schievink [Wed, 24 Jun 2020 14:07:02 +0000 (16:07 +0200)]
ItemTree: Use more boxed slices
Jonas Schievink [Wed, 24 Jun 2020 13:54:35 +0000 (15:54 +0200)]
Don't allocate empty generics
Jonas Schievink [Wed, 24 Jun 2020 13:36:18 +0000 (15:36 +0200)]
Don't allocate common visibilities
Jonas Schievink [Tue, 23 Jun 2020 18:20:30 +0000 (20:20 +0200)]
Remove file id from item tree
It's not needed, and `source` is only used by tests anyways
Jonas Schievink [Tue, 23 Jun 2020 17:42:19 +0000 (19:42 +0200)]
Slightly reduce ItemTree memory footprint
Jonas Schievink [Tue, 23 Jun 2020 16:46:08 +0000 (18:46 +0200)]
Merge item tree traits
The Source trait isn't needed anymore since we no longer merge
extern crate items with use items.
Jonas Schievink [Tue, 23 Jun 2020 16:41:32 +0000 (18:41 +0200)]
Generate ModItem via macro
Jonas Schievink [Tue, 23 Jun 2020 16:31:14 +0000 (18:31 +0200)]
Address more comments
Jonas Schievink [Tue, 23 Jun 2020 16:28:47 +0000 (18:28 +0200)]
if let else -> match
Jonas Schievink [Tue, 23 Jun 2020 16:20:51 +0000 (18:20 +0200)]
Unify and test attribute handling
Jonas Schievink [Tue, 23 Jun 2020 11:46:38 +0000 (13:46 +0200)]
Collect inner items in expression macros
Jonas Schievink [Tue, 23 Jun 2020 09:57:23 +0000 (11:57 +0200)]
Measure ItemTree query memory usage
Jonas Schievink [Mon, 22 Jun 2020 17:15:54 +0000 (19:15 +0200)]
Make generics and attr queries use ItemTree
Now it's fast
Jonas Schievink [Mon, 22 Jun 2020 14:59:15 +0000 (16:59 +0200)]
Record HirFileId's in profiler
Jonas Schievink [Mon, 22 Jun 2020 14:41:10 +0000 (16:41 +0200)]
Make remaining item data queries use item tree
Jonas Schievink [Mon, 22 Jun 2020 13:07:06 +0000 (15:07 +0200)]
draw the rest of the owl
Jonas Schievink [Wed, 17 Jun 2020 16:43:41 +0000 (18:43 +0200)]
ItemTree: Make clonable and add AST access
Jonas Schievink [Wed, 17 Jun 2020 10:24:05 +0000 (12:24 +0200)]
Lower generics
Jonas Schievink [Tue, 16 Jun 2020 17:20:29 +0000 (19:20 +0200)]
ItemTree: use a newtyped ID
Jonas Schievink [Tue, 16 Jun 2020 12:52:43 +0000 (14:52 +0200)]
Move ItemTree lowering into its own module
Jonas Schievink [Mon, 15 Jun 2020 17:23:50 +0000 (19:23 +0200)]
Remove now-broken incremental test
The ItemTree tracks impl and trait items, so the CrateDefMap now needs
recomputing when those change
Jonas Schievink [Mon, 15 Jun 2020 17:16:43 +0000 (19:16 +0200)]
Remove raw item query
Jonas Schievink [Mon, 15 Jun 2020 17:16:29 +0000 (19:16 +0200)]
Fix test
Jonas Schievink [Mon, 15 Jun 2020 17:16:14 +0000 (19:16 +0200)]
Move collector
Jonas Schievink [Mon, 15 Jun 2020 17:16:02 +0000 (19:16 +0200)]
Draw the rest of the owl
Jonas Schievink [Fri, 12 Jun 2020 21:24:26 +0000 (23:24 +0200)]
collector changes WIP
Jonas Schievink [Fri, 12 Jun 2020 11:58:02 +0000 (13:58 +0200)]
lower traits
Jonas Schievink [Thu, 11 Jun 2020 17:46:56 +0000 (19:46 +0200)]
Hook up query, add impls, lower moar
Aleksey Kladov [Wed, 25 Mar 2020 14:33:01 +0000 (15:33 +0100)]
Start item tree
bors[bot] [Wed, 24 Jun 2020 14:25:56 +0000 (14:25 +0000)]
Merge #5034
5034: Cleanup project.json deserialization r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 24 Jun 2020 13:52:07 +0000 (15:52 +0200)]
Cleanup project.json deserialization
Aleksey Kladov [Wed, 24 Jun 2020 12:57:37 +0000 (14:57 +0200)]
Rename json_project -> project_json
bors[bot] [Wed, 24 Jun 2020 13:02:37 +0000 (13:02 +0000)]
Merge #5015 #5027 #5028
5015: Account for updated module ids when determining whether a resolution is changed r=matklad a=Nashenas88
Fixes #4943
5027: Make Debug less verbose for VfsPath and use Display in analysis-stats r=matklad a=lnicola
5028: Remove namedExports config r=matklad a=lnicola
Fixes a warning:
```
(!) Plugin commonjs: The namedExports option from "@rollup/plugin-commonjs" is deprecated. Named exports are now handled automatically.
```
Co-authored-by: Paul Daniel Faria <Nashenas88@users.noreply.github.com>
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
bors[bot] [Wed, 24 Jun 2020 12:52:05 +0000 (12:52 +0000)]
Merge #5029
5029: Be more explicit about absolute paths at various places r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Paul Daniel Faria [Wed, 24 Jun 2020 12:50:59 +0000 (08:50 -0400)]
Fix formatting issue with glob shadow test
Aleksey Kladov [Wed, 24 Jun 2020 11:34:24 +0000 (13:34 +0200)]
Be more explicit about absolute paths at various places
Paul Daniel Faria [Wed, 24 Jun 2020 12:20:41 +0000 (08:20 -0400)]
Use a macro in push_res to simplify code, simplify glob_shadowed_def assertion
Laurențiu Nicola [Wed, 24 Jun 2020 11:09:12 +0000 (14:09 +0300)]
Remove namedExports config
Laurențiu Nicola [Wed, 24 Jun 2020 11:07:03 +0000 (14:07 +0300)]
Make Debug less verbose for VfsPath and use Display in analysis-stats
bors[bot] [Wed, 24 Jun 2020 10:40:47 +0000 (10:40 +0000)]
Merge #5023
5023: Fix string literal inference in match r=flodiebold a=lnicola
Fixes #5020
r? @flodiebold
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
bors[bot] [Wed, 24 Jun 2020 10:31:20 +0000 (10:31 +0000)]
Merge #5024 #5026
5024: Simplify r=matklad a=matklad
bors r+
🤖
5026: Disable file watching when running slow tests r=matklad a=matklad
This should rid us of the intermittent test failure
https://github.com/rust-analyzer/rust-analyzer/pull/5017#issuecomment-
648717983
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 24 Jun 2020 10:06:53 +0000 (12:06 +0200)]
Simplify
Aleksey Kladov [Wed, 24 Jun 2020 10:27:13 +0000 (12:27 +0200)]
Disable file watching when running slow tests
This should rid us of the intermittent test failure
https://github.com/rust-analyzer/rust-analyzer/pull/5017#issuecomment-
648717983
Laurențiu Nicola [Wed, 24 Jun 2020 09:57:28 +0000 (12:57 +0300)]
Fix string literal inference in match
Veetaha [Wed, 24 Jun 2020 10:19:14 +0000 (13:19 +0300)]
Don't mess with messy temp dir and just download into extension dir
Temp dirs are messy. Dealing with them requires handling quite a bunch of
edge cases. As proposed by lnicola this seems better to just put the temp files
in the extension dir and not care much about suddenly leaving garbage.
Instead we get shorter and less platform-caveat-y code.
We will also assume users don't try to issue a download in different vscode windows simultaneously
Aleksey Kladov [Wed, 24 Jun 2020 10:01:17 +0000 (12:01 +0200)]
Simplify
bors[bot] [Wed, 24 Jun 2020 09:52:24 +0000 (09:52 +0000)]
Merge #5022
5022: Simplify r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 24 Jun 2020 09:51:45 +0000 (11:51 +0200)]
Simplify
Aleksey Kladov [Wed, 24 Jun 2020 09:50:53 +0000 (11:50 +0200)]
Simplify
Aleksey Kladov [Wed, 24 Jun 2020 09:48:44 +0000 (11:48 +0200)]
Simplify
bors[bot] [Wed, 24 Jun 2020 09:34:25 +0000 (09:34 +0000)]
Merge #5021
5021: Reduce code dupication around fixtures r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 24 Jun 2020 09:31:30 +0000 (11:31 +0200)]
Remove duplication
Aleksey Kladov [Wed, 24 Jun 2020 09:29:43 +0000 (11:29 +0200)]
More consistent usage of fixtures
Aleksey Kladov [Wed, 24 Jun 2020 09:05:47 +0000 (11:05 +0200)]
Use fixtures more
bors[bot] [Wed, 24 Jun 2020 08:28:59 +0000 (08:28 +0000)]
Merge #5018
5018: Simplify r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 24 Jun 2020 08:22:02 +0000 (10:22 +0200)]
Simplify
bors[bot] [Wed, 24 Jun 2020 05:22:23 +0000 (05:22 +0000)]
Merge #4940
4940: Add support for marking doctest items as distinct from normal code r=ltentrup a=Nashenas88
This adds `HighlightTag::Generic | HighlightModifier::Injected` as the default highlight for all elements within a doctest. Please feel free to suggest that a new tag be created or a different one used.
![Screenshot from 2020-06-23 09-18-13](https://user-images.githubusercontent.com/
1673130 /
85408493 -
9752ce00 -b532-11ea-94fe-
197353ccc778 .png)
Fixes #4929
Fixes #4939
Co-authored-by: Paul Daniel Faria <Nashenas88@users.noreply.github.com>
Co-authored-by: Paul Daniel Faria <nashenas88@users.noreply.github.com>
Paul Daniel Faria [Wed, 24 Jun 2020 02:10:01 +0000 (22:10 -0400)]
Account for updated module ids when determining whether a resolution is "changed"
Paul Daniel Faria [Tue, 23 Jun 2020 23:35:09 +0000 (19:35 -0400)]
Improve readability be replacing hard-to-read if-else branches with a match
bors[bot] [Tue, 23 Jun 2020 22:59:22 +0000 (22:59 +0000)]
Merge #5014
5014: Use only one code-path for parsing fixtures r=matklad a=matklad
This removes leading newlines everywhere, shifting all ranges in tests
by one
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 23 Jun 2020 22:48:38 +0000 (00:48 +0200)]
Use only one code-path for parsing fixtures
This removes leading newlines everywhere, shifting all ranges in tests
by one
Aleksey Kladov [Tue, 23 Jun 2020 22:30:34 +0000 (00:30 +0200)]
Centralize fixture parsing for assists
bors[bot] [Tue, 23 Jun 2020 21:47:00 +0000 (21:47 +0000)]
Merge #5008
5008: Remove useless test code r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 23 Jun 2020 11:20:53 +0000 (13:20 +0200)]
Remove useless test code
bors[bot] [Tue, 23 Jun 2020 21:34:12 +0000 (21:34 +0000)]
Merge #5013
5013: More principled indentation trimming in fixtures r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 23 Jun 2020 20:27:24 +0000 (22:27 +0200)]
More principled indentation trimming in fixtures
Aleksey Kladov [Tue, 23 Jun 2020 19:45:40 +0000 (21:45 +0200)]
Minor, rename
bors[bot] [Tue, 23 Jun 2020 19:30:28 +0000 (19:30 +0000)]
Merge #5012
5012: Slightly better name r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 23 Jun 2020 19:29:50 +0000 (21:29 +0200)]
Slightly better name
bors[bot] [Tue, 23 Jun 2020 18:39:58 +0000 (18:39 +0000)]
Merge #5011
5011: Simplify fixtures r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 23 Jun 2020 18:38:36 +0000 (20:38 +0200)]
Complicate
Fixing test fallout unfortunately requires more work, we need to do
it, but let's merge something at least!
Aleksey Kladov [Tue, 23 Jun 2020 16:58:45 +0000 (18:58 +0200)]
Docs for Fixture
Aleksey Kladov [Tue, 23 Jun 2020 16:56:26 +0000 (18:56 +0200)]
Cut problematic dependency
Aleksey Kladov [Tue, 23 Jun 2020 16:46:56 +0000 (18:46 +0200)]
Nicer API
Aleksey Kladov [Tue, 23 Jun 2020 16:43:55 +0000 (18:43 +0200)]
Simplify
Paul Daniel Faria [Tue, 23 Jun 2020 16:40:55 +0000 (12:40 -0400)]
Remove unrelated change
Aleksey Kladov [Tue, 23 Jun 2020 16:34:50 +0000 (18:34 +0200)]
Simplify
Aleksey Kladov [Tue, 23 Jun 2020 16:20:32 +0000 (18:20 +0200)]
Simplify
Aleksey Kladov [Tue, 23 Jun 2020 16:17:43 +0000 (18:17 +0200)]
Drop rarely used fixture functionality
Aleksey Kladov [Tue, 23 Jun 2020 15:59:56 +0000 (17:59 +0200)]
Move fixtures to a separate file
Paul Daniel Faria [Tue, 23 Jun 2020 16:15:45 +0000 (12:15 -0400)]
Update comment for pop_and_inject
Co-authored-by: Leander Tentrup <ltentrup@users.noreply.github.com>
Paul Daniel Faria [Tue, 23 Jun 2020 13:17:53 +0000 (09:17 -0400)]
Update injection mechanism and stop injecting through highlight element, switch to more general new highlight tag, generic
Paul Daniel Faria [Mon, 22 Jun 2020 14:28:07 +0000 (10:28 -0400)]
Add punctuation highlighting for highlighting punctuation in doctests, fix highlighting in doctests