]>
git.lizzy.rs Git - rust.git/log
flip1995 [Fri, 26 Jul 2019 19:01:18 +0000 (21:01 +0200)]
Bump version of clippy_dummy
The crates.io page of clippy still suggest to install `clippy-preview`
instead of `clippy` I think it's time to change this.
Thanks to the Stuttgart Meetup for discovering this!
bors [Wed, 24 Jul 2019 04:56:28 +0000 (04:56 +0000)]
Auto merge of #4297 - matthiaskrgr:rustup_12, r=matthiaskrgr
rustup
changelog: none
Matthias Krüger [Wed, 24 Jul 2019 00:24:27 +0000 (02:24 +0200)]
update test stderr, not sure which rustc pull request caused this.
Matthias Krüger [Wed, 24 Jul 2019 00:20:36 +0000 (02:20 +0200)]
rustup https://github.com/rust-lang/rust/pull/62859
bors [Tue, 23 Jul 2019 09:52:18 +0000 (09:52 +0000)]
Auto merge of #4266 - uHOOCCOOHu:fix/async_fn_lifetime, r=flip1995
Ignore generated fresh lifetimes in elision check
<!--
Thank you for making Clippy better!
We're collecting our changelog from pull request descriptions.
If your PR only updates to the latest nightly, you can leave the
`changelog` entry as `none`. Otherwise, please write a short comment
explaining your change.
If your PR fixes an issue, you can add "fixes #issue_number" into this
PR description. This way the issue will be automatically closed when
your PR is merged.
If you added a new lint, here's a checklist for things that will be
checked during review or continuous integration.
- [ ] Followed [lint naming conventions][lint_naming]
- [ ] Added passing UI tests (including committed `.stderr` file)
- [ ] `cargo test` passes locally
- [ ] Executed `util/dev update_lints`
- [ ] Added lint documentation
- [ ] Run `cargo fmt`
Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.
Delete this line and everything above before opening your PR -->
fixes #3988
changelog: Ignore generated fresh lifetimes in elision check.
**HELP**: It seems `tests/ui` are compiled under edition 2015, and I don't know how to add tests for this properly.
Here is the test input it had already passed:
```rust
#![feature(async_await)]
#![allow(dead_code)]
async fn sink1<'a>(_: &'a str) {} // lint
async fn sink1_elided(_: &str) {} // ok
async fn one_to_one<'a>(s: &'a str) -> &'a str { s } // lint
async fn one_to_one_elided(s: &str) -> &str { s } // ok
async fn all_to_one<'a>(a: &'a str, _b: &'a str) -> &'a str { a } // ok
// async fn unrelated(_: &str, _: &str) {} // Not allowed in async fn
// #3988
struct Foo;
impl Foo {
pub async fn foo(&mut self) {} // ok
}
// rust-lang/rust#61115
async fn print(s: &str) { // ok
println!("{}", s);
}
fn main() {}
```
uHOOCCOOHu [Mon, 22 Jul 2019 19:59:09 +0000 (03:59 +0800)]
Fix tests for edition 2018 compatibility
uHOOCCOOHu [Mon, 22 Jul 2019 18:57:49 +0000 (02:57 +0800)]
Revert "Revert global fmt config and use `rustfmt::skip`"
This reverts commit
b70b3b14aa3125fe4f74a6a71fb7a7b7e78ab13f .
bors [Sun, 21 Jul 2019 13:48:30 +0000 (13:48 +0000)]
Auto merge of #4292 - mikerite:fix-breakage-
20190721 , r=matthiaskrgr
Fix breakage due to rust-lang/rust#62705
Also rename `OUTER_EXPN_INFO` to `OUTER_EXPN_EXPN_INFO` to match new
function names.
changelog: none
Michael Wright [Sun, 21 Jul 2019 10:52:14 +0000 (12:52 +0200)]
Fix breakage due to rust-lang/rust#60913
Michael Wright [Sun, 21 Jul 2019 07:36:31 +0000 (09:36 +0200)]
Fix breakage due to rust-lang/rust#62705
Also rename `OUTER_EXPN_INFO` to `OUTER_EXPN_EXPN_INFO` to match new
function names.
uHOOCCOOHu [Fri, 19 Jul 2019 16:50:18 +0000 (00:50 +0800)]
Revert global fmt config and use `rustfmt::skip`
uHOOCCOOHu [Fri, 19 Jul 2019 15:03:34 +0000 (23:03 +0800)]
Fix fmt
bors [Fri, 19 Jul 2019 14:44:36 +0000 (14:44 +0000)]
Auto merge of #4287 - matthiaskrgr:rustup_11, r=phansch
rustup https://github.com/rust-lang/rust/pull/62679/
changelog: none
Matthias Krüger [Fri, 19 Jul 2019 14:41:10 +0000 (16:41 +0200)]
rustup https://github.com/rust-lang/rust/pull/62679/
bors [Fri, 19 Jul 2019 07:25:55 +0000 (07:25 +0000)]
Auto merge of #4286 - phansch:update_pulldown_cmark3, r=flip1995
Update pulldown-cmark to 0.5.3
Fixes a couple of crashes of which I added one example to our tests.
changelog: Update `pulldown-cmark` to 0.5.3 to fix potential crashes in `doc_markdown` lint
bors [Fri, 19 Jul 2019 05:31:31 +0000 (05:31 +0000)]
Auto merge of #4285 - matthiaskrgr:rustup_backticks, r=phansch
rustup https://github.com/rust-lang/rust/pull/62764
(was merged as part of https://github.com/rust-lang/rust/pull/62782 )
changelog: none
Philipp Hansch [Fri, 19 Jul 2019 05:18:10 +0000 (07:18 +0200)]
Update pulldown-cmark to 0.5.3
Matthias Krüger [Thu, 18 Jul 2019 22:35:32 +0000 (00:35 +0200)]
rustup https://github.com/rust-lang/rust/pull/62764
(was merged as part of https://github.com/rust-lang/rust/pull/62782 )
bors [Thu, 18 Jul 2019 18:57:32 +0000 (18:57 +0000)]
Auto merge of #4282 - phansch:decrease_stderr_maximum_length, r=flip1995
Decrease maximum length for stderr files
Now at 275.
changelog: none
cc #2038
uHOOCCOOHu [Thu, 18 Jul 2019 18:43:10 +0000 (02:43 +0800)]
Add test
bors [Thu, 18 Jul 2019 18:20:40 +0000 (18:20 +0000)]
Auto merge of #4274 - daxpedda:implicit_return_fixes, r=flip1995
false positives fixes of `implicit_return`
- Handle returning macro statements properly (remove "this error originates in a macro outside of the current crate")
- Handle functions that return never type
- Handle functions that panic but do not return never type
changelog: Fix false positives in `implicit_return` lint pertaining to macros and panics
bors [Thu, 18 Jul 2019 17:16:28 +0000 (17:16 +0000)]
Auto merge of #4284 - flip1995:rustfmt, r=phansch
Format code
changelog: none
flip1995 [Thu, 18 Jul 2019 15:23:22 +0000 (17:23 +0200)]
Format code
Philipp Hansch [Wed, 17 Jul 2019 19:13:33 +0000 (21:13 +0200)]
Decrease maximum length for stderr files
Now at 275.
daxpedda [Wed, 17 Jul 2019 18:44:09 +0000 (20:44 +0200)]
Improved imports
bors [Wed, 17 Jul 2019 08:08:18 +0000 (08:08 +0000)]
Auto merge of #4280 - phansch:uitests_matches, r=flip1995
UI Test Cleanup: Extract match_ref_pats tests
changelog: none
cc #2038
bors [Wed, 17 Jul 2019 07:23:25 +0000 (07:23 +0000)]
Auto merge of #4259 - Darth-Revan:origin/inherent_to_string, r=flip1995
Implement lint for inherent to_string() method.
Fixes #4247
changelog: Implement two new lints: `inherent_to_string` and `inherent_to_string_shadow_display`
1) Emits a warning if a type implements an inherent method `to_string(&self) -> String`
2) Emits an error if a type implements an inherent method `to_string(&self) -> String` and also implements the `Display` trait
Darth-Revan [Tue, 16 Jul 2019 16:29:37 +0000 (18:29 +0200)]
Fix "unkown clippy lint" error in UI test.
Darth-Revan [Mon, 15 Jul 2019 16:43:47 +0000 (18:43 +0200)]
Corrections for PR review.
Darth-Revan [Sat, 6 Jul 2019 18:13:38 +0000 (20:13 +0200)]
Implement lint for inherent to_string() method.
bors [Wed, 17 Jul 2019 06:48:53 +0000 (06:48 +0000)]
Auto merge of #4278 - phansch:uitestcleanup_indexing, r=flip1995
UI Test Cleanup: Split out out_of_bounds_indexing
This moves the `out_of_bounds_indexing` lint tests to their own
directory.
changelog: none
cc #2038
Philipp Hansch [Wed, 17 Jul 2019 06:08:26 +0000 (08:08 +0200)]
UI Test Cleanup: Extract match_ref_pats tests
Philipp Hansch [Tue, 16 Jul 2019 20:26:47 +0000 (22:26 +0200)]
Update UI tests
bors [Tue, 16 Jul 2019 20:24:03 +0000 (20:24 +0000)]
Auto merge of #4276 - phansch:uitestcleanup, r=flip1995
UI Test Cleanup: Split up checked_unwrap tests
Let's slowly bring that ticket closer to the finish line :snail: :checkered_flag:
This splits up `tests/ui/checked_unwrap.rs` into:
* `tests/ui/checked_unwrap/complex.rs`
* `tests/ui/checked_unwrap/simple.rs`
Based on the naming of the methods in the tests.
changelog: none
cc #2038
Philipp Hansch [Tue, 16 Jul 2019 19:29:03 +0000 (21:29 +0200)]
Allow no_effect lint
for cleaner stderr file
Co-Authored-By: Philipp Krones <hello@philkrones.com>
Philipp Hansch [Tue, 16 Jul 2019 19:28:37 +0000 (21:28 +0200)]
Remove comment
Co-Authored-By: Philipp Krones <hello@philkrones.com>
Philipp Hansch [Tue, 16 Jul 2019 19:28:03 +0000 (21:28 +0200)]
cargo fmt
Philipp Hansch [Mon, 15 Jul 2019 19:27:44 +0000 (21:27 +0200)]
UI Test Cleanup: Split up checked_unwrap tests
This splits up `tests/ui/checked_unwrap.rs` into:
* `tests/ui/checked_unwrap/complex.rs`
* `tests/ui/checked_unwrap/simple.rs`
Based on the naming of the methods in the tests.
cc #2038
daxpedda [Tue, 16 Jul 2019 12:46:33 +0000 (14:46 +0200)]
Removed lintining on never type.
Abstracted repeating strings into statics.
bors [Tue, 16 Jul 2019 07:33:46 +0000 (07:33 +0000)]
Auto merge of #4275 - jayhardee9:fix/cmp-signum, r=flip1995
Fix float_cmp false positive when comparing signum
fixes #4248
changelog: Fix float_cmp false positive when comparing signum
Philipp Hansch [Tue, 16 Jul 2019 05:30:23 +0000 (07:30 +0200)]
UI Test Cleanup: Split out out_of_bounds_indexing
This moves the `out_of_bounds_indexing` lint tests to their own
directory.
bors [Mon, 15 Jul 2019 23:18:42 +0000 (23:18 +0000)]
Auto merge of #4211 - flip1995:check_changelog, r=matthiaskrgr
Check for changelog entry in PR bodies
cc #4031 but now on the auto and try branches. (https://github.com/rust-lang/rust-clippy/issues/3955#issuecomment-
502230021 )
changelog: none
Jerry Hardee [Mon, 15 Jul 2019 19:00:07 +0000 (14:00 -0500)]
Lint
Jerry Hardee [Mon, 15 Jul 2019 17:46:58 +0000 (12:46 -0500)]
Fix float_cmp false positive when comparing signum
f1.signum() == f2.signum()
f1.signum() != f2.signum()
should not trigger a warning.
flip1995 [Tue, 18 Jun 2019 10:14:02 +0000 (12:14 +0200)]
grep only lines, that start with 'changelog: '
flip1995 [Sat, 15 Jun 2019 11:54:46 +0000 (13:54 +0200)]
Get PR number from bors commit message
flip1995 [Thu, 25 Apr 2019 15:08:20 +0000 (17:08 +0200)]
Authenticate with github_api_token
flip1995 [Thu, 25 Apr 2019 13:45:52 +0000 (15:45 +0200)]
Check PRs for changelog entry in the body
daxpedda [Mon, 15 Jul 2019 14:02:50 +0000 (16:02 +0200)]
false positives fixes of `implicit_return`
- Handle returning macro statements properly
- Handle functions that return never type
- Handle functions that panic but do not return never type
bors [Mon, 15 Jul 2019 07:51:29 +0000 (07:51 +0000)]
Auto merge of #4273 - mikerite:deny-warnings, r=flip1995
Deny warnings in CI
changelog: none
Michael Wright [Mon, 15 Jul 2019 05:35:02 +0000 (07:35 +0200)]
Deny warnings in CI
bors [Mon, 15 Jul 2019 05:20:34 +0000 (05:20 +0000)]
Auto merge of #3418 - phansch:add_travis_windows_build, r=me,flip1995
Fix Travis Windows build
Closes #3306
flip1995 [Sun, 14 Jul 2019 13:21:50 +0000 (15:21 +0200)]
Disable dogfood on windows for faster build time on travis
flip1995 [Sun, 14 Jul 2019 13:13:47 +0000 (15:13 +0200)]
Revert "Remove `CARGO_INCREMENTAL=0` from windows build"
This reverts commit
876a7e1f01cb14a63eee54cb44524a87161d5454 .
Using incremental build on windows increases the build time on travis by
about 8 minutes.
flip1995 [Sat, 13 Jul 2019 11:26:26 +0000 (13:26 +0200)]
Remove `CARGO_INCREMENTAL=0` from windows build
flip1995 [Sat, 13 Jul 2019 09:42:44 +0000 (11:42 +0200)]
Test with different sysroots dependent on the OS
flip1995 [Fri, 12 Jul 2019 12:13:15 +0000 (14:13 +0200)]
Build sys_root in driver with PathBuf instead of String
flip1995 [Fri, 12 Jul 2019 10:12:53 +0000 (12:12 +0200)]
Don't re-set the LD_LIBRARY_PATH in base_tests.sh
flip1995 [Fri, 12 Jul 2019 08:58:06 +0000 (10:58 +0200)]
Add master toolchain binaries to the PATH
Philipp Hansch [Wed, 28 Nov 2018 06:29:05 +0000 (07:29 +0100)]
Change conditional
Maybe uname == Linux was true on the windows VM?
This could be a way to avoid the secret environment variable issue with
Travis CI.
Philipp Hansch [Fri, 9 Nov 2018 06:13:34 +0000 (07:13 +0100)]
Stop allowing failures in Travis windows build
bors [Sat, 13 Jul 2019 10:05:15 +0000 (10:05 +0000)]
Auto merge of #4229 - euclio:lint-doc-generation-fix, r=flip1995
don't strip blank lines in lint documentation
changelog: don't strip blank lines in lint documentation
Fixes #4116.
This PR also switches the docs headings to deterministically display in the order that they are declared in the source, with "Configuration" always appearing last. It doesn't seem like there was a defined order before.
bors [Sat, 13 Jul 2019 09:26:16 +0000 (09:26 +0000)]
Auto merge of #4232 - mikerite:dev-fmt-4, r=flip1995
Add dev fmt subcommand
changelog: none
bors [Sat, 13 Jul 2019 08:59:12 +0000 (08:59 +0000)]
Auto merge of #4268 - mikerite:fix-4260, r=flip1995
Fix bug in `implicit_hasher` causing crashes
Skip linting if the type is from an external macro. Closes #4260.
changelog: Fix bug in `implicit_hasher` causing crashes
Michael Wright [Sat, 13 Jul 2019 07:20:54 +0000 (09:20 +0200)]
Merge branch 'master' into dev-fmt-4
bors [Fri, 12 Jul 2019 07:26:03 +0000 (07:26 +0000)]
Auto merge of #4269 - lzutao:rustup, r=flip1995
Rustup `macro expansion and resolution`
Rustup https://github.com/rust-lang/rust/pull/62476
changelog: none
Lzu Tao [Thu, 11 Jul 2019 14:45:34 +0000 (21:45 +0700)]
Rustup `macro expansion and resolution`
Michael Wright [Thu, 11 Jul 2019 06:47:05 +0000 (08:47 +0200)]
Fix bug in `implicit_hasher` causing crashes
Skip linting if the type is from an external macro. Closes #4260.
Michael Wright [Thu, 11 Jul 2019 05:21:44 +0000 (05:21 +0000)]
Avoid rustfmt bug on Windows
uHOOCCOOHu [Tue, 9 Jul 2019 17:57:25 +0000 (01:57 +0800)]
Ignore generated fresh lifetimes in elision check.
bors [Tue, 9 Jul 2019 15:28:26 +0000 (15:28 +0000)]
Auto merge of #4257 - skade:improve-cast-alignment, r=flip1995
Improve cast_ptr_alignment lint
<!--
Thank you for making Clippy better!
We're collecting our changelog from pull request descriptions.
If your PR only updates to the latest nightly, you can leave the
`changelog` entry as `none`. Otherwise, please write a short comment
explaining your change.
If your PR fixes an issue, you can add "fixes #issue_number" into this
PR description. This way the issue will be automatically closed when
your PR is merged.
If you added a new lint, here's a checklist for things that will be
checked during review or continuous integration.
- [x] Followed [lint naming conventions][lint_naming]
- [x] Added passing UI tests (including committed `.stderr` file)
- [x] `cargo test` passes locally
- [x] Executed `util/dev update_lints`
- [x] Added lint documentation
- [x] Run `cargo fmt`
Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.
Delete this line and everything above before opening your PR -->
* print alignment in bytes in the lint message
* ignore ZST left-hand types
Fixes #3797 and #4256
changelog:
* `cast_ptr_alignment`: Print alignment in bytes in the lint message
* `cast_ptr_alignment`: Ignore casting from ZST left-hand types
Florian Gilcher [Sat, 6 Jul 2019 09:40:14 +0000 (11:40 +0200)]
Improve cast_ptr_alignment lint
* print alignment in bytes in the lint message
* ignore ZST left-hand types
bors [Tue, 9 Jul 2019 13:15:29 +0000 (13:15 +0000)]
Auto merge of #4265 - vks:patch-1, r=flip1995
cast_ptr_alignment: Mention legal use under known problems
Refs #2881.
changelog: Mention know problems for cast_ptr_alignment
Vinzent Steinberg [Tue, 9 Jul 2019 12:48:48 +0000 (14:48 +0200)]
cast_ptr_alignment: Mention legal use under known problems
Refs #2881.
bors [Tue, 9 Jul 2019 11:40:43 +0000 (11:40 +0000)]
Auto merge of #4264 - flip1995:appveyor, r=flip1995
Disable AppVeyor builds on the master branch
AppVeyor is already checked on every merge of a PR, rechecking it
immediately after on the master branch is not necessary.
Resolves #4263
changelog: none
flip1995 [Tue, 9 Jul 2019 11:34:22 +0000 (13:34 +0200)]
Disable AppVeyor builds on the master branch
AppVeyor is already checked on every merge of a PR, rechecking it
immediately after on the master branch is not necessary.
bors [Tue, 9 Jul 2019 09:48:33 +0000 (09:48 +0000)]
Auto merge of #4233 - thiagoarrais:jens1o-fix-1208, r=phansch,flip1995
Avoid reporting string_lit_as_bytes for long strings
Port of @jens1o code ([
b76f939 ][jens1o_commit])
Fixes #1208
[jens1o_commit]: https://github.com/jens1o/rust-clippy/commit/
b76f939ac2efcfe24900c286b3b7713d972d9088
<!--
Thank you for making Clippy better!
We're collecting our changelog from pull request descriptions.
If your PR only updates to the latest nightly, you can leave the
`changelog` entry as `none`. Otherwise, please write a short comment
explaining your change.
If your PR fixes an issue, you can add "fixes #issue_number" into this
PR description. This way the issue will be automatically closed when
your PR is merged.
If you added a new lint, here's a checklist for things that will be
checked during review or continuous integration.
- [ ] Followed [lint naming conventions][lint_naming]
- [ ] Added passing UI tests (including committed `.stderr` file)
- [ ] `cargo test` passes locally
- [ ] Executed `util/dev update_lints`
- [ ] Added lint documentation
- [ ] Run `cargo fmt`
Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.
Delete this line and everything above before opening your PR -->
changelog: bugfix for long strings as bytes
bors [Tue, 9 Jul 2019 09:10:07 +0000 (09:10 +0000)]
Auto merge of #4262 - bara86:master, r=flip1995
Use empty block instead of unit type for needless return
fixes #4238
changelog: Use empty block instead of unit type for needless return
Thiago Arrais [Mon, 8 Jul 2019 16:12:51 +0000 (13:12 -0300)]
Extract semantic constant
Bara [Mon, 8 Jul 2019 18:45:51 +0000 (20:45 +0200)]
Use empty block instead of unit type for needless return
Jens Hausdorf [Sun, 10 Mar 2019 10:06:19 +0000 (11:06 +0100)]
Avoid reporting string_lit_as_bytes for long strings
Port of @jens1o code ([
b76f939 ][jens1o_commit])
Fixes #1208
[jens1o_commit]: https://github.com/jens1o/rust-clippy/commit/
b76f939ac2efcfe24900c286b3b7713d972d9088
Co-authored-by: Thiago Arrais <thiago.arrais@gmail.com>
Michael Wright [Mon, 8 Jul 2019 05:20:11 +0000 (07:20 +0200)]
Add rustfmt nightly to appveyor install
Michael Wright [Fri, 5 Jul 2019 05:49:19 +0000 (07:49 +0200)]
Work around rustup fallback error on Windows
flip1995 [Thu, 4 Jul 2019 12:35:27 +0000 (14:35 +0200)]
Update documentation to the dev fmt command
Michael Wright [Thu, 4 Jul 2019 04:35:33 +0000 (06:35 +0200)]
Remove format checks from CI scripts again.
Michael Wright [Wed, 3 Jul 2019 05:35:55 +0000 (07:35 +0200)]
Remove format checks from CI script
Michael Wright [Wed, 26 Jun 2019 04:08:33 +0000 (06:08 +0200)]
Improve fmt test failure message
Michael Wright [Tue, 25 Jun 2019 05:30:29 +0000 (07:30 +0200)]
Fix crash on `dev --limit-stderr-length`
Michael Wright [Tue, 25 Jun 2019 04:43:38 +0000 (06:43 +0200)]
Add dev fmt subcommand
bors [Sun, 7 Jul 2019 02:25:07 +0000 (02:25 +0000)]
Auto merge of #4258 - mikerite:fix-breakage-
20190706 , r=Manishearth
Fix breakage due to rust-lang/rust#61988
changelog: none
Michael Wright [Sat, 6 Jul 2019 17:43:34 +0000 (19:43 +0200)]
rustfmt
Michael Wright [Sat, 6 Jul 2019 17:35:08 +0000 (19:35 +0200)]
Address reviews
Michael Wright [Sat, 6 Jul 2019 17:06:49 +0000 (19:06 +0200)]
Fix breakage due to rust-lang/rust#61988
bors [Sat, 6 Jul 2019 07:19:20 +0000 (07:19 +0000)]
Auto merge of #4255 - mikerite:fix-warnings-
20190706 , r=Manishearth
Fix unknown lint warnings
changelog: none
Michael Wright [Sat, 6 Jul 2019 07:15:48 +0000 (09:15 +0200)]
Fix unknown lint warnings
bors [Sat, 6 Jul 2019 06:30:15 +0000 (06:30 +0000)]
Auto merge of #4254 - lzutao:hiridification-62168, r=Manishearth
Rustup HirIdification
Rustup https://github.com/rust-lang/rust/pull/62168
changelog: none
Lzu Tao [Sat, 6 Jul 2019 05:30:11 +0000 (12:30 +0700)]
Remove lint for ONCE_INIT
ONCE_INIT will be deprecated in rust 1.38.0
Lzu Tao [Sat, 6 Jul 2019 04:04:03 +0000 (04:04 +0000)]
Update rustfix tests
Lzu Tao [Sat, 6 Jul 2019 03:52:51 +0000 (10:52 +0700)]
Rename hir::map::local_def_id_from_hir_id to local_def_id
bors [Thu, 4 Jul 2019 08:30:18 +0000 (08:30 +0000)]
Auto merge of #4252 - mikerite:fix-unused-import-
20190704 , r=flip1995
Remove unused import
changelog: none