]> git.lizzy.rs Git - rust.git/log
rust.git
4 years agoMake sure there are no commands in code actions
Aleksey Kladov [Sat, 11 Jul 2020 09:46:31 +0000 (11:46 +0200)]
Make sure there are no commands in code actions

4 years agoMerge #5307
bors[bot] [Sat, 11 Jul 2020 01:42:18 +0000 (01:42 +0000)]
Merge #5307

5307: disable profiling r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agodisable profiling
Aleksey Kladov [Sat, 11 Jul 2020 01:41:52 +0000 (03:41 +0200)]
disable profiling

4 years agoProfiling example
Aleksey Kladov [Sat, 11 Jul 2020 01:39:44 +0000 (03:39 +0200)]
Profiling example

4 years agoMerge #5305
bors[bot] [Sat, 11 Jul 2020 01:05:15 +0000 (01:05 +0000)]
Merge #5305

5305: Profiling tweaks r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoProfiling tweaks
Aleksey Kladov [Sat, 11 Jul 2020 01:04:37 +0000 (03:04 +0200)]
Profiling tweaks

4 years agoMerge #5304
bors[bot] [Fri, 10 Jul 2020 23:39:44 +0000 (23:39 +0000)]
Merge #5304

5304: Don't show error when speculatively reloading workspace r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoDon't show error when speculatively reloading workspace
Aleksey Kladov [Fri, 10 Jul 2020 23:39:06 +0000 (01:39 +0200)]
Don't show error when speculatively reloading workspace

4 years agoMerge #5303
bors[bot] [Fri, 10 Jul 2020 23:31:57 +0000 (23:31 +0000)]
Merge #5303

5303: Speed up completion r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoSpeed up completion
Aleksey Kladov [Fri, 10 Jul 2020 23:26:24 +0000 (01:26 +0200)]
Speed up completion

4 years agoMerge #5302
bors[bot] [Fri, 10 Jul 2020 21:57:56 +0000 (21:57 +0000)]
Merge #5302

5302: Simplify r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoSimplify
Aleksey Kladov [Fri, 10 Jul 2020 21:57:10 +0000 (23:57 +0200)]
Simplify

4 years agoMerge #5301
bors[bot] [Fri, 10 Jul 2020 21:46:02 +0000 (21:46 +0000)]
Merge #5301

5301: Don't spawn notify unnecessary r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoDon't spawn notify unnecessary
Aleksey Kladov [Fri, 10 Jul 2020 21:39:25 +0000 (23:39 +0200)]
Don't spawn notify unnecessary

4 years agoMerge #5300
bors[bot] [Fri, 10 Jul 2020 21:20:36 +0000 (21:20 +0000)]
Merge #5300

5300: Update deps r=matklad a=kjeremy

Bumps tracing to 0.1.16 which reduces monomorphization: https://github.com/rust-analyzer/rust-analyzer/issues/1987#issuecomment-654711560

Co-authored-by: kjeremy <kjeremy@gmail.com>
4 years agoUpdate deps
kjeremy [Fri, 10 Jul 2020 21:14:24 +0000 (17:14 -0400)]
Update deps

4 years agoMerge #5299
bors[bot] [Fri, 10 Jul 2020 20:31:11 +0000 (20:31 +0000)]
Merge #5299

5299: Reload when new example/test/etc is added r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoOptimize VFS processing
Aleksey Kladov [Fri, 10 Jul 2020 20:29:40 +0000 (22:29 +0200)]
Optimize VFS processing

4 years agoSort cargo metadata
Aleksey Kladov [Fri, 10 Jul 2020 20:28:41 +0000 (22:28 +0200)]
Sort cargo metadata

See https://github.com/rust-lang/cargo/issues/8477

We need this to prevent spurious workspace reloads

4 years agoAdd profiling calls
Aleksey Kladov [Fri, 10 Jul 2020 16:53:01 +0000 (18:53 +0200)]
Add profiling calls

4 years agoAlso reload when adding new examples, tests, etc
Aleksey Kladov [Fri, 10 Jul 2020 16:48:39 +0000 (18:48 +0200)]
Also reload when adding new examples, tests, etc

4 years agoMerge #5298
bors[bot] [Fri, 10 Jul 2020 16:22:38 +0000 (16:22 +0000)]
Merge #5298

5298: Better caret placement when filling match arms r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoBetter caret placement when filling match arms
Aleksey Kladov [Fri, 10 Jul 2020 16:22:04 +0000 (18:22 +0200)]
Better caret placement when filling match arms

4 years agoMerge #5297
bors[bot] [Fri, 10 Jul 2020 15:57:18 +0000 (15:57 +0000)]
Merge #5297

5297: Better name r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoBetter name
Aleksey Kladov [Fri, 10 Jul 2020 15:56:55 +0000 (17:56 +0200)]
Better name

4 years agoMerge #5296
bors[bot] [Fri, 10 Jul 2020 15:43:14 +0000 (15:43 +0000)]
Merge #5296

5296: Don't add braces after struct r=matklad a=matklad

Unit structs are a thing

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoDon't add braces after struct
Aleksey Kladov [Fri, 10 Jul 2020 15:42:18 +0000 (17:42 +0200)]
Don't add braces after struct

Unit structs are a thing

4 years agoBetter complete expression keywords
Aleksey Kladov [Fri, 10 Jul 2020 15:41:43 +0000 (17:41 +0200)]
Better complete expression keywords

4 years agoMerge #5295
bors[bot] [Fri, 10 Jul 2020 14:29:37 +0000 (14:29 +0000)]
Merge #5295

5295: Complete params in nested fns r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoComplete params in nested fns
Aleksey Kladov [Fri, 10 Jul 2020 14:29:14 +0000 (16:29 +0200)]
Complete params in nested fns

4 years agoMerge #5294
bors[bot] [Fri, 10 Jul 2020 14:08:36 +0000 (14:08 +0000)]
Merge #5294

5294: Complete parameters more aggressively r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoComplete parameters more aggressively
Aleksey Kladov [Fri, 10 Jul 2020 14:07:12 +0000 (16:07 +0200)]
Complete parameters more aggressively

4 years agoRefresh tests
Aleksey Kladov [Fri, 10 Jul 2020 14:05:01 +0000 (16:05 +0200)]
Refresh tests

4 years agoMerge #5293
bors[bot] [Fri, 10 Jul 2020 13:35:46 +0000 (13:35 +0000)]
Merge #5293

5293: Automatically reload project info on Cargo.toml changes r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoAutomatically reload project info on Cargo.toml changes
Aleksey Kladov [Fri, 10 Jul 2020 13:27:34 +0000 (15:27 +0200)]
Automatically reload project info on Cargo.toml changes

4 years agoMerge #5292
bors[bot] [Fri, 10 Jul 2020 12:47:23 +0000 (12:47 +0000)]
Merge #5292

5292: Goto type definition improvements r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoLook through Arc for goto type definition
Aleksey Kladov [Fri, 10 Jul 2020 12:42:26 +0000 (14:42 +0200)]
Look through Arc for goto type definition

4 years agoSimplify tests
Aleksey Kladov [Fri, 10 Jul 2020 12:39:05 +0000 (14:39 +0200)]
Simplify tests

4 years agoDont expose ID
Aleksey Kladov [Fri, 10 Jul 2020 12:11:31 +0000 (14:11 +0200)]
Dont expose ID

4 years agoRename
Aleksey Kladov [Fri, 10 Jul 2020 12:09:31 +0000 (14:09 +0200)]
Rename

4 years agoGoto type definition works for self
Aleksey Kladov [Fri, 10 Jul 2020 12:08:35 +0000 (14:08 +0200)]
Goto type definition works for self

4 years agoMerge #5286
bors[bot] [Fri, 10 Jul 2020 09:33:29 +0000 (09:33 +0000)]
Merge #5286

5286: Only take first 500 syntax errors r=jonas-schievink a=yihuang

Too many syntax errors make some editor/ide slow, fix #3434.

Co-authored-by: yihuang <yi.codeplayer@gmail.com>
4 years agoOnly take first 500 syntax errors
yihuang [Fri, 10 Jul 2020 07:41:41 +0000 (15:41 +0800)]
Only take first 500 syntax errors

Too many syntax errors make some editor/ide slow, fix #3434.

4 years agoMerge #5288
bors[bot] [Fri, 10 Jul 2020 09:09:09 +0000 (09:09 +0000)]
Merge #5288

5288: Avoid accidently stumping over config values r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoAvoid accidently stumping over config values
Aleksey Kladov [Thu, 9 Jul 2020 22:28:12 +0000 (00:28 +0200)]
Avoid accidently stumping over config values

4 years agoMerge #5285
bors[bot] [Thu, 9 Jul 2020 17:22:16 +0000 (17:22 +0000)]
Merge #5285

5285: Don't mess with cursor position when adding hashes r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoDon't mess with cursor position when adding hashes
Aleksey Kladov [Thu, 9 Jul 2020 17:21:41 +0000 (19:21 +0200)]
Don't mess with cursor position when adding hashes

4 years agoMerge #5284
bors[bot] [Thu, 9 Jul 2020 16:49:44 +0000 (16:49 +0000)]
Merge #5284

5284: Fold struct literals r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoFold struct literals
Aleksey Kladov [Thu, 9 Jul 2020 16:49:17 +0000 (18:49 +0200)]
Fold struct literals

4 years agoMerge #5283
bors[bot] [Thu, 9 Jul 2020 16:28:35 +0000 (16:28 +0000)]
Merge #5283

5283: Arg count mismatch diagnostic: Handle tuple struct/variant ctors r=jonas-schievink a=jonas-schievink

I didn't know `callable_item_signature` was a thing, that makes this really easy.

bors r+

Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
4 years agoarg count mismatch: handle tuple ctors
Jonas Schievink [Thu, 9 Jul 2020 16:24:02 +0000 (18:24 +0200)]
arg count mismatch: handle tuple ctors

4 years agoMerge #5270
bors[bot] [Thu, 9 Jul 2020 15:34:43 +0000 (15:34 +0000)]
Merge #5270

5270: Add argument count mismatch diagnostic r=matklad a=jonas-schievink

Closes https://github.com/rust-analyzer/rust-analyzer/issues/4025.

This currently has one false positive on this line, where `max` is resolved to `Iterator::max` instead of `Ord::max`:

https://github.com/rust-analyzer/rust-analyzer/blob/8aa10c00a4c5b957d459fac5a103cd9688e8dcdd/crates/expect/src/lib.rs#L263

(I have no idea why it thinks that `usize` is an `Iterator`)

TODO:
* [x] Tests
* [x] Improve diagnostic text for method calls

Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
4 years agoAddress review comments
Jonas Schievink [Thu, 9 Jul 2020 15:33:49 +0000 (17:33 +0200)]
Address review comments

4 years agoMerge #5282
bors[bot] [Thu, 9 Jul 2020 14:19:14 +0000 (14:19 +0000)]
Merge #5282

5282: Move diagnostics tests to expect r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoAlways put config first
Aleksey Kladov [Thu, 9 Jul 2020 14:12:53 +0000 (16:12 +0200)]
Always put config first

4 years agoMove diagnostics tests to expect
Aleksey Kladov [Thu, 9 Jul 2020 14:04:29 +0000 (16:04 +0200)]
Move diagnostics tests to expect

4 years agoAdd tests
Jonas Schievink [Thu, 9 Jul 2020 13:52:10 +0000 (15:52 +0200)]
Add tests

4 years agoFix diagnostic for method calls
Jonas Schievink [Thu, 9 Jul 2020 13:51:32 +0000 (15:51 +0200)]
Fix diagnostic for method calls

4 years agoCorrectly pluralize message
Jonas Schievink [Thu, 9 Jul 2020 13:50:53 +0000 (15:50 +0200)]
Correctly pluralize message

4 years agoRemove unnecessary DiagnosticSink handlers
Jonas Schievink [Thu, 9 Jul 2020 13:50:35 +0000 (15:50 +0200)]
Remove unnecessary DiagnosticSink handlers

4 years agoAdd fixmes
Aleksey Kladov [Thu, 9 Jul 2020 13:41:13 +0000 (15:41 +0200)]
Add fixmes

4 years agoSimplify
Aleksey Kladov [Thu, 9 Jul 2020 13:35:52 +0000 (15:35 +0200)]
Simplify

4 years agoCleanup diagnostic conversion code
Aleksey Kladov [Thu, 9 Jul 2020 13:34:37 +0000 (15:34 +0200)]
Cleanup diagnostic conversion code

4 years agoMerge #5281
bors[bot] [Thu, 9 Jul 2020 12:45:24 +0000 (12:45 +0000)]
Merge #5281

5281: Remove insta from ra_ide r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoRemove insta from ra_ide
Aleksey Kladov [Thu, 9 Jul 2020 12:33:57 +0000 (14:33 +0200)]
Remove insta from ra_ide

4 years agoCleanup diagnostics tests
Aleksey Kladov [Thu, 9 Jul 2020 12:33:03 +0000 (14:33 +0200)]
Cleanup diagnostics tests

4 years agoReduce code duplication
Aleksey Kladov [Thu, 9 Jul 2020 11:59:49 +0000 (13:59 +0200)]
Reduce code duplication

4 years agoDon't emit diagnostic if there are type errors
Jonas Schievink [Thu, 9 Jul 2020 10:41:35 +0000 (12:41 +0200)]
Don't emit diagnostic if there are type errors

4 years agoAdd argument count mismatch diagnostic
Jonas Schievink [Wed, 8 Jul 2020 17:58:45 +0000 (19:58 +0200)]
Add argument count mismatch diagnostic

4 years agoMerge #5280
bors[bot] [Thu, 9 Jul 2020 10:15:20 +0000 (10:15 +0000)]
Merge #5280

5280: Re-enable IDE features for incomplete impl blocs r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoRe-enable IDE features for incomplete impl blocs
Aleksey Kladov [Thu, 9 Jul 2020 10:14:26 +0000 (12:14 +0200)]
Re-enable IDE features for incomplete impl blocs

4 years agoMerge #5279
bors[bot] [Thu, 9 Jul 2020 09:48:40 +0000 (09:48 +0000)]
Merge #5279

5279: Simplify r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoSimplify
Aleksey Kladov [Thu, 9 Jul 2020 09:47:27 +0000 (11:47 +0200)]
Simplify

4 years agoMerge #5278
bors[bot] [Thu, 9 Jul 2020 09:01:45 +0000 (09:01 +0000)]
Merge #5278

5278: expect should be a dev dep r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoexpect should be a dev dep
Aleksey Kladov [Thu, 9 Jul 2020 08:59:41 +0000 (10:59 +0200)]
expect should be a dev dep

4 years agoUnify tests
Aleksey Kladov [Thu, 9 Jul 2020 08:58:56 +0000 (10:58 +0200)]
Unify tests

4 years agoMerge #5276
bors[bot] [Thu, 9 Jul 2020 08:34:12 +0000 (08:34 +0000)]
Merge #5276

5276: Streamline r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoNo blank indent
Aleksey Kladov [Thu, 9 Jul 2020 08:33:32 +0000 (10:33 +0200)]
No blank indent

4 years agoPrettier rendering
Aleksey Kladov [Thu, 9 Jul 2020 08:30:47 +0000 (10:30 +0200)]
Prettier rendering

4 years agoStreamline
Aleksey Kladov [Thu, 9 Jul 2020 08:19:37 +0000 (10:19 +0200)]
Streamline

4 years agoReduce API
Aleksey Kladov [Thu, 9 Jul 2020 08:03:28 +0000 (10:03 +0200)]
Reduce API

4 years agoCleanup
Aleksey Kladov [Thu, 9 Jul 2020 07:56:15 +0000 (09:56 +0200)]
Cleanup

4 years agoReduce API
Aleksey Kladov [Thu, 9 Jul 2020 07:42:01 +0000 (09:42 +0200)]
Reduce API

4 years agoRename
Aleksey Kladov [Thu, 9 Jul 2020 07:39:53 +0000 (09:39 +0200)]
Rename

4 years agoMerge #5273
bors[bot] [Wed, 8 Jul 2020 22:11:52 +0000 (22:11 +0000)]
Merge #5273

5273: Refactor hover tests r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoRefactor hover tests
Aleksey Kladov [Wed, 8 Jul 2020 22:07:32 +0000 (00:07 +0200)]
Refactor hover tests

4 years agoSimplify tests
Aleksey Kladov [Wed, 8 Jul 2020 21:06:15 +0000 (23:06 +0200)]
Simplify tests

4 years agobetter language
Aleksey Kladov [Wed, 8 Jul 2020 20:47:50 +0000 (22:47 +0200)]
better language

4 years agoAdd Markup type
Aleksey Kladov [Wed, 8 Jul 2020 20:37:35 +0000 (22:37 +0200)]
Add Markup type

4 years agoMerge #5272
bors[bot] [Wed, 8 Jul 2020 20:03:19 +0000 (20:03 +0000)]
Merge #5272

5272: :arrow_up: deps r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years ago:arrow_up: deps
Aleksey Kladov [Wed, 8 Jul 2020 20:02:54 +0000 (22:02 +0200)]
:arrow_up: deps

4 years agoMerge #5271
bors[bot] [Wed, 8 Jul 2020 18:42:46 +0000 (18:42 +0000)]
Merge #5271

5271: Tidyup hover r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agosimplify
Aleksey Kladov [Wed, 8 Jul 2020 18:26:20 +0000 (20:26 +0200)]
simplify

4 years agoMinimize API
Aleksey Kladov [Wed, 8 Jul 2020 17:58:50 +0000 (19:58 +0200)]
Minimize API

4 years agoDead code
Aleksey Kladov [Wed, 8 Jul 2020 17:54:50 +0000 (19:54 +0200)]
Dead code

4 years agoReduce visibility
Aleksey Kladov [Wed, 8 Jul 2020 17:41:57 +0000 (19:41 +0200)]
Reduce visibility

4 years agoMerge #5266
bors[bot] [Wed, 8 Jul 2020 17:33:03 +0000 (17:33 +0000)]
Merge #5266

5266: Remove relative_path dependency r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
4 years agoRemove relative_path dependency
Aleksey Kladov [Wed, 8 Jul 2020 17:09:42 +0000 (19:09 +0200)]
Remove relative_path dependency

4 years agoRemove unwanted dependency
Aleksey Kladov [Wed, 8 Jul 2020 16:22:57 +0000 (18:22 +0200)]
Remove unwanted dependency

4 years agoDocument failed refactor
Aleksey Kladov [Wed, 8 Jul 2020 16:17:45 +0000 (18:17 +0200)]
Document failed refactor