]>
git.lizzy.rs Git - rust.git/log
Michael Wright [Thu, 4 Jul 2019 04:35:33 +0000 (06:35 +0200)]
Remove format checks from CI scripts again.
Michael Wright [Wed, 3 Jul 2019 05:35:55 +0000 (07:35 +0200)]
Remove format checks from CI script
Michael Wright [Wed, 26 Jun 2019 04:08:33 +0000 (06:08 +0200)]
Improve fmt test failure message
Michael Wright [Tue, 25 Jun 2019 05:30:29 +0000 (07:30 +0200)]
Fix crash on `dev --limit-stderr-length`
Michael Wright [Tue, 25 Jun 2019 04:43:38 +0000 (06:43 +0200)]
Add dev fmt subcommand
bors [Sun, 7 Jul 2019 02:25:07 +0000 (02:25 +0000)]
Auto merge of #4258 - mikerite:fix-breakage-
20190706 , r=Manishearth
Fix breakage due to rust-lang/rust#61988
changelog: none
Michael Wright [Sat, 6 Jul 2019 17:43:34 +0000 (19:43 +0200)]
rustfmt
Michael Wright [Sat, 6 Jul 2019 17:35:08 +0000 (19:35 +0200)]
Address reviews
Michael Wright [Sat, 6 Jul 2019 17:06:49 +0000 (19:06 +0200)]
Fix breakage due to rust-lang/rust#61988
bors [Sat, 6 Jul 2019 07:19:20 +0000 (07:19 +0000)]
Auto merge of #4255 - mikerite:fix-warnings-
20190706 , r=Manishearth
Fix unknown lint warnings
changelog: none
Michael Wright [Sat, 6 Jul 2019 07:15:48 +0000 (09:15 +0200)]
Fix unknown lint warnings
bors [Sat, 6 Jul 2019 06:30:15 +0000 (06:30 +0000)]
Auto merge of #4254 - lzutao:hiridification-62168, r=Manishearth
Rustup HirIdification
Rustup https://github.com/rust-lang/rust/pull/62168
changelog: none
Lzu Tao [Sat, 6 Jul 2019 05:30:11 +0000 (12:30 +0700)]
Remove lint for ONCE_INIT
ONCE_INIT will be deprecated in rust 1.38.0
Lzu Tao [Sat, 6 Jul 2019 04:04:03 +0000 (04:04 +0000)]
Update rustfix tests
Lzu Tao [Sat, 6 Jul 2019 03:52:51 +0000 (10:52 +0700)]
Rename hir::map::local_def_id_from_hir_id to local_def_id
bors [Thu, 4 Jul 2019 08:30:18 +0000 (08:30 +0000)]
Auto merge of #4252 - mikerite:fix-unused-import-
20190704 , r=flip1995
Remove unused import
changelog: none
Michael Wright [Thu, 4 Jul 2019 04:49:31 +0000 (06:49 +0200)]
Remove unused import
bors [Wed, 3 Jul 2019 20:22:46 +0000 (20:22 +0000)]
Auto merge of #4251 - matthiaskrgr:rustup_10, r=Manishearth
rustup https://github.com/rust-lang/rust/pull/61995
changelog: none
Matthias Krüger [Wed, 3 Jul 2019 16:00:35 +0000 (18:00 +0200)]
rustup https://github.com/rust-lang/rust/pull/61995
bors [Wed, 3 Jul 2019 07:03:49 +0000 (07:03 +0000)]
Auto merge of #4250 - mikerite:fix-3992, r=phansch
Fix allow bug in `trivially_copy_pass_by_ref`
Closes #3992
changelog: Fix allow bug in `trivially_copy_pass_by_ref`
bors [Wed, 3 Jul 2019 06:36:32 +0000 (06:36 +0000)]
Auto merge of #4249 - matthiaskrgr:license_url, r=phansch
readme: fix urls in the license
The ">" at the end was detected as part of the url and caused it to 404.
changelog: none
Michael Wright [Wed, 3 Jul 2019 05:15:21 +0000 (07:15 +0200)]
Fix allow bug in `trivially_copy_pass_by_ref`
Closes #3992
Matthias Krüger [Tue, 2 Jul 2019 18:06:18 +0000 (20:06 +0200)]
readme: fix urls in the license
bors [Tue, 2 Jul 2019 07:25:21 +0000 (07:25 +0000)]
Auto merge of #4246 - mikerite:fix-4244, r=flip1995
Fix `match_same_arms` false negative
Closes #4244
changelog: Fix `match_same_arms` false negative
Michael Wright [Tue, 2 Jul 2019 06:08:28 +0000 (08:08 +0200)]
Fix `match_same_arms` false negative
Closes #4244
bors [Mon, 1 Jul 2019 13:58:48 +0000 (13:58 +0000)]
Auto merge of #4245 - flip1995:ice_4121, r=matthiaskrgr
Test for melted ICE #4121
resolves #4121
r? @matthiaskrgr
changelog: none
flip1995 [Mon, 1 Jul 2019 13:56:06 +0000 (15:56 +0200)]
Reenable cargo and rls tests in travis
flip1995 [Mon, 1 Jul 2019 13:53:48 +0000 (15:53 +0200)]
Test for melted ICE #4121
bors [Mon, 1 Jul 2019 08:10:25 +0000 (08:10 +0000)]
Auto merge of #4243 - mikerite:fix-4058, r=flip1995
Fix `never_loop` false positive
Closes #4058
changelog: none
bors [Mon, 1 Jul 2019 07:41:33 +0000 (07:41 +0000)]
Auto merge of #4222 - jfrikker:try_err, r=flip1995
Adding try_err lint
changelog: Adds the "try_err" lint, which catches instances of the following: Err(x)?
fixes #4212
Michael Wright [Mon, 1 Jul 2019 05:16:32 +0000 (07:16 +0200)]
Fix `never_loop` false positive
Closes #4058
Joe Frikker [Sun, 30 Jun 2019 22:28:12 +0000 (18:28 -0400)]
Running rustfmt on test
bors [Sun, 30 Jun 2019 13:14:38 +0000 (13:14 +0000)]
Auto merge of #4240 - alex:uninit-intrinsic-prep, r=Manishearth
Removed use of intrinsics::uninit from tests.
This is in preperation for https://github.com/rust-lang/rust/pull/62150
Also allows deprecations in preperations for intrinsics::init being deprecated, which is a planned future step.
changelog: none
Alex Gaynor [Sat, 29 Jun 2019 13:34:42 +0000 (09:34 -0400)]
Removed use of intrinsics::uninit from tests.
This is in preperation for https://github.com/rust-lang/rust/pull/62150
Also allows deprecations in preperations for intrinsics::init being deprecated, which is a planned future step.
bors [Tue, 25 Jun 2019 22:35:35 +0000 (22:35 +0000)]
Auto merge of #4235 - Manishearth:rustup, r=Manishearth
Rustup to
5f9c0448dde167128d668da4555879f64e56af1d
Fixes fallout from https://github.com/rust-lang/rust/pull/62091/files
changelog: none
Manish Goregaokar [Tue, 25 Jun 2019 21:41:10 +0000 (14:41 -0700)]
fmt
Manish Goregaokar [Tue, 25 Jun 2019 21:34:47 +0000 (14:34 -0700)]
Remove a hir_to_node_id
Manish Goregaokar [Tue, 25 Jun 2019 21:34:07 +0000 (14:34 -0700)]
find_by_hir_id -> find
Manish Goregaokar [Tue, 25 Jun 2019 21:33:51 +0000 (14:33 -0700)]
get_parent_node_by_hir_id -> get_parent_node
Joe Frikker [Tue, 25 Jun 2019 01:28:46 +0000 (21:28 -0400)]
Making try_err machine applicable
bors [Mon, 24 Jun 2019 16:27:01 +0000 (16:27 +0000)]
Auto merge of #4230 - flip1995:unsugar_if, r=Manishearth
Replace `unsugar_if` function with `is_if` function
cc https://github.com/rust-lang/rust-clippy/pull/4123#discussion_r296581719
changelog: none
r? @Manishearth
flip1995 [Mon, 24 Jun 2019 07:51:19 +0000 (09:51 +0200)]
Simplify unsugar_if to just an if expr check
flip1995 [Mon, 24 Jun 2019 07:39:12 +0000 (09:39 +0200)]
Remove ast:: prefix from types
bors [Mon, 24 Jun 2019 05:21:52 +0000 (05:21 +0000)]
Auto merge of #4123 - Centril:rustup-let-chains-ast, r=Manishearth
Fix fallout from rust-lang/rust PR 60861
Fixes incoming breakage for unlanded https://github.com/rust-lang/rust/pull/60861.
Tests are passing locally; the Rust PR now needs to land first.
@Manishearth also says we'll want to split out to a `collapsible_if_let` once we have let-chains working in Rust nightly or something.
Mazdak Farrokhzad [Mon, 24 Jun 2019 05:20:52 +0000 (07:20 +0200)]
Put 'if let' back into comment.
Mazdak Farrokhzad [Mon, 24 Jun 2019 02:54:23 +0000 (04:54 +0200)]
Pacify rustfmt.
Mazdak Farrokhzad [Mon, 24 Jun 2019 02:00:05 +0000 (04:00 +0200)]
Fix dogfood test failures.
Joe Frikker [Sat, 22 Jun 2019 20:34:07 +0000 (16:34 -0400)]
PR comments
Mazdak Farrokhzad [Tue, 21 May 2019 06:17:47 +0000 (08:17 +0200)]
Account for let_chains in collapsible_if ui test cases.
Mazdak Farrokhzad [Tue, 21 May 2019 05:43:43 +0000 (07:43 +0200)]
Fix fallout from rust-lang/rust PR 60861.
Joe Frikker [Wed, 19 Jun 2019 03:22:51 +0000 (23:22 -0400)]
Adding try_err lint
bors [Sat, 22 Jun 2019 09:38:53 +0000 (09:38 +0000)]
Auto merge of #4220 - d-dorazio:4182-needless-return-void-functions, r=flip1995
make needless_return work with void functions
fixes https://github.com/rust-lang/rust-clippy/issues/4181.
changelog: make needless_return work with void functions.
I don't think the failure is related to my changes, but I'm not sure :thinking:
bors [Sat, 22 Jun 2019 08:42:09 +0000 (08:42 +0000)]
Auto merge of #4227 - lzutao:node-pruning, r=flip1995
Fix fallout cause NodeId pruning
Rustup rust-lang/rust#61984
changelog: none
Lzu Tao [Sat, 22 Jun 2019 06:41:16 +0000 (13:41 +0700)]
Fix fallout cause NodeId pruning
Daniele D'Orazio [Fri, 21 Jun 2019 14:47:34 +0000 (16:47 +0200)]
cargo fmt
bors [Fri, 21 Jun 2019 13:47:13 +0000 (13:47 +0000)]
Auto merge of #4225 - jeremystucki:refactoring, r=flip1995
Remove needless lifetimes
changelog: none
Daniele D'Orazio [Fri, 21 Jun 2019 12:46:34 +0000 (14:46 +0200)]
more idiomatic code
bors [Fri, 21 Jun 2019 12:43:15 +0000 (12:43 +0000)]
Auto merge of #3919 - matthiaskrgr:readme_3, r=flip1995
readme: update
Remove the crates.io badge from the readme.
Installing clippy via crates.io is deprecated and rustup should be used instead, thus we should not promote crates.io here.
Don't have clippy::correctness" lint category in bold letters, I think it looks a little off.
flip1995 [Fri, 21 Jun 2019 12:41:52 +0000 (14:41 +0200)]
Remove another unnecessary lifetime
Jeremy Stucki [Fri, 21 Jun 2019 11:31:20 +0000 (13:31 +0200)]
Remove needless lifetimes
Daniele D'Orazio [Thu, 20 Jun 2019 11:44:00 +0000 (13:44 +0200)]
update tests and fix lints in clippy
Daniele D'Orazio [Wed, 19 Jun 2019 12:56:02 +0000 (14:56 +0200)]
make needless_return work with void functions
bors [Fri, 21 Jun 2019 10:33:53 +0000 (10:33 +0000)]
Auto merge of #4223 - mikerite:fix-breakage-2019-06-21, r=flip1995
Fix breakage due to rust-lang/rust#61968
<!--
Thank you for making Clippy better!
We're collecting our changelog from pull request descriptions.
If your PR only updates to the latest nightly, you can leave the
`changelog` entry as `none`. Otherwise, please write a short comment
explaining your change.
If your PR fixes an issue, you can add "fixes #issue_number" into this
PR description. This way the issue will be automatically closed when
your PR is merged.
If you added a new lint, here's a checklist for things that will be
checked during review or continuous integration.
- [ ] Followed [lint naming conventions][lint_naming]
- [ ] Added passing UI tests (including committed `.stderr` file)
- [ ] `cargo test` passes locally
- [ ] Executed `util/dev update_lints`
- [ ] Added lint documentation
- [ ] Run `cargo fmt`
Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.
Delete this line and everything above before opening your PR -->
changelog: none
flip1995 [Fri, 21 Jun 2019 10:32:39 +0000 (12:32 +0200)]
Remove unnecssary lifetime from trait_ref_of_method
Michael Wright [Fri, 21 Jun 2019 06:14:07 +0000 (08:14 +0200)]
Fix breakage due to rust-lang/rust#61968
Matthias Krüger [Thu, 4 Apr 2019 09:28:11 +0000 (11:28 +0200)]
readme: update
Remove the crates.io badge from the readme.
Installing clippy via crates.io is deprecated and rustup should be used instead, thus we should not promote crates.io here.
Don't have the entire clippy::correctness line in bold letters, I think it looks a little off.
bors [Wed, 19 Jun 2019 23:19:51 +0000 (23:19 +0000)]
Auto merge of #4221 - lzutao:redundant-lifetime, r=matthiaskrgr
Fix warnings about unnecessary lifetime bounds
Rustup https://github.com/rust-lang/rust/pull/61172
changelog: none
Lzu Tao [Wed, 19 Jun 2019 18:36:23 +0000 (01:36 +0700)]
Fix warnings about unnecessary lifetime bounds
Rustup https://github.com/rust-lang/rust/pull/61172
bors [Wed, 19 Jun 2019 10:35:28 +0000 (10:35 +0000)]
Auto merge of #4218 - lzutao:rustup, r=phansch
Rustup
changelog: none
Lzu Tao [Wed, 19 Jun 2019 10:16:42 +0000 (17:16 +0700)]
Fix lifetime mismatch between LateContext and Ty
Lzu Tao [Wed, 19 Jun 2019 09:59:25 +0000 (16:59 +0700)]
Fix missing field in ExprKind::Yield
Rustup rust-lang/rust#61941
bors [Wed, 19 Jun 2019 07:57:27 +0000 (07:57 +0000)]
Auto merge of #4210 - dtolnay:division, r=flip1995
Downgrade integer_division to restriction
I believe that this lint falls outside of the scope of opinionated pedantism of the other pedantic lints.
changelog: Downgrade integer_division lint from pedantic to restriction
bors [Wed, 19 Jun 2019 07:19:26 +0000 (07:19 +0000)]
Auto merge of #4217 - Manishearth:clog, r=flip1995
Update changelog headings
1.36 is beta now
changelog: none
flip1995 [Wed, 19 Jun 2019 07:18:19 +0000 (09:18 +0200)]
Unify heading style
Manish Goregaokar [Tue, 18 Jun 2019 22:12:18 +0000 (15:12 -0700)]
Make headings stable
Manish Goregaokar [Tue, 18 Jun 2019 22:09:53 +0000 (15:09 -0700)]
Update changelog
bors [Tue, 18 Jun 2019 18:38:30 +0000 (18:38 +0000)]
Auto merge of #4216 - phansch:replace_nodeset, r=matthiaskrgr
Refactor: Replace NodeSet with HirIdSet
This saves us one HirId -> NodeId conversion.
changelog: none
Philipp Hansch [Tue, 18 Jun 2019 17:45:01 +0000 (19:45 +0200)]
Refactor: Replace NodeSet with HirIdSet
This saves us one HirId -> NodeId conversion.
bors [Tue, 18 Jun 2019 10:05:04 +0000 (10:05 +0000)]
Auto merge of #4215 - matthiaskrgr:rustup_9, r=flip1995
rustup https://github.com/rust-lang/rust/pull/61836/
changelog: none
Matthias Krüger [Tue, 18 Jun 2019 09:15:47 +0000 (11:15 +0200)]
rustup https://github.com/rust-lang/rust/pull/61836/
bors [Mon, 17 Jun 2019 15:18:31 +0000 (15:18 +0000)]
Auto merge of #4214 - d-dorazio:4204-fix-float-cmp-neq, r=flip1995
fix suggestion for floating point inequality
It should be of the form `(a - b).abs() > error` whereas it was `(a - b).abs() < error` that is instead what should be used for equality.
fixes #4204.
changelog: fix suggestion for floating point inequality
Daniele D'Orazio [Mon, 17 Jun 2019 14:42:41 +0000 (16:42 +0200)]
fix suggestion for floating points inequality
It should be of the form `(a - b).abs() > error` whereas it was
`(a - b).abs() < error` that is instead what should be used for equality.
David Tolnay [Sat, 15 Jun 2019 07:11:53 +0000 (00:11 -0700)]
Downgrade integer_division to restriction
bors [Fri, 14 Jun 2019 20:45:56 +0000 (20:45 +0000)]
Auto merge of #4209 - lzutao:TyCtxt-lifetime, r=Manishearth
Fix wrong lifetime of TyCtxt
Rustup rust-lang/rust#61817
changelog: none
Lzu Tao [Fri, 14 Jun 2019 16:47:48 +0000 (23:47 +0700)]
Fix wrong lifetime of TyCtxt
bors [Fri, 14 Jun 2019 12:55:22 +0000 (12:55 +0000)]
Auto merge of #4206 - rust-lang:update_lints, r=phansch
Use replace_region_in_file for creating the lint list
r? @phansch
changelog: none
flip1995 [Fri, 14 Jun 2019 08:36:43 +0000 (10:36 +0200)]
Use replace_region_in_file for creating the lint list
bors [Fri, 14 Jun 2019 08:47:43 +0000 (08:47 +0000)]
Auto merge of #4162 - krk:static-static, r=flip1995
Add lint for statics with explicit static lifetime.
changelog: Add lint for statics with explicit static lifetime, fixes #4138.
flip1995 [Fri, 14 Jun 2019 07:54:34 +0000 (09:54 +0200)]
Restructure rename tests
krk [Thu, 13 Jun 2019 21:54:05 +0000 (23:54 +0200)]
Register rename to the LintStore.
krk [Thu, 13 Jun 2019 21:47:06 +0000 (23:47 +0200)]
Rename REDUNDANT_STATIC_LIFETIME to REDUNDANT_STATIC_LIFETIMES.
Kerem [Wed, 12 Jun 2019 17:57:49 +0000 (19:57 +0200)]
Remove pub from RedundantStaticLifetime.visit_type function.
Co-Authored-By: Philipp Krones <hello@philkrones.com>
krk [Tue, 11 Jun 2019 19:52:18 +0000 (21:52 +0200)]
Rename const_static_lifetime to redundant_static_lifetime.
krk [Tue, 11 Jun 2019 19:32:38 +0000 (21:32 +0200)]
Merge StaticConst and StaticStatic lints into StaticConst.
krk [Mon, 10 Jun 2019 17:25:00 +0000 (19:25 +0200)]
Use RedundantStaticLifetime in StaticStatic.
krk [Mon, 10 Jun 2019 17:01:05 +0000 (19:01 +0200)]
Move type-checking logic in StaticConst to RedundantStaticLifetime.
krk [Sat, 1 Jun 2019 10:10:15 +0000 (12:10 +0200)]
Add lint for statics with explicit static lifetime.
bors [Thu, 13 Jun 2019 08:51:53 +0000 (08:51 +0000)]
Auto merge of #4175 - yaahallo:master, r=oli-obk
Implement better help for clippy-driver
https://github.com/rust-lang/rust-clippy/issues/4173
bors [Thu, 13 Jun 2019 05:01:02 +0000 (05:01 +0000)]
Auto merge of #4201 - mgr-inz-rafal:typos_in_docs, r=matthiaskrgr
Typos and minor grammar corrections
Just some minor grammar issues and typos in documentation.
bors [Wed, 12 Jun 2019 22:54:02 +0000 (22:54 +0000)]
Auto merge of #4200 - lzutao:tyctxt-lifetime, r=matthiaskrgr
Fix wrong lifetime of TyCtxt
Rustup https://github.com/rust-lang/rust/pull/61722
changelog: none