]> git.lizzy.rs Git - rust.git/log
rust.git
3 years agoFix resolution of `crate` paths from within blocks
Jonas Schievink [Tue, 2 Feb 2021 17:02:12 +0000 (18:02 +0100)]
Fix resolution of `crate` paths from within blocks

They resolve to the crate root, not the DefMap's root module (which
can be a block)

3 years agoMerge #7523
bors[bot] [Tue, 2 Feb 2021 15:40:43 +0000 (15:40 +0000)]
Merge #7523

7523: Bump chalk and rustc_lexer r=lnicola a=lnicola

bors r+

Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
3 years agoBump rustc_lexer
Laurențiu Nicola [Tue, 2 Feb 2021 15:13:49 +0000 (17:13 +0200)]
Bump rustc_lexer

3 years agoBump chalk
Laurențiu Nicola [Tue, 2 Feb 2021 15:07:10 +0000 (17:07 +0200)]
Bump chalk

3 years agoMerge #7522
bors[bot] [Tue, 2 Feb 2021 15:27:01 +0000 (15:27 +0000)]
Merge #7522

7522: Use non-deprecated memmap2 crate r=kjeremy a=kjeremy

`cargo audit` complains that `memmap` is unmaintained so switch to
RazrFalcon's maintained version.

Removes yet another edge on winapi

Co-authored-by: kjeremy <kjeremy@gmail.com>
3 years agoUse non-deprecated memmap2 crate
kjeremy [Tue, 2 Feb 2021 15:25:17 +0000 (10:25 -0500)]
Use non-deprecated memmap2 crate

`cargo audit` complains that `memmap` is unmaintained so switch to
RazrFalcon's maintained version.

Removes yet another edge on winapi

3 years agoMerge #7521
bors[bot] [Tue, 2 Feb 2021 15:09:34 +0000 (15:09 +0000)]
Merge #7521

7521: cargo update r=kjeremy a=kjeremy

Pulls in soundness fix from rowan.

Co-authored-by: kjeremy <kjeremy@gmail.com>
3 years agocargo update
kjeremy [Tue, 2 Feb 2021 15:00:34 +0000 (10:00 -0500)]
cargo update

3 years agoMerge #7520
bors[bot] [Tue, 2 Feb 2021 14:59:29 +0000 (14:59 +0000)]
Merge #7520

7520: Show alias underlying type r=lnicola a=lumenian

Closes #7511

Display underlying type in the tooltip:
```rust
pub type SomeAlias = f64
```
instead of:
```rust
pub type SomeAlias
```

Co-authored-by: lumenian <lumenian@gmail.com>
3 years agoShow alias underlying type
lumenian [Tue, 2 Feb 2021 14:47:56 +0000 (17:47 +0300)]
Show alias underlying type

3 years agoMerge #7519
bors[bot] [Tue, 2 Feb 2021 13:09:21 +0000 (13:09 +0000)]
Merge #7519

7519: add useless types to the styleguide r=matklad a=matklad

bors r+

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoadd useless types to the styleguide
Aleksey Kladov [Tue, 2 Feb 2021 12:41:57 +0000 (15:41 +0300)]
add useless types to the styleguide

3 years agoMerge #7518
bors[bot] [Tue, 2 Feb 2021 11:37:45 +0000 (11:37 +0000)]
Merge #7518

7518: Use the right `DefMap` when looking up modules r=jonas-schievink a=jonas-schievink

Fixes the bugs encountered in https://github.com/rust-analyzer/rust-analyzer/pull/7506#issuecomment-771417467

bors r+

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
3 years agoUse the right `DefMap` when looking up modules
Jonas Schievink [Tue, 2 Feb 2021 11:25:13 +0000 (12:25 +0100)]
Use the right `DefMap` when looking up modules

3 years agoMerge #7516
bors[bot] [Tue, 2 Feb 2021 10:47:22 +0000 (10:47 +0000)]
Merge #7516

7516: Revert "Use block_def_map in body lowering" r=jonas-schievink a=jonas-schievink

Reverts rust-analyzer/rust-analyzer#7506

bors r+

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
3 years agoRevert "Use block_def_map in body lowering"
Jonas Schievink [Tue, 2 Feb 2021 10:46:58 +0000 (11:46 +0100)]
Revert "Use block_def_map in body lowering"

3 years agoMerge #7514
bors[bot] [Mon, 1 Feb 2021 20:57:26 +0000 (20:57 +0000)]
Merge #7514

7514: Only allow one proc-macro process r=edwin0cheng a=edwin0cheng

cc @lnicola

bors r+

Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
3 years agoOnly allow one proc-macro process
Edwin Cheng [Mon, 1 Feb 2021 20:55:17 +0000 (04:55 +0800)]
Only allow one proc-macro process

3 years agoMerge #7512
bors[bot] [Mon, 1 Feb 2021 19:25:00 +0000 (19:25 +0000)]
Merge #7512

7512: Reap proc macro server instances r=lnicola a=lnicola

Fixes #7510, but not the root cause.

Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
3 years agoReap proc macro server instances
Laurențiu Nicola [Mon, 1 Feb 2021 19:24:09 +0000 (21:24 +0200)]
Reap proc macro server instances

3 years agoMerge #7509
bors[bot] [Mon, 1 Feb 2021 18:20:53 +0000 (18:20 +0000)]
Merge #7509

7509: Improve nvim-lsp setup instructions r=lnicola a=lnicola

bors r+

Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
3 years agoImprove nvim-lsp setup instructions
Laurențiu Nicola [Mon, 1 Feb 2021 18:20:15 +0000 (20:20 +0200)]
Improve nvim-lsp setup instructions

3 years agoMerge #7508
bors[bot] [Mon, 1 Feb 2021 16:41:52 +0000 (16:41 +0000)]
Merge #7508

7508: Don't filter code suggestions on Applicability r=lnicola a=CryZe

I've noticed that there are various suggestions that rust-analyzer seems to filter out, even if they make sense.

Here's an example of where it seems like there should be a suggestion, but there isn't:

![https://i.imgur.com/wsjM6iz.png](https://i.imgur.com/wsjM6iz.png)

It turns out that this specific suggestion is not considered `MachineApplicable`, which are the only suggestions that rust-analyzer accepts. However if you read the documentation for `MachineApplicable`,

[Source](https://github.com/rust-lang/rust/blob/b3897e3d1302391ed02efbac1dce8073646b8173/compiler/rustc_lint_defs/src/lib.rs#L27-L29)
```rust
/// The suggestion is definitely what the user intended. This suggestion should be
/// automatically applied.
MachineApplicable,
```

then you realize that these are specifically only those suggestions that rust-analyzer could even automatically apply (in some distant future, behind some setting or command or so). Other suggestions that may have some semantic impact do not use `MachineApplicable`. So all other suggestions are still intended to be suggested to the user, just not automatically applied without the user being consulted.

[Source](https://github.com/rust-lang/rust/blob/b3897e3d1302391ed02efbac1dce8073646b8173/compiler/rustc_lint_defs/src/lib.rs#L22-L24)
```rust
/// All suggestions are marked with an `Applicability`. Tools use the applicability of a suggestion
/// to determine whether it should be automatically applied or if the user should be consulted
/// before applying the suggestion.
```

So with that in mind, rust-analyzer should almost definitely not filter out `MaybeIncorrect` (which honestly is named horribly, it just means that it's a semantic change, not just a syntactical one).

Then there's `HasPlaceholders` which basically is just another semantic one, but with placeholders. The user will have to make some adjustments, but the suggestion still is perfectly valid. rust-analyzer could probably detect those placeholders and put proper "tab through" markers there for the IDE, but that's not necessary for now.

Then the last one is `Unspecified` which is so unknown that I don't even know how to judge it, meaning that the suggestion should probably also just be suggested to the user and then they can decide.

So with all that in mind, I'm proposing to get rid of the check for Applicability entirely.

Co-authored-by: Christopher Serr <christopher.serr@gmail.com>
3 years agoUpdate Test Data
Christopher Serr [Mon, 1 Feb 2021 16:36:51 +0000 (17:36 +0100)]
Update Test Data

3 years agoDon't filter code suggestions on Applicability
Christopher Serr [Mon, 1 Feb 2021 15:57:04 +0000 (16:57 +0100)]
Don't filter code suggestions on Applicability

I've noticed that there are various suggestions that rust-analyzer seems
to filter out, even if they make sense.

Here's an example of where it seems like there should be a suggestion,
but there isn't:

![https://i.imgur.com/wsjM6iz.png](https://i.imgur.com/wsjM6iz.png)

It turns out that this specific suggestion is not considered
`MachineApplicable`, which are the only suggestions that rust-analyzer
accepts. However if you read the documentation for `MachineApplicable`,

https://github.com/rust-lang/rust/blob/b3897e3d1302391ed02efbac1dce8073646b8173/compiler/rustc_lint_defs/src/lib.rs#L27-L29

then you realize that these are specifically only those suggestions that
rust-analyzer could even automatically apply (in some distant future,
behind some setting or so). Other suggestions that may have some
semantic impact do not use `MachineApplicable`. So all other suggestions
are still intended to be suggested to the user, just not automatically
applied without the user being consulted.

https://github.com/rust-lang/rust/blob/b3897e3d1302391ed02efbac1dce8073646b8173/compiler/rustc_lint_defs/src/lib.rs#L22-L24

So with that in mind, rust-analyzer should almost definitely not filter
out `MaybeIncorrect` (which honestly is named horribly, it just means
that it's a semantic change, not just a syntactical one).

Then there's `HasPlaceholders` which basically is just another semantic
one, but with placeholders. The user will have to make some adjustments,
but the suggestion still is perfectly valid. rust-analyzer could
probably detect those placeholders and put proper "tab through" markers
there for the IDE, but that's not necessary for now.

Then the last one is `Unspecified` which is so unknown that I don't even
know how to judge it, meaning that the suggestion should probably also
just be suggested to the user and then they can decide.

So with all that in mind, I'm proposing to get rid of the check for
Applicability entirely.

3 years agoMerge #7507
bors[bot] [Mon, 1 Feb 2021 14:46:56 +0000 (14:46 +0000)]
Merge #7507

7507: Explain what to do if a release fails r=lnicola a=lnicola

bors r+

Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
3 years agoExplain what to do if a release fails
Laurențiu Nicola [Mon, 1 Feb 2021 14:43:18 +0000 (16:43 +0200)]
Explain what to do if a release fails

3 years agoMerge #7506
bors[bot] [Mon, 1 Feb 2021 12:42:31 +0000 (12:42 +0000)]
Merge #7506

7506: Use block_def_map in body lowering r=jonas-schievink a=jonas-schievink

This makes `lower_block` update the `DefMap` and `ModuleId` used by the expander to the corresponding `block_def_map`. This cleans up a bit of code, but doesn't expose any new features.

bors r+

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
3 years agoShortcut `block_def_map` if there's no inner items
Jonas Schievink [Mon, 1 Feb 2021 12:32:43 +0000 (13:32 +0100)]
Shortcut `block_def_map` if there's no inner items

This previously didn't work, but apparently only because of the wonky
test setup

3 years agoUse body lowering for block_def_map tests
Jonas Schievink [Mon, 1 Feb 2021 12:20:35 +0000 (13:20 +0100)]
Use body lowering for block_def_map tests

Removes the hacky and buggy custom lowering code

3 years agoUse block_def_map in body lowering
Jonas Schievink [Mon, 1 Feb 2021 12:19:55 +0000 (13:19 +0100)]
Use block_def_map in body lowering

3 years agoMerge #7503
bors[bot] [Sun, 31 Jan 2021 20:13:28 +0000 (20:13 +0000)]
Merge #7503

7503: Return inner attributes of outline mod declarations in `attrs_query` r=jonas-schievink a=Veykril

Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
3 years agoMerge #7502
bors[bot] [Sun, 31 Jan 2021 20:04:07 +0000 (20:04 +0000)]
Merge #7502

7502: Honor #![macro_use] in mod source files r=jonas-schievink a=Veykril

Fixes #7501

Since `ItemTree` builds the `RawAttrs` directly we need the special check here as I don't think we can fix this in `RawAttrs` constructor as its solely AST based and we need to touch two different ASTs here.

This just made me realize that `attrs_query` suffers from a similar problem, for example hovering an outline `mod` decl won't show inner docs, only outer ones, #7503.

Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
3 years agoReturn inner attributes of outline mod declarations in `attrs_query`
Lukas Wirth [Sun, 31 Jan 2021 18:53:01 +0000 (19:53 +0100)]
Return inner attributes of outline mod declarations in `attrs_query`

3 years agoHonor #![macro_use] in mod source files
Lukas Wirth [Sun, 31 Jan 2021 18:26:04 +0000 (19:26 +0100)]
Honor #![macro_use] in mod source files

3 years agoMerge #7500
bors[bot] [Sat, 30 Jan 2021 17:12:56 +0000 (17:12 +0000)]
Merge #7500

7500: Fix ast::String::value not properly escaping in some cases r=Veykril a=Veykril

Fixes #7496
bors r+

Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
3 years agoFix ast::String::value not properly escaping in some cases
Lukas Wirth [Sat, 30 Jan 2021 15:31:19 +0000 (16:31 +0100)]
Fix ast::String::value not properly escaping in some cases

3 years agoMerge #7483
bors[bot] [Sat, 30 Jan 2021 15:23:21 +0000 (15:23 +0000)]
Merge #7483

7483: Classify function calls as functions when shadowed by types r=matklad a=Veykril

Fixes #7479

Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
3 years agoMerge #7494
bors[bot] [Sat, 30 Jan 2021 08:13:32 +0000 (08:13 +0000)]
Merge #7494

7494: Simpilfy mbe parsing r=edwin0cheng a=edwin0cheng

bors r+

Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
3 years agoSimpilfy mbe parsing
Edwin Cheng [Sat, 30 Jan 2021 08:12:30 +0000 (16:12 +0800)]
Simpilfy mbe parsing

3 years agoMerge #7493
bors[bot] [Fri, 29 Jan 2021 18:32:10 +0000 (18:32 +0000)]
Merge #7493

7493: Add --print-config-schema to help r=lnicola a=lnicola

bors r+

Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
3 years agoAdd --print-config-schema to help
Laurențiu Nicola [Fri, 29 Jan 2021 18:31:12 +0000 (20:31 +0200)]
Add --print-config-schema to help

3 years agoMerge #7491
bors[bot] [Fri, 29 Jan 2021 16:24:16 +0000 (16:24 +0000)]
Merge #7491

7491: Simplify mbe match error. r=edwin0cheng a=edwin0cheng

Handle parse error in rule parsing instead of matching in mbe.

bors r+

Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
3 years agoSimplify mbe match error.
Edwin Cheng [Fri, 29 Jan 2021 16:21:43 +0000 (00:21 +0800)]
Simplify mbe match error.

Handle parse error in rule parsing instead of match in mbe

3 years agoMerge #7490
bors[bot] [Fri, 29 Jan 2021 15:13:48 +0000 (15:13 +0000)]
Merge #7490

7490: cargo update r=kjeremy a=kjeremy

Co-authored-by: kjeremy <kjeremy@gmail.com>
3 years agocargo update
kjeremy [Fri, 29 Jan 2021 15:12:39 +0000 (10:12 -0500)]
cargo update

3 years agoPrefer ValueNS when resolving hir path for PathExpressions
Lukas Wirth [Fri, 29 Jan 2021 14:59:52 +0000 (15:59 +0100)]
Prefer ValueNS when resolving hir path for PathExpressions

3 years agoMerge #7489
bors[bot] [Fri, 29 Jan 2021 13:13:05 +0000 (13:13 +0000)]
Merge #7489

7489: :arrow_up: rowan r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years ago:arrow_up: rowan
Aleksey Kladov [Fri, 29 Jan 2021 13:12:41 +0000 (16:12 +0300)]
:arrow_up: rowan

3 years agoMerge #7488
bors[bot] [Fri, 29 Jan 2021 12:24:38 +0000 (12:24 +0000)]
Merge #7488

7488: Rename mbe_expander for consistency r=edwin0cheng a=edwin0cheng

bors r+

Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
3 years agoRename mbe_expander for consistency
Edwin Cheng [Fri, 29 Jan 2021 12:23:38 +0000 (20:23 +0800)]
Rename mbe_expander for consistency

3 years agoMerge #7487
bors[bot] [Thu, 28 Jan 2021 22:31:34 +0000 (22:31 +0000)]
Merge #7487

7487: Forbid flyimport completions in use statements r=SomeoneToIgnore a=SomeoneToIgnore

Closes #7469

Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
3 years agoForbid flyimport completions in use statements
Kirill Bulatov [Thu, 28 Jan 2021 22:28:54 +0000 (00:28 +0200)]
Forbid flyimport completions in use statements

3 years agoMerge #7486
bors[bot] [Thu, 28 Jan 2021 19:27:59 +0000 (19:27 +0000)]
Merge #7486

7486: :arrow_up: rowan r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years ago:arrow_up: rowan
Aleksey Kladov [Thu, 28 Jan 2021 19:27:35 +0000 (22:27 +0300)]
:arrow_up: rowan

3 years agoMerge #7485
bors[bot] [Thu, 28 Jan 2021 18:34:57 +0000 (18:34 +0000)]
Merge #7485

7485: Fix incorrect `FileId` and remove broken shortcut r=jonas-schievink a=jonas-schievink

Apparently we were using the crate's root file instead of the file
containing the block.

bors r+

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
3 years agoFix incorrect `FileId` and remove broken shortcut
Jonas Schievink [Thu, 28 Jan 2021 18:33:00 +0000 (19:33 +0100)]
Fix incorrect `FileId` and remove broken shortcut

Apparently we were using the crate's root file instead of the file
containing the block.

3 years agoClassify function calls as functions when shadowed by types
Lukas Wirth [Thu, 28 Jan 2021 18:06:33 +0000 (19:06 +0100)]
Classify function calls as functions when shadowed by types

3 years agoMerge #7482
bors[bot] [Thu, 28 Jan 2021 17:55:54 +0000 (17:55 +0000)]
Merge #7482

7482: block_def_map: add a few macro tests r=jonas-schievink a=jonas-schievink

bors r+

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
3 years agoblock_def_map: add a few macro tests
Jonas Schievink [Thu, 28 Jan 2021 17:53:35 +0000 (18:53 +0100)]
block_def_map: add a few macro tests

3 years agoMerge #7412
bors[bot] [Thu, 28 Jan 2021 17:43:51 +0000 (17:43 +0000)]
Merge #7412

7412: Async loading for outdir and proc-macro r=maklad a=edwin0cheng

cc #7328

![Peek 2021-01-24 02-04](https://user-images.githubusercontent.com/11014119/105610083-8f208100-5de8-11eb-8e96-c2d4e349b352.gif)

[Edit]
~~Finding a way to know when the workspace and build data are loaded...~~

[Edit 2]
Not perfect solution, but seem to work now.

Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
3 years agoUpdate lsp-extension.md hash
Edwin Cheng [Thu, 28 Jan 2021 17:32:31 +0000 (01:32 +0800)]
Update lsp-extension.md hash

3 years agoMerge #7481
bors[bot] [Thu, 28 Jan 2021 17:28:58 +0000 (17:28 +0000)]
Merge #7481

7481: Update `original_module` when ascending `DefMap`s r=jonas-schievink a=jonas-schievink

bors r+

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
3 years agoUpdate `original_module` when ascending `DefMap`s
Jonas Schievink [Thu, 28 Jan 2021 17:27:27 +0000 (18:27 +0100)]
Update `original_module` when ascending `DefMap`s

3 years agobug fix
Edwin Cheng [Thu, 28 Jan 2021 17:19:09 +0000 (01:19 +0800)]
bug fix

3 years agoUpdate doc
Edwin Cheng [Thu, 28 Jan 2021 15:33:58 +0000 (23:33 +0800)]
Update doc

3 years agoUpdate vscode for new status
Edwin Cheng [Thu, 28 Jan 2021 15:33:48 +0000 (23:33 +0800)]
Update vscode for new status

3 years agoAsync Loading outdir and proc-macro
Edwin Cheng [Thu, 28 Jan 2021 15:33:02 +0000 (23:33 +0800)]
Async Loading outdir and proc-macro

3 years agoMerge #7480
bors[bot] [Thu, 28 Jan 2021 17:02:24 +0000 (17:02 +0000)]
Merge #7480

7480: ItemTree: Treat items in `MacroStmts` as top-level r=jonas-schievink a=jonas-schievink

bors r+

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
3 years agoItemTree: Treat items in `MacroStmts` as top-level
Jonas Schievink [Thu, 28 Jan 2021 17:00:10 +0000 (18:00 +0100)]
ItemTree: Treat items in `MacroStmts` as top-level

3 years agoMerge #7478
bors[bot] [Thu, 28 Jan 2021 16:25:53 +0000 (16:25 +0000)]
Merge #7478

7478: Simplify heavy tests r=edwin0cheng a=matklad

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoSimplify heavy tests
Aleksey Kladov [Thu, 28 Jan 2021 16:10:48 +0000 (19:10 +0300)]
Simplify heavy tests

Progress notifications are edge triggered, while status is level
triggered. This makes it a hared to misuse signal for the readiness of
the server.

3 years agoMerge #7477
bors[bot] [Thu, 28 Jan 2021 16:00:43 +0000 (16:00 +0000)]
Merge #7477

7477: :arrow_up: cm r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years ago:arrow_up: cm
Aleksey Kladov [Thu, 28 Jan 2021 15:59:54 +0000 (18:59 +0300)]
:arrow_up: cm

3 years agoMerge #7475
bors[bot] [Thu, 28 Jan 2021 14:57:01 +0000 (14:57 +0000)]
Merge #7475

7475: cargo update r=kjeremy a=kjeremy

net -13 crates

Co-authored-by: kjeremy <kjeremy@gmail.com>
3 years agocargo update
kjeremy [Thu, 28 Jan 2021 14:55:34 +0000 (09:55 -0500)]
cargo update

3 years agoMerge #7474
bors[bot] [Thu, 28 Jan 2021 14:08:54 +0000 (14:08 +0000)]
Merge #7474

7474: Make logger-based debugging more pleasant r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoMake logger-based debugging more pleasant
Aleksey Kladov [Thu, 28 Jan 2021 14:04:44 +0000 (17:04 +0300)]
Make logger-based debugging more pleasant

3 years agoMerge #7473
bors[bot] [Thu, 28 Jan 2021 13:49:30 +0000 (13:49 +0000)]
Merge #7473

7473: Use RA_LOG in tests r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoUse RA_LOG in tests
Aleksey Kladov [Thu, 28 Jan 2021 13:49:07 +0000 (16:49 +0300)]
Use RA_LOG in tests

3 years agoMerge #7472
bors[bot] [Thu, 28 Jan 2021 13:01:29 +0000 (13:01 +0000)]
Merge #7472

7472: Easier to debug timeouts in tests r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoEasier to debug timeouts in tests
Aleksey Kladov [Thu, 28 Jan 2021 13:00:33 +0000 (16:00 +0300)]
Easier to debug timeouts in tests

3 years agoMerge #7471
bors[bot] [Thu, 28 Jan 2021 11:29:41 +0000 (11:29 +0000)]
Merge #7471

7471: Force XCode version r=lnicola a=lnicola

Pin an Xcode version in the release workflow to avoid:

```
Run SDKROOT=$(xcrun -sdk macosx11.0 --show-sdk-path) MACOSX_DEPLOYMENT_TARGET=$(xcrun -sdk macosx11.0 --show-sdk-platform-version) cargo xtask dist
xcodebuild: error: SDK "macosx11.0" cannot be located.
xcodebuild: error: SDK "macosx11.0" cannot be located.
xcrun: error: unable to lookup item 'Path' in SDK 'macosx11.0'
xcodebuild: error: SDK "macosx11.0" cannot be located.
xcodebuild: error: SDK "macosx11.0" cannot be located.
xcrun: error: unable to lookup item 'PlatformVersion' in SDK 'macosx11.0'
```

Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
3 years agoForce XCode version
Laurențiu Nicola [Thu, 28 Jan 2021 09:48:23 +0000 (11:48 +0200)]
Force XCode version

3 years agoMerge #7468
bors[bot] [Wed, 27 Jan 2021 21:35:57 +0000 (21:35 +0000)]
Merge #7468

7468: Enable fill_match_arms in macros r=Veykril a=Veykril

Fixes #3936

The indentation is a bit off, but I don't think it's worth trying to fix that up until we have a proper formatting thing set up, as this most likely requires some hand picked specializing making the implementation worse to read(Assuming this can even be fixed for all cases by hardcoding indentation fixes).

bors r+

Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
3 years agoEnable fill_match_arms in macros
Lukas Wirth [Wed, 27 Jan 2021 21:32:40 +0000 (22:32 +0100)]
Enable fill_match_arms in macros

3 years agoMerge #7466
bors[bot] [Wed, 27 Jan 2021 18:17:54 +0000 (18:17 +0000)]
Merge #7466

7466: Fix legacy macro resolution in block expressions r=jonas-schievink a=jonas-schievink

bors r+

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
3 years agoFix legacy macro resolution in block expressions
Jonas Schievink [Wed, 27 Jan 2021 18:16:29 +0000 (19:16 +0100)]
Fix legacy macro resolution in block expressions

3 years agoMerge #7451
bors[bot] [Wed, 27 Jan 2021 15:48:35 +0000 (15:48 +0000)]
Merge #7451

7451: rust-analyzer.files.excludeDirs r=matklad a=matklad

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoMerge #7465
bors[bot] [Wed, 27 Jan 2021 14:40:57 +0000 (14:40 +0000)]
Merge #7465

7465: Only hide parameter hints for path, field and methodcall expressions r=SomeoneToIgnore a=Veykril

Doing this check for other expressions makes little sense to me.

Fixes #7458

Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
3 years agoOnly hide parameter hints for path, field and methodcall expressions
Lukas Wirth [Wed, 27 Jan 2021 13:20:58 +0000 (14:20 +0100)]
Only hide parameter hints for path, field and methodcall expressions

3 years agoMerge #7464
bors[bot] [Wed, 27 Jan 2021 13:26:18 +0000 (13:26 +0000)]
Merge #7464

7464: Export `CARGO` for proc. macros r=jonas-schievink a=jonas-schievink

Fixes https://github.com/rust-analyzer/rust-analyzer/issues/7462

bors r+

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
3 years agoExport `CARGO` for proc. macros
Jonas Schievink [Wed, 27 Jan 2021 13:21:05 +0000 (14:21 +0100)]
Export `CARGO` for proc. macros

3 years agoMerge #7463
bors[bot] [Wed, 27 Jan 2021 12:22:55 +0000 (12:22 +0000)]
Merge #7463

7463: Bump deps r=lnicola a=lnicola

bors r+

Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
3 years agoBump deps
Laurențiu Nicola [Wed, 27 Jan 2021 12:22:19 +0000 (14:22 +0200)]
Bump deps

3 years agoMerge #7461
bors[bot] [Wed, 27 Jan 2021 09:40:52 +0000 (09:40 +0000)]
Merge #7461

7461: Squelch a warning r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoSquelch a warning
Aleksey Kladov [Wed, 27 Jan 2021 09:40:15 +0000 (12:40 +0300)]
Squelch a warning

3 years agoadd more counts
Aleksey Kladov [Wed, 27 Jan 2021 09:16:24 +0000 (12:16 +0300)]
add more counts

3 years agoMerge #7460
bors[bot] [Wed, 27 Jan 2021 09:16:54 +0000 (09:16 +0000)]
Merge #7460

7460: add more counts r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
3 years agoadd more counts
Aleksey Kladov [Wed, 27 Jan 2021 09:16:24 +0000 (12:16 +0300)]
add more counts