]> git.lizzy.rs Git - rust.git/log
rust.git
4 years agoMake dec2flt_table compatible with rustfmt
David Tolnay [Sat, 30 Nov 2019 03:38:59 +0000 (19:38 -0800)]
Make dec2flt_table compatible with rustfmt

4 years agoUse recursion_limit for const eval stack limit
cad97 [Mon, 25 Nov 2019 02:09:37 +0000 (21:09 -0500)]
Use recursion_limit for const eval stack limit

4 years agoRollup merge of #66847 - dtolnay:_fmt, r=joshtriplett
David Tolnay [Sat, 30 Nov 2019 02:46:09 +0000 (18:46 -0800)]
Rollup merge of #66847 - dtolnay:_fmt, r=joshtriplett

Allow any identifier as format arg name

Previously:

```console
error: invalid format string: invalid argument name `_x`
 --> src/main.rs:2:16
  |
2 |     println!("{_x}", _x=0);
  |                ^^ invalid argument name in format string
  |
  = note: argument names cannot start with an underscore
```

Not supporting identifiers starting with underscore appears to have been an arbitrary limitation from 2013 in code that was most likely never reviewed: https://github.com/rust-lang/rust/pull/8245/files#diff-0347868ef389c805e97636623e4a4ea6R277

The error message was dutifully improved in #50610 but is there any reason that leading underscore would be a special case?

This commit updates the format_args parser to accept identifiers with leading underscores.

4 years agoRollup merge of #66820 - dtolnay:fmt3, r=Dylan-DPC
David Tolnay [Sat, 30 Nov 2019 02:46:08 +0000 (18:46 -0800)]
Rollup merge of #66820 - dtolnay:fmt3, r=Dylan-DPC

Format libstd with rustfmt

(Same strategy as #66691.)

This commit applies rustfmt with rust-lang/rust's default settings to files in src/libstd *that are not involved in any currently open PR* to minimize merge conflicts, and are not part of libstd/os (#66818) or libstd/sys (#66819). The list of files involved in open PRs was determined by querying GitHub's GraphQL API [with this script](https://gist.github.com/dtolnay/aa9c34993dc051a4f344d1b10e4487e8).

With the list of files from the script in outstanding_files, the relevant commands were:

    $ find src/libstd -name '*.rs' \
        | xargs rustfmt --edition=2018 --unstable-features --skip-children
    $ rg libstd outstanding_files | xargs git checkout --

Repeating this process several months apart should get us coverage of most of the rest of libstd.

To confirm no funny business:

    $ git checkout $THIS_COMMIT^
    $ git show --pretty= --name-only $THIS_COMMIT \
        | xargs rustfmt --edition=2018 --unstable-features --skip-children
    $ git diff $THIS_COMMIT  # there should be no difference

4 years agoRollup merge of #66819 - dtolnay:fmt2, r=kennytm
David Tolnay [Sat, 30 Nov 2019 02:46:06 +0000 (18:46 -0800)]
Rollup merge of #66819 - dtolnay:fmt2, r=kennytm

Format libstd/sys with rustfmt

(Same strategy as #66691.)

This commit applies rustfmt with rust-lang/rust's default settings to files in src/libstd/sys *that are not involved in any currently open PR* to minimize merge conflicts. The list of files involved in open PRs was determined by querying GitHub's GraphQL API [with this script](https://gist.github.com/dtolnay/aa9c34993dc051a4f344d1b10e4487e8).

With the list of files from the script in outstanding_files, the relevant commands were:

    $ find src/libstd/sys -name '*.rs' \
        | xargs rustfmt --edition=2018 --unstable-features --skip-children
    $ rg libstd/sys outstanding_files | xargs git checkout --

Repeating this process several months apart should get us coverage of most of the rest of the files.

To confirm no funny business:

    $ git checkout $THIS_COMMIT^
    $ git show --pretty= --name-only $THIS_COMMIT \
        | xargs rustfmt --edition=2018 --unstable-features --skip-children
    $ git diff $THIS_COMMIT  # there should be no difference

4 years agoRollup merge of #66818 - dtolnay:fmt1, r=Dylan-DPC
David Tolnay [Sat, 30 Nov 2019 02:46:05 +0000 (18:46 -0800)]
Rollup merge of #66818 - dtolnay:fmt1, r=Dylan-DPC

Format libstd/os with rustfmt

(Same strategy as #66691.)

This commit applies rustfmt with rust-lang/rust's default settings to files in src/libstd/os *that are not involved in any currently open PR* to minimize merge conflicts. The list of files involved in open PRs was determined by querying GitHub's GraphQL API [with this script](https://gist.github.com/dtolnay/aa9c34993dc051a4f344d1b10e4487e8).

With the list of files from the script in outstanding_files, the relevant commands were:

    $ find src/libstd/os -name '*.rs' \
        | xargs rustfmt --edition=2018 --unstable-features --skip-children
    $ rg libstd/os outstanding_files | xargs git checkout --

Repeating this process several months apart should get us coverage of most of the rest of the files.

To confirm no funny business:

    $ git checkout $THIS_COMMIT^
    $ git show --pretty= --name-only $THIS_COMMIT \
        | xargs rustfmt --edition=2018 --unstable-features --skip-children
    $ git diff $THIS_COMMIT  # there should be no difference

4 years agoBless ui test for libstd reformat
David Tolnay [Wed, 27 Nov 2019 19:07:26 +0000 (11:07 -0800)]
Bless ui test for libstd reformat

4 years agoFormat libstd with rustfmt
David Tolnay [Wed, 27 Nov 2019 18:29:00 +0000 (10:29 -0800)]
Format libstd with rustfmt

This commit applies rustfmt with rust-lang/rust's default settings to
files in src/libstd *that are not involved in any currently open PR* to
minimize merge conflicts. THe list of files involved in open PRs was
determined by querying GitHub's GraphQL API with this script:
https://gist.github.com/dtolnay/aa9c34993dc051a4f344d1b10e4487e8

With the list of files from the script in outstanding_files, the
relevant commands were:

    $ find src/libstd -name '*.rs' \
        | xargs rustfmt --edition=2018 --unstable-features --skip-children
    $ rg libstd outstanding_files | xargs git checkout --

Repeating this process several months apart should get us coverage of
most of the rest of libstd.

To confirm no funny business:

    $ git checkout $THIS_COMMIT^
    $ git show --pretty= --name-only $THIS_COMMIT \
        | xargs rustfmt --edition=2018 --unstable-features --skip-children
    $ git diff $THIS_COMMIT  # there should be no difference

4 years agoFormat libstd/sys with rustfmt
David Tolnay [Wed, 27 Nov 2019 18:28:39 +0000 (10:28 -0800)]
Format libstd/sys with rustfmt

This commit applies rustfmt with rust-lang/rust's default settings to
files in src/libstd/sys *that are not involved in any currently open PR*
to minimize merge conflicts. THe list of files involved in open PRs was
determined by querying GitHub's GraphQL API with this script:
https://gist.github.com/dtolnay/aa9c34993dc051a4f344d1b10e4487e8

With the list of files from the script in outstanding_files, the
relevant commands were:

    $ find src/libstd/sys -name '*.rs' \
        | xargs rustfmt --edition=2018 --unstable-features --skip-children
    $ rg libstd/sys outstanding_files | xargs git checkout --

Repeating this process several months apart should get us coverage of
most of the rest of the files.

To confirm no funny business:

    $ git checkout $THIS_COMMIT^
    $ git show --pretty= --name-only $THIS_COMMIT \
        | xargs rustfmt --edition=2018 --unstable-features --skip-children
    $ git diff $THIS_COMMIT  # there should be no difference

4 years agoFormat libstd/os with rustfmt
David Tolnay [Wed, 27 Nov 2019 18:28:21 +0000 (10:28 -0800)]
Format libstd/os with rustfmt

This commit applies rustfmt with rust-lang/rust's default settings to
files in src/libstd/os *that are not involved in any currently open PR*
to minimize merge conflicts. THe list of files involved in open PRs was
determined by querying GitHub's GraphQL API with this script:
https://gist.github.com/dtolnay/aa9c34993dc051a4f344d1b10e4487e8

With the list of files from the script in outstanding_files, the
relevant commands were:

    $ find src/libstd/os -name '*.rs' \
        | xargs rustfmt --edition=2018 --unstable-features --skip-children
    $ rg libstd/os outstanding_files | xargs git checkout --

Repeating this process several months apart should get us coverage of
most of the rest of the files.

To confirm no funny business:

    $ git checkout $THIS_COMMIT^
    $ git show --pretty= --name-only $THIS_COMMIT \
        | xargs rustfmt --edition=2018 --unstable-features --skip-children
    $ git diff $THIS_COMMIT  # there should be no difference

4 years agocheck.rs: inline a constant
Mazdak Farrokhzad [Sat, 30 Nov 2019 02:30:49 +0000 (03:30 +0100)]
check.rs: inline a constant

4 years agoAuto merge of #66873 - RalfJung:miri-args, r=dtolnay
bors [Sat, 30 Nov 2019 02:12:19 +0000 (02:12 +0000)]
Auto merge of #66873 - RalfJung:miri-args, r=dtolnay

really_init cmdline args on Miri

r? @joshtriplett

Closes #66862.

4 years agomove UnstableFeatures -> rustc_feature
Mazdak Farrokhzad [Sat, 30 Nov 2019 01:50:47 +0000 (02:50 +0100)]
move UnstableFeatures -> rustc_feature

4 years agoinline two explanation constants
Mazdak Farrokhzad [Sat, 30 Nov 2019 01:40:28 +0000 (02:40 +0100)]
inline two explanation constants

4 years agobuiltin_attrs.rs -> rustc_feature
Mazdak Farrokhzad [Sat, 30 Nov 2019 01:34:18 +0000 (02:34 +0100)]
builtin_attrs.rs -> rustc_feature

4 years agomove is_builtin_attr to syntax::attr
Mazdak Farrokhzad [Sat, 30 Nov 2019 01:20:07 +0000 (02:20 +0100)]
move is_builtin_attr to syntax::attr

4 years agobuiltin_attrs: inline some strings
Mazdak Farrokhzad [Sat, 30 Nov 2019 01:03:32 +0000 (02:03 +0100)]
builtin_attrs: inline some strings

4 years agosimplify gated cfgs logic
Mazdak Farrokhzad [Sat, 30 Nov 2019 00:57:53 +0000 (01:57 +0100)]
simplify gated cfgs logic

4 years agomove AttributeTemplate to builtin_attrs
Mazdak Farrokhzad [Fri, 29 Nov 2019 23:56:46 +0000 (00:56 +0100)]
move AttributeTemplate to builtin_attrs

4 years agomove Stability to rustc_feature
Mazdak Farrokhzad [Fri, 29 Nov 2019 23:39:51 +0000 (00:39 +0100)]
move Stability to rustc_feature

4 years agorustc: move mir::SourceScopeLocalData to a field of SourceScopeData.
Eduard-Mihai Burtescu [Tue, 26 Nov 2019 20:17:35 +0000 (22:17 +0200)]
rustc: move mir::SourceScopeLocalData to a field of SourceScopeData.

4 years agorustc_mir: fix inliner to also copy over source_scope_local_data.
Eduard-Mihai Burtescu [Tue, 26 Nov 2019 17:55:32 +0000 (19:55 +0200)]
rustc_mir: fix inliner to also copy over source_scope_local_data.

4 years agorustc: move MIR source_scope_local_data's ClearCrossCrate to be around elements.
Eduard-Mihai Burtescu [Tue, 26 Nov 2019 17:55:03 +0000 (19:55 +0200)]
rustc: move MIR source_scope_local_data's ClearCrossCrate to be around elements.

4 years agointroduce crate rustc_feature and move active, accepted, and removed to it
Mazdak Farrokhzad [Fri, 29 Nov 2019 23:23:38 +0000 (00:23 +0100)]
introduce crate rustc_feature and move active, accepted, and removed to it

4 years agorustc_typeck: gate AnonConst's generics on feature(const_generics).
Eduard-Mihai Burtescu [Fri, 29 Nov 2019 23:15:15 +0000 (01:15 +0200)]
rustc_typeck: gate AnonConst's generics on feature(const_generics).

4 years agorustc: fix ty::Const::eval's handling of inference variables.
Eduard-Mihai Burtescu [Fri, 29 Nov 2019 23:13:47 +0000 (01:13 +0200)]
rustc: fix ty::Const::eval's handling of inference variables.

4 years agoAdd explanation message for E0203
Nixon [Fri, 29 Nov 2019 22:16:26 +0000 (22:16 +0000)]
Add explanation message for E0203

4 years agoAuto merge of #66879 - RalfJung:rollup-nprxpzi, r=RalfJung
bors [Fri, 29 Nov 2019 22:00:28 +0000 (22:00 +0000)]
Auto merge of #66879 - RalfJung:rollup-nprxpzi, r=RalfJung

Rollup of 11 pull requests

Successful merges:

 - #66379 (Rephrase docs in for ptr)
 - #66589 (Draw vertical lines correctly in compiler error messages)
 - #66613 (Allow customising ty::TraitRef's printing behavior)
 - #66766 (Panic machinery comments and tweaks)
 - #66791 (Handle GlobalCtxt directly from librustc_interface query system)
 - #66793 (Record temporary static references in generator witnesses)
 - #66808 (Cleanup error code)
 - #66826 (Clarifies how to tag users for assigning PRs)
 - #66837 (Clarify `{f32,f64}::EPSILON` docs)
 - #66844 (Miri: do not consider memory allocated by caller_location leaked)
 - #66872 (Minor documentation fix)

Failed merges:

r? @ghost

4 years agoRollup merge of #66872 - Mikotochan:patch-1, r=jonas-schievink
Ralf Jung [Fri, 29 Nov 2019 21:57:44 +0000 (22:57 +0100)]
Rollup merge of #66872 - Mikotochan:patch-1, r=jonas-schievink

Minor documentation fix

Fixed the documentation for any as is a trait rather than a type.

4 years agoRollup merge of #66844 - RalfJung:caller-location-leak, r=oli-obk
Ralf Jung [Fri, 29 Nov 2019 21:57:42 +0000 (22:57 +0100)]
Rollup merge of #66844 - RalfJung:caller-location-leak, r=oli-obk

Miri: do not consider memory allocated by caller_location leaked

Fixes https://github.com/rust-lang/miri/issues/1071

r? @oli-obk

I am not sure if this is the best approach, but it certainly is the easiest.

4 years agoRollup merge of #66837 - ohadravid:epsilon-doc, r=dtolnay
Ralf Jung [Fri, 29 Nov 2019 21:57:41 +0000 (22:57 +0100)]
Rollup merge of #66837 - ohadravid:epsilon-doc, r=dtolnay

Clarify `{f32,f64}::EPSILON` docs

The doc for `EPSILON` says:
>  This is the difference between `1.0` and the next **largest** representable number.

Which is a bit unclear.

[Wikipedia](https://en.wikipedia.org/wiki/Machine_epsilon) says
> Machine epsilon is defined as the difference between 1 and the next **larger** floating point number

So this PR update the docs to match the Wikipedia version.

The original PR also has this in a [comment](https://github.com/rust-lang/rust/pull/50919#discussion_r192600209).

4 years agoRollup merge of #66826 - mlodato517:mlodato517-clarify-pr-message-assigner, r=Dylan-DPC
Ralf Jung [Fri, 29 Nov 2019 21:57:39 +0000 (22:57 +0100)]
Rollup merge of #66826 - mlodato517:mlodato517-clarify-pr-message-assigner, r=Dylan-DPC

Clarifies how to tag users for assigning PRs

Clarifies language of where to put `r?` text to assign a particular user. Mostly a follow up of [this discussion](https://github.com/rust-lang/rust/pull/66797#issuecomment-559153444).

4 years agoRollup merge of #66808 - GuillaumeGomez:cleanup-err-code-3, r=Dylan-DPC
Ralf Jung [Fri, 29 Nov 2019 21:57:38 +0000 (22:57 +0100)]
Rollup merge of #66808 - GuillaumeGomez:cleanup-err-code-3, r=Dylan-DPC

Cleanup error code

r? @Dylan-DPC

4 years agoRollup merge of #66793 - matthewjasper:record-static-refs, r=cramertj
Ralf Jung [Fri, 29 Nov 2019 21:57:36 +0000 (22:57 +0100)]
Rollup merge of #66793 - matthewjasper:record-static-refs, r=cramertj

Record temporary static references in generator witnesses

Closes #66695

* Record the pointer to static's type in MIR.
* Normalize the static's type (so that constants can be compared correctly).

4 years agoRollup merge of #66791 - cjgillot:arena, r=Mark-Simulacrum
Ralf Jung [Fri, 29 Nov 2019 21:57:34 +0000 (22:57 +0100)]
Rollup merge of #66791 - cjgillot:arena, r=Mark-Simulacrum

Handle GlobalCtxt directly from librustc_interface query system

This PR constructs the `GlobalCtxt` as a member of the `Queries` in librustc_interface.
This simplifies the code to construct it, at the expense of added complexity in the query control flow.
This allows to handle the arenas directly from librustc_interface.

Based on #66707

r? @Zoxc

4 years agoRollup merge of #66766 - RalfJung:panic-comments, r=SimonSapin
Ralf Jung [Fri, 29 Nov 2019 21:57:33 +0000 (22:57 +0100)]
Rollup merge of #66766 - RalfJung:panic-comments, r=SimonSapin

Panic machinery comments and tweaks

This is mostly more comments, but I also renamed some things:
* `BoxMeUp::box_me_up` is not terribly descriptive, and since this is a "take"-style method (the argument is `&mut self` but the return type is fully owned, even though you can't tell from the type) I chose a name involving "take".
* `continue_panic_fmt` was very confusing as it was entirely unclear what was being continued -- for some time I thought "continue" might be the same as "resume" for a panic, but that's something entirely different. So I renamed this to `begin_panic_handler`, matching the `begin_panic*` theme of the other entry points.

r? @Dylan-DPC @SimonSapin

4 years agoRollup merge of #66613 - Areredify:trait-ref-print, r=eddyb
Ralf Jung [Fri, 29 Nov 2019 21:57:31 +0000 (22:57 +0100)]
Rollup merge of #66613 - Areredify:trait-ref-print, r=eddyb

Allow customising ty::TraitRef's printing behavior

This pr allows to explicitly choose which representation of `TraitRef` (`<T as Trait<U>>` or `Trait<U>`) you want to print. `Debug` and `Display` representations of `TraitRef` now match.

Closes #59188.

4 years agoRollup merge of #66589 - TheSamsa:master, r=Dylan-DPC
Ralf Jung [Fri, 29 Nov 2019 21:57:30 +0000 (22:57 +0100)]
Rollup merge of #66589 - TheSamsa:master, r=Dylan-DPC

Draw vertical lines correctly in compiler error messages

... with multiline annotations correctly when non-1space unicode characters are to the left

For this we use the correct calculation of the 'left' identation

closes #66552

4 years agoRollup merge of #66379 - CreepySkeleton:patch-1, r=RalfJung
Ralf Jung [Fri, 29 Nov 2019 21:57:28 +0000 (22:57 +0100)]
Rollup merge of #66379 - CreepySkeleton:patch-1, r=RalfJung

Rephrase docs in for ptr

These methods can be supplied with NULL just fine, this is the whole point of `Option<&T>` return type.

4 years agoSimplifyArmIdentity only for locals with the same type
Tomasz Miąsko [Fri, 29 Nov 2019 00:00:00 +0000 (00:00 +0000)]
SimplifyArmIdentity only for locals with the same type

Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
4 years agoreally_init cmdline args on Miri
Ralf Jung [Fri, 29 Nov 2019 19:07:55 +0000 (20:07 +0100)]
really_init cmdline args on Miri

4 years agoMinor documentation fix
Mikotochan [Fri, 29 Nov 2019 18:47:16 +0000 (20:47 +0200)]
Minor documentation fix

Fixed the documentation for any as is a trait rather than a type.

4 years agoAuto merge of #66321 - ninjasource:async-fn-resume-after-completion, r=oli-obk
bors [Fri, 29 Nov 2019 18:11:33 +0000 (18:11 +0000)]
Auto merge of #66321 - ninjasource:async-fn-resume-after-completion, r=oli-obk

Async fn resume after completion

#65419 -- Attempting to run an async fn after completion mentions generators
Not yet ready for review - work in progress
Just need to run the tests on a proper build server

4 years agominor fix
Mark Mansi [Fri, 29 Nov 2019 17:07:01 +0000 (11:07 -0600)]
minor fix

4 years agoremove get_named_span
Mark Mansi [Mon, 25 Nov 2019 18:36:53 +0000 (12:36 -0600)]
remove get_named_span

4 years agorename to AnonRegionFromAsyncFn
Mark Mansi [Mon, 25 Nov 2019 00:47:15 +0000 (18:47 -0600)]
rename to AnonRegionFromAsyncFn

4 years agoimprove lifetime errors with implicit trait object lifetimes
Mark Mansi [Sat, 23 Nov 2019 21:11:35 +0000 (15:11 -0600)]
improve lifetime errors with implicit trait object lifetimes

4 years agoIgnore wasm for panic tests
David Haig [Fri, 29 Nov 2019 15:37:46 +0000 (15:37 +0000)]
Ignore wasm for panic tests

4 years agoAuto merge of #66697 - petrochenkov:nocstore, r=eddyb
bors [Fri, 29 Nov 2019 14:51:59 +0000 (14:51 +0000)]
Auto merge of #66697 - petrochenkov:nocstore, r=eddyb

rustc_metadata: Privatize more things and a couple of other refactorings

This PR continues https://github.com/rust-lang/rust/pull/66496 and hits the point of diminishing returns.
All fields of `CrateRoot` and `CrateMetadata` are privatized.
For read-only fields this certainly makes sense, but for a few fields updateable from outside of `rmeta.rs` (mostly `creader.rs`) it was done mostly for consistency, I can make them `pub(crate)` again if requested.

`cstore.rs` (which became small after #66496) was merged into `creader.rs`.

A few things noticed while making the privacy changes were addressed in the remaining refactoring commits.

Fixes https://github.com/rust-lang/rust/issues/66550
r? @eddyb @Mark-Simulacrum

4 years agoallow customising ty::TraitRef's printing behavior
Mikhail Babenko [Thu, 21 Nov 2019 18:01:14 +0000 (21:01 +0300)]
allow customising ty::TraitRef's printing behavior

fix clippy

allow customising ty::TraitRef's printing behavior

fix clippy

stylistic fix

4 years agoAuto merge of #66645 - RalfJung:dereferenceable, r=pnkfelix
bors [Fri, 29 Nov 2019 11:35:03 +0000 (11:35 +0000)]
Auto merge of #66645 - RalfJung:dereferenceable, r=pnkfelix

remove the 'dereferenceable' attribute from Box

Fixes https://github.com/rust-lang/rust/issues/66600

r? @eddyb @rkruppe

4 years agoAuto merge of #66590 - Aaron1011:fix/real-impl-trait-coherence, r=varkor
bors [Fri, 29 Nov 2019 08:12:43 +0000 (08:12 +0000)]
Auto merge of #66590 - Aaron1011:fix/real-impl-trait-coherence, r=varkor

Apply proper commit from PR #63934

While working on PR #63934, I accidentally reverted to an older version
of the PR while working on a rebase. The PR was then merged, not with
the later, approved changes, but with earlier, unapproved changes.

This PR applies the changes that were *suppoesd* to be mereged in
PR #63934. All of the proper tests appear to have been merged
in PR #63934, so this PR adds no new tests

4 years agoAuto merge of #66547 - leo60228:procfs-fallback, r=dtolnay
bors [Fri, 29 Nov 2019 05:04:51 +0000 (05:04 +0000)]
Auto merge of #66547 - leo60228:procfs-fallback, r=dtolnay

Fallback to .init_array when no arguments are available on glibc Linux

Linux is one of the only platforms where `std::env::args` doesn't work in a cdylib.

4 years agoUse LLVMAddAnalysisPasses instead of Rust's wrapper
Victor Ding [Fri, 29 Nov 2019 03:31:09 +0000 (14:31 +1100)]
Use LLVMAddAnalysisPasses instead of Rust's wrapper

LLVM exposes a C API `LLVMAddAnalysisPasses` and hence Rust's own
wrapper `LLVMRustAddAnalysisPasses` is not needed anymore.

4 years agoAuto merge of #66567 - estebank:suggest-copy, r=Centril
bors [Fri, 29 Nov 2019 00:23:23 +0000 (00:23 +0000)]
Auto merge of #66567 - estebank:suggest-copy, r=Centril

Use structured suggestion when requiring `Copy` constraint in type param

4 years agoAuto merge of #66843 - RalfJung:miri, r=RalfJung
bors [Thu, 28 Nov 2019 20:39:41 +0000 (20:39 +0000)]
Auto merge of #66843 - RalfJung:miri, r=RalfJung

update Miri

Fixes https://github.com/rust-lang/rust/issues/66795

r? @ghost

4 years agorustc: hide HirId's fmt::Debug output from -Z span_free_formats.
Eduard-Mihai Burtescu [Thu, 28 Nov 2019 20:32:43 +0000 (22:32 +0200)]
rustc: hide HirId's fmt::Debug output from -Z span_free_formats.

4 years agoreview comments
Esteban Küber [Sun, 24 Nov 2019 05:44:28 +0000 (21:44 -0800)]
review comments

4 years agoDeduplicate type param constraint suggestion code
Esteban Küber [Wed, 20 Nov 2019 01:11:55 +0000 (17:11 -0800)]
Deduplicate type param constraint suggestion code

4 years agoUse structured suggestion when requiring `Copy` constraint in type param
Esteban Küber [Wed, 20 Nov 2019 00:43:24 +0000 (16:43 -0800)]
Use structured suggestion when requiring `Copy` constraint in type param

4 years agoAllow any identifier as format arg name
David Tolnay [Thu, 28 Nov 2019 18:49:13 +0000 (10:49 -0800)]
Allow any identifier as format arg name

Previously:

    error: invalid format string: invalid argument name `_x`
     --> src/main.rs:2:16
      |
    2 |     println!("{_x}", a=0);
      |                ^^ invalid argument name in format string
      |
      = note: argument names cannot start with an underscore

Not supporting identifiers starting with underscore appears to have been
an arbitrary limitation from 2013 in code that was most likely never
reviewed:
https://github.com/rust-lang/rust/pull/8245/files#diff-0347868ef389c805e97636623e4a4ea6R277

The error message was dutifully improved in #50610 but is there any
reason that leading underscore would be a special case?

This commit updates the format_args parser to accept identifiers with
leading underscores.

4 years agoApply proper commit from PR #63934
Aaron Hill [Wed, 20 Nov 2019 22:15:42 +0000 (17:15 -0500)]
Apply proper commit from PR #63934

While working on PR #63934, I accidentally reverted to an older version
of the PR while working on a rebase. The PR was then merged, not with
the later, approved changes, but with earlier, unapproved changes.

This PR applies the changes that were *suppoesd* to be mereged in
PR #63934. All of the proper tests appear to have been merged
in PR #63934, so this PR adds no new tests

Fixes #66580

4 years agodo not consider memory allocated by caller_location leaked
Ralf Jung [Thu, 28 Nov 2019 18:15:32 +0000 (19:15 +0100)]
do not consider memory allocated by caller_location leaked

4 years agorustc: Move some queries to `rustc_metadata`
Vadim Petrochenkov [Sun, 24 Nov 2019 15:12:02 +0000 (18:12 +0300)]
rustc: Move some queries to `rustc_metadata`

4 years agorustc_metadata: Avoid some side effects during speculative crate resolution
Vadim Petrochenkov [Sun, 24 Nov 2019 12:52:36 +0000 (15:52 +0300)]
rustc_metadata: Avoid some side effects during speculative crate resolution

Namely, `update_extern_crate`.

Also, stop tracking visited crates in `update_extern_crate`, the rank check does the same thing (prevents visiting dependencies if the rank didn't change), but more precisely.

4 years agorustc_metadata: Pass SVH by value
Vadim Petrochenkov [Sun, 24 Nov 2019 12:29:35 +0000 (15:29 +0300)]
rustc_metadata: Pass SVH by value

4 years agorustc_metadata: Move `has_global_allocator` from session to cstore
Vadim Petrochenkov [Sun, 24 Nov 2019 11:37:46 +0000 (14:37 +0300)]
rustc_metadata: Move `has_global_allocator` from session to cstore

4 years agorustc_metadata: Privatize some fields and methods of `CStore`
Vadim Petrochenkov [Sat, 23 Nov 2019 22:25:22 +0000 (01:25 +0300)]
rustc_metadata: Privatize some fields and methods of `CStore`

After it's moved to `creader.rs`

4 years agorustc_metadata: Merge `cstore.rs` into `creader.rs`
Vadim Petrochenkov [Sat, 23 Nov 2019 22:10:12 +0000 (01:10 +0300)]
rustc_metadata: Merge `cstore.rs` into `creader.rs`

4 years agorustc_metadata: Privatize `CrateMetadata::root`
Vadim Petrochenkov [Sat, 23 Nov 2019 21:46:33 +0000 (00:46 +0300)]
rustc_metadata: Privatize `CrateMetadata::root`

4 years agorustc_metadata: Privatize all fields of `CrateRoot`
Vadim Petrochenkov [Sat, 23 Nov 2019 20:46:32 +0000 (23:46 +0300)]
rustc_metadata: Privatize all fields of `CrateRoot`

All of them are read-only

4 years agorustc_metadata: Privatize `CrateMetadata::dep_kind`
Vadim Petrochenkov [Sat, 23 Nov 2019 20:34:17 +0000 (23:34 +0300)]
rustc_metadata: Privatize `CrateMetadata::dep_kind`

4 years agorustc_metadata: Privatize `CrateMetadata::source`
Vadim Petrochenkov [Sat, 23 Nov 2019 20:13:54 +0000 (23:13 +0300)]
rustc_metadata: Privatize `CrateMetadata::source`

4 years agorustc_metadata: Privatize `CrateMetadata::extern_crate`
Vadim Petrochenkov [Sat, 23 Nov 2019 20:01:57 +0000 (23:01 +0300)]
rustc_metadata: Privatize `CrateMetadata::extern_crate`

4 years agorustc_metadata: Privatize `CrateMetadata::dependencies`
Vadim Petrochenkov [Sat, 23 Nov 2019 19:28:45 +0000 (22:28 +0300)]
rustc_metadata: Privatize `CrateMetadata::dependencies`

4 years agorustc_metadata: Cleanup generation of crate dependency lists
Vadim Petrochenkov [Sat, 23 Nov 2019 18:21:00 +0000 (21:21 +0300)]
rustc_metadata: Cleanup generation of crate dependency lists

4 years agoupdate Miri
Ralf Jung [Thu, 28 Nov 2019 17:40:05 +0000 (18:40 +0100)]
update Miri

4 years agoAuto merge of #66642 - ecstatic-morse:promotion-in-const, r=eddyb
bors [Thu, 28 Nov 2019 17:30:24 +0000 (17:30 +0000)]
Auto merge of #66642 - ecstatic-morse:promotion-in-const, r=eddyb

Create promoted MIR fragments for `const` and `static`s

Resolves #65732.

The previous strategy of removing `Drop` and `StorageDead` for promoted locals only worked for rvalue lifetime extension and only if no `loop`s were present. This PR applies the approach currently used for `fn` and `const fn`s to `const` and `statics`.

This may have some performance impacts.

r? @eddyb

4 years agoAuto merge of #66603 - Nadrieril:fix-65413, r=varkor
bors [Thu, 28 Nov 2019 14:22:47 +0000 (14:22 +0000)]
Auto merge of #66603 - Nadrieril:fix-65413, r=varkor

Fix #65413

#65413 was due to an oversight in `pat_constructor` that didn't check if a particular const value was maybe a slice/array const.

4 years agoClarify `{f32,f64}::EPSILON` docs
Ohad Ravid [Thu, 28 Nov 2019 12:49:58 +0000 (13:49 +0100)]
Clarify `{f32,f64}::EPSILON` docs

4 years agoAuto merge of #66246 - matthewjasper:simplify-mem-cat, r=pnkfelix
bors [Thu, 28 Nov 2019 10:36:56 +0000 (10:36 +0000)]
Auto merge of #66246 - matthewjasper:simplify-mem-cat, r=pnkfelix

Simplify memory categorization

With AST borrowck gone, mem_categorization can be simplified, a lot.

* `cmt_` is now called `Place`. Most local variable names have been updated to reflect this, but the `cat_*` methods retain their names.
* `MemCategorizationContext` no longer needs a `ScopeTree` and always needs an `InferCtxt`.
* `Place` now uses a similar representation to `mir::Place` with a `Vec` of projections.
* `Upvar` places don't include the implicit environment and capture derefs. These are now handled by `regionck` when needed.
* Various types, methods and variants only used by AST borrowck have been removed.
* `ExprUseVisitor` now lives in `rustc_typeck::expr_use_visitor`.
* `MemCategorizationContext` and `Place` live in `rustc_typeck::mem_categorization`.
* `Place` is re-exported in `rustc_typeck::expr_use_visitor` so that Clippy can access it.

The loss of an error in `issue-4335.rs` is due to a change in capture inference in ill-formed programs. If any projection from a variable is moved from then we capture that variable by move, whether or not the place being moved from allows this.

Closes #66270

4 years agoMoved tests and fixed merge conflict
David Haig [Thu, 28 Nov 2019 08:24:19 +0000 (08:24 +0000)]
Moved tests and fixed merge conflict

4 years agoconst_prop: detect and avoid catching Miri errors that require allocation
Ralf Jung [Thu, 28 Nov 2019 08:03:00 +0000 (09:03 +0100)]
const_prop: detect and avoid catching Miri errors that require allocation

4 years agoFail fast if generator_kind is None
David Haig [Tue, 26 Nov 2019 12:45:19 +0000 (12:45 +0000)]
Fail fast if generator_kind is None

4 years agoBlock indent formatting
David Haig [Tue, 26 Nov 2019 10:46:49 +0000 (10:46 +0000)]
Block indent formatting

4 years agoFixed unit test
David Haig [Tue, 26 Nov 2019 02:40:01 +0000 (02:40 +0000)]
Fixed unit test

4 years agoReduced repetition by refactoring new body to constructor function
David Haig [Tue, 26 Nov 2019 01:31:27 +0000 (01:31 +0000)]
Reduced repetition by refactoring new body to constructor function

4 years agoRemoved FIXME comment
David Haig [Tue, 26 Nov 2019 00:56:58 +0000 (00:56 +0000)]
Removed FIXME comment

4 years agoFixed tidy errors
David Haig [Tue, 26 Nov 2019 00:45:09 +0000 (00:45 +0000)]
Fixed tidy errors

4 years agoRemove duplication using single variant for error
David Haig [Tue, 26 Nov 2019 00:30:07 +0000 (00:30 +0000)]
Remove duplication using single variant for error

4 years agoFixed merge issue
David Haig [Mon, 25 Nov 2019 15:27:42 +0000 (15:27 +0000)]
Fixed merge issue

4 years agoFixed merge issue
David Haig [Mon, 25 Nov 2019 13:38:08 +0000 (13:38 +0000)]
Fixed merge issue

4 years agoSquash
David Haig [Mon, 25 Nov 2019 12:58:40 +0000 (12:58 +0000)]
Squash

4 years agoAuto merge of #66294 - davidhewitt:const_fn_memoization, r=oli-obk
bors [Thu, 28 Nov 2019 07:06:40 +0000 (07:06 +0000)]
Auto merge of #66294 - davidhewitt:const_fn_memoization, r=oli-obk

Add memoization for const function evaluations

When a const function is being evaluated, as long as all its arguments are zero-sized-types (or it has no arguments) then we can trivially memoize the evaluation result using the existing query mechanism.

With thanks to @oli-obk for mentoring me through this at RustFest Barcelona.

r? @oli-obk

4 years agoAuto merge of #65013 - petertodd:2019-maybeuninit-debug, r=sfackler
bors [Thu, 28 Nov 2019 03:41:29 +0000 (03:41 +0000)]
Auto merge of #65013 - petertodd:2019-maybeuninit-debug, r=sfackler

Implement Debug for MaybeUninit

Precedent: `UnsafeCell` implements `Debug` even though it can't actually display the value. I noticed this omission while writing the following:

```
#[derive(Debug)]
 pub struct SliceInitializer<'a, T> {
    marker: PhantomData<&'a mut T>,
    uninit: &'a mut [MaybeUninit<T>],
    written: usize,
}
```

...which currently unergonomically fails to compile.

`UnsafeCell` does require `T: Debug`. Because of things like the above I think it'd be better to leave that requirement off. In fact, I'd also suggest removing that requirement for `UnsafeCell` too, which again I noticed in some low-level real world code.

4 years agoAuto merge of #66829 - Manishearth:clippyup, r=Manishearth
bors [Thu, 28 Nov 2019 00:36:23 +0000 (00:36 +0000)]
Auto merge of #66829 - Manishearth:clippyup, r=Manishearth

Update clippy

Fixes https://github.com/rust-lang/rust/issues/66728

r? @ghost

4 years agoUpdate CONTRIBUTING.md
Dylan DPC [Thu, 28 Nov 2019 00:26:45 +0000 (01:26 +0100)]
Update CONTRIBUTING.md

4 years agoUpdate CONTRIBUTING.md
Dylan DPC [Thu, 28 Nov 2019 00:23:39 +0000 (01:23 +0100)]
Update CONTRIBUTING.md

4 years agoUpdate test for mutably borrowed statics in a const
Dylan MacKenzie [Wed, 27 Nov 2019 01:08:46 +0000 (17:08 -0800)]
Update test for mutably borrowed statics in a const

This checks `static mut` as well for E0017, and blesses tests now that
we emit an error for a mut deref.

4 years agoDon't treat a reference to a `static` as a reborrow
Dylan MacKenzie [Wed, 27 Nov 2019 22:04:11 +0000 (14:04 -0800)]
Don't treat a reference to a `static` as a reborrow

They now look the same in the MIR after #66587.