]> git.lizzy.rs Git - rust.git/log
rust.git
2 years agoBless tests with the full list of conventions in the output
Scott McMurray [Sun, 29 May 2022 08:29:42 +0000 (01:29 -0700)]
Bless tests with the full list of conventions in the output

2 years agoAdd support for emitting functions with `coldcc` in LLVM
Scott McMurray [Sun, 29 May 2022 07:25:14 +0000 (00:25 -0700)]
Add support for emitting functions with `coldcc` in LLVM

The eventual goal is to try using this for things like the internal panicking stuff, to see whether it helps.

2 years agoAuto merge of #96652 - notriddle:notriddle/self, r=GuillaumeGomez
bors [Sun, 29 May 2022 03:15:28 +0000 (03:15 +0000)]
Auto merge of #96652 - notriddle:notriddle/self, r=GuillaumeGomez

rustdoc: include impl generics / self in search index

Fixes #92205

2 years agoAuto merge of #97500 - GuillaumeGomez:rollup-ms1bvps, r=GuillaumeGomez
bors [Sun, 29 May 2022 00:40:45 +0000 (00:40 +0000)]
Auto merge of #97500 - GuillaumeGomez:rollup-ms1bvps, r=GuillaumeGomez

Rollup of 5 pull requests

Successful merges:

 - #96950 (Add regression test for #96395)
 - #97028 (Add support for embedding pretty printers via `#[debugger_visualizer]` attribute)
 - #97478 (Remove FIXME on `ExtCtxt::fn_decl()`)
 - #97479 (Make some tests check-pass)
 - #97482 (ptr::invalid is not equivalent to a int2ptr cast)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

2 years agoRollup merge of #97482 - RalfJung:ptr-invalid, r=thomcc
Guillaume Gomez [Sat, 28 May 2022 23:12:33 +0000 (01:12 +0200)]
Rollup merge of #97482 - RalfJung:ptr-invalid, r=thomcc

ptr::invalid is not equivalent to a int2ptr cast

I just realized I forgot to update these docs when adding `from_exposed_addr`.
Right now the docs say `invalid` and `from_exposed_addr` are both equivalent to a cast, and that is clearly not what we want.

Cc ``@Gankra``

2 years agoRollup merge of #97479 - JohnTitor:make-check-pass, r=compiler-errors
Guillaume Gomez [Sat, 28 May 2022 23:12:32 +0000 (01:12 +0200)]
Rollup merge of #97479 - JohnTitor:make-check-pass, r=compiler-errors

Make some tests check-pass

This touches the tests related to lint, parser, and importing, all of them should be fine with `check-pass`.
r? ``@compiler-errors``

2 years agoRollup merge of #97478 - JohnTitor:fixme-fn-decl, r=compiler-errors
Guillaume Gomez [Sat, 28 May 2022 23:12:30 +0000 (01:12 +0200)]
Rollup merge of #97478 - JohnTitor:fixme-fn-decl, r=compiler-errors

Remove FIXME on `ExtCtxt::fn_decl()`

`ExtCtxt::fn_decl()` is used like `self.fn_decl(..)` or `self.cx.fn_decl(..)`, coverting it to an assoc fn, for example, makes it inconvenience (e.g. `self.cx.fn_decl(..)` would be longer to represent). Given that, it doesn't seem a "FIXME" thing and unused `self` is okay, I think.

2 years agoRollup merge of #97028 - ridwanabdillahi:pretty-printer, r=michaelwoerister
Guillaume Gomez [Sat, 28 May 2022 23:12:30 +0000 (01:12 +0200)]
Rollup merge of #97028 - ridwanabdillahi:pretty-printer, r=michaelwoerister

Add support for embedding pretty printers via `#[debugger_visualizer]` attribute

Initial support for [RFC 3191](https://github.com/rust-lang/rfcs/pull/3191) in PR https://github.com/rust-lang/rust/pull/91779 was scoped to supporting embedding NatVis files using a new attribute. This PR implements the pretty printer support as stated in the RFC mentioned above.

This change includes embedding pretty printers in the `.debug_gdb_scripts` just as the pretty printers for rustc are embedded today. Also added additional tests for embedded pretty printers. Additionally cleaned up error checking so all error checking is done up front regardless of the current target.

RFC: https://github.com/rust-lang/rfcs/pull/3191

2 years agoRollup merge of #96950 - JohnTitor:issue-96395, r=compiler-errors,oli-obk
Guillaume Gomez [Sat, 28 May 2022 23:12:29 +0000 (01:12 +0200)]
Rollup merge of #96950 - JohnTitor:issue-96395, r=compiler-errors,oli-obk

Add regression test for #96395

Closes #96395
This repeats "fixed" and "ICE", see https://github.com/rust-lang/glacier/pull/1243#issuecomment-1123768138
I think it's good to add a test before regressing again.
r? ``@compiler-errors`` for quick reviiew

cc ``@oli-obk`` you might want to check as you're familiar with MIR

2 years agoAuto merge of #97472 - cuviper:rebase-rustc-rayon, r=Mark-Simulacrum
bors [Sat, 28 May 2022 22:24:53 +0000 (22:24 +0000)]
Auto merge of #97472 - cuviper:rebase-rustc-rayon, r=Mark-Simulacrum

Update to rebased rustc-rayon 0.4

In rayon-rs/rayon#938, miri uncovered a race in `rustc-rayon-core` that had already been fixed in the regular `rayon-core`. I have now rebased that fork onto the latest rayon branch, and published as 0.4. I also updated `indexmap` to bump the dependency.

`Cargo.lock` changes:

    Updating indexmap v1.8.0 -> v1.8.2
    Updating rayon v1.5.1 -> v1.5.3
    Updating rayon-core v1.9.1 -> v1.9.3
    Updating rustc-rayon v0.3.2 -> v0.4.0
    Updating rustc-rayon-core v0.3.2 -> v0.4.1

2 years agoAuto merge of #97207 - RalfJung:backtrace, r=Mark-Simulacrum
bors [Sat, 28 May 2022 19:30:58 +0000 (19:30 +0000)]
Auto merge of #97207 - RalfJung:backtrace, r=Mark-Simulacrum

update libbacktrace

It seems like previously we were on a tag of the backtrace repo; not sure if there is a policy that it should always be a tag?

Cc https://github.com/rust-lang/backtrace-rs/pull/462 `@alexcrichton` `@DrMeepster`

2 years agoAuto merge of #97461 - eddyb:proc-macro-less-payload, r=bjorn3
bors [Sat, 28 May 2022 16:49:52 +0000 (16:49 +0000)]
Auto merge of #97461 - eddyb:proc-macro-less-payload, r=bjorn3

proc_macro: don't pass a client-side function pointer through the server.

Before this PR, `proc_macro::bridge::Client<F>` contained both:
* the C ABI entry-point `run`, that the server can call to start the client
* some "payload" `f: F` passed to that entry-point
  * in practice, this was always a (client-side Rust ABI) `fn` pointer to the actual function the proc macro author wrote, i.e. `#[proc_macro] fn foo(input: TokenStream) -> TokenStream`

In other words, the client was passing one of its (Rust) `fn` pointers to the server, which was passing it back to the client, for the client to call (see later below for why that was ever needed).

I was inspired by `@nnethercote's` attempt to remove the `get_handle_counters` field from `Client` (see https://github.com/rust-lang/rust/pull/97004#issuecomment-1139273301), which combined with removing the `f` ("payload") field, could theoretically allow for a `#[repr(transparent)]` `Client` that mostly just newtypes the C ABI entry-point `fn` pointer <sub>(and in the context of e.g. wasm isolation, that's *all* you want, since you can reason about it from outside the wasm VM, as just a 32-bit "function table index", that you can pass to the wasm VM to call that function)</sub>.

<hr/>

So this PR removes that "payload". But it's not a simple refactor: the reason the field existed in the first place is because monomorphizing over a function type doesn't let you call the function without having a value of that type, because function types don't implement anything like `Default`, i.e.:
```rust
extern "C" fn ffi_wrapper<A, R, F: Fn(A) -> R>(arg: A) -> R {
    let f: F = ???; // no way to get a value of `F`
    f(arg)
}
```
That could be solved with something like this, if it was allowed:
```rust
extern "C" fn ffi_wrapper<
    A, R,
    F: Fn(A) -> R,
    const f: F // not allowed because the type is a generic param
>(arg: A) -> R {
    f(arg)
}
```

Instead, this PR contains a workaround in `proc_macro::bridge::selfless_reify` (see its module-level comment for more details) that can provide something similar to the `ffi_wrapper` example above, but limited to `F` being `Copy` and ZST (and requiring an `F` value to prove the caller actually can create values of `F` and it's not uninhabited or some other unsound situation).

<hr/>

Hopefully this time we don't have a performance regression, and this has a chance to land.

cc `@mystor` `@bjorn3`

2 years agonote to future self
Ralf Jung [Sat, 28 May 2022 16:15:04 +0000 (18:15 +0200)]
note to future self

2 years agoAuto merge of #97383 - dingxiangfei2009:restore-region-scope-tree-query, r=dingxiangf...
bors [Sat, 28 May 2022 14:30:25 +0000 (14:30 +0000)]
Auto merge of #97383 - dingxiangfei2009:restore-region-scope-tree-query, r=dingxiangfei2009

Try to cache region_scope_tree as a query

This PR will attempt to restore `region_scope_tree` as a query so that caching works again. It seems that `region_scope_tree` could be re-computed for nested items after all, which could explain the performance regression introduced by #95563.

cc `@Mark-Simulacrum` `@pnkfelix` I will try to trigger a perf run here.

2 years agoAuto merge of #97158 - JakobDegen:dse, r=tmiasko,cjgillot
bors [Sat, 28 May 2022 11:49:42 +0000 (11:49 +0000)]
Auto merge of #97158 - JakobDegen:dse, r=tmiasko,cjgillot

Split dead store elimination off dest prop

This splits off a part of #96451 . I've added this in as its own pass for now, so that it actually runs, can be tested, etc. In the dest prop PR, I'll stop invoking this as its own pass, so that it doesn't get invoked twice.

r? `@tmiasko`

2 years agoptr::invalid is not equivalent to a int2ptr cast
Ralf Jung [Sat, 28 May 2022 10:39:36 +0000 (12:39 +0200)]
ptr::invalid is not equivalent to a int2ptr cast

2 years agoMake some tests check-pass
Yuki Okushi [Sat, 28 May 2022 09:57:02 +0000 (18:57 +0900)]
Make some tests check-pass

2 years agoRemove FIXME on `ExtCtxt::fn_decl()`
Yuki Okushi [Sat, 28 May 2022 09:12:34 +0000 (18:12 +0900)]
Remove FIXME on `ExtCtxt::fn_decl()`

2 years agoAuto merge of #97476 - Dylan-DPC:rollup-t53nxoe, r=Dylan-DPC
bors [Sat, 28 May 2022 09:08:49 +0000 (09:08 +0000)]
Auto merge of #97476 - Dylan-DPC:rollup-t53nxoe, r=Dylan-DPC

Rollup of 5 pull requests

Successful merges:

 - #94640 (Partially stabilize `(const_)slice_ptr_len` feature by stabilizing `NonNull::len`)
 - #97034 (Implement `Hash` for `core::alloc::Layout`)
 - #97327 (macros: introduce `fluent_messages` macro )
 - #97448 (docs: Don't imply that OsStr on Unix is always UTF-8)
 - #97466 ([bootstrap] Move `sanitize_sh` from `dist` to `install`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

2 years agoRollup merge of #97466 - jyn514:consolidate-install, r=Mark-Simulacrum
Dylan DPC [Sat, 28 May 2022 06:45:54 +0000 (08:45 +0200)]
Rollup merge of #97466 - jyn514:consolidate-install, r=Mark-Simulacrum

[bootstrap] Move `sanitize_sh` from `dist` to `install`

This is the only place it's used, so there's no need for it to be public in another module.
In general, `dist` shouldn't ever touch shell scripts.

2 years agoRollup merge of #97448 - Xiretza:os-str-unix-doc, r=joshtriplett
Dylan DPC [Sat, 28 May 2022 06:45:53 +0000 (08:45 +0200)]
Rollup merge of #97448 - Xiretza:os-str-unix-doc, r=joshtriplett

docs: Don't imply that OsStr on Unix is always UTF-8

The methods in `OsStrExt` consume and return `&[u8]` and don't perform any UTF-8 checks.

2 years agoRollup merge of #97327 - davidtwco:diagnostic-translation-compile-time-validation...
Dylan DPC [Sat, 28 May 2022 06:45:52 +0000 (08:45 +0200)]
Rollup merge of #97327 - davidtwco:diagnostic-translation-compile-time-validation, r=oli-obk

macros: introduce `fluent_messages` macro

Adds a new `fluent_messages` macro which performs compile-time validation of the compiler's Fluent resources (i.e. that the resources parse and don't multiply define the same messages) and generates constants that make using those messages in diagnostics more ergonomic.

For example, given the following invocation of the macro..

```rust
fluent_messages! {
    typeck => "./typeck.ftl",
}
```

..where `typeck.ftl` has the following contents..

```fluent
typeck-field-multiply-specified-in-initializer =
    field `{$ident}` specified more than once
    .label = used more than once
    .label-previous-use = first use of `{$ident}`
```

...then the macro parse the Fluent resource, emitting a diagnostic if it fails to do so...

```text
error: could not parse Fluent resource
  --> $DIR/test.rs:35:28
   |
LL |         missing_message => "./missing-message.ftl",
   |                            ^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: see additional errors emitted

error: expected a message field for "missing-message"
 --> ./missing-message.ftl:1:1
  |
1 | missing-message =
  | ^^^^^^^^^^^^^^^^^^
  |
```
...or generating the following code if it succeeds:

```rust
pub static DEFAULT_LOCALE_RESOURCES: &'static [&'static str] = &[
    include_str!("./typeck.ftl"),
];

mod fluent_generated {
    mod typeck {
        pub const field_multiply_specified_in_initializer: DiagnosticMessage =
            DiagnosticMessage::fluent("typeck-field-multiply-specified-in-initializer");
        pub const field_multiply_specified_in_initializer_label_previous_use: DiagnosticMessage =
            DiagnosticMessage::fluent_attr(
                "typeck-field-multiply-specified-in-initializer",
                "previous-use-label"
            );
    }
}
```

When emitting a diagnostic, the generated constants can be used as follows:

```rust
let mut err = sess.struct_span_err(
    span,
    fluent::typeck::field_multiply_specified_in_initializer
);
err.span_label(
    span,
    fluent::typeck::field_multiply_specified_in_initializer_label
);
err.span_label(
    previous_use_span,
    fluent::typeck::field_multiply_specified_in_initializer_label_previous_use
);
err.emit();
```

I'd like to reduce the verbosity of referring to labels/notes/helps with this scheme (though it wasn't much better before), but I'll leave that for a follow-up.

r? `@oli-obk`
cc `@pvdrz` `@compiler-errors`

2 years agoRollup merge of #97034 - fee1-dead-contrib:layout-hash, r=dtolnay
Dylan DPC [Sat, 28 May 2022 06:45:51 +0000 (08:45 +0200)]
Rollup merge of #97034 - fee1-dead-contrib:layout-hash, r=dtolnay

Implement `Hash` for `core::alloc::Layout`

This was brought up on [reddit](https://www.reddit.com/r/rust/comments/uoypui/the_standard_library_types_are_good_except_when/), and I don't see why Layout shouldn't implement `Hash`. Feel free to comment if I am wrong though :)

2 years agoRollup merge of #94640 - Pointerbender:issue-71146-partial-stabilization, r=yaahc
Dylan DPC [Sat, 28 May 2022 06:45:50 +0000 (08:45 +0200)]
Rollup merge of #94640 - Pointerbender:issue-71146-partial-stabilization, r=yaahc

Partially stabilize `(const_)slice_ptr_len` feature by stabilizing `NonNull::len`

This PR partially stabilizes features `const_slice_ptr_len` and `slice_ptr_len` by only stabilizing `NonNull::len`. This partial stabilization is tracked under features `slice_ptr_len_nonnull` and `const_slice_ptr_len_nonnull`, for which this PR can serve as the tracking issue.

To summarize the discussion from #71146 leading up to this partial stabilization request:

It's currently a bit footgunny to obtain the length of a raw slice pointer, stabilization of `NonNull:len` will help with removing these footguns. Some example footguns are:

```rust
/// # Safety
/// The caller must ensure that `ptr`:
/// 1. does not point to memory that was previously allocated but is now deallocated;
/// 2. is within the bounds of a single allocated object;
/// 3. does not to point to a slice for which the length exceeds `isize::MAX` bytes;
/// 4. points to a properly aligned address;
/// 5. does not point to uninitialized memory;
/// 6. does not point to a mutably borrowed memory location.
pub unsafe fn ptr_len<T>(ptr: core::ptr::NonNull<[T]>) -> usize {
   (&*ptr.as_ptr()).len()
}
```

A slightly less complicated version (but still more complicated than it needs to be):

```rust
/// # Safety
/// The caller must ensure that the start of `ptr`:
/// 1. does not point to memory that was previously allocated but is now deallocated;
/// 2. must be within the bounds of a single allocated object.
pub unsafe fn ptr_len<T>(ptr: NonNull<[T]>) -> usize {
   (&*(ptr.as_ptr() as *const [()])).len()
}
```

This PR does not stabilize `<*const [T]>::len` and  `<*mut [T]>::len` because the tracking issue #71146 list a potential blocker for these methods, but this blocker [does not apply](https://github.com/rust-lang/rust/issues/71146#issuecomment-808735714) to `NonNull::len`.

We should probably also ping the [Constant Evaluation WG](https://github.com/rust-lang/const-eval) since this PR includes a `#[rustc_allow_const_fn_unstable(const_slice_ptr_len)]`. My instinct here is that this will probably be okay because the pointer is not actually dereferenced and `len()` does not touch the address component of the pointer, but would be best to double check :)

One potential down-side was raised that stabilizing `NonNull::len` could lead to encouragement of coding patterns like:

```
pub fn ptr_len<T>(ptr: *mut [T]) -> usize {
   NonNull::new(ptr).unwrap().len()
}
```

which unnecessarily assert non-nullness. However, these are much less of a footgun than the above examples and this should be resolved when `slice_ptr_len` fully stabilizes eventually.

2 years agoAuto merge of #97465 - jyn514:dist-ra, r=Mark-Simulacrum
bors [Sat, 28 May 2022 06:45:15 +0000 (06:45 +0000)]
Auto merge of #97465 - jyn514:dist-ra, r=Mark-Simulacrum

Fix `x dist --stage 1 src/tools/rust-analyzer`

Previously, this would break because the submodule wasn't checked out.

Fixes https://github.com/rust-lang/rust/issues/97464.

2 years agoAuto merge of #97284 - b-naber:constraint-dyn-impl-suggestion, r=estebank
bors [Sat, 28 May 2022 04:04:29 +0000 (04:04 +0000)]
Auto merge of #97284 - b-naber:constraint-dyn-impl-suggestion, r=estebank

Add suggestion for relaxing static lifetime bounds on dyn trait impls in NLL

This PR introduces suggestions for relaxing static lifetime bounds on impls of dyn trait items for NLL similar to what is already available in lexical region diagnostics.

Fixes https://github.com/rust-lang/rust/issues/95701

r? `@estebank`

2 years agoUpdate to rebased rustc-rayon 0.4
Josh Stone [Sat, 28 May 2022 00:14:22 +0000 (17:14 -0700)]
Update to rebased rustc-rayon 0.4

2 years agoAuto merge of #97433 - GuillaumeGomez:rm-refcell-context, r=notriddle
bors [Sat, 28 May 2022 01:37:09 +0000 (01:37 +0000)]
Auto merge of #97433 - GuillaumeGomez:rm-refcell-context, r=notriddle

Pass Context as a &mut to allow to remove RefCell fields

Fixes #90323.

r? `@notriddle`

2 years agoSwitch incremental/hashes tests to all use optimizations.
Jakob Degen [Sat, 28 May 2022 01:17:39 +0000 (18:17 -0700)]
Switch incremental/hashes tests to all use optimizations.

2 years agoAuto merge of #97468 - matthiaskrgr:rollup-8cu0hqr, r=matthiaskrgr
bors [Fri, 27 May 2022 23:17:18 +0000 (23:17 +0000)]
Auto merge of #97468 - matthiaskrgr:rollup-8cu0hqr, r=matthiaskrgr

Rollup of 6 pull requests

Successful merges:

 - #95214 (Remove impossible panic note from `Vec::append`)
 - #97411 (Print stderr consistently)
 - #97453 (rename `TyKind` to `RegionKind` in comment in rustc_middle)
 - #97457 (Add regression test for #81899)
 - #97458 (Modify `derive(Debug)` to use `Self` in struct literal to avoid redundant error)
 - #97462 (Add more eslint rules)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

2 years agoRollup merge of #97462 - GuillaumeGomez:more-eslint-rules, r=notriddle
Matthias Krüger [Fri, 27 May 2022 23:11:51 +0000 (01:11 +0200)]
Rollup merge of #97462 - GuillaumeGomez:more-eslint-rules, r=notriddle

Add more eslint rules

The last one is the most useful of this batch. :)

Here are the links for the eslint rules:

 * [arrow-parens](https://eslint.org/docs/rules/arrow-parens)
 * [no-unused-vars](https://eslint.org/docs/rules/no-unused-vars)
 * [eqeqeq](https://eslint.org/docs/rules/eqeqeq)

r? `@notriddle`

2 years agoRollup merge of #97458 - estebank:use-self-in-derive-macro, r=compiler-errors
Matthias Krüger [Fri, 27 May 2022 23:11:50 +0000 (01:11 +0200)]
Rollup merge of #97458 - estebank:use-self-in-derive-macro, r=compiler-errors

Modify `derive(Debug)` to use `Self` in struct literal to avoid redundant error

Reduce verbosity in #97343.

2 years agoRollup merge of #97457 - JohnTitor:issue-81899, r=compiler-errors
Matthias Krüger [Fri, 27 May 2022 23:11:49 +0000 (01:11 +0200)]
Rollup merge of #97457 - JohnTitor:issue-81899, r=compiler-errors

Add regression test for #81899

Closes #81899
r? `@compiler-errors`

2 years agoRollup merge of #97453 - lcnr:comment, r=jackh726
Matthias Krüger [Fri, 27 May 2022 23:11:48 +0000 (01:11 +0200)]
Rollup merge of #97453 - lcnr:comment, r=jackh726

rename `TyKind` to `RegionKind` in comment in rustc_middle

2 years agoRollup merge of #97411 - raiyansayeed:print-stderr-consistently, r=Mark-Simulacrum
Matthias Krüger [Fri, 27 May 2022 23:11:47 +0000 (01:11 +0200)]
Rollup merge of #97411 - raiyansayeed:print-stderr-consistently, r=Mark-Simulacrum

Print stderr consistently

Solves https://github.com/rust-lang/rust/issues/96712

I tried to follow what I perceived as the general consensus for error messages in boostrap i.e messages that were ..
* resulting from an Err(...) =>
* literally called as "Error: ...."
* by the end of the block scope forced to run a panic! or process::exit with a guaranteed non-zero error code.

2 years agoRollup merge of #95214 - tbu-:pr_vec_append_doc, r=Mark-Simulacrum
Matthias Krüger [Fri, 27 May 2022 23:11:46 +0000 (01:11 +0200)]
Rollup merge of #95214 - tbu-:pr_vec_append_doc, r=Mark-Simulacrum

Remove impossible panic note from `Vec::append`

Neither the number of elements in a vector can overflow a `usize`, nor
can the amount of elements in two vectors.

2 years ago[bootstrap] Move `sanitize_sh` from `dist` to `install`
Joshua Nelson [Fri, 27 May 2022 22:52:41 +0000 (17:52 -0500)]
[bootstrap] Move `sanitize_sh` from `dist` to `install`

This is the only place it's used, so there's no need for it to be public in another module.
In general, `dist` shouldn't ever touch shell scripts.

2 years agoFix `x dist --stage 1 src/tools/rust-analyzer`
Joshua Nelson [Fri, 27 May 2022 22:47:31 +0000 (17:47 -0500)]
Fix `x dist --stage 1 src/tools/rust-analyzer`

Previously, this would break because the submodule wasn't checked out.

2 years agoAdd "eqeqeq" eslint rule
Guillaume Gomez [Fri, 27 May 2022 20:30:19 +0000 (22:30 +0200)]
Add "eqeqeq" eslint rule

2 years agoAdd "no-unused-vars" eslint rule
Guillaume Gomez [Fri, 27 May 2022 20:22:22 +0000 (22:22 +0200)]
Add "no-unused-vars" eslint rule

2 years agoAdd "arrow-parens" eslint rule
Guillaume Gomez [Fri, 27 May 2022 20:21:41 +0000 (22:21 +0200)]
Add "arrow-parens" eslint rule

2 years agoPass Context as a &mut to allow to remove RefCell fields
Guillaume Gomez [Thu, 26 May 2022 18:18:00 +0000 (20:18 +0200)]
Pass Context as a &mut to allow to remove RefCell fields

2 years agocleanup librustdoc by making parent stack store items
Michael Howell [Fri, 27 May 2022 19:23:29 +0000 (12:23 -0700)]
cleanup librustdoc by making parent stack store items

2 years agoproc_macro: don't pass a client-side function pointer through the server.
Eduard-Mihai Burtescu [Fri, 27 May 2022 17:38:58 +0000 (17:38 +0000)]
proc_macro: don't pass a client-side function pointer through the server.

2 years agoAuto merge of #96790 - lqd:update_jemalloc, r=Mark-Simulacrum
bors [Fri, 27 May 2022 18:28:12 +0000 (18:28 +0000)]
Auto merge of #96790 - lqd:update_jemalloc, r=Mark-Simulacrum

Update jemalloc to v5.3

Now that `jemalloc` version 5.3 has been released, this PR updates `tikv-jemalloc-sys` to the corresponding release.

The crates.io publishing issue seems to have been resolved for the `jemalloc-sys` package, and version 5.3.0 is now also available under the historical name (and should become the preferred crate to be used). Therefore, this PR also switches back to using `jemalloc-sys` instead of  `tikv-jemalloc-sys`.

2 years agoModify `derive(Debug)` to use `Self` in struct literal to avoid redundant error
Esteban Küber [Fri, 27 May 2022 17:48:12 +0000 (10:48 -0700)]
Modify `derive(Debug)` to use `Self` in struct literal to avoid redundant error

#97343

2 years agoAdd test for #97343
Esteban Küber [Fri, 27 May 2022 17:47:05 +0000 (10:47 -0700)]
Add test for #97343

2 years agoAdd regression test for #81899
Yuki Okushi [Fri, 27 May 2022 16:32:15 +0000 (01:32 +0900)]
Add regression test for #81899

2 years agofix comment
lcnr [Fri, 27 May 2022 14:36:59 +0000 (16:36 +0200)]
fix comment

2 years agoAuto merge of #96046 - oli-obk:const_typeck, r=cjgillot
bors [Fri, 27 May 2022 11:31:37 +0000 (11:31 +0000)]
Auto merge of #96046 - oli-obk:const_typeck, r=cjgillot

Move various checks to typeck so them failing causes the typeck result to get tainted

Fixes #69487
fixes #79047

cc `@RalfJung` this gets rid of the `Transmute` invalid program error variant

2 years agodocs: Don't imply that OsStr on Unix is always UTF-8
Xiretza [Fri, 27 May 2022 10:12:15 +0000 (12:12 +0200)]
docs: Don't imply that OsStr on Unix is always UTF-8

The methods in `OsStrExt` consume and return `&[u8]` and don't perform
any UTF-8 checks.

2 years agoUpdate tests on aarch64
Oli Scherer [Fri, 27 May 2022 09:18:11 +0000 (09:18 +0000)]
Update tests on aarch64

2 years agoAuto merge of #97442 - hafeoz:master, r=GuillaumeGomez
bors [Fri, 27 May 2022 08:50:51 +0000 (08:50 +0000)]
Auto merge of #97442 - hafeoz:master, r=GuillaumeGomez

Fix multiline attributes processing in doctest

Fixes #97440.

It seems like the call to `check_if_attr_is_complete` is not provided with the correct argument: the pending attribute should be passed, while the current line is actually being passed. This causes any attribute with more than 2 lines to fail and produces ICE when running through doctest.

2 years agoAuto merge of #97004 - nnethercote:proc-macro-tweaks, r=eddyb
bors [Fri, 27 May 2022 06:09:45 +0000 (06:09 +0000)]
Auto merge of #97004 - nnethercote:proc-macro-tweaks, r=eddyb

Proc macro tweaks

Various improvements I spotted while looking through the proc macro code.

r? `@eddyb`

2 years agoCut down `associated_item`.
Nicholas Nethercote [Mon, 16 May 2022 21:42:57 +0000 (07:42 +1000)]
Cut down `associated_item`.

The part of it dealing with types obfuscates and makes the code less
concise. This commit removes that part.

2 years agoRemove unnecessary blank line.
Nicholas Nethercote [Mon, 16 May 2022 22:39:57 +0000 (08:39 +1000)]
Remove unnecessary blank line.

2 years agoRename `b` as `buf` in several places.
Nicholas Nethercote [Wed, 18 May 2022 23:03:26 +0000 (09:03 +1000)]
Rename `b` as `buf` in several places.

Because it's easy to confuse with `bridge`.

2 years agoAdd some comments about `_marker` fields.
Nicholas Nethercote [Sun, 15 May 2022 23:36:52 +0000 (09:36 +1000)]
Add some comments about `_marker` fields.

There is some non-obvious information required to understand them.

2 years agoClarify a comment.
Nicholas Nethercote [Fri, 13 May 2022 05:57:55 +0000 (15:57 +1000)]
Clarify a comment.

`reverse_encode` isn't necessary to please the borrow checker, it's to
match the ordering done by `reverse_decode`.

2 years agoRename `ProcMacroDerive` as `DeriveProcMacro`.
Nicholas Nethercote [Mon, 16 May 2022 01:56:36 +0000 (11:56 +1000)]
Rename `ProcMacroDerive` as `DeriveProcMacro`.

So it matches the existing `AttrProcMacro` and `BangProcMacro` types.

2 years agoRename `ProcMacro` trait as `BangProcMacro`.
Nicholas Nethercote [Fri, 13 May 2022 04:07:56 +0000 (14:07 +1000)]
Rename `ProcMacro` trait as `BangProcMacro`.

Similar to the existing `AttrProcMacro` trait.

2 years agoSimplify types in `proc_macro_harness.rs`.
Nicholas Nethercote [Fri, 13 May 2022 01:45:51 +0000 (11:45 +1000)]
Simplify types in `proc_macro_harness.rs`.

This gives the more obvious derive/attr/bang distinction, and reduces
code size slightly.

2 years agoMake `Buffer<T>` non-generic.
Nicholas Nethercote [Thu, 12 May 2022 23:38:02 +0000 (09:38 +1000)]
Make `Buffer<T>` non-generic.

`u8` is the only type that makes sense for `T`, as demonstrated by the
fact that several impls and functions are hardwired to `Buffer<u8>`.

2 years agoImprove formatting in `associated_item!` definition.
Nicholas Nethercote [Fri, 13 May 2022 00:21:38 +0000 (10:21 +1000)]
Improve formatting in `associated_item!` definition.

2 years agoAdd some comments.
Nicholas Nethercote [Fri, 13 May 2022 00:07:45 +0000 (10:07 +1000)]
Add some comments.

2 years agoFix a typo in a comment.
Nicholas Nethercote [Thu, 12 May 2022 23:44:17 +0000 (09:44 +1000)]
Fix a typo in a comment.

2 years agoAuto merge of #97444 - compiler-errors:rollup-2gvdav6, r=compiler-errors
bors [Fri, 27 May 2022 03:27:04 +0000 (03:27 +0000)]
Auto merge of #97444 - compiler-errors:rollup-2gvdav6, r=compiler-errors

Rollup of 3 pull requests

Successful merges:

 - #96051 (Use rounding in float to Duration conversion methods)
 - #97066 (rustdoc: Remove `ItemFragment(Kind)`)
 - #97436 (Update `triagebot.toml` for macos ping group)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

2 years agoRollup merge of #97436 - compiler-errors:macos-ping-2, r=Mark-Simulacrum
Michael Goulet [Fri, 27 May 2022 03:15:09 +0000 (20:15 -0700)]
Rollup merge of #97436 - compiler-errors:macos-ping-2, r=Mark-Simulacrum

Update `triagebot.toml` for macos ping group

idk what i'm doing but i saw https://github.com/rust-lang/rust/pull/96392#issuecomment-1138893845

cc: `@thomcc`

2 years agoRollup merge of #97066 - petrochenkov:nofragkind, r=camelid
Michael Goulet [Fri, 27 May 2022 03:15:08 +0000 (20:15 -0700)]
Rollup merge of #97066 - petrochenkov:nofragkind, r=camelid

rustdoc: Remove `ItemFragment(Kind)`

And stop using `write!` when rendering URL fragments to avoid impossible errors.

2 years agoRollup merge of #96051 - newpavlov:duration_rounding, r=nagisa,joshtriplett
Michael Goulet [Fri, 27 May 2022 03:15:07 +0000 (20:15 -0700)]
Rollup merge of #96051 - newpavlov:duration_rounding, r=nagisa,joshtriplett

Use rounding in float to Duration conversion methods

Closes #96045

2 years agofmt
Артём Павлов [Artyom Pavlov] [Fri, 27 May 2022 02:15:22 +0000 (05:15 +0300)]
fmt

2 years agofix nanos overflow for f64
Артём Павлов [Artyom Pavlov] [Fri, 27 May 2022 01:59:01 +0000 (04:59 +0300)]
fix nanos overflow for f64

2 years agoAuto merge of #96298 - petrochenkov:fromgen, r=estebank
bors [Fri, 27 May 2022 01:01:15 +0000 (01:01 +0000)]
Auto merge of #96298 - petrochenkov:fromgen, r=estebank

libcore: Add `iter::from_generator` which is like `iter::from_fn`, but for coroutines instead of functions

An equally useful little helper.

I didn't follow any of the async-wg work, so I don't know why something like this wasn't added before.

2 years agoremove trailing space
X [Fri, 27 May 2022 00:46:40 +0000 (08:46 +0800)]
remove trailing space

Co-authored-by: Rémy Rakic <remy.rakic+github@gmail.com>
2 years agoadd debug asserts
Artyom Pavlov [Fri, 27 May 2022 00:22:56 +0000 (00:22 +0000)]
add debug asserts

2 years agolibcore: Add `iter::from_generator` which is like `iter::from_fn`, but for coroutines...
Vadim Petrochenkov [Thu, 21 Apr 2022 20:47:39 +0000 (23:47 +0300)]
libcore: Add `iter::from_generator` which is like `iter::from_fn`, but for coroutines instead of functions

2 years agoFormatting
hafeoz [Thu, 26 May 2022 22:27:41 +0000 (23:27 +0100)]
Formatting

2 years agoRemove few characters for tidy check to pass
hafeoz [Thu, 26 May 2022 22:13:37 +0000 (23:13 +0100)]
Remove few characters for tidy check to pass

2 years agoAuto merge of #97386 - nnethercote:optimize-pos-adjustments, r=bjorn3
bors [Thu, 26 May 2022 22:01:19 +0000 (22:01 +0000)]
Auto merge of #97386 - nnethercote:optimize-pos-adjustments, r=bjorn3

Optimize position adjustments

A small improvement.

r? `@bjorn3`

2 years agoAdd tests
hafeoz [Thu, 26 May 2022 21:55:29 +0000 (22:55 +0100)]
Add tests

2 years agoUse correct var for attribute completeness fn
hafeoz [Thu, 26 May 2022 21:54:31 +0000 (22:54 +0100)]
Use correct var for attribute completeness fn

2 years agorustdoc: factor orphan impl items into an actual struct
Michael Howell [Thu, 26 May 2022 21:01:08 +0000 (14:01 -0700)]
rustdoc: factor orphan impl items into an actual struct

2 years agoUpdate `triagebot.toml` for macos ping group
Michael Goulet [Thu, 26 May 2022 19:42:14 +0000 (12:42 -0700)]
Update `triagebot.toml` for macos ping group

2 years agoAuto merge of #97434 - matthiaskrgr:rollup-7j3y16l, r=matthiaskrgr
bors [Thu, 26 May 2022 19:33:22 +0000 (19:33 +0000)]
Auto merge of #97434 - matthiaskrgr:rollup-7j3y16l, r=matthiaskrgr

Rollup of 3 pull requests

Successful merges:

 - #96033 (Add section on common message styles for Result::expect)
 - #97354 (Updates to browser-ui-test)
 - #97424 (clippy::complexity fixes)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

2 years agoRollup merge of #97424 - matthiaskrgr:clippy_complexity_may26, r=oli-obk
Matthias Krüger [Thu, 26 May 2022 18:59:43 +0000 (20:59 +0200)]
Rollup merge of #97424 - matthiaskrgr:clippy_complexity_may26, r=oli-obk

clippy::complexity fixes

clone_on_copy
useless_format
bind_instead_of_map
filter_map_identity
useless_conversion
map_flatten
unnecessary_unwrap

2 years agoRollup merge of #97354 - GuillaumeGomez:browser-ui-test-update, r=notriddle
Matthias Krüger [Thu, 26 May 2022 18:59:42 +0000 (20:59 +0200)]
Rollup merge of #97354 - GuillaumeGomez:browser-ui-test-update, r=notriddle

Updates to browser-ui-test

I took the commits from #97317. Since the ubuntu 22.04 version, you either need to use `--no-sandbox` or use another binary to run the GUI tests. I couldn't find out why the chromium used by `browser-ui-test` isn't working anymore on this ubuntu version.

r? `@notriddle`

2 years agoRollup merge of #96033 - yaahc:expect-elaboration, r=scottmcm
Matthias Krüger [Thu, 26 May 2022 18:59:40 +0000 (20:59 +0200)]
Rollup merge of #96033 - yaahc:expect-elaboration, r=scottmcm

Add section on common message styles for Result::expect

Based on a question from https://github.com/rust-lang/project-error-handling/issues/50#issuecomment-1092339937

~~One thing I haven't decided on yet, should I duplicate this section on `Option::expect`, link to this section, or move it somewhere else and link to that location from both docs?~~: I ended up moving the section to `std::error` and referencing it from both `Result::expect` and `Option::expect`'s docs.

I think this section, when combined with the similar update I made on [`std::panic!`](https://doc.rust-lang.org/nightly/std/macro.panic.html#when-to-use-panic-vs-result) implies that we should possibly more aggressively encourage and support the "expect as precondition" style described in this section. The consensus among the libs team seems to be that panic should be used for bugs, not expected potential failure modes. The "expect as error message" style seems to align better with the panic for unrecoverable errors style where they're seen as normal errors where the only difference is a desire to kill the current execution unit (aka erlang style error handling). I'm wondering if we should be providing a panic hook similar to `human-panic` or more strongly recommending the "expect as precondition" style of expect message.

2 years agoAuto merge of #97046 - conradludgate:faster-ascii-case-conv-path, r=thomcc
bors [Thu, 26 May 2022 15:29:01 +0000 (15:29 +0000)]
Auto merge of #97046 - conradludgate:faster-ascii-case-conv-path, r=thomcc

improve case conversion happy path

Someone shared the source code for [Go's string case conversion](https://github.com/golang/go/blob/19156a54741d4f353c9e8e0860197ca95a6ee6ca/src/strings/strings.go#L558-L616).

It features a hot path for ascii-only strings (although I assume for reasons specific to go, they've opted for a read safe hot loop).

I've borrowed these ideas and also kept our existing code to provide a fast path + seamless utf-8 correct path fallback.

(Naive) Benchmarks can be found here https://github.com/conradludgate/case-conv

For the cases where non-ascii is found near the start, the performance of this algorithm does fall back to original speeds and has not had any measurable speed loss

2 years agoUpdate compiler/rustc_typeck/src/check/region.rs
Niko Matsakis [Thu, 26 May 2022 14:44:29 +0000 (10:44 -0400)]
Update compiler/rustc_typeck/src/check/region.rs

2 years agoimprove case conversion happy path
Conrad Ludgate [Sat, 14 May 2022 17:44:31 +0000 (18:44 +0100)]
improve case conversion happy path

2 years agoAuto merge of #97168 - SparrowLii:accesses, r=cjgillot
bors [Thu, 26 May 2022 11:15:15 +0000 (11:15 +0000)]
Auto merge of #97168 - SparrowLii:accesses, r=cjgillot

omit `record_accesses` function when collecting `MonoItem`s

This PR fixes the FIXME in the impl of `record_accesses` function.
[Edit] We can call `instantiation_mode` when push the `MonoItem` into `neighbors`. This avoids extra local variables `accesses: SmallVec<[_; 128]>`

2 years agoclippy::complexity fixes
Matthias Krüger [Thu, 26 May 2022 11:14:24 +0000 (13:14 +0200)]
clippy::complexity fixes

clone_on_copy
useless_format
bind_instead_of_map
filter_map_identity
useless_conversion
map_flatten
unnecessary_unwrap

2 years agoAuto merge of #96742 - m-ou-se:bsd-no-ancillary, r=joshtriplett
bors [Thu, 26 May 2022 08:50:33 +0000 (08:50 +0000)]
Auto merge of #96742 - m-ou-se:bsd-no-ancillary, r=joshtriplett

Disable unix::net::ancillary on BSD.

See https://github.com/rust-lang/rust/issues/76915#issuecomment-1118954474

2 years agorebase, use Ty in CallArgument and re-insert static_assert_size on ConstraintCategory
b-naber [Wed, 25 May 2022 21:32:27 +0000 (23:32 +0200)]
rebase, use Ty in CallArgument and re-insert static_assert_size on ConstraintCategory

2 years agoAuto merge of #97410 - jyn514:tool-std-features, r=Mark-Simulacrum
bors [Thu, 26 May 2022 05:45:54 +0000 (05:45 +0000)]
Auto merge of #97410 - jyn514:tool-std-features, r=Mark-Simulacrum

Only allow `compiletest` to use `feature(test)`, not any other feature

Using language features occasionally causes issues when using nightly to bootstrap, rather than beta.
See #59264 for additional context.

2 years agoDisable unix::net::ancillary on BSD.
Mara Bos [Thu, 5 May 2022 19:01:07 +0000 (21:01 +0200)]
Disable unix::net::ancillary on BSD.

2 years agofix: undo old changes
Raiyan [Thu, 26 May 2022 02:12:50 +0000 (22:12 -0400)]
fix: undo old changes

2 years agofeat: refactored bootstrap files to use stderr consistently
Raiyan [Thu, 26 May 2022 02:01:55 +0000 (22:01 -0400)]
feat: refactored bootstrap files to use stderr consistently

2 years agoAuto merge of #97369 - tmiasko:codgen-ssa-atomic-ordering, r=michaelwoerister
bors [Thu, 26 May 2022 02:00:17 +0000 (02:00 +0000)]
Auto merge of #97369 - tmiasko:codgen-ssa-atomic-ordering, r=michaelwoerister

rustc_codegen_ssa: cleanup `AtomicOrdering`

* Remove unused `NotAtomic` ordering.
* Rename `Monotonic` to `Relaxed` - a Rust specific name.
* Derive copy and clone.

2 years agocall `instantiation_mode` when pushing a new mono_item
SparrowLii [Thu, 26 May 2022 01:36:54 +0000 (09:36 +0800)]
call `instantiation_mode` when pushing a new mono_item