]> git.lizzy.rs Git - rust.git/log
rust.git
2 years agorustc_codegen_gcc: proper check for may_unwind
cynecx [Fri, 19 Nov 2021 22:37:09 +0000 (23:37 +0100)]
rustc_codegen_gcc: proper check for may_unwind

2 years agoadd clobber_abi("C") to may_unwind inline-asm tests
cynecx [Fri, 19 Nov 2021 21:41:16 +0000 (22:41 +0100)]
add clobber_abi("C") to may_unwind inline-asm tests

2 years agoadd tests for asm's options(may_unwind)
cynecx [Sun, 14 Nov 2021 02:08:12 +0000 (03:08 +0100)]
add tests for asm's options(may_unwind)

2 years agoadd `unwind_asm` feature gate for `may_unwind` option
cynecx [Sun, 14 Nov 2021 19:21:05 +0000 (20:21 +0100)]
add `unwind_asm` feature gate for `may_unwind` option

2 years agorustc_codegen_gcc: error on unwinding inline asm
cynecx [Fri, 12 Nov 2021 23:37:30 +0000 (00:37 +0100)]
rustc_codegen_gcc: error on unwinding inline asm

2 years agoUpdate unstable-book with recent asm changes (`may_unwind`)
cynecx [Sun, 19 Sep 2021 20:38:55 +0000 (22:38 +0200)]
Update unstable-book with recent asm changes (`may_unwind`)

2 years agocg_cranelift: check may_unwind flag instead of cleanup
cynecx [Sat, 4 Sep 2021 20:14:09 +0000 (22:14 +0200)]
cg_cranelift: check may_unwind flag instead of cleanup

2 years agoLLVM codgen support for unwinding inline assembly
cynecx [Sat, 4 Sep 2021 17:25:09 +0000 (19:25 +0200)]
LLVM codgen support for unwinding inline assembly

2 years agoAdjust llvm wrapper for unwinding support for inlineasm
cynecx [Sat, 28 Aug 2021 17:02:00 +0000 (19:02 +0200)]
Adjust llvm wrapper for unwinding support for inlineasm

2 years agoAdd initial AST and MIR support for unwinding from inline assembly
Amanieu d'Antras [Mon, 30 Aug 2021 00:23:33 +0000 (01:23 +0100)]
Add initial AST and MIR support for unwinding from inline assembly

2 years agoAuto merge of #90737 - eholk:intofuture, r=tmandry
bors [Fri, 3 Dec 2021 19:29:21 +0000 (19:29 +0000)]
Auto merge of #90737 - eholk:intofuture, r=tmandry

Reintroduce `into_future` in `.await` desugaring

This is a reintroduction of the remaining parts from https://github.com/rust-lang/rust/pull/65244 that have not been relanded yet.

This isn't quite ready to merge yet. The last attempt was reverting due to performance regressions, so we need to make sure this does not introduce those issues again.

Issues #67644, #67982

/cc `@yoshuawuyts`

2 years agoAuto merge of #91491 - spastorino:revert-91354, r=oli-obk
bors [Fri, 3 Dec 2021 16:26:01 +0000 (16:26 +0000)]
Auto merge of #91491 - spastorino:revert-91354, r=oli-obk

Revert "Auto merge of #91354 - fee1-dead:const_env, r=spastorino"

This reverts commit 18bb8c61a975fff6424cda831ace5b0404277145, reversing
changes made to d9baa361902b172be716f96619b909f340802dea.

Reverts #91354 in order to address #91489. We would need to place this changes in a more granular way and would also be nice to address the small perf regression that was also introduced.

r? `@oli-obk`
cc `@fee1-dead`

2 years agoAuto merge of #91393 - Julian-Wollersberger:lexer_optimization, r=petrochenkov
bors [Fri, 3 Dec 2021 13:20:14 +0000 (13:20 +0000)]
Auto merge of #91393 - Julian-Wollersberger:lexer_optimization, r=petrochenkov

Optimize `rustc_lexer`

The `cursor.first()` method in `rustc_lexer` now calls the `chars.next()` method instead of `chars.nth_char(0)`.

This allows LLVM to optimize the code better. The biggest win is that `eat_while()` is now fully inlined and generates better assembly. This improves the lexer's performance by 35% in a micro-benchmark I made (Lexing all 18MB of code in the compiler directory). But lexing is only a small part of the overall compilation time, so I don't know how significant it is.

Big thanks to criterion and `cargo asm`.

2 years agoRevert "Auto merge of #91354 - fee1-dead:const_env, r=spastorino"
Santiago Pastorino [Fri, 3 Dec 2021 13:11:21 +0000 (10:11 -0300)]
Revert "Auto merge of #91354 - fee1-dead:const_env, r=spastorino"

This reverts commit 18bb8c61a975fff6424cda831ace5b0404277145, reversing
changes made to d9baa361902b172be716f96619b909f340802dea.

2 years agoAuto merge of #91286 - scottmcm:residual-trait, r=joshtriplett
bors [Fri, 3 Dec 2021 10:15:11 +0000 (10:15 +0000)]
Auto merge of #91286 - scottmcm:residual-trait, r=joshtriplett

Make `array::{try_from_fn, try_map}` and `Iterator::try_find` generic over `Try`

Fixes #85115

This only updates unstable functions.

`array::try_map` didn't actually exist before; this adds it under the still-open tracking issue #79711 from the old PR #79713.

Tracking issue for the new trait: #91285

This would also solve the return type question in for the proposed `Iterator::try_reduce` in #87054

2 years agoAuto merge of #91486 - matthiaskrgr:rollup-699fo18, r=matthiaskrgr
bors [Fri, 3 Dec 2021 07:12:36 +0000 (07:12 +0000)]
Auto merge of #91486 - matthiaskrgr:rollup-699fo18, r=matthiaskrgr

Rollup of 10 pull requests

Successful merges:

 - #88906 (Implement write() method for Box<MaybeUninit<T>>)
 - #90269 (Make `Option::expect` unstably const)
 - #90854 (Type can be unsized and uninhabited)
 - #91170 (rustdoc: preload fonts)
 - #91273 (Fix ICE #91268 by checking that the snippet ends with a `)`)
 - #91381 (Android: -ldl must appear after -lgcc when linking)
 - #91453 (Document Windows TLS drop behaviour)
 - #91462 (Use try_normalize_erasing_regions in needs_drop)
 - #91474 (suppress warning about set_errno being unused on DragonFly)
 - #91483 (Sync rustfmt subtree)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

2 years agoRollup merge of #91483 - calebcartwright:sync-rustfmt-subtree, r=calebcartwright
Matthias Krüger [Fri, 3 Dec 2021 05:24:19 +0000 (06:24 +0100)]
Rollup merge of #91483 - calebcartwright:sync-rustfmt-subtree, r=calebcartwright

Sync rustfmt subtree

2 years agoRollup merge of #91474 - rtzoeller:dfly_set_errno, r=cuviper
Matthias Krüger [Fri, 3 Dec 2021 05:24:18 +0000 (06:24 +0100)]
Rollup merge of #91474 - rtzoeller:dfly_set_errno, r=cuviper

suppress warning about set_errno being unused on DragonFly

Other targets allow this function to be unused, DragonFly just misses out due to providing a specialization.

This fixes a build error for DragonFly.

2 years agoRollup merge of #91462 - b-naber:use-try-normalize-erasing-regions, r=jackh726
Matthias Krüger [Fri, 3 Dec 2021 05:24:17 +0000 (06:24 +0100)]
Rollup merge of #91462 - b-naber:use-try-normalize-erasing-regions, r=jackh726

Use try_normalize_erasing_regions in needs_drop

Fixes https://github.com/rust-lang/rust/issues/81199

r? ``@jackh726``

2 years agoRollup merge of #91453 - ChrisDenton:doc-win-tls-dtors, r=dtolnay
Matthias Krüger [Fri, 3 Dec 2021 05:24:16 +0000 (06:24 +0100)]
Rollup merge of #91453 - ChrisDenton:doc-win-tls-dtors, r=dtolnay

Document Windows TLS drop behaviour

The way Windows TLS destructors are run has some "interesting" properties. They should be documented.

Fixes #74875

2 years agoRollup merge of #91381 - Amanieu:android_libdl, r=petrochenkov
Matthias Krüger [Fri, 3 Dec 2021 05:24:15 +0000 (06:24 +0100)]
Rollup merge of #91381 - Amanieu:android_libdl, r=petrochenkov

Android: -ldl must appear after -lgcc when linking

#90846 accidentally broke Android builds because it causes the standard library to no longer use `dlsym` on Android. This results in `libdl` being ignored by the linker since no symbols are needed from it. However, we later import `libgcc` for unwinding which *does* depend on `libdl` for `dl_iterate_phdr`. Since linkers don't revisit previous libraries when resolving symbols, this causes a linker error due to an undefined reference to `dl_iterate_phdr`.

This is resolved by adding a second `-ldl` after `-lgcc` in the linker command-line.

2 years agoRollup merge of #91273 - Badel2:ice-index-str, r=estebank
Matthias Krüger [Fri, 3 Dec 2021 05:24:14 +0000 (06:24 +0100)]
Rollup merge of #91273 - Badel2:ice-index-str, r=estebank

Fix ICE #91268 by checking that the snippet ends with a `)`

Fix #91268

Previously it was assumed that the last character of `snippet` will be a `)`, so using `snippet.len() - 1` as an index should be safe. However as we see in the test, it is possible to enter that branch without a closing `)`, and it will trigger the panic if the last character happens to be multibyte.

The fix is to ensure that the snippet ends with `)`, and skip the suggestion otherwise.

2 years agoRollup merge of #91170 - jsha:preload-fonts, r=GuillaumeGomez
Matthias Krüger [Fri, 3 Dec 2021 05:24:13 +0000 (06:24 +0100)]
Rollup merge of #91170 - jsha:preload-fonts, r=GuillaumeGomez

rustdoc: preload fonts

Follow-up from #82315.

I noticed that font loading was so slow that even when loading from local disk, we get a flash of unstyled text (FOUT) followed by a reflow when the fonts load. With this change, we reliably get the appropriate fonts in the first render pass when loading locally, and we get it some of the time when loading from a website.

This only preloads woff2 versions. According to https://caniuse.com/?search=preload and https://caniuse.com/?search=woff2, all browsers that support preload also support woff2, so this is fine; we will never load two copies of a font.

Don't preload italic font faces because they aren't used on all pages.

Demo: https://rustdoc.crud.net/jsha/preload-fonts/std/string/struct.String.html

2 years agoRollup merge of #90854 - sanxiyn:unsized-and-uninhabited, r=estebank
Matthias Krüger [Fri, 3 Dec 2021 05:24:12 +0000 (06:24 +0100)]
Rollup merge of #90854 - sanxiyn:unsized-and-uninhabited, r=estebank

Type can be unsized and uninhabited

Fix #88150.

2 years agoRollup merge of #90269 - woppopo:const_option_expect, r=yaahc
Matthias Krüger [Fri, 3 Dec 2021 05:24:11 +0000 (06:24 +0100)]
Rollup merge of #90269 - woppopo:const_option_expect, r=yaahc

Make `Option::expect` unstably const

Tracking issue: #67441

2 years agoRollup merge of #88906 - Kixunil:box-maybe-uninit-write, r=dtolnay
Matthias Krüger [Fri, 3 Dec 2021 05:24:11 +0000 (06:24 +0100)]
Rollup merge of #88906 - Kixunil:box-maybe-uninit-write, r=dtolnay

Implement write() method for Box<MaybeUninit<T>>

This adds method similar to `MaybeUninit::write` main difference being
it returns owned `Box`. This can be used to elide copy from stack
safely, however it's not currently tested that the optimization actually
occurs.

Analogous methods are not provided for `Rc` and `Arc` as those need to
handle the possibility of sharing. Some version of them may be added in
the future.

This was discussed in #63291 which this change extends.

2 years agoAuto merge of #91339 - cbarrete:vecdeque-remove-grow-check, r=Mark-Simulacrum
bors [Fri, 3 Dec 2021 04:14:07 +0000 (04:14 +0000)]
Auto merge of #91339 - cbarrete:vecdeque-remove-grow-check, r=Mark-Simulacrum

Remove unnecessary check in VecDeque::grow

All callers already check that the buffer is full before calling
`grow()`. This is where it makes the most sense, since `grow()` is
`inline(never)` and we don't want to pay for a function call just for
that check.
It could also be argued that it would be correct to call `grow()` even
if the buffer wasn't full yet.
This change breaks no code since `grow()` is not `pub`.

2 years agoMerge commit '8da837185714cefbb261e93e9846afb11c1dc60e' into sync-rustfmt-subtree
Caleb Cartwright [Fri, 3 Dec 2021 03:35:30 +0000 (21:35 -0600)]
Merge commit '8da837185714cefbb261e93e9846afb11c1dc60e' into sync-rustfmt-subtree

2 years agoMerge pull request #5121 from calebcartwright/subtree-sync-2021-12-02
Caleb Cartwright [Fri, 3 Dec 2021 03:29:47 +0000 (21:29 -0600)]
Merge pull request #5121 from calebcartwright/subtree-sync-2021-12-02

subtree sync

2 years agoMerge remote-tracking branch 'upstream/master' into subtree-sync-2021-12-02
Caleb Cartwright [Fri, 3 Dec 2021 03:02:14 +0000 (21:02 -0600)]
Merge remote-tracking branch 'upstream/master' into subtree-sync-2021-12-02

2 years agoUpdate .stderr files
Eric Holk [Fri, 3 Dec 2021 00:12:25 +0000 (16:12 -0800)]
Update .stderr files

2 years agouse try_normalize_erasing_regions in needs_drop
b-naber [Thu, 2 Dec 2021 19:30:35 +0000 (20:30 +0100)]
use try_normalize_erasing_regions in needs_drop

2 years agosuppress warning about set_errno being unused on DragonFly
Ryan Zoeller [Thu, 2 Dec 2021 22:16:27 +0000 (16:16 -0600)]
suppress warning about set_errno being unused on DragonFly

Other targets allow this function to be unused, DragonFly just
misses out due to providing a specialization.

2 years agoAuto merge of #91469 - matthiaskrgr:rollup-xom3j55, r=matthiaskrgr
bors [Thu, 2 Dec 2021 21:58:48 +0000 (21:58 +0000)]
Auto merge of #91469 - matthiaskrgr:rollup-xom3j55, r=matthiaskrgr

Rollup of 12 pull requests

Successful merges:

 - #89954 (Fix legacy_const_generic doc arguments display)
 - #91321 (Handle placeholder regions in NLL type outlive constraints)
 - #91329 (Fix incorrect usage of `EvaluatedToOk` when evaluating `TypeOutlives`)
 - #91364 (Improve error message for incorrect field accesses through raw pointers)
 - #91387 (Clarify and tidy up explanation of E0038)
 - #91410 (Move `#![feature(const_precise_live_drops)]` checks earlier in the pipeline)
 - #91435 (Improve diagnostic for missing half of binary operator in `if` condition)
 - #91444 (disable tests in Miri that take too long)
 - #91457 (Add additional test from rust issue number 91068)
 - #91460 (Document how `last_os_error` should be used)
 - #91464 (Document file path case sensitivity)
 - #91466 (Improve the comments in `Symbol::interner`.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

2 years agoRollup merge of #91466 - nnethercote:Symbol-interner-comments, r=Mark-Simulacrum
Matthias Krüger [Thu, 2 Dec 2021 21:16:19 +0000 (22:16 +0100)]
Rollup merge of #91466 - nnethercote:Symbol-interner-comments, r=Mark-Simulacrum

Improve the comments in `Symbol::interner`.

r? `@Mark-Simulacrum`

2 years agoRollup merge of #91464 - ChrisDenton:doc-path-case-sensitivity, r=joshtriplett
Matthias Krüger [Thu, 2 Dec 2021 21:16:18 +0000 (22:16 +0100)]
Rollup merge of #91464 - ChrisDenton:doc-path-case-sensitivity, r=joshtriplett

Document file path case sensitivity

This describes the current behaviour of the standard library's pure path methods.

Fixes #66260.

2 years agoRollup merge of #91460 - ChrisDenton:doc-last-os-error, r=joshtriplett
Matthias Krüger [Thu, 2 Dec 2021 21:16:16 +0000 (22:16 +0100)]
Rollup merge of #91460 - ChrisDenton:doc-last-os-error, r=joshtriplett

Document how `last_os_error` should be used

It should be made clear that the state of the last OS error could change if another function call is made before the call to `Error::last_os_error()`.

Fixes: #53155
2 years agoRollup merge of #91457 - steffahn:additional_test_from_91068, r=jackh726
Matthias Krüger [Thu, 2 Dec 2021 21:16:15 +0000 (22:16 +0100)]
Rollup merge of #91457 - steffahn:additional_test_from_91068, r=jackh726

Add additional test from rust issue number 91068

see rust-lang/rust#91068

r? ``@jackh726``

2 years agoRollup merge of #91444 - RalfJung:miri-tests, r=dtolnay
Matthias Krüger [Thu, 2 Dec 2021 21:16:14 +0000 (22:16 +0100)]
Rollup merge of #91444 - RalfJung:miri-tests, r=dtolnay

disable tests in Miri that take too long

Comparing slices of length `usize::MAX` diverges in Miri. In fact these tests even diverge in rustc unless `-O` is passed. I tried this code to check that:
```rust
#![feature(slice_take)]

const EMPTY_MAX: &'static [()] = &[(); usize::MAX];

fn main() {
    let mut slice: &[_] = &[(); usize::MAX];
    println!("1");
    assert_eq!(Some(&[] as _), slice.take(usize::MAX..));
    println!("2");
    let remaining: &[_] = EMPTY_MAX;
    println!("3");
    assert_eq!(remaining, slice);
    println!("4");
}
```
So, disable these tests in Miri for now.

2 years agoRollup merge of #91435 - FabianWolff:issue-91421-if-then, r=lcnr
Matthias Krüger [Thu, 2 Dec 2021 21:16:13 +0000 (22:16 +0100)]
Rollup merge of #91435 - FabianWolff:issue-91421-if-then, r=lcnr

Improve diagnostic for missing half of binary operator in `if` condition

Fixes #91421. I've also changed it so that it doesn't consume the `else` token in the error case, because it will try to consume it again afterwards, leading to this incorrect error message (where the `else` reported as missing is actually there):
```
error: expected one of `.`, `;`, `?`, `else`, or an operator, found `{`
 --> src/main.rs:4:12
  |
4 |     } else { 4 };
  |            ^ expected one of `.`, `;`, `?`, `else`, or an operator
```

r? `@lcnr`

2 years agoRollup merge of #91410 - ecstatic-morse:const-precise-live-drops-take-2, r=oli-obk
Matthias Krüger [Thu, 2 Dec 2021 21:16:13 +0000 (22:16 +0100)]
Rollup merge of #91410 - ecstatic-morse:const-precise-live-drops-take-2, r=oli-obk

Move `#![feature(const_precise_live_drops)]` checks earlier in the pipeline

Should mitigate the issues found during MCP on #73255.

Once this is done, we should clean up the queries a bit, since I think `mir_drops_elaborated_and_const_checked` can be merged back into `mir_promoted`.

Fixes #90770.

cc ``@rust-lang/wg-const-eval``
r? ``@nikomatsakis`` (since they reviewed #71824)

2 years agoRollup merge of #91387 - graydon:E0038-clarification, r=wesleywiser
Matthias Krüger [Thu, 2 Dec 2021 21:16:12 +0000 (22:16 +0100)]
Rollup merge of #91387 - graydon:E0038-clarification, r=wesleywiser

Clarify and tidy up explanation of E0038

I ran into E0038 (specifically the `Self:Sized` constraint on object-safety) the other day and it seemed to me that the explanations I found floating around the internet were a bit .. wrong. Like they didn't make sense. And then I went and checked the official explanation here and it didn't make sense either.

As far as I can tell (reading through the history of the RFCs), two totally different aspects of object-safety have got tangled up in much of the writing on the subject:
  - Object-safety related to "not even theoretically possible" issues. This includes things like "methods that take or return Self by value", which obviously will never work for an unsized type in a world with fixed-size stack frames (and it'd be an opaque type anyways, which, ugh). This sort of thing was originally decided method-by-method, with non-object-safe methods stripped from objects; but in [RFC 0255](https://rust-lang.github.io/rfcs/0255-object-safety.html) this sort of per-impossible-method reasoning was made into a per-trait safety property (with the escape hatch left in where users could mark methods `where Self:Sized` to have them stripped before the trait's object safety is considered).
  - Object-safety related to "totally possible but ergonomically a little awkward" issues. Specifically in a trait with `Trait:Sized`, there's no a priori reason why this constraint makes the trait impossible to make into an object -- imagine it had nothing but harmless `&self`-taking methods. No problem! Who cares if the Trait requires its implementing types to be sized? As far as I can tell reading the history here, in both RFC 0255 and then later in [RFC 0546](https://rust-lang.github.io/rfcs/0546-Self-not-sized-by-default.html) it seems that the motivation for making `Trait:Sized` be non-object-safe has _nothing to do_ with the impossibility of making objects out of such types, and everything to do with enabling "[a trait object SomeTrait to implement the trait SomeTrait](https://rust-lang.github.io/rfcs/0546-Self-not-sized-by-default.html#motivation)". That is, since `dyn Trait` is unsized, if `Trait:Sized` then you can never have the automatic (and reasonable) ergonomic implicit `impl Trait for dyn Trait`. And the authors of that RFC really wanted that automatic implicit implementation of `Trait` for `dyn Trait`. So they just defined `Trait:Sized` as non-object safe -- no `dyn Trait` can ever exist that the compiler can't synthesize such an impl for. Well enough!

However, I noticed in my reading-and-reconstruction that lots of documentation on the internet, including forum and Q&A site answers and (most worrying) the compiler explanation all kinda grasp at something like the first ("not theoretically possible") explanation, and fail to mention the second ("just an ergonomic constraint") explanation. So I figured I'd clean up the docs to clarify, maybe confuse the next person less (unless of course I'm misreading the history here and misunderstanding motives -- please let me know if so!)

While here I also did some cleanups:

  - Rewrote the preamble, trying to help the user get a little better oriented (I found the existing preamble a bit scattered).
  - Modernized notation (using `dyn Trait`)
  - Changed the section headings to all be written with the same logical sense: to all be written as "conditions that violate object safety" rather than a mix of that and the negated form "conditions that must not happen in order to ensure object safety".

I think there's a fair bit more to clean up in this doc -- the later sections get a bit rambly and I suspect there should be a completely separated-out section covering the `where Self:Sized` escape hatch for instructing the compiler to "do the old thing" and strip methods off traits when turning them into objects (it's a bit buried as a digression in the individual sub-error sections). But I did what I had time for now.

2 years agoRollup merge of #91364 - FabianWolff:issue-91210-ptr-field, r=oli-obk
Matthias Krüger [Thu, 2 Dec 2021 21:16:11 +0000 (22:16 +0100)]
Rollup merge of #91364 - FabianWolff:issue-91210-ptr-field, r=oli-obk

Improve error message for incorrect field accesses through raw pointers

Fixes #91210.

2 years agoRollup merge of #91329 - Aaron1011:modulo-regions-test, r=jackh726
Matthias Krüger [Thu, 2 Dec 2021 21:16:10 +0000 (22:16 +0100)]
Rollup merge of #91329 - Aaron1011:modulo-regions-test, r=jackh726

Fix incorrect usage of `EvaluatedToOk` when evaluating `TypeOutlives`

A global predicate is not guarnatenteed to outlive all regions.
If the predicate involves late-bound regions, then it may fail
to outlive other regions (e.g. `for<'b> &'b bool: 'static` does not
hold)

We now only produce `EvaluatedToOk` when a global predicate has no
late-bound regions - in that case, the ony region that can be present
in the type is 'static

2 years agoRollup merge of #91321 - matthewjasper:constaint-placeholders, r=jackh726
Matthias Krüger [Thu, 2 Dec 2021 21:16:09 +0000 (22:16 +0100)]
Rollup merge of #91321 - matthewjasper:constaint-placeholders, r=jackh726

Handle placeholder regions in NLL type outlive constraints

Closes #76168

2 years agoRollup merge of #89954 - GuillaumeGomez:legacy-const-generic-doc, r=Amanieu
Matthias Krüger [Thu, 2 Dec 2021 21:16:08 +0000 (22:16 +0100)]
Rollup merge of #89954 - GuillaumeGomez:legacy-const-generic-doc, r=Amanieu

Fix legacy_const_generic doc arguments display

Fixes https://github.com/rust-lang/rust/issues/83167.

cc ``@Amanieu``

2 years agoImprove the comments in `Symbol::interner`.
Nicholas Nethercote [Thu, 2 Dec 2021 20:12:31 +0000 (07:12 +1100)]
Improve the comments in `Symbol::interner`.

2 years agoDocument file path case sensitivity
Chris Denton [Thu, 2 Dec 2021 19:37:25 +0000 (19:37 +0000)]
Document file path case sensitivity

2 years agoCode review feedback
Eric Holk [Thu, 2 Dec 2021 19:36:48 +0000 (11:36 -0800)]
Code review feedback

Add a note about `IntoFuture` in error messages where T is not a future.

Change await-into-future.rs to be a run-pass test.

2 years agoMake array::{try_from_fn, try_map} and Iterator::try_find generic over Try
Scott McMurray [Sat, 27 Nov 2021 07:09:34 +0000 (23:09 -0800)]
Make array::{try_from_fn, try_map} and Iterator::try_find generic over Try

Fixes 85115

This only updates unstable functions.

`array::try_map` didn't actually exist before, despite the tracking issue 79711 still being open from the old PR 79713.

2 years agoAuto merge of #91318 - eggyal:reduce-boilerplate-around-infallible-folders, r=jackh726
bors [Thu, 2 Dec 2021 19:12:00 +0000 (19:12 +0000)]
Auto merge of #91318 - eggyal:reduce-boilerplate-around-infallible-folders, r=jackh726

Reduce boilerplate around infallible folders

Further to https://github.com/rust-lang/rust/pull/91230#issuecomment-981059666

r? `@jackh726`

2 years agoDocument how `last_os_error` should be used
Chris Denton [Thu, 2 Dec 2021 17:51:44 +0000 (17:51 +0000)]
Document how `last_os_error` should be used

2 years agoChange to check-pass
Jack Huey [Thu, 2 Dec 2021 17:11:31 +0000 (12:11 -0500)]
Change to check-pass

2 years agoAdd additional test from rust issue number 91068
Frank Steffahn [Thu, 2 Dec 2021 16:46:57 +0000 (17:46 +0100)]
Add additional test from rust issue number 91068

2 years agoImplement write() method for Box<MaybeUninit<T>>
Martin Habovstiak [Mon, 13 Sep 2021 13:44:27 +0000 (15:44 +0200)]
Implement write() method for Box<MaybeUninit<T>>

This adds method similar to `MaybeUninit::write` main difference being
it returns owned `Box`. This can be used to elide copy from stack
safely, however it's not currently tested that the optimization actually
occurs.

Analogous methods are not provided for `Rc` and `Arc` as those need to
handle the possibility of sharing. Some version of them may be added in
the future.

This was discussed in #63291 which this change extends.

2 years agoRename TypeFolderFallible to FallibleTypeFolder
Alan Egerton [Wed, 1 Dec 2021 15:11:24 +0000 (15:11 +0000)]
Rename TypeFolderFallible to FallibleTypeFolder

2 years agoUpdate compiler/rustc_middle/src/ty/fold.rs
eggyal [Wed, 1 Dec 2021 12:48:49 +0000 (12:48 +0000)]
Update compiler/rustc_middle/src/ty/fold.rs

Co-authored-by: lcnr <rust@lcnr.de>
2 years agoReduce boilerplate around infallible folders
Alan Egerton [Wed, 1 Dec 2021 00:55:57 +0000 (00:55 +0000)]
Reduce boilerplate around infallible folders

2 years agoRemove no-longer used `IdFunctor::map_id`
Alan Egerton [Sun, 28 Nov 2021 15:07:25 +0000 (15:07 +0000)]
Remove no-longer used `IdFunctor::map_id`

2 years agoAuto merge of #91455 - matthiaskrgr:rollup-gix2hy6, r=matthiaskrgr
bors [Thu, 2 Dec 2021 14:53:20 +0000 (14:53 +0000)]
Auto merge of #91455 - matthiaskrgr:rollup-gix2hy6, r=matthiaskrgr

Rollup of 4 iffy pull requests

Successful merges:

 - #89234 (Disallow non-c-like but "fieldless" ADTs from being casted to integer if they use arbitrary enum discriminant)
 - #91045 (Issue 90702 fix: Stop treating some crate loading failures as fatal errors)
 - #91394 (Bump stage0 compiler)
 - #91411 (Enable svh tests on msvc)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

2 years agoRollup merge of #91411 - ChrisDenton:valid-paths, r=petrochenkov
Matthias Krüger [Thu, 2 Dec 2021 14:52:04 +0000 (15:52 +0100)]
Rollup merge of #91411 - ChrisDenton:valid-paths, r=petrochenkov

Enable svh tests on msvc

These tests were ignored for msvc in #30778 because of additional notes that were being added for some reason. I'm fairly confident this has been fixed in the intervening years so lets try re-enabling these tests.

Fixes #31306

2 years agoRollup merge of #91394 - Mark-Simulacrum:bump-stage0, r=pietroalbini
Matthias Krüger [Thu, 2 Dec 2021 14:52:03 +0000 (15:52 +0100)]
Rollup merge of #91394 - Mark-Simulacrum:bump-stage0, r=pietroalbini

Bump stage0 compiler

r? `@pietroalbini` (or anyone else)

2 years agoRollup merge of #91045 - mjptree:issue-90702-fix, r=petrochenkov
Matthias Krüger [Thu, 2 Dec 2021 14:52:01 +0000 (15:52 +0100)]
Rollup merge of #91045 - mjptree:issue-90702-fix, r=petrochenkov

Issue 90702 fix: Stop treating some crate loading failures as fatal errors

Surface mulitple `extern crate` resolution errors at a time.

This is achieved by creating a dummy crate, instead of aborting directly after the resolution error. The `ExternCrateError` has been added to allow propagating the resolution error from `rustc_metadata` crate to the `rustc_resolve` with a minimal public surface. The `import_extern_crate` function is a block that was factored out from `build_reduced_graph_for_item` for better organization. The only added functionality made to it where the added error handling in the `process_extern_crate` call. The remaining bits in this function are the same as before.

Resolves #90702

r? `@petrochenkov`

2 years agoRollup merge of #89234 - nbdd0121:discr, r=jackh726
Matthias Krüger [Thu, 2 Dec 2021 14:52:00 +0000 (15:52 +0100)]
Rollup merge of #89234 - nbdd0121:discr, r=jackh726

Disallow non-c-like but "fieldless" ADTs from being casted to integer if they use arbitrary enum discriminant

Code like

```rust
#[repr(u8)]
enum Enum {
    Foo /* = 0 */,
    Bar(),
    Baz{}
}

let x = Enum::Bar() as u8;
```

seems to be unintentionally allowed so we couldn't disallow them now ~~, but we could disallow them if arbitrary enum discriminant is used before 1.56 hits stable~~ (stabilization was reverted).

Related: #88621

`@rustbot` label +T-lang

2 years agoDocument Windows TLS drop behaviour
Chris Denton [Thu, 2 Dec 2021 13:52:35 +0000 (13:52 +0000)]
Document Windows TLS drop behaviour

2 years agoAuto merge of #91354 - fee1-dead:const_env, r=spastorino
bors [Thu, 2 Dec 2021 11:48:58 +0000 (11:48 +0000)]
Auto merge of #91354 - fee1-dead:const_env, r=spastorino

Cleanup: Eliminate ConstnessAnd

This is almost a behaviour-free change and purely a refactoring. "almost" because we appear to be using the wrong ParamEnv somewhere already, and this is now exposed by failing a test using the unstable `~const` feature.

We most definitely need to review all `without_const` and at some point should probably get rid of many of them by using `TraitPredicate` instead of `TraitRef`.

This is a continuation of https://github.com/rust-lang/rust/pull/90274.

r? `@oli-obk`

cc `@spastorino` `@ecstatic-morse`

2 years agoAdd test for legacy-const-generic arguments
Guillaume Gomez [Sat, 16 Oct 2021 15:52:24 +0000 (17:52 +0200)]
Add test for legacy-const-generic arguments

2 years agoTransform const generics if the function uses rustc_legacy_const_generics
Guillaume Gomez [Sat, 16 Oct 2021 15:52:06 +0000 (17:52 +0200)]
Transform const generics if the function uses rustc_legacy_const_generics

2 years agoAuto merge of #91291 - GuillaumeGomez:const-deref-method, r=camelid
bors [Thu, 2 Dec 2021 06:11:05 +0000 (06:11 +0000)]
Auto merge of #91291 - GuillaumeGomez:const-deref-method, r=camelid

Fix const deref methods display

Fixes https://github.com/rust-lang/rust/issues/90855 (more information in the issue).

r? `@camelid`

2 years agodisable tests in Miri that take too long
Ralf Jung [Thu, 2 Dec 2021 03:48:59 +0000 (22:48 -0500)]
disable tests in Miri that take too long

2 years agoAuto merge of #91003 - psumbera:sparc64-abi, r=nagisa
bors [Thu, 2 Dec 2021 02:59:44 +0000 (02:59 +0000)]
Auto merge of #91003 - psumbera:sparc64-abi, r=nagisa

fix sparc64 ABI for aggregates with floating point members

Fixes #86163

2 years agoDetermine when new comment lines are needed for itemized blocks
Yacin Tmimi [Fri, 19 Nov 2021 23:52:52 +0000 (18:52 -0500)]
Determine when new comment lines are needed for itemized blocks

Fixes 5088

Previously, rustfmt would add a new comment line anytime it reformatted
an itemized block within a comment when ``wrap_comments=true``. This
would lead to rustfmt adding empty comments with trailing whitespace.

Now, new comment lines are only added if the original comment spanned
multiple lines, if the comment needs to be wrapped, or if the comment
originally started with an empty comment line.

2 years agoAuto merge of #90446 - cjgillot:late-elided, r=jackh726
bors [Wed, 1 Dec 2021 23:22:43 +0000 (23:22 +0000)]
Auto merge of #90446 - cjgillot:late-elided, r=jackh726

Lint elided lifetimes in path during lifetime resolution.

The lifetime elision lint is known to be brittle and can be redundant with later lifetime resolution errors. This PR aims to remove the redundancy by performing the lint after lifetime resolution.

This PR proposes to carry the information that an elision should be linted against by using a special `LifetimeName`. I am not certain this is the best solution, but it is certainly the easiest.

Fixes https://github.com/rust-lang/rust/issues/60199
Fixes https://github.com/rust-lang/rust/issues/55768
Fixes https://github.com/rust-lang/rust/issues/63110
Fixes https://github.com/rust-lang/rust/issues/71957

2 years agoImprove suggestion for extern crate self error message
Michael [Fri, 26 Nov 2021 21:39:44 +0000 (21:39 +0000)]
Improve suggestion for extern crate self error message

2 years agoImprove diagnostic for missing half of binary operator in `if` condition
Fabian Wolff [Wed, 1 Dec 2021 21:36:50 +0000 (22:36 +0100)]
Improve diagnostic for missing half of binary operator in `if` condition

2 years agoStop treating extern crate loading failures as fatal errors
Michael [Fri, 26 Nov 2021 20:37:56 +0000 (20:37 +0000)]
Stop treating extern crate loading failures as fatal errors

2 years agoFactor out build reduced graph for extern crate
Michael [Fri, 26 Nov 2021 19:18:51 +0000 (19:18 +0000)]
Factor out build reduced graph for extern crate

2 years agoAuto merge of #91433 - matthiaskrgr:rollup-118ql06, r=matthiaskrgr
bors [Wed, 1 Dec 2021 20:14:07 +0000 (20:14 +0000)]
Auto merge of #91433 - matthiaskrgr:rollup-118ql06, r=matthiaskrgr

Rollup of 5 pull requests

Successful merges:

 - #88502 (Add slice take methods)
 - #91313 (expand: Turn `ast::Crate` into a first class expansion target)
 - #91424 (Update LLVM with patches for better llvm-cov diagnostics)
 - #91425 (Include lint errors in error count for `-Ztreat-err-as-bug`)
 - #91430 (Add tests for `normalize-docs` overflow errors)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

2 years agoDisallow non-c-like but "fieldless" ADTs from being casted to integer...
Gary Guo [Fri, 24 Sep 2021 20:58:25 +0000 (21:58 +0100)]
Disallow non-c-like but "fieldless" ADTs from being casted to integer...

... if they use arbitrary enum discriminant. Code like

```rust
enum Enum {
    Foo = 1,
    Bar(),
    Baz{}
}
```

seems to be unintentionally allowed so we couldn't disallow them now,
but we could disallow them if arbitrary enum discriminant is used before
1.56 hits stable.

2 years agoRollup merge of #91430 - jyn514:normalize-fallible, r=jackh726
Matthias Krüger [Wed, 1 Dec 2021 19:57:48 +0000 (20:57 +0100)]
Rollup merge of #91430 - jyn514:normalize-fallible, r=jackh726

Add tests for `normalize-docs` overflow errors

`@b-naber` do you understand why using `try_normalize_erasing_regions` doesn't silence these cycle errors? Rustdoc isn't emitting them, rustc is aborting before returning an error, even though the function has `try_` in the name.

cc https://github.com/rust-lang/rust/issues/82692, https://github.com/rust-lang/rust/pull/91255

2 years agoRollup merge of #91425 - jyn514:treat-lint-err-as-bug, r=oli-obk
Matthias Krüger [Wed, 1 Dec 2021 19:57:47 +0000 (20:57 +0100)]
Rollup merge of #91425 - jyn514:treat-lint-err-as-bug, r=oli-obk

Include lint errors in error count for `-Ztreat-err-as-bug`

This was a regression from https://github.com/rust-lang/rust/pull/87337;
the `panic_if_treat_err_as_bug` function only checked the number of hard
errors, not the number of lint errors.

r? `@oli-obk`

2 years agoRollup merge of #91424 - richkadel:llvm-patch-instrproferror, r=tmandry
Matthias Krüger [Wed, 1 Dec 2021 19:57:46 +0000 (20:57 +0100)]
Rollup merge of #91424 - richkadel:llvm-patch-instrproferror, r=tmandry

Update LLVM with patches for better llvm-cov diagnostics

Cherry-picks
https://github.com/llvm/llvm-project/commit/ee88b8d63e475a75ae525563edfa95f6fcaac83a
and
https://github.com/llvm/llvm-project/commit/126e7611c70ca41782aa851c2bec132607eb8127

These patches to LLVM were added to help debug occasional errors that
cause coverage reporting to fail. Prior to this patch, the only messaging
was that the coverage data was malformed. Hopefully the improved
messaging will help identify the root cause of these errors, when they
arise, so we can make corrections to coverage output from Rust.

r? `@tmandry`

2 years agoRollup merge of #91313 - petrochenkov:cratexp, r=Aaron1011
Matthias Krüger [Wed, 1 Dec 2021 19:57:43 +0000 (20:57 +0100)]
Rollup merge of #91313 - petrochenkov:cratexp, r=Aaron1011

expand: Turn `ast::Crate` into a first class expansion target

And stop creating a fake `mod` item for the crate root when expanding a crate, thus addressing FIXMEs left in https://github.com/rust-lang/rust/pull/82238, and making a step towards a proper support for crate-level macro attributes (cc #54726).

I haven't added token collection support for the whole crate in this PR, maybe later.
r? `@Aaron1011`

2 years agoRollup merge of #88502 - ibraheemdev:slice-take, r=dtolnay
Matthias Krüger [Wed, 1 Dec 2021 19:57:42 +0000 (20:57 +0100)]
Rollup merge of #88502 - ibraheemdev:slice-take, r=dtolnay

Add slice take methods

Revival of #62282

This PR adds the following slice methods:

- `take`
- `take_mut`
- `take_first`
- `take_first_mut`
- `take_last`
- `take_last_mut`

r? `@LukasKalbertodt`

2 years agoUse `try_normalize_erasing_regions` instead of a custom infer context
Joshua Nelson [Wed, 1 Dec 2021 19:00:27 +0000 (19:00 +0000)]
Use `try_normalize_erasing_regions` instead of a custom infer context

This unfortunately is still giving an unsilenceable overflow error :(

2 years agoReplace `nth_char(0)` with `next()` in `cursor.first()`
Julian Wollersberger [Tue, 30 Nov 2021 15:06:58 +0000 (16:06 +0100)]
Replace `nth_char(0)` with `next()` in `cursor.first()`
and optimize the iterator returned by `tokenize().

This improves lexer performance by 35%

2 years agoAdd regression test for #90770
Dylan MacKenzie [Wed, 1 Dec 2021 18:04:21 +0000 (10:04 -0800)]
Add regression test for #90770

2 years agoAuto merge of #91275 - camelid:deny-test-warnings, r=jyn514
bors [Wed, 1 Dec 2021 16:41:52 +0000 (16:41 +0000)]
Auto merge of #91275 - camelid:deny-test-warnings, r=jyn514

Deny warnings in rustdoc non-UI tests

These warnings were silently ignored since they did not appear in a
`.stderr` file and did not fail the test. With this change, warnings in
tests are denied, causing the tests to fail if they have warnings.

This change has already led me to find a bug in rustdoc (#91274) and a
useless test (`src/test/rustdoc/primitive/primitive-generic-impl.rs`,
though its uselessness is unrelated to its warnings).

r? `@jyn514`

2 years agoInclude lint errors in error count for `-Ztreat-err-as-bug`
Joshua Nelson [Wed, 1 Dec 2021 16:32:55 +0000 (16:32 +0000)]
Include lint errors in error count for `-Ztreat-err-as-bug`

This was a regression from https://github.com/rust-lang/rust/pull/87337;
the `panic_if_treat_err_as_bug` function only checked the number of hard
errors, not the number of lint errors.

2 years agoUpdate LLVM with patches for better llvm-cov diagnostics
Rich Kadel [Tue, 30 Nov 2021 23:40:55 +0000 (15:40 -0800)]
Update LLVM with patches for better llvm-cov diagnostics

Cherry-picks
https://github.com/llvm/llvm-project/commit/ee88b8d63e475a75ae525563edfa95f6fcaac83a
and
https://github.com/llvm/llvm-project/commit/126e7611c70ca41782aa851c2bec132607eb8127

These patches to LLVM were added to help debug occasional errors that
cause coverage reporting to fail. Prior to this patch, the only messaging
was that the coverage data was malformed. Hopefully the improved
messaging will help identify the root cause of these errors, when they
arise, so we can make corrections to coverage output from Rust.

2 years agoFormat
Deadbeef [Wed, 1 Dec 2021 15:33:37 +0000 (23:33 +0800)]
Format

2 years agoTODO => FIXME
Deadbeef [Wed, 1 Dec 2021 15:32:36 +0000 (23:32 +0800)]
TODO => FIXME

2 years agoCache with consistent env and bound
Deadbeef [Wed, 1 Dec 2021 15:22:42 +0000 (23:22 +0800)]
Cache with consistent env and bound

2 years agoAuto merge of #91255 - b-naber:normalization-ice, r=jackh276
bors [Wed, 1 Dec 2021 13:33:33 +0000 (13:33 +0000)]
Auto merge of #91255 - b-naber:normalization-ice, r=jackh276

Implement version of normalize_erasing_regions that allows for normalization failure

Fixes https://github.com/rust-lang/rust/issues/59324
Fixes https://github.com/rust-lang/rust/issues/67684
Fixes https://github.com/rust-lang/rust/issues/69398
Fixes https://github.com/rust-lang/rust/issues/71113
Fixes https://github.com/rust-lang/rust/issues/82079
Fixes #85103
Fixes https://github.com/rust-lang/rust/issues/88856
Fixes #91231
Fixes https://github.com/rust-lang/rust/issues/91234

Previously we called `normalize_erasing_regions` inside `layout_of`. `normalize_erasing_regions` assumes that the normalization succeeds. Since some `layout_of` calls happen before typecheck has finished, we introduce a new variant that allows for returning an error.

2 years agorebase
b-naber [Wed, 1 Dec 2021 12:14:19 +0000 (13:14 +0100)]
rebase

2 years agoaddress review
b-naber [Tue, 30 Nov 2021 23:20:57 +0000 (00:20 +0100)]
address review

2 years agofix query description
b-naber [Fri, 26 Nov 2021 22:41:22 +0000 (23:41 +0100)]
fix query description

2 years agoremove static_assert_size on InterpError
b-naber [Fri, 26 Nov 2021 22:39:48 +0000 (23:39 +0100)]
remove static_assert_size on InterpError

2 years agomore fixed issues
b-naber [Fri, 26 Nov 2021 22:37:24 +0000 (23:37 +0100)]
more fixed issues

2 years agoadd tests and bless existing ones
b-naber [Fri, 26 Nov 2021 17:37:29 +0000 (18:37 +0100)]
add tests and bless existing ones