]>
git.lizzy.rs Git - rust.git/log
Jeremy Kolb [Sat, 11 Jul 2020 21:29:45 +0000 (17:29 -0400)]
Update lsp-types to account for new CodeActionKind structure
bors[bot] [Sat, 11 Jul 2020 20:13:07 +0000 (20:13 +0000)]
Merge #5323
5323: Rewrite item_tree tests to expect r=matklad a=matklad
insta review wouldn't update the test, so ...
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sat, 11 Jul 2020 20:11:31 +0000 (22:11 +0200)]
Rewrite item_tree tests to expect
insta review wouldn't update the test, so ...
Aleksey Kladov [Sat, 11 Jul 2020 19:53:32 +0000 (21:53 +0200)]
Extern fns are implicitly unsafe
closes #4865
bors[bot] [Sat, 11 Jul 2020 18:02:33 +0000 (18:02 +0000)]
Merge #5320
5320: Bump macro recursion limit in release r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sat, 11 Jul 2020 18:01:56 +0000 (20:01 +0200)]
Bump macro recursion limit in release
bors[bot] [Sat, 11 Jul 2020 16:40:56 +0000 (16:40 +0000)]
Merge #5318
5318: More tight recursion limit when expanding macros in function bodies r=matklad a=matklad
cc #4944
cc #5317
This doesn't fully close #4944 -- looks like we hit SO in syntax
highlighting, when we use `Semantics::expand_macro`.
Seems like we need to place expansion limit on the macro itself (store
it as a part of MacroCallId?)!
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sat, 11 Jul 2020 16:35:35 +0000 (18:35 +0200)]
More tight recursion limit when expanding macros in function bodies
cc #4944
cc #5317
This doesn't fully close #4944 -- looks like we hit SO in syntax
highlighting, when we use `Semantics::expand_macro`.
Seems like we need to place expansion limit on the macro itself (store
it as a part of MacroCallId?)!
bors[bot] [Sat, 11 Jul 2020 12:59:04 +0000 (12:59 +0000)]
Merge #5315
5315: Minor r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sat, 11 Jul 2020 12:57:07 +0000 (14:57 +0200)]
Minor
bors[bot] [Sat, 11 Jul 2020 12:52:20 +0000 (12:52 +0000)]
Merge #5314
5314: Use dedicated semantic highlight tag for parameters r=matklad a=matklad
closes #5106
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sat, 11 Jul 2020 12:50:00 +0000 (14:50 +0200)]
Use dedicated semantic highlight tag for parameters
closes #5106
bors[bot] [Sat, 11 Jul 2020 11:31:32 +0000 (11:31 +0000)]
Merge #5313
5313: no doctests r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sat, 11 Jul 2020 11:31:02 +0000 (13:31 +0200)]
no doctests
bors[bot] [Sat, 11 Jul 2020 10:57:21 +0000 (10:57 +0000)]
Merge #5312
5312: Make slow test parallel r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sat, 11 Jul 2020 10:56:44 +0000 (12:56 +0200)]
Make slow test parallel
bors[bot] [Sat, 11 Jul 2020 10:46:25 +0000 (10:46 +0000)]
Merge #5311
5311: Fix goto definition for type alias type parameters r=matklad a=matklad
closes https://github.com/rust-analyzer/rust-analyzer/issues/5042
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sat, 11 Jul 2020 10:45:30 +0000 (12:45 +0200)]
Fix goto definition for type alias type parameters
closes https://github.com/rust-analyzer/rust-analyzer/issues/5042
bors[bot] [Sat, 11 Jul 2020 10:34:14 +0000 (10:34 +0000)]
Merge #5310
5310: Reduce visibility r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sat, 11 Jul 2020 10:31:50 +0000 (12:31 +0200)]
Reduce visibility
bors[bot] [Sat, 11 Jul 2020 09:58:56 +0000 (09:58 +0000)]
Merge #5309
5309: Make sure there are no commands in code actions r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sat, 11 Jul 2020 09:46:31 +0000 (11:46 +0200)]
Make sure there are no commands in code actions
bors[bot] [Sat, 11 Jul 2020 09:51:31 +0000 (09:51 +0000)]
Merge #4996
4996: Correctly generate new struct field in file containing struct def r=matklad a=TimoFreiberg
WIP because the test doesn't pass.
Testing the fix by hand looked good, although quickfixes seem to not support setting the editor cursor yet, which i think we want for "generate missing defs from usage" fixes.
Co-authored-by: Timo Freiberg <timo.freiberg@gmail.com>
bors[bot] [Sat, 11 Jul 2020 01:42:18 +0000 (01:42 +0000)]
Merge #5307
5307: disable profiling r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sat, 11 Jul 2020 01:41:52 +0000 (03:41 +0200)]
disable profiling
Aleksey Kladov [Sat, 11 Jul 2020 01:39:44 +0000 (03:39 +0200)]
Profiling example
bors[bot] [Sat, 11 Jul 2020 01:05:15 +0000 (01:05 +0000)]
Merge #5305
5305: Profiling tweaks r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sat, 11 Jul 2020 01:04:37 +0000 (03:04 +0200)]
Profiling tweaks
bors[bot] [Fri, 10 Jul 2020 23:39:44 +0000 (23:39 +0000)]
Merge #5304
5304: Don't show error when speculatively reloading workspace r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 10 Jul 2020 23:39:06 +0000 (01:39 +0200)]
Don't show error when speculatively reloading workspace
bors[bot] [Fri, 10 Jul 2020 23:31:57 +0000 (23:31 +0000)]
Merge #5303
5303: Speed up completion r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 10 Jul 2020 23:26:24 +0000 (01:26 +0200)]
Speed up completion
bors[bot] [Fri, 10 Jul 2020 21:57:56 +0000 (21:57 +0000)]
Merge #5302
5302: Simplify r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 10 Jul 2020 21:57:10 +0000 (23:57 +0200)]
Simplify
bors[bot] [Fri, 10 Jul 2020 21:46:02 +0000 (21:46 +0000)]
Merge #5301
5301: Don't spawn notify unnecessary r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 10 Jul 2020 21:39:25 +0000 (23:39 +0200)]
Don't spawn notify unnecessary
bors[bot] [Fri, 10 Jul 2020 21:20:36 +0000 (21:20 +0000)]
Merge #5300
5300: Update deps r=matklad a=kjeremy
Bumps tracing to 0.1.16 which reduces monomorphization: https://github.com/rust-analyzer/rust-analyzer/issues/1987#issuecomment-
654711560
Co-authored-by: kjeremy <kjeremy@gmail.com>
kjeremy [Fri, 10 Jul 2020 21:14:24 +0000 (17:14 -0400)]
Update deps
bors[bot] [Fri, 10 Jul 2020 20:31:11 +0000 (20:31 +0000)]
Merge #5299
5299: Reload when new example/test/etc is added r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 10 Jul 2020 20:29:40 +0000 (22:29 +0200)]
Optimize VFS processing
Aleksey Kladov [Fri, 10 Jul 2020 20:28:41 +0000 (22:28 +0200)]
Sort cargo metadata
See https://github.com/rust-lang/cargo/issues/8477
We need this to prevent spurious workspace reloads
Aleksey Kladov [Fri, 10 Jul 2020 16:53:01 +0000 (18:53 +0200)]
Add profiling calls
Aleksey Kladov [Fri, 10 Jul 2020 16:48:39 +0000 (18:48 +0200)]
Also reload when adding new examples, tests, etc
Timo Freiberg [Mon, 22 Jun 2020 19:29:11 +0000 (21:29 +0200)]
Correctly generate new struct field in file containing struct def
bors[bot] [Fri, 10 Jul 2020 16:22:38 +0000 (16:22 +0000)]
Merge #5298
5298: Better caret placement when filling match arms r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 10 Jul 2020 16:22:04 +0000 (18:22 +0200)]
Better caret placement when filling match arms
bors[bot] [Fri, 10 Jul 2020 15:57:18 +0000 (15:57 +0000)]
Merge #5297
5297: Better name r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 10 Jul 2020 15:56:55 +0000 (17:56 +0200)]
Better name
bors[bot] [Fri, 10 Jul 2020 15:43:14 +0000 (15:43 +0000)]
Merge #5296
5296: Don't add braces after struct r=matklad a=matklad
Unit structs are a thing
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 10 Jul 2020 15:42:18 +0000 (17:42 +0200)]
Don't add braces after struct
Unit structs are a thing
Aleksey Kladov [Fri, 10 Jul 2020 15:41:43 +0000 (17:41 +0200)]
Better complete expression keywords
bors[bot] [Fri, 10 Jul 2020 14:29:37 +0000 (14:29 +0000)]
Merge #5295
5295: Complete params in nested fns r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 10 Jul 2020 14:29:14 +0000 (16:29 +0200)]
Complete params in nested fns
bors[bot] [Fri, 10 Jul 2020 14:08:36 +0000 (14:08 +0000)]
Merge #5294
5294: Complete parameters more aggressively r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 10 Jul 2020 14:07:12 +0000 (16:07 +0200)]
Complete parameters more aggressively
Aleksey Kladov [Fri, 10 Jul 2020 14:05:01 +0000 (16:05 +0200)]
Refresh tests
bors[bot] [Fri, 10 Jul 2020 13:35:46 +0000 (13:35 +0000)]
Merge #5293
5293: Automatically reload project info on Cargo.toml changes r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 10 Jul 2020 13:27:34 +0000 (15:27 +0200)]
Automatically reload project info on Cargo.toml changes
bors[bot] [Fri, 10 Jul 2020 12:47:23 +0000 (12:47 +0000)]
Merge #5292
5292: Goto type definition improvements r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 10 Jul 2020 12:42:26 +0000 (14:42 +0200)]
Look through Arc for goto type definition
Aleksey Kladov [Fri, 10 Jul 2020 12:39:05 +0000 (14:39 +0200)]
Simplify tests
Aleksey Kladov [Fri, 10 Jul 2020 12:11:31 +0000 (14:11 +0200)]
Dont expose ID
Aleksey Kladov [Fri, 10 Jul 2020 12:09:31 +0000 (14:09 +0200)]
Rename
Aleksey Kladov [Fri, 10 Jul 2020 12:08:35 +0000 (14:08 +0200)]
Goto type definition works for self
bors[bot] [Fri, 10 Jul 2020 09:33:29 +0000 (09:33 +0000)]
Merge #5286
5286: Only take first 500 syntax errors r=jonas-schievink a=yihuang
Too many syntax errors make some editor/ide slow, fix #3434.
Co-authored-by: yihuang <yi.codeplayer@gmail.com>
yihuang [Fri, 10 Jul 2020 07:41:41 +0000 (15:41 +0800)]
Only take first 500 syntax errors
Too many syntax errors make some editor/ide slow, fix #3434.
bors[bot] [Fri, 10 Jul 2020 09:09:09 +0000 (09:09 +0000)]
Merge #5288
5288: Avoid accidently stumping over config values r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 9 Jul 2020 22:28:12 +0000 (00:28 +0200)]
Avoid accidently stumping over config values
bors[bot] [Thu, 9 Jul 2020 17:22:16 +0000 (17:22 +0000)]
Merge #5285
5285: Don't mess with cursor position when adding hashes r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 9 Jul 2020 17:21:41 +0000 (19:21 +0200)]
Don't mess with cursor position when adding hashes
bors[bot] [Thu, 9 Jul 2020 16:49:44 +0000 (16:49 +0000)]
Merge #5284
5284: Fold struct literals r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 9 Jul 2020 16:49:17 +0000 (18:49 +0200)]
Fold struct literals
bors[bot] [Thu, 9 Jul 2020 16:28:35 +0000 (16:28 +0000)]
Merge #5283
5283: Arg count mismatch diagnostic: Handle tuple struct/variant ctors r=jonas-schievink a=jonas-schievink
I didn't know `callable_item_signature` was a thing, that makes this really easy.
bors r+
Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
Jonas Schievink [Thu, 9 Jul 2020 16:24:02 +0000 (18:24 +0200)]
arg count mismatch: handle tuple ctors
bors[bot] [Thu, 9 Jul 2020 15:34:43 +0000 (15:34 +0000)]
Merge #5270
5270: Add argument count mismatch diagnostic r=matklad a=jonas-schievink
Closes https://github.com/rust-analyzer/rust-analyzer/issues/4025.
This currently has one false positive on this line, where `max` is resolved to `Iterator::max` instead of `Ord::max`:
https://github.com/rust-analyzer/rust-analyzer/blob/
8aa10c00a4c5b957d459fac5a103cd9688e8dcdd /crates/expect/src/lib.rs#L263
(I have no idea why it thinks that `usize` is an `Iterator`)
TODO:
* [x] Tests
* [x] Improve diagnostic text for method calls
Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
Jonas Schievink [Thu, 9 Jul 2020 15:33:49 +0000 (17:33 +0200)]
Address review comments
bors[bot] [Thu, 9 Jul 2020 14:19:14 +0000 (14:19 +0000)]
Merge #5282
5282: Move diagnostics tests to expect r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 9 Jul 2020 14:12:53 +0000 (16:12 +0200)]
Always put config first
Aleksey Kladov [Thu, 9 Jul 2020 14:04:29 +0000 (16:04 +0200)]
Move diagnostics tests to expect
Jonas Schievink [Thu, 9 Jul 2020 13:52:10 +0000 (15:52 +0200)]
Add tests
Jonas Schievink [Thu, 9 Jul 2020 13:51:32 +0000 (15:51 +0200)]
Fix diagnostic for method calls
Jonas Schievink [Thu, 9 Jul 2020 13:50:53 +0000 (15:50 +0200)]
Correctly pluralize message
Jonas Schievink [Thu, 9 Jul 2020 13:50:35 +0000 (15:50 +0200)]
Remove unnecessary DiagnosticSink handlers
Aleksey Kladov [Thu, 9 Jul 2020 13:41:13 +0000 (15:41 +0200)]
Add fixmes
Aleksey Kladov [Thu, 9 Jul 2020 13:35:52 +0000 (15:35 +0200)]
Simplify
Aleksey Kladov [Thu, 9 Jul 2020 13:34:37 +0000 (15:34 +0200)]
Cleanup diagnostic conversion code
bors[bot] [Thu, 9 Jul 2020 12:45:24 +0000 (12:45 +0000)]
Merge #5281
5281: Remove insta from ra_ide r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 9 Jul 2020 12:33:57 +0000 (14:33 +0200)]
Remove insta from ra_ide
Aleksey Kladov [Thu, 9 Jul 2020 12:33:03 +0000 (14:33 +0200)]
Cleanup diagnostics tests
Aleksey Kladov [Thu, 9 Jul 2020 11:59:49 +0000 (13:59 +0200)]
Reduce code duplication
Jonas Schievink [Thu, 9 Jul 2020 10:41:35 +0000 (12:41 +0200)]
Don't emit diagnostic if there are type errors
Jonas Schievink [Wed, 8 Jul 2020 17:58:45 +0000 (19:58 +0200)]
Add argument count mismatch diagnostic
bors[bot] [Thu, 9 Jul 2020 10:15:20 +0000 (10:15 +0000)]
Merge #5280
5280: Re-enable IDE features for incomplete impl blocs r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 9 Jul 2020 10:14:26 +0000 (12:14 +0200)]
Re-enable IDE features for incomplete impl blocs
bors[bot] [Thu, 9 Jul 2020 09:48:40 +0000 (09:48 +0000)]
Merge #5279
5279: Simplify r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 9 Jul 2020 09:47:27 +0000 (11:47 +0200)]
Simplify
bors[bot] [Thu, 9 Jul 2020 09:01:45 +0000 (09:01 +0000)]
Merge #5278
5278: expect should be a dev dep r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 9 Jul 2020 08:59:41 +0000 (10:59 +0200)]
expect should be a dev dep
Aleksey Kladov [Thu, 9 Jul 2020 08:58:56 +0000 (10:58 +0200)]
Unify tests
bors[bot] [Thu, 9 Jul 2020 08:34:12 +0000 (08:34 +0000)]
Merge #5276
5276: Streamline r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>