From: bors Date: Mon, 15 Aug 2016 15:35:18 +0000 (-0700) Subject: Auto merge of #35340 - michaelwoerister:incr-comp-cli-args, r=nikomatsakis X-Git-Url: https://git.lizzy.rs/?a=commitdiff_plain;h=f65d96fe3fa3cfae2cfc88be40f7416a22c88bf2;p=rust.git Auto merge of #35340 - michaelwoerister:incr-comp-cli-args, r=nikomatsakis Take commandline arguments into account for incr. comp. Implements the conservative strategy described in https://github.com/rust-lang/rust/issues/33727. From now one, every time a new commandline option is added, one has to specify if it influences the incremental compilation cache. I've tried to implement this as automatic as possible: One just has to added either the `[TRACKED]` or the `[UNTRACKED]` marker next to the field. The `Options`, `CodegenOptions`, and `DebuggingOptions` definitions in `session::config` show plenty of examples. The PR removes some cruft from `session::config::Options`, mostly unnecessary copies of flags also present in `DebuggingOptions` or `CodeGenOptions` in the same struct. One notable removal is the `cfg` field that contained the values passed via `--cfg` commandline arguments. I chose to remove it because (1) its content is only a subset of what later is stored in `hir::Crate::config` and it's pretty likely that reading the cfgs from `Options` would not be what you wanted, and (2) we could not incorporate it into the dep-tracking hash of the `Options` struct because of how the test framework works, leaving us with a piece of untracked but vital data. It is now recommended (just as before) to access the crate config via the `krate()` method in the HIR map. Because the `cfg` field is not present in the `Options` struct any more, some methods in the `CompilerCalls` trait now take the crate config as an explicit parameter -- which might constitute a breaking change for plugin authors. --- f65d96fe3fa3cfae2cfc88be40f7416a22c88bf2