From: Oliver Scherer <github35764891676564198441@oli-obk.de>
Date: Tue, 18 Dec 2018 08:42:46 +0000 (+0100)
Subject: Explain that lack of short circuiting support in constants is temporary
X-Git-Url: https://git.lizzy.rs/?a=commitdiff_plain;h=d815e2b870793e8793900be0aeb8ccaf5e4c7291;p=rust.git

Explain that lack of short circuiting support in constants is temporary
---

diff --git a/src/librustc_mir/transform/qualify_consts.rs b/src/librustc_mir/transform/qualify_consts.rs
index 10d14c1e412..cd6a9e98e8d 100644
--- a/src/librustc_mir/transform/qualify_consts.rs
+++ b/src/librustc_mir/transform/qualify_consts.rs
@@ -1348,7 +1348,10 @@ fn run_pass<'a, 'tcx>(&self,
                     for (span, kind) in mir.control_flow_destroyed.iter() {
                         error.span_note(
                             *span,
-                            &format!("use of {} here", kind),
+                            &format!("use of {} here does not actually short circuit due to \
+                            the const evaluator presently not being able to do control flow. \
+                            See https://github.com/rust-lang/rust/issues/49146 for more \
+                            information.", kind),
                         );
                     }
                     for local in locals {
diff --git a/src/test/ui/consts/const_short_circuit.stderr b/src/test/ui/consts/const_short_circuit.stderr
index 80713442706..a67bb0b1b6d 100644
--- a/src/test/ui/consts/const_short_circuit.stderr
+++ b/src/test/ui/consts/const_short_circuit.stderr
@@ -4,7 +4,7 @@ error: new features like let bindings are not permitted in constants which also
 LL |     let mut x = true && false;
    |         ^^^^^
    |
-note: use of `&&` operator here
+note: use of `&&` operator here does not actually short circuit due to the const evaluator presently not being able to do control flow. See https://github.com/rust-lang/rust/issues/49146 for more information.
   --> $DIR/const_short_circuit.rs:6:22
    |
 LL |     let mut x = true && false;
@@ -16,7 +16,7 @@ error: new features like let bindings are not permitted in constants which also
 LL |     let x = true && false;
    |         ^
    |
-note: use of `&&` operator here
+note: use of `&&` operator here does not actually short circuit due to the const evaluator presently not being able to do control flow. See https://github.com/rust-lang/rust/issues/49146 for more information.
   --> $DIR/const_short_circuit.rs:11:18
    |
 LL |     let x = true && false;