From: Lymia Aluysia Date: Mon, 30 Mar 2020 13:41:58 +0000 (-0700) Subject: Merge pull request #13 from epavese/insert_return_consistent X-Git-Url: https://git.lizzy.rs/?a=commitdiff_plain;h=d5d88c8f738629c64cd9e2281f81d923c76d254b;p=enumset.git Merge pull request #13 from epavese/insert_return_consistent return value for insert() was inconsistent with std sets --- d5d88c8f738629c64cd9e2281f81d923c76d254b diff --cc enumset/src/lib.rs index d97054e,66f605f..b04aa1c --- a/enumset/src/lib.rs +++ b/enumset/src/lib.rs @@@ -357,12 -342,8 +357,12 @@@ impl EnumSet } /// Adds a value to this set. + /// + /// If the set did not have this value present, `false` is returned. + /// + /// If the set did have this value present, `true` is returned. pub fn insert(&mut self, value: T) -> bool { - let contains = self.contains(value); + let contains = !self.contains(value); self.__enumset_underlying = self.__enumset_underlying | Self::mask(value.enum_into_u8()); contains }