From: Richard Diamond <wichard@vitalitystudios.com>
Date: Mon, 7 Sep 2015 00:26:41 +0000 (-0500)
Subject: Don't add unnamed address attributes to intrinsics.
X-Git-Url: https://git.lizzy.rs/?a=commitdiff_plain;h=ba72d9722caf48ad5f184d4da61117f80d98761e;p=rust.git

Don't add unnamed address attributes to intrinsics.

Intrinsics never have an address, so it doesn't make sense to say that their
address is unnamed.
---

diff --git a/src/librustc_trans/trans/context.rs b/src/librustc_trans/trans/context.rs
index fd8dbe83add..75874963f5f 100644
--- a/src/librustc_trans/trans/context.rs
+++ b/src/librustc_trans/trans/context.rs
@@ -798,6 +798,7 @@ macro_rules! ifn {
             if key == $name {
                 let f = declare::declare_cfn(ccx, $name, Type::func(&[], &$ret),
                                              ccx.tcx().mk_nil());
+                llvm::SetUnnamedAddr(f, false);
                 ccx.intrinsics().borrow_mut().insert($name, f.clone());
                 return Some(f);
             }
@@ -806,6 +807,7 @@ macro_rules! ifn {
             if key == $name {
                 let f = declare::declare_cfn(ccx, $name, Type::func(&[$($arg),*], &$ret),
                                              ccx.tcx().mk_nil());
+                llvm::SetUnnamedAddr(f, false);
                 ccx.intrinsics().borrow_mut().insert($name, f.clone());
                 return Some(f);
             }
diff --git a/src/test/codegen/intrinsic-no-unnamed-attr.rs b/src/test/codegen/intrinsic-no-unnamed-attr.rs
new file mode 100644
index 00000000000..0f239c84265
--- /dev/null
+++ b/src/test/codegen/intrinsic-no-unnamed-attr.rs
@@ -0,0 +1,22 @@
+// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+// compile-flags: -C no-prepopulate-passes
+
+#![feature(intrinsics)]
+
+extern "rust-intrinsic" {
+    fn sqrtf32(x: f32) -> f32;
+}
+// CHECK: @llvm.sqrt.f32(float) #{{[0-9]*}}
+
+fn main() {
+    unsafe { sqrtf32(0.0f32); }
+}