From: rubenwardy <rw@rubenwardy.com>
Date: Wed, 16 Sep 2020 21:19:14 +0000 (+0100)
Subject: Fix broken state comparison due to enum ordering
X-Git-Url: https://git.lizzy.rs/?a=commitdiff_plain;h=a1e0e37223436b9d1c65d6f75251faf5226f2f79;p=cheatdb.git

Fix broken state comparison due to enum ordering
---

diff --git a/app/blueprints/todo/__init__.py b/app/blueprints/todo/__init__.py
index d0903b9..b9f2081 100644
--- a/app/blueprints/todo/__init__.py
+++ b/app/blueprints/todo/__init__.py
@@ -20,6 +20,7 @@ import flask_menu as menu
 from app.models import *
 from app.querybuilder import QueryBuilder
 from app.utils import get_int_or_abort
+from sqlalchemy import or_
 
 bp = Blueprint("todo", __name__)
 
@@ -35,7 +36,7 @@ def view():
 	if canApproveNew:
 		packages = Package.query.filter_by(state=PackageState.READY_FOR_REVIEW) \
 			.order_by(db.desc(Package.created_at)).all()
-		wip_packages = Package.query.filter(Package.state<PackageState.READY_FOR_REVIEW) \
+		wip_packages = Package.query.filter(or_(Package.state==PackageState.WIP, Package.state==PackageState.CHANGES_NEEDED)) \
 			.order_by(db.desc(Package.created_at)).all()
 
 	releases = None