From: bors <bors@rust-lang.org>
Date: Thu, 11 Feb 2016 22:22:54 +0000 (+0000)
Subject: Auto merge of #31545 - dotdash:no_noalias, r=alexcrichton
X-Git-Url: https://git.lizzy.rs/?a=commitdiff_plain;h=98ec51a4ddc5519f809d667e7dbbf636d59ab653;p=rust.git

Auto merge of #31545 - dotdash:no_noalias, r=alexcrichton

LLVM's memory dependence analysis doesn't properly account for calls
that could unwind and thus effectively act as a branching point. This
can lead to stores that are only visible when the call unwinds being
removed, possibly leading to calls to drop() functions with b0rked
memory contents.

As there is no fix for this in LLVM yet and we want to keep
compatibility to current LLVM versions anyways, we have to workaround
this bug by omitting the noalias attribute on &mut function arguments.
Benchmarks suggest that the performance loss by this change is very
small.

Thanks to @RalfJung for pushing me towards not removing too many
noalias annotations and @alexcrichton for helping out with the test for
this bug.

Fixes #29485
---

98ec51a4ddc5519f809d667e7dbbf636d59ab653